[jira] [Commented] (CB-7684) [Media] CDVSound Kills any and all playing sound files when a single file finishes

2018-01-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310807#comment-16310807
 ] 

ASF GitHub Bot commented on CB-7684:


kaynz commented on issue #100: CB-7684: (iOS) Fix CDVSound killing all audio 
when a single file finishes
URL: 
https://github.com/apache/cordova-plugin-media/pull/100#issuecomment-355207080
 
 
   @damienleroux Pretty sure it's an environment bug and has nothing to do with 
your commit: 
https://travis-ci.org/apache/cordova-plugin-media/jobs/324476963#L1534


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Media] CDVSound Kills any and all playing sound files when a single file 
> finishes
> --
>
> Key: CB-7684
> URL: https://issues.apache.org/jira/browse/CB-7684
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-media
>Affects Versions: 3.5.0
> Environment: iOS
>Reporter: Nathan Stryker
>
> The CDVSound file will kill all playing media files when ever a single file 
> completes playing. The issue is around like 691 in the method 
> "AudioDidFinishPlaying", with the code:
> if (self.avSession) {
> [self.avSession setActive:NO error:nil];
> }
> The reason I think this is a bug is that if a user as Music file A playing in 
> a loop and Music file B plays, when B completes the "setActive:NO" will kill 
> the avSession of both A and B. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13396) Splash screen images are resized incorrectly on iPhone X

2018-01-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310559#comment-16310559
 ] 

ASF GitHub Bot commented on CB-13396:
-

iisdan commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-355174454
 
 
   This is important, eta on merge? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> 
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
>Reporter: Ken Mickles
>  Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13729) Cordova platform add inconsistency between config.xml and package.json

2018-01-03 Thread jcesarmobile (JIRA) 
jcesarmobile created CB-13729:
-

 Summary: Cordova platform add inconsistency between config.xml and 
package.json
 Key: CB-13729
 URL: https://issues.apache.org/jira/browse/CB-13729
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-cli
Affects Versions: cordova@8.0.0
Reporter: jcesarmobile


I had save-prefix='^' for npm, but cordova platform add platformName was saved 
with ^ in package.json, but with ~ in config.xml

Both of them should use the save-prefix preference

cordova plugin add works as expected, it uses the same on both package.json and 
config.xml respecting the save-prefix preference



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13353) Support --save-exact for plugins/platforms

2018-01-03 Thread jcesarmobile (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310386#comment-16310386
 ] 

jcesarmobile commented on CB-13353:
---

Testing with node v8.9.1, npm 5.5.1 and Cordova CLI 8.0.0

This two commands save in both package.json and config.xml as ^4.0.1
cordova plugin add cordova-plugin-geolocation --save-exact
cordova plugin add cordova-plugin-geolocation@4.0.1 --save-exact


> Support --save-exact for plugins/platforms
> --
>
> Key: CB-13353
> URL: https://issues.apache.org/jira/browse/CB-13353
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Affects Versions: cordova@7.0.0
>Reporter: Mike Hartington
>Assignee: Audrey So
>Priority: Minor
>  Labels: beginner, easy-fix
>
> Adding a plugin or platform and passing a version will still add a {{^}} or 
> {{~}} to the config.xml/package.json when installing. Since under the hood, 
> npm is handling things, there should be support for the {{--save-exact}} flag 
> as well.  [~stevegill]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13728) Types are not loaded into angular typescript project

2018-01-03 Thread Dmitriy (JIRA) 
Dmitriy created CB-13728:


 Summary: Types are not loaded into angular typescript project
 Key: CB-13728
 URL: https://issues.apache.org/jira/browse/CB-13728
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-plugin-camera
Affects Versions: cordova-android-7.0.0
 Environment: MacOS High Sierra
npm -v 
5.6.0

node -v 
v8.4.0

typescript 2.5.3
Reporter: Dmitriy
Priority: Critical


When installing cordova-plugin-camera package via npm, types are not properly 
loaded in angular2 application:

When trying to build or serve receiving such error:

ERROR in error TS2688: Cannot find type definition file for '.github'.
error TS2688: Cannot find type definition file for 'appium-tests'.
error TS2688: Cannot find type definition file for 'doc'.
error TS2688: Cannot find type definition file for 'jsdoc2md'.
error TS2688: Cannot find type definition file for 'src'.
error TS2688: Cannot find type definition file for 'tests'.
error TS2688: Cannot find type definition file for 'www'.
src/app/components/myprofile/photo-upload-modal/photo-upload-modal.component.ts(26,19):
 error TS2339: Property 'camera' does not exist on type 'Navigator'.
src/app/components/myprofile/photo-upload-modal/photo-upload-modal.component.ts(29,69):
 error TS2304: Cannot find name 'Camera'.
src/app/components/myprofile/photo-upload-modal/photo-upload-modal.component.ts(29,103):
 error TS2304: Cannot find name 'Camera'.
src/app/components/myprofile/photo-upload-modal/photo-upload-modal.component.ts(31,29):
 error TS2304: Cannot find name 'Camera'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13727) aaa

2018-01-03 Thread anto (JIRA) 
anto created CB-13727:
-

 Summary: aaa
 Key: CB-13727
 URL: https://issues.apache.org/jira/browse/CB-13727
 Project: Apache Cordova
  Issue Type: Test
Reporter: anto
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13726) New app shouldn't contain icons and splash for deprecated platforms

2018-01-03 Thread jcesarmobile (JIRA) 
jcesarmobile created CB-13726:
-

 Summary: New app shouldn't contain icons and splash for deprecated 
platforms
 Key: CB-13726
 URL: https://issues.apache.org/jira/browse/CB-13726
 Project: Apache Cordova
  Issue Type: Bug
Affects Versions: cordova@8.0.0
Reporter: jcesarmobile


I've created a new project and it contains a res folder with an icon and a 
screen folder. Each of them contain icons and splash screens for deprecated 
platforms such as bada, blackberry, tizen, etc.

A new project shouldn't contain deprecated platforms resources.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-12218) inconsistent null handling between EVAL and ONLINE bridge modes

2018-01-03 Thread Joe Bowser (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser resolved CB-12218.
-
Resolution: Fixed

> inconsistent null handling between EVAL and ONLINE bridge modes
> ---
>
> Key: CB-12218
> URL: https://issues.apache.org/jira/browse/CB-12218
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: 6.0.0
> Environment: Android
>Reporter: Alan Kinzie
>Assignee: Joe Bowser
> Attachments: CB12218.zip
>
>
> If the Android native code invokes the success callback like this:
> callbackContext.success(null);
> then the value given to the javascript callback changes depending on the 
> bridge type used.
> If the ONLINE_EVENT type is used, then null will be passed to the javascript 
> callback.
> ie: if result is the parameter of the javascript success callback then
> result === null  // will be true
> result === "" // will be false
> If the EVAL_BRIDGE type is used, then an empty string will be passed to the 
> javascript callback.
> ie: if result is the parameter of the javascript success callback then
> result === null  // will be false
> result === "" // will be true
> The value of the parameter given to the success callback should not change 
> depending on the bridge type.  Since ONLINE_EVENT was the default before 
> cordova android 6.0.0, I am inclined to think the ONLINE bridge is doing the 
> correct behaviour.  Also, converting null to an empty string loses 
> information.  Therefore I think the EVAL mode should to be changed to be 
> consistent with the ONLINE mode.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12218) inconsistent null handling between EVAL and ONLINE bridge modes

2018-01-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310142#comment-16310142
 ] 

ASF GitHub Bot commented on CB-12218:
-

infil00p commented on issue #425: CB-12218: (android) Fix consistency of null 
result message
URL: https://github.com/apache/cordova-android/pull/425#issuecomment-355102549
 
 
   LGTM, Merging!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> inconsistent null handling between EVAL and ONLINE bridge modes
> ---
>
> Key: CB-12218
> URL: https://issues.apache.org/jira/browse/CB-12218
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: 6.0.0
> Environment: Android
>Reporter: Alan Kinzie
>Assignee: Joe Bowser
> Attachments: CB12218.zip
>
>
> If the Android native code invokes the success callback like this:
> callbackContext.success(null);
> then the value given to the javascript callback changes depending on the 
> bridge type used.
> If the ONLINE_EVENT type is used, then null will be passed to the javascript 
> callback.
> ie: if result is the parameter of the javascript success callback then
> result === null  // will be true
> result === "" // will be false
> If the EVAL_BRIDGE type is used, then an empty string will be passed to the 
> javascript callback.
> ie: if result is the parameter of the javascript success callback then
> result === null  // will be false
> result === "" // will be true
> The value of the parameter given to the success callback should not change 
> depending on the bridge type.  Since ONLINE_EVENT was the default before 
> cordova android 6.0.0, I am inclined to think the ONLINE bridge is doing the 
> correct behaviour.  Also, converting null to an empty string loses 
> information.  Therefore I think the EVAL mode should to be changed to be 
> consistent with the ONLINE mode.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12218) inconsistent null handling between EVAL and ONLINE bridge modes

2018-01-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310145#comment-16310145
 ] 

ASF subversion and git services commented on CB-12218:
--

Commit 45a7b90c6c1d22291261ccd58e8e3e159a1a1ca6 in cordova-android's branch 
refs/heads/master from [~deton]
[ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=45a7b90 ]

CB-12218: (android) Fix consistency of null result message

Fix problem that JavaScript receives ""(empty string) instead of null
if plugin sends null result from new thread.


> inconsistent null handling between EVAL and ONLINE bridge modes
> ---
>
> Key: CB-12218
> URL: https://issues.apache.org/jira/browse/CB-12218
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: 6.0.0
> Environment: Android
>Reporter: Alan Kinzie
>Assignee: Joe Bowser
> Attachments: CB12218.zip
>
>
> If the Android native code invokes the success callback like this:
> callbackContext.success(null);
> then the value given to the javascript callback changes depending on the 
> bridge type used.
> If the ONLINE_EVENT type is used, then null will be passed to the javascript 
> callback.
> ie: if result is the parameter of the javascript success callback then
> result === null  // will be true
> result === "" // will be false
> If the EVAL_BRIDGE type is used, then an empty string will be passed to the 
> javascript callback.
> ie: if result is the parameter of the javascript success callback then
> result === null  // will be false
> result === "" // will be true
> The value of the parameter given to the success callback should not change 
> depending on the bridge type.  Since ONLINE_EVENT was the default before 
> cordova android 6.0.0, I am inclined to think the ONLINE bridge is doing the 
> correct behaviour.  Also, converting null to an empty string loses 
> information.  Therefore I think the EVAL mode should to be changed to be 
> consistent with the ONLINE mode.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12218) inconsistent null handling between EVAL and ONLINE bridge modes

2018-01-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310144#comment-16310144
 ] 

ASF GitHub Bot commented on CB-12218:
-

infil00p closed pull request #425: CB-12218: (android) Fix consistency of null 
result message
URL: https://github.com/apache/cordova-android/pull/425
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/framework/src/org/apache/cordova/NativeToJsMessageQueue.java 
b/framework/src/org/apache/cordova/NativeToJsMessageQueue.java
index a8f59fad9..d17b1c43a 100755
--- a/framework/src/org/apache/cordova/NativeToJsMessageQueue.java
+++ b/framework/src/org/apache/cordova/NativeToJsMessageQueue.java
@@ -511,6 +511,9 @@ void buildJsMessage(StringBuilder sb) {
 .append(pluginResult.getMessage())
 .append("')");
 break;
+case PluginResult.MESSAGE_TYPE_NULL:
+sb.append("null");
+break;
 default:
 sb.append(pluginResult.getMessage());
 }
diff --git 
a/test/app/src/test/java/org/apache/cordova/unittests/NativeToJsMessageQueueTest.java
 
b/test/app/src/test/java/org/apache/cordova/unittests/NativeToJsMessageQueueTest.java
index e52789494..dc7bb6725 100644
--- 
a/test/app/src/test/java/org/apache/cordova/unittests/NativeToJsMessageQueueTest.java
+++ 
b/test/app/src/test/java/org/apache/cordova/unittests/NativeToJsMessageQueueTest.java
@@ -161,4 +161,17 @@ public void testMultipartPopAndEncodeAsJs()
 assertEquals(result, 
"cordova.callbackFromNative('37',true,1,[0,1,2,3,4],false);");
 }
 
+@Test
+public void testNullPopAndEncodeAsJs()
+{
+NativeToJsMessageQueue queue = new NativeToJsMessageQueue();
+queue.addBridgeMode(new NativeToJsMessageQueue.NoOpBridgeMode());
+queue.setBridgeMode(0);
+
+PluginResult result = new PluginResult(PluginResult.Status.OK, 
(String)null);
+queue.addPluginResult(result, TEST_CALLBACK_ID);
+assertFalse(queue.isEmpty());
+String resultString = queue.popAndEncodeAsJs();
+assertEquals(resultString, "cordova.callbackFromNative('" + 
TEST_CALLBACK_ID + "',true,1,[null],false);");
+}
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> inconsistent null handling between EVAL and ONLINE bridge modes
> ---
>
> Key: CB-12218
> URL: https://issues.apache.org/jira/browse/CB-12218
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: 6.0.0
> Environment: Android
>Reporter: Alan Kinzie
>Assignee: Joe Bowser
> Attachments: CB12218.zip
>
>
> If the Android native code invokes the success callback like this:
> callbackContext.success(null);
> then the value given to the javascript callback changes depending on the 
> bridge type used.
> If the ONLINE_EVENT type is used, then null will be passed to the javascript 
> callback.
> ie: if result is the parameter of the javascript success callback then
> result === null  // will be true
> result === "" // will be false
> If the EVAL_BRIDGE type is used, then an empty string will be passed to the 
> javascript callback.
> ie: if result is the parameter of the javascript success callback then
> result === null  // will be false
> result === "" // will be true
> The value of the parameter given to the success callback should not change 
> depending on the bridge type.  Since ONLINE_EVENT was the default before 
> cordova android 6.0.0, I am inclined to think the ONLINE bridge is doing the 
> correct behaviour.  Also, converting null to an empty string loses 
> information.  Therefore I think the EVAL mode should to be changed to be 
> consistent with the ONLINE mode.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12218) inconsistent null handling between EVAL and ONLINE bridge modes

2018-01-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310147#comment-16310147
 ] 

ASF subversion and git services commented on CB-12218:
--

Commit fcf705e00749f39b93223eacb31b2c2a2e120d1a in cordova-android's branch 
refs/heads/master from [~bowserj]
[ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=fcf705e ]

Merge pull request #425 from deton/fix-nullresult-fromthread

CB-12218: (android) Fix consistency of null result message

> inconsistent null handling between EVAL and ONLINE bridge modes
> ---
>
> Key: CB-12218
> URL: https://issues.apache.org/jira/browse/CB-12218
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: 6.0.0
> Environment: Android
>Reporter: Alan Kinzie
>Assignee: Joe Bowser
> Attachments: CB12218.zip
>
>
> If the Android native code invokes the success callback like this:
> callbackContext.success(null);
> then the value given to the javascript callback changes depending on the 
> bridge type used.
> If the ONLINE_EVENT type is used, then null will be passed to the javascript 
> callback.
> ie: if result is the parameter of the javascript success callback then
> result === null  // will be true
> result === "" // will be false
> If the EVAL_BRIDGE type is used, then an empty string will be passed to the 
> javascript callback.
> ie: if result is the parameter of the javascript success callback then
> result === null  // will be false
> result === "" // will be true
> The value of the parameter given to the success callback should not change 
> depending on the bridge type.  Since ONLINE_EVENT was the default before 
> cordova android 6.0.0, I am inclined to think the ONLINE bridge is doing the 
> correct behaviour.  Also, converting null to an empty string loses 
> information.  Therefore I think the EVAL mode should to be changed to be 
> consistent with the ONLINE mode.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7684) [Media] CDVSound Kills any and all playing sound files when a single file finishes

2018-01-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310021#comment-16310021
 ] 

ASF GitHub Bot commented on CB-7684:


damienleroux commented on issue #100: CB-7684: (iOS) Fix CDVSound killing all 
audio when a single file finishes
URL: 
https://github.com/apache/cordova-plugin-media/pull/100#issuecomment-355086234
 
 
   @adriano-di-giovanni. I can't say if you made mistakes or not. Besides, 
@macdonst, my PR 
[#162](https://github.com/apache/cordova-plugin-media/pull/162) seems to fail 
travis integration tests but don't know why.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Media] CDVSound Kills any and all playing sound files when a single file 
> finishes
> --
>
> Key: CB-7684
> URL: https://issues.apache.org/jira/browse/CB-7684
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-media
>Affects Versions: 3.5.0
> Environment: iOS
>Reporter: Nathan Stryker
>
> The CDVSound file will kill all playing media files when ever a single file 
> completes playing. The issue is around like 691 in the method 
> "AudioDidFinishPlaying", with the code:
> if (self.avSession) {
> [self.avSession setActive:NO error:nil];
> }
> The reason I think this is a bug is that if a user as Music file A playing in 
> a loop and Music file B plays, when B completes the "setActive:NO" will kill 
> the avSession of both A and B. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-13725) Circular module dependency

2018-01-03 Thread Jake Degiovanni (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Degiovanni updated CB-13725:
-
Environment: 
h4. +Target OS Affected+
* Blackberry10
* Seemingly every other platform that has not been updated to the PlatformAPI 
(in this scenario every platform marked deprecated)

h4. +Cordova Version+
* 7.1.0

h4. +Host Operating System+
* Ubuntu Xenial docker container running on Windows 10
* Ubuntu 14.04 LTS

h4. +NodeJS Version+
* v6.10.2 LTS
* v8.9.4 LTS

  was:
+Target OS Affected+
* Blackberry10
* Seemingly every other platform that has not been updated to the PlatformAPI 
(in this scenario every platform marked deprecated)

+Cordova Version+
* 7.1.0

+Host Operating System+
* Ubuntu Xenial docker container running on Windows 10
* Ubuntu 14.04 LTS

+NodeJS Version+
* v6.10.2 LTS
* v8.9.4 LTS


> Circular module dependency
> --
>
> Key: CB-13725
> URL: https://issues.apache.org/jira/browse/CB-13725
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-lib
>Affects Versions: 7.0.0
> Environment: h4. +Target OS Affected+
> * Blackberry10
> * Seemingly every other platform that has not been updated to the PlatformAPI 
> (in this scenario every platform marked deprecated)
> h4. +Cordova Version+
> * 7.1.0
> h4. +Host Operating System+
> * Ubuntu Xenial docker container running on Windows 10
> * Ubuntu 14.04 LTS
> h4. +NodeJS Version+
> * v6.10.2 LTS
> * v8.9.4 LTS
>Reporter: Jake Degiovanni
>  Labels: blackberry10, bug, question, ubuntu
> Fix For: 7.0.0
>
>
> There is a circular dependency within the util.js file (src/cordova/util.js) 
> and the platforms.js file (src/platforms/platforms.js).
> This circular dependency causes the platforms variable to equal an empty 
> JavaScript object ({}); as a result when within the getPlatformApiFunction 
> the else condition !platforms[platform] on line 498 is always trigerred 
> causing deprecated platforms to always fail upon attempted addition to the 
> project.
> This bug also seems to affect the hostSupports function on line 94.
> Can someone more versed in this components inner workings confirm if this is 
> indeed a bug? I would be happy to attempt a fix if it is but would need to 
> discuss my idea for a potential fix with a more experienced dev first to 
> ensure I don't break hidden dependencies.
> Potential fix:
> On line 30 change var platforms = require('../platforms/platforms'); to var 
> platforms = require('../platforms/platformsConfig.json');



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13725) Circular module dependency

2018-01-03 Thread Jake Degiovanni (JIRA) 
Jake Degiovanni created CB-13725:


 Summary: Circular module dependency
 Key: CB-13725
 URL: https://issues.apache.org/jira/browse/CB-13725
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-lib
Affects Versions: 7.0.0
 Environment: +Target OS Affected+
* Blackberry10
* Seemingly every other platform that has not been updated to the PlatformAPI 
(in this scenario every platform marked deprecated)

+Cordova Version+
* 7.1.0

+Host Operating System+
* Ubuntu Xenial docker container running on Windows 10
* Ubuntu 14.04 LTS

+NodeJS Version+
* v6.10.2 LTS
* v8.9.4 LTS
Reporter: Jake Degiovanni
 Fix For: 7.0.0


There is a circular dependency within the util.js file (src/cordova/util.js) 
and the platforms.js file (src/platforms/platforms.js).

This circular dependency causes the platforms variable to equal an empty 
JavaScript object ({}); as a result when within the getPlatformApiFunction the 
else condition !platforms[platform] on line 498 is always trigerred causing 
deprecated platforms to always fail upon attempted addition to the project.

This bug also seems to affect the hostSupports function on line 94.

Can someone more versed in this components inner workings confirm if this is 
indeed a bug? I would be happy to attempt a fix if it is but would need to 
discuss my idea for a potential fix with a more experienced dev first to ensure 
I don't break hidden dependencies.

Potential fix:

On line 30 change var platforms = require('../platforms/platforms'); to var 
platforms = require('../platforms/platformsConfig.json');



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-13721) Can't build Android app if it has a plugin that uses cdvHelpers.getConfigPreference

2018-01-03 Thread jcesarmobile (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-13721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile resolved CB-13721.
---
Resolution: Fixed

Fixed in 7.1.0-dev

> Can't build Android app if it has a plugin that uses 
> cdvHelpers.getConfigPreference
> ---
>
> Key: CB-13721
> URL: https://issues.apache.org/jira/browse/CB-13721
> Project: Apache Cordova
>  Issue Type: Bug
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>
> If you create an app and add a plugin which has a gradle file with 
> cdvHelpers.getConfigPreference the app wont' build.
> Example, add this plugin:
> cordova plugin add cordova-plugin-navitia-sdk-ux



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13723) Tie in to Coraline for Linux support

2018-01-03 Thread jcesarmobile (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309872#comment-16309872
 ] 

jcesarmobile commented on CB-13723:
---

For better visibility you should probably send a mail to 
d...@cordova.apache.org telling about your project

> Tie in to Coraline for Linux support
> 
>
> Key: CB-13723
> URL: https://issues.apache.org/jira/browse/CB-13723
> Project: Apache Cordova
>  Issue Type: Task
>  Components: cordova-cli
> Environment: Linux
>Reporter: Pat Deegan
>Priority: Minor
>  Labels: platforms
>
> Cordova-ubuntu is out and left me high and dry with respect to Linux versions 
> of my cordova apps.  
> So I've created a system to run cordova (and ionic) applications on linux, 
> with plugins to bridge JS to the host.  You can get more info/see a short 
> demo on the [Coraline project site|https://coraline.psychogenic.com].
> How Coraline differs from cordova-ubuntu:
> * it doesn't rely on the ubuntu-sdk, of course, or Qt--it's straight up C++, 
> though plugins *can* use Qt;
> * in theory, it runs on _any_ flavour of Linux;
> * plugins are dynamically loadable, and shared (though there are facilities 
> for app-specific plugins);
> * because of the above point, apps don't actually need to be *compiled* -- 
> you just need a directory with all the html/js/resources, massaged 
> appropriately to get rid of the Node stuff.
> At this point, the _src/ubuntu_ directories for cordova plugins have started 
> disappearing, which is a shame--I've put wrappers around a few, like the 
> device and sqlite plugins, and am working on a way to make transition from 
> cordova-ubuntu to coraline a simple affair for the plugins.
> The hardest part at this stage is migrating the existing plugin JS--though 
> the APIs for coraline plugins are all identical (that's the point of cordova, 
> after all), I'm uncertain how cordova did the magic when it comes to 
> integrating the plugins' JS module exports stuff into the final apps, so I've 
> been doing it manual style (slow).
> What I'd like from you guys is:
> * an idea of what to do/where to look to make integration of a new "linux" 
> platform possible with the cordova CLI;
> * pointers to what I'd need to produce and do in order to get Linux/Coraline 
> support into cordova; 
> * any input you might have on how I might make the system better.
> and anything else you'd like to add to get the ball rolling on having actual 
> Linux support for cordova.
> Please don't hesitate with any questions.
> Thanks,
> Pat Deegan



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7684) [Media] CDVSound Kills any and all playing sound files when a single file finishes

2018-01-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309870#comment-16309870
 ] 

ASF GitHub Bot commented on CB-7684:


adriano-di-giovanni commented on issue #100: CB-7684: (iOS) Fix CDVSound 
killing all audio when a single file finishes
URL: 
https://github.com/apache/cordova-plugin-media/pull/100#issuecomment-355055346
 
 
   @damienleroux It's the #143. Did I make any mistakes? I think it's a valid 
alternative to the one from @tbrebant. It's also backward compatible. Please, 
let me know.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Media] CDVSound Kills any and all playing sound files when a single file 
> finishes
> --
>
> Key: CB-7684
> URL: https://issues.apache.org/jira/browse/CB-7684
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-media
>Affects Versions: 3.5.0
> Environment: iOS
>Reporter: Nathan Stryker
>
> The CDVSound file will kill all playing media files when ever a single file 
> completes playing. The issue is around like 691 in the method 
> "AudioDidFinishPlaying", with the code:
> if (self.avSession) {
> [self.avSession setActive:NO error:nil];
> }
> The reason I think this is a bug is that if a user as Music file A playing in 
> a loop and Music file B plays, when B completes the "setActive:NO" will kill 
> the avSession of both A and B. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7684) [Media] CDVSound Kills any and all playing sound files when a single file finishes

2018-01-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309629#comment-16309629
 ] 

ASF GitHub Bot commented on CB-7684:


damienleroux commented on issue #100: CB-7684: (iOS) Fix CDVSound killing all 
audio when a single file finishes
URL: 
https://github.com/apache/cordova-plugin-media/pull/100#issuecomment-355008373
 
 
   @adriano-di-giovanni I didn't see you submit a PR for this issue. May be 
more relevant that the 
[commit](https://github.com/apache/cordova-plugin-media/pull/100/files) 
from@tbrebrant that solves the issue: I don't know.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Media] CDVSound Kills any and all playing sound files when a single file 
> finishes
> --
>
> Key: CB-7684
> URL: https://issues.apache.org/jira/browse/CB-7684
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-media
>Affects Versions: 3.5.0
> Environment: iOS
>Reporter: Nathan Stryker
>
> The CDVSound file will kill all playing media files when ever a single file 
> completes playing. The issue is around like 691 in the method 
> "AudioDidFinishPlaying", with the code:
> if (self.avSession) {
> [self.avSession setActive:NO error:nil];
> }
> The reason I think this is a bug is that if a user as Music file A playing in 
> a loop and Music file B plays, when B completes the "setActive:NO" will kill 
> the avSession of both A and B. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7684) [Media] CDVSound Kills any and all playing sound files when a single file finishes

2018-01-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309348#comment-16309348
 ] 

ASF GitHub Bot commented on CB-7684:


adriano-di-giovanni commented on issue #100: CB-7684: (iOS) Fix CDVSound 
killing all audio when a single file finishes
URL: 
https://github.com/apache/cordova-plugin-media/pull/100#issuecomment-354967569
 
 
   @damienleroux, @macdonst  are you talking about my #143 being merged? If so, 
I've just updated my PR to fix merge conflicts that were related to plugin.xml 
only. Please, let me know.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Media] CDVSound Kills any and all playing sound files when a single file 
> finishes
> --
>
> Key: CB-7684
> URL: https://issues.apache.org/jira/browse/CB-7684
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-media
>Affects Versions: 3.5.0
> Environment: iOS
>Reporter: Nathan Stryker
>
> The CDVSound file will kill all playing media files when ever a single file 
> completes playing. The issue is around like 691 in the method 
> "AudioDidFinishPlaying", with the code:
> if (self.avSession) {
> [self.avSession setActive:NO error:nil];
> }
> The reason I think this is a bug is that if a user as Music file A playing in 
> a loop and Music file B plays, when B completes the "setActive:NO" will kill 
> the avSession of both A and B. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Issue Comment Deleted] (CB-13009) cordova prepare unnecessarily edits config.xml and package.json

2018-01-03 Thread Christian Tschanz (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-13009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Tschanz updated CB-13009:
---
Comment: was deleted

(was: Guten Tag

Ich bin vom 18.12. bis am 02.01. in den Ferien.

Ihre Nachricht werde ich erst nach meiner Rückkehr bearbeiten können.


Bei dringenderen Angelegenheiten wenden Sie sich bitte an Nicolas Hoby: 
nicolas.h...@jls.ch

Vielen Dank

Christian Tschanz
)

> cordova prepare unnecessarily edits config.xml and package.json
> ---
>
> Key: CB-13009
> URL: https://issues.apache.org/jira/browse/CB-13009
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-cli
>Affects Versions: 7.0.1
> Environment: Mac OSX 10.12.5
> Node 8.1.2
> npm 5.0.3
>Reporter: Christian Tschanz
>Priority: Minor
>  Labels: tools-next
>
> I crafted my config.xml file by hand (and added comments) to make it more 
> readable and maintainable. I also removed all '^' or '~' from the versions of 
> the engines/plugins to fix the version to one specific one (I will manually 
> test new versions and update if possible). I also removed the '^' from the 
> package.json file it generates.
> When running 'cordova prepare' it will completely re-create the config.xml 
> file and therefore re-format it. It will also re-add the '^' to all versions. 
> It will also add the '^' to the versions in the package.json file.
> This is VERY annoying. Previous versions did not behave like this. They only 
> edited the config.xml if explicitly told to do so. I really, really want to 
> fix the versions to a specific one and don't want it to always add the '^'. I 
> would also prefer it if it the 'prepare' command would not re-create the 
> config.xml file as there is no need for that and it kills all formatting and 
> comments.
> At the moment I hope it respects the 'package-lock' file when installing 
> plugins because I can't have it install newer versions automatically. Sadly 
> many plugins are not as stable and well maintained for such an automatic 
> update to work well in large projects.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org