[jira] [Commented] (CB-11893) CocoaPods support: Provide a way to add use_frameworks! on the Podfile

2018-02-05 Thread Ilya Isupov (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353350#comment-16353350
 ] 

Ilya Isupov commented on CB-11893:
--

Hi [~shazron],

But if I need to have a dependency on swift framework, is there any way to work 
around this issue and add use_frameworks! statement to podfile? In my case 
project builds correctly if I manually modify Podfile and install pods.

Thank you!

> CocoaPods support: Provide a way to add use_frameworks! on the Podfile
> --
>
> Key: CB-11893
> URL: https://issues.apache.org/jira/browse/CB-11893
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-ios
>Reporter: jcesarmobile
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@5.0.0
>
> Attachments: Integrating Static Library With Cocoapods 
> Use_frameworks.pdf
>
>
> If the library you want to use on the plugin uses Swift or you want to use 
> dynamic frameworks you have to add use_frameworks! on the Podfile
> I don't think there is a way of adding it right now.
> We should provide a way of adding it 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-12582) Plugin's Cocoapods don't persist if another plugin is added after it

2018-02-05 Thread Kenichi Naito (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353200#comment-16353200
 ] 

Kenichi Naito edited comment on CB-12582 at 2/6/18 1:40 AM:


{code:java}
`pod install` overrides pbxproj file. Then we should purge cache file.
---
 bin/templates/scripts/cordova/Api.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/templates/scripts/cordova/Api.js 
b/bin/templates/scripts/cordova/Api.js
index dd50d11f..04da4a1b 100644
--- a/bin/templates/scripts/cordova/Api.js
+++ b/bin/templates/scripts/cordova/Api.js
@@ -285,6 +285,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) 
{
 if (podfileFile.isDirty()) {
 podfileFile.write();
 events.emit('verbose', 'Running `pod install` (to install 
plugins)');
+    projectFile.purgeProjectFileCache(self.locations.root);
 
 return podfileFile.install(check_reqs.check_cocoapods);
 } else {
--
2.14.2
{code}
 


was (Author: knaito):
{code:java}
---
 bin/templates/scripts/cordova/Api.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/templates/scripts/cordova/Api.js 
b/bin/templates/scripts/cordova/Api.js
index dd50d11f..04da4a1b 100644
--- a/bin/templates/scripts/cordova/Api.js
+++ b/bin/templates/scripts/cordova/Api.js
@@ -285,6 +285,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) 
{
 if (podfileFile.isDirty()) {
 podfileFile.write();
 events.emit('verbose', 'Running `pod install` (to install 
plugins)');
+    projectFile.purgeProjectFileCache(self.locations.root);
 
 return podfileFile.install(check_reqs.check_cocoapods);
 } else {
--
2.14.2
{code}
 

> Plugin's Cocoapods don't persist if another plugin is added after it
> 
>
> Key: CB-12582
> URL: https://issues.apache.org/jira/browse/CB-12582
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios@4.3.1, 6.5.0
>Reporter: Kyle Kirbatski
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@4.5.1
>
> Attachments: 0001-exec-purgeProjectFileCache-when-pod-install.patch
>
>
> I was trying to use the urbanairship-cordova plugin but was unable to because 
> the frameworks added by Cocoapods (referenced from the plugin's xml) were not 
> being found for linking. After some investigation it appears that if a plugin 
> is added after a plugin that uses cocoapods then the changes made by 
> cocoapods are removed by cordova.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-12582) Plugin's Cocoapods don't persist if another plugin is added after it

2018-02-05 Thread Kenichi Naito (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353200#comment-16353200
 ] 

Kenichi Naito edited comment on CB-12582 at 2/6/18 1:39 AM:


{code:java}
---
 bin/templates/scripts/cordova/Api.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/templates/scripts/cordova/Api.js 
b/bin/templates/scripts/cordova/Api.js
index dd50d11f..04da4a1b 100644
--- a/bin/templates/scripts/cordova/Api.js
+++ b/bin/templates/scripts/cordova/Api.js
@@ -285,6 +285,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) 
{
 if (podfileFile.isDirty()) {
 podfileFile.write();
 events.emit('verbose', 'Running `pod install` (to install 
plugins)');
+    projectFile.purgeProjectFileCache(self.locations.root);
 
 return podfileFile.install(check_reqs.check_cocoapods);
 } else {
--
2.14.2
{code}
 


was (Author: knaito):
```
---
 bin/templates/scripts/cordova/Api.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/templates/scripts/cordova/Api.js 
b/bin/templates/scripts/cordova/Api.js
index dd50d11f..04da4a1b 100644
--- a/bin/templates/scripts/cordova/Api.js
+++ b/bin/templates/scripts/cordova/Api.js
@@ -285,6 +285,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) 
{
 if (podfileFile.isDirty()) {
 podfileFile.write();
 events.emit('verbose', 'Running `pod install` (to install 
plugins)');
+projectFile.purgeProjectFileCache(self.locations.root);
 
 return podfileFile.install(check_reqs.check_cocoapods);
 } else {
-- 
2.14.2
```

> Plugin's Cocoapods don't persist if another plugin is added after it
> 
>
> Key: CB-12582
> URL: https://issues.apache.org/jira/browse/CB-12582
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios@4.3.1, 6.5.0
>Reporter: Kyle Kirbatski
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@4.5.1
>
> Attachments: 0001-exec-purgeProjectFileCache-when-pod-install.patch
>
>
> I was trying to use the urbanairship-cordova plugin but was unable to because 
> the frameworks added by Cocoapods (referenced from the plugin's xml) were not 
> being found for linking. After some investigation it appears that if a plugin 
> is added after a plugin that uses cocoapods then the changes made by 
> cocoapods are removed by cordova.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-12582) Plugin's Cocoapods don't persist if another plugin is added after it

2018-02-05 Thread Kenichi Naito (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353200#comment-16353200
 ] 

Kenichi Naito edited comment on CB-12582 at 2/6/18 1:30 AM:


```
---
 bin/templates/scripts/cordova/Api.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/templates/scripts/cordova/Api.js 
b/bin/templates/scripts/cordova/Api.js
index dd50d11f..04da4a1b 100644
--- a/bin/templates/scripts/cordova/Api.js
+++ b/bin/templates/scripts/cordova/Api.js
@@ -285,6 +285,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) 
{
 if (podfileFile.isDirty()) {
 podfileFile.write();
 events.emit('verbose', 'Running `pod install` (to install 
plugins)');
+projectFile.purgeProjectFileCache(self.locations.root);
 
 return podfileFile.install(check_reqs.check_cocoapods);
 } else {
-- 
2.14.2
```


was (Author: knaito):
```
---
 bin/templates/scripts/cordova/Api.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/templates/scripts/cordova/Api.js 
b/bin/templates/scripts/cordova/Api.js
index dd50d11f..04da4a1b 100644
--- a/bin/templates/scripts/cordova/Api.js
+++ b/bin/templates/scripts/cordova/Api.js
@@ -285,6 +285,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) 
{
 if (podfileFile.isDirty()) {
 podfileFile.write();
 events.emit('verbose', 'Running `pod install` (to install 
plugins)');
+    projectFile.purgeProjectFileCache(self.locations.root);
 
 return podfileFile.install(check_reqs.check_cocoapods);
 } else {
-- 
2.14.2
```

> Plugin's Cocoapods don't persist if another plugin is added after it
> 
>
> Key: CB-12582
> URL: https://issues.apache.org/jira/browse/CB-12582
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios@4.3.1, 6.5.0
>Reporter: Kyle Kirbatski
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@4.5.1
>
> Attachments: 0001-exec-purgeProjectFileCache-when-pod-install.patch
>
>
> I was trying to use the urbanairship-cordova plugin but was unable to because 
> the frameworks added by Cocoapods (referenced from the plugin's xml) were not 
> being found for linking. After some investigation it appears that if a plugin 
> is added after a plugin that uses cocoapods then the changes made by 
> cocoapods are removed by cordova.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12582) Plugin's Cocoapods don't persist if another plugin is added after it

2018-02-05 Thread Kenichi Naito (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353200#comment-16353200
 ] 

Kenichi Naito commented on CB-12582:


```
---
 bin/templates/scripts/cordova/Api.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/templates/scripts/cordova/Api.js 
b/bin/templates/scripts/cordova/Api.js
index dd50d11f..04da4a1b 100644
--- a/bin/templates/scripts/cordova/Api.js
+++ b/bin/templates/scripts/cordova/Api.js
@@ -285,6 +285,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) 
{
 if (podfileFile.isDirty()) {
 podfileFile.write();
 events.emit('verbose', 'Running `pod install` (to install 
plugins)');
+    projectFile.purgeProjectFileCache(self.locations.root);
 
 return podfileFile.install(check_reqs.check_cocoapods);
 } else {
-- 
2.14.2
```

> Plugin's Cocoapods don't persist if another plugin is added after it
> 
>
> Key: CB-12582
> URL: https://issues.apache.org/jira/browse/CB-12582
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios@4.3.1, 6.5.0
>Reporter: Kyle Kirbatski
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@4.5.1
>
> Attachments: 0001-exec-purgeProjectFileCache-when-pod-install.patch
>
>
> I was trying to use the urbanairship-cordova plugin but was unable to because 
> the frameworks added by Cocoapods (referenced from the plugin's xml) were not 
> being found for linking. After some investigation it appears that if a plugin 
> is added after a plugin that uses cocoapods then the changes made by 
> cocoapods are removed by cordova.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-12582) Plugin's Cocoapods don't persist if another plugin is added after it

2018-02-05 Thread Kenichi Naito (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kenichi Naito updated CB-12582:
---
Attachment: 0001-exec-purgeProjectFileCache-when-pod-install.patch

> Plugin's Cocoapods don't persist if another plugin is added after it
> 
>
> Key: CB-12582
> URL: https://issues.apache.org/jira/browse/CB-12582
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios@4.3.1, 6.5.0
>Reporter: Kyle Kirbatski
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@4.5.1
>
> Attachments: 0001-exec-purgeProjectFileCache-when-pod-install.patch
>
>
> I was trying to use the urbanairship-cordova plugin but was unable to because 
> the frameworks added by Cocoapods (referenced from the plugin's xml) were not 
> being found for linking. After some investigation it appears that if a plugin 
> is added after a plugin that uses cocoapods then the changes made by 
> cocoapods are removed by cordova.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13849) getDirectory('') returns root path

2018-02-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353183#comment-16353183
 ] 

ASF GitHub Bot commented on CB-13849:
-

Beutlin opened a new pull request #230: CB-13849: (android) getDirectory("") 
returns current path instead of / path
URL: https://github.com/apache/cordova-plugin-file/pull/230
 
 
   
   
   ### Platforms affected
   - Android
   
   
   ### What does this PR do?
   Currently the comman getDirectory('') with an empty parameter returns always 
the root path. It does not matter on which path this command is executed. This 
is an unexpected behaviour and might cause security issues.
   With this patch the path of the current directory is returned, like in other 
implementations (i.e. browser).
   
   ### What testing has been done on this change?
   It has been tested on an emulator. Furthermore the sourcecode has been 
evaluated and there is no negative issues with it. 
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> getDirectory('') returns root path
> --
>
> Key: CB-13849
> URL: https://issues.apache.org/jira/browse/CB-13849
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-file
>Affects Versions: cordova-android-7.0.0
> Environment: Android
>Reporter: Tobias Haupenthal
>Priority: Major
>
> At the moment the command \{someDir}.getDirectory("") with a blank argument 
> returns the root-path.
> If someone works already on a subdirectory that behaviour might be a security 
> flaw.
> Better would be to return the current directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13850) Typescript: Misspelled property fileSystem

2018-02-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353134#comment-16353134
 ] 

ASF GitHub Bot commented on CB-13850:
-

Beutlin opened a new pull request #229: CB-13850: Fix spelling in typed-file: 
property name filesystem (wrong…
URL: https://github.com/apache/cordova-plugin-file/pull/229
 
 
   
   
   ### Platforms affected
   -
   
   ### What does this PR do?
   The DefinitelyTyped file has a wrong attribute for an Entry object. It is 
"fileSystem" but should be "filesystem". The consequence of this is that the 
syntax checker of an IDE might give an false warning.
   
   ### What testing has been done on this change?
   Looked at file www/Entry.js. Obviously the naming is here "filesystem".
   
   ### Checklist
   - [ x ] [Reported an 
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [ x ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - Automated tests are not possible, because this bug is related to a 
DefinitelyTyped file, which provides only syntax checking for IDEs.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Typescript: Misspelled property fileSystem
> --
>
> Key: CB-13850
> URL: https://issues.apache.org/jira/browse/CB-13850
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-file
>Reporter: Tobias Haupenthal
>Priority: Major
>
> The Typescript file index.d.ts shows that an Entry shall have an attribute 
> fileSystem.
> But in Android this property is undefined. There is only the property 
> filesystem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13852) cordova-plugin-media getPosition audio failed

2018-02-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352916#comment-16352916
 ] 

ASF GitHub Bot commented on CB-13852:
-

jsdussanc opened a new pull request #165: CB-13852: (iOS) Fix bug prevent error 
on getPosition
URL: https://github.com/apache/cordova-plugin-media/pull/165
 
 
   
   When I try to get the position of an audio that had an error while loading, 
the crash appose exponentially because it can not cast the time = none
   
   ### Platforms affected
   iOS xx
   
   ### What does this PR do?
   
   if the time is none, return the value of position at default = -1
   
   ### What testing has been done on this change?
   It does not affect much, I tested it in my personal project
   
   ### Checklist
   - [ x ] [Reported an 
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [ x ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change. (I don`t 
know)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-media getPosition audio failed
> -
>
> Key: CB-13852
> URL: https://issues.apache.org/jira/browse/CB-13852
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-media
>Affects Versions: cordova-ios 4.5.0
> Environment: iOS all versions
>Reporter: Juan Sebastian Dussan Cubides
>Priority: Minor
>
> (iOS)
> When I try to get the position of an audio that had an error while loading, 
> the crash appose exponentially because it can not cast the time = none



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13852) cordova-plugin-media getPosition audio failed

2018-02-05 Thread Juan Sebastian Dussan Cubides (JIRA) 
Juan Sebastian Dussan Cubides created CB-13852:
--

 Summary: cordova-plugin-media getPosition audio failed
 Key: CB-13852
 URL: https://issues.apache.org/jira/browse/CB-13852
 Project: Apache Cordova
  Issue Type: Improvement
  Components: cordova-plugin-media
Affects Versions: cordova-ios 4.5.0
 Environment: iOS all versions
Reporter: Juan Sebastian Dussan Cubides


(iOS)

When I try to get the position of an audio that had an error while loading, the 
crash appose exponentially because it can not cast the time = none



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13851) Can't load Twitter hosted videos

2018-02-05 Thread Jordan Matejicek (JIRA) 
Jordan Matejicek created CB-13851:
-

 Summary: Can't load Twitter hosted videos
 Key: CB-13851
 URL: https://issues.apache.org/jira/browse/CB-13851
 Project: Apache Cordova
  Issue Type: Bug
  Components: AllPlatforms
 Environment: IOS & Android
Reporter: Jordan Matejicek


Hi,

Got an issue trying to embed twitter vidéos; player load but got an error when 
loading the video :

Refused to display 
'https://twitter.com/i/videos/tweet/959025264822022144?embed_source=clientlib_id=0_init=1_code=fr_syndication_guest_id=true'
 in a frame because an ancestor violates the following Content Security Policy 
directive: "frame-ancestors *".

Already tryed to whitelist twitter using whitelist cordova plugin but without 
success. Any though about this ?

Thank you !



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org