[jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code
[ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534379#comment-16534379 ] ASF GitHub Bot commented on CB-13055: - raphinesse commented on issue #624: CB-13055 Fold all fetch options to `true` URL: https://github.com/apache/cordova-lib/pull/624#issuecomment-402906492 Never mind the check.js refactor commits they will go in a separate PR. I just wanted to have them here for testing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > remove --nofetch option and all old fetching code > - > > Key: CB-13055 > URL: https://issues.apache.org/jira/browse/CB-13055 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill >Assignee: Raphael >Priority: Major > Labels: backlog, tools-next > Fix For: cordova@8 > > > Cordova uses cordova-fetch for fetching modules by default now. In the next > major version, lets drop the older methods. This is great for reducing > maintenance in cordova. Original fetch proposal is at > https://github.com/cordova/cordova-discuss/pull/33 > remove --nofetch option > remove lazy_load > remove gitclone.js > remove npm dependency > remove remoteload.js > update anywhere that these files are used > Proposal: https://github.com/apache/cordova-discuss/pull/76 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code
[ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534347#comment-16534347 ] ASF GitHub Bot commented on CB-13055: - raphinesse opened a new pull request #624: CB-13055 Fold all fetch options to `true` URL: https://github.com/apache/cordova-lib/pull/624 Manual constant folding assuming any `fetch` options to be `true`. Extends #617 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > remove --nofetch option and all old fetching code > - > > Key: CB-13055 > URL: https://issues.apache.org/jira/browse/CB-13055 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill >Assignee: Raphael >Priority: Major > Labels: backlog, tools-next > Fix For: cordova@8 > > > Cordova uses cordova-fetch for fetching modules by default now. In the next > major version, lets drop the older methods. This is great for reducing > maintenance in cordova. Original fetch proposal is at > https://github.com/cordova/cordova-discuss/pull/33 > remove --nofetch option > remove lazy_load > remove gitclone.js > remove npm dependency > remove remoteload.js > update anywhere that these files are used > Proposal: https://github.com/apache/cordova-discuss/pull/76 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code
[
https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534346#comment-16534346
]
ASF GitHub Bot commented on CB-13055:
-
raphinesse closed pull request #624: CB-13055 Fold all fetch options to `true`
URL: https://github.com/apache/cordova-lib/pull/624
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/integration-tests/pkgJson-restore.spec.js
b/integration-tests/pkgJson-restore.spec.js
index e045e6080..558c908a8 100644
--- a/integration-tests/pkgJson-restore.spec.js
+++ b/integration-tests/pkgJson-restore.spec.js
@@ -561,9 +561,10 @@ describe('update empty package.json to match config.xml',
function () {
// Expect that config.xml contains only android at this point.
expect(configEngArray.indexOf('android')).toBeGreaterThan(-1);
expect(configEngArray.length === 1);
-// Run cordova prepare.
-prepare();
+
return emptyPlatformList().then(function () {
+return prepare();
+}).then(function () {
var cfg2 = new ConfigParser(configXmlPath);
engines = cfg2.getEngines();
engNames = engines.map(function (elem) {
diff --git a/integration-tests/plugman_uninstall.spec.js
b/integration-tests/plugman_uninstall.spec.js
index 5faa8a792..6f4465160 100644
--- a/integration-tests/plugman_uninstall.spec.js
+++ b/integration-tests/plugman_uninstall.spec.js
@@ -17,7 +17,6 @@
under the License.
*/
-var uninstall = require('../src/plugman/uninstall');
var install = require('../src/plugman/install');
var actions = require('cordova-common').ActionStack;
var PluginInfo = require('cordova-common').PluginInfo;
@@ -30,6 +29,7 @@ var fs = require('fs');
var path = require('path');
var shell = require('shelljs');
var Q = require('q');
+var rewire = require('rewire');
var spec = path.join(__dirname, '..', 'spec', 'plugman');
var srcProject = path.join(spec, 'projects', 'android');
var project = path.join(spec, 'projects', 'android_uninstall.test');
@@ -66,6 +66,13 @@ var TEST_XML = '\n' +
'\n' +
'\n';
+var uninstall;
+
+beforeEach(() => {
+uninstall = rewire('../src/plugman/uninstall');
+uninstall.__set__('npmUninstall', jasmine.createSpy());
+});
+
describe('plugman uninstall start', function () {
beforeEach(function () {
var origParseElementtreeSync =
xmlHelpers.parseElementtreeSync.bind(xmlHelpers);
@@ -159,11 +166,8 @@ describe('uninstallPlatform', function () {
});
});
-describe('with dependencies', function () {
-var emit;
-beforeEach(function () {
-emit = spyOn(events, 'emit');
-});
+it('Test 014 : should uninstall dependent plugins', function () {
+var emit = spyOn(events, 'emit');
return uninstall.uninstallPlatform('android', project, 'A')
.then(function (result) {
expect(emit).toHaveBeenCalledWith('log', 'Uninstalling 2
dependent plugins.');
diff --git a/spec/cordova/platform/addHelper.spec.js
b/spec/cordova/platform/addHelper.spec.js
index 2fc88cc0f..4eaa90a48 100644
--- a/spec/cordova/platform/addHelper.spec.js
+++ b/spec/cordova/platform/addHelper.spec.js
@@ -138,8 +138,9 @@ describe('cordova/platform/addHelper', function () {
describe('platform spec inference', function () {
it('should retrieve platform details from
directories-specified-as-platforms using getPlatformDetailsFromDir', function
() {
-cordova_util.isDirectory.and.returnValue(true);
var directory_to_platform = '/path/to/cordova-atari';
+cordova_util.isDirectory.and.returnValue(true);
+
fetch_mock.and.returnValue(Promise.resolve(directory_to_platform));
return platform_addHelper('add', hooks_mock, projectRoot,
[directory_to_platform], {restoring: true}).then(function () {
expect(platform_module.getPlatformDetailsFromDir).toHaveBeenCalledWith(directory_to_platform,
null);
expect(platform_addHelper.downloadPlatform).not.toHaveBeenCalled();
diff --git a/spec/cordova/platform/remove.spec.js
b/spec/cordova/platform/remove.spec.js
index d55508576..058ca2a7e 100644
--- a/spec/cordova/platform/remove.spec.js
+++ b/spec/cordova/platform/remove.spec.js
@@ -20,7 +20,6 @@ var fs = require('fs');
var Q = require('q');
var events = require('cordova-common').events;
var rewire = require('rewire');
-var platform_remove = rewire('../../../src/cordova/platform/remove');
var cordova_util = require('../../../src/cordova/util');
var promiseutil =
[jira] [Commented] (CB-14139) Can't run android commands with 32bit Java
[ https://issues.apache.org/jira/browse/CB-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534319#comment-16534319 ] ASF GitHub Bot commented on CB-14139: - erisu edited a comment on issue #459: CB-14139 android: Add jvmargs flag for custom values URL: https://github.com/apache/cordova-android/pull/459#issuecomment-40247 @janpio, sorry for the missing comment. The more I think about it, it's probably better to not add an additional flag to set the jvmargs. It is a quicker and simpler solution but as mentioned, it would be harder to remove the flag in the future. Using the gradle.properties would be better in the long run. Looking back at the potential issue mentioned above when using the properties file, I think we just need to create a GradlePropertiesConfigParser/Writer. If the file doesn't exist, we can either - Create the file with our defaults - Continue using the inline command If the file already exists, parse the file to see if they have the default variables (excluding its value). If the default arguments are missing: - Edit the file with our defaults - Continue using the inline command If they already have the arguments define, then just accept their values. Also, I feel the amount of 32bit users could probably be very low and this would be an edge case. Since the user had a temporary workaround, we might be able to focus on removing all of the command-line usage in-favor of the gradle.properties instead of just jvmargs. The user's temporary workaround did mention setting the environment variables affect the whole system but, it might be possible to set the variable during execution. This shouldn't affect the whole system. `_JAVA_OPTIONS=-Xmx512m cordova ...`. The only question is if the set variable is still set when gradle runs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Can't run android commands with 32bit Java > -- > > Key: CB-14139 > URL: https://issues.apache.org/jira/browse/CB-14139 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 8.0.0 > Environment: Win 10 Pro x64 >Reporter: misterTi >Assignee: Joe Bowser >Priority: Blocker > > GradleBuilder.js has a buiit-in option org.gradle.jvmargs=---Xmx2048m on line > 59, which prevents it from running on 32bit Java. It always fails with VM > heap error. The workaround is to create an environment variable > __JAVA__OPTIONS=-Xmx512m, but this then affects the whole system. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14139) Can't run android commands with 32bit Java
[ https://issues.apache.org/jira/browse/CB-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534317#comment-16534317 ] ASF GitHub Bot commented on CB-14139: - erisu edited a comment on issue #459: CB-14139 android: Add jvmargs flag for custom values URL: https://github.com/apache/cordova-android/pull/459#issuecomment-40247 @janpio, sorry for the missing comment. The more I think about it, it's probably better to not add an additional flag to set the jvmargs. It is a quicker and simpler solution but as mentioned, it would be harder to remove the flag in the future. Using the gradle.properties would be better in the long run. Looking back at the potential issue mentioned above when using the properties file, I think we just need to create a GradlePropertiesConfigParser/Writer. If the file doesn't exist, we can either - Create the file with our defaults - Continue using the inline command If the file already exists, parse the file to see if they have the default variables (excluding its value). If the default arguments are missing: - Edit the file with our defaults - Continue using the inline command If they already have the arguments define, then just accept their values. Also, I feel the amount of 32bit users could probably be very low and this would be an edge case. Since the user had a temporary workaround, we might be able to focus on removing all of the command-line usage in-favor of the gradle.properties instead of just jvmargs. The user's temporary workaround did mention setting the environment variables but affecting the whole system. Though testing is needed, it might be possible to set the variable during execution which shouldn't affect the whole system. `_JAVA_OPTIONS=-Xmx512m cordova ...`. The only question is if the set variable is still set when gradle runs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Can't run android commands with 32bit Java > -- > > Key: CB-14139 > URL: https://issues.apache.org/jira/browse/CB-14139 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 8.0.0 > Environment: Win 10 Pro x64 >Reporter: misterTi >Assignee: Joe Bowser >Priority: Blocker > > GradleBuilder.js has a buiit-in option org.gradle.jvmargs=---Xmx2048m on line > 59, which prevents it from running on 32bit Java. It always fails with VM > heap error. The workaround is to create an environment variable > __JAVA__OPTIONS=-Xmx512m, but this then affects the whole system. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14139) Can't run android commands with 32bit Java
[ https://issues.apache.org/jira/browse/CB-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534316#comment-16534316 ] ASF GitHub Bot commented on CB-14139: - erisu commented on issue #459: CB-14139 android: Add jvmargs flag for custom values URL: https://github.com/apache/cordova-android/pull/459#issuecomment-40247 @janpio, sorry for the missing comment. The more I think about it, it's probably better to not add an additional flag to set the jvmargs. It is a quicker and simpler solution but as mentioned, it would be harder to remove flag in the future. Using the gradle.properties would be better in the long run. Looking back at the potential issue mentioned above when using the properties file, I think we just need to create a GradlePropertiesConfigParser/Writer. If the file doesn't exist, we can either - Create the file with our defaults - Continue using the inline command If the file already exists, parse the file to see if they have the default variables (excluding its value). If the default arguments are missing: - Edit the file with our defaults - Continue using the inline command If they already have the arguments define, then just accept their values. Also, I feel the amount of 32bit users could probably be very low and this would be an edge case. Since the user had a temporary workaround, we might be able to focus on removing all of the command-line usage in-favor of the gradle.properties instead of just jvmargs. The user's temporary workaround did mention setting the environment variables but affecting the whole system. Though testing is needed, it might be possible to set the variable during execution which shouldn't affect the whole system. `_JAVA_OPTIONS=-Xmx512m cordova ...`. The only question is if the set variable is still set when gradle runs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Can't run android commands with 32bit Java > -- > > Key: CB-14139 > URL: https://issues.apache.org/jira/browse/CB-14139 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 8.0.0 > Environment: Win 10 Pro x64 >Reporter: misterTi >Assignee: Joe Bowser >Priority: Blocker > > GradleBuilder.js has a buiit-in option org.gradle.jvmargs=---Xmx2048m on line > 59, which prevents it from running on 32bit Java. It always fails with VM > heap error. The workaround is to create an environment variable > __JAVA__OPTIONS=-Xmx512m, but this then affects the whole system. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code
[ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534268#comment-16534268 ] ASF GitHub Bot commented on CB-13055: - raphinesse commented on issue #624: CB-13055 Fold all fetch options to `true` URL: https://github.com/apache/cordova-lib/pull/624#issuecomment-402878505 The test file that causes the errors on Windows is nasty. I'll DRY it first. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > remove --nofetch option and all old fetching code > - > > Key: CB-13055 > URL: https://issues.apache.org/jira/browse/CB-13055 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill >Assignee: Raphael >Priority: Major > Labels: backlog, tools-next > Fix For: cordova@8 > > > Cordova uses cordova-fetch for fetching modules by default now. In the next > major version, lets drop the older methods. This is great for reducing > maintenance in cordova. Original fetch proposal is at > https://github.com/cordova/cordova-discuss/pull/33 > remove --nofetch option > remove lazy_load > remove gitclone.js > remove npm dependency > remove remoteload.js > update anywhere that these files are used > Proposal: https://github.com/apache/cordova-discuss/pull/76 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14097) Camera plugin crashes using getPicture on some files
[
https://issues.apache.org/jira/browse/CB-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534223#comment-16534223
]
ASF GitHub Bot commented on CB-14097:
-
jcesarmobile commented on issue #322: CB-14097: (android) Fix crash when
selecting some files with getPicture
URL:
https://github.com/apache/cordova-plugin-camera/pull/322#issuecomment-402868908
Thanks, merged!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Camera plugin crashes using getPicture on some files
>
>
> Key: CB-14097
> URL: https://issues.apache.org/jira/browse/CB-14097
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Affects Versions: Master
> Environment: At least tested on:
> Cordova 7.1.0
> Camera 4.0.3
> But the code is the same in master branch.
>Reporter: B. van Mensvoort
>Priority: Critical
> Fix For: Master
>
> Attachments: logcat.txt
>
>
> My app uses navigator.camera.getPicture to select files from a library.
> After selecting some files, the app crashes. Some files go well and it
> doesn't seem to happen on all devices.
> The crash happens in the FileHelper.java file and it the exception is:
> {{java.lang.NumberFormatException: For input string:
> "raw:/storage/emulated/0/Download/filename.PDF"}}
> It seems to be caused the way files are saved on the device. The urls of the
> files are different. When resaving the file, the URL can be as expected.
> Expected URL:
> {{content://com.android.providers.downloads.documents/document/}}
> Error URL:
> {{content://com.android.providers.downloads.documents/document/raw%3A%2Fstorage%2Femulated%2F0%2FDownload%2Ffilename.pdf}}
> The fix is the same as:
> [https://github.com/severianremi/uCrop/commit/9e2bb067631ac3bd3817c0fb55c51db3d61edfe0]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-14097) Camera plugin crashes using getPicture on some files
[
https://issues.apache.org/jira/browse/CB-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jcesarmobile resolved CB-14097.
---
Resolution: Fixed
Fixed in 4.0.4-dev
> Camera plugin crashes using getPicture on some files
>
>
> Key: CB-14097
> URL: https://issues.apache.org/jira/browse/CB-14097
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Affects Versions: Master
> Environment: At least tested on:
> Cordova 7.1.0
> Camera 4.0.3
> But the code is the same in master branch.
>Reporter: B. van Mensvoort
>Priority: Critical
> Fix For: Master
>
> Attachments: logcat.txt
>
>
> My app uses navigator.camera.getPicture to select files from a library.
> After selecting some files, the app crashes. Some files go well and it
> doesn't seem to happen on all devices.
> The crash happens in the FileHelper.java file and it the exception is:
> {{java.lang.NumberFormatException: For input string:
> "raw:/storage/emulated/0/Download/filename.PDF"}}
> It seems to be caused the way files are saved on the device. The urls of the
> files are different. When resaving the file, the URL can be as expected.
> Expected URL:
> {{content://com.android.providers.downloads.documents/document/}}
> Error URL:
> {{content://com.android.providers.downloads.documents/document/raw%3A%2Fstorage%2Femulated%2F0%2FDownload%2Ffilename.pdf}}
> The fix is the same as:
> [https://github.com/severianremi/uCrop/commit/9e2bb067631ac3bd3817c0fb55c51db3d61edfe0]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14097) Camera plugin crashes using getPicture on some files
[
https://issues.apache.org/jira/browse/CB-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534220#comment-16534220
]
ASF subversion and git services commented on CB-14097:
--
Commit 5c23b65af9b11fa3a17bd44513418113dea9b8ed in cordova-plugin-camera's
branch refs/heads/master from bvmensvoort
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=5c23b65 ]
CB-14097: (android) Fix crash when selecting some files with getPicture (#322)
* CB-14097: (android) Fix crash when selecting some files with getPicture of
urls with raw://
Handles both urls:
content://com.android.providers.downloads.documents/document/
content://com.android.providers.downloads.documents/document/raw%3A%2Fstorage%2Femulated%2F0%2FDownload%2Ffilename.pdf
* Optimization: Remove TextUtils dependency, return null when no id could be
extracted
> Camera plugin crashes using getPicture on some files
>
>
> Key: CB-14097
> URL: https://issues.apache.org/jira/browse/CB-14097
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Affects Versions: Master
> Environment: At least tested on:
> Cordova 7.1.0
> Camera 4.0.3
> But the code is the same in master branch.
>Reporter: B. van Mensvoort
>Priority: Critical
> Fix For: Master
>
> Attachments: logcat.txt
>
>
> My app uses navigator.camera.getPicture to select files from a library.
> After selecting some files, the app crashes. Some files go well and it
> doesn't seem to happen on all devices.
> The crash happens in the FileHelper.java file and it the exception is:
> {{java.lang.NumberFormatException: For input string:
> "raw:/storage/emulated/0/Download/filename.PDF"}}
> It seems to be caused the way files are saved on the device. The urls of the
> files are different. When resaving the file, the URL can be as expected.
> Expected URL:
> {{content://com.android.providers.downloads.documents/document/}}
> Error URL:
> {{content://com.android.providers.downloads.documents/document/raw%3A%2Fstorage%2Femulated%2F0%2FDownload%2Ffilename.pdf}}
> The fix is the same as:
> [https://github.com/severianremi/uCrop/commit/9e2bb067631ac3bd3817c0fb55c51db3d61edfe0]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14097) Camera plugin crashes using getPicture on some files
[
https://issues.apache.org/jira/browse/CB-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534219#comment-16534219
]
ASF GitHub Bot commented on CB-14097:
-
jcesarmobile closed pull request #322: CB-14097: (android) Fix crash when
selecting some files with getPicture
URL: https://github.com/apache/cordova-plugin-camera/pull/322
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/android/FileHelper.java b/src/android/FileHelper.java
index ccc5e3e7..edf16578 100644
--- a/src/android/FileHelper.java
+++ b/src/android/FileHelper.java
@@ -97,10 +97,21 @@ public static String
getRealPathFromURI_API11_And_Above(final Context context, f
else if (isDownloadsDocument(uri)) {
final String id = DocumentsContract.getDocumentId(uri);
-final Uri contentUri = ContentUris.withAppendedId(
-Uri.parse("content://downloads/public_downloads"),
Long.valueOf(id));
-
-return getDataColumn(context, contentUri, null, null);
+if (id != null && id.length() > 0) {
+if (id.startsWith("raw:")) {
+return id.replaceFirst("raw:", "");
+}
+try {
+final Uri contentUri = ContentUris.withAppendedId(
+
Uri.parse("content://downloads/public_downloads"), Long.valueOf(id));
+
+return getDataColumn(context, contentUri, null, null);
+} catch (NumberFormatException e) {
+return null;
+}
+} else {
+return null;
+}
}
// MediaProvider
else if (isMediaDocument(uri)) {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Camera plugin crashes using getPicture on some files
>
>
> Key: CB-14097
> URL: https://issues.apache.org/jira/browse/CB-14097
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Affects Versions: Master
> Environment: At least tested on:
> Cordova 7.1.0
> Camera 4.0.3
> But the code is the same in master branch.
>Reporter: B. van Mensvoort
>Priority: Critical
> Fix For: Master
>
> Attachments: logcat.txt
>
>
> My app uses navigator.camera.getPicture to select files from a library.
> After selecting some files, the app crashes. Some files go well and it
> doesn't seem to happen on all devices.
> The crash happens in the FileHelper.java file and it the exception is:
> {{java.lang.NumberFormatException: For input string:
> "raw:/storage/emulated/0/Download/filename.PDF"}}
> It seems to be caused the way files are saved on the device. The urls of the
> files are different. When resaving the file, the URL can be as expected.
> Expected URL:
> {{content://com.android.providers.downloads.documents/document/}}
> Error URL:
> {{content://com.android.providers.downloads.documents/document/raw%3A%2Fstorage%2Femulated%2F0%2FDownload%2Ffilename.pdf}}
> The fix is the same as:
> [https://github.com/severianremi/uCrop/commit/9e2bb067631ac3bd3817c0fb55c51db3d61edfe0]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14097) Camera plugin crashes using getPicture on some files
[
https://issues.apache.org/jira/browse/CB-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534221#comment-16534221
]
ASF subversion and git services commented on CB-14097:
--
Commit 5c23b65af9b11fa3a17bd44513418113dea9b8ed in cordova-plugin-camera's
branch refs/heads/master from bvmensvoort
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=5c23b65 ]
CB-14097: (android) Fix crash when selecting some files with getPicture (#322)
* CB-14097: (android) Fix crash when selecting some files with getPicture of
urls with raw://
Handles both urls:
content://com.android.providers.downloads.documents/document/
content://com.android.providers.downloads.documents/document/raw%3A%2Fstorage%2Femulated%2F0%2FDownload%2Ffilename.pdf
* Optimization: Remove TextUtils dependency, return null when no id could be
extracted
> Camera plugin crashes using getPicture on some files
>
>
> Key: CB-14097
> URL: https://issues.apache.org/jira/browse/CB-14097
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Affects Versions: Master
> Environment: At least tested on:
> Cordova 7.1.0
> Camera 4.0.3
> But the code is the same in master branch.
>Reporter: B. van Mensvoort
>Priority: Critical
> Fix For: Master
>
> Attachments: logcat.txt
>
>
> My app uses navigator.camera.getPicture to select files from a library.
> After selecting some files, the app crashes. Some files go well and it
> doesn't seem to happen on all devices.
> The crash happens in the FileHelper.java file and it the exception is:
> {{java.lang.NumberFormatException: For input string:
> "raw:/storage/emulated/0/Download/filename.PDF"}}
> It seems to be caused the way files are saved on the device. The urls of the
> files are different. When resaving the file, the URL can be as expected.
> Expected URL:
> {{content://com.android.providers.downloads.documents/document/}}
> Error URL:
> {{content://com.android.providers.downloads.documents/document/raw%3A%2Fstorage%2Femulated%2F0%2FDownload%2Ffilename.pdf}}
> The fix is the same as:
> [https://github.com/severianremi/uCrop/commit/9e2bb067631ac3bd3817c0fb55c51db3d61edfe0]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10358) Update Weinre Docs to note that it's deprecated
[ https://issues.apache.org/jira/browse/CB-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534212#comment-16534212 ] ASF GitHub Bot commented on CB-10358: - jcesarmobile commented on a change in pull request #16: CB-10358: Add deprecation notice URL: https://github.com/apache/cordova-weinre/pull/16#discussion_r200502953 ## File path: README.md ## @@ -16,6 +16,21 @@ * specific language governing permissions and limitations * under the License. --> +# cordova-weinre + +## Deprecation Notice + +This project is being deprecated. No more work will be done on this project by the Cordova development community. You can continue to use this project and it should work as-is, but issues will not be fixed by the Cordova community. + +weinre was built in an age when there were no remote debuggers available for mobile devices. Since then, some platforms are starting to provide remote debugger capabilities, as part of their platform tool set. + +1. Android:[Get Started with Remote Debugging Android Devices](https://developers.google.com/web/tools/chrome-devtools/remote-debugging/) +1. iOS:[Safari Developer Tools overview](https://support.apple.com/guide/safari-developer/safari-developer-tools-overview-dev073038698/mac) +1. Windows:[Debug Store apps in Visual Studio](https://msdn.microsoft.com/library/hh441472.aspx) + +Important note, some of weinre dependencies have security issues, use on your own risk. Review comment: In VS Code it highlight it in yellow, but yeah, it doesn't do anything here, so I'll remove it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update Weinre Docs to note that it's deprecated > --- > > Key: CB-10358 > URL: https://issues.apache.org/jira/browse/CB-10358 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-weinre (DEPRECATED) >Reporter: Patrick Mueller >Assignee: Patrick Mueller >Priority: Trivial > > !http://unmaintained.tech/badge.svg! > It's been over a year since the last weinre release - > http://people.apache.org/~pmuellr/weinre/builds/?C=M;O=D;V=0 > Even before then, the bug reports have slowed down, and I don't really have > time to deal with the handful that are left anyway. > So, consider this my throwing the towel. My next update may just be a badge > and link to http://http://unmaintained.tech/ -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10358) Update Weinre Docs to note that it's deprecated
[ https://issues.apache.org/jira/browse/CB-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534207#comment-16534207 ] ASF GitHub Bot commented on CB-10358: - brodybits commented on a change in pull request #16: CB-10358: Add deprecation notice URL: https://github.com/apache/cordova-weinre/pull/16#discussion_r200501319 ## File path: README.md ## @@ -16,6 +16,21 @@ * specific language governing permissions and limitations * under the License. --> +# cordova-weinre + +## Deprecation Notice + +This project is being deprecated. No more work will be done on this project by the Cordova development community. You can continue to use this project and it should work as-is, but issues will not be fixed by the Cordova community. + +weinre was built in an age when there were no remote debuggers available for mobile devices. Since then, some platforms are starting to provide remote debugger capabilities, as part of their platform tool set. + +1. Android:[Get Started with Remote Debugging Android Devices](https://developers.google.com/web/tools/chrome-devtools/remote-debugging/) +1. iOS:[Safari Developer Tools overview](https://support.apple.com/guide/safari-developer/safari-developer-tools-overview-dev073038698/mac) +1. Windows:[Debug Store apps in Visual Studio](https://msdn.microsoft.com/library/hh441472.aspx) + +Important note, some of weinre dependencies have security issues, use on your own risk. Review comment: `` doesn't seem to do much if I click the View button I would mark "Important note" in **BOLD CAPS** This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update Weinre Docs to note that it's deprecated > --- > > Key: CB-10358 > URL: https://issues.apache.org/jira/browse/CB-10358 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-weinre (DEPRECATED) >Reporter: Patrick Mueller >Assignee: Patrick Mueller >Priority: Trivial > > !http://unmaintained.tech/badge.svg! > It's been over a year since the last weinre release - > http://people.apache.org/~pmuellr/weinre/builds/?C=M;O=D;V=0 > Even before then, the bug reports have slowed down, and I don't really have > time to deal with the handful that are left anyway. > So, consider this my throwing the towel. My next update may just be a badge > and link to http://http://unmaintained.tech/ -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-10886) add support for support IE Mobile
[
https://issues.apache.org/jira/browse/CB-10886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jcesarmobile closed CB-10886.
-
Resolution: Won't Fix
We are deprecating weinre and we won't do more releases, so we won't fix this.
> add support for support IE Mobile
> -
>
> Key: CB-10886
> URL: https://issues.apache.org/jira/browse/CB-10886
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-weinre (DEPRECATED)
>Reporter: Patrick Mueller
>Assignee: Patrick Mueller
>Priority: Critical
> Labels: triaged
>
> see https://github.com/apache/cordova-weinre/pull/14
> It appears some Windows phone are using a User Agent that weinre doesn't
> catch. {{"MSIE"}} and now {{"IEMobile"}} as well.
> There's a check for just {{"MSIE"}} in the file
> {{weinre.web/modules/weinre/common/HookLib.coffee}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-10281) Allow CORS
[
https://issues.apache.org/jira/browse/CB-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jcesarmobile closed CB-10281.
-
Resolution: Won't Fix
Fix Version/s: (was: Master)
We are deprecating weinre and we won't do more releases, so we won't fix this.
> Allow CORS
> --
>
> Key: CB-10281
> URL: https://issues.apache.org/jira/browse/CB-10281
> Project: Apache Cordova
> Issue Type: New Feature
> Components: cordova-weinre (DEPRECATED)
>Affects Versions: 3.5.0
>Reporter: Miquel
>Assignee: Patrick Mueller
>Priority: Minor
> Labels: easyfix, features, patch
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> I've created a pull request to allow CORS:
> https://github.com/apache/cordova-weinre/pull/10:
> {noformat}
> diff --git a/weinre.server/lib/weinre.js b/weinre.server/lib/weinre.js
> index a4ca11c..036df78 100644
> --- a/weinre.server/lib/weinre.js
> +++ b/weinre.server/lib/weinre.js
> @@ -133,6 +133,11 @@ startServer = function() {
>});
>app.use(express.favicon(favIcon));
>app.use(jsonBodyParser());
> + app.use(function(req, res, next) {
> +res.header("Access-Control-Allow-Origin", "*");
> +res.header("Access-Control-Allow-Headers", "Origin, X-Requested-With,
> Content-Type, Accept");
> +next();
> + });
>app.all(/^\/ws\/client(.*)/, function(request, response, next) {
> var uri;
> uri = request.params[0];
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-6835) weinre - Fix header licenses (Apache RAT report)
[ https://issues.apache.org/jira/browse/CB-6835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-6835. Resolution: Won't Fix As we are deprecating weinre and we won't do more releases, we won't fix this. > weinre - Fix header licenses (Apache RAT report) > > > Key: CB-6835 > URL: https://issues.apache.org/jira/browse/CB-6835 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-weinre (DEPRECATED) >Reporter: Shazron Abdullah >Assignee: Patrick Mueller >Priority: Major > Fix For: 3.6.0 > > > JavaDocs are generated and so license header is optional > Generated files do not required license headers > Add a .ratExcludes file for files to exclude > 153 Unknown Licenses > *** > Unapproved licenses: > ./weinre.build/vendor/webkit/WebCore/inspector/InjectedScriptHost.idl > ./weinre.build/vendor/webkit/WebCore/inspector/InjectedScriptSource.js > ./weinre.build/vendor/webkit/WebCore/inspector/Inspector.idl > ./weinre.build/vendor/webkit/WebCore/inspector/InspectorFrontendHost.idl > ./weinre.build/vendor/webkit/WebCore/inspector/JavaScriptCallFrame.idl > ./weinre.build/vendor/webkit/WebCore/inspector/ScriptProfile.idl > ./weinre.build/vendor/webkit/WebCore/inspector/ScriptProfileNode.idl > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/ApplicationCacheItemsView.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/AuditCategories.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/AuditFormatters.js > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/AuditLauncherView.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/AuditResultView.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/AuditRules.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/AuditsPanel.js > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/BottomUpProfileDataGridTree.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/Breakpoint.js > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/BreakpointManager.js > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/BreakpointsSidebarPane.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/CSSCompletions.js > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/CSSKeywordCompletions.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/CSSStyleModel.js > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/CallStackSidebarPane.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/Checkbox.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/Color.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/ConsolePanel.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/ConsoleView.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/ContextMenu.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/CookieItemsView.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/CookieParser.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/CookiesTable.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/DOMAgent.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/DOMStorage.js > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/DOMStorageItemsView.js > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/DOMSyntaxHighlighter.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/DataGrid.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/Database.js > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/DatabaseQueryView.js > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/DatabaseTableView.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/DebuggerModel.js > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/DetailedHeapshotView.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/Drawer.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/ElementsPanel.js > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/ElementsTreeOutline.js > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/EventListenersSidebarPane.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/ExtensionAPI.js > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/ExtensionAPISchema.json > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/ExtensionAuditCategory.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/ExtensionCommon.js > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/ExtensionPanel.js > > ./weinre.build/vendor/webkit/WebCore/inspector/front-end/ExtensionRegistryStub.js >
[jira] [Commented] (CB-10358) Update Weinre Docs to note that it's deprecated
[ https://issues.apache.org/jira/browse/CB-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534190#comment-16534190 ] ASF GitHub Bot commented on CB-10358: - jcesarmobile commented on a change in pull request #16: CB-10358: Add deprecation notice URL: https://github.com/apache/cordova-weinre/pull/16#discussion_r200498417 ## File path: README.md ## @@ -16,6 +16,19 @@ * specific language governing permissions and limitations * under the License. --> +# cordova-weinre + +## Deprecation Notice + +This project is being deprecated. No more work will be done on this project by the Cordova development community. You can continue to use this project and it should work as-is, but issues will not be fixed by the Cordova community. + +weinre was built in an age when there were no remote debuggers available for mobile devices. Since then, some platforms are starting to provide remote debugger capabilities, as part of their platform tool set. + +1. Android:[Get Started with Remote Debugging Android Devicese](https://developers.google.com/web/tools/chrome-devtools/remote-debugging/) Review comment: thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update Weinre Docs to note that it's deprecated > --- > > Key: CB-10358 > URL: https://issues.apache.org/jira/browse/CB-10358 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-weinre (DEPRECATED) >Reporter: Patrick Mueller >Assignee: Patrick Mueller >Priority: Trivial > > !http://unmaintained.tech/badge.svg! > It's been over a year since the last weinre release - > http://people.apache.org/~pmuellr/weinre/builds/?C=M;O=D;V=0 > Even before then, the bug reports have slowed down, and I don't really have > time to deal with the handful that are left anyway. > So, consider this my throwing the towel. My next update may just be a badge > and link to http://http://unmaintained.tech/ -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-10324) Derive whitelist tags from CSP
[
https://issues.apache.org/jira/browse/CB-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Gill reassigned CB-10324:
---
Assignee: (was: Steve Gill)
> Derive whitelist tags from CSP
> --
>
> Key: CB-10324
> URL: https://issues.apache.org/jira/browse/CB-10324
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android, cordova-ios
>Affects Versions: 4.0.1
>Reporter: Gregor Schmidt
>Priority: Minor
>
> When dynamically creating an {{iframe}}, the {{iframe}}'s {{src}} is never
> loaded. This worked without issues using 3.9.2.
> Example Code:
> {code:javascript}
> i = document.createElement("iframe");
> i.src = "https://example.org;;
> document.body.appendChild(i);
> {code}
> Please note, that you have to extend the {{Content-Security-Policy}} headers
> to include {{https:}} to pass CSP restrictions.
> I have also created a sample project to reproduce the problem. You may find
> it at https://github.com/schmidt/cordova-ios-iframe-example
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-7930) create coho toolsRelease command based off nightly
[ https://issues.apache.org/jira/browse/CB-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill reassigned CB-7930: -- Assignee: (was: Steve Gill) > create coho toolsRelease command based off nightly > -- > > Key: CB-7930 > URL: https://issues.apache.org/jira/browse/CB-7930 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-coho >Reporter: Steve Gill >Priority: Major > > It will be based off coho nightly. Multi-step process. Proposal below. Still > figuring out some details (what to pass in). Feel free to comment and provide > feedback. > Step 1) coho prepare-tools-release --jira ISSUENUMBER > - Use latest tags in platform repos; use in platformsConfig.json > - Include cordova-js & plugman (nightlies don't)(cordova-js: only if changes > exist) > - Update package.json files + relevant dependencies > - npm link relevant repos > - run tests > - generate release notes for tools repos > - Ask user for manual curation for changes in release notes > Step 2) coho publish-tools --rc --jira ISSUENUMBER > - branch tools repos (no need to cherry-pick release log changes) > - update versions on master with -dev > - Commit changes > - Build archive > - publish archive to npm under rc tag > - publish to dist/dev > Step 3) (manual for now) > - Start vote thread > - close vote thread > Step 4) coho publish-tools --final --jira ISSUENUMBER > - Publish to dist & delete dist/dev > - Change npm latest tags to point to new versions > Not including for now: > - Generating issue on Jira (should be done manually pre step 1) > - Pinning dependencies (should be done manually pre step 1) > - license checks (should be done manually pre step 1) > - audit-license-headers (should be done manually pre step 1) > - Changes to docs.cordova.io > - Creating blog post -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13926) Remove old platforms and plugins from cordova docs
[ https://issues.apache.org/jira/browse/CB-13926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill reassigned CB-13926: --- Assignee: (was: Steve Gill) > Remove old platforms and plugins from cordova docs > -- > > Key: CB-13926 > URL: https://issues.apache.org/jira/browse/CB-13926 > Project: Apache Cordova > Issue Type: Task > Components: cordova-docs >Reporter: Steve Gill >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-11623) --link-to no longer seems to be working
[ https://issues.apache.org/jira/browse/CB-11623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Gill reassigned CB-11623: --- Assignee: (was: Steve Gill) > --link-to no longer seems to be working > --- > > Key: CB-11623 > URL: https://issues.apache.org/jira/browse/CB-11623 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-create >Affects Versions: 6.3.0 > Environment: Windows 10, Windows Command Prompt >Reporter: Graham Harper >Priority: Major > Labels: triaged > > We have a build script for installing and building Cordova from source > control that begins with the line: > cordova create bin com.example.domain APPNAME --link-to=www > Where www is our existing app code (html, css, js etc.) > We've been running this build script on new deployments just fine for 6 > months or so, and its behaviour until this version has been to create a > simlink in the newly-created 'bin' folder to our existing app in 'www'; > however, as of 6.3.0 this is no longer working. The command creates the bin > folder, but it only contains the default 'Hello Cordova' application. > --copy-from still seems to be working (although is marked as deprecated), so > we can work around this issue, but it's not appropriate for our deployment > and development process. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14194) Prepare fails when using scoped packages
[
https://issues.apache.org/jira/browse/CB-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533919#comment-16533919
]
ASF GitHub Bot commented on CB-14194:
-
oliversalzburg commented on issue #625: CB-14194: Don't cut off scope from
package identifier
URL: https://github.com/apache/cordova-lib/pull/625#issuecomment-402794027
@dpogue Good call. I'll have a look at the tests.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Prepare fails when using scoped packages
>
>
> Key: CB-14194
> URL: https://issues.apache.org/jira/browse/CB-14194
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: Master
>Reporter: Oliver Salzburg
>Priority: Major
>
> When adding a plugin to a project, cordova will fail if the plugin is hosted
> under an npm scope.
> The scope is cut off when searching for the installation folder on disk:
> {code}
> Discovered plugin "@fairmanager/cordova-plugin-push" in config.xml. Adding it
> to the project
> Failed to restore plugin "@fairmanager/cordova-plugin-push" from config.xml.
> You might need to try adding it again. Error: Cannot find plugin.xml for
> plugin "cordova-plugin-push". Please try adding it again.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14194) Prepare fails when using scoped packages
[
https://issues.apache.org/jira/browse/CB-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533892#comment-16533892
]
ASF GitHub Bot commented on CB-14194:
-
dpogue commented on issue #625: CB-14194: Don't cut off scope from package
identifier
URL: https://github.com/apache/cordova-lib/pull/625#issuecomment-402785915
:+1: on this change.
I'd feel slightly more confident if there were [updated
tests](https://github.com/fairmanager-cordova/cordova-lib/blob/master/spec/cordova/plugin/add.spec.js)
to confirm expected behaviour and prevent regressions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Prepare fails when using scoped packages
>
>
> Key: CB-14194
> URL: https://issues.apache.org/jira/browse/CB-14194
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: Master
>Reporter: Oliver Salzburg
>Priority: Major
>
> When adding a plugin to a project, cordova will fail if the plugin is hosted
> under an npm scope.
> The scope is cut off when searching for the installation folder on disk:
> {code}
> Discovered plugin "@fairmanager/cordova-plugin-push" in config.xml. Adding it
> to the project
> Failed to restore plugin "@fairmanager/cordova-plugin-push" from config.xml.
> You might need to try adding it again. Error: Cannot find plugin.xml for
> plugin "cordova-plugin-push". Please try adding it again.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14194) Prepare fails when using scoped packages
[
https://issues.apache.org/jira/browse/CB-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Piotrowski (Sujan) updated CB-14194:
Description:
When adding a plugin to a project, cordova will fail if the plugin is hosted
under an npm scope.
The scope is cut off when searching for the installation folder on disk:
{code}
Discovered plugin "@fairmanager/cordova-plugin-push" in config.xml. Adding it
to the project
Failed to restore plugin "@fairmanager/cordova-plugin-push" from config.xml.
You might need to try adding it again. Error: Cannot find plugin.xml for plugin
"cordova-plugin-push". Please try adding it again.
{code}
was:
When adding a plugin to a project, cordova will fail if the plugin is hosted
under an npm scope.
The scope is cut off when searching for the installation folder on disk:
```
Discovered plugin "@fairmanager/cordova-plugin-push" in config.xml. Adding it
to the project
Failed to restore plugin "@fairmanager/cordova-plugin-push" from config.xml.
You might need to try adding it again. Error: Cannot find plugin.xml for plugin
"cordova-plugin-push". Please try adding it again.
```
> Prepare fails when using scoped packages
>
>
> Key: CB-14194
> URL: https://issues.apache.org/jira/browse/CB-14194
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: Master
>Reporter: Oliver Salzburg
>Priority: Major
>
> When adding a plugin to a project, cordova will fail if the plugin is hosted
> under an npm scope.
> The scope is cut off when searching for the installation folder on disk:
> {code}
> Discovered plugin "@fairmanager/cordova-plugin-push" in config.xml. Adding it
> to the project
> Failed to restore plugin "@fairmanager/cordova-plugin-push" from config.xml.
> You might need to try adding it again. Error: Cannot find plugin.xml for
> plugin "cordova-plugin-push". Please try adding it again.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14194) Prepare fails when using scoped packages
[ https://issues.apache.org/jira/browse/CB-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533813#comment-16533813 ] ASF GitHub Bot commented on CB-14194: - oliversalzburg opened a new pull request #625: CB-14194: Don't cut off scope from package identifier URL: https://github.com/apache/cordova-lib/pull/625 ### Platforms affected All ### What does this PR do? When looking for the installation folder for a scoped npm package, include the scope in the search. Otherwise it will always fail. ### What testing has been done on this change? I ran `npm test` and I built (`cordova prepare`) our own app with this code. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare fails when using scoped packages > > > Key: CB-14194 > URL: https://issues.apache.org/jira/browse/CB-14194 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: Master >Reporter: Oliver Salzburg >Priority: Major > > When adding a plugin to a project, cordova will fail if the plugin is hosted > under an npm scope. > The scope is cut off when searching for the installation folder on disk: > ``` > Discovered plugin "@fairmanager/cordova-plugin-push" in config.xml. Adding it > to the project > Failed to restore plugin "@fairmanager/cordova-plugin-push" from config.xml. > You might need to try adding it again. Error: Cannot find plugin.xml for > plugin "cordova-plugin-push". Please try adding it again. > ``` -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14194) Prepare fails when using scoped packages
Oliver Salzburg created CB-14194: Summary: Prepare fails when using scoped packages Key: CB-14194 URL: https://issues.apache.org/jira/browse/CB-14194 Project: Apache Cordova Issue Type: Bug Components: cordova-lib Affects Versions: Master Reporter: Oliver Salzburg When adding a plugin to a project, cordova will fail if the plugin is hosted under an npm scope. The scope is cut off when searching for the installation folder on disk: ``` Discovered plugin "@fairmanager/cordova-plugin-push" in config.xml. Adding it to the project Failed to restore plugin "@fairmanager/cordova-plugin-push" from config.xml. You might need to try adding it again. Error: Cannot find plugin.xml for plugin "cordova-plugin-push". Please try adding it again. ``` -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14097) Camera plugin crashes using getPicture on some files
[
https://issues.apache.org/jira/browse/CB-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533778#comment-16533778
]
ASF GitHub Bot commented on CB-14097:
-
bvmensvoort commented on issue #322: CB-14097: (android) Fix crash when
selecting some files with getPicture
URL:
https://github.com/apache/cordova-plugin-camera/pull/322#issuecomment-402750627
I have implemented the suggestions of the review.
Must be better now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Camera plugin crashes using getPicture on some files
>
>
> Key: CB-14097
> URL: https://issues.apache.org/jira/browse/CB-14097
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Affects Versions: Master
> Environment: At least tested on:
> Cordova 7.1.0
> Camera 4.0.3
> But the code is the same in master branch.
>Reporter: B. van Mensvoort
>Priority: Critical
> Fix For: Master
>
> Attachments: logcat.txt
>
>
> My app uses navigator.camera.getPicture to select files from a library.
> After selecting some files, the app crashes. Some files go well and it
> doesn't seem to happen on all devices.
> The crash happens in the FileHelper.java file and it the exception is:
> {{java.lang.NumberFormatException: For input string:
> "raw:/storage/emulated/0/Download/filename.PDF"}}
> It seems to be caused the way files are saved on the device. The urls of the
> files are different. When resaving the file, the URL can be as expected.
> Expected URL:
> {{content://com.android.providers.downloads.documents/document/}}
> Error URL:
> {{content://com.android.providers.downloads.documents/document/raw%3A%2Fstorage%2Femulated%2F0%2FDownload%2Ffilename.pdf}}
> The fix is the same as:
> [https://github.com/severianremi/uCrop/commit/9e2bb067631ac3bd3817c0fb55c51db3d61edfe0]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14097) Camera plugin crashes using getPicture on some files
[
https://issues.apache.org/jira/browse/CB-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533766#comment-16533766
]
ASF GitHub Bot commented on CB-14097:
-
bvmensvoort commented on a change in pull request #322: CB-14097: (android) Fix
crash when selecting some files with getPicture
URL:
https://github.com/apache/cordova-plugin-camera/pull/322#discussion_r200380526
##
File path: src/android/FileHelper.java
##
@@ -97,10 +98,19 @@ public static String
getRealPathFromURI_API11_And_Above(final Context context, f
else if (isDownloadsDocument(uri)) {
final String id = DocumentsContract.getDocumentId(uri);
-final Uri contentUri = ContentUris.withAppendedId(
-Uri.parse("content://downloads/public_downloads"),
Long.valueOf(id));
-
-return getDataColumn(context, contentUri, null, null);
+if (!TextUtils.isEmpty(id)) {
Review comment:
Good idea to remove the dependency
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Camera plugin crashes using getPicture on some files
>
>
> Key: CB-14097
> URL: https://issues.apache.org/jira/browse/CB-14097
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Affects Versions: Master
> Environment: At least tested on:
> Cordova 7.1.0
> Camera 4.0.3
> But the code is the same in master branch.
>Reporter: B. van Mensvoort
>Priority: Critical
> Fix For: Master
>
> Attachments: logcat.txt
>
>
> My app uses navigator.camera.getPicture to select files from a library.
> After selecting some files, the app crashes. Some files go well and it
> doesn't seem to happen on all devices.
> The crash happens in the FileHelper.java file and it the exception is:
> {{java.lang.NumberFormatException: For input string:
> "raw:/storage/emulated/0/Download/filename.PDF"}}
> It seems to be caused the way files are saved on the device. The urls of the
> files are different. When resaving the file, the URL can be as expected.
> Expected URL:
> {{content://com.android.providers.downloads.documents/document/}}
> Error URL:
> {{content://com.android.providers.downloads.documents/document/raw%3A%2Fstorage%2Femulated%2F0%2FDownload%2Ffilename.pdf}}
> The fix is the same as:
> [https://github.com/severianremi/uCrop/commit/9e2bb067631ac3bd3817c0fb55c51db3d61edfe0]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14193) navigator.camera.getPicture stopped working
Sunil Kr created CB-14193: - Summary: navigator.camera.getPicture stopped working Key: CB-14193 URL: https://issues.apache.org/jira/browse/CB-14193 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-camera Environment: Android. Reporter: Sunil Kr navigator.camera.getPicture stopped working. App crashed when I click a button which call a code to open camera -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14097) Camera plugin crashes using getPicture on some files
[
https://issues.apache.org/jira/browse/CB-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533516#comment-16533516
]
jcesarmobile commented on CB-14097:
---
I requested changes on the PR and they have not been addressed yet, so be
patient.
> Camera plugin crashes using getPicture on some files
>
>
> Key: CB-14097
> URL: https://issues.apache.org/jira/browse/CB-14097
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Affects Versions: Master
> Environment: At least tested on:
> Cordova 7.1.0
> Camera 4.0.3
> But the code is the same in master branch.
>Reporter: B. van Mensvoort
>Priority: Critical
> Fix For: Master
>
> Attachments: logcat.txt
>
>
> My app uses navigator.camera.getPicture to select files from a library.
> After selecting some files, the app crashes. Some files go well and it
> doesn't seem to happen on all devices.
> The crash happens in the FileHelper.java file and it the exception is:
> {{java.lang.NumberFormatException: For input string:
> "raw:/storage/emulated/0/Download/filename.PDF"}}
> It seems to be caused the way files are saved on the device. The urls of the
> files are different. When resaving the file, the URL can be as expected.
> Expected URL:
> {{content://com.android.providers.downloads.documents/document/}}
> Error URL:
> {{content://com.android.providers.downloads.documents/document/raw%3A%2Fstorage%2Femulated%2F0%2FDownload%2Ffilename.pdf}}
> The fix is the same as:
> [https://github.com/severianremi/uCrop/commit/9e2bb067631ac3bd3817c0fb55c51db3d61edfe0]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14097) Camera plugin crashes using getPicture on some files
[
https://issues.apache.org/jira/browse/CB-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533511#comment-16533511
]
Sunil Kr commented on CB-14097:
---
Hi Team,
I am also experiencing the same issue at end when I use
navigator.camera.getPicture, App crashed.
This is really a critical one.
> Camera plugin crashes using getPicture on some files
>
>
> Key: CB-14097
> URL: https://issues.apache.org/jira/browse/CB-14097
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Affects Versions: Master
> Environment: At least tested on:
> Cordova 7.1.0
> Camera 4.0.3
> But the code is the same in master branch.
>Reporter: B. van Mensvoort
>Priority: Critical
> Fix For: Master
>
> Attachments: logcat.txt
>
>
> My app uses navigator.camera.getPicture to select files from a library.
> After selecting some files, the app crashes. Some files go well and it
> doesn't seem to happen on all devices.
> The crash happens in the FileHelper.java file and it the exception is:
> {{java.lang.NumberFormatException: For input string:
> "raw:/storage/emulated/0/Download/filename.PDF"}}
> It seems to be caused the way files are saved on the device. The urls of the
> files are different. When resaving the file, the URL can be as expected.
> Expected URL:
> {{content://com.android.providers.downloads.documents/document/}}
> Error URL:
> {{content://com.android.providers.downloads.documents/document/raw%3A%2Fstorage%2Femulated%2F0%2FDownload%2Ffilename.pdf}}
> The fix is the same as:
> [https://github.com/severianremi/uCrop/commit/9e2bb067631ac3bd3817c0fb55c51db3d61edfe0]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14139) Can't run android commands with 32bit Java
[ https://issues.apache.org/jira/browse/CB-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533507#comment-16533507 ] ASF GitHub Bot commented on CB-14139: - janpio commented on issue #459: CB-14139 android: Add jvmargs flag for custom values URL: https://github.com/apache/cordova-android/pull/459#issuecomment-402683302 Huh @erisu? What happened? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Can't run android commands with 32bit Java > -- > > Key: CB-14139 > URL: https://issues.apache.org/jira/browse/CB-14139 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 8.0.0 > Environment: Win 10 Pro x64 >Reporter: misterTi >Assignee: Joe Bowser >Priority: Blocker > > GradleBuilder.js has a buiit-in option org.gradle.jvmargs=---Xmx2048m on line > 59, which prevents it from running on 32bit Java. It always fails with VM > heap error. The workaround is to create an environment variable > __JAVA__OPTIONS=-Xmx512m, but this then affects the whole system. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
