[jira] [Commented] (CB-14193) navigator.camera.getPicture stopped working
[ https://issues.apache.org/jira/browse/CB-14193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542552#comment-16542552 ] Sunil Kr commented on CB-14193: --- Cordova CLI version? - 6.5.0 cordova-android version? - 6.1.2 Plugin version? - 2.2.0 Android version of the device? - It's not working in any android device (Latest one as well) > navigator.camera.getPicture stopped working > --- > > Key: CB-14193 > URL: https://issues.apache.org/jira/browse/CB-14193 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android. >Reporter: Sunil Kr >Priority: Blocker > Labels: cordova-6.0.0, plugin-camera > > navigator.camera.getPicture stopped working. App crashed when I click a > button which call a code to open camera -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12016) remove plugin ID mapping
[ https://issues.apache.org/jira/browse/CB-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542502#comment-16542502 ] ASF GitHub Bot commented on CB-12016: - codecov-io commented on issue #33: CB-12016: (all) Removed cordova-registry-mapper dependency URL: https://github.com/apache/cordova-common/pull/33#issuecomment-404721486 # [Codecov](https://codecov.io/gh/apache/cordova-common/pull/33?src=pr=h1) Report > Merging [#33](https://codecov.io/gh/apache/cordova-common/pull/33?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-common/commit/7bf9627f0135c6b3518292660b6e07e6f5815926?src=pr=desc) will **increase** coverage by `0.27%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/cordova-common/pull/33?src=pr=tree) ```diff @@Coverage Diff@@ ## master #33 +/- ## = + Coverage 85.62% 85.9% +0.27% = Files 19 19 Lines17461738 -8 Branches 367 361 -6 = - Hits 14951493 -2 + Misses251 245 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-common/pull/33?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/PlatformJson.js](https://codecov.io/gh/apache/cordova-common/pull/33/diff?src=pr=tree#diff-c3JjL1BsYXRmb3JtSnNvbi5qcw==) | `82.35% <0%> (+4.17%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-common/pull/33?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-common/pull/33?src=pr=footer). Last update [7bf9627...59e5e9a](https://codecov.io/gh/apache/cordova-common/pull/33?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > remove plugin ID mapping > > > Key: CB-12016 > URL: https://issues.apache.org/jira/browse/CB-12016 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Steve Gill >Assignee: Audrey So >Priority: Major > Labels: cordova-7.0.0 > Fix For: 7.0.0, cordova@7.0.0 > > > For cordova@7, we can remove the cordova-registry-mapper module and remove > the automatic plugin mapping we do -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12016) remove plugin ID mapping
[ https://issues.apache.org/jira/browse/CB-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542457#comment-16542457 ] ASF GitHub Bot commented on CB-12016: - brodybits commented on issue #33: CB-12016: (all) Removed cordova-registry-mapper dependency URL: https://github.com/apache/cordova-common/pull/33#issuecomment-404714550 ❤️ hope it doesn't break anything, no time to check this week unfortunately. Any comments from @raphinesse or @dpogue? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > remove plugin ID mapping > > > Key: CB-12016 > URL: https://issues.apache.org/jira/browse/CB-12016 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Steve Gill >Assignee: Audrey So >Priority: Major > Labels: cordova-7.0.0 > Fix For: 7.0.0, cordova@7.0.0 > > > For cordova@7, we can remove the cordova-registry-mapper module and remove > the automatic plugin mapping we do -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12016) remove plugin ID mapping
[ https://issues.apache.org/jira/browse/CB-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542454#comment-16542454 ] ASF GitHub Bot commented on CB-12016: - erisu opened a new pull request #33: CB-12016: (all) Removed cordova-registry-mapper dependency URL: https://github.com/apache/cordova-common/pull/33 ### Platforms affected all ### What does this PR do? Remove a forgotten dead dependency. Ticket [CB-12016](https://issues.apache.org/jira/browse/CB-12016) was to remove this dependency and had been resolved but appears `cordova-common` was forgotten. ### What testing has been done on this change? Tested adding plugins with old and new package name. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > remove plugin ID mapping > > > Key: CB-12016 > URL: https://issues.apache.org/jira/browse/CB-12016 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Steve Gill >Assignee: Audrey So >Priority: Major > Labels: cordova-7.0.0 > Fix For: 7.0.0, cordova@7.0.0 > > > For cordova@7, we can remove the cordova-registry-mapper module and remove > the automatic plugin mapping we do -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542093#comment-16542093 ] ASF GitHub Bot commented on CB-14166: - oliversalzburg commented on issue #622: CB-14166: (cli) Fixed issue when installing plugins on windows URL: https://github.com/apache/cordova-lib/pull/622#issuecomment-404614684 I rebased this on top of master and I'm still seeing the e2e test failures. Even more than that, I have a couple of additional failures due to https://github.com/apache/cordova-fetch/pull/25 So the cascade goes on for me, but the failures noted above are legit. However, I don't see how these are related to this change. CC: @brodybits This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14194) Prepare fails when using scoped packages
[
https://issues.apache.org/jira/browse/CB-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541908#comment-16541908
]
ASF GitHub Bot commented on CB-14194:
-
brodybits commented on issue #625: CB-14194: Don't cut off scope from package
identifier
URL: https://github.com/apache/cordova-lib/pull/625#issuecomment-404573599
> I expect that I'll also need #622
Something else for one of us (you?) to revive in a new PR?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Prepare fails when using scoped packages
>
>
> Key: CB-14194
> URL: https://issues.apache.org/jira/browse/CB-14194
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: Master
>Reporter: Oliver Salzburg
>Priority: Major
>
> When adding a plugin to a project, cordova will fail if the plugin is hosted
> under an npm scope.
> The scope is cut off when searching for the installation folder on disk:
> {code}
> Discovered plugin "@fairmanager/cordova-plugin-push" in config.xml. Adding it
> to the project
> Failed to restore plugin "@fairmanager/cordova-plugin-push" from config.xml.
> You might need to try adding it again. Error: Cannot find plugin.xml for
> plugin "cordova-plugin-push". Please try adding it again.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14194) Prepare fails when using scoped packages
[
https://issues.apache.org/jira/browse/CB-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541884#comment-16541884
]
ASF GitHub Bot commented on CB-14194:
-
oliversalzburg commented on issue #625: CB-14194: Don't cut off scope from
package identifier
URL: https://github.com/apache/cordova-lib/pull/625#issuecomment-404567472
Yeah, I'll look into it later today, but I expect that I'll also need #622
to get a working setup to even approach this, as I'm primarily working on
Windows.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Prepare fails when using scoped packages
>
>
> Key: CB-14194
> URL: https://issues.apache.org/jira/browse/CB-14194
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: Master
>Reporter: Oliver Salzburg
>Priority: Major
>
> When adding a plugin to a project, cordova will fail if the plugin is hosted
> under an npm scope.
> The scope is cut off when searching for the installation folder on disk:
> {code}
> Discovered plugin "@fairmanager/cordova-plugin-push" in config.xml. Adding it
> to the project
> Failed to restore plugin "@fairmanager/cordova-plugin-push" from config.xml.
> You might need to try adding it again. Error: Cannot find plugin.xml for
> plugin "cordova-plugin-push". Please try adding it again.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541706#comment-16541706 ] ASF GitHub Bot commented on CB-14166: - dpogue commented on issue #622: CB-14166: (cli) Fixed issue when installing plugins on windows URL: https://github.com/apache/cordova-lib/pull/622#issuecomment-404526546 I suspect unrelated. Would be good to rebase this against master both to get much more stable tests and to resolve the conflict. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541702#comment-16541702 ] ASF GitHub Bot commented on CB-14166: - janpio commented on issue #622: CB-14166: (cli) Fixed issue when installing plugins on windows URL: https://github.com/apache/cordova-lib/pull/622#issuecomment-404526363 Oh and it seems in the meantime the file was changed by someone else, causing a conflict in this PR. Should be pretty simple to fix and resolve, could you have a look please @AlmirKadric ? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541700#comment-16541700 ] ASF GitHub Bot commented on CB-14166: - janpio commented on issue #622: CB-14166: (cli) Fixed issue when installing plugins on windows URL: https://github.com/apache/cordova-lib/pull/622#issuecomment-404526010 Unfortunately seems to be failing on Windows/ AppVeyor: ``` Failures: 1) update pkg.json AND config.xml to include all plugins/merge variables and check for duplicates Test#014 : update pkg.json AND config.xml to include all plugins and merge variables (no dupes) Message: Expected '^2.3.0' to equal '^2.4.1'. Stack: Error: Expected '^2.3.0' to equal '^2.4.1'. at at C:\projects\cordova-lib\integration-tests\pkgJson-restore.spec.js:1068:47 at _fulfilled (C:\projects\cordova-lib\node_modules\q\q.js:854:54) at self.promiseDispatch.done (C:\projects\cordova-lib\node_modules\q\q.js:883:30) at Promise.promise.promiseDispatch (C:\projects\cordova-lib\node_modules\q\q.js:816:13) Message: Expected '^2.3.0' to equal '^2.4.1'. Stack: Error: Expected '^2.3.0' to equal '^2.4.1'. at at C:\projects\cordova-lib\integration-tests\pkgJson-restore.spec.js:1088:67 at _fulfilled (C:\projects\cordova-lib\node_modules\q\q.js:854:54) at self.promiseDispatch.done (C:\projects\cordova-lib\node_modules\q\q.js:883:30) at Promise.promise.promiseDispatch (C:\projects\cordova-lib\node_modules\q\q.js:816:13) 2) update config.xml to include the plugin that is in pkg.json Test#015 : update config.xml to include all plugins/variables from pkg.json Message: Expected '^2.3.0' to equal '^2.4.1'. Stack: Error: Expected '^2.3.0' to equal '^2.4.1'. at at C:\projects\cordova-lib\integration-tests\pkgJson-restore.spec.js:1184:71 at _fulfilled (C:\projects\cordova-lib\node_modules\q\q.js:854:54) at self.promiseDispatch.done (C:\projects\cordova-lib\node_modules\q\q.js:883:30) at Promise.promise.promiseDispatch (C:\projects\cordova-lib\node_modules\q\q.js:816:13) Message: Expected '^2.3.0' to equal '^2.4.1'. Stack: Error: Expected '^2.3.0' to equal '^2.4.1'. at at C:\projects\cordova-lib\integration-tests\pkgJson-restore.spec.js:1189:47 at _fulfilled (C:\projects\cordova-lib\node_modules\q\q.js:854:54) at self.promiseDispatch.done (C:\projects\cordova-lib\node_modules\q\q.js:883:30) at Promise.promise.promiseDispatch (C:\projects\cordova-lib\node_modules\q\q.js:816:13) Message: Expected $.spec = '^2.3.0' to equal '^2.4.1'. Stack: Error: Expected $.spec = '^2.3.0' to equal '^2.4.1'. at at C:\projects\cordova-lib\integration-tests\pkgJson-restore.spec.js:1193:39 at _fulfilled (C:\projects\cordova-lib\node_modules\q\q.js:854:54) at self.promiseDispatch.done (C:\projects\cordova-lib\node_modules\q\q.js:883:30) at Promise.promise.promiseDispatch (C:\projects\cordova-lib\node_modules\q\q.js:816:13) ``` Is this a new problem caused by this PR or unrelated test failure? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional
[jira] [Created] (CB-14206) iOS 12 support
Thiago Marafon created CB-14206: --- Summary: iOS 12 support Key: CB-14206 URL: https://issues.apache.org/jira/browse/CB-14206 Project: Apache Cordova Issue Type: Bug Components: cordova-ios Reporter: Thiago Marafon iOS 12 is planned to be released this fall. But we are already doing POCs with its new features. Is there a plan to add support to this new version? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14148) cordova platform ls shows nonsense www ^3.12.0 platform
[
https://issues.apache.org/jira/browse/CB-14148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541689#comment-16541689
]
ASF GitHub Bot commented on CB-14148:
-
dpogue commented on issue #620: CB-14148 remove nonsense "www" platform from
listing
URL: https://github.com/apache/cordova-lib/pull/620#issuecomment-404522764
I do not :disappointed:
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> cordova platform ls shows nonsense www ^3.12.0 platform
> ---
>
> Key: CB-14148
> URL: https://issues.apache.org/jira/browse/CB-14148
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli, cordova-common, cordova-lib
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Minor
>
> As I already reported in
> [apache/cordova-discuss#86|https://github.com/apache/cordova-discuss/issues/86]
> and saw someone else report in Slack:
> {code:bash}
> $ cordova --version
> 8.0.0
> {code}
> {code:bash}
> $ cordova platform ls
> Installed platforms:
>
> Available platforms:
> android ~7.0.0
> browser ~5.0.1
> ios ~4.5.4
> osx ~4.0.1
> windows ~5.0.0
> www ^3.12.0
> {code}
> If I would do {{cordova platform add www}}:
> {code:bash}
> $ cordova platform add www
> (node:10383) UnhandledPromiseRejectionWarning: CordovaError: Error: npm:
> Command failed with exit code 1 Error output:
> npm ERR! code ENOLOCAL
> npm ERR! Could not install from "www" as it does not contain a package.json
> file.
> npm ERR! A complete log of this run can be found in:
> npm ERR! /Users/brodybits/.npm/_logs/2018-01-04T04_21_59_700Z-debug.log
> at
> /Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/cordova-fetch/index.js:104:29
> at _rejected
> (/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:864:24)
> at
> /Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:890:30
> at Promise.when
> (/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:1142:31)
> at Promise.promise.promiseDispatch
> (/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:808:41)
> at
> /Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:624:44
> at runSingle
> (/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:137:13)
> at flush
> (/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:125:13)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> (node:10383) UnhandledPromiseRejectionWarning: Unhandled promise rejection.
> This error originated either by throwing inside of an async function without
> a catch block, or by rejecting a promise which was not handled with .catch().
> (rejection id: 1)
> (node:10383) [DEP0018] DeprecationWarning: Unhandled promise rejections are
> deprecated. In the future, promise rejections that are not handled will
> terminate the Node.js process with a non-zero exit code.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14194) Prepare fails when using scoped packages
[
https://issues.apache.org/jira/browse/CB-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541642#comment-16541642
]
ASF GitHub Bot commented on CB-14194:
-
brodybits commented on issue #625: CB-14194: Don't cut off scope from package
identifier
URL: https://github.com/apache/cordova-lib/pull/625#issuecomment-404512619
@oliversalzburg I wonder if you should start with #602, fix it up, add your
other enhancements, and raise a new PR that says something like "closes #602"
or "resolves #602"?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Prepare fails when using scoped packages
>
>
> Key: CB-14194
> URL: https://issues.apache.org/jira/browse/CB-14194
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: Master
>Reporter: Oliver Salzburg
>Priority: Major
>
> When adding a plugin to a project, cordova will fail if the plugin is hosted
> under an npm scope.
> The scope is cut off when searching for the installation folder on disk:
> {code}
> Discovered plugin "@fairmanager/cordova-plugin-push" in config.xml. Adding it
> to the project
> Failed to restore plugin "@fairmanager/cordova-plugin-push" from config.xml.
> You might need to try adding it again. Error: Cannot find plugin.xml for
> plugin "cordova-plugin-push". Please try adding it again.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14194) Prepare fails when using scoped packages
[
https://issues.apache.org/jira/browse/CB-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541640#comment-16541640
]
ASF GitHub Bot commented on CB-14194:
-
oliversalzburg commented on issue #625: CB-14194: Don't cut off scope from
package identifier
URL: https://github.com/apache/cordova-lib/pull/625#issuecomment-404511707
@raphinesse I'd say #602 covers a lot more cases and should probably be
preferred. I suspect @akdor1154 has a much better understanding of the subject
at hand than I do.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Prepare fails when using scoped packages
>
>
> Key: CB-14194
> URL: https://issues.apache.org/jira/browse/CB-14194
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: Master
>Reporter: Oliver Salzburg
>Priority: Major
>
> When adding a plugin to a project, cordova will fail if the plugin is hosted
> under an npm scope.
> The scope is cut off when searching for the installation folder on disk:
> {code}
> Discovered plugin "@fairmanager/cordova-plugin-push" in config.xml. Adding it
> to the project
> Failed to restore plugin "@fairmanager/cordova-plugin-push" from config.xml.
> You might need to try adding it again. Error: Cannot find plugin.xml for
> plugin "cordova-plugin-push". Please try adding it again.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-14202) Unexplained Android build failure when drawables added.
[
https://issues.apache.org/jira/browse/CB-14202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jcesarmobile closed CB-14202.
-
Resolution: Duplicate
This was already reported and fixed. There will be a 7.1.1 release soon fixing
the problem
> Unexplained Android build failure when drawables added.
> ---
>
> Key: CB-14202
> URL: https://issues.apache.org/jira/browse/CB-14202
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: 7.0.0, 7.1.0
> Environment: cordova 8.0.8
> cordova-android 7.0.0
>Reporter: Robert Brenton
>Priority: Minor
>
> If you create an Android project with version 7.0.0 or 7.1.0 and create a res
> directory in platforms/android/res the build fails with a confusing message.
> Some plugins create this directory and or have instructions are to copy
> drawables into this directory.
> Potential solutions could be
> # More descriptive error
> # Better detection that is a Android Studio project would allow for better
> diagnoses of this failure
> # Suggest to user to move the drawables to the Android Studio project format
> indicating the presence of the res directory and the app directory
> To reproduce
> # cordova create test9 com.Test.Test9
> # cordova platform add android
> # mkdir -p platforms/android/res/drawable
> # cp image.png platforms/android/res/drawable
> # cordova build --verbose
> *The error*
> {{Generating platform-specific config.xml from defaults for android at
> /tmp/test9/platforms/android/res/xml/config.xml}}
> {{cp: copyFileSync: could not write to dest file
> (code=ENOENT):/tmp/test9/platforms/android/res/xml/config.xml}}{{Merging
> project's config.xml into platform-specific android config.xml}}
> {{Parsing /tmp/test9/platforms/android/res/xml/config.xml failed}}
> {{(node:20148) UnhandledPromiseRejectionWarning: Unhandled promise rejection
> (rejection id: 1): Error: ENOENT: no such file or directory, open
> '/tmp/test9/platforms/android/res/xml/config.xml'}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-14204) Cannot bring up keyboard instantly after upgrading to ios 11.4
[ https://issues.apache.org/jira/browse/CB-14204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-14204. - Resolution: Not A Problem This is not a Cordova problem, is an iOS problem, you should report it to Apple > Cannot bring up keyboard instantly after upgrading to ios 11.4 > -- > > Key: CB-14204 > URL: https://issues.apache.org/jira/browse/CB-14204 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: 3.8.0, 4.5.0 > Environment: # Objective C > # Ember 1.13.8 > # Cordova 3.8.0 (also having the issue in 4.5.4) > # Xcode 9.2 >Reporter: Arun Joseph W >Priority: Major > > Cannot bring up keyboard instantly after upgrading to iOS 11.4. User has to > touch the keyboard for extra 0.5 seconds to bring up the keyboard (on input > text element). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14205) Add hints to error messages
[ https://issues.apache.org/jira/browse/CB-14205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541529#comment-16541529 ] jcesarmobile commented on CB-14205: --- I think Cordova used to use the Android Studio version, but then in Android Studio 3, Google changed the permissions and could not be uses anymore (I think it only affects macOS) See related issue about the permissions problem https://issues.apache.org/jira/browse/CB-13495 > Add hints to error messages > --- > > Key: CB-14205 > URL: https://issues.apache.org/jira/browse/CB-14205 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Minor > > As discussed in [this Cordova-Android 7.1.1 > thread|https://lists.apache.org/thread.html/dc48de471e8101d928b74d53497e1e5c50e59727d43e68b49bcac55b@%3Cdev.cordova.apache.org%3E] > cordova-android generates an unclear error message if Gradle is not present. > I think the best solution would be for error messages to point to help pages > that describe what the user has to do. > This message is marked for cordova-android; I would like to apply a similar > solution to the other tools and platforms packages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14205) Add hints to error messages
Chris Brody created CB-14205: Summary: Add hints to error messages Key: CB-14205 URL: https://issues.apache.org/jira/browse/CB-14205 Project: Apache Cordova Issue Type: Improvement Components: cordova-android Reporter: Chris Brody Assignee: Chris Brody As discussed in [this Cordova-Android 7.1.1 thread|https://lists.apache.org/thread.html/dc48de471e8101d928b74d53497e1e5c50e59727d43e68b49bcac55b@%3Cdev.cordova.apache.org%3E] cordova-android generates an unclear error message if Gradle is not present. I think the best solution would be for error messages to point to help pages that describe what the user has to do. This message is marked for cordova-android; I would like to apply a similar solution to the other tools and platforms packages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14194) Prepare fails when using scoped packages
[
https://issues.apache.org/jira/browse/CB-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541458#comment-16541458
]
ASF GitHub Bot commented on CB-14194:
-
raphinesse commented on issue #625: CB-14194: Don't cut off scope from package
identifier
URL: https://github.com/apache/cordova-lib/pull/625#issuecomment-404469035
How is this related to #602?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Prepare fails when using scoped packages
>
>
> Key: CB-14194
> URL: https://issues.apache.org/jira/browse/CB-14194
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: Master
>Reporter: Oliver Salzburg
>Priority: Major
>
> When adding a plugin to a project, cordova will fail if the plugin is hosted
> under an npm scope.
> The scope is cut off when searching for the installation folder on disk:
> {code}
> Discovered plugin "@fairmanager/cordova-plugin-push" in config.xml. Adding it
> to the project
> Failed to restore plugin "@fairmanager/cordova-plugin-push" from config.xml.
> You might need to try adding it again. Error: Cannot find plugin.xml for
> plugin "cordova-plugin-push". Please try adding it again.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14148) cordova platform ls shows nonsense www ^3.12.0 platform
[
https://issues.apache.org/jira/browse/CB-14148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541454#comment-16541454
]
ASF GitHub Bot commented on CB-14148:
-
raphinesse commented on issue #620: CB-14148 remove nonsense "www" platform
from listing
URL: https://github.com/apache/cordova-lib/pull/620#issuecomment-404468448
@dpogue @stevengill do you have any idea what the `www` platform's purpose
is or was?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> cordova platform ls shows nonsense www ^3.12.0 platform
> ---
>
> Key: CB-14148
> URL: https://issues.apache.org/jira/browse/CB-14148
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli, cordova-common, cordova-lib
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Minor
>
> As I already reported in
> [apache/cordova-discuss#86|https://github.com/apache/cordova-discuss/issues/86]
> and saw someone else report in Slack:
> {code:bash}
> $ cordova --version
> 8.0.0
> {code}
> {code:bash}
> $ cordova platform ls
> Installed platforms:
>
> Available platforms:
> android ~7.0.0
> browser ~5.0.1
> ios ~4.5.4
> osx ~4.0.1
> windows ~5.0.0
> www ^3.12.0
> {code}
> If I would do {{cordova platform add www}}:
> {code:bash}
> $ cordova platform add www
> (node:10383) UnhandledPromiseRejectionWarning: CordovaError: Error: npm:
> Command failed with exit code 1 Error output:
> npm ERR! code ENOLOCAL
> npm ERR! Could not install from "www" as it does not contain a package.json
> file.
> npm ERR! A complete log of this run can be found in:
> npm ERR! /Users/brodybits/.npm/_logs/2018-01-04T04_21_59_700Z-debug.log
> at
> /Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/cordova-fetch/index.js:104:29
> at _rejected
> (/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:864:24)
> at
> /Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:890:30
> at Promise.when
> (/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:1142:31)
> at Promise.promise.promiseDispatch
> (/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:808:41)
> at
> /Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:624:44
> at runSingle
> (/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:137:13)
> at flush
> (/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:125:13)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> (node:10383) UnhandledPromiseRejectionWarning: Unhandled promise rejection.
> This error originated either by throwing inside of an async function without
> a catch block, or by rejecting a promise which was not handled with .catch().
> (rejection id: 1)
> (node:10383) [DEP0018] DeprecationWarning: Unhandled promise rejections are
> deprecated. In the future, promise rejections that are not handled will
> terminate the Node.js process with a non-zero exit code.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-14020) cordova-plugin-geolocation crashes with "Collection was mutated while being enumerated"
[ https://issues.apache.org/jira/browse/CB-14020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile resolved CB-14020. --- Resolution: Fixed Fixed in 4.0.2-dev > cordova-plugin-geolocation crashes with "Collection was mutated while being > enumerated" > --- > > Key: CB-14020 > URL: https://issues.apache.org/jira/browse/CB-14020 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-geolocation >Affects Versions: Master > Environment: iOS 11 > cordova-ios@4.3.1 > cordova-plugin-geolocation@2.4.2 > Although I am running an older version, this issue does not appear to be > fixed in the latest plugin version as the relevant code has not been changed. > The javascript in my app is making multiple calls to > `navigator.geolocation.getCurrentPosition()` in rapid succession. >Reporter: Elijah R >Priority: Major > Labels: crash, easyfix, pull-request-available, race-condition > Attachments: crash-log.txt > > > There is a race condition in CDVLocation.m. The > self.locationData.locationCallbacks array can be mutated in one thread and > enumerated concurrently in another thread, which causes the app to crash with > the following exception: > Fatal Exception: NSGenericException > Collection <__NSArrayM: 0x1d444d020> was mutated while being enumerated. > The exception is raised at [CDVLocation returnLocationError:withMessage:] > (CDVLocation.m:312) > I am unable to reproduce the issue, however it is a common crash for users of > my app. A user named seeday on github has opened a pull request to address > this issue: https://github.com/apache/cordova-plugin-geolocation/pull/91 > I'm filing this bug to help get that work merged. > I've attached an abridged crash log with the relevant stack trace. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14020) cordova-plugin-geolocation crashes with "Collection was mutated while being enumerated"
[ https://issues.apache.org/jira/browse/CB-14020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541450#comment-16541450 ] ASF GitHub Bot commented on CB-14020: - Unibozu commented on issue #104: CB-14020: (ios) Fix "Collection was mutated while being enumerated" crash URL: https://github.com/apache/cordova-plugin-geolocation/pull/104#issuecomment-404466835 Thanks @jcesarmobile! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-plugin-geolocation crashes with "Collection was mutated while being > enumerated" > --- > > Key: CB-14020 > URL: https://issues.apache.org/jira/browse/CB-14020 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-geolocation >Affects Versions: Master > Environment: iOS 11 > cordova-ios@4.3.1 > cordova-plugin-geolocation@2.4.2 > Although I am running an older version, this issue does not appear to be > fixed in the latest plugin version as the relevant code has not been changed. > The javascript in my app is making multiple calls to > `navigator.geolocation.getCurrentPosition()` in rapid succession. >Reporter: Elijah R >Priority: Major > Labels: crash, easyfix, pull-request-available, race-condition > Attachments: crash-log.txt > > > There is a race condition in CDVLocation.m. The > self.locationData.locationCallbacks array can be mutated in one thread and > enumerated concurrently in another thread, which causes the app to crash with > the following exception: > Fatal Exception: NSGenericException > Collection <__NSArrayM: 0x1d444d020> was mutated while being enumerated. > The exception is raised at [CDVLocation returnLocationError:withMessage:] > (CDVLocation.m:312) > I am unable to reproduce the issue, however it is a common crash for users of > my app. A user named seeday on github has opened a pull request to address > this issue: https://github.com/apache/cordova-plugin-geolocation/pull/91 > I'm filing this bug to help get that work merged. > I've attached an abridged crash log with the relevant stack trace. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-14033) `cordova plugin add` skips directory on windows
[
https://issues.apache.org/jira/browse/CB-14033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raphael resolved CB-14033.
--
Resolution: Fixed
> `cordova plugin add` skips directory on windows
> ---
>
> Key: CB-14033
> URL: https://issues.apache.org/jira/browse/CB-14033
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
> Environment: Cordova 6.2.0
>Reporter: Jack Lu
>Assignee: Raphael
>Priority: Major
>
> Suppose we have a cordova plugin project and a test project that are under
> the same directory. The {color:#33}cordova plugin project {color}is in
> directory p, and the test project in directory t. When I run following
> command in directory t:
>
> {code:java}
> cordova plugin add ..\p
> {code}
> the install fails, and I found it's due to the src directory missing during
> copying.
> After digging into the source, I found it's caused by a special handling in
> the fetch action{color:#33} on windows{color}. The source is
> {color:#33}[https://github.com/apache/cordova-lib/blob/master/src/plugman/fetch.js#L299]{color}.
> {code:java}
> /*
> [CB-10423]
> This is a special case. On windows we cannot create a symlink
> unless we are run as admin
> The error that we have is because src contains dest, so we
> end up with a recursive folder explosion
> This code avoids copy the one folder that will explode, and
> allows plugins to contain a demo project
> and to install the plugin via `cordova plugin add ../`
> */
> var resolvedSrcPath = path.resolve(plugin_dir);
> var filenames = fs.readdirSync(resolvedSrcPath);
> var relPath = path.relative(resolvedSrcPath,dest);
> var relativeRootFolder = relPath.split('\\')[0];
> filenames.splice(filenames.indexOf(relativeRootFolder),1);
> {code}
> in this case {color:#33}relPath{color} will be "..\t\plugins\plugin
> id", {color:#33}relativeRootFolder{color} be "..", then
> {color:#33}filenames.indexOf(relativeRootFolder){color} be -1, finally
> filenames lost the last element, which is the src directory in my case.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14033) `cordova plugin add` skips directory on windows
[
https://issues.apache.org/jira/browse/CB-14033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541448#comment-16541448
]
ASF GitHub Bot commented on CB-14033:
-
raphinesse closed pull request #621: CB-14033 Support symbolic dir links on
Windows
URL: https://github.com/apache/cordova-lib/pull/621
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/integration-tests/plugman_fetch.spec.js
b/integration-tests/plugman_fetch.spec.js
index 4895bee07..e01010131 100644
--- a/integration-tests/plugman_fetch.spec.js
+++ b/integration-tests/plugman_fetch.spec.js
@@ -94,7 +94,7 @@ describe('fetch', function () {
});
it('Test 003 : should create a symlink if used with `link` param',
function () {
return fetch(test_plugin, temp, { link: true }).then(function () {
-expect(sym).toHaveBeenCalledWith(test_plugin, path.join(temp,
test_plugin_id), 'dir');
+expect(sym).toHaveBeenCalledWith(test_plugin, path.join(temp,
test_plugin_id), 'junction');
});
});
@@ -152,23 +152,13 @@ describe('fetch', function () {
return Q(pluginDir);
});
-if (/^win/.test(process.platform)) {
-it('Test 020 : should copy all but the /demo/ folder', function ()
{
-var cp = spyOn(shell, 'cp');
-return fetch(srcDir, appDir).then(function () {
-expect(cp).toHaveBeenCalledWith('-R', path.join(srcDir,
'asset.txt'), path.join(appDir, 'test-recursive'));
-expect(cp).not.toHaveBeenCalledWith('-R', srcDir,
path.join(appDir, 'test-recursive'));
-});
-});
-} else {
-it('Test 021 : should skip copy to avoid recursive error',
function () {
+it('Test 021 : should skip copy to avoid recursive error', function ()
{
-var cp = spyOn(shell, 'cp').and.callFake(function () {});
+var cp = spyOn(shell, 'cp').and.callFake(function () {});
-return fetch(srcDir, appDir).then(function () {
-expect(cp).not.toHaveBeenCalled();
-});
+return fetch(srcDir, appDir).then(function () {
+expect(cp).not.toHaveBeenCalled();
});
-}
+});
});
});
diff --git a/src/plugman/fetch.js b/src/plugman/fetch.js
index 221e21ccb..7fe69209e 100644
--- a/src/plugman/fetch.js
+++ b/src/plugman/fetch.js
@@ -279,39 +279,15 @@ function copyPlugin (pinfo, plugins_dir, link) {
shell.rm('-rf', dest);
if (!link && dest.indexOf(path.resolve(plugin_dir) + path.sep) === 0) {
-
-if (/^win/.test(process.platform)) {
-/*
-[CB-10423]
-This is a special case. On windows we cannot create a symlink
unless we are run as admin
-The error that we have is because src contains dest, so we end
up with a recursive folder explosion
-This code avoids copy the one folder that will explode, and
allows plugins to contain a demo project
-and to install the plugin via `cordova plugin add ../`
-*/
-var resolvedSrcPath = path.resolve(plugin_dir);
-var filenames = fs.readdirSync(resolvedSrcPath);
-var relPath = path.relative(resolvedSrcPath, dest);
-var relativeRootFolder = relPath.split('\\')[0];
-filenames.splice(filenames.indexOf(relativeRootFolder), 1);
-shell.mkdir('-p', dest);
-events.emit('verbose', 'Copying plugin "' + resolvedSrcPath + '"
=> "' + dest + '"');
-events.emit('verbose', 'Skipping folder "' + relativeRootFolder +
'"');
-
-filenames.forEach(function (elem) {
-shell.cp('-R', path.join(resolvedSrcPath, elem), dest);
-});
-return dest;
-} else {
-events.emit('verbose', 'Copy plugin destination is child of src.
Forcing --link mode.');
-link = true;
-}
+events.emit('verbose', 'Copy plugin destination is child of src.
Forcing --link mode.');
+link = true;
}
if (link) {
var isRelativePath = plugin_dir.charAt(1) !== ':' &&
plugin_dir.charAt(0) !== path.sep;
var fixedPath = isRelativePath ? path.join(path.relative(plugins_dir,
process.env.PWD || process.cwd()), plugin_dir) : plugin_dir;
events.emit('verbose', 'Linking "' + dest + '" => "' + fixedPath +
'"');
-fs.symlinkSync(fixedPath, dest, 'dir');
+fs.symlinkSync(fixedPath, dest, 'junction');
} else {
shell.mkdir('-p', dest);
events.emit('verbose',
[jira] [Commented] (CB-14033) `cordova plugin add` skips directory on windows
[
https://issues.apache.org/jira/browse/CB-14033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541447#comment-16541447
]
ASF subversion and git services commented on CB-14033:
--
Commit 17f5b7fb51a5aed9b0302f855d40be97ce587952 in cordova-lib's branch
refs/heads/master from Raphael von der Grün
[ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=17f5b7f ]
CB-14033 Support symbolic dir links on Windows (#621)
This uses junctions whenever creating directory symlinks on Windows
since that does not require any special privileges.
> `cordova plugin add` skips directory on windows
> ---
>
> Key: CB-14033
> URL: https://issues.apache.org/jira/browse/CB-14033
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
> Environment: Cordova 6.2.0
>Reporter: Jack Lu
>Assignee: Raphael
>Priority: Major
>
> Suppose we have a cordova plugin project and a test project that are under
> the same directory. The {color:#33}cordova plugin project {color}is in
> directory p, and the test project in directory t. When I run following
> command in directory t:
>
> {code:java}
> cordova plugin add ..\p
> {code}
> the install fails, and I found it's due to the src directory missing during
> copying.
> After digging into the source, I found it's caused by a special handling in
> the fetch action{color:#33} on windows{color}. The source is
> {color:#33}[https://github.com/apache/cordova-lib/blob/master/src/plugman/fetch.js#L299]{color}.
> {code:java}
> /*
> [CB-10423]
> This is a special case. On windows we cannot create a symlink
> unless we are run as admin
> The error that we have is because src contains dest, so we
> end up with a recursive folder explosion
> This code avoids copy the one folder that will explode, and
> allows plugins to contain a demo project
> and to install the plugin via `cordova plugin add ../`
> */
> var resolvedSrcPath = path.resolve(plugin_dir);
> var filenames = fs.readdirSync(resolvedSrcPath);
> var relPath = path.relative(resolvedSrcPath,dest);
> var relativeRootFolder = relPath.split('\\')[0];
> filenames.splice(filenames.indexOf(relativeRootFolder),1);
> {code}
> in this case {color:#33}relPath{color} will be "..\t\plugins\plugin
> id", {color:#33}relativeRootFolder{color} be "..", then
> {color:#33}filenames.indexOf(relativeRootFolder){color} be -1, finally
> filenames lost the last element, which is the src directory in my case.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14204) Cannot bring up keyboard instantly after upgrading to ios 11.4
Arun Joseph W created CB-14204: -- Summary: Cannot bring up keyboard instantly after upgrading to ios 11.4 Key: CB-14204 URL: https://issues.apache.org/jira/browse/CB-14204 Project: Apache Cordova Issue Type: Bug Components: cordova-ios Affects Versions: 3.8.0, 4.5.0 Environment: # Objective C # Ember 1.13.8 # Cordova 3.8.0 (also having the issue in 4.5.4) # Xcode 9.2 Reporter: Arun Joseph W Cannot bring up keyboard instantly after upgrading to iOS 11.4. User has to touch the keyboard for extra 0.5 seconds to bring up the keyboard (on input text element). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13245) Filereader.readAsText fails on Android with long text files when
[ https://issues.apache.org/jira/browse/CB-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541405#comment-16541405 ] ASF GitHub Bot commented on CB-13245: - AnthonyWard commented on issue #217: CB-13245: (android) Fix bug caused by negative length reported for an asset URL: https://github.com/apache/cordova-plugin-file/pull/217#issuecomment-404457427 This should be resolved now in version 7.1.1 of cordova-androd CB-13923 (android) fix -1 length for compressed files https://github.com/apache/cordova-android/blob/7.1.x/RELEASENOTES.md This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Filereader.readAsText fails on Android with long text files when > > > Key: CB-13245 > URL: https://issues.apache.org/jira/browse/CB-13245 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file >Affects Versions: Master > Environment: Android 7.1.1 >Reporter: Daniel Behnen >Priority: Major > > When reader.readAsText is called with an URI pointing to a local asset with a > size greater than READ_CHUNK_SIZE = 256 * 1024, loading produces corrupt > data. > The behaviour is caused by a negative length returned by > CordovaResourceApi.openForRead() when the URI is a URI_TYPE_ASSET. Given the > negative length, Filesystem.readFileAtURL() returns the whole file instead of > the desired part and FileReader.readSuccessCallback() does not check the > returned buffer size. Hence, the following chunks are attated to the buffer > regardless of whether the file was already completely read. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13193) Setting orientation to landscape might turn UI upside down if already in landscape
[
https://issues.apache.org/jira/browse/CB-13193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541359#comment-16541359
]
ASF GitHub Bot commented on CB-13193:
-
sbatezat commented on issue #25: CB-13193: (ios) Fixed Lock iOS Landscape
Orientation turn up-sidedown
URL:
https://github.com/apache/cordova-plugin-screen-orientation/pull/25#issuecomment-404445082
Any chance to see this PR released in a tag?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Setting orientation to landscape might turn UI upside down if already in
> landscape
> --
>
> Key: CB-13193
> URL: https://issues.apache.org/jira/browse/CB-13193
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-screen-orientation
>Reporter: Jonathan Herdt
>Assignee: Vishal Mishra
>Priority: Major
>
> Steps to reproduce:
> # Set up an app to lock its orientation to 'landscape' at startup via
> `screen.orientation.lock('landscape')`
> # Set device to landscape-left (home button on left side)
> # Start app
> # Observe UI turning upside down
> Desired behavior: Rotation is locked but UI does not turn upside down
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
