[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603949#comment-16603949
]
ASF GitHub Bot commented on CB-13685:
-
erisu edited a comment on issue #830: CB-13685 android: Added adaptive icon docs
URL: https://github.com/apache/cordova-docs/pull/830#issuecomment-418608412
@dpogue I believe it should be OK to merge.
The updated docs are in `www/docs/en/dev/` directory. It shouldn't appear on
the website as latest, I believe. The user would have to explicitly select
`dev`. Also if the user goes to dev, they would see this info message:
```
This version of the documentation is under development! Click here for the
latest released version.
```
I am not sure if there is any documentation explaining to how to use dev or
that dev is `nightly`? For those who use nightly would need docs anyways I
believe. These docs for sure might get crawled also once made available.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603950#comment-16603950
]
ASF GitHub Bot commented on CB-13685:
-
erisu edited a comment on issue #830: CB-13685 android: Added adaptive icon docs
URL: https://github.com/apache/cordova-docs/pull/830#issuecomment-418608412
@dpogue I believe it should be OK to merge.
The updated docs are in `www/docs/en/dev/` directory. It shouldn't appear on
the website as latest, I believe. The user would have to explicitly select
`dev`. Also if the user goes to dev, they would see this info message:
```
This version of the documentation is under development! Click here for the
latest released version.
```
I am not sure if there is any documentation explaining to how to use dev or
that dev is `nightly`? For those who use nightly builds, they would need docs
anyways I believe. These docs for sure might get crawled also once made
available.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603946#comment-16603946
]
ASF GitHub Bot commented on CB-13685:
-
erisu commented on issue #830: CB-13685 android: Added adaptive icon docs
URL: https://github.com/apache/cordova-docs/pull/830#issuecomment-418608412
@dpogue I believe it should be OK to merge.
The updated docs are in `www/docs/en/dev/` directory. It shouldn't appear on
the website as latest docs. The user would have to explicitly select `dev`.
Also if the user goes to dev, they would see this info message:
```
This version of the documentation is under development! Click here for the
latest released version.
```
I am sure if there is any documentation explaining to how to use dev or that
dev is `nightly`? For those who use nightly would need docs anyways I believe.
These docs for sure might get crawled also once made available.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603947#comment-16603947
]
ASF GitHub Bot commented on CB-13685:
-
erisu edited a comment on issue #830: CB-13685 android: Added adaptive icon docs
URL: https://github.com/apache/cordova-docs/pull/830#issuecomment-418608412
@dpogue I believe it should be OK to merge.
The updated docs are in `www/docs/en/dev/` directory. It shouldn't appear on
the website as latest, I believe. The user would have to explicitly select
`dev`. Also if the user goes to dev, they would see this info message:
```
This version of the documentation is under development! Click here for the
latest released version.
```
I am sure if there is any documentation explaining to how to use dev or that
dev is `nightly`? For those who use nightly would need docs anyways I believe.
These docs for sure might get crawled also once made available.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603943#comment-16603943
]
ASF GitHub Bot commented on CB-13685:
-
dpogue commented on issue #830: CB-13685 android: Added adaptive icon docs
URL: https://github.com/apache/cordova-docs/pull/830#issuecomment-418606291
apache/cordova-android#448 is now merged, but not yet released... is it safe
to merge docs, or do those need to wait for an actual release? I'm a bit
worried about docs PRs getting forgotten
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14140) Use fs-extra (and which) instead of shelljs
[ https://issues.apache.org/jira/browse/CB-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603521#comment-16603521 ] ASF subversion and git services commented on CB-14140: -- Commit d4c8e02288ac5e4a2ffdd3afb9a1db609676f128 in cordova-lib's branch refs/heads/master from Raphael von der Grün [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=d4c8e02 ] Merge pull request #613 from dpogue/fs-extra CB-14140 Switch to using fs-extra in favour of shelljs > Use fs-extra (and which) instead of shelljs > --- > > Key: CB-14140 > URL: https://issues.apache.org/jira/browse/CB-14140 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android, cordova-ios, cordova-lib, cordova-osx, > cordova-windows >Reporter: Chris Brody >Assignee: Darryl Pogue >Priority: Minor > > It is more efficient to use fs-extra, sometimes with some help from which, > than shelljs. > This improvement has already landed in the master branch of cordova-common > for the next major release, and work has already been started in some other > packages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14140) Use fs-extra (and which) instead of shelljs
[
https://issues.apache.org/jira/browse/CB-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603520#comment-16603520
]
ASF GitHub Bot commented on CB-14140:
-
raphinesse closed pull request #613: CB-14140 Switch to using fs-extra in
favour of shelljs
URL: https://github.com/apache/cordova-lib/pull/613
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/integration-tests/HooksRunner.spec.js
b/integration-tests/HooksRunner.spec.js
index a65558fef..8ec873c31 100644
--- a/integration-tests/HooksRunner.spec.js
+++ b/integration-tests/HooksRunner.spec.js
@@ -201,7 +201,10 @@ describe('HooksRunner', function () {
});
});
-it('Test 012 : should run before_plugin_uninstall,
before_plugin_install, after_plugin_install hooks for a plugin being installed
with correct opts.plugin context', function () {
+// FIXME Sometimes the paths returned in the hook context are
resolved to their realpath, sometimes not.
+// Furthermore, using npm@3 (default for node@6) will install the
local plugin by copying not by symlinking.
+// Disabling this test until the paths in the in the hook context
are handled consistently.
+xit('Test 012 : should run before_plugin_uninstall,
before_plugin_install, after_plugin_install hooks for a plugin being installed
with correct opts.plugin context', function () {
const hooksToTest = [
'before_plugin_uninstall',
'before_plugin_install',
diff --git a/integration-tests/platform.spec.js
b/integration-tests/platform.spec.js
index 5990737e3..193a53acb 100644
--- a/integration-tests/platform.spec.js
+++ b/integration-tests/platform.spec.js
@@ -17,8 +17,7 @@
var helpers = require('../spec/helpers');
var path = require('path');
-var fs = require('fs');
-var shell = require('shelljs');
+var fs = require('fs-extra');
var superspawn = require('cordova-common').superspawn;
var config = require('../src/cordova/config');
var Q = require('q');
@@ -39,12 +38,9 @@ describe('platform end-to-end', function () {
var results;
beforeEach(function () {
-shell.rm('-rf', tmpDir);
+fs.removeSync(tmpDir);
-// cp then mv because we need to copy everything, but that means it'll
copy the whole directory.
-// Using /* doesn't work because of hidden files.
-shell.cp('-R', path.join(fixturesDir, 'base'), tmpDir);
-shell.mv(path.join(tmpDir, 'base'), project);
+fs.copySync(path.join(fixturesDir, 'base'), project);
process.chdir(project);
// Now we load the config.json in the newly created project and edit
the target platform's lib entry
@@ -58,7 +54,7 @@ describe('platform end-to-end', function () {
spyOn(superspawn, 'spawn').and.callFake(function (cmd, args) {
if (cmd.match(/create\b/)) {
// This is a call to the bin/create script, so do the copy
ourselves.
-shell.cp('-R', path.join(fixturesDir, 'platforms', 'android'),
path.join(project, 'platforms'));
+fs.copySync(path.join(fixturesDir, 'platforms/android'),
path.join(project, 'platforms/android'));
} else if (cmd.match(/version\b/)) {
return Q('3.3.0');
} else if (cmd.match(/update\b/)) {
@@ -72,7 +68,7 @@ describe('platform end-to-end', function () {
afterEach(function () {
process.chdir(path.join(__dirname, '..')); // Needed to rm the dir on
Windows.
-shell.rm('-rf', tmpDir);
+fs.removeSync(tmpDir);
});
// Factoring out some repeated checks.
@@ -166,7 +162,7 @@ describe('platform add plugin rm end-to-end', function () {
afterEach(function () {
process.chdir(path.join(__dirname, '..')); // Needed to rm the dir on
Windows.
-shell.rm('-rf', tmpDir);
+fs.removeSync(tmpDir);
});
it('Test 006 : should remove dependency when removing parent plugin',
function () {
@@ -209,7 +205,7 @@ describe('platform add and remove --fetch', function () {
afterEach(function () {
process.chdir(path.join(__dirname, '..')); // Needed to rm the dir on
Windows.
-shell.rm('-rf', tmpDir);
+fs.removeSync(tmpDir);
});
it('Test 007 : should add and remove platform from node_modules
directory', function () {
@@ -255,7 +251,7 @@ describe('plugin add and rm end-to-end --fetch', function
() {
afterEach(function () {
process.chdir(path.join(__dirname, '..')); // Needed to rm the dir on
Windows.
-shell.rm('-rf', tmpDir);
+fs.removeSync(tmpDir);
});
it('Test
[jira] [Commented] (CB-14140) Use fs-extra (and which) instead of shelljs
[ https://issues.apache.org/jira/browse/CB-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603421#comment-16603421 ] ASF GitHub Bot commented on CB-14140: - raphinesse commented on issue #613: CB-14140 Switch to using fs-extra in favour of shelljs URL: https://github.com/apache/cordova-lib/pull/613#issuecomment-418469969 I squashed some of the commits and will merge (with merge commit) as soon as the CI tests are done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use fs-extra (and which) instead of shelljs > --- > > Key: CB-14140 > URL: https://issues.apache.org/jira/browse/CB-14140 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android, cordova-ios, cordova-lib, cordova-osx, > cordova-windows >Reporter: Chris Brody >Assignee: Darryl Pogue >Priority: Minor > > It is more efficient to use fs-extra, sometimes with some help from which, > than shelljs. > This improvement has already landed in the master branch of cordova-common > for the next major release, and work has already been started in some other > packages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603221#comment-16603221
]
ASF GitHub Bot commented on CB-13685:
-
raphinesse commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-418417584
No. It uses the latest nightly build. Should be easier to setup than using
master. Try an earlier nightly build if npm throws errors at you during
installation. A full list of available versions can be found via npm.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603220#comment-16603220
]
ASF GitHub Bot commented on CB-13685:
-
LarryBJohnson edited a comment on issue #448: CB-13685 android: Adaptive Icon
Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-418416311
so does adding @nightly switch it to this branch ? allowing me to create
adaptive icons with cordova ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603214#comment-16603214
]
ASF GitHub Bot commented on CB-13685:
-
LarryBJohnson commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-418416311
so does adding @nightly switch it to this branch ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12582) Plugin's Cocoapods don't persist if another plugin is added after it
[ https://issues.apache.org/jira/browse/CB-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603217#comment-16603217 ] Matthias commented on CB-12582: --- Hmm, interesting, didn't check the source. Still running into an issue with pods not found for linking with cordova-ios@4.5.5 Yeah, probably a different issue with cocoapod dependencies then. In my case a plugin actually installs a pod which itself has additional pods as dependencies which are not found for linking in the end. > Plugin's Cocoapods don't persist if another plugin is added after it > > > Key: CB-12582 > URL: https://issues.apache.org/jira/browse/CB-12582 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.3.1, 6.5.0 >Reporter: Kyle Kirbatski >Assignee: Shazron Abdullah >Priority: Major > Labels: backlog > Fix For: cordova-ios@4.5.5 > > Attachments: 0001-exec-purgeProjectFileCache-when-pod-install.patch > > > I was trying to use the urbanairship-cordova plugin but was unable to because > the frameworks added by Cocoapods (referenced from the plugin's xml) were not > being found for linking. After some investigation it appears that if a plugin > is added after a plugin that uses cocoapods then the changes made by > cocoapods are removed by cordova. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603211#comment-16603211
]
ASF GitHub Bot commented on CB-13685:
-
raphinesse commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-418415846
No. `npm i -g cordova@nightly` and `npm i cordova-android@nightly` in your
project
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603208#comment-16603208
]
ASF GitHub Bot commented on CB-13685:
-
janpio commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-418415269
No.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603206#comment-16603206
]
ASF GitHub Bot commented on CB-13685:
-
LarryBJohnson commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-418414514
If I where to go in my command line and download cordova using node js I
would type npm install -g cordova would this give me a version of cordova that
would let me use adaptive icons ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603201#comment-16603201
]
ASF GitHub Bot commented on CB-13685:
-
LarryBJohnson edited a comment on issue #448: CB-13685 android: Adaptive Icon
Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-418398326
How would one go about switching from standered npm cordova to this master
branch?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12582) Plugin's Cocoapods don't persist if another plugin is added after it
[ https://issues.apache.org/jira/browse/CB-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603199#comment-16603199 ] jcesarmobile commented on CB-12582: --- Not sure why it was reverted, but seems to still be there https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/Api.js#L310 > Plugin's Cocoapods don't persist if another plugin is added after it > > > Key: CB-12582 > URL: https://issues.apache.org/jira/browse/CB-12582 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.3.1, 6.5.0 >Reporter: Kyle Kirbatski >Assignee: Shazron Abdullah >Priority: Major > Labels: backlog > Fix For: cordova-ios@4.5.5 > > Attachments: 0001-exec-purgeProjectFileCache-when-pod-install.patch > > > I was trying to use the urbanairship-cordova plugin but was unable to because > the frameworks added by Cocoapods (referenced from the plugin's xml) were not > being found for linking. After some investigation it appears that if a plugin > is added after a plugin that uses cocoapods then the changes made by > cocoapods are removed by cordova. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12582) Plugin's Cocoapods don't persist if another plugin is added after it
[ https://issues.apache.org/jira/browse/CB-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603184#comment-16603184 ] Matthias commented on CB-12582: --- Since the change has been [reverted|https://github.com/apache/cordova-ios/commit/15246c9d627a633847a2e62dce14190ac443f390], can the issue be reopened? > Plugin's Cocoapods don't persist if another plugin is added after it > > > Key: CB-12582 > URL: https://issues.apache.org/jira/browse/CB-12582 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.3.1, 6.5.0 >Reporter: Kyle Kirbatski >Assignee: Shazron Abdullah >Priority: Major > Labels: backlog > Fix For: cordova-ios@4.5.5 > > Attachments: 0001-exec-purgeProjectFileCache-when-pod-install.patch > > > I was trying to use the urbanairship-cordova plugin but was unable to because > the frameworks added by Cocoapods (referenced from the plugin's xml) were not > being found for linking. After some investigation it appears that if a plugin > is added after a plugin that uses cocoapods then the changes made by > cocoapods are removed by cordova. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603145#comment-16603145
]
ASF GitHub Bot commented on CB-13685:
-
janpio commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-418398870
What does `slandered npm cordova` mean?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603141#comment-16603141
]
ASF GitHub Bot commented on CB-13685:
-
LarryBJohnson commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-418398326
How would one go about switching from slandered npm cordova to this master
branch?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10034) Plugins iOS Custom Frameworks are added to "Embedded Binaries" XCode project section by default
[
https://issues.apache.org/jira/browse/CB-10034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602706#comment-16602706
]
ASF GitHub Bot commented on CB-10034:
-
raphinesse commented on issue #399: CB-10034 Addresses Embedded/Linked/Signed
Custom Frameworks via updated node-xcode
URL: https://github.com/apache/cordova-lib/pull/399#issuecomment-418275034
The files modified for this PR have been removed in
64fea70ea0554458ebc399f0ad4ba4b534b5cd3f. Since plugin handlers now live in the
platform repositories, this has to be implemented in
[apache/cordova-ios](https://github.com/apache/cordova-ios).
@shazron Maybe you want to open an issue in cordova-ios that links to this,
so it's not forgotten?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Plugins iOS Custom Frameworks are added to "Embedded Binaries" XCode project
> section by default
> ---
>
> Key: CB-10034
> URL: https://issues.apache.org/jira/browse/CB-10034
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: 5.4.0, 5.3.3, 6.0.1, 6.1.1
> Environment: OSX developing for iOS
>Reporter: Roberto Andrade
>Priority: Major
>
> Since CB-9517 was merged and released in 5.3.0 it seems to have changed the
> approach to adding a "custom framework" dependency declared in {{plugin.xml}}
> with the {{}} directive into the xcode project, as
> per the [following
> change|https://github.com/apache/cordova-lib/commit/737f2df4e5c8de205c90cc29614483ebcd71f605].
> It assumes all frameworks are "embeddable", which is not true for a great
> chunk of frameworks out there that have not being built with the new iOS
> 8/XCode 6 Cocoa Framework architecture. Most of the frameworks I use
> (developed prior to Apple coming up with the "official" iOS 8 Framework
> utilities and Xcode project options) use community provided
> [iOS-Universal-Framework|https://github.com/kstenerud/iOS-Universal-Framework],
> which once an artifact generated using that project template gets added to
> the "embedded binaries" section of a depending app (ie: Cordova app), Xcode
> has issues doing its thing because they were not built with the iOS 8
> framework magic in it.
> I suggest that the new behavior be the default (ie: add it to the embedded
> binaries section) but provide an option when declaring the framework
> dependency in {{plugin.xml}} so that we can override the behavior and specify
> whether or not we want it to the embedded (at that point the old <=5.2.0
> behavior should take over, ie: just add it to the list of framework
> dependencies but not the the embedded binaries section of the project), may I
> suggest:
> {{}}
> as the optional override (being assumed as {{true}} by default)?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10034) Plugins iOS Custom Frameworks are added to "Embedded Binaries" XCode project section by default
[
https://issues.apache.org/jira/browse/CB-10034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602707#comment-16602707
]
ASF GitHub Bot commented on CB-10034:
-
raphinesse closed pull request #399: CB-10034 Addresses Embedded/Linked/Signed
Custom Frameworks via updated node-xcode
URL: https://github.com/apache/cordova-lib/pull/399
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cordova-common/src/PluginInfo/PluginInfo.js
b/cordova-common/src/PluginInfo/PluginInfo.js
index e1a1b3180..7c28eb572 100644
--- a/cordova-common/src/PluginInfo/PluginInfo.js
+++ b/cordova-common/src/PluginInfo/PluginInfo.js
@@ -301,8 +301,11 @@ function PluginInfo(dirname) {
type: el.attrib.type,
parent: el.attrib.parent,
custom: isStrTrue(el.attrib.custom),
+embed: el.attrib.embed === undefined ? undefined :
isStrTrue(el.attrib.embed),
+link: el.attrib.link === undefined ? undefined :
isStrTrue(el.attrib.link),
src: el.attrib.src,
weak: isStrTrue(el.attrib.weak),
+sign: isStrTrue(el.attrib.sign),
versions: el.attrib.versions,
targetDir: el.attrib['target-dir'],
deviceTarget: el.attrib['device-target'] || el.attrib.target,
diff --git a/cordova-lib/package.json b/cordova-lib/package.json
index 5a3d2ba6e..4df772076 100644
--- a/cordova-lib/package.json
+++ b/cordova-lib/package.json
@@ -40,7 +40,7 @@
"underscore": "1.7.0",
"unorm": "1.3.3",
"valid-identifier": "0.0.1",
-"xcode": "0.8.0"
+"xcode": "0.8.6"
},
"devDependencies": {
"codecov": "^1.0.1",
diff --git a/cordova-lib/spec-plugman/platforms/ios.spec.js
b/cordova-lib/spec-plugman/platforms/ios.spec.js
index 7c245bd2c..c3e999cfa 100644
--- a/cordova-lib/spec-plugman/platforms/ios.spec.js
+++ b/cordova-lib/spec-plugman/platforms/ios.spec.js
@@ -269,7 +269,7 @@ describe('ios project handler', function() {
var frameworks = copyArray(valid_custom_frameworks);
var spy = spyOn(proj_files.xcode, 'addFramework');
ios['framework'].install(frameworks[0], dummyplugin, temp,
dummy_id, null, proj_files);
-
expect(spy).toHaveBeenCalledWith(path.normalize('SampleApp/Plugins/org.test.plugins.dummyplugin/Custom.framework'),
{customFramework:true});
+
expect(spy).toHaveBeenCalledWith(path.normalize('SampleApp/Plugins/org.test.plugins.dummyplugin/Custom.framework'),
{customFramework:true, embed:true, link:undefined, sign:false});
});
// TODO: Add more tests to cover the cases:
@@ -299,6 +299,27 @@ describe('ios project handler', function() {
path.join(temp,
'SampleApp/Plugins/org.test.plugins.dummyplugin'));
});
});
+
+it('with embed="false" attribute should call into xcodeproj\'s
addFramework accordingly', function() {
+var frameworks = copyArray(valid_custom_frameworks);
+var spy = spyOn(proj_files.xcode, 'addFramework');
+ios['framework'].install(frameworks[1], dummyplugin, temp,
dummy_id, null, proj_files);
+
expect(spy).toHaveBeenCalledWith(path.normalize('SampleApp/Plugins/org.test.plugins.dummyplugin/NonEmbeddable.framework'),
{customFramework:true, embed:false, link:undefined, sign:false});
+});
+
+it('with link="false" attribute should call into xcodeproj\'s
addFramework accordingly', function() {
+var frameworks = copyArray(valid_custom_frameworks);
+var spy = spyOn(proj_files.xcode, 'addFramework');
+ios['framework'].install(frameworks[2], dummyplugin, temp,
dummy_id, null, proj_files);
+
expect(spy).toHaveBeenCalledWith(path.normalize('SampleApp/Plugins/org.test.plugins.dummyplugin/Unlinkable.framework'),
{customFramework:true, embed:false, link:false, sign:false});
+});
+
+it('with sign="true" attribute should call into xcodeproj\'s
addFramework accordingly', function() {
+var frameworks = copyArray(valid_custom_frameworks);
+var spy = spyOn(proj_files.xcode, 'addFramework');
+ios['framework'].install(frameworks[3], dummyplugin, temp,
dummy_id, null, proj_files);
+
expect(spy).toHaveBeenCalledWith(path.normalize('SampleApp/Plugins/org.test.plugins.dummyplugin/Signable.framework'),
{customFramework:true, embed:true, link:undefined, sign:true});
+});
});
[jira] [Commented] (CB-9033) Plugins fail to install on Apple Watch based Cordova project
[ https://issues.apache.org/jira/browse/CB-9033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602695#comment-16602695 ] ASF GitHub Bot commented on CB-9033: raphinesse commented on issue #219: CB-9033 : fix WatchKit support URL: https://github.com/apache/cordova-lib/pull/219#issuecomment-418271896 The files modified for this PR have been removed in 64fea70ea0554458ebc399f0ad4ba4b534b5cd3f. Since plugin handlers now live in the platform repositories, this has to be implemented in [apache/cordova-ios](https://github.com/apache/cordova-ios). @shazron Maybe you want to open an issue in cordova-ios that links to this, so it's not forgotten? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Plugins fail to install on Apple Watch based Cordova project > > > Key: CB-9033 > URL: https://issues.apache.org/jira/browse/CB-9033 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 5.0.0 > Environment: iOS >Reporter: Olivier Goguel >Assignee: Shazron Abdullah >Priority: Major > Labels: backlog > Fix For: cordova-ios@4.5.1 > > > After having added the Watch Kit target to an iOS Cordova project, plugins > cannot be added any more through the CLI. > An error is thrown "'could not find -Info.plist file, or config.xml file." as > the plugin manager is confused by the plist files from the WatchKit App and > WatchKit Extension and fails to find the proper plist file of the projet. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9033) Plugins fail to install on Apple Watch based Cordova project
[
https://issues.apache.org/jira/browse/CB-9033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602696#comment-16602696
]
ASF GitHub Bot commented on CB-9033:
raphinesse closed pull request #219: CB-9033 : fix WatchKit support
URL: https://github.com/apache/cordova-lib/pull/219
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cordova-lib/spec-plugman/platforms/ios.spec.js
b/cordova-lib/spec-plugman/platforms/ios.spec.js
index b1ead60b6..d7e20ef07 100644
--- a/cordova-lib/spec-plugman/platforms/ios.spec.js
+++ b/cordova-lib/spec-plugman/platforms/ios.spec.js
@@ -28,6 +28,7 @@ var ios = require('../../src/plugman/platforms/ios'),
temp = path.join(os.tmpdir(), 'plugman'),
plugins_dir = path.join(temp, 'cordova', 'plugins'),
ios_config_xml_project = path.join(__dirname, '..', 'projects',
'ios-config-xml', '*'),
+ios_apple_watch_project = path.join(__dirname, '..', 'projects',
'ios-apple-watch', '*'),
ios_project = path.join(ios_config_xml_project, '..'),
faultyplugin = path.join(__dirname, '..', 'plugins',
'org.test.plugins.faultyplugin'),
dummyplugin = path.join(__dirname, '..', 'plugins',
'org.test.plugins.dummyplugin'),
@@ -163,13 +164,13 @@ describe('ios project handler', function() {
var source = copyArray(valid_source).filter(function(s) {
return s.targetDir === undefined; });
var spy = spyOn(proj_files.xcode, 'addSourceFile');
ios['source-file'].install(source[0], dummyplugin, temp,
dummy_id, null, proj_files);
-expect(spy).toHaveBeenCalledWith(slashJoin('Plugins',
dummy_id, 'DummyPluginCommand.m'), {});
+expect(spy).toHaveBeenCalledWith(slashJoin('Plugins',
dummy_id, 'DummyPluginCommand.m'),{ target:'571A463A14DB0A1B007FEAC7'});
});
it('should call into xcodeproj\'s addSourceFile appropriately when
element has a target-dir', function() {
var source = copyArray(valid_source).filter(function(s) {
return s.targetDir !== undefined; });
var spy = spyOn(proj_files.xcode, 'addSourceFile');
ios['source-file'].install(source[0], dummyplugin, temp,
dummy_id, null, proj_files);
-expect(spy).toHaveBeenCalledWith(slashJoin('Plugins',
dummy_id, 'targetDir', 'TargetDirTest.m'), {});
+expect(spy).toHaveBeenCalledWith(slashJoin('Plugins',
dummy_id, 'targetDir', 'TargetDirTest.m'), {
target:'571A463A14DB0A1B007FEAC7'});
});
it('should cp the file to the right target location when element
has no target-dir', function() {
var source = copyArray(valid_source).filter(function(s) {
return s.targetDir === undefined; });
@@ -188,7 +189,7 @@ describe('ios project handler', function() {
spyOn(proj_files.xcode, 'addSourceFile');
var spy = spyOn(proj_files.xcode, 'addFramework');
ios['source-file'].install(source[0], dummyplugin, temp,
dummy_id, null, proj_files);
-expect(spy).toHaveBeenCalledWith(path.join('SampleApp',
'Plugins', dummy_id, 'SourceWithFramework.m'), {weak:false});
+expect(spy).toHaveBeenCalledWith(path.join('SampleApp',
'Plugins', dummy_id, 'SourceWithFramework.m'),
{weak:false,target:'571A463A14DB0A1B007FEAC7'});
});
});
@@ -254,7 +255,7 @@ describe('ios project handler', function() {
var resources = copyArray(valid_resources);
var spy = spyOn(proj_files.xcode, 'addResourceFile');
ios['resource-file'].install(resources[0], dummyplugin, temp,
'pluginid', null, proj_files);
-expect(spy).toHaveBeenCalledWith(path.join('Resources',
'DummyPlugin.bundle'));
+expect(spy).toHaveBeenCalledWith(path.join('Resources',
'DummyPlugin.bundle'),{target: '571A463A14DB0A1B007FEAC7'});
});
it('should cp the file to the right target location', function() {
var resources = copyArray(valid_resources);
@@ -269,7 +270,7 @@ describe('ios project handler', function() {
var frameworks = copyArray(valid_custom_frameworks);
var spy = spyOn(proj_files.xcode, 'addFramework');
ios['framework'].install(frameworks[0], dummyplugin, temp,
dummy_id, null, proj_files);
-
expect(spy).toHaveBeenCalledWith(path.normalize('SampleApp/Plugins/org.test.plugins.dummyplugin/Custom.framework'),
{customFramework:true});
+
expect(spy).toHaveBeenCalledWith(path.normalize('SampleApp/Plugins/org.test.plugins.dummyplugin/Custom.framework'),
[jira] [Commented] (CB-14140) Use fs-extra (and which) instead of shelljs
[ https://issues.apache.org/jira/browse/CB-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602681#comment-16602681 ] ASF GitHub Bot commented on CB-14140: - raphinesse edited a comment on issue #613: CB-14140 Switch to using fs-extra in favour of shelljs URL: https://github.com/apache/cordova-lib/pull/613#issuecomment-418254803 I kept them separate for the review. Before merging, I'd manually squash _most_ commits. So just let me know when this is good to go and I'll clean it up and get it merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use fs-extra (and which) instead of shelljs > --- > > Key: CB-14140 > URL: https://issues.apache.org/jira/browse/CB-14140 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android, cordova-ios, cordova-lib, cordova-osx, > cordova-windows >Reporter: Chris Brody >Assignee: Darryl Pogue >Priority: Minor > > It is more efficient to use fs-extra, sometimes with some help from which, > than shelljs. > This improvement has already landed in the master branch of cordova-common > for the next major release, and work has already been started in some other > packages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14140) Use fs-extra (and which) instead of shelljs
[ https://issues.apache.org/jira/browse/CB-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602680#comment-16602680 ] ASF GitHub Bot commented on CB-14140: - raphinesse edited a comment on issue #613: CB-14140 Switch to using fs-extra in favour of shelljs URL: https://github.com/apache/cordova-lib/pull/613#issuecomment-418254803 I kept them separate for the review. Before merging, I'd manually squash _most_ commits. So just let me know hen this is good to go and I'll clean it up and get it merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use fs-extra (and which) instead of shelljs > --- > > Key: CB-14140 > URL: https://issues.apache.org/jira/browse/CB-14140 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android, cordova-ios, cordova-lib, cordova-osx, > cordova-windows >Reporter: Chris Brody >Assignee: Darryl Pogue >Priority: Minor > > It is more efficient to use fs-extra, sometimes with some help from which, > than shelljs. > This improvement has already landed in the master branch of cordova-common > for the next major release, and work has already been started in some other > packages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14140) Use fs-extra (and which) instead of shelljs
[ https://issues.apache.org/jira/browse/CB-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602648#comment-16602648 ] ASF GitHub Bot commented on CB-14140: - raphinesse commented on issue #613: CB-14140 Switch to using fs-extra in favour of shelljs URL: https://github.com/apache/cordova-lib/pull/613#issuecomment-418254803 I kept them separate for the review. Before merging, I'd manually squash _most_ commits. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use fs-extra (and which) instead of shelljs > --- > > Key: CB-14140 > URL: https://issues.apache.org/jira/browse/CB-14140 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android, cordova-ios, cordova-lib, cordova-osx, > cordova-windows >Reporter: Chris Brody >Assignee: Darryl Pogue >Priority: Minor > > It is more efficient to use fs-extra, sometimes with some help from which, > than shelljs. > This improvement has already landed in the master branch of cordova-common > for the next major release, and work has already been started in some other > packages. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
