[jira] [Commented] (CB-10795) [InAppBrowser] Circular loop if app had an intent-filter defined for the URL being opened
[
https://issues.apache.org/jira/browse/CB-10795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616945#comment-16616945
]
ASF GitHub Bot commented on CB-10795:
-
dpolivy commented on issue #154: [CB-10795] Exclude current app from external
intent list
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/154#issuecomment-421854941
@janpio Wow, totally didn't realize this was never merged. I just rebased
the commit off master so it should be good to go.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [InAppBrowser] Circular loop if app had an intent-filter defined for the URL
> being opened
> -
>
> Key: CB-10795
> URL: https://issues.apache.org/jira/browse/CB-10795
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Reporter: Dan Polivy
>Priority: Minor
> Labels: Android, triaged
>
> Consider the following scenario:
> 1. App "X" has an intent-filter defined that says it can open URLs for
> "www.example.com". (e.g., using
> https://github.com/EddyVerbruggen/Custom-URL-scheme plugin)
> 2. App "X" wants to launch a specific URL on www.example.com in the system
> browser.
> 3. App "X" uses InAppBrowser plugin and calls {{window.open}} with
> {{_system}} as the target.
> Actual:
> Since the app itself has an intent-filter defined for "www.example.com",
> InAppBrowser will just re-launch the app with the intent. In some cases, if a
> default handler is not chosen, one will get a chooser, however the app will
> still be listed as the default option.
> Expected:
> The app should be able to launch the URL in the system browser to avoid a
> circular redirect.
> There is some discussion of this issue on stackoverflow:
> http://stackoverflow.com/questions/18682833/how-to-exclude-a-specific-application-from-action-view-intent
> http://stackoverflow.com/questions/29529027/open-url-in-browser-even-though-my-app-registered-an-intent-filter-for-it
> I think it might be reasonable for InAppBrowser, in {{openExternal}}, to
> explicitly remove the current app from the list.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14260) captureImage: permission denial on android 8.1
[
https://issues.apache.org/jira/browse/CB-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616936#comment-16616936
]
ASF GitHub Bot commented on CB-14260:
-
jcesarmobile commented on issue #95: CB-14260: (android) captureImage
permission denial on android 8.1
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/95#issuecomment-421849266
I'm pretty sure the audio recording still needs the read permission, so I
think it might be safer to ask for both, at least in captureAudio, or just
don't change it there and change only for captureImage.
Couldn't really test because my 8.1 device doesn't include an audio capture
app, and tried using a few and only one from sony allows the intent, but then
cordova-android CordovaResourceApi is not able to handle the content url
returned.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> captureImage: permission denial on android 8.1
> --
>
> Key: CB-14260
> URL: https://issues.apache.org/jira/browse/CB-14260
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media-capture
>Affects Versions: 3.0.0
>Reporter: Marco
>Priority: Major
>
> When I call "captureImage" method I accept all permissions but I get:
> {noformat}
> java.lang.SecurityException: Permission Denial: writing
> com.android.providers.media.MediaProvider uri
> content://media/external/images/media from pid=12716, uid=10079 requires
> android.permission.WRITE_EXTERNAL_STORAGE, or grantUriPermission(){noformat}
> I'm using cordova-plugin-media-capture version 3.0.2
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this
[
https://issues.apache.org/jira/browse/CB-13179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616934#comment-16616934
]
ASF GitHub Bot commented on CB-13179:
-
JiaLiPassion commented on issue #215: CB-13179:(all) invoke onEvent listener
with _realReader as applyThis
URL:
https://github.com/apache/cordova-plugin-file/pull/215#issuecomment-421848180
@janpio, I have rebased, the test still failed, is that possible to run
`test` in local? thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova file plugin onEvent(such as onload) should be invoked with
> _realReader as this
> --
>
> Key: CB-13179
> URL: https://issues.apache.org/jira/browse/CB-13179
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-file
> Environment: Android, ios, Browser
>Reporter: Jia Li
>Priority: Minor
> Labels: features
>
> When `FileReader` add onEvent listener such as `onload`, it will add the
> listener to inner `_realReader` , but when it invoke the listener, it use the
> FileReader as `this`.
> 1. When add onload listener in application code.
> ```javascript
> var fileReader = new FileReader();
> fileReader.onload = function() {};
> ```
> it will call `www/FileReader.js defineEvent`
> ```javascript
> function defineEvent(eventName) {
> utils.defineGetterSetter(FileReader.prototype, eventName, function() {
> return this._realReader[eventName] || null;
> }, function(value) {
> this._realReader[eventName] = value;
> });
> }
> ```
> the listener is added to `this._realReader`.
> And when the listener is triggered for example in `readSuccessCallback`
> it will invoke the method with `this`.
> ```javascript
> this.onload(new ProgressEvent("load", {target:this}));
> ```
> in the normal senario, it will ok, but when it work with some polyfilles such
> as `zone.js of angular4`, it will fail because `zone.js` have some special
> handling which require the `this` object be the same when add listener and
> invoke listener.
> https://github.com/angular/zone.js/issues/868
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12930) File plugin getDirectory on windows fails on path ending with slash
[ https://issues.apache.org/jira/browse/CB-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616921#comment-16616921 ] ASF GitHub Bot commented on CB-12930: - giuseppelt commented on issue #207: CB-12930: (windows) Fix getDirectory trailing slash path URL: https://github.com/apache/cordova-plugin-file/pull/207#issuecomment-421843550 @janpio Hi, I would like, but I deleted the fork, so now I can't. I checked the files and there're no diffs, the conflict is just ephemeral on some line ending, I think. You should able to merge and resolve as is. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > File plugin getDirectory on windows fails on path ending with slash > --- > > Key: CB-12930 > URL: https://issues.apache.org/jira/browse/CB-12930 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file >Reporter: Giuseppe La Torre >Priority: Minor > > On Windows, getDirectory with a path ending with '/' fails. > On all other platform it works as intended. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-14183) Android 7 / Android 8 - capture.captureAudio cause No Activity found to handle Intent { act=android.provider.MediaStore.RECORD_SOUND 7
[
https://issues.apache.org/jira/browse/CB-14183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jcesarmobile closed CB-14183.
-
Resolution: Duplicate
We are moving to github issues and somebody already reported it there, so going
to close this one in favour of the github one, please subscribe there if
interested
https://github.com/apache/cordova-plugin-media-capture/issues/102
> Android 7 / Android 8 - capture.captureAudio cause No Activity found to
> handle Intent { act=android.provider.MediaStore.RECORD_SOUND 7
> --
>
> Key: CB-14183
> URL: https://issues.apache.org/jira/browse/CB-14183
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media-capture
> Environment: Node version: v7.9.0
> Cordova version: 7.0.1
> cordova-android version: 7.1.0
>
>Reporter: GSS FED
>Priority: Major
>
> Affected target: Android 7 (sdk = 24), Android 8 (sdk = 26)
> Not affected target: Android 6 (sdk = 23)
> code:
>
> {code:java}
> // capture callback
> var captureSuccess = function(mediaFiles) {
> var i, path, len;
> for (i = 0, len = mediaFiles.length; i < len; i += 1) {
> path = mediaFiles[i].fullPath;
> // do something interesting with the file
> }
> };
> // capture error callback
> var captureError = function(error) {
> if (error.code) { console.log('Error code: ' + error.code); }
> else { console.log('Error: ' + error); }
> };
> // start audio capture
> navigator.device.capture.captureAudio(captureSuccess, captureError,
> {limit:2});{code}
>
> Android 8 log: "Error: No Activity found to handle Intent \{
> act=android.provider.MediaStore.RECORD_SOUND }"
> while Android 6 can open recorder
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7700) Translations for October
[ https://issues.apache.org/jira/browse/CB-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616868#comment-16616868 ] ASF GitHub Bot commented on CB-7700: janpio closed pull request #38: CB-7700 cordova-plugin-dialogs documentation translation URL: https://github.com/apache/cordova-plugin-dialogs/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Translations for October > > > Key: CB-7700 > URL: https://issues.apache.org/jira/browse/CB-7700 > Project: Apache Cordova > Issue Type: Improvement > Components: Translation >Reporter: Victor Adrian Sosa Herrera >Assignee: Lisa Seacat DeLuca >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-10033) new resizable cropping rectangle instead of Apple's standard square
[ https://issues.apache.org/jira/browse/CB-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-10033. - Resolution: Won't Fix Closing as the PR, it fits better in a separate plugin that just handles the cropping part and can take the image url from camera plugin or any other. > new resizable cropping rectangle instead of Apple's standard square > --- > > Key: CB-10033 > URL: https://issues.apache.org/jira/browse/CB-10033 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-camera > Environment: iOS >Reporter: Manfred at Convey >Priority: Minor > Labels: feature, iOS > > On iOS there's only that very insufficient inflexible cropping square – > compared to Android or WinMobile – which moreover obviously doesn’t work > properly (see CB-9930, CB-2648). > As we need a flexible, sizable rectangle, we implemented that in our fork of > the camera plugin. > And with that we even already submitted a [pull > request|https://github.com/apache/cordova-plugin-camera/pull/131]. > (being very new to Cordova we didn’t realize, that there obviously has to be > such a JIRA issue, before). > To be downward compatible and to not urge others, for whom that square may be > sufficient, it is made parametrizable via a new preference (as this is iOS > specific and nothing that has to be changeable at runtime), defaulting to > false. > If the plugin is called with option allowEdit == true, then setting this new > preference to true suppresses that standard (fairly useless) square for > cropping the photo, even suppresses the (then also useless) view of the photo > with the "Retake"- and "Use Photo"-buttons, but instead offers a resizable > cropping rectangle (with "Redo" and "Save“). > More detail about how it’s implemented can be found in the comment of the > mentioned pull request; > and as there already started a discussion, I added more detail and thoughts > [here|https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156117731] > and > [here|https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156988289]. > We think others could use and want that, too – in the standard plug in. > Yes, it is platform specific, but on Android and WinMobile it’s already > possible to crop with a flexible rectangle (somehow – knowing, that Android > also isn’t really satisfying). > I also emailed d...@cordova.apache.org with a > [proposal|http://callback.markmail.org/thread/5bjkv4ukymo6ybot]. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10033) new resizable cropping rectangle instead of Apple's standard square
[ https://issues.apache.org/jira/browse/CB-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616861#comment-16616861 ] ASF GitHub Bot commented on CB-10033: - jcesarmobile commented on issue #131: CB-10033 – iOS: new resizable cropping rectangle instead of Apple's standard square URL: https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-421815520 He sent a mail to the dev mail list and nobody answered, so I don't think there is interest in this after all those years. It's probably better to make a plugin that just crops the images independent from camera plugin, so going to close the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > new resizable cropping rectangle instead of Apple's standard square > --- > > Key: CB-10033 > URL: https://issues.apache.org/jira/browse/CB-10033 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-camera > Environment: iOS >Reporter: Manfred at Convey >Priority: Minor > Labels: feature, iOS > > On iOS there's only that very insufficient inflexible cropping square – > compared to Android or WinMobile – which moreover obviously doesn’t work > properly (see CB-9930, CB-2648). > As we need a flexible, sizable rectangle, we implemented that in our fork of > the camera plugin. > And with that we even already submitted a [pull > request|https://github.com/apache/cordova-plugin-camera/pull/131]. > (being very new to Cordova we didn’t realize, that there obviously has to be > such a JIRA issue, before). > To be downward compatible and to not urge others, for whom that square may be > sufficient, it is made parametrizable via a new preference (as this is iOS > specific and nothing that has to be changeable at runtime), defaulting to > false. > If the plugin is called with option allowEdit == true, then setting this new > preference to true suppresses that standard (fairly useless) square for > cropping the photo, even suppresses the (then also useless) view of the photo > with the "Retake"- and "Use Photo"-buttons, but instead offers a resizable > cropping rectangle (with "Redo" and "Save“). > More detail about how it’s implemented can be found in the comment of the > mentioned pull request; > and as there already started a discussion, I added more detail and thoughts > [here|https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156117731] > and > [here|https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156988289]. > We think others could use and want that, too – in the standard plug in. > Yes, it is platform specific, but on Android and WinMobile it’s already > possible to crop with a flexible rectangle (somehow – knowing, that Android > also isn’t really satisfying). > I also emailed d...@cordova.apache.org with a > [proposal|http://callback.markmail.org/thread/5bjkv4ukymo6ybot]. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10369) Added getVideo() feature with thumbnail creation
[ https://issues.apache.org/jira/browse/CB-10369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616857#comment-16616857 ] ASF GitHub Bot commented on CB-10369: - janpio commented on issue #168: CB-10369: Added getVideo() feature with thumbnail creation (readded) URL: https://github.com/apache/cordova-plugin-camera/pull/168#issuecomment-421814595 Hey @tbutcaru , there seems to be a merge conflict now. Could you maybe fix this? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Added getVideo() feature with thumbnail creation > > > Key: CB-10369 > URL: https://issues.apache.org/jira/browse/CB-10369 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-camera >Reporter: Tanase Butcaru >Priority: Major > Labels: Android, features > > I've implemented the +getVideo()+ function for cordova-plugin-camera which > gives the user the ability to record a video with default camera app. > Optionally, this feature can create a thumbnail for the recorded video. > Full description and PR can be found in the external issue URL. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10033) new resizable cropping rectangle instead of Apple's standard square
[ https://issues.apache.org/jira/browse/CB-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616850#comment-16616850 ] ASF GitHub Bot commented on CB-10033: - janpio commented on issue #131: CB-10033 – iOS: new resizable cropping rectangle instead of Apple's standard square URL: https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-421810856 Hey @convey-mane , there seems to be a merge conflict now. Could you maybe fix this? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > new resizable cropping rectangle instead of Apple's standard square > --- > > Key: CB-10033 > URL: https://issues.apache.org/jira/browse/CB-10033 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-camera > Environment: iOS >Reporter: Manfred at Convey >Priority: Minor > Labels: feature, iOS > > On iOS there's only that very insufficient inflexible cropping square – > compared to Android or WinMobile – which moreover obviously doesn’t work > properly (see CB-9930, CB-2648). > As we need a flexible, sizable rectangle, we implemented that in our fork of > the camera plugin. > And with that we even already submitted a [pull > request|https://github.com/apache/cordova-plugin-camera/pull/131]. > (being very new to Cordova we didn’t realize, that there obviously has to be > such a JIRA issue, before). > To be downward compatible and to not urge others, for whom that square may be > sufficient, it is made parametrizable via a new preference (as this is iOS > specific and nothing that has to be changeable at runtime), defaulting to > false. > If the plugin is called with option allowEdit == true, then setting this new > preference to true suppresses that standard (fairly useless) square for > cropping the photo, even suppresses the (then also useless) view of the photo > with the "Retake"- and "Use Photo"-buttons, but instead offers a resizable > cropping rectangle (with "Redo" and "Save“). > More detail about how it’s implemented can be found in the comment of the > mentioned pull request; > and as there already started a discussion, I added more detail and thoughts > [here|https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156117731] > and > [here|https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156988289]. > We think others could use and want that, too – in the standard plug in. > Yes, it is platform specific, but on Android and WinMobile it’s already > possible to crop with a flexible rectangle (somehow – knowing, that Android > also isn’t really satisfying). > I also emailed d...@cordova.apache.org with a > [proposal|http://callback.markmail.org/thread/5bjkv4ukymo6ybot]. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12468) cordova-inappbrowser-plugin setDefaultOptions method
[ https://issues.apache.org/jira/browse/CB-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616838#comment-16616838 ] ASF GitHub Bot commented on CB-12468: - janpio commented on issue #213: CB-12468 added ability to set|get default options; URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/213#issuecomment-421807520 @IvanProdaiko94 could you please rebase onto `master` once more? Maybe this will reset and fix the tests. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-inappbrowser-plugin setDefaultOptions method > > > Key: CB-12468 > URL: https://issues.apache.org/jira/browse/CB-12468 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-lib >Affects Versions: 3.5.0 > Environment: IOS/Android >Reporter: Ivan Prodaiko >Priority: Major > Labels: features > Fix For: Master > > > While using cordova-inappbrowser-plugin I must set popup features only when > calling window.open method. But a lot of libraries (firebase, openFB) use > window.open inside their own code where I can't directly menage the features > of window to be opened, and on IOS, where we do not a have a 'back' button we > could have a problem. For example window, opened with 'toolbar=no' will make > app to stack with no ability to close the window. Another thing to be > mentioned is when on IOS you use attribute, after opening a > new window without setting 'allowInlineMediaPlayback=yes' all inline > attributes will stop working properly and video will start to open in a > fullscreen mode. > So, my proposal is to provide an ability to setDefaultOptions method that > will help to prevent external libraries to manage the options of of window to > be opened directly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13179) Cordova file plugin onEvent(such as onload) should be invoked with _realReader as this
[
https://issues.apache.org/jira/browse/CB-13179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616835#comment-16616835
]
ASF GitHub Bot commented on CB-13179:
-
janpio commented on issue #215: CB-13179:(all) invoke onEvent listener with
_realReader as applyThis
URL:
https://github.com/apache/cordova-plugin-file/pull/215#issuecomment-421806839
Hey @JiaLiPassion , there seems to be a merge conflict now. Could you maybe
fix this? Thanks.
Also, tests are _all_ failing. Rebasing your branch on `master` might
possibly fix this, could you do that? Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova file plugin onEvent(such as onload) should be invoked with
> _realReader as this
> --
>
> Key: CB-13179
> URL: https://issues.apache.org/jira/browse/CB-13179
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-file
> Environment: Android, ios, Browser
>Reporter: Jia Li
>Priority: Minor
> Labels: features
>
> When `FileReader` add onEvent listener such as `onload`, it will add the
> listener to inner `_realReader` , but when it invoke the listener, it use the
> FileReader as `this`.
> 1. When add onload listener in application code.
> ```javascript
> var fileReader = new FileReader();
> fileReader.onload = function() {};
> ```
> it will call `www/FileReader.js defineEvent`
> ```javascript
> function defineEvent(eventName) {
> utils.defineGetterSetter(FileReader.prototype, eventName, function() {
> return this._realReader[eventName] || null;
> }, function(value) {
> this._realReader[eventName] = value;
> });
> }
> ```
> the listener is added to `this._realReader`.
> And when the listener is triggered for example in `readSuccessCallback`
> it will invoke the method with `this`.
> ```javascript
> this.onload(new ProgressEvent("load", {target:this}));
> ```
> in the normal senario, it will ok, but when it work with some polyfilles such
> as `zone.js of angular4`, it will fail because `zone.js` have some special
> handling which require the `this` object be the same when add listener and
> invoke listener.
> https://github.com/angular/zone.js/issues/868
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13460) Apply Android style to the splash screen.
[ https://issues.apache.org/jira/browse/CB-13460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616832#comment-16616832 ] ASF GitHub Bot commented on CB-13460: - janpio commented on issue #137: CB-13460: Apply Android style to the splash screen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/137#issuecomment-421806230 Hey @pdyraga, could you please rebase your PR on master? Shouldn't be much effort, and may possibly fix the test issues. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Apply Android style to the splash screen. > - > > Key: CB-13460 > URL: https://issues.apache.org/jira/browse/CB-13460 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-splashscreen >Reporter: Piotr Dyraga >Priority: Major > > This improvement aims at making the splash screen dialog use the > `SplashScreenStyle`, if defined. If not, it plugin should fall back to the > default style (backward compatibility). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13502) Android - add support for "setRate" method already available on iOS
[ https://issues.apache.org/jira/browse/CB-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616831#comment-16616831 ] ASF GitHub Bot commented on CB-13502: - janpio commented on issue #152: CB-13502: (android) Implementation of setRate method for Android Marshmallow and later URL: https://github.com/apache/cordova-plugin-media/pull/152#issuecomment-421806107 Hey @jh3141 , there seems to be a merge conflict now. Could you maybe fix this? Thanks. Also, as @stevengill commented before you changed some test data so _all_ tests are failing currently. Could you please also fix this? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Android - add support for "setRate" method already available on iOS > --- > > Key: CB-13502 > URL: https://issues.apache.org/jira/browse/CB-13502 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-media >Reporter: Julian Hall >Priority: Minor > > The iOS media plugin supports a method "setRate" which changes the playback > rate. Android has support for this feature in the MediaPlayer class used by > the media plugin since API version 23 (Marshmallow), therefore supporting > this method there is very easy. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12479) InAppBrowser: Add Loading Spinner for Android
[ https://issues.apache.org/jira/browse/CB-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616827#comment-16616827 ] ASF GitHub Bot commented on CB-12479: - janpio commented on issue #88: CB-12479: Add loading spinner for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-421804792 Hey @cjpearson , there seems to be a merge conflict now. Could you maybe fix this? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > InAppBrowser: Add Loading Spinner for Android > - > > Key: CB-12479 > URL: https://issues.apache.org/jira/browse/CB-12479 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: 2.5.0, 2.6.0, 2.7.0, 2.8.0 > Environment: Android (at least) >Reporter: jcesarmobile >Priority: Trivial > Labels: Triaged > > In CB-3750 a loader spinner was added for iOS. There was another PR for > Android but it was never merged, so I'm creating this new issue for Android. > PR https://github.com/apache/cordova-plugin-inappbrowser/pull/88 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera
[ https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616826#comment-16616826 ] ASF GitHub Bot commented on CB-13307: - janpio commented on issue #286: CB-13307: (Android) Fixed issue when unable to load image with mime t… URL: https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-421804726 Hey @DavidBriglio , there seems to be a merge conflict now. Could you maybe fix this? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Accessing Google Photos on Pixel from cordova-plugin-camera > --- > > Key: CB-13307 > URL: https://issues.apache.org/jira/browse/CB-13307 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: David Briglio >Priority: Major > > Currently when trying to access some photos from Google Photos, it fails to > load. Android 8.0 on Google Pixel, cordova version 6.5.0, > cordova-plugin-camera version 2.4.1. > Causes: > 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types > are considered an invalid image. The mimetype of the image I am loading gets > set to "image/*". > 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri > authority is compared against "com.google.android.apps.photos.content", where > the actual is "com.google.android.apps.photos.contentprovider". This causes > the logic to dismiss the image as not from Google Photos. > After applying fixes for these two areas, I am able to successfully load all > of my images. > Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286]. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12834) Opening a link to a file in the inappbrowser on Android crashes the app
[ https://issues.apache.org/jira/browse/CB-12834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616824#comment-16616824 ] ASF GitHub Bot commented on CB-12834: - janpio commented on issue #244: CB-12834: (android) Fix bug when opening a download link URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/244#issuecomment-421804667 Hey @infil00p , there seems to be a merge conflict now. Could you maybe fix this? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Opening a link to a file in the inappbrowser on Android crashes the app > --- > > Key: CB-12834 > URL: https://issues.apache.org/jira/browse/CB-12834 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser > Environment: Android > 4.4 >Reporter: Mèir Noordermeer >Assignee: Joe Bowser >Priority: Critical > Labels: android, cordova, download, inappbrowser > Original Estimate: 2h > Remaining Estimate: 2h > > When opening a link to a a file (a PDF, for example) the inappbrowser > crashes, because on Android versions of 4.4 storage permissions are not > automatically granted anymore. Thus these should be requested instead of > letting the app crash. > I am creating this issue to follow the guidelines of pull requests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12930) File plugin getDirectory on windows fails on path ending with slash
[ https://issues.apache.org/jira/browse/CB-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616822#comment-16616822 ] ASF GitHub Bot commented on CB-12930: - janpio commented on issue #207: CB-12930: (windows) Fix getDirectory trailing slash path URL: https://github.com/apache/cordova-plugin-file/pull/207#issuecomment-421804551 Hey @giuseppelt , there seems to be a merge conflict now. Could you maybe fix this? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > File plugin getDirectory on windows fails on path ending with slash > --- > > Key: CB-12930 > URL: https://issues.apache.org/jira/browse/CB-12930 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file >Reporter: Giuseppe La Torre >Priority: Minor > > On Windows, getDirectory with a path ending with '/' fails. > On all other platform it works as intended. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12961) cordova-plugin-file doesn't work on browser platform with iOS devices
[ https://issues.apache.org/jira/browse/CB-12961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616823#comment-16616823 ] ASF GitHub Bot commented on CB-12961: - janpio commented on issue #210: CB-12961 URL: https://github.com/apache/cordova-plugin-file/pull/210#issuecomment-421804609 Hey @robertfromont , there seems to be a merge conflict now. Could you maybe fix this? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-plugin-file doesn't work on browser platform with iOS devices > - > > Key: CB-12961 > URL: https://issues.apache.org/jira/browse/CB-12961 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file > Environment: "browser" platform apps running in iOS browsers - Safari > and Chrome >Reporter: Robert Fromont >Priority: Minor > Original Estimate: 24h > Remaining Estimate: 24h > > An error is returned when put is called on the indexedDB database, because > apparently iOS on Safari doesn't support saving Blobs. It turns out it also > doesn't appear to support saving objects with function attributes, including > getters/setters. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
[ https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616821#comment-16616821 ] ASF GitHub Bot commented on CB-11714: - janpio commented on issue #242: CB-11714: (windows) added check for encoding in savePhoto() without height/width URL: https://github.com/apache/cordova-plugin-camera/pull/242#issuecomment-421804440 Hey @DisruptiveMind , there seems to be a merge conflict now. Could you maybe fix this? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Camera plugin for windows does not properly set content-type when selecting > JPG->PNG > > > Key: CB-11714 > URL: https://issues.apache.org/jira/browse/CB-11714 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: Master > Environment: Windows 10 >Reporter: Tyler Pham >Priority: Major > Labels: easyfix, triaged, windows > > When selecting a JPG with encodingType = Camera.EncodingType.PNG, the > resizeImage() will not modify the target content type when converting > canvas.toDataURL(...) -- the content-type will still be image/jpeg but with a > .png extension which will cause the browser to not render to image and issue > an error. > Possibly related to: CB-8618 > I have created a small fix at: > https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11846) window.open mailto: consistency
[
https://issues.apache.org/jira/browse/CB-11846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616818#comment-16616818
]
ASF GitHub Bot commented on CB-11846:
-
janpio commented on issue #186: CB-11846: window.open mailto: consistency
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/186#issuecomment-421804283
Hey @lexaurin , there seems to be a merge conflict now. Could you maybe fix
this? Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> window.open mailto: consistency
> ---
>
> Key: CB-11846
> URL: https://issues.apache.org/jira/browse/CB-11846
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: 1.5.0
>Reporter: Lex Mourek
>Priority: Minor
> Fix For: Master
>
>
> {{window.open('mailto:f...@bar.com')}} is inconsistent among platforms. On
> iOS it opens native email app, on Android and WP it silently fails and do
> nothing.
> On the other hand window.open('tel:650-349-9067') works on Android and iOS
> but not on WP.
> I know now that one can add second parameter {{_system}} to window.open to
> enforce opening link in native browser but the main problem is that it is not
> evident for the first look. It took me two hours on my project to find out
> that it is the InAppBrowser plugin which causes that my email links don't
> work on Android while it works on iOS.
> I suggest we fix {{mailto:}} links opening on Android and WP to make it
> consistent and I'm able to provide pull request for this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12145) Since Android 5 third party cookies cannot be accepted by the browser due to default policy settings
[ https://issues.apache.org/jira/browse/CB-12145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616820#comment-16616820 ] ASF GitHub Bot commented on CB-12145: - janpio commented on issue #198: CB-12145: (android) Allow third party cookies if parameter set URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/198#issuecomment-421804376 Hey @tmoxon , there seems to be a merge conflict now. Could you maybe fix this? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Since Android 5 third party cookies cannot be accepted by the browser due to > default policy settings > > > Key: CB-12145 > URL: https://issues.apache.org/jira/browse/CB-12145 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: Android 5+ >Reporter: Tim Moxon >Priority: Minor > Labels: android, cookies, security > Original Estimate: 2h > Remaining Estimate: 2h > > Since Android Lollipop / version 5 the inappbrowser cannot accept third party > cookies due to changes to the default policy from the OS. The main cordova > platform now accepts them by default to handle various workflows in which > they are necessitated, however the inappbrowser hasn't yet followed suit. > In my particular usage scenario this creates problems with an opened browser > not being able to pass through an oauth flow to another site in the > background. > I have a fix for this which I will commit now in association with this ticket. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11721) Android InAppBrowser Previous, Next page history buttons do not change with the state of the content
[ https://issues.apache.org/jira/browse/CB-11721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616817#comment-16616817 ] ASF GitHub Bot commented on CB-11721: - janpio commented on issue #182: CB-11721 android: InAppBrowser history buttons fix URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/182#issuecomment-421803934 Hey @justforgolly, there seems to be a merge conflict now. Could you maybe fix this? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Android InAppBrowser Previous, Next page history buttons do not change with > the state of the content > > > Key: CB-11721 > URL: https://issues.apache.org/jira/browse/CB-11721 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: Master > Environment: Android OS 6.0.1, Cordova CLI 6.3.1, cordova-android > 5.2.1, cordova-plugin-inappbrowser 1.4.0 >Reporter: Arjun Thounaojam >Assignee: Arjun Thounaojam >Priority: Major > Labels: android, triaged > Attachments: InAppBrowserAndroidCurrentHistoryButtons.png, > InAppBrowserAndroidImprovedHistoryButtons.png > > > Steps to reproduce: > 1) Create a simple Cordova Android app with the InAppBrowser plugin pointing > to a website. E.g. https://news.google.com > 2) Navigate back and forth between different pages > 3) Observe the history buttons on the toolbar > Expected behavior: > The Previous / Next arrow buttons should become highlighted or faded based on > where in the page history the content is. > This behavior is standard on most browsers. The iOS InAppBrowser implements > it too. > Observed behavior: > The Previous / Next buttons remain highlighted regardless of if it's possible > to navigate back or forward in the content. > This was never implemented for Android so wasn't sure if Issue Type should be > a Bug or Improvement. Left it at default. > I have a potential implementation. Will fork repo and trigger a pull request > soon. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11409) iOS memory warning's automated release could be optional
[
https://issues.apache.org/jira/browse/CB-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616816#comment-16616816
]
ASF GitHub Bot commented on CB-11409:
-
janpio commented on issue #101: CB-11409: (iOS) New method allowing to disable
automated memory release on memoryWarning
URL:
https://github.com/apache/cordova-plugin-media/pull/101#issuecomment-421803669
Hey @tbrebant, seems there is a merge conflict now. Could you please take
care of this? Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> iOS memory warning's automated release could be optional
>
>
> Key: CB-11409
> URL: https://issues.apache.org/jira/browse/CB-11409
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-media
> Environment: iOS
>Reporter: Thibaut Brebant
>Priority: Minor
> Labels: media, memory, warning
>
> It would be great to have an option to control if whether or not the user
> wants to release all audio resources when a Memory Warning is received on iOS.
> User may want to have a better control of what is happening when a memory
> warning is received, such as releasing other resources first, and eventually,
> manually, request for a resource release.
> Maybe something like:
> {code}
> Media.setAutoReleaseOnMemWarning(true/false);
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11314) Live Streams are not playing on Android 6
[
https://issues.apache.org/jira/browse/CB-11314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616815#comment-16616815
]
ASF GitHub Bot commented on CB-11314:
-
janpio commented on issue #97: CB-11314 android: avoid seeking on media without
duration
URL:
https://github.com/apache/cordova-plugin-media/pull/97#issuecomment-421803569
There is a merge conflict now @schoetty. Could you maybe fix that please?
Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Live Streams are not playing on Android 6
> -
>
> Key: CB-11314
> URL: https://issues.apache.org/jira/browse/CB-11314
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media
> Environment: Android >= 6.0
>Reporter: Stefan Schöttelndreyer
>Priority: Major
>
> On Android >= 6.0, live streams do not start playing. This is because the
> {{onPrepared}} method of {{AudioPlayer}} invokes {{seekTo}}, what leads to an
> error because live streams have no duration and hence can not be seeked.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10883) resolveLocalFileSystemURL cordova.file.externalRootDirectory is fail on android 6.0
[
https://issues.apache.org/jira/browse/CB-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616814#comment-16616814
]
ASF GitHub Bot commented on CB-10883:
-
janpio commented on issue #173: CB-10883: Added getPermissionEntries for
Directory Entries, which is affected by Marshmallow Permissions
URL:
https://github.com/apache/cordova-plugin-file/pull/173#issuecomment-421803162
There is a conflict now @infil00p. Could you maybe resolve this? Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> resolveLocalFileSystemURL cordova.file.externalRootDirectory is fail on
> android 6.0
> ---
>
> Key: CB-10883
> URL: https://issues.apache.org/jira/browse/CB-10883
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file
> Environment: cordova 6.0
> cordova-plugin-file 4.1.2-dev
> device android 6.0
>Reporter: junyuz
>Assignee: Joe Bowser
>Priority: Major
> Labels: Android, patch
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> window.resolveLocalFileSystemURL(cordova.file.externalRootDirectory,
> function(dirEntry) {
> var directoryReader = dirEntry.createReader();
> directoryReader.readEntries(function(entries) {}
> }
> on android6.0 entries.length==0
> but on android4.x 5.x is run good
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10795) [InAppBrowser] Circular loop if app had an intent-filter defined for the URL being opened
[
https://issues.apache.org/jira/browse/CB-10795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616812#comment-16616812
]
ASF GitHub Bot commented on CB-10795:
-
janpio commented on issue #154: [CB-10795] Exclude current app from external
intent list
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/154#issuecomment-421803021
@dpolivy I know this has been quite some time ago, but there is a merge
conflict now. Could you maybe resolve this? Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [InAppBrowser] Circular loop if app had an intent-filter defined for the URL
> being opened
> -
>
> Key: CB-10795
> URL: https://issues.apache.org/jira/browse/CB-10795
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Reporter: Dan Polivy
>Priority: Minor
> Labels: Android, triaged
>
> Consider the following scenario:
> 1. App "X" has an intent-filter defined that says it can open URLs for
> "www.example.com". (e.g., using
> https://github.com/EddyVerbruggen/Custom-URL-scheme plugin)
> 2. App "X" wants to launch a specific URL on www.example.com in the system
> browser.
> 3. App "X" uses InAppBrowser plugin and calls {{window.open}} with
> {{_system}} as the target.
> Actual:
> Since the app itself has an intent-filter defined for "www.example.com",
> InAppBrowser will just re-launch the app with the intent. In some cases, if a
> default handler is not chosen, one will get a chooser, however the app will
> still be listed as the default option.
> Expected:
> The app should be able to launch the URL in the system browser to avoid a
> circular redirect.
> There is some discussion of this issue on stackoverflow:
> http://stackoverflow.com/questions/18682833/how-to-exclude-a-specific-application-from-action-view-intent
> http://stackoverflow.com/questions/29529027/open-url-in-browser-even-though-my-app-registered-an-intent-filter-for-it
> I think it might be reasonable for InAppBrowser, in {{openExternal}}, to
> explicitly remove the current app from the list.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6708) iOS does not preserve GPS metadata from images picked from the Photo Gallery
[ https://issues.apache.org/jira/browse/CB-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616811#comment-16616811 ] ASF GitHub Bot commented on CB-6708: janpio commented on issue #230: CB-6708: [iOS]keep the metadata of image, add GPS when take picture from Camera. URL: https://github.com/apache/cordova-plugin-camera/pull/230#issuecomment-421802563 There is a conflict in a file now unfortunately. Could you take care of this @lxbyes? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS does not preserve GPS metadata from images picked from the Photo Gallery > > > Key: CB-6708 > URL: https://issues.apache.org/jira/browse/CB-6708 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: Ryan Murphy >Priority: Minor > Labels: Triaged, camera, gps, ios > > Images picked from the gallery do not preserve metadata when saved to tmp. > Particularly they lose GPS metadata. > This extra metadata is available in asset.defaultRepresentation.metadata. > I have a solution that works for my purpose. But currently only saving with > asset.defaultRepresentation.fullResolutionImage. > Approach to get the asset: https://github.com/foundry/UIImageMetadata > Approach to save the asset: http://stackoverflow.com/a/15398387/618412 > (answer from Andrew Theis). > Thanks for consideration. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12367) Modernize styling of iOS InAppBrowser view
[
https://issues.apache.org/jira/browse/CB-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616810#comment-16616810
]
ASF GitHub Bot commented on CB-12367:
-
janpio commented on issue #210: CB-12367: Modernize styling of iOS InAppBrowser
view
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/210#issuecomment-421802427
Some more merge conflicts, tiny stuff again. Could you take care of that
@reidab please? Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Modernize styling of iOS InAppBrowser view
> --
>
> Key: CB-12367
> URL: https://issues.apache.org/jira/browse/CB-12367
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-inappbrowser
>Affects Versions: 1.6.1
>Reporter: Reid Beels
>Priority: Major
>
> I've been working on a branch that brings several visual and configuration
> improvements to the iOS InAppBrowser view, along with a little refactoring of
> the view setup code.
> This PR:
> * breaks up the large {{CDVInAppBrowserViewController createView}} method
> into several smaller helper methods to handle the creation of individual
> subviews
> * gives the {{addressLabel}} a wrapping view to provide flexibility of
> background color / padding
> * changes the default toolbar style from {{UIBarStyleBlackOpaque}} to
> {{UIBarStyleDefault}} to match the system default
> * adds a {{toolbarstyle}} configuration option that accepts {{default}} or
> {{black}}
> * sets the status bar style and background color to match the
> {{toolbarstyle}}, so that top toolbars can blend nicely into the status bar
> * replaces the unicode navigation arrows (◄►) with drawn arrows that match
> those used in Safari
> * adds a {{tintcolor}} configuration option that accepts hex strings like
> {{F8A027}}. If not provided, or set to {{default}}, controls will be rendered
> in the default iOS blue, or in white when {{toolbarstyle=black}} is set.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14260) captureImage: permission denial on android 8.1
[
https://issues.apache.org/jira/browse/CB-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616795#comment-16616795
]
ASF GitHub Bot commented on CB-14260:
-
jcesarmobile commented on issue #95: CB-14260: (android) captureImage
permission denial on android 8.1
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/95#issuecomment-421792949
This doesn't need a certain number of "tests and approvals", it just needs
to be verified by some core contributor that can merge, so instead of getting
friends saying "it works", what you can do to accelerate the process is to
provide a sample app where the bug can be easily reproduced so it's easier for
whoever test this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> captureImage: permission denial on android 8.1
> --
>
> Key: CB-14260
> URL: https://issues.apache.org/jira/browse/CB-14260
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media-capture
>Affects Versions: 3.0.0
>Reporter: Marco
>Priority: Major
>
> When I call "captureImage" method I accept all permissions but I get:
> {noformat}
> java.lang.SecurityException: Permission Denial: writing
> com.android.providers.media.MediaProvider uri
> content://media/external/images/media from pid=12716, uid=10079 requires
> android.permission.WRITE_EXTERNAL_STORAGE, or grantUriPermission(){noformat}
> I'm using cordova-plugin-media-capture version 3.0.2
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12875) iOS Magnifying glass is showing wrong content in iFrame
[ https://issues.apache.org/jira/browse/CB-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile resolved CB-12875. --- Resolution: Fixed Fixed in 3.0.1-dev > iOS Magnifying glass is showing wrong content in iFrame > --- > > Key: CB-12875 > URL: https://issues.apache.org/jira/browse/CB-12875 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova@7.0.0 >Reporter: Thom Eijken >Priority: Major > Attachments: IMG_5791.jpg, IMG_5792.jpg > > > Our app is opening certain third party web pages using the inAppbrowser and > some of those pages (unfortunately) contain content in iFrames. > The issue occurs on iOS when you push and hold the screen to select text or > use the magnifying glass to set the cursor in an input/textarea field. What > happens is that the magnifying glass doesn't actually show the content within > the iFrame, but it shows the content underneath the in-appbrowser (the page > that launched the in-appbrowser). > I've created a very simple example to reproduce this. Just load test.html in > the in-appbrowser and use the magnifying glass inside the iframe. > File: test.html > > > > > > File: iframe.html > > > vhutriwbhrobh jbiortjtboirtw j bjrowijb iorwtj boirjgwobj org brw > jborjgiobj rojb org iob roi jboirtjwbiojrtowbj orjw bojrtobj rtj borjwiob > jrwio biorw b > vhreiuvhuierf hviu ehv oueh vo qv > o > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616774#comment-16616774 ] ASF subversion and git services commented on CB-14166: -- Commit e5695ccdd07312785b4d9036f6b01b8aa55d13ee in cordova-lib's branch refs/heads/cross-spawn-test from Almir Kadric [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=e5695cc ] CB-14166: (cli) Fixed issue when install plugins on windows The npm package name is already wrapped in quotes to prevent special characters from being execute. However the additional win32 code was further injecting quotes around the version causing npm to return a EINVALIDTAGNAME error. The win32 code is redundant and seems to not be required. > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
