Re: [PR] feat: add privacy-manifest config support [cordova-ios]

2024-03-07 Thread via GitHub


knaito-asial commented on code in PR #1406:
URL: https://github.com/apache/cordova-ios/pull/1406#discussion_r1517208726


##
lib/PlatformConfigParser.js:
##
@@ -0,0 +1,35 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+'use strict';
+
+const ConfigParser = require('cordova-common').ConfigParser;
+
+class PlatformConfigParser extends ConfigParser {
+/** getPrivacyManifest */
+getPrivacyManifest () {
+const platform_manifest = 
this.doc.find('./platform[@name="ios"]/privacy-manifest');
+if (platform_manifest != null) {
+return platform_manifest;
+}
+return null;
+}

Review Comment:
   Thank you. I updated the code as you suggested.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] `cordova run ios --target=iPhone-X` causes build error [cordova-ios]

2024-03-07 Thread via GitHub


erisu commented on issue #1371:
URL: https://github.com/apache/cordova-ios/issues/1371#issuecomment-1985010695

   While this might not be directly related, please ensure that you have the 
iPhone X simulator installed.
   
   iPhone X is considered an older device now. It's worth noting that Xcode may 
no longer include iPhone X as a default "Run Destination". I had to manually 
add it.
   
   To do so, you'll need to open Xcode and follow these steps:
   
   1. Go to Product -> Destination -> Manage Run Destinations...
   2. In the window that opens, select "Simulators" on the left.
   3. Confirm if "iPhone X" is listed
   
   If it's not, you'll need to add it by clicking the "+" button at the bottom.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] `cordova run ios --target=iPhone-X` causes build error [cordova-ios]

2024-03-07 Thread via GitHub


contfedorov commented on issue #1371:
URL: https://github.com/apache/cordova-ios/issues/1371#issuecomment-1984995976

   @erisu 
   I have followed exactly steps you've described: created empty new project 
and run it. Well, just run `cordova platform add ios@latest` command without 
`@latest`.
   
   I also don't run it on real device, but on simulator.
   
   I can try to check further. Hope this is just my local configuration 
problem. Maybe you can point me any direction I should follow?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] `cordova run ios --target=iPhone-X` causes build error [cordova-ios]

2024-03-07 Thread via GitHub


erisu commented on issue #1371:
URL: https://github.com/apache/cordova-ios/issues/1371#issuecomment-1984971452

   @contfedorov, I'm not entirely sure what "re-creating project from scratch" 
entails, but have you attempted creating a new sample project with no 
modifications other than adding the iOS platform?
   
   You mentioned in the ticket:
   > First, I've checked via my current project (not using the sample one).
   
   I would suggest trying with the minimum steps:
   ```
   cordova create cdvTestProject
   cd cdvTestProject
   cordova platform add ios@latest
   cordova run ios --target=iPhone-X
   ```
   
   No code changes, configuration file modifications, plugin or resource 
additions are made, and the project is not opened in Xcode.
   
   Also, please note that I am not using a device for testing. I do not have a 
device plugged into my Mac. I am using a simulator for this test.
   
   If the issue persists with a sample/blank project, I am leaning more towards 
your environment being the issue.
   
   I don't believe upgrading Xcode or macOS will necessarily make a difference, 
but it's worth noting that Apple has stated that as of April 2024, all apps 
submitted to the App Store must be built with a minimum of Xcode 15 and the iOS 
17 SDK. Eventually, you will need to upgrade. However, I don't expect it to 
change the outcome of this issue.
   
   If the problem doesn't occur with the blank sample project, I suggest adding 
plugins, other platforms, and application code one by one and building in 
between, until you identify what causes the issue.
   
   Since I'm unable to reproduce this problem, it will be challenging for me to 
determine the cause of your issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [PR] feat: add privacy-manifest config support [cordova-ios]

2024-03-07 Thread via GitHub


breautek commented on code in PR #1406:
URL: https://github.com/apache/cordova-ios/pull/1406#discussion_r1516638428


##
lib/PlatformConfigParser.js:
##
@@ -0,0 +1,35 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+'use strict';
+
+const ConfigParser = require('cordova-common').ConfigParser;
+
+class PlatformConfigParser extends ConfigParser {
+/** getPrivacyManifest */
+getPrivacyManifest () {
+const platform_manifest = 
this.doc.find('./platform[@name="ios"]/privacy-manifest');
+if (platform_manifest != null) {
+return platform_manifest;
+}
+return null;
+}

Review Comment:
   I think the condition here is redundent.
   
   We are:
   
   1. creating a variable without making any use of it,
   2. checking if it's not null and returning it
   3. Otherwise returning null, which is the value of said variable if it 
reached this point.
   
   I think we can simplify it just simply returning the result of 
`this.doc.find(...)`.
   
   If we want to make it clear that null can be returned, we can perhaps add a 
JSDoc
   
   ```suggestion
   /**
* Returns the privacy manifest node, if available.
* Otherwise `null` is returned.
*/
   getPrivacyManifest () {
   return this.doc.find('./platform[@name="ios"]/privacy-manifest');
   }
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] `cordova run ios --target=iPhone-X` causes build error [cordova-ios]

2024-03-07 Thread via GitHub


contfedorov commented on issue #1371:
URL: https://github.com/apache/cordova-ios/issues/1371#issuecomment-1984129487

   @erisu 
   Double-checked this by re-creating project from scratch. Can confirm: an 
issue is reproducible on my machine. Build process can't find native imports 
(``, etc.) Here is my setup. Any steps should I take 
to align it with yours? Upgrade Node.js/macOS?
   
   ```
   % cordova info
   
   Cordova Packages:
   
   cli: 12.0.0
   common: 5.0.0
   create: 5.0.0
   lib: 12.0.1
   common: 5.0.0
   fetch: 4.0.0
   serve: 4.0.1
   
   Project Installed Platforms:
   
   ios: 7.0.1
   
   Project Installed Plugins:
   
   
   Environment:
   
   OS: macOS Sonoma 14.1.1 (23B81) (darwin 23.1.0) x64
   Node: v18.17.0
   npm: 9.6.7
   
   ios Environment:
   
   xcodebuild:
   Xcode 15.2
   Build version 15C500b
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] Cannot resume the app after hiding with lounchMode "singleInstance" or "single Top" [cordova-android]

2024-03-07 Thread via GitHub


kd8ssq commented on issue #1150:
URL: 
https://github.com/apache/cordova-android/issues/1150#issuecomment-1984062225

   > There is no way to prevent the app from being destroyed when it's entering 
the background.
   > 
   > The OS may destroy the app activity for several reasons. If the app is in 
the foreground those reasons are limited, but it's far more likely for the OS 
to destroy the app once the app goes in the background.
   > 
   > If the activity `onDestroy` is called (as shown in the OP stacktrace) it 
means the OS has decided to destroy the app. More information on the android 
life cycle can be read 
[here](https://developer.android.com/guide/components/activities/activity-lifecycle#ondestroy).
   > 
   > Note that natively there are ways to serialize/store view state so that it 
can be recreated later during the `Create` life-cycle, however as far as I 
know, there is no way to serialize webview state. It is rather large issue with 
all webview-based applications.
   
   Thanks.  That's too bad.  I can see the OnPause being triggered but then 
some destroy event is also being triggered afterwards.  I'll take a look at the 
idea of saving the state. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] Cannot resume the app after hiding with lounchMode "singleInstance" or "single Top" [cordova-android]

2024-03-07 Thread via GitHub


breautek commented on issue #1150:
URL: 
https://github.com/apache/cordova-android/issues/1150#issuecomment-1984012897

   There is no way to prevent the app from being destroyed when it's entering 
the background.
   
   The OS may destroy the app activity for several reasons. If the app is in 
the foreground those reasons are limited, but it's far more likely for the OS 
to destroy the app once the app goes in the background.
   
   If the activity `onDestroy` is called (as shown in the OP stacktrace) it 
means the OS has decided to destroy the app. More information on the android 
life cycle can be read 
[here](https://developer.android.com/guide/components/activities/activity-lifecycle#ondestroy).
   
   Note that natively there are ways to serialize/store view state so that it 
can be recreated later during the `Create` life-cycle, however as far as I 
know, there is no way to serialize webview state. It is rather large issue with 
all webview-based applications.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] Cannot resume the app after hiding with lounchMode "singleInstance" or "single Top" [cordova-android]

2024-03-07 Thread via GitHub


kd8ssq commented on issue #1150:
URL: 
https://github.com/apache/cordova-android/issues/1150#issuecomment-1983981066

   I actually noticed the same thing on a handful of different simulator tests 
with different versions of cordova-android (11 and 12).
   
   Were you ever able to figure out how to get the app to not be destroyed when 
you send it to the background?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] "Plugin's Cocoapods don't persist if another plugin is added after it" [cordova-ios]

2024-03-07 Thread via GitHub


erisu commented on issue #649:
URL: https://github.com/apache/cordova-ios/issues/649#issuecomment-1983902191

   I am closing out this issue as the original issue on JIRA was closed with a 
fix version of cordova-ios@4.5.5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] "Plugin's Cocoapods don't persist if another plugin is added after it" [cordova-ios]

2024-03-07 Thread via GitHub


erisu closed issue #649: "Plugin's Cocoapods don't persist if another plugin is 
added after it"
URL: https://github.com/apache/cordova-ios/issues/649


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [D] cordova requirements Command failed with ENOENT [cordova]

2024-03-07 Thread via GitHub


GitHub user breautek added a comment to the discussion: cordova requirements 
Command failed with ENOENT

> Why doesn't cordova notice when I change the java sdk version?

Cordova first checks and uses `CORDOVA_JAVA_HOME` environment variable if set, 
then falls back to `JAVA_HOME` (if I recall correctly.)

So if `CORDOVA_JAVA_HOME` or `JAVA_HOME` is set to a JDK 17 environment, it 
will use those binaries over say a `PATH` order. I'd also note that JDK 17 
would be the recommended environment to use as that's what Android Studio will 
use and their tools assumes a JDK 17 environment.  JDK 19 or later is not 
officially supported by the android SDK so mileage may vary there.

For what it's worth, I also get

```
Android target: not installed
Command failed with ENOENT: avdmanager list target
spawn avdmanager ENOENT
```

when running the requirements command, but cordova and android building still 
works, so those might be a bug with the requirements command itself, rather 
than the bug in the actual cordova-android platform.

> How can I tell it there are android targets on my system (supposing the 
> "platforms;android-xx" really are android targets"?

A workaround would be to use `sdkmanager` directly as you were already doing:

`$ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager --list_installed`

And you're right, you're looking for `platforms;...` lines:

```
  platforms;android-33  | 3| 
Android SDK Platform 33| platforms/android-33   
  
  platforms;android-34  | 3| 
Android SDK Platform 34| platforms/android-34  
```

In my case, I have both android API 33 and 34 installed. At this time, Cordova 
only supports API 33. API 34 support will be introduced in the upcoming 
cordova-android@13 release.

GitHub link: 
https://github.com/apache/cordova/discussions/469#discussioncomment-8708288


This is an automatically sent email for issues@cordova.apache.org.
To unsubscribe, please send an email to: issues-unsubscr...@cordova.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] Any possible reason why files in www folder load ok in emulator but not in device? [cordova-ios]

2024-03-07 Thread via GitHub


jfoclpf commented on issue #1293:
URL: https://github.com/apache/cordova-ios/issues/1293#issuecomment-1983264329

   thanks for all the support and great work 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] Any possible reason why files in www folder load ok in emulator but not in device? [cordova-ios]

2024-03-07 Thread via GitHub


jfoclpf closed issue #1293: Any possible reason why files in www folder load ok 
in emulator but not in device?
URL: https://github.com/apache/cordova-ios/issues/1293


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] Any possible reason why files in www folder load ok in emulator but not in device? [cordova-ios]

2024-03-07 Thread via GitHub


erisu commented on issue #1293:
URL: https://github.com/apache/cordova-ios/issues/1293#issuecomment-1983250887

   It seems that the discussion has reached a resolution. If the issue has been 
resolved, could you please close the ticket?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] `cordova run ios --target iPhone-X --emulator` builds for "iPhone SE Simulator" [cordova-ios]

2024-03-07 Thread via GitHub


erisu commented on issue #593:
URL: https://github.com/apache/cordova-ios/issues/593#issuecomment-1982991629

   This issue is no longer valid.
   
   Similar issues have been reported in other tickets, tested, and confirmed to 
not be an issue with the latest cordova-ios platform.
   
   Since Paramedic typically utilizes the main branch or the latest release, 
this issue should not persist.
   
   If the problem persists, please open a new ticket.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] `cordova run ios --target iPhone-X --emulator` builds for "iPhone SE Simulator" [cordova-ios]

2024-03-07 Thread via GitHub


erisu closed issue #593: `cordova run ios --target iPhone-X --emulator` builds 
for "iPhone SE Simulator"
URL: https://github.com/apache/cordova-ios/issues/593


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] `cordova run --list` returns "iPhones 4S, 9.0" simulator, using "iPhone-4s" as target fails with "xcodebuild: error: Unable to find a destination matching the provided destination specifier: {

2024-03-07 Thread via GitHub


erisu commented on issue #601:
URL: https://github.com/apache/cordova-ios/issues/601#issuecomment-1982944936

   The ticket will be closed as the issue is no longer present.
   
   I have tested this with the latest cordova-ios release (7.0.1).
   
   Since the ticket was created, there have been a few changes:
   
   - When using the `cordova run --list` command, the platform flag is now 
required to be included.
   - The latest version of Xcode no longer includes iPhone 4s binaries.
   
   Taking into account these changes, I tested with the following:
   
   ```
   $ cordova run ios --list
   $ cordova run ios --target=iPhone-6s
   ```
   
   We can confirm that `iPhone-6s` is listed:
   
   ```
   cordova run ios --list
   Available iOS Devices:
   Available iOS Simulators:
iPhone-13-mini, 17.2
iPhone-SE-3rd-generation, 17.2
iPhone-SE-3rd-generation, 17.0
iPhone-14-Pro, 17.0
iPhone-14-Pro-Max, 17.0
iPad-mini-6th-generation, 17.2
iPad-mini-6th-generation, 17.0
iPad-Pro-12-9-inch-6th-generation-8GB, 17.2
iPad-Pro-12-9-inch-6th-generation-8GB, 17.0
iPhone-XR, 17.2
iPhone-15, 17.2
iPhone-15, 17.0
iPhone-15-Plus, 17.2
iPhone-15-Plus, 17.0
iPhone-15-Pro, 17.2
iPhone-15-Pro, 17.0
iPhone-15-Pro-Max, 17.2
iPhone-15-Pro-Max, 17.0
iPad-Air-5th-generation, 17.2
iPad-10th-generation, 17.2
iPad-Pro-11-inch-4th-generation-8GB, 17.2
iPhone-14, 16.1
iPhone-X, 16.1
iPad-Pro-12-9-inch-6th-generation-16GB, 17.0
iPhone-6s, 15.5
iPhone-SE, 15.5
   ```
   
   We also confirmed that the build targets iPhone-6s and deploys to an 
iPhone-6s simulator:
   
   ```
   cordova run ios --target=iPhone-6s
   List simulator targets
   Building for "iPhone 6s" Simulator 
(com.apple.CoreSimulator.SimDeviceType.iPhone-6s, iPhone-6s).
   ...
   Target: iPhone 6s
   ...
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] `cordova run --list` returns "iPhones 4S, 9.0" simulator, using "iPhone-4s" as target fails with "xcodebuild: error: Unable to find a destination matching the provided destination specifier: {

2024-03-07 Thread via GitHub


erisu closed issue #601: `cordova run --list` returns "iPhones 4S, 9.0" 
simulator, using "iPhone-4s" as target fails with "xcodebuild: error: Unable to 
find a destination matching the provided destination specifier: { platform:iOS 
Simulator, OS:latest, name:iPhone 4s }"
URL: https://github.com/apache/cordova-ios/issues/601


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] `cordova run ios --target ... --emulator` builds for different target [cordova-ios]

2024-03-07 Thread via GitHub


erisu commented on issue #603:
URL: https://github.com/apache/cordova-ios/issues/603#issuecomment-1982895296

   The ticket will be closed as it's no longer an issue.
   
   When executing the commands `cordova run ios --target=iPhone-X` and `cordova 
run ios --target=iPhone-XR`, I can confirm that the target value was used 
correctly. The application built and deployed to the respective target values.
   
   I have tested this on the latest cordova-ios release (7.0.1).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] `cordova run ios --target ... --emulator` builds for different target [cordova-ios]

2024-03-07 Thread via GitHub


erisu closed issue #603: `cordova run ios --target ... --emulator` builds for 
different target
URL: https://github.com/apache/cordova-ios/issues/603


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] `cordova run ios -target iPhone-XR` leads to `Building for "iPhone X" Simulator`, later not able to start XR simulator to run the app [cordova-ios]

2024-03-07 Thread via GitHub


erisu commented on issue #602:
URL: https://github.com/apache/cordova-ios/issues/602#issuecomment-1982884431

   Will close out this ticket as no longer an issue. 
   
   Using the latest cordova-ios release (7.0.1), running the above command 
`cordova run ios --target=iPhone-XR` shows that the target is `iPhone Xʀ`.
   
   It successfully builds and deploys app to the iPhone Xʀ simulator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] `cordova run ios -target iPhone-XR` leads to `Building for "iPhone X" Simulator`, later not able to start XR simulator to run the app [cordova-ios]

2024-03-07 Thread via GitHub


erisu closed issue #602: `cordova run ios -target iPhone-XR` leads to `Building 
for "iPhone X" Simulator`, later not able to start XR simulator to run the app
URL: https://github.com/apache/cordova-ios/issues/602


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



Re: [I] `cordova run ios --target=iPhone-X` causes build error [cordova-ios]

2024-03-07 Thread via GitHub


erisu commented on issue #1371:
URL: https://github.com/apache/cordova-ios/issues/1371#issuecomment-1982855954

   I was unable to reproduce this issue.
   
   My Example Project Data
   
   ```
   $ cordova info
   Cordova Packages:
   
   cli: 12.0.0
   common: 5.0.0
   create: 5.0.0
   lib: 12.0.1
   common: 5.0.0
   fetch: 4.0.0
   serve: 4.0.1
   
   Project Installed Platforms:
   
   ios: 7.0.1
   
   Project Installed Plugins:
   
   
   Environment:
   
   OS: macOS Sonoma 14.2.1 (23C71) (darwin 23.2.0) arm64
   Node: v18.18.2
   npm: 9.8.1
   
   ios Environment:
   
   xcodebuild:
   Xcode 15.2
   Build version 15C500b
   ```
   
   Running command `cordova run ios --target=iPhone-X` will build and deploy 
the app successfully to iPhone X.
   
   ```
   ** BUILD SUCCEEDED **
   
   Deploying to simulator
   [ios-sim] device.name: iPhone X
   
   [ios-sim] device.runtime: iOS 16.1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org