Re: [PR] ci(gh-action): add Apache RAT & package license checker workflow [cordova-electron]
codecov-commenter commented on PR #272: URL: https://github.com/apache/cordova-electron/pull/272#issuecomment-2060433671 ## [Codecov](https://app.codecov.io/gh/apache/cordova-electron/pull/272?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 100.00%. Comparing base [(`d5ad929`)](https://app.codecov.io/gh/apache/cordova-electron/commit/d5ad92987df6f4bcba19080d6c33cba147b18166?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`09dbdc2`)](https://app.codecov.io/gh/apache/cordova-electron/pull/272?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@Coverage Diff@@ ##master #272 +/- ## = Coverage 100.00% 100.00% = Files 1414 Lines 656 656 = Hits 656 656 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-electron/pull/272?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] ci: Set up CodeQL analysis w/ fix [cordova-electron]
erisu merged PR #276: URL: https://github.com/apache/cordova-electron/pull/276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] ci: Set up CodeQL analysis w/ fix [cordova-electron]
codecov-commenter commented on PR #276: URL: https://github.com/apache/cordova-electron/pull/276#issuecomment-2060379167 ## [Codecov](https://app.codecov.io/gh/apache/cordova-electron/pull/276?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 100.00%. Comparing base [(`abe901b`)](https://app.codecov.io/gh/apache/cordova-electron/commit/abe901b978acc0c330a8ee7d74dc83fd0ec73aff?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`f450289`)](https://app.codecov.io/gh/apache/cordova-electron/pull/276?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@Coverage Diff@@ ##master #276 +/- ## = Coverage 100.00% 100.00% = Files 1414 Lines 656 656 = Hits 656 656 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-electron/pull/276?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] ci: Set up CodeQL analysis w/ fix [cordova-electron]
github-advanced-security[bot] commented on PR #276: URL: https://github.com/apache/cordova-electron/pull/276#issuecomment-2060378766 This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on [this overview](/apache/cordova-electron/security/code-scanning?query=pr%3A276+is%3Aopen). Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out [the documentation](https://docs.github.com/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/about-code-scanning). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[PR] ci: Set up CodeQL analysis w/ fix [cordova-electron]
erisu opened a new pull request, #276: URL: https://github.com/apache/cordova-electron/pull/276 ### Platforms affected n/a ### Motivation and Context CodeQL scanning in CI can help identify bugs and security issues with the library. ### Description * Added CodeQL scanning with default options as part of CI. ### Testing * Ran this in my fork * Confirmed that CodeQL results showed up under security scanning * Applied additional non-breaking changes to resolve scan reports. ### Checklist - [x] I've run the tests to see all new and existing tests pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] Bump the npm_and_yarn group with 2 updates [cordova-js]
dependabot[bot] commented on PR #269: URL: https://github.com/apache/cordova-js/pull/269#issuecomment-2060298147 This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure [ignore rules](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#ignore) in dependabot.yml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] Bump the npm_and_yarn group with 2 updates [cordova-js]
dpogue commented on PR #269: URL: https://github.com/apache/cordova-js/pull/269#issuecomment-2060298125 cordova-ios is only used for testing the assembly of the cordova.js script, and we can't currently update it because the `cordova-js-src` folder is ignored by npm. I'm going to close this for now until we figure out some strategy for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] Bump the npm_and_yarn group with 2 updates [cordova-js]
dpogue closed pull request #269: Bump the npm_and_yarn group with 2 updates URL: https://github.com/apache/cordova-js/pull/269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] chore(ci): Set up CodeQL analysis [cordova-fetch]
codecov-commenter commented on PR #118: URL: https://github.com/apache/cordova-fetch/pull/118#issuecomment-2060291298 ## [Codecov](https://app.codecov.io/gh/apache/cordova-fetch/pull/118?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 92.18%. Comparing base [(`63476a4`)](https://app.codecov.io/gh/apache/cordova-fetch/commit/63476a4e3d99c237a176ef58b293703b4dd167de?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`4ab5515`)](https://app.codecov.io/gh/apache/cordova-fetch/pull/118?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #118 +/- ## === Coverage 92.18% 92.18% === Files 11 Lines 64 64 === Hits 59 59 Misses 55 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-fetch/pull/118?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] chore(ci): Set up CodeQL analysis [cordova-fetch]
github-advanced-security[bot] commented on PR #118: URL: https://github.com/apache/cordova-fetch/pull/118#issuecomment-2060290721 This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on [this overview](/apache/cordova-fetch/security/code-scanning?query=pr%3A118+is%3Aopen). Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out [the documentation](https://docs.github.com/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/about-code-scanning). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[PR] chore(ci): Set up CodeQL analysis [cordova-fetch]
dpogue opened a new pull request, #118: URL: https://github.com/apache/cordova-fetch/pull/118 ### Platforms affected All ### Motivation and Context CodeQL scanning in CI can help identify bugs and security issues with the library. ### Description * Added CodeQL scanning with default options as part of CI. ### Testing * Ran this in my fork, confirmed that CodeQL results showed up under security scanning (and then resolved several of those issues in a previous PR) ### Checklist - [x] I've run the tests to see all new and existing tests pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] iOS - Privacy Manifest [cordova-plugin-device]
erisu closed issue #192: iOS - Privacy Manifest URL: https://github.com/apache/cordova-plugin-device/issues/192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] feat(ios): add bundled resources for privacy manifest [cordova-plugin-device]
erisu merged PR #193: URL: https://github.com/apache/cordova-plugin-device/pull/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] chore: prepare package for 2.2.0-dev [cordova-plugin-device]
erisu merged PR #194: URL: https://github.com/apache/cordova-plugin-device/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] chore(ci): Set up CodeQL analysis [cordova-common]
dpogue merged PR #206: URL: https://github.com/apache/cordova-common/pull/206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] chore(deps): Update some dependencies, add Node 20 to CI [cordova-lib]
dpogue merged PR #924: URL: https://github.com/apache/cordova-lib/pull/924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[PR] chore: prepare package for 2.2.0-dev [cordova-plugin-device]
erisu opened a new pull request, #194: URL: https://github.com/apache/cordova-plugin-device/pull/194 ### Platforms affected n/a ### Motivation and Context prepare for 2.2.0 release ### Description bump package to 2.2.0-dev ### Testing n/a ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Cordova was listed on the list of requirements for third-party SDKs announced by Apple today. [cordova-ios]
vtellez commented on issue #1391: URL: https://github.com/apache/cordova-ios/issues/1391#issuecomment-2060020214 Today, we uploaded an APP including the new directives in the config.xml and we did not receive any warning from Apple when processing the binary. The APP has been reviewed and approved without problems, so it seems that the new situation would be resolved Thank you very much to everyone for your help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Error Code 3 If more than one camera application is present in Mobile [cordova-plugin-media-capture]
breautek commented on issue #139: URL: https://github.com/apache/cordova-plugin-media-capture/issues/139#issuecomment-2059536270 Closing as duplicate in favour of https://github.com/apache/cordova-plugin-media-capture/issues/291 which contains a lot more details and is well more documented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Error Code 3 If more than one camera application is present in Mobile [cordova-plugin-media-capture]
breautek closed issue #139: Error Code 3 If more than one camera application is present in Mobile URL: https://github.com/apache/cordova-plugin-media-capture/issues/139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] The startURLSchemeTask method in CDVURLSchemeHandler was not executed [cordova-ios]
GymotgM commented on issue #1421: URL: https://github.com/apache/cordova-ios/issues/1421#issuecomment-2058614294 I have reviewed Cordova plugin webview proxy Operated in startURLSchemeTask, but the startURLSchemeTask method has not been executed yet The loadRequest and decisionPolicyForNavigationAction in CDVWebViewEngine are both executed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[I] The startURLSchemeTask method in CDVURLSchemeHandler was not executed [cordova-ios]
GymotgM opened a new issue, #1421: URL: https://github.com/apache/cordova-ios/issues/1421 Apache Cordova uses GitHub Issues as a feature request and bug tracker _only_. For usage and support questions, please check out the resources below. Thanks! Start the app, enter CDVWebViewEngine, execute loadRequest, but do not proceed to CDVURLSchemeHandler to execute the startURLSchemeTask method. What should be done next You can get answers to your usage and support questions about **Apache Cordova** on: * Slack Community Chat: https://cordova.slack.com (you can sign-up at https://s.apache.org/cordova-slack) * StackOverflow: https://stackoverflow.com/questions/tagged/cordova using the tag `cordova` --- If you are using a tool that uses Cordova internally, like e.g. Ionic, check their support channels: * **Ionic Framework** * [Ionic Community Forum](https://forum.ionicframework.com/) * [Ionic Worldwide Slack](https://ionicworldwide.herokuapp.com/) * **PhoneGap** * [PhoneGap Developer Community](https://forums.adobe.com/community/phonegap) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[I] Cordova undefined when AndroidInsecureFileModeEnabled set to false [cordova-android]
formidable255 opened a new issue, #1706: URL: https://github.com/apache/cordova-android/issues/1706 Using cordova android version 12 via voltbuilder. Currently trying to fix a google recaptcha issue on android where google returns invalid domain. This happens when `AndroidInsecureFileModeEnabled` is set to true and the origin is `file:///`. When set to false, the domain becomes 'https' and recaptcha works fine but cordova is undefined inside the project causing non of my plug-ins to work. Why does cordova become undefined and any way this can be fixed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] chore(ci): Set up CodeQL analysis [cordova-common]
github-advanced-security[bot] commented on PR #206: URL: https://github.com/apache/cordova-common/pull/206#issuecomment-2058414630 This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on [this overview](/apache/cordova-common/security/code-scanning?query=pr%3A206+is%3Aopen). Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out [the documentation](https://docs.github.com/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/about-code-scanning). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] chore(ci): Set up CodeQL analysis [cordova-common]
codecov-commenter commented on PR #206: URL: https://github.com/apache/cordova-common/pull/206#issuecomment-2058416554 ## [Codecov](https://app.codecov.io/gh/apache/cordova-common/pull/206?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 88.40%. Comparing base [(`0901c1d`)](https://app.codecov.io/gh/apache/cordova-common/commit/0901c1dcaef43634ce91fcc2ab1657c0a5982c49?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`d214977`)](https://app.codecov.io/gh/apache/cordova-common/pull/206?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #206 +/- ## === Coverage 88.40% 88.40% === Files 20 20 Lines1147 1147 === Hits 1014 1014 Misses133 133 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-common/pull/206?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[PR] chore(ci): Set up CodeQL analysis [cordova-common]
dpogue opened a new pull request, #206: URL: https://github.com/apache/cordova-common/pull/206 ### Platforms affected All ### Motivation and Context CodeQL scanning in CI can help identify bugs and security issues with the library. ### Description * Added CodeQL scanning with default options as part of CI. ### Testing * Ran this in my fork, confirmed that CodeQL results showed up under security scanning (and then resolved several of those issues in a previous PR) ### Checklist - [x] I've run the tests to see all new and existing tests pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] The CDVURLProtocol no longer exists, so how should we modify the interception? [cordova-ios]
GymotgM commented on issue #1420: URL: https://github.com/apache/cordova-ios/issues/1420#issuecomment-2058351730 @jcesarmobile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] The CDVURLProtocol no longer exists, so how should we modify the interception? [cordova-ios]
GymotgM commented on issue #1420: URL: https://github.com/apache/cordova-ios/issues/1420#issuecomment-2058350988 How to use WebviewProxy? Pod install cannot find this plugin, so I can only manually put the file into the project. After putting it into the project, how can I proceed to the - (BOOL) overrideSchemeTask: (id) urlSchemeTask method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
