[jira] [Commented] (CB-12623) Android: device plugin should access Context through webView.getContext()
[ https://issues.apache.org/jira/browse/CB-12623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846409#comment-17846409 ] ASF subversion and git services commented on CB-12623: -- Commit 59163987b6de4bad902e8da5f27b9f9d0023fec0 in cordova-plugin-device's branch refs/heads/pick from Xiaolei Yu [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-device.git;h=5916398 ] CB-12623: (android) use the new context getter to access Context > Android: device plugin should access Context through webView.getContext() > - > > Key: CB-12623 > URL: https://issues.apache.org/jira/browse/CB-12623 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-plugin-device >Reporter: Xiaolei Yu >Priority: Minor > Labels: android-next > Fix For: cordova-android-7.0.0 > > > The device plugin only requires a valid Context but currently depends on an > active Activity, and does not work when the WebView is created in a service. > CB-7976 is a similar issue. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11462) Coordinates heading and speed can be negative under iOS
[ https://issues.apache.org/jira/browse/CB-11462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765428#comment-17765428 ] ASF subversion and git services commented on CB-11462: -- Commit 13f2a203c4c6194da2feb5e5f41241fb8ce3a7bc in cordova-plugin-geolocation's branch refs/heads/master from Norman Breau [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-geolocation.git;h=13f2a20 ] fix: heading speed w3c spec (#270) * CB-11462: (all) Make sure Coordinates#speed follows the w3c specification. Speed can have a negative value on iOS devices when the OS is not able to determine the current speed. This is against the w3c specification. Which only allows null and a number value >= 0. See the following links for further informations: * https://dev.w3.org/geo/api/spec-source.html#speed * https://developer.apple.com/library/ios/documentation/CoreLocation/Reference/CLLocation_Class/#//apple_ref/occ/instp/CLLocation/speed * CB-11462: (all) Make sure Coordinates#heading follows the w3c specification. Heading (course) can have a negative value on iOS devices when the OS is not able to determine the current heading. This is against the w3c specification. Which only allows null and a number value >= 0 and <= 360. See the following links for further informations: * https://dev.w3.org/geo/api/spec-source.html#heading * https://developer.apple.com/library/ios/documentation/CoreLocation/Reference/CLLocation_Class/#//apple_ref/occ/instp/CLLocation/course - Co-authored-by: Malte Legenhausen > Coordinates heading and speed can be negative under iOS > --- > > Key: CB-11462 > URL: https://issues.apache.org/jira/browse/CB-11462 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-geolocation >Affects Versions: Master >Reporter: Malte Legenhausen >Priority: Major > > On iOS the values heading and speed can be negative values according to the > documentation of CLLocation. These values are directly exposed by the > Coordinates object, which leads to unwanted bahavior. According to the w3c > specification these values are only allows to be null or greater 0. > Following links for further informations: > * https://dev.w3.org/geo/api/spec-source.html#heading > * https://dev.w3.org/geo/api/spec-source.html#speed > * > https://developer.apple.com/library/ios/documentation/CoreLocation/Reference/CLLocation_Class/#//apple_ref/occ/instp/CLLocation/course > * > https://developer.apple.com/library/ios/documentation/CoreLocation/Reference/CLLocation_Class/#//apple_ref/occ/instp/CLLocation/speed > I already provided a pull request: > https://github.com/apache/cordova-plugin-geolocation/pull/77 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11982) create new cordova config command
[ https://issues.apache.org/jira/browse/CB-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709077#comment-17709077 ] ASF subversion and git services commented on CB-11982: -- Commit f1b4dc892ae57be10061eab3df850e03970f26ce in cordova-discuss's branch refs/heads/master from Audrey So [ https://gitbox.apache.org/repos/asf?p=cordova-discuss.git;h=f1b4dc8 ] GitHub migration proposal (#75) * CB-11982 - proposal for new cordova config command * cordova-config-command.md removed and pushed up on CB-11982 branch instead * github_migration_proposal : proposal to migrate jira issues to github > create new cordova config command > - > > Key: CB-11982 > URL: https://issues.apache.org/jira/browse/CB-11982 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Steve Gill >Assignee: Audrey So >Priority: Major > Labels: cordova-7.0.0 > Fix For: cordova@7.0.0 > > > Model it after npm config command. https://docs.npmjs.com/cli/config > This issue could use a cordova-discuss PR before implementing. > Might want to migrate telemetry and update-notifier config into this. > Currently, telemetry and update-notifier use > https://github.com/yeoman/configstore under the hood. Stores configs in > ~/.config/configstore/ -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12064) navigator.getUserMedia as used in the camera plugin for the browser target has been deprecated and should be changed to match the new spec which is navigator.mediaDevices
[ https://issues.apache.org/jira/browse/CB-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610736#comment-17610736 ] ASF subversion and git services commented on CB-12064: -- Commit 250dd45957e8a2162e3c3dab81ef7cdb9bc337ec in cordova-plugin-camera's branch refs/heads/CB-12064 from Julio César [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=250dd45 ] fix(browser): use navigator.mediaDevices.getUserMedia CB-12064 > navigator.getUserMedia as used in the camera plugin for the browser target > has been deprecated and should be changed to match the new spec which is > navigator.mediaDevices.getUserMedia > --- > > Key: CB-12064 > URL: https://issues.apache.org/jira/browse/CB-12064 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: 3.5.0 > Environment: Chrome, Firefox and Opera >Reporter: Justin Willis >Assignee: Jesse MacFadyen >Priority: Major > > The navigator.getUserMedia api has been deprecated and updated to be > navigator.mediaDevices.getUserMedia. After looking at the camera plugin today > and how it works with the browser target it seems that the camera plugin > still uses the deprecated version of the api. While the old api is currently > still supported along with the new version of the api in Chrome and Firefox, > it is due to be removed asap, which would in turn break the current version > of the camera plugin. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11641) MediaError object missing message member
[
https://issues.apache.org/jira/browse/CB-11641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599497#comment-17599497
]
ASF subversion and git services commented on CB-11641:
--
Commit 081fa5ed2fe9492b1b8a02272796901c64658894 in cordova-plugin-media's
branch refs/heads/master from エリス
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-media.git;h=081fa5e ]
feat(android): add 'message' field to media error CB-11641 (#357)
* CB-11641 android: add 'message' field to media error
It was not possible before to get error message.This updated Android
implementation to return error code with message similar to iOS.
* style: apply lint corrections
* refactor(android): private API sendStatusChange
Co-authored-by: Nikita Matrosov
> MediaError object missing message member
>
>
> Key: CB-11641
> URL: https://issues.apache.org/jira/browse/CB-11641
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media
>Affects Versions: 2.3.0
> Environment: Building on OSX 10.11.5, Android 5.1.1 and 5.2.0
>Reporter: Madison Dickson
>Assignee: Nikita Matrosov
>Priority: Minor
> Labels: pull-request-available
>
> on iOS, the MediaError object contains both the error code and the message.
> On Android, the object is missing the message.
> {code}
> new Media(this.src,
> // success callback
> successCallback,
> // error callback
> function(err) {
> console.log("recordAudio():Audio Error Code: "+ err.code + ", "+
> err.message, err);
> if(app.file){
> app.file.release();
> app.file = null;
> // app.stop();
> }
> }
> {code}
> outputs: {{recordAudio():Audio Error Code: 0, undefined}}
> I have seen both error code 0 and error code 1, the former of which is not
> documented.
> https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-media/index.html#mediaerror
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13243) Don't reset default audio session category when release
[ https://issues.apache.org/jira/browse/CB-13243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598299#comment-17598299 ] ASF subversion and git services commented on CB-13243: -- Commit 422c9a949cee54185a1d1c603edf06d165ec456c in cordova-plugin-media's branch refs/heads/master from エリス [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-media.git;h=422c9a9 ] fix(ios): Reset default audio session category when release (CB-13243) (#354) Co-authored-by: yunseok > Don't reset default audio session category when release > --- > > Key: CB-13243 > URL: https://issues.apache.org/jira/browse/CB-13243 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Reporter: Yunseok Han >Priority: Major > Labels: ios > > When recording is released, don't set category. > all audio output in app is not working. > So have to set basic category of avsession to > AVAudioSessionCategorySoloAmbient -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14203) Cordova-Android platform patch release July 2018
[
https://issues.apache.org/jira/browse/CB-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17388112#comment-17388112
]
ASF subversion and git services commented on CB-14203:
--
Commit 38ca895459bcd2ae1cbeccab1b900ffaf649acb6 in cordova-android's branch
refs/heads/10.0.x from エリス
[ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=38ca895 ]
fix: add missing release notes (#1291)
* CB-14203 Update RELEASENOTES & version for 7.1.1
* Update RELEASENOTES & version for v7.1.2
* Update VERSION & RELEASENOTES for 7.1.3
* Update VERSION & RELEASENOTES for 7.1.4
Co-authored-by: Christopher J. Brody
Co-authored-by: Darryl Pogue
> Cordova-Android platform patch release July 2018
>
>
> Key: CB-14203
> URL: https://issues.apache.org/jira/browse/CB-14203
> Project: Apache Cordova
> Issue Type: Task
> Components: cordova-android
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> Patch release of {{cordova-android}} package with CB-14145 (npm audit issues)
> resolved. (Other issues will be raised for July 2018 patch releases on the
> other platforms.)
> Following steps at
> [https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md]
> (with some modifications)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14203) Cordova-Android platform patch release July 2018
[
https://issues.apache.org/jira/browse/CB-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386714#comment-17386714
]
ASF subversion and git services commented on CB-14203:
--
Commit 38ca895459bcd2ae1cbeccab1b900ffaf649acb6 in cordova-android's branch
refs/heads/master from エリス
[ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=38ca895 ]
fix: add missing release notes (#1291)
* CB-14203 Update RELEASENOTES & version for 7.1.1
* Update RELEASENOTES & version for v7.1.2
* Update VERSION & RELEASENOTES for 7.1.3
* Update VERSION & RELEASENOTES for 7.1.4
Co-authored-by: Christopher J. Brody
Co-authored-by: Darryl Pogue
> Cordova-Android platform patch release July 2018
>
>
> Key: CB-14203
> URL: https://issues.apache.org/jira/browse/CB-14203
> Project: Apache Cordova
> Issue Type: Task
> Components: cordova-android
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> Patch release of {{cordova-android}} package with CB-14145 (npm audit issues)
> resolved. (Other issues will be raised for July 2018 patch releases on the
> other platforms.)
> Following steps at
> [https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md]
> (with some modifications)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12224) Plugins Release Dec 7th, 2016
[ https://issues.apache.org/jira/browse/CB-12224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371281#comment-17371281 ] ASF subversion and git services commented on CB-12224: -- Commit 5d648753281f2de6703fbf44014e140fbb99bf72 in cordova-plugin-whitelist's branch refs/heads/master from Shazron Abdullah [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-whitelist.git;h=5d64875 ] CB-12224 Incremented plugin version. > Plugins Release Dec 7th, 2016 > - > > Key: CB-12224 > URL: https://issues.apache.org/jira/browse/CB-12224 > Project: Apache Cordova > Issue Type: Task > Components: AllPlugins >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12519) Plugins Release, Tue Feb 28 2017
[ https://issues.apache.org/jira/browse/CB-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371282#comment-17371282 ] ASF subversion and git services commented on CB-12519: -- Commit 03bb9cbd44f612db6a2cd7b3fc115c1a7b03 in cordova-plugin-whitelist's branch refs/heads/master from Steve Gill [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-whitelist.git;h=03bb9cb ] CB-12519 Updated version and RELEASENOTES.md for release 1.3.2 > Plugins Release, Tue Feb 28 2017 > > > Key: CB-12519 > URL: https://issues.apache.org/jira/browse/CB-12519 > Project: Apache Cordova > Issue Type: Task > Components: AllPlugins >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12236) Fix release notes on plugins released Dec 07 2016
[ https://issues.apache.org/jira/browse/CB-12236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371280#comment-17371280 ] ASF subversion and git services commented on CB-12236: -- Commit 7f2678fd84ab6063c9868a8210a6d6bd2e96fd63 in cordova-plugin-whitelist's branch refs/heads/master from Shazron Abdullah [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-whitelist.git;h=7f2678f ] CB-12236 - Fixed RELEASENOTES for cordova-plugin-whitelist > Fix release notes on plugins released Dec 07 2016 > - > > Key: CB-12236 > URL: https://issues.apache.org/jira/browse/CB-12236 > Project: Apache Cordova > Issue Type: Bug >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > > My bad - Just noticed (after release) that the release notes are not correct > in the README.md. Generate the correct ones for the blog post and amend the > release notes in the actual plugins. > Checklist: https://github.com/cordova/cordova-status/issues/3 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5989) Properties defined in plugin.xml are not created in *-Info.plist
[ https://issues.apache.org/jira/browse/CB-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149473#comment-17149473 ] ASF subversion and git services commented on CB-5989: - Commit a18bf0e2774b40dda11e3475b11a2dc3639bdb80 in cordova-common's branch refs/heads/4.0.x from Dave Alden [ https://gitbox.apache.org/repos/asf?p=cordova-common.git;h=a18bf0e ] (ios) fix: resolve correct path to app info plist when multiple plist files are present (#144). When multiple plist files exists in a cordova-ios project (e.g. due to a plugin containing ``), ConfigFile was updated under CB-5989 to select the app plist as the target for changes destined for *-Info.plist. However, the change made under CB-5989 incorrectly constructed the path to the app plist by omitting the project name subdirectory from the path, causing the fix to fail to work. This commit fixes this by correcting the constructed path to the app plist. > Properties defined in plugin.xml are not created in *-Info.plist > > > Key: CB-5989 > URL: https://issues.apache.org/jira/browse/CB-5989 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-plugman >Affects Versions: 3.3.0 > Environment: Mavericks 10.9.1; Xcode 5.0.2; Cordova 3.3.1-0.3.0 >Reporter: Kelvin Dart >Priority: Major > Labels: CLI, Plugin > Attachments: after_platform_add_plist_fix.sh, > before_platform_add_plist_fix.sh > > > I have the following tag in my tag, within plugin.xml: > parent="UISupportedExternalAccessoryProtocols"> > > jp.star-m.starpro > > > However, whenever I attempt to add in my plugin, this setting is not applied > to my project's plist file and I have to do it manually. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5989) Properties defined in plugin.xml are not created in *-Info.plist
[ https://issues.apache.org/jira/browse/CB-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149472#comment-17149472 ] ASF subversion and git services commented on CB-5989: - Commit a18bf0e2774b40dda11e3475b11a2dc3639bdb80 in cordova-common's branch refs/heads/4.0.x from Dave Alden [ https://gitbox.apache.org/repos/asf?p=cordova-common.git;h=a18bf0e ] (ios) fix: resolve correct path to app info plist when multiple plist files are present (#144). When multiple plist files exists in a cordova-ios project (e.g. due to a plugin containing ``), ConfigFile was updated under CB-5989 to select the app plist as the target for changes destined for *-Info.plist. However, the change made under CB-5989 incorrectly constructed the path to the app plist by omitting the project name subdirectory from the path, causing the fix to fail to work. This commit fixes this by correcting the constructed path to the app plist. > Properties defined in plugin.xml are not created in *-Info.plist > > > Key: CB-5989 > URL: https://issues.apache.org/jira/browse/CB-5989 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-plugman >Affects Versions: 3.3.0 > Environment: Mavericks 10.9.1; Xcode 5.0.2; Cordova 3.3.1-0.3.0 >Reporter: Kelvin Dart >Priority: Major > Labels: CLI, Plugin > Attachments: after_platform_add_plist_fix.sh, > before_platform_add_plist_fix.sh > > > I have the following tag in my tag, within plugin.xml: > parent="UISupportedExternalAccessoryProtocols"> > > jp.star-m.starpro > > > However, whenever I attempt to add in my plugin, this setting is not applied > to my project's plist file and I have to do it manually. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5989) Properties defined in plugin.xml are not created in *-Info.plist
[ https://issues.apache.org/jira/browse/CB-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134245#comment-17134245 ] ASF subversion and git services commented on CB-5989: - Commit a18bf0e2774b40dda11e3475b11a2dc3639bdb80 in cordova-common's branch refs/heads/master from Dave Alden [ https://gitbox.apache.org/repos/asf?p=cordova-common.git;h=a18bf0e ] (ios) fix: resolve correct path to app info plist when multiple plist files are present (#144). When multiple plist files exists in a cordova-ios project (e.g. due to a plugin containing ``), ConfigFile was updated under CB-5989 to select the app plist as the target for changes destined for *-Info.plist. However, the change made under CB-5989 incorrectly constructed the path to the app plist by omitting the project name subdirectory from the path, causing the fix to fail to work. This commit fixes this by correcting the constructed path to the app plist. > Properties defined in plugin.xml are not created in *-Info.plist > > > Key: CB-5989 > URL: https://issues.apache.org/jira/browse/CB-5989 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-plugman >Affects Versions: 3.3.0 > Environment: Mavericks 10.9.1; Xcode 5.0.2; Cordova 3.3.1-0.3.0 >Reporter: Kelvin Dart >Priority: Major > Labels: CLI, Plugin > Attachments: after_platform_add_plist_fix.sh, > before_platform_add_plist_fix.sh > > > I have the following tag in my tag, within plugin.xml: > parent="UISupportedExternalAccessoryProtocols"> > > jp.star-m.starpro > > > However, whenever I attempt to add in my plugin, this setting is not applied > to my project's plist file and I have to do it manually. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5989) Properties defined in plugin.xml are not created in *-Info.plist
[ https://issues.apache.org/jira/browse/CB-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134244#comment-17134244 ] ASF subversion and git services commented on CB-5989: - Commit a18bf0e2774b40dda11e3475b11a2dc3639bdb80 in cordova-common's branch refs/heads/master from Dave Alden [ https://gitbox.apache.org/repos/asf?p=cordova-common.git;h=a18bf0e ] (ios) fix: resolve correct path to app info plist when multiple plist files are present (#144). When multiple plist files exists in a cordova-ios project (e.g. due to a plugin containing ``), ConfigFile was updated under CB-5989 to select the app plist as the target for changes destined for *-Info.plist. However, the change made under CB-5989 incorrectly constructed the path to the app plist by omitting the project name subdirectory from the path, causing the fix to fail to work. This commit fixes this by correcting the constructed path to the app plist. > Properties defined in plugin.xml are not created in *-Info.plist > > > Key: CB-5989 > URL: https://issues.apache.org/jira/browse/CB-5989 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-cli, cordova-plugman >Affects Versions: 3.3.0 > Environment: Mavericks 10.9.1; Xcode 5.0.2; Cordova 3.3.1-0.3.0 >Reporter: Kelvin Dart >Priority: Major > Labels: CLI, Plugin > Attachments: after_platform_add_plist_fix.sh, > before_platform_add_plist_fix.sh > > > I have the following tag in my tag, within plugin.xml: > parent="UISupportedExternalAccessoryProtocols"> > > jp.star-m.starpro > > > However, whenever I attempt to add in my plugin, this setting is not applied > to my project's plist file and I have to do it manually. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13143) Integrate cordova-plugin-splashscreen
[ https://issues.apache.org/jira/browse/CB-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112853#comment-17112853 ] ASF subversion and git services commented on CB-13143: -- Commit 2d8e0a9e5d281a685947f9c92b610885c8475183 in cordova-ios's branch refs/heads/master from Darryl Pogue [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=2d8e0a9 ] breaking feature: Integrate & replace SplashScreens w/ Launch Storyboard (CB-13143) (#790) * breaking (splashscreen): drop launch image & default storyboard * refactor (prepare): delete legacy splash screen launch images * CB-13143: Added launch view to CDVViewController * CB-13143: Integrate the SplashScreen plugin * refactor (CDVLaunchScreen): update xml structure by Xcode Co-authored-by: Erisu Co-authored-by: Jeff Chang > Integrate cordova-plugin-splashscreen > - > > Key: CB-13143 > URL: https://issues.apache.org/jira/browse/CB-13143 > Project: Apache Cordova > Issue Type: Task > Components: cordova-plugin-splashscreen >Reporter: Filip Maj >Priority: Major > Labels: plugins-next > Time Spent: 10m > Remaining Estimate: 0h > > Over and above the actual migration of the code into platform repos, we need > to do the following: > 1. Update README.md to reflect maintenance status: > – Direct users to file bugs/prs to the platforms that integrate the plugin > 2. Close out any PRs and issues > 3. Deprecate the component from JIRA > 4. Highlight in release notes and announcement blog posts about upgrade path: > – potential conflicts in old cordova projects that explicitly added the > integrated plugin > – how to turn the integrated plugin off via feature tag tweaking in config.xml > 5. cordova-docs need updating: > * should show how to turn the integrated plugin off via feature tag tweaking > in config.xml > * https://cordova.apache.org/docs/en/latest/guide/support/index.html needs to > remove splashscreen > * https://cordova.apache.org/docs/en/latest/config_ref/images.html mentions > that splashscreen documentation exists under the plugin ref docs. where would > we put this now? a new section under each platform guide? > * https://cordova.apache.org/docs/en/latest/plugin_ref/plugman.html > 6. bump version, do a final release, and npm deprecate the plugin > We might want to split this all up into subtasks. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13143) Integrate cordova-plugin-splashscreen
[ https://issues.apache.org/jira/browse/CB-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112854#comment-17112854 ] ASF subversion and git services commented on CB-13143: -- Commit 2d8e0a9e5d281a685947f9c92b610885c8475183 in cordova-ios's branch refs/heads/master from Darryl Pogue [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=2d8e0a9 ] breaking feature: Integrate & replace SplashScreens w/ Launch Storyboard (CB-13143) (#790) * breaking (splashscreen): drop launch image & default storyboard * refactor (prepare): delete legacy splash screen launch images * CB-13143: Added launch view to CDVViewController * CB-13143: Integrate the SplashScreen plugin * refactor (CDVLaunchScreen): update xml structure by Xcode Co-authored-by: Erisu Co-authored-by: Jeff Chang > Integrate cordova-plugin-splashscreen > - > > Key: CB-13143 > URL: https://issues.apache.org/jira/browse/CB-13143 > Project: Apache Cordova > Issue Type: Task > Components: cordova-plugin-splashscreen >Reporter: Filip Maj >Priority: Major > Labels: plugins-next > Time Spent: 10m > Remaining Estimate: 0h > > Over and above the actual migration of the code into platform repos, we need > to do the following: > 1. Update README.md to reflect maintenance status: > – Direct users to file bugs/prs to the platforms that integrate the plugin > 2. Close out any PRs and issues > 3. Deprecate the component from JIRA > 4. Highlight in release notes and announcement blog posts about upgrade path: > – potential conflicts in old cordova projects that explicitly added the > integrated plugin > – how to turn the integrated plugin off via feature tag tweaking in config.xml > 5. cordova-docs need updating: > * should show how to turn the integrated plugin off via feature tag tweaking > in config.xml > * https://cordova.apache.org/docs/en/latest/guide/support/index.html needs to > remove splashscreen > * https://cordova.apache.org/docs/en/latest/config_ref/images.html mentions > that splashscreen documentation exists under the plugin ref docs. where would > we put this now? a new section under each platform guide? > * https://cordova.apache.org/docs/en/latest/plugin_ref/plugman.html > 6. bump version, do a final release, and npm deprecate the plugin > We might want to split this all up into subtasks. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13143) Integrate cordova-plugin-splashscreen
[ https://issues.apache.org/jira/browse/CB-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112852#comment-17112852 ] ASF subversion and git services commented on CB-13143: -- Commit 2d8e0a9e5d281a685947f9c92b610885c8475183 in cordova-ios's branch refs/heads/master from Darryl Pogue [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=2d8e0a9 ] breaking feature: Integrate & replace SplashScreens w/ Launch Storyboard (CB-13143) (#790) * breaking (splashscreen): drop launch image & default storyboard * refactor (prepare): delete legacy splash screen launch images * CB-13143: Added launch view to CDVViewController * CB-13143: Integrate the SplashScreen plugin * refactor (CDVLaunchScreen): update xml structure by Xcode Co-authored-by: Erisu Co-authored-by: Jeff Chang > Integrate cordova-plugin-splashscreen > - > > Key: CB-13143 > URL: https://issues.apache.org/jira/browse/CB-13143 > Project: Apache Cordova > Issue Type: Task > Components: cordova-plugin-splashscreen >Reporter: Filip Maj >Priority: Major > Labels: plugins-next > Time Spent: 10m > Remaining Estimate: 0h > > Over and above the actual migration of the code into platform repos, we need > to do the following: > 1. Update README.md to reflect maintenance status: > – Direct users to file bugs/prs to the platforms that integrate the plugin > 2. Close out any PRs and issues > 3. Deprecate the component from JIRA > 4. Highlight in release notes and announcement blog posts about upgrade path: > – potential conflicts in old cordova projects that explicitly added the > integrated plugin > – how to turn the integrated plugin off via feature tag tweaking in config.xml > 5. cordova-docs need updating: > * should show how to turn the integrated plugin off via feature tag tweaking > in config.xml > * https://cordova.apache.org/docs/en/latest/guide/support/index.html needs to > remove splashscreen > * https://cordova.apache.org/docs/en/latest/config_ref/images.html mentions > that splashscreen documentation exists under the plugin ref docs. where would > we put this now? a new section under each platform guide? > * https://cordova.apache.org/docs/en/latest/plugin_ref/plugman.html > 6. bump version, do a final release, and npm deprecate the plugin > We might want to split this all up into subtasks. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13987) WKWebView doesn't layout properly at launch on iPhone X
[ https://issues.apache.org/jira/browse/CB-13987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068807#comment-17068807 ] ASF subversion and git services commented on CB-13987: -- Commit dc8b2777bcea9fe2dce4fe5bac6cf548d9d43621 in cordova-plugin-wkwebview-engine's branch refs/heads/janpio-add_ci_platform from Darryl Pogue [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-wkwebview-engine.git;h=dc8b277 ] Revert "CB-13987: (ios) Fix WKWebView doesn't layout properly at… (#107) > WKWebView doesn't layout properly at launch on iPhone X > --- > > Key: CB-13987 > URL: https://issues.apache.org/jira/browse/CB-13987 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.5.4 > Environment: Mac > Cordova 8.0.0 > codova-plugin-wkwebview-engine 1.1.4 >Reporter: Kamal Kalra >Assignee: Suraj Pindoria >Priority: Major > Attachments: TestApp2.zip > > > WKWebView doesn't seem to layout properly at launch. There is a black bar at > the bottom of the view. If I rotate the app to landscape mode, the view > automatically resizes correctly and occupies the entire screen. Then when I > rotate back to portrait mode, it works correctly and occupies the entire > screen as expected. But at launch this is not happening. It should occupy > the entire screen at that point without having to rotate back and forth. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-5417) Notification.beep doesn't use background thread - blocks app execution
[
https://issues.apache.org/jira/browse/CB-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16996787#comment-16996787
]
ASF subversion and git services commented on CB-5417:
-
Commit b9a57d2553ae2db2e68ab5e15d7f34d5f1907ac8 in cordova-plugin-dialogs's
branch refs/heads/master from jcesarmobile
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-dialogs.git;h=b9a57d2 ]
CB-5417(ios): use background thread for beep (#133)
> Notification.beep doesn't use background thread - blocks app execution
> --
>
> Key: CB-5417
> URL: https://issues.apache.org/jira/browse/CB-5417
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-dialogs
>Affects Versions: 3.1.0
> Environment: iOS
>Reporter: Michael Schmidt
>Assignee: jcesarmobile
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Notification.beep blocks the UI - comes to relevance when triggering multiple
> beeps
> {quote}
> THREAD WARNING: ['Notification'] took '13.020996' ms. Plugin should use a
> background thread.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14135) cordova-ios Podfile template only escape first occurrence of single quote in the project name
[ https://issues.apache.org/jira/browse/CB-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986071#comment-16986071 ] ASF subversion and git services commented on CB-14135: -- Commit c1a6640758d1e95f7f7e0dbca980df8780a2adf4 in cordova-ios's branch refs/heads/master from jcesarmobile [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=c1a6640 ] CB-14135(ios): escape all single quotes from name in Podfile (#731) > cordova-ios Podfile template only escape first occurrence of single quote in > the project name > - > > Key: CB-14135 > URL: https://issues.apache.org/jira/browse/CB-14135 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS platform >Reporter: Nimrod Goldrat >Assignee: Shazron Abdullah >Priority: Minor > Labels: ios > Fix For: cordova-ios 4.5.0 > > Original Estimate: 1h > Time Spent: 20m > Remaining Estimate: 40m > > The Podfile template escape the first occurrence of single quotes for project > names when generating the Podfile. This will cause a syntax error in the > Podfile since the target and project are single quoted strings. The solution > is to escape the single quotes in the project name before writing them to the > Podfile. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14108) in config.xml increases config_munge count in ios.json and android.json.
[
https://issues.apache.org/jira/browse/CB-14108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911910#comment-16911910
]
ASF subversion and git services commented on CB-14108:
--
Commit d1a10a9774ee8d0f5505c2aa746d4f2733060481 in cordova-common's branch
refs/heads/master from エリス
[ https://gitbox.apache.org/repos/asf?p=cordova-common.git;h=d1a10a9 ]
revert: #24 CB-14108: fix incorrect count in config_munge (#89)
* Revert "CB-14108: fix incorrect count in config_munge in ios.json and
android.json"
This reverts commit ce3801a184d34cc4c3ea08aeecd159227c6ae9e9.
* chore: eslint object-curly-spacing fix
* add CordovaError spec
* chore: fix eslint warnings for CordovaError spec
* fix CordovaError spec test
* chore: added additional AS project path check
> in config.xml increases config_munge count in ios.json and
> android.json.
> --
>
> Key: CB-14108
> URL: https://issues.apache.org/jira/browse/CB-14108
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common, cordova-lib
>Affects Versions: 8.0.0
>Reporter: Ken Naito
>Priority: Major
> Fix For: cordova-common@3.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> On both iOS and Android platforms, using causes duplication in
> the `ios.json` and `android.json` files, which could lead to extremely large
> file sizes (and possibly unexpected behaviour?).
> For a Cordova 7.1/8.0 application, add the following to config.xml:
>
> {code:java}
>
>
>
>
> Please permit Camera!
>
>
> {code}
> Now run `cordova prepare`. The file `platforms/ios/ios.json` now contains the
> below. Note the count is 1.
>
> {code:java}
> "config_munge": {
> "files": {
> "*-Info.plist": {
> "parents": {
> "NSCameraUsageDescription": [
> {
> "xml": "Please permit Camera!",
> "count": 1
> }
> ]
> }
> }
> }
> },
> {code}
> Run `cordova prepare` again. The platforms/ios/ios.json changes, increasing
> the count to 2.
>
> {code:java}
> "config_munge": {
> "files": {
> "*-Info.plist": {
> "parents": {
> "NSCameraUsageDescription": [
> {
> "xml": "Please permit Camera!",
> "count": 2
> }
> ]
> }
> }
> }
> },
> {code}
> Furthermore, if we change the text inside the `` in the `config.xml`:
> {code:java}
>
>
>
>
> This app uses Camera!
>
>
> {code}
> Then after running `cordova prepare`, there is now a second entry in
> `platforms/ios/ios.json`, rather than replacing the existing entry.
>
> {code:java}
> "config_munge": {
> "files": {
> "*-Info.plist": {
> "parents": {
> "NSCameraUsageDescription": [
> {
> "xml": "Please permit Camera!",
> "count": 2
> },
> {
> "xml": "This app uses Camera!",
> "count": 1
> }
> ]
> }
> }
> }
> },
> {code}
> This behaviour is the same for Android, and can be reproduced in the same
> way, by adding something like the below to `config.xml`:
> {code:java}
>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14108) in config.xml increases config_munge count in ios.json and android.json.
[
https://issues.apache.org/jira/browse/CB-14108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911911#comment-16911911
]
ASF subversion and git services commented on CB-14108:
--
Commit d1a10a9774ee8d0f5505c2aa746d4f2733060481 in cordova-common's branch
refs/heads/master from エリス
[ https://gitbox.apache.org/repos/asf?p=cordova-common.git;h=d1a10a9 ]
revert: #24 CB-14108: fix incorrect count in config_munge (#89)
* Revert "CB-14108: fix incorrect count in config_munge in ios.json and
android.json"
This reverts commit ce3801a184d34cc4c3ea08aeecd159227c6ae9e9.
* chore: eslint object-curly-spacing fix
* add CordovaError spec
* chore: fix eslint warnings for CordovaError spec
* fix CordovaError spec test
* chore: added additional AS project path check
> in config.xml increases config_munge count in ios.json and
> android.json.
> --
>
> Key: CB-14108
> URL: https://issues.apache.org/jira/browse/CB-14108
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common, cordova-lib
>Affects Versions: 8.0.0
>Reporter: Ken Naito
>Priority: Major
> Fix For: cordova-common@3.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> On both iOS and Android platforms, using causes duplication in
> the `ios.json` and `android.json` files, which could lead to extremely large
> file sizes (and possibly unexpected behaviour?).
> For a Cordova 7.1/8.0 application, add the following to config.xml:
>
> {code:java}
>
>
>
>
> Please permit Camera!
>
>
> {code}
> Now run `cordova prepare`. The file `platforms/ios/ios.json` now contains the
> below. Note the count is 1.
>
> {code:java}
> "config_munge": {
> "files": {
> "*-Info.plist": {
> "parents": {
> "NSCameraUsageDescription": [
> {
> "xml": "Please permit Camera!",
> "count": 1
> }
> ]
> }
> }
> }
> },
> {code}
> Run `cordova prepare` again. The platforms/ios/ios.json changes, increasing
> the count to 2.
>
> {code:java}
> "config_munge": {
> "files": {
> "*-Info.plist": {
> "parents": {
> "NSCameraUsageDescription": [
> {
> "xml": "Please permit Camera!",
> "count": 2
> }
> ]
> }
> }
> }
> },
> {code}
> Furthermore, if we change the text inside the `` in the `config.xml`:
> {code:java}
>
>
>
>
> This app uses Camera!
>
>
> {code}
> Then after running `cordova prepare`, there is now a second entry in
> `platforms/ios/ios.json`, rather than replacing the existing entry.
>
> {code:java}
> "config_munge": {
> "files": {
> "*-Info.plist": {
> "parents": {
> "NSCameraUsageDescription": [
> {
> "xml": "Please permit Camera!",
> "count": 2
> },
> {
> "xml": "This app uses Camera!",
> "count": 1
> }
> ]
> }
> }
> }
> },
> {code}
> This behaviour is the same for Android, and can be reproduced in the same
> way, by adding something like the below to `config.xml`:
> {code:java}
>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13987) WKWebView doesn't layout properly at launch on iPhone X
[ https://issues.apache.org/jira/browse/CB-13987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887418#comment-16887418 ] ASF subversion and git services commented on CB-13987: -- Commit dc8b2777bcea9fe2dce4fe5bac6cf548d9d43621 in cordova-plugin-wkwebview-engine's branch refs/heads/master from Darryl Pogue [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-wkwebview-engine.git;h=dc8b277 ] Revert "CB-13987: (ios) Fix WKWebView doesn't layout properly at… (#107) > WKWebView doesn't layout properly at launch on iPhone X > --- > > Key: CB-13987 > URL: https://issues.apache.org/jira/browse/CB-13987 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.5.4 > Environment: Mac > Cordova 8.0.0 > codova-plugin-wkwebview-engine 1.1.4 >Reporter: Kamal Kalra >Assignee: Suraj Pindoria >Priority: Major > Attachments: TestApp2.zip > > > WKWebView doesn't seem to layout properly at launch. There is a black bar at > the bottom of the view. If I rotate the app to landscape mode, the view > automatically resizes correctly and occupies the entire screen. Then when I > rotate back to portrait mode, it works correctly and occupies the entire > screen as expected. But at launch this is not happening. It should occupy > the entire screen at that point without having to rotate back and forth. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13987) WKWebView doesn't layout properly at launch on iPhone X
[ https://issues.apache.org/jira/browse/CB-13987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887401#comment-16887401 ] ASF subversion and git services commented on CB-13987: -- Commit 0e8bd8eaa4d168789bbdf9501a6cabfe95af26d9 in cordova-plugin-wkwebview-engine's branch refs/heads/revert-45-CB-13987 from Darryl Pogue [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-wkwebview-engine.git;h=0e8bd8e ] Revert "CB-13987: (ios) Fix WKWebView doesn't layout properly at launch on iP…" > WKWebView doesn't layout properly at launch on iPhone X > --- > > Key: CB-13987 > URL: https://issues.apache.org/jira/browse/CB-13987 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova-ios@4.5.4 > Environment: Mac > Cordova 8.0.0 > codova-plugin-wkwebview-engine 1.1.4 >Reporter: Kamal Kalra >Assignee: Suraj Pindoria >Priority: Major > Attachments: TestApp2.zip > > > WKWebView doesn't seem to layout properly at launch. There is a black bar at > the bottom of the view. If I rotate the app to landscape mode, the view > automatically resizes correctly and occupies the entire screen. Then when I > rotate back to portrait mode, it works correctly and occupies the entire > screen as expected. But at launch this is not happening. It should occupy > the entire screen at that point without having to rotate back and forth. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14106) device.model is different on simulator and on real device
[ https://issues.apache.org/jira/browse/CB-14106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854732#comment-16854732 ] ASF subversion and git services commented on CB-14106: -- Commit d65cdf62e368c8c59258616bd949b8a2d82bcf54 in cordova-plugin-device's branch refs/heads/2.0.x from Daniel Toplak [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-device.git;h=d65cdf6 ] CB-14106 - device.model is different on simulator and on real device (#80) > device.model is different on simulator and on real device > - > > Key: CB-14106 > URL: https://issues.apache.org/jira/browse/CB-14106 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-device >Affects Versions: cordova-ios 4.5.0 >Reporter: Daniel Toplak >Priority: Minor > > When using e.g. an iPhone X, device.model returns: > Simulator: "x86_64" > Real device: "iPhone10,6" -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12035) [cordova-plugin-network-information] connection info is not reliable on Android 6
[
https://issues.apache.org/jira/browse/CB-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811367#comment-16811367
]
ASF subversion and git services commented on CB-12035:
--
Commit db0d4b54bcd9df1bfb4da9fd0ce1aaaf4215 in
cordova-plugin-network-information's branch refs/heads/master from Jesse
MacFadyen
[
https://gitbox.apache.org/repos/asf?p=cordova-plugin-network-information.git;h=db0d4b5
]
Merge pull request #74 from PieterVanPoyer/master
CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info
is not reliable on Android 6
> [cordova-plugin-network-information] connection info is not reliable on
> Android 6
> -
>
> Key: CB-12035
> URL: https://issues.apache.org/jira/browse/CB-12035
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-network-information
>Affects Versions: 1.3.0
> Environment: Samsung Galaxy Edge S6 / Android 6
> useragent: "Mozilla/5.0 (Linux; Android 6.0.1; SM-G925F Build/MMB29K; wv)
> AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/53.0.2785.124
> Mobile Safari/537.36"
> reproduced with:
> cordova-plugin-network-information@1.3.0 (latest)
> cordova-plugin-network-information@1.2.0
>Reporter: jakub-g
>Priority: Major
> Labels: android
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I've noticed that information exposed by the plugin is not reliable. It
> happens often that I'm connected to the internet via WiFi, and the plugin
> says that there's no connection.
> It's not easy to reproduce it on-demand, but I reproduced it many times
> recently. It happens most often when in the morning, I open the Cordova app
> that was running in background throughout the night.
> Then, when I connect to Chrome Dev Tools, I can do a repl session like this:
> {code}
> > navigator.connection.type
> "none"
> > window.fetch('http://www.example.org').then(function(res)
> > {console.log(res.status)})
> Promise {[[PromiseStatus]]: "pending", [[PromiseValue]]: undefined}
> 200
> Fetch complete: GET "http://www.example.org/;.(anonymous function)
> > navigator.connection.type
> "none"
> {code}
> So, the plugin thinks I'm offline, yet any HTTP calls done within the app
> without checking if I'm offline or online, are successful (either from the
> app or devtools).
> When I disable WiFi and reenable it, after a few seconds the plugin updates
> its state and then it tells that connection type is "wifi".
> There are several possibilities here:
> - either system (or device driver) gives us incorrect information, or
> - cordova plugin is caching data and/or not listening properly to all the
> events and/or incorrectly processing it
> and most probably the issue manifests itself when the device is asleep for
> many hours (but I'm not sure about this).
> Note that I also noticed another issue, that sometimes the Chrome network
> stack thinks I'm offline (when I do an HTTP call, it fails immediately and I
> see network errors in devtools console) - and then I restart the Cordova app,
> and everything's fine, all HTTP calls are ok - but this is unrelated to this
> ticket, and perhaps a bug in Chrome.
> This ticket seems to be most likely a bug in the plugin, because as I said
> before, doing HTTP call succeeds despite the plugin telling me that I'm
> offline.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786445#comment-16786445 ] ASF subversion and git services commented on CB-14166: -- Commit d4df8a9390f92fa28ba7307f8ca5bbb2f9041b82 in cordova-lib's branch refs/heads/master from Almir Kadric [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=d4df8a9 ] CB-14166: (cli) Fixed issue when install plugins on windows (#622) The npm package name is already wrapped in quotes to prevent special characters from being execute. However the additional win32 code was further injecting quotes around the version causing npm to return a EINVALIDTAGNAME error. The win32 code is redundant and seems to not be required. > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > Time Spent: 10m > Remaining Estimate: 0h > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13969) Allow close button and navigation buttons positions to be swapped - Cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785290#comment-16785290 ] ASF subversion and git services commented on CB-13969: -- Commit 3c0a42e2aedd19a06115e58ac56c3f3ea4a61dc5 in cordova-plugin-inappbrowser's branch refs/heads/master from steinaragustli [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=3c0a42e ] CB-13969 fix inappbrowser.css to be unmodified > Allow close button and navigation buttons positions to be swapped - > Cordova/inappbrowser > > > Key: CB-13969 > URL: https://issues.apache.org/jira/browse/CB-13969 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS and Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: inappbrowser > Attachments: IMG_0003.jpg, IMG_0004.PNG, > Screenshot_20180313-105154.png, Screenshot_20180313-110504.png > > Original Estimate: 0h > Remaining Estimate: 0h > > Allow the user to swap positions for the close button and navigation buttons. > I added a new property 'lefttoright' which does this. > Screenshots: > iOS(the default for the close button is being on the left): > 'lefttoright' is set: > !IMG_0004.PNG! > default(not set): > !IMG_0003.jpg! > > Android(default is for close button being on the right): > 'lefttoright' is set: > !Screenshot_20180313-110504.png! > default(not set): > !Screenshot_20180313-105154.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13969) Allow close button and navigation buttons positions to be swapped - Cordova/inappbrowser
[ https://issues.apache.org/jira/browse/CB-13969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785288#comment-16785288 ] ASF subversion and git services commented on CB-13969: -- Commit c7931faa7e7a3f4dbe8def504609f5421b5130ff in cordova-plugin-inappbrowser's branch refs/heads/master from Steinar Ágúst [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=c7931fa ] CB-13969 adding newline at end of inappbrowser.cs > Allow close button and navigation buttons positions to be swapped - > Cordova/inappbrowser > > > Key: CB-13969 > URL: https://issues.apache.org/jira/browse/CB-13969 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: iOS and Android >Reporter: Steinar Ágúst Steinarsson >Priority: Minor > Labels: inappbrowser > Attachments: IMG_0003.jpg, IMG_0004.PNG, > Screenshot_20180313-105154.png, Screenshot_20180313-110504.png > > Original Estimate: 0h > Remaining Estimate: 0h > > Allow the user to swap positions for the close button and navigation buttons. > I added a new property 'lefttoright' which does this. > Screenshots: > iOS(the default for the close button is being on the left): > 'lefttoright' is set: > !IMG_0004.PNG! > default(not set): > !IMG_0003.jpg! > > Android(default is for close button being on the right): > 'lefttoright' is set: > !Screenshot_20180313-110504.png! > default(not set): > !Screenshot_20180313-105154.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14217) cordova-ios platform patch release July 2018
[ https://issues.apache.org/jira/browse/CB-14217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762331#comment-16762331 ] ASF subversion and git services commented on CB-14217: -- Commit c8ed5a5aaba7eae828fef1e30bd5cc1a6bfaaceb in cordova-ios's branch refs/heads/master from Christopher J. Brody [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=c8ed5a5 ] CB-14217 Update RELEASENOTES & version for 4.5.5 > cordova-ios platform patch release July 2018 > > > Key: CB-14217 > URL: https://issues.apache.org/jira/browse/CB-14217 > Project: Apache Cordova > Issue Type: Task > Components: cordova-ios >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > Patch release of cordova-ios package with CB-14145 (npm audit issues) > resolved. > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md > (with some modifications) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12940) Use deployment-target for platform version in Podfile
[ https://issues.apache.org/jira/browse/CB-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737887#comment-16737887 ] ASF subversion and git services commented on CB-12940: -- Commit 92b639fd23d044b3dd9c85bed238fc98e2e47be3 in cordova-ios's branch refs/heads/4.5.x from Jonathan Vukovich-Tribouharet [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=92b639f ] CB-12940: [IOS] Use deployment-target from config.xml for platform version in Podfile (#469) > Use deployment-target for platform version in Podfile > - > > Key: CB-12940 > URL: https://issues.apache.org/jira/browse/CB-12940 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Affects Versions: cordova-ios@4.4.0 >Reporter: Todd Miller >Assignee: Shazron Abdullah >Priority: Major > Labels: backlog > Fix For: cordova-ios@4.5.5 > > > The current Podfile.js script is hardcoded to set the platform ios version to > 8.0. However, there are some pods that require 9.0 or they will fail to > install. The deployment-target preference should be honored and used when > generating the Podfile. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13927) Modified xcodeProjDir to filter out files/folders that contain "._"
[ https://issues.apache.org/jira/browse/CB-13927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737865#comment-16737865 ] ASF subversion and git services commented on CB-13927: -- Commit 1cf92246d5463f519bab76e573078a76d58f9c68 in cordova-ios's branch refs/heads/master from Derek [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=1cf9224 ] CB-13927 - Modified xcodeProjDir to filter out files/folders that contain "._" (#355) * Modified xcodeProjDir to filter out files/folders that contain "._" I ran into an issue trying to add an ios plugin using a virtual machine. The code would return an array for the xcodeProjDir and then of course use the wrong one. It would use the one starting with "._ProjectName" which I believe is an MacOS hidden folder. I attempted to install the plugin on OsX but because it's a virtual machine it still had those hidden folders. I've made it so that it will filter those out while looking for the proper xCode project folder. > Modified xcodeProjDir to filter out files/folders that contain "._" > --- > > Key: CB-13927 > URL: https://issues.apache.org/jira/browse/CB-13927 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > I ran into an issue trying to add an ios plugin using a virtual machine. The > code would return an array for the xcodeProjDir and then of course use the > wrong one. It would use the one starting with "._ProjectName" which I believe > is an MacOS hidden folder. I attempted to install the plugin on OsX but > because it's a virtual machine it still had those hidden folders. I've made > it so that it will filter those out while looking for the proper xCode > project folder. > h3. *Platforms affected* > Windows (host) / OSx (guest) virtual machines > h3. *What does this PR do?* > Fixes a folder issue. Before it would try to use an incorrect folder for the > xCode project. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14045) iOS 11.3 - app freeze/sleep
[ https://issues.apache.org/jira/browse/CB-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725658#comment-16725658 ] ASF subversion and git services commented on CB-14045: -- Commit cf4fb989f4d3b6fa50c13fdc0fe2ca5ee86c6e63 in cordova-ios's branch refs/heads/4.5.x from Chris Brody [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=cf4fb98 ] Revert "CB-14045 - reinit url after app freezes on 4.5.x" (#484) As discussed in PR #418, we decided the change was too drastic for a patch release. > iOS 11.3 - app freeze/sleep > --- > > Key: CB-14045 > URL: https://issues.apache.org/jira/browse/CB-14045 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova@7.1.0, cordova-ios@4.5.4 >Reporter: Robert >Priority: Blocker > Labels: ios, ios11, lock, performance, sleep > Time Spent: 0.5h > Remaining Estimate: 0h > > Users with iOS 11.3 can’t use the app when device is locked for more than 10 > minutes. > Event onResume not firing. > Steps to Reproduce: > Install Fitatu app. > Open app on any view. > Lock the device for more than 10 minutes. > After 10 minutes, unlock device. > Expected Results: > App wakes up and the UI is responding (e.g. user is able to click buttons) > Actual Results: > App wakes up and the UI is blocked (user is not able to click buttons) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14045) iOS 11.3 - app freeze/sleep
[ https://issues.apache.org/jira/browse/CB-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725113#comment-16725113 ] ASF subversion and git services commented on CB-14045: -- Commit 2174c987b1a229a36c51c4117713f4f22344a1d8 in cordova-ios's branch refs/heads/revert-418-cb-14045-on-4.5.x from Chris Brody [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=2174c98 ] Revert "CB-14045 - reinit url after app freezes on 4.5.x" > iOS 11.3 - app freeze/sleep > --- > > Key: CB-14045 > URL: https://issues.apache.org/jira/browse/CB-14045 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova@7.1.0, cordova-ios@4.5.4 >Reporter: Robert >Priority: Blocker > Labels: ios, ios11, lock, performance, sleep > Time Spent: 10m > Remaining Estimate: 0h > > Users with iOS 11.3 can’t use the app when device is locked for more than 10 > minutes. > Event onResume not firing. > Steps to Reproduce: > Install Fitatu app. > Open app on any view. > Lock the device for more than 10 minutes. > After 10 minutes, unlock device. > Expected Results: > App wakes up and the UI is responding (e.g. user is able to click buttons) > Actual Results: > App wakes up and the UI is blocked (user is not able to click buttons) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14045) iOS 11.3 - app freeze/sleep
[ https://issues.apache.org/jira/browse/CB-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724938#comment-16724938 ] ASF subversion and git services commented on CB-14045: -- Commit 31f96021883e07d28c88e2d79d0333b2e92e0e1e in cordova-ios's branch refs/heads/4.5.x from Chris Brody [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=31f9602 ] Merge pull request #418 from brodybits/cb-14045-on-4.5.x CB-14045 - reinit url after app freezes on 4.5.x > iOS 11.3 - app freeze/sleep > --- > > Key: CB-14045 > URL: https://issues.apache.org/jira/browse/CB-14045 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova@7.1.0, cordova-ios@4.5.4 >Reporter: Robert >Priority: Blocker > Labels: ios, ios11, lock, performance, sleep > Time Spent: 10m > Remaining Estimate: 0h > > Users with iOS 11.3 can’t use the app when device is locked for more than 10 > minutes. > Event onResume not firing. > Steps to Reproduce: > Install Fitatu app. > Open app on any view. > Lock the device for more than 10 minutes. > After 10 minutes, unlock device. > Expected Results: > App wakes up and the UI is responding (e.g. user is able to click buttons) > Actual Results: > App wakes up and the UI is blocked (user is not able to click buttons) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14045) iOS 11.3 - app freeze/sleep
[ https://issues.apache.org/jira/browse/CB-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724937#comment-16724937 ] ASF subversion and git services commented on CB-14045: -- Commit bab1654b767c94589e53a1de5abb486da3c73186 in cordova-ios's branch refs/heads/4.5.x from Sarunas Valaskevicius [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=bab1654 ] CB-14045 - Reinit url after app freezes (#363) * test reinit url * refactor: split function + check if appUrl is not empty * Added tests. > iOS 11.3 - app freeze/sleep > --- > > Key: CB-14045 > URL: https://issues.apache.org/jira/browse/CB-14045 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Affects Versions: cordova@7.1.0, cordova-ios@4.5.4 >Reporter: Robert >Priority: Blocker > Labels: ios, ios11, lock, performance, sleep > Time Spent: 10m > Remaining Estimate: 0h > > Users with iOS 11.3 can’t use the app when device is locked for more than 10 > minutes. > Event onResume not firing. > Steps to Reproduce: > Install Fitatu app. > Open app on any view. > Lock the device for more than 10 minutes. > After 10 minutes, unlock device. > Expected Results: > App wakes up and the UI is responding (e.g. user is able to click buttons) > Actual Results: > App wakes up and the UI is blocked (user is not able to click buttons) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14198) Error when running simulate with --target parameter on non-US windows 10
[
https://issues.apache.org/jira/browse/CB-14198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724862#comment-16724862
]
ASF subversion and git services commented on CB-14198:
--
Commit 7a9c60ff8531c6b3b553577e844020305e3ebdb0 in cordova-serve's branch
refs/heads/master from Yuri Skorokhodov
[ https://gitbox.apache.org/repos/asf?p=cordova-serve.git;h=7a9c60f ]
CB-14198: (all) Fix bug when running simulate --target= under non-US Windows 10
(#14)
* CB-14198: (all) Fix bug when running simulate --target= under non-US Windows
10
- change regex to parse stdout from reg.exe for browser recognition to be
language independent
- Add tests for regItemPattern check, enhanced regexp pattern to avoid
regression in the future
- Add "var" keyword to the "result" variable declaration
- Add test for non-latin registry key (Russian)
> Error when running simulate with --target parameter on non-US windows 10
>
>
> Key: CB-14198
> URL: https://issues.apache.org/jira/browse/CB-14198
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-serve
>Affects Versions: cordova-serve@2.0.1
> Environment: * Windows 10 German Version 1703
> * cordova@8.0.0
> * cordova-simulate@0.4.0
> * cordova-serve@2.0.1
>Reporter: Peter Kläs
>Priority: Major
> Labels: windows
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When running cordova simulate with a specific browser, e.g.
> {code:java}
> simulate android --target=chrome
> {code}
> the simulation does not start but instead throws an error:
> {code:java}
> C:\Users\pk\AppData\Roaming\npm\node_modules\cordova-simulate\node_modules\cordova-serve\src\browser.js:224
> if (fs.existsSync(trimRegPath(result[2]))) {
> ^
> TypeError: Cannot read property '2' of null
> at
> C:\Users\pk\AppData\Roaming\npm\node_modules\cordova-simulate\node_modules\cordova-serve\src\browser.js:224:57
> at ChildProcess.exithandler (child_process.js:267:7)
> at emitTwo (events.js:126:13)
> at ChildProcess.emit (events.js:214:7)
> at maybeClose (internal/child_process.js:925:16)
> at Socket.stream.socket.on (internal/child_process.js:346:11)
> at emitOne (events.js:116:13)
> at Socket.emit (events.js:211:7)
> at Pipe._handle.close [as _onclose] (net.js:557:12)
> {code}
> Reason is a language-dependent result from reg.exe when querying the
> path/to/browser in the regex line 201 in browser.js.The output from reg.exe
> for chrome (parameter stdout) is in my configuration:
> {code:java}
> HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App
> Paths\chrome.EXE
> (Standard) REG_SZ C:\Program Files
> (x86)\Google\Chrome\Application\chrome.exe
> {code}
> But the code expects (Note (Standard) vs. (Default)) :
> {code:java}
> HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App
> Paths\chrome.EXE
> (Default) REG_SZ C:\Program Files
> (x86)\Google\Chrome\Application\chrome.exe
> {code}
> To fix, i would suggest changing the regex in
> [https://github.com/apache/cordova-serve/blob/1667227ce3706cc0a27c065a300bce083c3799ee/src/browser.js#L201]
> from
> {code:javascript}
> var regItemPattern = /\s*\(Default\)\s+(REG_SZ)\s+([^\s].*)\s*/;
> {code}
> to
> {code:javascript}
> var regItemPattern = /\s*\(.*\)\s+(REG_SZ)\s+([^\s].*)\s*/;
> {code}
> to match most translations.
> Regards
> Peter
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14198) Error when running simulate with --target parameter on non-US windows 10
[
https://issues.apache.org/jira/browse/CB-14198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724861#comment-16724861
]
ASF subversion and git services commented on CB-14198:
--
Commit 7a9c60ff8531c6b3b553577e844020305e3ebdb0 in cordova-serve's branch
refs/heads/master from Yuri Skorokhodov
[ https://gitbox.apache.org/repos/asf?p=cordova-serve.git;h=7a9c60f ]
CB-14198: (all) Fix bug when running simulate --target= under non-US Windows 10
(#14)
* CB-14198: (all) Fix bug when running simulate --target= under non-US Windows
10
- change regex to parse stdout from reg.exe for browser recognition to be
language independent
- Add tests for regItemPattern check, enhanced regexp pattern to avoid
regression in the future
- Add "var" keyword to the "result" variable declaration
- Add test for non-latin registry key (Russian)
> Error when running simulate with --target parameter on non-US windows 10
>
>
> Key: CB-14198
> URL: https://issues.apache.org/jira/browse/CB-14198
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-serve
>Affects Versions: cordova-serve@2.0.1
> Environment: * Windows 10 German Version 1703
> * cordova@8.0.0
> * cordova-simulate@0.4.0
> * cordova-serve@2.0.1
>Reporter: Peter Kläs
>Priority: Major
> Labels: windows
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When running cordova simulate with a specific browser, e.g.
> {code:java}
> simulate android --target=chrome
> {code}
> the simulation does not start but instead throws an error:
> {code:java}
> C:\Users\pk\AppData\Roaming\npm\node_modules\cordova-simulate\node_modules\cordova-serve\src\browser.js:224
> if (fs.existsSync(trimRegPath(result[2]))) {
> ^
> TypeError: Cannot read property '2' of null
> at
> C:\Users\pk\AppData\Roaming\npm\node_modules\cordova-simulate\node_modules\cordova-serve\src\browser.js:224:57
> at ChildProcess.exithandler (child_process.js:267:7)
> at emitTwo (events.js:126:13)
> at ChildProcess.emit (events.js:214:7)
> at maybeClose (internal/child_process.js:925:16)
> at Socket.stream.socket.on (internal/child_process.js:346:11)
> at emitOne (events.js:116:13)
> at Socket.emit (events.js:211:7)
> at Pipe._handle.close [as _onclose] (net.js:557:12)
> {code}
> Reason is a language-dependent result from reg.exe when querying the
> path/to/browser in the regex line 201 in browser.js.The output from reg.exe
> for chrome (parameter stdout) is in my configuration:
> {code:java}
> HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App
> Paths\chrome.EXE
> (Standard) REG_SZ C:\Program Files
> (x86)\Google\Chrome\Application\chrome.exe
> {code}
> But the code expects (Note (Standard) vs. (Default)) :
> {code:java}
> HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App
> Paths\chrome.EXE
> (Default) REG_SZ C:\Program Files
> (x86)\Google\Chrome\Application\chrome.exe
> {code}
> To fix, i would suggest changing the regex in
> [https://github.com/apache/cordova-serve/blob/1667227ce3706cc0a27c065a300bce083c3799ee/src/browser.js#L201]
> from
> {code:javascript}
> var regItemPattern = /\s*\(Default\)\s+(REG_SZ)\s+([^\s].*)\s*/;
> {code}
> to
> {code:javascript}
> var regItemPattern = /\s*\(.*\)\s+(REG_SZ)\s+([^\s].*)\s*/;
> {code}
> to match most translations.
> Regards
> Peter
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13813) Remove old iOS code from cordova-plugin-camera
[ https://issues.apache.org/jira/browse/CB-13813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708571#comment-16708571 ] ASF subversion and git services commented on CB-13813: -- Commit ce77aab010bdbedb43ba84dd831ea7352c09402c in cordova-plugin-camera's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=ce77aab ] CB-13813: (iOS) Remove old iOS code (#381) > Remove old iOS code from cordova-plugin-camera > -- > > Key: CB-13813 > URL: https://issues.apache.org/jira/browse/CB-13813 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-camera >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > cordova-ios supports iOS 9 and newer, but cordova-plugin-camera still has > IsAtLeastiOSVersion(@"8.0") code that is not needed. Also used UIAlertView > which is deprecated > We should remove all the IsAtLeastiOSVersion(@"8.0") and replace the > UIAlertView with UIAlertController and some other old unused code -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14022) Vibrate plugin does not work
[ https://issues.apache.org/jira/browse/CB-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700731#comment-16700731 ] ASF subversion and git services commented on CB-14022: -- Commit 930b91d57635fb17d6c7dc38d56b74bd2171aa0c in cordova-plugin-vibration's branch refs/heads/janpio-remove_translations from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=930b91d ] CB-14022: documented android quirk with vibration > Vibrate plugin does not work > > > Key: CB-14022 > URL: https://issues.apache.org/jira/browse/CB-14022 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova@7.0.0, cordova-android-7.0.0 >Reporter: Mahesh Kanniah >Assignee: Joe Bowser >Priority: Minor > Fix For: Master > > > navigator.vibrate does not work. > Used to work in earlier versions but just fails to work. > Tested on multiple devices running different android versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin
[ https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700728#comment-16700728 ] ASF subversion and git services commented on CB-13892: -- Commit 46d7db8b0b7d62bbe267244d33388e475154aca7 in cordova-plugin-vibration's branch refs/heads/janpio-remove_translations from [~jcpa] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=46d7db8 ] CB-13892:(all) Remove navigator.notification > Remove navigator.notification from vibration plugin > --- > > Key: CB-13892 > URL: https://issues.apache.org/jira/browse/CB-13892 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-vibration >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > The navigator.notification was deprecated long time ago and also deleted from > the docs, but the plugin still have it as merges in the plugin.xml > We should remove it from plugin.xml and from the manual tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018
[ https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700732#comment-16700732 ] ASF subversion and git services commented on CB-14030: -- Commit 0b323409f963fe4c0f3e968a2a20b593b66bde98 in cordova-plugin-vibration's branch refs/heads/janpio-remove_translations from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=0b32340 ] CB-14030 Updated version and RELEASENOTES.md for release 3.1.0 (via coho) > Plugins Release, Thu Apr 12 2018 > > > Key: CB-14030 > URL: https://issues.apache.org/jira/browse/CB-14030 > Project: Apache Cordova > Issue Type: Task > Components: AllPlugins >Reporter: Steve Gill >Assignee: Steve Gill >Priority: Major > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md > Generated automatically using cordova-coho. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin
[ https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700729#comment-16700729 ] ASF subversion and git services commented on CB-13892: -- Commit 06e9aa4a57aa8b368e5e402ace05776e4f2a496a in cordova-plugin-vibration's branch refs/heads/janpio-remove_translations from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=06e9aa4 ] Merge pull request #67 from jcesarmobile/CB-13892 CB-13892:(all) Remove navigator.notification > Remove navigator.notification from vibration plugin > --- > > Key: CB-13892 > URL: https://issues.apache.org/jira/browse/CB-13892 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-vibration >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > The navigator.notification was deprecated long time ago and also deleted from > the docs, but the plugin still have it as merges in the plugin.xml > We should remove it from plugin.xml and from the manual tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin
[ https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700730#comment-16700730 ] ASF subversion and git services commented on CB-13892: -- Commit 06e9aa4a57aa8b368e5e402ace05776e4f2a496a in cordova-plugin-vibration's branch refs/heads/janpio-remove_translations from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=06e9aa4 ] Merge pull request #67 from jcesarmobile/CB-13892 CB-13892:(all) Remove navigator.notification > Remove navigator.notification from vibration plugin > --- > > Key: CB-13892 > URL: https://issues.apache.org/jira/browse/CB-13892 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-vibration >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > The navigator.notification was deprecated long time ago and also deleted from > the docs, but the plugin still have it as merges in the plugin.xml > We should remove it from plugin.xml and from the manual tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13865) Making CameraPopover for imagePicker bigger on Ipad
[
https://issues.apache.org/jira/browse/CB-13865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698162#comment-16698162
]
ASF subversion and git services commented on CB-13865:
--
Commit cd72047dfc60175fe6ddf158b1094a8ca09871b8 in cordova-plugin-camera's
branch refs/heads/master from [~amerCode]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=cd72047 ]
CB-13865: (IOS-Ipad) Making popover Window Size configurable using
popoverOptions - imagePicker (#314)
> Making CameraPopover for imagePicker bigger on Ipad
> ---
>
> Key: CB-13865
> URL: https://issues.apache.org/jira/browse/CB-13865
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-camera
>Reporter: Ams
>Priority: Major
> Fix For: Master
>
>
> The popover for imagePicker from gallery is way too small and people complain
> about not being able to see images before selecting them.
>
> The fix is simple:
>
> Adding this line to willShowViewController method will set it to 960 by 960
> or as big as the screen widht/height
> [viewController setPreferredContentSize:CGSizeMake(960,960)];
> It should be added right in the if statement:
> if([navigationController isKindOfClass:[UIImagePickerController class]]){
>
> HOW CAN I COMMIT THIS CHANGE?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12210) Specifying the --plugin flag without a value causes an exception
[
https://issues.apache.org/jira/browse/CB-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697906#comment-16697906
]
ASF subversion and git services commented on CB-12210:
--
Commit 2b3e03f32a6f13af6dce9b0ed9a9417597a9349e in cordova-paramedic's branch
refs/heads/janpio-misc from Fil Maj
[ https://gitbox.apache.org/repos/asf?p=cordova-paramedic.git;h=2b3e03f ]
[CB-12210] require a string when parsing the plugin argument. (#19)
> Specifying the --plugin flag without a value causes an exception
>
>
> Key: CB-12210
> URL: https://issues.apache.org/jira/browse/CB-12210
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-paramedic
>Reporter: sterling gerritz
>Assignee: Jesse MacFadyen
>Priority: Minor
>
> FYI: when I failed to add a path paramedic threw a 'type error':
> cordova-paramedic --platform android --plugin
> cordova-paramedic: creating temp project at
> /var/folders/p4/m50wzcnx3_5grsq_d3z5kq5wgn/T/tmp-21300Vfzeii04OHd0
> cordova-paramedic: installing true
> path.js:7
>throw new TypeError('Path must be a string. Received ' + inspect(path));
>^
> TypeError: Path must be a string. Received true
>at assertPath (path.js:7:11)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12210) Specifying the --plugin flag without a value causes an exception
[
https://issues.apache.org/jira/browse/CB-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697896#comment-16697896
]
ASF subversion and git services commented on CB-12210:
--
Commit 2b3e03f32a6f13af6dce9b0ed9a9417597a9349e in cordova-paramedic's branch
refs/heads/master from Fil Maj
[ https://gitbox.apache.org/repos/asf?p=cordova-paramedic.git;h=2b3e03f ]
[CB-12210] require a string when parsing the plugin argument. (#19)
> Specifying the --plugin flag without a value causes an exception
>
>
> Key: CB-12210
> URL: https://issues.apache.org/jira/browse/CB-12210
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-paramedic
>Reporter: sterling gerritz
>Assignee: Jesse MacFadyen
>Priority: Minor
>
> FYI: when I failed to add a path paramedic threw a 'type error':
> cordova-paramedic --platform android --plugin
> cordova-paramedic: creating temp project at
> /var/folders/p4/m50wzcnx3_5grsq_d3z5kq5wgn/T/tmp-21300Vfzeii04OHd0
> cordova-paramedic: installing true
> path.js:7
>throw new TypeError('Path must be a string. Received ' + inspect(path));
>^
> TypeError: Path must be a string. Received true
>at assertPath (path.js:7:11)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13569) The LocalFileSystem enum in the typescript file is inverted
[ https://issues.apache.org/jira/browse/CB-13569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697449#comment-16697449 ] ASF subversion and git services commented on CB-13569: -- Commit d135cd0e006736ea60c9dec46590de0927d57b6b in cordova-plugin-file's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-file.git;h=d135cd0 ] CB-13569: fix inverted LocalFileSystem enum (#274) > The LocalFileSystem enum in the typescript file is inverted > --- > > Key: CB-13569 > URL: https://issues.apache.org/jira/browse/CB-13569 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file > Environment: Problem when using typescript. >Reporter: anton deblasio >Priority: Trivial > Original Estimate: 5m > Remaining Estimate: 5m > > When using the typescript type file one of the enums is inverted > the LocalFileSystem has two options PERSISTENT and TEMPORARY, these relate > to the values 1 and 0 respectively. However in the typescript file they are > set to 0 and 1. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13837) TypeScript Definition for CameraPopoverOptions does not declare class
[
https://issues.apache.org/jira/browse/CB-13837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697392#comment-16697392
]
ASF subversion and git services commented on CB-13837:
--
Commit 86b0bf2534a8d22e582437b30f57a0fad870471d in cordova-plugin-camera's
branch refs/heads/master from [~jcesarmobile]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=86b0bf2 ]
CB-13837: fix TypeScript Definition for CameraPopoverOptions (#379)
> TypeScript Definition for CameraPopoverOptions does not declare class
> -
>
> Key: CB-13837
> URL: https://issues.apache.org/jira/browse/CB-13837
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Reporter: Ryan Murphy
>Priority: Minor
>
> The docs for CameraPopoverOptions use it as a class.
> From docs:
> {code:javascript}
> var cameraPopoverOptions = new CameraPopoverOptions(0, 0, 100, 100,
> Camera.PopoverArrowDirection.ARROW_ANY);
> {code}
>
> But the index.d.ts only define an interface, not declare a class, so using it
> as a class in a TypeScript file gives the error:
> {color:#ff}[ts] 'CameraPopoverOptions' only refers to a type, but is
> being used as a value here.{color}
> The fix would be to declare a class and constructor.
> {code:java}
> declare class CameraPopoverOptions implements CameraPopoverOptions {
> constructor(x?: number, y?: number, width?: number, height?: number,
> arrowDir?: number);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13830) Cordova-Android@7.0.0 fails to add a plugin previously removed
[
https://issues.apache.org/jira/browse/CB-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690739#comment-16690739
]
ASF subversion and git services commented on CB-13830:
--
Commit e3468c66a374ac4a05940ccb3b0cbf1e5b56b193 in cordova-android's branch
refs/heads/7.1.x from Christopher J. Brody
[ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=e3468c6 ]
Check target-dir mapping of plugin xml source file (PR #550)
Possibly related to: CB-13830: Add handlers for plugins
that use non-Java source files, such as Camera
> Cordova-Android@7.0.0 fails to add a plugin previously removed
> --
>
> Key: CB-13830
> URL: https://issues.apache.org/jira/browse/CB-13830
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: macOS 10.12.6
> node 9.4.0
> Cordova CLI 8.0.0
>
>Reporter: Enrico Giordani
>Assignee: Joe Bowser
>Priority: Major
>
> Removing a plugin and than adding it again, causes an error:
> {code}
> $ cordova create testapp
> $ cd testapp
> $ cordova platform add android
> Using cordova-fetch for cordova-android@~7.0.0
> Adding android project...
> Creating Cordova project for the Android platform:
> Path: platforms/android
> Package: io.cordova.hellocordova
> Name: HelloCordova
> Activity: MainActivity
> Android target: android-26
> Subproject Path: CordovaLib
> Subproject Path: app
> Android project created with cordova-android@7.0.0
> Android Studio project detected
> Android Studio project detected
> Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
> project
> Installing "cordova-plugin-whitelist" for android
> This plugin is only applicable for versions of cordova-android greater than
> 4.0. If you have a previous platform version, you do *not* need this plugin
> since the whitelist will be built in.
>
> Adding cordova-plugin-whitelist to package.json
> Saved plugin info for "cordova-plugin-whitelist" to config.xml
> --save flag or autosave detected
> Saving android@~7.0.0 into config.xml file ...
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Adding cordova-plugin-camera to package.json
> Saved plugin info for "cordova-plugin-camera" to config.xml
> {code}
> {code}
> $ cordova plugin remove cordova-plugin-camera
> Uninstalling cordova-plugin-camera from android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Removing "cordova-plugin-camera"
> Removing plugin cordova-plugin-camera from config.xml file...
> Removing cordova-plugin-camera from package.json
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Error during processing of action! Attempting to revert...
> Failed to install 'cordova-plugin-camera': CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
> already exists!
> at copyNewFile
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
> at install
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
> at ActionStack.process
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
> at PluginManager.doOperation
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
> at PluginManager.addPlugin
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
> at /Users/enrico/tmp/testapp/platforms/android/cordova/Api.js:247:74
> at _fulfilled
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:854:54)
> at self.promiseDispatch.done
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:883:30)
> at Promise.promise.promiseDispatch
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:816:13)
> at
> /Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:570:49
> (node:5722) UnhandledPromiseRejectionWarning: CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
> already exists!
> at copyNewFile
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
> at install
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
> at ActionStack.process
>
[jira] [Commented] (CB-13830) Cordova-Android@7.0.0 fails to add a plugin previously removed
[
https://issues.apache.org/jira/browse/CB-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687249#comment-16687249
]
ASF subversion and git services commented on CB-13830:
--
Commit 578a6422098f9c1786834d6f98782142846f72cb in cordova-android's branch
refs/heads/master from Christopher J. Brody
[ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=578a642 ]
Check target-dir mapping of plugin xml source file
Possibly related to: CB-13830: Add handlers for plugins
that use non-Java source files, such as Camera
> Cordova-Android@7.0.0 fails to add a plugin previously removed
> --
>
> Key: CB-13830
> URL: https://issues.apache.org/jira/browse/CB-13830
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: macOS 10.12.6
> node 9.4.0
> Cordova CLI 8.0.0
>
>Reporter: Enrico Giordani
>Assignee: Joe Bowser
>Priority: Major
>
> Removing a plugin and than adding it again, causes an error:
> {code}
> $ cordova create testapp
> $ cd testapp
> $ cordova platform add android
> Using cordova-fetch for cordova-android@~7.0.0
> Adding android project...
> Creating Cordova project for the Android platform:
> Path: platforms/android
> Package: io.cordova.hellocordova
> Name: HelloCordova
> Activity: MainActivity
> Android target: android-26
> Subproject Path: CordovaLib
> Subproject Path: app
> Android project created with cordova-android@7.0.0
> Android Studio project detected
> Android Studio project detected
> Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
> project
> Installing "cordova-plugin-whitelist" for android
> This plugin is only applicable for versions of cordova-android greater than
> 4.0. If you have a previous platform version, you do *not* need this plugin
> since the whitelist will be built in.
>
> Adding cordova-plugin-whitelist to package.json
> Saved plugin info for "cordova-plugin-whitelist" to config.xml
> --save flag or autosave detected
> Saving android@~7.0.0 into config.xml file ...
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Adding cordova-plugin-camera to package.json
> Saved plugin info for "cordova-plugin-camera" to config.xml
> {code}
> {code}
> $ cordova plugin remove cordova-plugin-camera
> Uninstalling cordova-plugin-camera from android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Removing "cordova-plugin-camera"
> Removing plugin cordova-plugin-camera from config.xml file...
> Removing cordova-plugin-camera from package.json
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Error during processing of action! Attempting to revert...
> Failed to install 'cordova-plugin-camera': CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
> already exists!
> at copyNewFile
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
> at install
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
> at ActionStack.process
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
> at PluginManager.doOperation
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
> at PluginManager.addPlugin
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
> at /Users/enrico/tmp/testapp/platforms/android/cordova/Api.js:247:74
> at _fulfilled
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:854:54)
> at self.promiseDispatch.done
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:883:30)
> at Promise.promise.promiseDispatch
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:816:13)
> at
> /Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:570:49
> (node:5722) UnhandledPromiseRejectionWarning: CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
> already exists!
> at copyNewFile
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
> at install
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
> at ActionStack.process
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
>
[jira] [Commented] (CB-14125) Increase cordova-android old plugin compatibility
[ https://issues.apache.org/jira/browse/CB-14125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687250#comment-16687250 ] ASF subversion and git services commented on CB-14125: -- Commit 92f07d0418aded0751120609025ac2df06d05a32 in cordova-android's branch refs/heads/master from Christopher J. Brody [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=92f07d0 ] Check old compat of other extension (CB-14125) of plugin source file installed into app/src/main with old target-dir scheme NOTE: These tests do *not* check compatibility of plugins with old lib target-dir scheme. > Increase cordova-android old plugin compatibility > - > > Key: CB-14125 > URL: https://issues.apache.org/jira/browse/CB-14125 > Project: Apache Cordova > Issue Type: Improvement >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > With the structure change of cordova-android 7.1.0, a lot of plugins don't > work because they user source-file tag for images or other file types. > Right now, we only patch to the new path structure .java and .xml files. > Add 'app/src/main' to all file types, no mater what type they have. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9366) Log error.stack when a call to a plugin throws an exception
[ https://issues.apache.org/jira/browse/CB-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687102#comment-16687102 ] ASF subversion and git services commented on CB-9366: - Commit 5c334b6c105b5f4df2130f998e8f4dc3f7b32bfb in cordova-android's branch refs/heads/master from Christopher J. Brody [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=5c334b6 ] CB-9366 cordova.js log error.stack (cordova-js@4.2.4) (Update cordova.js from cordova-js@4.2.4, using coho copy-js) > Log error.stack when a call to a plugin throws an exception > --- > > Key: CB-9366 > URL: https://issues.apache.org/jira/browse/CB-9366 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-js >Affects Versions: Master >Reporter: Nikhil Khandelwal >Assignee: Chris Brody >Priority: Minor > Fix For: 4.2.4 > > > This can help in isolating the cause of the error. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11828) New NativeToJSBridge does not work on Jellybean
[ https://issues.apache.org/jira/browse/CB-11828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684093#comment-16684093 ] ASF subversion and git services commented on CB-11828: -- Commit e31596f60eeb3d9a7d47844b3e0e45304530d30f in cordova-android's branch refs/heads/master from [~brodybits] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=e31596f ] Remove obsolete check for JellyBean (GH-534) (#544) to work properly on Android Pie was introduced in dc0bfeb0c (CB-11828) Resolves #534 Co-authored-by: Co-authored-by: Christopher J. Brody > New NativeToJSBridge does not work on Jellybean > > > Key: CB-11828 > URL: https://issues.apache.org/jira/browse/CB-11828 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: Master >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Blocker > > Apparently this got missed after weeks of review. The new default bridge > doesn't work on Jellybean, and since we're required to support Jellybean > until it dips below 5%, we need to be able to keep supporting it for the > SystemWebView. However, we have a uniquely strange situation where we just > add bridge modes to SystemWebViews, which could cause some unpredictable > results when choosing the right webview. > For example, we have enumerated values for setting the mode on the JS for the > four types of nativeToJsBridges, but they can be added at random depending on > the circumstance. > BTW: This only affects the master branch, and not any released versions of > Cordova. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14201) Remove Gradle property in-line command arguments for gradle.properties
[ https://issues.apache.org/jira/browse/CB-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671108#comment-16671108 ] ASF subversion and git services commented on CB-14201: -- Commit dacb0e5c721a7476b767261433fb96e7a7b6f088 in cordova-android's branch refs/heads/master from エリス [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=dacb0e5 ] CB-14201: (android) Removes Gradle property in-line command arguments for gradle.properties > Remove Gradle property in-line command arguments for gradle.properties > -- > > Key: CB-14201 > URL: https://issues.apache.org/jira/browse/CB-14201 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Reporter: Bryan Ellis >Priority: Minor > > By passing in properties as an argument to the Gradle's command, it prevents > users from being able to override these values. > In one example, a user reported > ([CB-14139|https://issues.apache.org/jira/browse/CB-14139]) the need to be > able to set the jvmargs so builds works on 32bit Java. > Some other values Cordova passes by default are org.gradle.daemon and > android.useDeprecatedNdk. > By removing the command line argument usage and migrating to the usage of > gradle.properties, it gives users the flexibility to override defaults if > desired. > This ticket will also resolve > [CB-14139|https://issues.apache.org/jira/browse/CB-14139] but also remove the > other argument usage. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14201) Remove Gradle property in-line command arguments for gradle.properties
[ https://issues.apache.org/jira/browse/CB-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671110#comment-16671110 ] ASF subversion and git services commented on CB-14201: -- Commit e58453d3e6f16e45fb9ac3b9f420832799c57e91 in cordova-android's branch refs/heads/master from [~dpogue] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=e58453d ] Merge pull request #465 from erisu/CB-14201 CB-14201: (android) Removes Gradle property in-line command arguments… > Remove Gradle property in-line command arguments for gradle.properties > -- > > Key: CB-14201 > URL: https://issues.apache.org/jira/browse/CB-14201 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Reporter: Bryan Ellis >Priority: Minor > > By passing in properties as an argument to the Gradle's command, it prevents > users from being able to override these values. > In one example, a user reported > ([CB-14139|https://issues.apache.org/jira/browse/CB-14139]) the need to be > able to set the jvmargs so builds works on 32bit Java. > Some other values Cordova passes by default are org.gradle.daemon and > android.useDeprecatedNdk. > By removing the command line argument usage and migrating to the usage of > gradle.properties, it gives users the flexibility to override defaults if > desired. > This ticket will also resolve > [CB-14139|https://issues.apache.org/jira/browse/CB-14139] but also remove the > other argument usage. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14201) Remove Gradle property in-line command arguments for gradle.properties
[ https://issues.apache.org/jira/browse/CB-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671109#comment-16671109 ] ASF subversion and git services commented on CB-14201: -- Commit e58453d3e6f16e45fb9ac3b9f420832799c57e91 in cordova-android's branch refs/heads/master from [~dpogue] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=e58453d ] Merge pull request #465 from erisu/CB-14201 CB-14201: (android) Removes Gradle property in-line command arguments… > Remove Gradle property in-line command arguments for gradle.properties > -- > > Key: CB-14201 > URL: https://issues.apache.org/jira/browse/CB-14201 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Reporter: Bryan Ellis >Priority: Minor > > By passing in properties as an argument to the Gradle's command, it prevents > users from being able to override these values. > In one example, a user reported > ([CB-14139|https://issues.apache.org/jira/browse/CB-14139]) the need to be > able to set the jvmargs so builds works on 32bit Java. > Some other values Cordova passes by default are org.gradle.daemon and > android.useDeprecatedNdk. > By removing the command line argument usage and migrating to the usage of > gradle.properties, it gives users the flexibility to override defaults if > desired. > This ticket will also resolve > [CB-14139|https://issues.apache.org/jira/browse/CB-14139] but also remove the > other argument usage. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653016#comment-16653016 ] ASF subversion and git services commented on CB-7179: - Commit 10a06691f94a5ccc76957c48887469aedd4c2e13 in cordova-plugin-inappbrowser's branch refs/heads/master from [~purplecabbage] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=10a0669 ] Merge pull request #271 from dpa99c/CB-7179 CB-7179 (iOS): Add WKWebView support for iOS > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653013#comment-16653013 ] ASF subversion and git services commented on CB-7179: - Commit 3927b8f2fee8e168bb19de93031b2f930b542b24 in cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=3927b8f ] Merge branch 'CB-7179' of https://github.com/dpa99c/cordova-plugin-themeablebrowser into CB-7179 > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653011#comment-16653011 ] ASF subversion and git services commented on CB-7179: - Commit 5d2df218d83bdaae79ca953799ad8d30cf9f2ce9 in cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=5d2df21 ] Merge branch 'CB-7179' of https://github.com/dpa99c/cordova-plugin-inappbrowser into CB-7179 > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653017#comment-16653017 ] ASF subversion and git services commented on CB-7179: - Commit 10a06691f94a5ccc76957c48887469aedd4c2e13 in cordova-plugin-inappbrowser's branch refs/heads/master from [~purplecabbage] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=10a0669 ] Merge pull request #271 from dpa99c/CB-7179 CB-7179 (iOS): Add WKWebView support for iOS > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653010#comment-16653010 ] ASF subversion and git services commented on CB-7179: - Commit 5d2df218d83bdaae79ca953799ad8d30cf9f2ce9 in cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=5d2df21 ] Merge branch 'CB-7179' of https://github.com/dpa99c/cordova-plugin-inappbrowser into CB-7179 > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653015#comment-16653015 ] ASF subversion and git services commented on CB-7179: - Commit 3927b8f2fee8e168bb19de93031b2f930b542b24 in cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=3927b8f ] Merge branch 'CB-7179' of https://github.com/dpa99c/cordova-plugin-themeablebrowser into CB-7179 > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653012#comment-16653012 ] ASF subversion and git services commented on CB-7179: - Commit 19c6dfe1971818789a4b3e83f6f4b0793e401597 in cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=19c6dfe ] Merge branch 'master' into CB-7179 > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653009#comment-16653009 ] ASF subversion and git services commented on CB-7179: - Commit cbfa195f7da3b8307a468c3f50f38de25f38bd8e in cordova-plugin-inappbrowser's branch refs/heads/master from Jan Piotrowski [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=cbfa195 ] Merge branch 'master' into CB-7179 > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14226) cordova-windows platform patch release July 2018
[ https://issues.apache.org/jira/browse/CB-14226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639154#comment-16639154 ] ASF subversion and git services commented on CB-14226: -- Commit 7240c893714a6d461e78c834dcbd34f646d3ace1 in cordova-docs's branch refs/heads/master from [~brodybits] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=7240c89 ] CB-14226 cordova-windows@6.0.1 patch blog post (#854) > cordova-windows platform patch release July 2018 > > > Key: CB-14226 > URL: https://issues.apache.org/jira/browse/CB-14226 > Project: Apache Cordova > Issue Type: Task > Components: cordova-windows >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > Patch release of cordova-windows package with CB-14145 (npm audit issues) > resolved. > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md > (with some modifications) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.
[ https://issues.apache.org/jira/browse/CB-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637579#comment-16637579 ] ASF subversion and git services commented on CB-14188: -- Commit 228703a63b088cbb635aa58f8a1015a9d5d818ab in cordova-plugin-inappbrowser's branch refs/heads/master from [~wvengen] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=228703a ] CB-14188: add beforeload event, catching navigation before it happens > Callback to decide whether to open link or not. > --- > > Key: CB-14188 > URL: https://issues.apache.org/jira/browse/CB-14188 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-inappbrowser >Affects Versions: 3.0.0 >Reporter: wvengen >Priority: Major > > Several times I've found myself wanting to tell inAppBrowser whether it can > open a link in the embedded webview or using the system web browser. It would > be great if there's a callback _before_ loading a page (loadstart is too late > there), where I can tell inAppBrowser to load the page or not. > CB-14013 introduced AllowedSchemes, but excluded the use of http and https. > -It would be useful to allow intercepting http and https links, e.g. to > decide whether to open the link in the system web browser or not.- At first I > thought this mechanism could be used, but because of the asynchronous nature > of Cordova callbacks, this didn't work out, and I added a beforeload > callback. See comment for an example. > I've submitted a PR -(my approach would be to generate a regexp based on > AllowedSchemes and match the URL on that, instead of the current if logic)-. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.
[ https://issues.apache.org/jira/browse/CB-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637580#comment-16637580 ] ASF subversion and git services commented on CB-14188: -- Commit eafaedaec4b82c14543e8f4622dc868e43b765e5 in cordova-plugin-inappbrowser's branch refs/heads/master from [~brodybits] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=eafaeda ] Merge pull request #276 from q-m/feature/beforeload-event CB-14188: Add beforeload event, catching navigation before it happens > Callback to decide whether to open link or not. > --- > > Key: CB-14188 > URL: https://issues.apache.org/jira/browse/CB-14188 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-inappbrowser >Affects Versions: 3.0.0 >Reporter: wvengen >Priority: Major > > Several times I've found myself wanting to tell inAppBrowser whether it can > open a link in the embedded webview or using the system web browser. It would > be great if there's a callback _before_ loading a page (loadstart is too late > there), where I can tell inAppBrowser to load the page or not. > CB-14013 introduced AllowedSchemes, but excluded the use of http and https. > -It would be useful to allow intercepting http and https links, e.g. to > decide whether to open the link in the system web browser or not.- At first I > thought this mechanism could be used, but because of the asynchronous nature > of Cordova callbacks, this didn't work out, and I added a beforeload > callback. See comment for an example. > I've submitted a PR -(my approach would be to generate a regexp based on > AllowedSchemes and match the URL on that, instead of the current if logic)-. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
[ https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637576#comment-16637576 ] ASF subversion and git services commented on CB-11714: -- Commit dc7395410890be9e918e6a7cd05bc2dfabcd24fc in cordova-plugin-camera's branch refs/heads/master from [~brodybits] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=dc73954 ] Merge pull request #242 from DisruptiveMind/master CB-11714: (windows) added check for encoding in savePhoto() without height/width > Camera plugin for windows does not properly set content-type when selecting > JPG->PNG > > > Key: CB-11714 > URL: https://issues.apache.org/jira/browse/CB-11714 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: Master > Environment: Windows 10 >Reporter: Tyler Pham >Priority: Major > Labels: easyfix, triaged, windows > > When selecting a JPG with encodingType = Camera.EncodingType.PNG, the > resizeImage() will not modify the target content type when converting > canvas.toDataURL(...) -- the content-type will still be image/jpeg but with a > .png extension which will cause the browser to not render to image and issue > an error. > Possibly related to: CB-8618 > I have created a small fix at: > https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
[ https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637575#comment-16637575 ] ASF subversion and git services commented on CB-11714: -- Commit eb57b02ba85429450d35a32ec13f86b88645a511 in cordova-plugin-camera's branch refs/heads/master from [~DisruptiveArt] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=eb57b02 ] CB-11714: reuse picture.name instead of pictureName > Camera plugin for windows does not properly set content-type when selecting > JPG->PNG > > > Key: CB-11714 > URL: https://issues.apache.org/jira/browse/CB-11714 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: Master > Environment: Windows 10 >Reporter: Tyler Pham >Priority: Major > Labels: easyfix, triaged, windows > > When selecting a JPG with encodingType = Camera.EncodingType.PNG, the > resizeImage() will not modify the target content type when converting > canvas.toDataURL(...) -- the content-type will still be image/jpeg but with a > .png extension which will cause the browser to not render to image and issue > an error. > Possibly related to: CB-8618 > I have created a small fix at: > https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
[ https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637574#comment-16637574 ] ASF subversion and git services commented on CB-11714: -- Commit a201722f6d9e94dcd071154287416f53b7423089 in cordova-plugin-camera's branch refs/heads/master from [~DisruptiveArt] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=a201722 ] CB-11714: (windows) added extra check for content-type in savePhoto() without options.targetWidth/Height > Camera plugin for windows does not properly set content-type when selecting > JPG->PNG > > > Key: CB-11714 > URL: https://issues.apache.org/jira/browse/CB-11714 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: Master > Environment: Windows 10 >Reporter: Tyler Pham >Priority: Major > Labels: easyfix, triaged, windows > > When selecting a JPG with encodingType = Camera.EncodingType.PNG, the > resizeImage() will not modify the target content type when converting > canvas.toDataURL(...) -- the content-type will still be image/jpeg but with a > .png extension which will cause the browser to not render to image and issue > an error. > Possibly related to: CB-8618 > I have created a small fix at: > https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12941) Update typings to latest DefinitelyTyped revision
[ https://issues.apache.org/jira/browse/CB-12941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635224#comment-16635224 ] ASF subversion and git services commented on CB-12941: -- Commit a0c267fe36be9a97c974f73b9d2160eca54b9828 in cordova-plugin-inappbrowser's branch refs/heads/master from [~timbru31] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=a0c267f ] CB-12941: update typings (#267) ### Platforms affected n/a - development with TypeScript ### What does this PR do? Updates the typings to match the latest published version on DefinitelyTyped. See https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17192 and https://stackoverflow.com/q/42095516/1902598 ### What testing has been done on this change? Project compiles again ;) ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - n/a: Added automated test coverage as appropriate for this change. fixes #300 > Update typings to latest DefinitelyTyped revision > - > > Key: CB-12941 > URL: https://issues.apache.org/jira/browse/CB-12941 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Reporter: Tim Brust >Priority: Major > Labels: inappbrowser, plugins, typescript, typings > > Update the typings in the cordova-plugin-inappbrowser to match the current > revision published via DefinitelyTyped. > This fixes e.g. this issue: https://stackoverflow.com/q/42095516/1902598 > DefinitelyTyped PR: > https://github.com/DefinitelyTyped/DefinitelyTyped/pull/17192 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13850) Typescript: Misspelled property fileSystem
[ https://issues.apache.org/jira/browse/CB-13850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634577#comment-16634577 ] ASF subversion and git services commented on CB-13850: -- Commit 4642fde47ff24f6a2a38ef5f812cca04e1c23a1a in cordova-plugin-file's branch refs/heads/master from Beutlin [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-file.git;h=4642fde ] CB-13850: Fix spelling in typed-file: property name filesystem (wrong… (#229) ### Platforms affected - ### What does this PR do? The DefinitelyTyped file has a wrong attribute for an Entry object. It is "fileSystem" but should be "filesystem". The consequence of this is that the syntax checker of an IDE might give an false warning. ### What testing has been done on this change? Looked at file www/Entry.js. Obviously the naming is here "filesystem". ### Checklist - [ x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ x ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - Automated tests are not possible, because this bug is related to a DefinitelyTyped file, which provides only syntax checking for IDEs. > Typescript: Misspelled property fileSystem > -- > > Key: CB-13850 > URL: https://issues.apache.org/jira/browse/CB-13850 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file >Reporter: Tobias Haupenthal >Priority: Major > > The Typescript file index.d.ts shows that an Entry shall have an attribute > fileSystem. > But in Android this property is undefined. There is only the property > filesystem. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13960) Typescript: FileWriter write argument definition shall include type string
[
https://issues.apache.org/jira/browse/CB-13960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634575#comment-16634575
]
ASF subversion and git services commented on CB-13960:
--
Commit 5353b847270d55f8caedfc992393137514c59992 in cordova-plugin-file's branch
refs/heads/master from vldmr-bus
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-file.git;h=5353b84 ]
CB-13960: fix FileWriter.write argument type definition for typescript (#231)
Fix FileWriter.write argument type definition for typescript
> Typescript: FileWriter write argument definition shall include type string
> --
>
> Key: CB-13960
> URL: https://issues.apache.org/jira/browse/CB-13960
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file
>Reporter: Vladimir
>Priority: Major
>
> www\FileWriter.js has the following annotation on write method:
> {code:java}
> @param data text or blob to be writte{code}
> But types\index.d.ts has the following type definition:
> {code:java}
> /**
> * Write the supplied data to the file at position.
> * @param {Blob} data The blob to write.
> */
> write(data: Blob): void;{code}
> Shall be as follows:
> {code:java}
> /**
> * Write the supplied data to the file at position.
> * @param {Blob|string} data The blob to write.
> */
> write(data: Blob|string): void;{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633873#comment-16633873 ] ASF subversion and git services commented on CB-14166: -- Commit 7ac19a8b086e8fa19551cbfc2e188c3bd7072da1 in cordova-lib's branch refs/heads/cross-spawn-test from Almir Kadric [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=7ac19a8 ] CB-14166: (cli) Fixed issue when install plugins on windows The npm package name is already wrapped in quotes to prevent special characters from being execute. However the additional win32 code was further injecting quotes around the version causing npm to return a EINVALIDTAGNAME error. The win32 code is redundant and seems to not be required. > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633166#comment-16633166 ] ASF subversion and git services commented on CB-14166: -- Commit 2820f583144a16aeef298f375384ef7a9dfb6ef5 in cordova-lib's branch refs/heads/cross-spawn-test from Almir Kadric [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=2820f58 ] CB-14166: (cli) Fixed issue when install plugins on windows The npm package name is already wrapped in quotes to prevent special characters from being execute. However the additional win32 code was further injecting quotes around the version causing npm to return a EINVALIDTAGNAME error. The win32 code is redundant and seems to not be required. > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628387#comment-16628387 ] ASF subversion and git services commented on CB-14166: -- Commit 19622dedfac0078b8f5f997c96996d505c35de71 in cordova-lib's branch refs/heads/cross-spawn-test from Almir Kadric [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=19622de ] CB-14166: (cli) Fixed issue when install plugins on windows The npm package name is already wrapped in quotes to prevent special characters from being execute. However the additional win32 code was further injecting quotes around the version causing npm to return a EINVALIDTAGNAME error. The win32 code is redundant and seems to not be required. > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
[
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628066#comment-16628066
]
ASF subversion and git services commented on CB-13740:
--
Commit 9a38451467eb5a9b75adc39c74508dd512dbec2d in cordova-browser's branch
refs/heads/master from [~purplecabbage]
[ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=9a38451 ]
CB-13740 return expected promise resolving with array
> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
>
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node: v7.5.0
> NPM: 4.1.2
> Cordova CLI: 8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM: 5.6.0
> Cordova CLI: 8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated.
> In the future, promise rejections that are not handled will terminate the
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection.
> This error originated either by throwing inside of an async function without
> a catch block, or by rejecting a promise which was not handled with .catch().
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are
> deprecated. In the future, promise rejections that are not handled will
> terminate the Node.js process with a non-zero exit code.
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
[
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628068#comment-16628068
]
ASF subversion and git services commented on CB-13740:
--
Commit 5ce40e53e2ea2be61c78dd3c9c6b9f27c58cc80a in cordova-browser's branch
refs/heads/master from [~purplecabbage]
[ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=5ce40e5 ]
Merge pull request #61 from purplecabbage/CB-13740
CB-13740 return expected promise resolving with array
> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
>
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node: v7.5.0
> NPM: 4.1.2
> Cordova CLI: 8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM: 5.6.0
> Cordova CLI: 8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated.
> In the future, promise rejections that are not handled will terminate the
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection.
> This error originated either by throwing inside of an async function without
> a catch block, or by rejecting a promise which was not handled with .catch().
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are
> deprecated. In the future, promise rejections that are not handled will
> terminate the Node.js process with a non-zero exit code.
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
[
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628067#comment-16628067
]
ASF subversion and git services commented on CB-13740:
--
Commit 5ce40e53e2ea2be61c78dd3c9c6b9f27c58cc80a in cordova-browser's branch
refs/heads/master from [~purplecabbage]
[ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=5ce40e5 ]
Merge pull request #61 from purplecabbage/CB-13740
CB-13740 return expected promise resolving with array
> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
>
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node: v7.5.0
> NPM: 4.1.2
> Cordova CLI: 8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM: 5.6.0
> Cordova CLI: 8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated.
> In the future, promise rejections that are not handled will terminate the
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection.
> This error originated either by throwing inside of an async function without
> a catch block, or by rejecting a promise which was not handled with .catch().
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are
> deprecated. In the future, promise rejections that are not handled will
> terminate the Node.js process with a non-zero exit code.
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
[
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628011#comment-16628011
]
ASF subversion and git services commented on CB-13740:
--
Commit 890d336a29c586633b4cfa1f714c1afe5e604ac6 in cordova-cli's branch
refs/heads/master from [~purplecabbage]
[ https://gitbox.apache.org/repos/asf?p=cordova-cli.git;h=890d336 ]
Merge pull request #335 from purplecabbage/CB-13740
CB-13740 safe requirements check
> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
>
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node: v7.5.0
> NPM: 4.1.2
> Cordova CLI: 8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM: 5.6.0
> Cordova CLI: 8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated.
> In the future, promise rejections that are not handled will terminate the
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection.
> This error originated either by throwing inside of an async function without
> a catch block, or by rejecting a promise which was not handled with .catch().
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are
> deprecated. In the future, promise rejections that are not handled will
> terminate the Node.js process with a non-zero exit code.
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
[
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628010#comment-16628010
]
ASF subversion and git services commented on CB-13740:
--
Commit f10a3719dce40f165f00864110ea6bcae336b38e in cordova-cli's branch
refs/heads/master from [~purplecabbage]
[ https://gitbox.apache.org/repos/asf?p=cordova-cli.git;h=f10a371 ]
CB-13740 gracefully handle platforms that don't pass back requirements to check
> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
>
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node: v7.5.0
> NPM: 4.1.2
> Cordova CLI: 8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM: 5.6.0
> Cordova CLI: 8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated.
> In the future, promise rejections that are not handled will terminate the
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection.
> This error originated either by throwing inside of an async function without
> a catch block, or by rejecting a promise which was not handled with .catch().
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are
> deprecated. In the future, promise rejections that are not handled will
> terminate the Node.js process with a non-zero exit code.
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13740) CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
[
https://issues.apache.org/jira/browse/CB-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628012#comment-16628012
]
ASF subversion and git services commented on CB-13740:
--
Commit 890d336a29c586633b4cfa1f714c1afe5e604ac6 in cordova-cli's branch
refs/heads/master from [~purplecabbage]
[ https://gitbox.apache.org/repos/asf?p=cordova-cli.git;h=890d336 ]
Merge pull request #335 from purplecabbage/CB-13740
CB-13740 safe requirements check
> CLI - "cordova requirements" throws error (UnhandledPromiseRejectionWarning)
>
>
> Key: CB-13740
> URL: https://issues.apache.org/jira/browse/CB-13740
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser, cordova-cli
> Environment: Windows 10
> Node: v7.5.0
> NPM: 4.1.2
> Cordova CLI: 8.0.0
> ---
> macOS High Sierra 10.13.1
> Node: v9.3.0
> NPM: 5.6.0
> Cordova CLI: 8.0.0
>Reporter: Sasha Kalmikov
>Priority: Major
>
> When running "cordova requirements" following error thrown:
> *Windows*:
> {noformat}
> Requirements check results for browser:
> (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection
> (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
> (node:5776) DeprecationWarning: Unhandled promise rejections are deprecated.
> In the future, promise rejections that are not handled will terminate the
> Node.js process with a non-zero exit code.
> {noformat}
> *macOS*:
> {noformat}
> Requirements check results for browser:
> (node:72094) UnhandledPromiseRejectionWarning: TypeError: Cannot read
> property 'forEach' of undefined
> at /usr/local/lib/node_modules/cordova/src/cli.js:397:35
> at Array.map ()
> at /usr/local/lib/node_modules/cordova/src/cli.js:388:68
> at _fulfilled
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at
> /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> at Function.Module.runMain (module.js:703:11)
> (node:72094) UnhandledPromiseRejectionWarning: Unhandled promise rejection.
> This error originated either by throwing inside of an async function without
> a catch block, or by rejecting a promise which was not handled with .catch().
> (rejection id: 1)
> (node:72094) [DEP0018] DeprecationWarning: Unhandled promise rejections are
> deprecated. In the future, promise rejections that are not handled will
> terminate the Node.js process with a non-zero exit code.
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14260) captureImage: permission denial on android 8.1
[
https://issues.apache.org/jira/browse/CB-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624298#comment-16624298
]
ASF subversion and git services commented on CB-14260:
--
Commit 3755f9f7374cb6434ddbf67e8c5e800671b939f5 in
cordova-plugin-media-capture's branch refs/heads/master from Marco Celotti
[
https://gitbox.apache.org/repos/asf?p=cordova-plugin-media-capture.git;h=3755f9f
]
CB-14260: (android) captureImage permission denial on android 8.1 (#95)
* CB-14260: (android) captureImage permission denial on android 8.1
> captureImage: permission denial on android 8.1
> --
>
> Key: CB-14260
> URL: https://issues.apache.org/jira/browse/CB-14260
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media-capture
>Affects Versions: 3.0.0
>Reporter: Marco
>Priority: Major
>
> When I call "captureImage" method I accept all permissions but I get:
> {noformat}
> java.lang.SecurityException: Permission Denial: writing
> com.android.providers.media.MediaProvider uri
> content://media/external/images/media from pid=12716, uid=10079 requires
> android.permission.WRITE_EXTERNAL_STORAGE, or grantUriPermission(){noformat}
> I'm using cordova-plugin-media-capture version 3.0.2
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14260) captureImage: permission denial on android 8.1
[
https://issues.apache.org/jira/browse/CB-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624299#comment-16624299
]
ASF subversion and git services commented on CB-14260:
--
Commit 3755f9f7374cb6434ddbf67e8c5e800671b939f5 in
cordova-plugin-media-capture's branch refs/heads/master from Marco Celotti
[
https://gitbox.apache.org/repos/asf?p=cordova-plugin-media-capture.git;h=3755f9f
]
CB-14260: (android) captureImage permission denial on android 8.1 (#95)
* CB-14260: (android) captureImage permission denial on android 8.1
> captureImage: permission denial on android 8.1
> --
>
> Key: CB-14260
> URL: https://issues.apache.org/jira/browse/CB-14260
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media-capture
>Affects Versions: 3.0.0
>Reporter: Marco
>Priority: Major
>
> When I call "captureImage" method I accept all permissions but I get:
> {noformat}
> java.lang.SecurityException: Permission Denial: writing
> com.android.providers.media.MediaProvider uri
> content://media/external/images/media from pid=12716, uid=10079 requires
> android.permission.WRITE_EXTERNAL_STORAGE, or grantUriPermission(){noformat}
> I'm using cordova-plugin-media-capture version 3.0.2
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10795) [InAppBrowser] Circular loop if app had an intent-filter defined for the URL being opened
[
https://issues.apache.org/jira/browse/CB-10795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622685#comment-16622685
]
ASF subversion and git services commented on CB-10795:
--
Commit a0783378fc901a84294dc66908a91f78014d3fb6 in
cordova-plugin-inappbrowser's branch refs/heads/master from [~dpolivy]
[
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=a078337
]
[CB-10795] Exclude current app from external intent list (#154)
On Android, if the app defines an intent-filter for a given URL, and
then tries to use inappbrowser to launch that URL via the _system
target, the default handler for that intent is the app itself.
That behavior can lead to circular loops, and ultimately is not what the
developer wants -- the link should be launched in a browser.
Because there is no easy way to find the "default" system browser on a
device, this solution will do two things:
1) Check if the app is one of the targets for this intent
2) If so, create a custom chooser with all other targets, excluding the
current app.
If the app is not a target, then the current (existing) behavior is
preserved.
The only real "downside" to this approach is that a default handler can no
longer be set for these URLs within the app, and a chooser will be shown each
time the user taps a link that opens in a new browser.
Fixes https://issues.apache.org/jira/browse/CB-10795
> [InAppBrowser] Circular loop if app had an intent-filter defined for the URL
> being opened
> -
>
> Key: CB-10795
> URL: https://issues.apache.org/jira/browse/CB-10795
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Reporter: Dan Polivy
>Priority: Minor
> Labels: Android, triaged
>
> Consider the following scenario:
> 1. App "X" has an intent-filter defined that says it can open URLs for
> "www.example.com". (e.g., using
> https://github.com/EddyVerbruggen/Custom-URL-scheme plugin)
> 2. App "X" wants to launch a specific URL on www.example.com in the system
> browser.
> 3. App "X" uses InAppBrowser plugin and calls {{window.open}} with
> {{_system}} as the target.
> Actual:
> Since the app itself has an intent-filter defined for "www.example.com",
> InAppBrowser will just re-launch the app with the intent. In some cases, if a
> default handler is not chosen, one will get a chooser, however the app will
> still be listed as the default option.
> Expected:
> The app should be able to launch the URL in the system browser to avoid a
> circular redirect.
> There is some discussion of this issue on stackoverflow:
> http://stackoverflow.com/questions/18682833/how-to-exclude-a-specific-application-from-action-view-intent
> http://stackoverflow.com/questions/29529027/open-url-in-browser-even-though-my-app-registered-an-intent-filter-for-it
> I think it might be reasonable for InAppBrowser, in {{openExternal}}, to
> explicitly remove the current app from the list.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10795) [InAppBrowser] Circular loop if app had an intent-filter defined for the URL being opened
[
https://issues.apache.org/jira/browse/CB-10795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622686#comment-16622686
]
ASF subversion and git services commented on CB-10795:
--
Commit a0783378fc901a84294dc66908a91f78014d3fb6 in
cordova-plugin-inappbrowser's branch refs/heads/master from [~dpolivy]
[
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=a078337
]
[CB-10795] Exclude current app from external intent list (#154)
On Android, if the app defines an intent-filter for a given URL, and
then tries to use inappbrowser to launch that URL via the _system
target, the default handler for that intent is the app itself.
That behavior can lead to circular loops, and ultimately is not what the
developer wants -- the link should be launched in a browser.
Because there is no easy way to find the "default" system browser on a
device, this solution will do two things:
1) Check if the app is one of the targets for this intent
2) If so, create a custom chooser with all other targets, excluding the
current app.
If the app is not a target, then the current (existing) behavior is
preserved.
The only real "downside" to this approach is that a default handler can no
longer be set for these URLs within the app, and a chooser will be shown each
time the user taps a link that opens in a new browser.
Fixes https://issues.apache.org/jira/browse/CB-10795
> [InAppBrowser] Circular loop if app had an intent-filter defined for the URL
> being opened
> -
>
> Key: CB-10795
> URL: https://issues.apache.org/jira/browse/CB-10795
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Reporter: Dan Polivy
>Priority: Minor
> Labels: Android, triaged
>
> Consider the following scenario:
> 1. App "X" has an intent-filter defined that says it can open URLs for
> "www.example.com". (e.g., using
> https://github.com/EddyVerbruggen/Custom-URL-scheme plugin)
> 2. App "X" wants to launch a specific URL on www.example.com in the system
> browser.
> 3. App "X" uses InAppBrowser plugin and calls {{window.open}} with
> {{_system}} as the target.
> Actual:
> Since the app itself has an intent-filter defined for "www.example.com",
> InAppBrowser will just re-launch the app with the intent. In some cases, if a
> default handler is not chosen, one will get a chooser, however the app will
> still be listed as the default option.
> Expected:
> The app should be able to launch the URL in the system browser to avoid a
> circular redirect.
> There is some discussion of this issue on stackoverflow:
> http://stackoverflow.com/questions/18682833/how-to-exclude-a-specific-application-from-action-view-intent
> http://stackoverflow.com/questions/29529027/open-url-in-browser-even-though-my-app-registered-an-intent-filter-for-it
> I think it might be reasonable for InAppBrowser, in {{openExternal}}, to
> explicitly remove the current app from the list.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14156) cordova-js browserify issues
[
https://issues.apache.org/jira/browse/CB-14156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619298#comment-16619298
]
ASF subversion and git services commented on CB-14156:
--
Commit 0b56cbc27bf580a63d11a6d8ed9c6fdb205dd829 in cordova-js's branch
refs/heads/master from [~brodybits]
[ https://gitbox.apache.org/repos/asf?p=cordova-js.git;h=0b56cbc ]
Merge pull request #162 from brodybits/cb-remove-browserify
[CB-14156] Remove browserify
> cordova-js browserify issues
>
>
> Key: CB-14156
> URL: https://issues.apache.org/jira/browse/CB-14156
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-js
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> I spotted the following issues with the way {{cordova-js}} uses
> {{browserify}}:
> * 1: duplicate source files in {{src}}: {{src/cordova_b.js}},
> {{src/common/modulemapper_b.js}},
> {{src/common/pluginloader_b.js}}, {{src/common/init_b.js}}, which only seem
> to be used by {{tasks/lib/bundle-browserify.js}}
> * 2: I have not been able to make a working {{browserify}} build.
> * 3: {{npm outdated}} shows {{browserify}} as outdated
> Another possible issue that I am not 100% sure about:
> * 4: {{browserify}} is listed as a {{dependencies}} item in {{package.json}}
> while I think it should have been listed as a {{devDependencies}} item
> I am very concerned that keeping duplicated source files may lead to old bugs
> including possible security issues leaking through the maintenance process in
> the future. The changes between the duplicated source files and the
> non-browserify versions are very limited so it should be possible to resolve
> this issue using very basic code techniques.
> I think the easiest solution would be to drop the browserify build/test
> target and remove the duplicated source files. I suspect that the browserify
> target has not been used for years.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618362#comment-16618362 ] ASF subversion and git services commented on CB-14166: -- Commit 7f795a05dfa7ab7fde317b0145b1215dacbd11a8 in cordova-lib's branch refs/heads/8.1.x from [~brodybits] [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=7f795a0 ] CB-14166 distinguish npm.cmd and npm.exe in win32 (#697) to check if escape is necessary (workaround solution in 8.1.x only) > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616774#comment-16616774 ] ASF subversion and git services commented on CB-14166: -- Commit e5695ccdd07312785b4d9036f6b01b8aa55d13ee in cordova-lib's branch refs/heads/cross-spawn-test from Almir Kadric [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=e5695cc ] CB-14166: (cli) Fixed issue when install plugins on windows The npm package name is already wrapped in quotes to prevent special characters from being execute. However the additional win32 code was further injecting quotes around the version causing npm to return a EINVALIDTAGNAME error. The win32 code is redundant and seems to not be required. > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611460#comment-16611460
]
ASF subversion and git services commented on CB-13685:
--
Commit d52d9982ad737ec02e4374e09f6d75f454db60b0 in cordova-docs's branch
refs/heads/master from エリス
[ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=d52d998 ]
CB-13685 android: Added adaptive icon docs (#830)
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10071) Proposal: feature to merge Swift bridging headers
[
https://issues.apache.org/jira/browse/CB-10071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611443#comment-16611443
]
ASF subversion and git services commented on CB-10071:
--
Commit 10b2f9cf18a6f77494f85e6e8bc7c5d8d75c193e in cordova-discuss's branch
refs/heads/master from [~knaito]
[ https://gitbox.apache.org/repos/asf?p=cordova-discuss.git;h=10b2f9c ]
CB-10071: (ios) Proposal swift support (#107)
* CB-10071: (ios) Proposal swift support
* Set status to completed
> Proposal: feature to merge Swift bridging headers
> -
>
> Key: CB-10071
> URL: https://issues.apache.org/jira/browse/CB-10071
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Reporter: Shazron Abdullah
>Priority: Major
> Labels: backlog
> Fix For: cordova-ios@5.0.0
>
>
> In cordova-ios-4.x we have a Bridging-Header.h file for Cordova classes, so
> this will enable Swift plugins.
> However, this is not adequate for Swift plugins that have to use third-party
> Objective-C libraries for their plugin itself. The plugins need to add the
> bridging headers to the app's Bridging-Header.h file (by appending to the
> file we already have).
> Firstly, we should never modify the app's Bridging-Header file, it should
> remain static (modifying this will be problematic for every `cordova prepare`
> cycle, for multiple plugins).
> We should have a feature to merge multiple bridging header files together,
> and point the SWIFT_OBJC_BRIDGING_HEADER value in build.xcconfig to it.
> An example of a Cordova plugin that has this problem:
> https://github.com/alongubkin/phonertc
> This could be an optional attribute in the `` tag in plugin.xml:
> https://cordova.apache.org/docs/en/4.0.0/plugin_ref/spec.html
> I propose something like-this:
> {code}
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10071) Proposal: feature to merge Swift bridging headers
[
https://issues.apache.org/jira/browse/CB-10071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611442#comment-16611442
]
ASF subversion and git services commented on CB-10071:
--
Commit 10b2f9cf18a6f77494f85e6e8bc7c5d8d75c193e in cordova-discuss's branch
refs/heads/master from [~knaito]
[ https://gitbox.apache.org/repos/asf?p=cordova-discuss.git;h=10b2f9c ]
CB-10071: (ios) Proposal swift support (#107)
* CB-10071: (ios) Proposal swift support
* Set status to completed
> Proposal: feature to merge Swift bridging headers
> -
>
> Key: CB-10071
> URL: https://issues.apache.org/jira/browse/CB-10071
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Reporter: Shazron Abdullah
>Priority: Major
> Labels: backlog
> Fix For: cordova-ios@5.0.0
>
>
> In cordova-ios-4.x we have a Bridging-Header.h file for Cordova classes, so
> this will enable Swift plugins.
> However, this is not adequate for Swift plugins that have to use third-party
> Objective-C libraries for their plugin itself. The plugins need to add the
> bridging headers to the app's Bridging-Header.h file (by appending to the
> file we already have).
> Firstly, we should never modify the app's Bridging-Header file, it should
> remain static (modifying this will be problematic for every `cordova prepare`
> cycle, for multiple plugins).
> We should have a feature to merge multiple bridging header files together,
> and point the SWIFT_OBJC_BRIDGING_HEADER value in build.xcconfig to it.
> An example of a Cordova plugin that has this problem:
> https://github.com/alongubkin/phonertc
> This could be an optional attribute in the `` tag in plugin.xml:
> https://cordova.apache.org/docs/en/4.0.0/plugin_ref/spec.html
> I propose something like-this:
> {code}
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14242) Remove bundledDependencies & committed node_modules from cordova-ios
[
https://issues.apache.org/jira/browse/CB-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611217#comment-16611217
]
ASF subversion and git services commented on CB-14242:
--
Commit 63f069f8bb318134cd6403b9929699f3290f5239 in cordova-ios's branch
refs/heads/master from Christopher J. Brody
[ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=63f069f ]
CB-14242 .gitignore completely ignore node_modules
> Remove bundledDependencies & committed node_modules from cordova-ios
>
>
> Key: CB-14242
> URL: https://issues.apache.org/jira/browse/CB-14242
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-ios
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> As described in parent task CB-14241: now that next major "-dev" release is
> marked (cordova-ios@5.0.0-dev) and CB-14074 (remove Node.js 4 from
> cordova-ios package.json & CI) is committed it is time to:
> * remove {{bundledDependencies}} entry from {{package.json}}
> * remove the committed {{node_modules}}
> * fix {{.gitignore}} to completely ignore {{node_modules}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14242) Remove bundledDependencies & committed node_modules from cordova-ios
[
https://issues.apache.org/jira/browse/CB-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611218#comment-16611218
]
ASF subversion and git services commented on CB-14242:
--
Commit ff1bcd05f419cd0a8a12006c9d512ef5c92b510f in cordova-ios's branch
refs/heads/master from [~dpogue]
[ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=ff1bcd0 ]
Merge pull request #388 from
brodybits/cb-14242-remove-bundled-dependencies-and-node-modules
CB-14242 remove bundledDependencies and committed node_modules
> Remove bundledDependencies & committed node_modules from cordova-ios
>
>
> Key: CB-14242
> URL: https://issues.apache.org/jira/browse/CB-14242
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-ios
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> As described in parent task CB-14241: now that next major "-dev" release is
> marked (cordova-ios@5.0.0-dev) and CB-14074 (remove Node.js 4 from
> cordova-ios package.json & CI) is committed it is time to:
> * remove {{bundledDependencies}} entry from {{package.json}}
> * remove the committed {{node_modules}}
> * fix {{.gitignore}} to completely ignore {{node_modules}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14242) Remove bundledDependencies & committed node_modules from cordova-ios
[
https://issues.apache.org/jira/browse/CB-14242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611216#comment-16611216
]
ASF subversion and git services commented on CB-14242:
--
Commit dd01952aadd985239c711901711b0ec5ccf979e3 in cordova-ios's branch
refs/heads/master from Christopher J. Brody
[ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=dd01952 ]
CB-14242 package.json remove bundledDependencies
> Remove bundledDependencies & committed node_modules from cordova-ios
>
>
> Key: CB-14242
> URL: https://issues.apache.org/jira/browse/CB-14242
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: cordova-ios
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> As described in parent task CB-14241: now that next major "-dev" release is
> marked (cordova-ios@5.0.0-dev) and CB-14074 (remove Node.js 4 from
> cordova-ios package.json & CI) is committed it is time to:
> * remove {{bundledDependencies}} entry from {{package.json}}
> * remove the committed {{node_modules}}
> * fix {{.gitignore}} to completely ignore {{node_modules}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.
[
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610940#comment-16610940
]
ASF subversion and git services commented on CB-13496:
--
Commit 9c6cda3db766c3daa87e8e4f8cc65e818a9e6dfc in cordova-common's branch
refs/heads/master from [~dpogue]
[ https://gitbox.apache.org/repos/asf?p=cordova-common.git;h=9c6cda3 ]
CB-13496: Fix greedy regex in plist-helpers
> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Ken Naito
>Priority: Trivial
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14108) in config.xml increases config_munge count in ios.json and android.json.
[
https://issues.apache.org/jira/browse/CB-14108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610937#comment-16610937
]
ASF subversion and git services commented on CB-14108:
--
Commit ce3801a184d34cc4c3ea08aeecd159227c6ae9e9 in cordova-common's branch
refs/heads/master from [~knaito]
[ https://gitbox.apache.org/repos/asf?p=cordova-common.git;h=ce3801a ]
CB-14108: fix incorrect count in config_munge in ios.json and android.json
* Fix to cordova prepare increment count at config_munge in platformJson
* Fix to cordova prepare when remove config-file case
> in config.xml increases config_munge count in ios.json and
> android.json.
> --
>
> Key: CB-14108
> URL: https://issues.apache.org/jira/browse/CB-14108
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common, cordova-lib
>Affects Versions: 8.0.0
>Reporter: Ken Naito
>Priority: Major
> Fix For: Master
>
>
> On both iOS and Android platforms, using causes duplication in
> the `ios.json` and `android.json` files, which could lead to extremely large
> file sizes (and possibly unexpected behaviour?).
> For a Cordova 7.1/8.0 application, add the following to config.xml:
>
> {code:java}
>
>
>
>
> Please permit Camera!
>
>
> {code}
> Now run `cordova prepare`. The file `platforms/ios/ios.json` now contains the
> below. Note the count is 1.
>
> {code:java}
> "config_munge": {
> "files": {
> "*-Info.plist": {
> "parents": {
> "NSCameraUsageDescription": [
> {
> "xml": "Please permit Camera!",
> "count": 1
> }
> ]
> }
> }
> }
> },
> {code}
> Run `cordova prepare` again. The platforms/ios/ios.json changes, increasing
> the count to 2.
>
> {code:java}
> "config_munge": {
> "files": {
> "*-Info.plist": {
> "parents": {
> "NSCameraUsageDescription": [
> {
> "xml": "Please permit Camera!",
> "count": 2
> }
> ]
> }
> }
> }
> },
> {code}
> Furthermore, if we change the text inside the `` in the `config.xml`:
> {code:java}
>
>
>
>
> This app uses Camera!
>
>
> {code}
> Then after running `cordova prepare`, there is now a second entry in
> `platforms/ios/ios.json`, rather than replacing the existing entry.
>
> {code:java}
> "config_munge": {
> "files": {
> "*-Info.plist": {
> "parents": {
> "NSCameraUsageDescription": [
> {
> "xml": "Please permit Camera!",
> "count": 2
> },
> {
> "xml": "This app uses Camera!",
> "count": 1
> }
> ]
> }
> }
> }
> },
> {code}
> This behaviour is the same for Android, and can be reproduced in the same
> way, by adding something like the below to `config.xml`:
> {code:java}
>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14073) Remove Node 4 from CI - cordova-browser
[ https://issues.apache.org/jira/browse/CB-14073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610660#comment-16610660 ] ASF subversion and git services commented on CB-14073: -- Commit ffdc001f943baf5aff70cd51a50c852ec7539ff8 in cordova-browser's branch refs/heads/master from エリス [ https://gitbox.apache.org/repos/asf?p=cordova-browser.git;h=ffdc001 ] CB-14073 browser: Drop Node 4, Added Node 10 > Remove Node 4 from CI - cordova-browser > --- > > Key: CB-14073 > URL: https://issues.apache.org/jira/browse/CB-14073 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-browser >Reporter: Darryl Pogue >Assignee: Bryan Ellis >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
