[jira] [Resolved] (CB-13624) Review and revise contribs docs
[ https://issues.apache.org/jira/browse/CB-13624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So resolved CB-13624. Resolution: Fixed > Review and revise contribs docs > --- > > Key: CB-13624 > URL: https://issues.apache.org/jira/browse/CB-13624 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-coho, cordova-docs >Reporter: Audrey So >Assignee: Audrey So > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13057) Remove cordova platform save command
[ https://issues.apache.org/jira/browse/CB-13057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-13057. -- Resolution: Fixed > Remove cordova platform save command > > > Key: CB-13057 > URL: https://issues.apache.org/jira/browse/CB-13057 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: cordova@8 >Reporter: Steve Gill >Assignee: Audrey So > Labels: backlog, tools-next > Fix For: cordova@8 > > > With autosaving now in place, we don't need `cordova platform save` anymore. > By removing this command, we can also remove > cordovaProject/platforms/platforms.json & > cordova-lib/src/cordova/platform_metadata.js > Deprecation notice will be added to cordova platform save until save command > is removed in cordova@8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13056) Remove non platform-API platforms
[ https://issues.apache.org/jira/browse/CB-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-13056. -- Resolution: Fixed > Remove non platform-API platforms > - > > Key: CB-13056 > URL: https://issues.apache.org/jira/browse/CB-13056 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Audrey So > Labels: tools-next > Fix For: cordova-8 > > > In the next major version of cordova, we should drop all platforms that > haven't updated to platformAPI > This includes older browser platforms, webos, blackberry and ubuntu > We can remove the parsers for these files + the platformAPI polyfill and any > other files that these platforms use -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-12807) Improve error message for bad templates when using cordova create --template
[ https://issues.apache.org/jira/browse/CB-12807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-12807. -- Resolution: Fixed > Improve error message for bad templates when using cordova create --template > > > Key: CB-12807 > URL: https://issues.apache.org/jira/browse/CB-12807 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-create >Affects Versions: 1.1.1 >Reporter: Steve Gill >Assignee: Audrey So > Labels: cordova-8.0.0, triaged > > right now, we don't handle the error very well when you are using a invalid > template during cordova create --template sometemplate. We just spew out the > npm stack. It would be better if we could catch the error and provide a nicer > message to our users. Something along the lines of the template is invalid. > Make sure you follow the template guide when creating a template. (link to > template guide). Templates now require a package.json. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13532) Cordova fails to find platform/plugin versions in package.json devDependencies
[
https://issues.apache.org/jira/browse/CB-13532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So closed CB-13532.
--
Resolution: Fixed
> Cordova fails to find platform/plugin versions in package.json devDependencies
> --
>
> Key: CB-13532
> URL: https://issues.apache.org/jira/browse/CB-13532
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Reporter: Darryl Pogue
>Assignee: Audrey So
> Labels: tools-next
>
> Cordova only looks at the {{dependencies}} section of package.json, and
> ignores anything specified in {{devDependencies}}. This results in the
> default pinned versions for platforms/plugins being used.
> Code in question:
> https://github.com/apache/cordova-lib/blob/da8ebf6cb81dd84c22e24fdf0baff9837a544b2d/src/cordova/platform/addHelper.js#L109-L113
> This is wrong because Cordova (and its related bits) is not a dependency of
> my application code, it is a build tool that belongs in devDependencies.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-12361. -- Resolution: Fixed > Speed up cordova-lib tests > -- > > Key: CB-12361 > URL: https://issues.apache.org/jira/browse/CB-12361 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Steve Gill > Labels: cordova-next > > * Split out e2e tests into own folder > * stub i/o and network requests > * use local fixtures when possible & makes sense -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-12810) keep existing formatting in package.json
[ https://issues.apache.org/jira/browse/CB-12810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-12810. -- Resolution: Fixed > keep existing formatting in package.json > > > Key: CB-12810 > URL: https://issues.apache.org/jira/browse/CB-12810 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: 7.0.0 >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: backlog, cordova-8.0.0, cordova-next, tools-next > > We will write our own indentation in package.json. For commands that shell > out to cordova-fetch and therefore npm, we have no control over it (cordova > platform/plugin add/rm). > We could theoretically keep indentaiton for commands where we write to > package.json (also platform/plugin add/rm to cordova key & during restore > when we sync config.xml & package.json). > This issue is probably not worth implementing. > npm@5 seems like it will respect existing formatting. > Previous issue with npm formatting: https://github.com/npm/npm/issues/5694 > npm5 respecting indentation: https://github.com/npm/npm/issues/16244 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13624) Review and revise contribs docs
[ https://issues.apache.org/jira/browse/CB-13624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13624: --- Component/s: cordova-docs > Review and revise contribs docs > --- > > Key: CB-13624 > URL: https://issues.apache.org/jira/browse/CB-13624 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-coho, cordova-docs >Reporter: Audrey So >Assignee: Audrey So > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13624) Review and revise contribs docs
Audrey So created CB-13624: -- Summary: Review and revise contribs docs Key: CB-13624 URL: https://issues.apache.org/jira/browse/CB-13624 Project: Apache Cordova Issue Type: Improvement Components: cordova-coho Reporter: Audrey So Assignee: Audrey So -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code
[ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267177#comment-16267177 ] Audrey So commented on CB-13055: Also removing registry code > remove --nofetch option and all old fetching code > - > > Key: CB-13055 > URL: https://issues.apache.org/jira/browse/CB-13055 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@8 > > > Cordova uses cordova-fetch for fetching modules by default now. In the next > major version, lets drop the older methods. This is great for reducing > maintenance in cordova. Original fetch proposal is at > https://github.com/cordova/cordova-discuss/pull/33 > remove --nofetch option > remove lazy_load > remove gitclone.js > remove npm dependency > remove remoteload.js > update anywhere that these files are used > Proposal: https://github.com/apache/cordova-discuss/pull/76 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13485) Not tested against Node 8
[ https://issues.apache.org/jira/browse/CB-13485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-13485. -- Resolution: Fixed > Not tested against Node 8 > - > > Key: CB-13485 > URL: https://issues.apache.org/jira/browse/CB-13485 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Jarrad Whitaker >Priority: Minor > Labels: test > > Tests aren't run against Node 8 in travis. > This is a slight problem as a couple of them fail for trivial reasons (error > string matching). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13331) Update jira-triage.md in cordova-coho to include necessary labels
[ https://issues.apache.org/jira/browse/CB-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-13331. -- Resolution: Fixed > Update jira-triage.md in cordova-coho to include necessary labels > - > > Key: CB-13331 > URL: https://issues.apache.org/jira/browse/CB-13331 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-coho >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > Labels: easy-fix, in-progress > > Revise and add in additional labels to use when triaging -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13543: --- Description: Automate build/deploy for cordova-docs Cordova-docs should be built and published automatically on every change Replace jsihnt with eslint Update README.md & update instructions in docs to reflect changes https://issues.apache.org/jira/browse/CB-13162 was: Automate build/deploy for cordova-docs Cordova-docs should be built and published automatically on every change Replace jsihnt with eslint Update README.md https://issues.apache.org/jira/browse/CB-13162 > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md & update instructions in docs to reflect changes > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13562) Asset tag creates a directory with same name of targeted file
[
https://issues.apache.org/jira/browse/CB-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So resolved CB-13562.
Resolution: Fixed
> Asset tag creates a directory with same name of targeted file
> -
>
> Key: CB-13562
> URL: https://issues.apache.org/jira/browse/CB-13562
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser
>Affects Versions: 5.0.1
>Reporter: Simon MacDonald
>Assignee: Jesse MacFadyen
> Labels: reproduced, triaged
>
> Asset tag appears to be broken in the browser platform. According to the docs
> at http://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#asset when
> you add an asset tag like:
> {code:xml}
>
> {code}
> it should copy www/foo.js to platforms/browser/www/foo.js but instead it
> creates a subdirectory called foo.js and the full path to the file is
> platforms/browser/www/foo.js/foo.js.
> If you want to duplicate this issue please create a new project then:
> cordova platform add browser@5.0.1
> cordova plugin add phonegap-plugin-push
> cordova build browser
> then you will see that
> platforms/browser/www/ServiceWorker.js/ServiceWorker.js exists when it should
> be platforms/browser/www/ServiceWorker.js.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-12381) Cordova's prepare command does not work reliably when it comes to restoring the platforms & plugins via config.xml
[
https://issues.apache.org/jira/browse/CB-12381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248220#comment-16248220
]
Audrey So edited comment on CB-12381 at 11/11/17 12:18 AM:
---
Hi Manuel ! Thank you for taking the time to write out the steps with images to
help us try and reproduce your issue.
I was not able to reproduce your issue. Please update to use the latest version
of cordova
npm install -g cordova@latest. Thanks!
- Audrey
was (Author: auso):
Hi Manuel ! Thank you for taking the time to write out the steps with images to
help us try and reproduce your issue.
I was not able to reproduce your issue. Please update to use the latest version
of cordova
```npm install -g cordova@latest```. Thanks!
- Audrey
> Cordova's prepare command does not work reliably when it comes to restoring
> the platforms & plugins via config.xml
> --
>
> Key: CB-12381
> URL: https://issues.apache.org/jira/browse/CB-12381
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli, cordova-ios
>Affects Versions: 6.4.0
> Environment: macOS Sierra 10.12.2, current versions of cordova and
> cordova-ios
>Reporter: Manuel Rauber
> Labels: cordova-8.0.0
> Attachments: Result of Step 10.png, Result of Step 13.png
>
>
> Howdy,
> I just figured out, that the cordova prepare command does not work reliably
> when it restores everything from the config.xml.
> *Steps to reproduce*
> # Install cordova via {{npm install cordova}} into an empty folder
> # Run {{$(npm bin)/cordova create sampleProject}} to create a new cordova
> project
> # Open the folder {{sampleProject}}
> # Run {{$(npm bin)/cordova platform add ios --save}} to add ios
> # Run {{$(npm bin)/cordova plugin add cordova-plugin-statusbar --save}} to
> add the status bar plugin
> # Open the {{config.xml}} and add this before the last closing tag:
> {{}}
> # Remove the folders {{platform}} and {{plugins}}. Now you have a project,
> which you normally check in into your source control system, since cordova is
> able to restore everything from config.xml
> # Run {{$(npm bin)/cordova prepare}} to restore
> # Open {{platforms/ios/HelloCordova.xcodeproj}} in XCode
> # Start it (simulator is ok)
> # Notice, that the status bar *does* overlay the WebView
> # Run {{$(npm bin)/cordova prepare}} again
> # Start the project in XCode again
> # Notice, that the status bar *does not* overlay the WebView
> *What happened?*
> In step 8 the file {{platforms/ios/HelloCordova/config.xml}} was created by
> cordova looking like that:
> {code:xml}
>
> xmlns="http://www.w3.org/ns/widgets;
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> HelloCordova
>
> A sample Apache Cordova application that responds to the deviceready
> event.
>
> http://cordova.io;>
> Apache Cordova Team
>
>
>
> http://*/*; />
> https://*/*; />
>
>
> mailto:*; />
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> {code}
> But, if you run the prepare command another time (which we did in step 12)
> the file looks like this:
> {code:xml}
>
> xmlns="http://www.w3.org/ns/widgets;
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> HelloCordova
>
> A sample Apache Cordova application that responds to the deviceready
> event.
>
> http://cordova.io;>
> Apache Cordova Team
>
>
>
> http://*/*; />
> https://*/*; />
>
>
> mailto:*; />
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> {code}
> Please note two things: The first is, that {{}} has
> been moved to the top in the second file. *But* in the first file (so after
> the first time {{prepare}}) the setting {{StatusBarOverlaysWebView}} has been
> defined twice. The first time with value {{false}} what we actually want and
> the second time with value {{true}}, which we don't want, but is the default
> of the plugin. For sure, this second setting overwrites the value we want to
> have.
> The second {{prepare}} command then *removes* the setting with the value
> {{true}}, so the config.xml has that setting only once with the value we
> want.
--
This message was sent by Atlassian JIRA
[jira] [Commented] (CB-12381) Cordova's prepare command does not work reliably when it comes to restoring the platforms & plugins via config.xml
[
https://issues.apache.org/jira/browse/CB-12381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248220#comment-16248220
]
Audrey So commented on CB-12381:
Hi Manuel ! Thank you for taking the time to write out the steps with images to
help us try and reproduce your issue.
I was not able to reproduce your issue. Please update to use the latest version
of cordova
`npm install -g cordova@latest`. Thanks!
- Audrey
> Cordova's prepare command does not work reliably when it comes to restoring
> the platforms & plugins via config.xml
> --
>
> Key: CB-12381
> URL: https://issues.apache.org/jira/browse/CB-12381
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli, cordova-ios
>Affects Versions: 6.4.0
> Environment: macOS Sierra 10.12.2, current versions of cordova and
> cordova-ios
>Reporter: Manuel Rauber
> Labels: cordova-8.0.0
> Attachments: Result of Step 10.png, Result of Step 13.png
>
>
> Howdy,
> I just figured out, that the cordova prepare command does not work reliably
> when it restores everything from the config.xml.
> *Steps to reproduce*
> # Install cordova via {{npm install cordova}} into an empty folder
> # Run {{$(npm bin)/cordova create sampleProject}} to create a new cordova
> project
> # Open the folder {{sampleProject}}
> # Run {{$(npm bin)/cordova platform add ios --save}} to add ios
> # Run {{$(npm bin)/cordova plugin add cordova-plugin-statusbar --save}} to
> add the status bar plugin
> # Open the {{config.xml}} and add this before the last closing tag:
> {{}}
> # Remove the folders {{platform}} and {{plugins}}. Now you have a project,
> which you normally check in into your source control system, since cordova is
> able to restore everything from config.xml
> # Run {{$(npm bin)/cordova prepare}} to restore
> # Open {{platforms/ios/HelloCordova.xcodeproj}} in XCode
> # Start it (simulator is ok)
> # Notice, that the status bar *does* overlay the WebView
> # Run {{$(npm bin)/cordova prepare}} again
> # Start the project in XCode again
> # Notice, that the status bar *does not* overlay the WebView
> *What happened?*
> In step 8 the file {{platforms/ios/HelloCordova/config.xml}} was created by
> cordova looking like that:
> {code:xml}
>
> xmlns="http://www.w3.org/ns/widgets;
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> HelloCordova
>
> A sample Apache Cordova application that responds to the deviceready
> event.
>
> http://cordova.io;>
> Apache Cordova Team
>
>
>
> http://*/*; />
> https://*/*; />
>
>
> mailto:*; />
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> {code}
> But, if you run the prepare command another time (which we did in step 12)
> the file looks like this:
> {code:xml}
>
> xmlns="http://www.w3.org/ns/widgets;
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> HelloCordova
>
> A sample Apache Cordova application that responds to the deviceready
> event.
>
> http://cordova.io;>
> Apache Cordova Team
>
>
>
> http://*/*; />
> https://*/*; />
>
>
> mailto:*; />
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> {code}
> Please note two things: The first is, that {{}} has
> been moved to the top in the second file. *But* in the first file (so after
> the first time {{prepare}}) the setting {{StatusBarOverlaysWebView}} has been
> defined twice. The first time with value {{false}} what we actually want and
> the second time with value {{true}}, which we don't want, but is the default
> of the plugin. For sure, this second setting overwrites the value we want to
> have.
> The second {{prepare}} command then *removes* the setting with the value
> {{true}}, so the config.xml has that setting only once with the value we
> want.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-12381) Cordova's prepare command does not work reliably when it comes to restoring the platforms & plugins via config.xml
[
https://issues.apache.org/jira/browse/CB-12381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248220#comment-16248220
]
Audrey So edited comment on CB-12381 at 11/11/17 12:18 AM:
---
Hi Manuel ! Thank you for taking the time to write out the steps with images to
help us try and reproduce your issue.
I was not able to reproduce your issue. Please update to use the latest version
of cordova
```npm install -g cordova@latest```. Thanks!
- Audrey
was (Author: auso):
Hi Manuel ! Thank you for taking the time to write out the steps with images to
help us try and reproduce your issue.
I was not able to reproduce your issue. Please update to use the latest version
of cordova
`npm install -g cordova@latest`. Thanks!
- Audrey
> Cordova's prepare command does not work reliably when it comes to restoring
> the platforms & plugins via config.xml
> --
>
> Key: CB-12381
> URL: https://issues.apache.org/jira/browse/CB-12381
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli, cordova-ios
>Affects Versions: 6.4.0
> Environment: macOS Sierra 10.12.2, current versions of cordova and
> cordova-ios
>Reporter: Manuel Rauber
> Labels: cordova-8.0.0
> Attachments: Result of Step 10.png, Result of Step 13.png
>
>
> Howdy,
> I just figured out, that the cordova prepare command does not work reliably
> when it restores everything from the config.xml.
> *Steps to reproduce*
> # Install cordova via {{npm install cordova}} into an empty folder
> # Run {{$(npm bin)/cordova create sampleProject}} to create a new cordova
> project
> # Open the folder {{sampleProject}}
> # Run {{$(npm bin)/cordova platform add ios --save}} to add ios
> # Run {{$(npm bin)/cordova plugin add cordova-plugin-statusbar --save}} to
> add the status bar plugin
> # Open the {{config.xml}} and add this before the last closing tag:
> {{}}
> # Remove the folders {{platform}} and {{plugins}}. Now you have a project,
> which you normally check in into your source control system, since cordova is
> able to restore everything from config.xml
> # Run {{$(npm bin)/cordova prepare}} to restore
> # Open {{platforms/ios/HelloCordova.xcodeproj}} in XCode
> # Start it (simulator is ok)
> # Notice, that the status bar *does* overlay the WebView
> # Run {{$(npm bin)/cordova prepare}} again
> # Start the project in XCode again
> # Notice, that the status bar *does not* overlay the WebView
> *What happened?*
> In step 8 the file {{platforms/ios/HelloCordova/config.xml}} was created by
> cordova looking like that:
> {code:xml}
>
> xmlns="http://www.w3.org/ns/widgets;
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> HelloCordova
>
> A sample Apache Cordova application that responds to the deviceready
> event.
>
> http://cordova.io;>
> Apache Cordova Team
>
>
>
> http://*/*; />
> https://*/*; />
>
>
> mailto:*; />
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> {code}
> But, if you run the prepare command another time (which we did in step 12)
> the file looks like this:
> {code:xml}
>
> xmlns="http://www.w3.org/ns/widgets;
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> HelloCordova
>
> A sample Apache Cordova application that responds to the deviceready
> event.
>
> http://cordova.io;>
> Apache Cordova Team
>
>
>
> http://*/*; />
> https://*/*; />
>
>
> mailto:*; />
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> {code}
> Please note two things: The first is, that {{}} has
> been moved to the top in the second file. *But* in the first file (so after
> the first time {{prepare}}) the setting {{StatusBarOverlaysWebView}} has been
> defined twice. The first time with value {{false}} what we actually want and
> the second time with value {{true}}, which we don't want, but is the default
> of the plugin. For sure, this second setting overwrites the value we want to
> have.
> The second {{prepare}} command then *removes* the setting with the value
> {{true}}, so the config.xml has that setting only once with the value we
> want.
--
This message was sent by Atlassian JIRA
[jira] [Updated] (CB-13562) Asset tag creates a directory with same name of targeted file
[
https://issues.apache.org/jira/browse/CB-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So updated CB-13562:
---
Labels: reproduced triaged (was: )
> Asset tag creates a directory with same name of targeted file
> -
>
> Key: CB-13562
> URL: https://issues.apache.org/jira/browse/CB-13562
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser
>Affects Versions: 5.0.1
>Reporter: Simon MacDonald
>Assignee: Jesse MacFadyen
> Labels: reproduced, triaged
>
> Asset tag appears to be broken in the browser platform. According to the docs
> at http://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#asset when
> you add an asset tag like:
> {code:xml}
>
> {code}
> it should copy www/foo.js to platforms/browser/www/foo.js but instead it
> creates a subdirectory called foo.js and the full path to the file is
> platforms/browser/www/foo.js/foo.js.
> If you want to duplicate this issue please create a new project then:
> cordova platform add browser@5.0.1
> cordova plugin add phonegap-plugin-push
> cordova build browser
> then you will see that
> platforms/browser/www/ServiceWorker.js/ServiceWorker.js exists when it should
> be platforms/browser/www/ServiceWorker.js.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13543: --- Description: Automate build/deploy for cordova-docs Cordova-docs should be built and published automatically on every change Replace jsihnt with eslint Update README.md https://issues.apache.org/jira/browse/CB-13162 was: Automate build/deploy for cordova-docs Cordova-docs should be built and published automatically on every change Update README.md https://issues.apache.org/jira/browse/CB-13162 > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Replace jsihnt with eslint > Update README.md > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13532) Cordova fails to find platform/plugin versions in package.json devDependencies
[
https://issues.apache.org/jira/browse/CB-13532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So reassigned CB-13532:
--
Assignee: Audrey So
> Cordova fails to find platform/plugin versions in package.json devDependencies
> --
>
> Key: CB-13532
> URL: https://issues.apache.org/jira/browse/CB-13532
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Reporter: Darryl Pogue
>Assignee: Audrey So
> Labels: tools-next
>
> Cordova only looks at the {{dependencies}} section of package.json, and
> ignores anything specified in {{devDependencies}}. This results in the
> default pinned versions for platforms/plugins being used.
> Code in question:
> https://github.com/apache/cordova-lib/blob/da8ebf6cb81dd84c22e24fdf0baff9837a544b2d/src/cordova/platform/addHelper.js#L109-L113
> This is wrong because Cordova (and its related bits) is not a dependency of
> my application code, it is a build tool that belongs in devDependencies.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-12810) keep existing formatting in package.json
[ https://issues.apache.org/jira/browse/CB-12810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So reassigned CB-12810: -- Assignee: Audrey So > keep existing formatting in package.json > > > Key: CB-12810 > URL: https://issues.apache.org/jira/browse/CB-12810 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Affects Versions: 7.0.0 >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: backlog, cordova-8.0.0, cordova-next, tools-next > > We will write our own indentation in package.json. For commands that shell > out to cordova-fetch and therefore npm, we have no control over it (cordova > platform/plugin add/rm). > We could theoretically keep indentaiton for commands where we write to > package.json (also platform/plugin add/rm to cordova key & during restore > when we sync config.xml & package.json). > This issue is probably not worth implementing. > npm@5 seems like it will respect existing formatting. > Previous issue with npm formatting: https://github.com/npm/npm/issues/5694 > npm5 respecting indentation: https://github.com/npm/npm/issues/16244 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13293) already fetched platforms shouldn't call fetch code
[ https://issues.apache.org/jira/browse/CB-13293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So reassigned CB-13293: -- Assignee: Audrey So > already fetched platforms shouldn't call fetch code > --- > > Key: CB-13293 > URL: https://issues.apache.org/jira/browse/CB-13293 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill >Assignee: Audrey So > Labels: tools-next > Fix For: cordova@7.1.0 > > > adding a platform that has already been added/fetched will still call > cordova-fetch before realizing the platform is already installed. Need to > check if platform is added first. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13543: --- Labels: enhancement feature in-progress optimization (was: enhancement feature optimization) > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, in-progress, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Update README.md > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13543: --- Description: Automate build/deploy for cordova-docs Cordova-docs should be built and published automatically on every change Update README.md https://issues.apache.org/jira/browse/CB-13162 was: Automate build/deploy for cordova-docs Cordova-docs should be built and published automatically on every change https://issues.apache.org/jira/browse/CB-13162 > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > Update README.md > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13162) cordova-docs should be built and published automatically on every change
[ https://issues.apache.org/jira/browse/CB-13162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-13162. -- Resolution: Duplicate > cordova-docs should be built and published automatically on every change > > > Key: CB-13162 > URL: https://issues.apache.org/jira/browse/CB-13162 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Filip Maj > Labels: backlog > > I would like to see the docs have better automation. > My ideal situation (and I don't think this is outside the realm of > possibility) is that, on every change to cordova-docs: > * the sources in crowdin are automatically updated (the crowdin GitHub > integration does all of this work for us) > * the cordova-docs get automatically built into a publish-ready state > * any languages in crowdin that have close-to-100% translation are pulled in > and integrated into the built docs > * the built + translation-integrated docs are finally pushed/published so > that docs.cordova.io is updated automatically. > We should also document this in the README if we ever get around to this > issue :) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13543: --- Description: Automate build/deploy for cordova-docs Cordova-docs should be built and published automatically on every change https://issues.apache.org/jira/browse/CB-13162 was: Automate build/deploy for cordova-docs Cordova-docs should be built and published automatically on every change > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change > https://issues.apache.org/jira/browse/CB-13162 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So reassigned CB-13543: -- Assignee: Audrey So > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So >Assignee: Audrey So > Labels: enhancement, feature, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13162) cordova-docs should be built and published automatically on every change
[ https://issues.apache.org/jira/browse/CB-13162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242635#comment-16242635 ] Audrey So commented on CB-13162: This is a duplicate issue. Closing this one and using --> https://issues.apache.org/jira/browse/CB-13543 Thanks! > cordova-docs should be built and published automatically on every change > > > Key: CB-13162 > URL: https://issues.apache.org/jira/browse/CB-13162 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Filip Maj > Labels: backlog > > I would like to see the docs have better automation. > My ideal situation (and I don't think this is outside the realm of > possibility) is that, on every change to cordova-docs: > * the sources in crowdin are automatically updated (the crowdin GitHub > integration does all of this work for us) > * the cordova-docs get automatically built into a publish-ready state > * any languages in crowdin that have close-to-100% translation are pulled in > and integrated into the built docs > * the built + translation-integrated docs are finally pushed/published so > that docs.cordova.io is updated automatically. > We should also document this in the README if we ever get around to this > issue :) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13543) Automate build/deploy for cordova-docs
[ https://issues.apache.org/jira/browse/CB-13543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13543: --- Description: Automate build/deploy for cordova-docs Cordova-docs should be built and published automatically on every change was:Automate build/deploy for cordova-docs > Automate build/deploy for cordova-docs > -- > > Key: CB-13543 > URL: https://issues.apache.org/jira/browse/CB-13543 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Audrey So > Labels: enhancement, feature, optimization > > Automate build/deploy for cordova-docs > Cordova-docs should be built and published automatically on every change -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13543) Automate build/deploy for cordova-docs
Audrey So created CB-13543: -- Summary: Automate build/deploy for cordova-docs Key: CB-13543 URL: https://issues.apache.org/jira/browse/CB-13543 Project: Apache Cordova Issue Type: Improvement Components: cordova-docs Reporter: Audrey So Automate build/deploy for cordova-docs -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13540) cordova-fetch npm install --production clobbers node_modules, causes workflow issues
[
https://issues.apache.org/jira/browse/CB-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240614#comment-16240614
]
Audrey So commented on CB-13540:
Hi! I have been trying to reproduce your issue, but haven't been able to so
far. What version of npm/node are you using? (npm -v, node -v). If you are able
to find steps to reproduce, please let me know. Thanks so much!
> cordova-fetch npm install --production clobbers node_modules, causes workflow
> issues
>
>
> Key: CB-13540
> URL: https://issues.apache.org/jira/browse/CB-13540
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch
>Reporter: Alex Matchneer
>Priority: Minor
> Labels: fetch, node_modules, npm
>
> I have tried and failed to provide a reproduction of this issue and have
> hence written/deleted/rewritten this issue many times without submitting, but
> now I'm going to just submit it, hope for feedback, and continue to try and
> reproduce:
> Basically, since this issue (https://issues.apache.org/jira/browse/CB-13303),
> cordova-fetch uses the `--production` flag with `npm install`, which tells
> npm not to install any "devDependencies".
> This seems like a sound approach, but for reasons that I can't reliably
> reproduced/put my finger on, it seems like this flag is also aggressively
> removing packages from `node_modules`, causing the following workflow issues:
> In my cordova project, I've added `cordova` as a dependency to package.json
> and encourage my teammates to use `./node_modules/.bin/cordova` rather than
> some globally installed `cordova` executable so that all dependencies are
> locked down and we don't have to fight the dependency hell of global CLI
> dependencies + local package.json dependencies.
> Now, when I freshly clone a repo, do an npm install, and then run
> `./node_modules/.bin/cordova prepare`, it will non-deterministically fail
> with the following output:
> {code}
> Discovered platform "ios@^4.5.3" in config.xml or package.json. Adding it to
> the project
> Using cordova-fetch for cordova-ios@^4.5.3
> Error: Failed to fetch platform cordova-ios@^4.5.3
> Probably this is either a connection problem, or platform spec is incorrect.
> Check your connection and platform name/version/URL.
> Failed to get absolute path to installed module
> Error: No platforms added to this project. Please use `cordova platform add
> `.
> {code}
> And when I look at node_modules, most of my dependencies have been deleted,
> and in particular, there's no more `node_modules/.bin/cordova` executable.
> My best guess is that the `npm install --production --no-save` that
> cordova-fetch internally does is nuking a bunch of dependencies considering
> "non-production", including the cli folder itself. The remedy is to use a
> globally installed cordova CLI executable, which somehow avoids these issues.
> Both my local and global cordova executables are 7.7.4.
> I will continue to try and provide a consistent reproduction of this issue;
> I've tried and failed many times and I'm starting to pull my hair out. I just
> wanted to officially post this issue in case other people have seen it, have
> advice, or have had better luck reproducing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13501) Update cordova repos to also use node 8
[ https://issues.apache.org/jira/browse/CB-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13501: --- Issue Type: Improvement (was: Bug) > Update cordova repos to also use node 8 > --- > > Key: CB-13501 > URL: https://issues.apache.org/jira/browse/CB-13501 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve >Affects Versions: cordova@7.1.0 >Reporter: Audrey So > > Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13485) Not tested against Node 8
[ https://issues.apache.org/jira/browse/CB-13485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234682#comment-16234682 ] Audrey So commented on CB-13485: Hi Jarrad! Thanks for your work on this. I actually fixed this with this PR --> CB-13501 --> https://github.com/apache/cordova-lib/pull/604/files (removing npm linking stuff) and also a fix/release of cordova-fetch@1.2.1 so there are no CI fails. It has been merged in so I think we can go ahead and close this issue. > Not tested against Node 8 > - > > Key: CB-13485 > URL: https://issues.apache.org/jira/browse/CB-13485 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Jarrad Whitaker >Priority: Minor > Labels: test > > Tests aren't run against Node 8 in travis. > This is a slight problem as a couple of them fail for trivial reasons (error > string matching). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13504) Cordova-Fetch Release 1.2.1 October 27, 2017
[ https://issues.apache.org/jira/browse/CB-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-13504. -- Resolution: Fixed > Cordova-Fetch Release 1.2.1 October 27, 2017 > > > Key: CB-13504 > URL: https://issues.apache.org/jira/browse/CB-13504 > Project: Apache Cordova > Issue Type: Task > Components: cordova-fetch >Reporter: Audrey So > Fix For: 1.2.1 > > > Following steps at: > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13514) in config.xml removes some XML elements added by plugins
[
https://issues.apache.org/jira/browse/CB-13514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So updated CB-13514:
---
Labels: reproduced triaged (was: )
> in config.xml removes some XML elements added by plugins
> --
>
> Key: CB-13514
> URL: https://issues.apache.org/jira/browse/CB-13514
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: cordova-android 6.3.0
>Reporter: Ibrahim M. Ghazal
> Labels: reproduced, triaged
>
> Adding {{}} to config.xml is removing some XML elements added by
> plugins. For example, {{cordova-plugin-file-opener2}} adds a {{}}
> element to AndroidManifest.xml. If I add an {{}} to config.xml
> that modifies AndroidManifest.xml, the {{}} element is removed on
> {{cordova (prepare|build|run) android}}
> To reproduce, create a cordova project with the following two files:
> package.json
> {code}
> {
> "name": "com.example.test",
> "displayName": "Test",
> "version": "1.0.0",
> "dependencies": {
> "cordova-android": "6.3.0",
> "cordova-plugin-file-opener2": "2.0.19"
> },
> "cordova": {
> "platforms": [
> "android"
> ],
> "plugins": {
> "cordova-plugin-file-opener2": {}
> }
> }
> }
> {code}
> config.xml
> {code}
>
> xmlns="http://www.w3.org/ns/widgets;
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> Test
>
>
> target="/manifest/application"
> xmlns:android="http://schemas.android.com/apk/res/android;>
>
>
>
>
>
>
> {code}
> Then run:
> $ npm install && cordova platform add android@6.3.0 --nosave
> [output omitted]
> $ cat ./platforms/android/AndroidManifest.xml
> {code}
>
> android:versionName="1.0.0" package="com.example.test"
> xmlns:android="http://schemas.android.com/apk/res/android;>
> android:normalScreens="true" android:resizeable="true"
> android:smallScreens="true" android:xlargeScreens="true" />
>
> android:hardwareAccelerated="true" android:icon="@mipmap/icon"
> android:label="@string/app_name" android:supportsRtl="true">
> android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale"
> android:label="@string/activity_name" android:launchMode="singleTop"
> android:name="MainActivity"
> android:theme="@android:style/Theme.DeviceDefault.NoActionBar"
> android:windowSoftInputMode="adjustResize">
>
>
>
>
>
> android:exported="false" android:grantUriPermissions="true"
> android:name="io.github.pwlin.cordova.plugins.fileopener2.FileProvider">
> android:resource="@xml/opener_paths" />
>
>
>
> />
>
> {code}
> $ cordova run android
> Conflict found, edit-config changes from config.xml will overwrite plugin.xml
> changes
> [rest of output omitted]
> $ cat ./platforms/android/AndroidManifest.xml
> {code}
>
> android:versionName="1.0.0" package="com.example.test"
> xmlns:android="http://schemas.android.com/apk/res/android;>
> android:normalScreens="true" android:resizeable="true"
> android:smallScreens="true" android:xlargeScreens="true" />
>
> android:hardwareAccelerated="true" android:icon="@mipmap/icon"
> android:label="@string/app_name" android:supportsRtl="true">
> android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale"
> android:label="@string/activity_name" android:launchMode="singleTop"
> android:name="MainActivity"
> android:theme="@android:style/Theme.DeviceDefault.NoActionBar"
> android:windowSoftInputMode="adjustResize">
>
>
>
>
>
>
>
> />
>
> {code}
> Note the missing {{}} element after running {{cordova run android}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.
[
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227070#comment-16227070
]
Audrey So commented on CB-13496:
Hi! Can you please provide steps so I can reproduce your issue? Also what
version of npm /node are you using? Thanks! (npm -v, node -v)
> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Kenichi Naito
>Priority: Trivial
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13484) Allow removing a whole XML element using
[
https://issues.apache.org/jira/browse/CB-13484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So updated CB-13484:
---
Labels: new-feature (was: )
> Allow removing a whole XML element using
> --
>
> Key: CB-13484
> URL: https://issues.apache.org/jira/browse/CB-13484
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-common
>Affects Versions: 2.1.1
>Reporter: Ibrahim M. Ghazal
> Labels: new-feature
>
> Currently, {{}} can only *add* an XML element to a config file,
> but not *remove* an element. {{}} can remove attributes from an
> element, but not whole elements.
> I'd like the ability to remove elements by adding something to {{config.xml}}
> instead of writing a hook.
> This is useful because some plugins include extra permissions which are not
> always needed (For example, {{cordova-plugin-file}} adds the
> {{WRITE_EXTERNAL_STORAGE}} permission, but not all apps that include
> {{cordova-plugin-file}} will actually write outside their data directory).
> Example syntax:
> {code}
> xmlns:android="http://schemas.android.com/apk/res/android;>
> />
>
> {code}
> (Note the {{mode="remove"}}, the default if absent should be "add")
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[ https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So resolved CB-13483. Resolution: Not A Problem > cordova add platform ios adds cordova-ios@4.4.0 not latest > -- > > Key: CB-13483 > URL: https://issues.apache.org/jira/browse/CB-13483 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Affects Versions: 7.0.1 >Reporter: Austin France > > $ cordova platform add ios --save > Using cordova-fetch for ios@~4.4.0 > It does this even when the engine setting for ios in config.xml is set to > 4.5.1. > To get version 4.5.1 (which contains important fixes) I have to remember to > $ cordova platform add ios@4.5.1 --save -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13478) Windows line endings in cordova-lib
[ https://issues.apache.org/jira/browse/CB-13478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So resolved CB-13478. Resolution: Fixed > Windows line endings in cordova-lib > --- > > Key: CB-13478 > URL: https://issues.apache.org/jira/browse/CB-13478 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: cordova@7.0.0 >Reporter: Jarrad Whitaker >Priority: Trivial > Labels: lint > Original Estimate: 1h > Remaining Estimate: 1h > > A few files in cordova-lib have snuck in with CRLFs. > I will open a pr with > - eslint set to error on crlfs > - gitattributes to prevent more crlfs > - files with crlf translated to lf -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13478) Windows line endings in cordova-lib
[ https://issues.apache.org/jira/browse/CB-13478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225272#comment-16225272 ] Audrey So commented on CB-13478: Closing this issue since it has been merged in. Thanks! > Windows line endings in cordova-lib > --- > > Key: CB-13478 > URL: https://issues.apache.org/jira/browse/CB-13478 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: cordova@7.0.0 >Reporter: Jarrad Whitaker >Priority: Trivial > Labels: lint > Original Estimate: 1h > Remaining Estimate: 1h > > A few files in cordova-lib have snuck in with CRLFs. > I will open a pr with > - eslint set to error on crlfs > - gitattributes to prevent more crlfs > - files with crlf translated to lf -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13504) Cordova-Fetch Release 1.2.1 October 27, 2017
[ https://issues.apache.org/jira/browse/CB-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13504: --- Fix Version/s: 1.2.1 > Cordova-Fetch Release 1.2.1 October 27, 2017 > > > Key: CB-13504 > URL: https://issues.apache.org/jira/browse/CB-13504 > Project: Apache Cordova > Issue Type: Task > Components: cordova-fetch >Reporter: Audrey So > Fix For: 1.2.1 > > > Following steps at: > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13504) Cordova-Fetch Release 1.2.1 October 27, 2017
Audrey So created CB-13504: -- Summary: Cordova-Fetch Release 1.2.1 October 27, 2017 Key: CB-13504 URL: https://issues.apache.org/jira/browse/CB-13504 Project: Apache Cordova Issue Type: Task Components: cordova-fetch Reporter: Audrey So Following steps at: https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13501) Update cordova repos to also use node 8
Audrey So created CB-13501: -- Summary: Update cordova repos to also use node 8 Key: CB-13501 URL: https://issues.apache.org/jira/browse/CB-13501 Project: Apache Cordova Issue Type: Bug Components: cordova-cli, cordova-common, cordova-fetch, cordova-serve Affects Versions: cordova@7.1.0 Reporter: Audrey So Update cordova repos to also use node 8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13492) Pass in the nosave flag to cordova-fetch & update uninstall to include nosave flag
[ https://issues.apache.org/jira/browse/CB-13492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-13492. -- Resolution: Fixed > Pass in the nosave flag to cordova-fetch & update uninstall to include nosave > flag > -- > > Key: CB-13492 > URL: https://issues.apache.org/jira/browse/CB-13492 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > > Make sure that the -nosave flag is passed in via cordova-fetch (when save is > false) > Add unit-test -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13492) Pass in the nosave flag to cordova-fetch & update uninstall to include nosave flag
[ https://issues.apache.org/jira/browse/CB-13492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13492: --- Summary: Pass in the nosave flag to cordova-fetch & update uninstall to include nosave flag (was: Pass in the nosave flag to cordova-fetch & update rm to include nosave flag) > Pass in the nosave flag to cordova-fetch & update uninstall to include nosave > flag > -- > > Key: CB-13492 > URL: https://issues.apache.org/jira/browse/CB-13492 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > > Make sure that the -nosave flag is passed in via cordova-fetch (when save is > false) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13492) Pass in the nosave flag to cordova-fetch & update uninstall to include nosave flag
[ https://issues.apache.org/jira/browse/CB-13492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13492: --- Description: Make sure that the -nosave flag is passed in via cordova-fetch (when save is false) Add unit-test was:Make sure that the -nosave flag is passed in via cordova-fetch (when save is false) > Pass in the nosave flag to cordova-fetch & update uninstall to include nosave > flag > -- > > Key: CB-13492 > URL: https://issues.apache.org/jira/browse/CB-13492 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > > Make sure that the -nosave flag is passed in via cordova-fetch (when save is > false) > Add unit-test -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13492) Pass in the nosave flag to cordova-fetch & update rm to include nosave flag
[ https://issues.apache.org/jira/browse/CB-13492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13492: --- Summary: Pass in the nosave flag to cordova-fetch & update rm to include nosave flag (was: Pass in the nosave flag to cordova-fetch) > Pass in the nosave flag to cordova-fetch & update rm to include nosave flag > --- > > Key: CB-13492 > URL: https://issues.apache.org/jira/browse/CB-13492 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > > Make sure that the -nosave flag is passed in via cordova-fetch (when save is > false) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13492) Pass in the nosave flag to cordova-fetch
Audrey So created CB-13492: -- Summary: Pass in the nosave flag to cordova-fetch Key: CB-13492 URL: https://issues.apache.org/jira/browse/CB-13492 Project: Apache Cordova Issue Type: Improvement Components: cordova-fetch Affects Versions: cordova@7.1.0 Reporter: Audrey So Assignee: Audrey So Priority: Minor Make sure that the -nosave flag is passed in via cordova-fetch (when save is false) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13463) No way to prevent package.json update with cordova commands even with --nosave
[
https://issues.apache.org/jira/browse/CB-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So reassigned CB-13463:
--
Assignee: Audrey So
> No way to prevent package.json update with cordova commands even with --nosave
> --
>
> Key: CB-13463
> URL: https://issues.apache.org/jira/browse/CB-13463
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
>Reporter: Andrew Crites
>Assignee: Audrey So
> Labels: reproduced, triaged
>
> With Cordova 7, cordova commands including {{cordova platform add}} and
> {{cordova prepare}} will copy plugin information from {{config.xml}} to
> {{package.json}}.
> According to [the saving platforms
> documentation|https://cordova.apache.org/docs/en/latest/platform_plugin_versioning_ref/],
> using {{--nosave}} should prevent updating {{package.json}} or
> {{config.xml}}, but this does not work (i.e. using {{--nosave}} still seems
> to update the {{package.json}}.
> I want to avoid updating {{package.json}} specifically because there doesn't
> seem to be a way to avoid hard coding variables for plugins. An example is
> the cordova fabric plugin:
> {code}
>
>
>
>
> {code}
> Cordova doesn't seem to provide a way for you to parameterize variables in
> the configuration. To get around this, I have {{build.config.xml}} where they
> are parameterized, and {{config.xml}} is created at install-time and not
> version controlled. However, this would be much more difficult to do with
> {{package.json}} and is practically not an option.
> When running {{cordova platform add ios --nosave}} with the above plugin,
> cordova still updates {{package.json}} to include the fabric plugin with the
> hard coded variables.
> * Cordova 6 question (with solution):
> https://stackoverflow.com/questions/37816035/using-environment-variables-parameterizing-config-xml
> * Cordova 7 question (no solution yet)
> https://stackoverflow.com/questions/46816928/parameterize-do-not-hard-code-variables-when-building-with-cordova-7
> Ideally {{--nosave}} would not update {{package.json}} as advertised. Even
> better, there should be a way to set up a cordova project so that any cordova
> commands do not save by default. This would prevent mistakes in a larger team
> and allow use of tools that wrap cordova such as ionic.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13463) No way to prevent package.json update with cordova commands even with --nosave
[
https://issues.apache.org/jira/browse/CB-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219156#comment-16219156
]
Audrey So commented on CB-13463:
Pull request has been merged to address this issue. Closing this issue #. Thank
you!
> No way to prevent package.json update with cordova commands even with --nosave
> --
>
> Key: CB-13463
> URL: https://issues.apache.org/jira/browse/CB-13463
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
>Reporter: Andrew Crites
> Labels: reproduced, triaged
>
> With Cordova 7, cordova commands including {{cordova platform add}} and
> {{cordova prepare}} will copy plugin information from {{config.xml}} to
> {{package.json}}.
> According to [the saving platforms
> documentation|https://cordova.apache.org/docs/en/latest/platform_plugin_versioning_ref/],
> using {{--nosave}} should prevent updating {{package.json}} or
> {{config.xml}}, but this does not work (i.e. using {{--nosave}} still seems
> to update the {{package.json}}.
> I want to avoid updating {{package.json}} specifically because there doesn't
> seem to be a way to avoid hard coding variables for plugins. An example is
> the cordova fabric plugin:
> {code}
>
>
>
>
> {code}
> Cordova doesn't seem to provide a way for you to parameterize variables in
> the configuration. To get around this, I have {{build.config.xml}} where they
> are parameterized, and {{config.xml}} is created at install-time and not
> version controlled. However, this would be much more difficult to do with
> {{package.json}} and is practically not an option.
> When running {{cordova platform add ios --nosave}} with the above plugin,
> cordova still updates {{package.json}} to include the fabric plugin with the
> hard coded variables.
> * Cordova 6 question (with solution):
> https://stackoverflow.com/questions/37816035/using-environment-variables-parameterizing-config-xml
> * Cordova 7 question (no solution yet)
> https://stackoverflow.com/questions/46816928/parameterize-do-not-hard-code-variables-when-building-with-cordova-7
> Ideally {{--nosave}} would not update {{package.json}} as advertised. Even
> better, there should be a way to set up a cordova project so that any cordova
> commands do not save by default. This would prevent mistakes in a larger team
> and allow use of tools that wrap cordova such as ionic.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13463) No way to prevent package.json update with cordova commands even with --nosave
[
https://issues.apache.org/jira/browse/CB-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So resolved CB-13463.
Resolution: Fixed
> No way to prevent package.json update with cordova commands even with --nosave
> --
>
> Key: CB-13463
> URL: https://issues.apache.org/jira/browse/CB-13463
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
>Reporter: Andrew Crites
> Labels: reproduced, triaged
>
> With Cordova 7, cordova commands including {{cordova platform add}} and
> {{cordova prepare}} will copy plugin information from {{config.xml}} to
> {{package.json}}.
> According to [the saving platforms
> documentation|https://cordova.apache.org/docs/en/latest/platform_plugin_versioning_ref/],
> using {{--nosave}} should prevent updating {{package.json}} or
> {{config.xml}}, but this does not work (i.e. using {{--nosave}} still seems
> to update the {{package.json}}.
> I want to avoid updating {{package.json}} specifically because there doesn't
> seem to be a way to avoid hard coding variables for plugins. An example is
> the cordova fabric plugin:
> {code}
>
>
>
>
> {code}
> Cordova doesn't seem to provide a way for you to parameterize variables in
> the configuration. To get around this, I have {{build.config.xml}} where they
> are parameterized, and {{config.xml}} is created at install-time and not
> version controlled. However, this would be much more difficult to do with
> {{package.json}} and is practically not an option.
> When running {{cordova platform add ios --nosave}} with the above plugin,
> cordova still updates {{package.json}} to include the fabric plugin with the
> hard coded variables.
> * Cordova 6 question (with solution):
> https://stackoverflow.com/questions/37816035/using-environment-variables-parameterizing-config-xml
> * Cordova 7 question (no solution yet)
> https://stackoverflow.com/questions/46816928/parameterize-do-not-hard-code-variables-when-building-with-cordova-7
> Ideally {{--nosave}} would not update {{package.json}} as advertised. Even
> better, there should be a way to set up a cordova project so that any cordova
> commands do not save by default. This would prevent mistakes in a larger team
> and allow use of tools that wrap cordova such as ionic.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[ https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219147#comment-16219147 ] Audrey So commented on CB-13483: Hi! I see you are using cordova@7.0.1. Please update to use cordova@7.1.0. It should work after you update. Please let me know the results. Thanks! > cordova add platform ios adds cordova-ios@4.4.0 not latest > -- > > Key: CB-13483 > URL: https://issues.apache.org/jira/browse/CB-13483 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Affects Versions: 7.0.1 >Reporter: Austin France > > $ cordova platform add ios --save > Using cordova-fetch for ios@~4.4.0 > It does this even when the engine setting for ios in config.xml is set to > 4.5.1. > To get version 4.5.1 (which contains important fixes) I have to remember to > $ cordova platform add ios@4.5.1 --save -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13486) adds duplicate element if the existing element has extra attributes
[
https://issues.apache.org/jira/browse/CB-13486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So updated CB-13486:
---
Labels: reproduced triaged (was: )
> adds duplicate element if the existing element has extra
> attributes
> -
>
> Key: CB-13486
> URL: https://issues.apache.org/jira/browse/CB-13486
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 2.1.1
>Reporter: Ibrahim M. Ghazal
> Labels: reproduced, triaged
>
> If {{}} tries to add an element to a config file, and that
> config file has the same element but with extra attributes, the element is
> added anyway. I expect it to consider it already existing and skip adding it.
> Example:
> 1. Add {{cordova-plugin-file}} plugin, which contains this line in
> {{plugin.xml}}:
> {code}
>
> />
>
> {code}
> 2. Since {{WRITE_EXTERNAL_STORAGE}} is not required on Android API 19+
> (Android 4.4+), I want to add {{android:maxSdkVersion="18"}} to the
> permission. So I add this to the app's {{config.xml}}
> {code}
> target="/manifest/uses-permission[@android:name='android.permission.WRITE_EXTERNAL_STORAGE']"
> xmlns:android="http://schemas.android.com/apk/res/android;>
> android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
>
> {code}
> 3. Run {{cordova run android}}. It succeeds the first time and the permission
> is modified correctly. {{AndroidManifest.xml}} now contains this:
> {code}
> android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
> {code}
> 3. Run {{cordova run android}} again. The {{}} from
> {{cordova-plugin-file}} is applied again. It searches for the exact element
> it wants to add and doesn't find it (because that element now has an extra
> attribute, {{android:maxSdkVersion}}), and so it adds it again.
> {{AndroidManifest.xml}} now contains this:
> {code}
> android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
>
> {code}
> This causes {{cordova run android}} to fail with:
> {code}
> Element uses-permission#android.permission.WRITE_EXTERNAL_STORAGE at
> AndroidManifest.xml:20:5-81 duplicated with element declared at
> AndroidManifest.xml:18:5-108
> See http://g.co/androidstudio/manifest-merger for more information about the
> manifest merger.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[ https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217211#comment-16217211 ] Audrey So commented on CB-13483: Hi! I am having difficulty reproducing your issue. What version of node/npm are you using? node -v npm -v Thank you! > cordova add platform ios adds cordova-ios@4.4.0 not latest > -- > > Key: CB-13483 > URL: https://issues.apache.org/jira/browse/CB-13483 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Affects Versions: 7.0.1 >Reporter: Austin France > > $ cordova platform add ios --save > Using cordova-fetch for ios@~4.4.0 > It does this even when the engine setting for ios in config.xml is set to > 4.5.1. > To get version 4.5.1 (which contains important fixes) I have to remember to > $ cordova platform add ios@4.5.1 --save -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13463) No way to prevent package.json update with cordova commands even with --nosave
[
https://issues.apache.org/jira/browse/CB-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So updated CB-13463:
---
Labels: reproduced triaged (was: )
> No way to prevent package.json update with cordova commands even with --nosave
> --
>
> Key: CB-13463
> URL: https://issues.apache.org/jira/browse/CB-13463
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
>Reporter: Andrew Crites
> Labels: reproduced, triaged
>
> With Cordova 7, cordova commands including {{cordova platform add}} and
> {{cordova prepare}} will copy plugin information from {{config.xml}} to
> {{package.json}}.
> According to [the saving platforms
> documentation|https://cordova.apache.org/docs/en/latest/platform_plugin_versioning_ref/],
> using {{--nosave}} should prevent updating {{package.json}} or
> {{config.xml}}, but this does not work (i.e. using {{--nosave}} still seems
> to update the {{package.json}}.
> I want to avoid updating {{package.json}} specifically because there doesn't
> seem to be a way to avoid hard coding variables for plugins. An example is
> the cordova fabric plugin:
> {code}
>
>
>
>
> {code}
> Cordova doesn't seem to provide a way for you to parameterize variables in
> the configuration. To get around this, I have {{build.config.xml}} where they
> are parameterized, and {{config.xml}} is created at install-time and not
> version controlled. However, this would be much more difficult to do with
> {{package.json}} and is practically not an option.
> When running {{cordova platform add ios --nosave}} with the above plugin,
> cordova still updates {{package.json}} to include the fabric plugin with the
> hard coded variables.
> * Cordova 6 question (with solution):
> https://stackoverflow.com/questions/37816035/using-environment-variables-parameterizing-config-xml
> * Cordova 7 question (no solution yet)
> https://stackoverflow.com/questions/46816928/parameterize-do-not-hard-code-variables-when-building-with-cordova-7
> Ideally {{--nosave}} would not update {{package.json}} as advertised. Even
> better, there should be a way to set up a cordova project so that any cordova
> commands do not save by default. This would prevent mistakes in a larger team
> and allow use of tools that wrap cordova such as ionic.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13414) Space in App name is gone on iOS 11
[ https://issues.apache.org/jira/browse/CB-13414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13414: --- Labels: ios11 (was: ) > Space in App name is gone on iOS 11 > --- > > Key: CB-13414 > URL: https://issues.apache.org/jira/browse/CB-13414 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 7.0.0 >Reporter: Dennis Patzer > Labels: ios11 > > For some odd reason the space in my app name is gone while deploying to iOS, > i.e. "My App" is transformed to "MyApp" :-( > Is it a bug? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13123) plugin add should use cordovaDependency instead of plugin.xml engine tag
[ https://issues.apache.org/jira/browse/CB-13123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So reassigned CB-13123: -- Assignee: Audrey So > plugin add should use cordovaDependency instead of plugin.xml engine tag > > > Key: CB-13123 > URL: https://issues.apache.org/jira/browse/CB-13123 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Steve Gill >Assignee: Audrey So > Labels: tools-next > Fix For: cordova@8 > > > We have been planning on switching from plugin.xml engine tag to > cordovaDependencies element in package.json when it comes to resolving > project dependencies during plugin add. > I suggest we update the code to use cordovaDependencies. Maybe we fallback on > plugin.xml engine element until we do a major cordova release where we drop > engine element fully. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13395) Add tests to cordova-common to test config and increase code coverage
[ https://issues.apache.org/jira/browse/CB-13395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209607#comment-16209607 ] Audrey So commented on CB-13395: Tests have been merged in with this PR/issue : https://issues.apache.org/jira/browse/CB-11244 > Add tests to cordova-common to test config and increase code coverage > - > > Key: CB-13395 > URL: https://issues.apache.org/jira/browse/CB-13395 > Project: Apache Cordova > Issue Type: Task > Components: cordova-common >Affects Versions: 7.0.0 >Reporter: Audrey So >Assignee: Audrey So > Labels: test > > Add tests to cordova-common to test config and increase code coverage -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13395) Add tests to cordova-common to test config and increase code coverage
[ https://issues.apache.org/jira/browse/CB-13395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13395: --- Description: Add tests to cordova-common to test config and increase code coverage (ConfigFile) (was: Add tests to cordova-common to test config and increase code coverage) > Add tests to cordova-common to test config and increase code coverage > - > > Key: CB-13395 > URL: https://issues.apache.org/jira/browse/CB-13395 > Project: Apache Cordova > Issue Type: Task > Components: cordova-common >Affects Versions: 7.0.0 >Reporter: Audrey So >Assignee: Audrey So > Labels: test > > Add tests to cordova-common to test config and increase code coverage > (ConfigFile) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13395) Add tests to cordova-common to test config and increase code coverage
[ https://issues.apache.org/jira/browse/CB-13395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So resolved CB-13395. Resolution: Fixed > Add tests to cordova-common to test config and increase code coverage > - > > Key: CB-13395 > URL: https://issues.apache.org/jira/browse/CB-13395 > Project: Apache Cordova > Issue Type: Task > Components: cordova-common >Affects Versions: 7.0.0 >Reporter: Audrey So >Assignee: Audrey So > Labels: test > > Add tests to cordova-common to test config and increase code coverage -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13055) remove --nofetch option and all old fetching code
[ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13055: --- Description: Cordova uses cordova-fetch for fetching modules by default now. In the next major version, lets drop the older methods. This is great for reducing maintenance in cordova. Original fetch proposal is at https://github.com/cordova/cordova-discuss/pull/33 remove --nofetch option remove lazy_load remove gitclone.js remove npm dependency remove remoteload.js update anywhere that these files are used Proposal: https://github.com/apache/cordova-discuss/pull/76 was: Cordova uses cordova-fetch for fetching modules by default now. In the next major version, lets drop the older methods. This is great for reducing maintenance in cordova. Original fetch proposal is at https://github.com/cordova/cordova-discuss/pull/33 remove --nofetch option remove lazy_load remove gitclone.js remove npm dependency remove remoteload.js update anywhere that these files are used > remove --nofetch option and all old fetching code > - > > Key: CB-13055 > URL: https://issues.apache.org/jira/browse/CB-13055 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Reporter: Steve Gill > Labels: backlog, tools-next > Fix For: cordova@8 > > > Cordova uses cordova-fetch for fetching modules by default now. In the next > major version, lets drop the older methods. This is great for reducing > maintenance in cordova. Original fetch proposal is at > https://github.com/cordova/cordova-discuss/pull/33 > remove --nofetch option > remove lazy_load > remove gitclone.js > remove npm dependency > remove remoteload.js > update anywhere that these files are used > Proposal: https://github.com/apache/cordova-discuss/pull/76 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13395) Add tests to cordova-common to test config and increase code coverage
Audrey So created CB-13395: -- Summary: Add tests to cordova-common to test config and increase code coverage Key: CB-13395 URL: https://issues.apache.org/jira/browse/CB-13395 Project: Apache Cordova Issue Type: Task Components: cordova-common Affects Versions: 7.0.0 Reporter: Audrey So Assignee: Audrey So Add tests to cordova-common to test config and increase code coverage -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13303) cordova fetch should use --production flag by default
[ https://issues.apache.org/jira/browse/CB-13303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So resolved CB-13303. Resolution: Fixed > cordova fetch should use --production flag by default > -- > > Key: CB-13303 > URL: https://issues.apache.org/jira/browse/CB-13303 > Project: Apache Cordova > Issue Type: Task > Components: cordova-fetch >Reporter: Steve Gill >Assignee: Audrey So > Labels: backlog, tools-next > > This should speed up cordova-fetch. When installing platforms and plugins, > run npm install --production under the hood so we don't fetch dev > dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13353) Support --save-exact for plugins/platforms
[
https://issues.apache.org/jira/browse/CB-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So resolved CB-13353.
Resolution: Fixed
> Support --save-exact for plugins/platforms
> --
>
> Key: CB-13353
> URL: https://issues.apache.org/jira/browse/CB-13353
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
>Reporter: Mike Hartington
>Assignee: Audrey So
>Priority: Minor
> Labels: beginner, easy-fix
>
> Adding a plugin or platform and passing a version will still add a {{^}} or
> {{~}} to the config.xml/package.json when installing. Since under the hood,
> npm is handling things, there should be support for the {{--save-exact}} flag
> as well. [~stevegill]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13274) Update cordova README.md docs with eslint changes and cleanup/remove old jshint files
[ https://issues.apache.org/jira/browse/CB-13274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So resolved CB-13274. Resolution: Fixed > Update cordova README.md docs with eslint changes and cleanup/remove old > jshint files > - > > Key: CB-13274 > URL: https://issues.apache.org/jira/browse/CB-13274 > Project: Apache Cordova > Issue Type: Task > Components: cordova-cli, cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > > Docs needs to be updated with latest eslint changes > Old jshint & jshint ignore files can be removed & any references to jshint -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13274) Update cordova README.md docs with eslint changes and cleanup/remove old jshint files
[ https://issues.apache.org/jira/browse/CB-13274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13274: --- Component/s: cordova-cli > Update cordova README.md docs with eslint changes and cleanup/remove old > jshint files > - > > Key: CB-13274 > URL: https://issues.apache.org/jira/browse/CB-13274 > Project: Apache Cordova > Issue Type: Task > Components: cordova-cli, cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > > Docs needs to be updated with latest eslint changes > Old jshint & jshint ignore files can be removed & any references to jshint -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13252) Nightly causing npm symbolic link loop issues
[
https://issues.apache.org/jira/browse/CB-13252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So resolved CB-13252.
Resolution: Fixed
> Nightly causing npm symbolic link loop issues
> -
>
> Key: CB-13252
> URL: https://issues.apache.org/jira/browse/CB-13252
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch
>Affects Versions: 7.0.2
>Reporter: Darryl Pogue
> Labels: tools-next
> Attachments: cordova.log
>
>
> Reproducible test case: https://github.com/dpogue/cordova-eloop (running with
> npm 5.4.0)
> Cordova prepare somehow decides to update the package.json to point a plugin
> at {{file:node_modules/cordova-plugin-}}, leading to npm trying to
> install from a folder into the same folder and throwing ELOOP errors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13353) Support --save-exact for plugins/platforms
[
https://issues.apache.org/jira/browse/CB-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188950#comment-16188950
]
Audrey So commented on CB-13353:
Also see --> https://github.com/apache/cordova-fetch/pull/4
> Support --save-exact for plugins/platforms
> --
>
> Key: CB-13353
> URL: https://issues.apache.org/jira/browse/CB-13353
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
>Reporter: Mike Hartington
>Assignee: Audrey So
>Priority: Minor
> Labels: beginner, easy-fix
>
> Adding a plugin or platform and passing a version will still add a {{^}} or
> {{~}} to the config.xml/package.json when installing. Since under the hood,
> npm is handling things, there should be support for the {{--save-exact}} flag
> as well. [~stevegill]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13353) Support --save-exact for plugins/platforms
[
https://issues.apache.org/jira/browse/CB-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So reassigned CB-13353:
--
Assignee: Audrey So
> Support --save-exact for plugins/platforms
> --
>
> Key: CB-13353
> URL: https://issues.apache.org/jira/browse/CB-13353
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
>Reporter: Mike Hartington
>Assignee: Audrey So
>Priority: Minor
> Labels: beginner, easy-fix
>
> Adding a plugin or platform and passing a version will still add a {{^}} or
> {{~}} to the config.xml/package.json when installing. Since under the hood,
> npm is handling things, there should be support for the {{--save-exact}} flag
> as well. [~stevegill]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13303) cordova fetch should use --production flag by default
[ https://issues.apache.org/jira/browse/CB-13303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188722#comment-16188722 ] Audrey So commented on CB-13303: This has been merged in. Next step: Provide the option to turn the production flag on and off. Should I create a new issue for this or is it okay to add it in under the same issue number? > cordova fetch should use --production flag by default > -- > > Key: CB-13303 > URL: https://issues.apache.org/jira/browse/CB-13303 > Project: Apache Cordova > Issue Type: Task > Components: cordova-fetch >Reporter: Steve Gill >Assignee: Audrey So > Labels: backlog, tools-next > > This should speed up cordova-fetch. When installing platforms and plugins, > run npm install --production under the hood so we don't fetch dev > dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13342) Update README.md for cordova-plugin-test-framework regarding package.json
[ https://issues.apache.org/jira/browse/CB-13342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So resolved CB-13342. Resolution: Fixed > Update README.md for cordova-plugin-test-framework regarding package.json > - > > Key: CB-13342 > URL: https://issues.apache.org/jira/browse/CB-13342 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-test-framework >Reporter: Audrey So >Priority: Trivial > Labels: beginner, easy-fix > > Update README.md for cordova-plugin-test-framework regarding package.json > Include build step in docs so tests build properly -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13298) npm WARN deprecated node-uuid@1.4.8: Use uuid module instead
[
https://issues.apache.org/jira/browse/CB-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So updated CB-13298:
---
Labels: beginner dependencies deprecation easyfix reproduced triaged (was:
dependencies deprecation easyfix reproduced triaged)
> npm WARN deprecated node-uuid@1.4.8: Use uuid module instead
>
>
> Key: CB-13298
> URL: https://issues.apache.org/jira/browse/CB-13298
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-common
>Affects Versions: 7.0.1
> Environment: NPM 5.4.0
>Reporter: Shad Sterling
>Priority: Minor
> Labels: beginner, dependencies, deprecation, easyfix,
> reproduced, triaged
>
> Running `npm install` with Cordova as a dependency raises this warning
> message:
> {code}
> npm WARN deprecated node-uuid@1.4.8: Use uuid module instead
> {code}
> `npm ls node-uuid` shows that Cordova depends on `node-uuid` in two places:
> {code}
> └─┬ cordova@7.0.1
> ├─┬ cordova-lib@7.0.1
> │ └─┬ npm@2.15.12
> │ └─┬ request@2.74.0
> │ └── node-uuid@1.4.7
> └─┬ insight@0.8.2
> └── node-uuid@1.4.8
> {code}
> The dependencies on `insight` and`npm` should be updated.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13353) Support --save-exact for plugins/platforms
[
https://issues.apache.org/jira/browse/CB-13353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So updated CB-13353:
---
Labels: beginner easy-fix (was: )
> Support --save-exact for plugins/platforms
> --
>
> Key: CB-13353
> URL: https://issues.apache.org/jira/browse/CB-13353
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
>Reporter: Mike Hartington
>Priority: Minor
> Labels: beginner, easy-fix
>
> Adding a plugin or platform and passing a version will still add a {{^}} or
> {{~}} to the config.xml/package.json when installing. Since under the hood,
> npm is handling things, there should be support for the {{--save-exact}} flag
> as well. [~stevegill]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181774#comment-16181774 ] Audrey So commented on CB-12895: Will be adding eslint to cordova-js and also ignoring pkg/ directory. Also, will need to ignore cordova.js files in android, ios, windows, and browser. This is to address a problem was uncovered while adding eslint to cordova-js repo. Issue was: The pkg/ directory is ignored by github so it doesn’t get checked in b/c the files are newly generated every time we run grunt compile. They get overwritten next time grunt compile is run. When grunt is called and compiled, it calls a generate function, which calls a bundle function. Here --> https://github.com/apache/cordova-js/blob/master/tasks/lib/bundle.js#L80 All of the output.push stuff is not compliant with eslint because of the indenting. For instance, here in line 80, eslint does not like that (1) there is a semi-colon in front of function and (2) `var PLATFORM_VERSION_BUILD_LABEL = '" + platformVersion + "';");` is not indented. and everything after that is not indented properly then. Solution: add cordova.js to all the platform repos eslintignore file and ignore pkg directory for eslint in cordova-js repo > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Reopened] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So reopened CB-12895: > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13342) Update README.md for cordova-plugin-test-framework regarding package.json
[ https://issues.apache.org/jira/browse/CB-13342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13342: --- Issue Type: Improvement (was: Bug) > Update README.md for cordova-plugin-test-framework regarding package.json > - > > Key: CB-13342 > URL: https://issues.apache.org/jira/browse/CB-13342 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-test-framework >Reporter: Audrey So >Priority: Trivial > Labels: beginner, easy-fix > > Update README.md for cordova-plugin-test-framework regarding package.json > Include build step in docs so tests build properly -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13342) Update README.md for cordova-plugin-test-framework regarding package.json
Audrey So created CB-13342: -- Summary: Update README.md for cordova-plugin-test-framework regarding package.json Key: CB-13342 URL: https://issues.apache.org/jira/browse/CB-13342 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-test-framework Reporter: Audrey So Priority: Trivial Update README.md for cordova-plugin-test-framework regarding package.json Include build step in docs so tests build properly -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13331) Update jira-triage.md in cordova-coho to include necessary labels
Audrey So created CB-13331: -- Summary: Update jira-triage.md in cordova-coho to include necessary labels Key: CB-13331 URL: https://issues.apache.org/jira/browse/CB-13331 Project: Apache Cordova Issue Type: Bug Components: cordova-coho Reporter: Audrey So Assignee: Audrey So Priority: Minor Revise and add in additional labels to use when triaging -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13312) Adding missing Jira labels/tags
[ https://issues.apache.org/jira/browse/CB-13312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13312: --- Labels: beginner in-progress on-hold rfc staging won't-fix (was: in-progress on-hold rfc staging won't-fix) > Adding missing Jira labels/tags > --- > > Key: CB-13312 > URL: https://issues.apache.org/jira/browse/CB-13312 > Project: Apache Cordova > Issue Type: Bug >Reporter: Audrey So > Labels: beginner, in-progress, on-hold, rfc, staging, won't-fix > > Adding in any missing labels/tags to track issues more easily and clearly. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13303) cordova fetch should use --production flag by default
[ https://issues.apache.org/jira/browse/CB-13303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So reassigned CB-13303: -- Assignee: Audrey So > cordova fetch should use --production flag by default > -- > > Key: CB-13303 > URL: https://issues.apache.org/jira/browse/CB-13303 > Project: Apache Cordova > Issue Type: Task > Components: cordova-fetch >Reporter: Steve Gill >Assignee: Audrey So > Labels: backlog, tools-next > > This should speed up cordova-fetch. When installing platforms and plugins, > run npm install --production under the hood so we don't fetch dev > dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13312) Adding missing Jira labels/tags
[ https://issues.apache.org/jira/browse/CB-13312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13312: --- Summary: Adding missing Jira labels/tags (was: Creating proper Jira labels) > Adding missing Jira labels/tags > --- > > Key: CB-13312 > URL: https://issues.apache.org/jira/browse/CB-13312 > Project: Apache Cordova > Issue Type: Bug >Reporter: Audrey So > Labels: in-progress, on-hold, rfc, staging, won't-fix > > Adding in any missing labels/tags to track issues more easily and clearly. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13312) Creating proper Jira labels
[ https://issues.apache.org/jira/browse/CB-13312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175534#comment-16175534 ] Audrey So commented on CB-13312: Note* As I was going through the labels, I noticed that we have a lot of the ones we already need. Just missing a few... > Creating proper Jira labels > --- > > Key: CB-13312 > URL: https://issues.apache.org/jira/browse/CB-13312 > Project: Apache Cordova > Issue Type: Bug >Reporter: Audrey So > Labels: in-progress, on-hold, rfc, staging, won't-fix > > Adding in any missing labels/tags to track issues more easily and clearly. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13312) Creating proper Jira labels
Audrey So created CB-13312: -- Summary: Creating proper Jira labels Key: CB-13312 URL: https://issues.apache.org/jira/browse/CB-13312 Project: Apache Cordova Issue Type: Bug Reporter: Audrey So Adding in any missing labels/tags to track issues more easily and clearly. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13288) Plugin "search" command, not working
[ https://issues.apache.org/jira/browse/CB-13288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-13288. -- Resolution: Fixed > Plugin "search" command, not working > > > Key: CB-13288 > URL: https://issues.apache.org/jira/browse/CB-13288 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > > cordova plugin search [ ] ... not working properly. > Error --> "Error: module.exports.search is not a function" > For example: > Running cordova plugin search > Should bring you to http://cordova.apache.org/plugins/ -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-12895) Replace jshint with eslint in our tools + platforms
[ https://issues.apache.org/jira/browse/CB-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So resolved CB-12895. Resolution: Fixed > Replace jshint with eslint in our tools + platforms > --- > > Key: CB-12895 > URL: https://issues.apache.org/jira/browse/CB-12895 > Project: Apache Cordova > Issue Type: Improvement > Components: AllComponents >Reporter: Steve Gill >Assignee: Audrey So >Priority: Minor > Labels: cordova-next > > Based on this proposal > https://github.com/cordova/cordova-discuss/pull/70#issuecomment-306649308 > JSHint does minimal checks and JSCS has been deprecated in favor of ESLint. > + > +I suggest to replace the current style checkers with ESLint. This allows to > set much more strict styling rules than at at this moment. > + > +I recommend using a popular preset, such as > [airbnb-base](https://www.npmjs.com/package/eslint-config-airbnb-base). > Example configuration: > + > +```yaml > +root: true > + > +extends: airbnb-base > +``` > + > +Many styling issues could be fixed by simply running: > + > +``` > +./node_modules/.bin/eslint --fix . > +``` > + > + > + > +Optionally the indent could be set to 4 instead of 2, because that's used > in the current code base. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13268) List of Plugins to Release, (September 2017)
[ https://issues.apache.org/jira/browse/CB-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-13268. -- Resolution: Duplicate > List of Plugins to Release, (September 2017) > > > Key: CB-13268 > URL: https://issues.apache.org/jira/browse/CB-13268 > Project: Apache Cordova > Issue Type: Bug > Components: AllPlugins >Reporter: Audrey So > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md > Generated automatically using cordova-coho. > cordova-plugin-device-motion > cordova-plugin-device-orientation > cordova-plugin-compat > cordova-plugin-console -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13288) Plugin "search" command, not working
[ https://issues.apache.org/jira/browse/CB-13288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13288: --- Description: cordova plugin search [ ] ... not working properly. Error --> "Error: module.exports.search is not a function" For example: Running cordova plugin search Should bring you to http://cordova.apache.org/plugins/ was: cordova plugin search [ ] ... not working properly. Error --> "Error: module.exports.search is not a function" For example: Running cordova plugin search bar code Should bring you to http://cordova.apache.org/plugins/?q=bar%20code > Plugin "search" command, not working > > > Key: CB-13288 > URL: https://issues.apache.org/jira/browse/CB-13288 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > > cordova plugin search [ ] ... not working properly. > Error --> "Error: module.exports.search is not a function" > For example: > Running cordova plugin search > Should bring you to http://cordova.apache.org/plugins/ -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13288) Plugin "search" command, not working
Audrey So created CB-13288: -- Summary: Plugin "search" command, not working Key: CB-13288 URL: https://issues.apache.org/jira/browse/CB-13288 Project: Apache Cordova Issue Type: Bug Components: cordova-lib Affects Versions: cordova7 Reporter: Audrey So Assignee: Audrey So Priority: Minor cordova plugin search [ ] ... not working properly. Error --> "Error: module.exports.search is not a function" For example: Running cordova plugin search bar code Should bring you to http://cordova.apache.org/plugins/?q=bar%20code -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13274) Update cordova README.md docs with eslint changes and cleanup/remove old jshint files
[ https://issues.apache.org/jira/browse/CB-13274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13274: --- Description: Docs needs to be updated with latest eslint changes Old jshint & jshint ignore files can be removed & any references to jshint was: Docs needs to be updated with latest eslint changes Old jshint & jshint ignore files can be removed > Update cordova README.md docs with eslint changes and cleanup/remove old > jshint files > - > > Key: CB-13274 > URL: https://issues.apache.org/jira/browse/CB-13274 > Project: Apache Cordova > Issue Type: Task > Components: cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > > Docs needs to be updated with latest eslint changes > Old jshint & jshint ignore files can be removed & any references to jshint -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13274) Update cordova README.md docs with eslint changes and cleanup/remove old jshint files
[ https://issues.apache.org/jira/browse/CB-13274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13274: --- Description: Docs needs to be updated with latest eslint changes Old jshint & jshint ignore files can be removed > Update cordova README.md docs with eslint changes and cleanup/remove old > jshint files > - > > Key: CB-13274 > URL: https://issues.apache.org/jira/browse/CB-13274 > Project: Apache Cordova > Issue Type: Task > Components: cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > > Docs needs to be updated with latest eslint changes > Old jshint & jshint ignore files can be removed -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13274) Update cordova README.md docs with eslint changes and cleanup/remove old jshint files
Audrey So created CB-13274: -- Summary: Update cordova README.md docs with eslint changes and cleanup/remove old jshint files Key: CB-13274 URL: https://issues.apache.org/jira/browse/CB-13274 Project: Apache Cordova Issue Type: Task Components: cordova-lib Affects Versions: @7 Reporter: Audrey So Assignee: Audrey So Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13274) Update cordova README.md docs with eslint changes and cleanup/remove old jshint files
[ https://issues.apache.org/jira/browse/CB-13274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13274: --- Affects Version/s: (was: @7) cordova7 > Update cordova README.md docs with eslint changes and cleanup/remove old > jshint files > - > > Key: CB-13274 > URL: https://issues.apache.org/jira/browse/CB-13274 > Project: Apache Cordova > Issue Type: Task > Components: cordova-lib >Affects Versions: cordova7 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13268) List of Plugins to Release, (September 2017)
[ https://issues.apache.org/jira/browse/CB-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13268: --- Description: Following steps at https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md Generated automatically using cordova-coho. cordova-plugin-device-motion cordova-plugin-device-orientation cordova-plugin-compat cordova-plugin-console was: Following steps at https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md Generated automatically using cordova-coho. > List of Plugins to Release, (September 2017) > > > Key: CB-13268 > URL: https://issues.apache.org/jira/browse/CB-13268 > Project: Apache Cordova > Issue Type: Bug > Components: AllPlugins >Reporter: Audrey So > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md > Generated automatically using cordova-coho. > cordova-plugin-device-motion > cordova-plugin-device-orientation > cordova-plugin-compat > cordova-plugin-console -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13268) List of Plugins to Release, (September 2017)
[ https://issues.apache.org/jira/browse/CB-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13268: --- Summary: List of Plugins to Release, (September 2017) (was: Plugins Release, September 2017) > List of Plugins to Release, (September 2017) > > > Key: CB-13268 > URL: https://issues.apache.org/jira/browse/CB-13268 > Project: Apache Cordova > Issue Type: Bug > Components: AllPlugins >Reporter: Audrey So > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md > Generated automatically using cordova-coho. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13268) Plugins Release, September 2017
Audrey So created CB-13268: -- Summary: Plugins Release, September 2017 Key: CB-13268 URL: https://issues.apache.org/jira/browse/CB-13268 Project: Apache Cordova Issue Type: Bug Components: AllPlugins Reporter: Audrey So Following steps at https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md Generated automatically using cordova-coho. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13252) Nightly causing npm symbolic link loop issues
[
https://issues.apache.org/jira/browse/CB-13252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157348#comment-16157348
]
Audrey So commented on CB-13252:
Hi! I was able to reproduce this issue:
node 8.4.0
npm 5.4.0
npm install
npx cordova@nightly prepare -d
> Nightly causing npm symbolic link loop issues
> -
>
> Key: CB-13252
> URL: https://issues.apache.org/jira/browse/CB-13252
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch
>Affects Versions: 7.0.2
>Reporter: Darryl Pogue
> Labels: tools-next
> Attachments: cordova.log
>
>
> Reproducible test case: https://github.com/dpogue/cordova-eloop (running with
> npm 5.4.0)
> Cordova prepare somehow decides to update the package.json to point a plugin
> at {{file:node_modules/cordova-plugin-}}, leading to npm trying to
> install from a folder into the same folder and throwing ELOOP errors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13231) Cordova-Common@2.1.0 Release August 30, 2017
[ https://issues.apache.org/jira/browse/CB-13231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So closed CB-13231. -- Resolution: Fixed > Cordova-Common@2.1.0 Release August 30, 2017 > > > Key: CB-13231 > URL: https://issues.apache.org/jira/browse/CB-13231 > Project: Apache Cordova > Issue Type: Task > Components: cordova-common >Affects Versions: 2.1.0 >Reporter: Audrey So >Assignee: Audrey So > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Reopened] (CB-13231) Cordova-Common@2.1.0 Release August 30, 2017
[ https://issues.apache.org/jira/browse/CB-13231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So reopened CB-13231: > Cordova-Common@2.1.0 Release August 30, 2017 > > > Key: CB-13231 > URL: https://issues.apache.org/jira/browse/CB-13231 > Project: Apache Cordova > Issue Type: Task > Components: cordova-common >Affects Versions: 2.1.0 >Reporter: Audrey So >Assignee: Audrey So > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13231) Cordova-Common@2.1.0 Release August 30, 2017
[ https://issues.apache.org/jira/browse/CB-13231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13231: --- Component/s: cordova-common > Cordova-Common@2.1.0 Release August 30, 2017 > > > Key: CB-13231 > URL: https://issues.apache.org/jira/browse/CB-13231 > Project: Apache Cordova > Issue Type: Task > Components: cordova-common >Affects Versions: 2.1.0 >Reporter: Audrey So >Assignee: Audrey So > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13231) Cordova-Common@2.1.0 Release August 30, 2017
[ https://issues.apache.org/jira/browse/CB-13231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So reassigned CB-13231: -- Assignee: Audrey So > Cordova-Common@2.1.0 Release August 30, 2017 > > > Key: CB-13231 > URL: https://issues.apache.org/jira/browse/CB-13231 > Project: Apache Cordova > Issue Type: Task > Components: cordova-common >Affects Versions: 2.1.0 >Reporter: Audrey So >Assignee: Audrey So > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
