[GitHub] [cordova-plugin-inappbrowser] breautek commented on issue #820: tg:resolve?domain=specificId net:err_unknown_url_scheme
breautek commented on issue #820: URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/820#issuecomment-1398727476 > yes, why is the issue closed? Nothing is clear! The issue is not closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] atomoc commented on issue #820: tg:resolve?domain=specificId net:err_unknown_url_scheme
atomoc commented on issue #820: URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/820#issuecomment-1398723609 yes, why is the issue closed? Nothing is clear! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-cli] IlyaNakhaichuk commented on issue #589: TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
IlyaNakhaichuk commented on issue #589: URL: https://github.com/apache/cordova-cli/issues/589#issuecomment-1398559393 any update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-ios] mkayander commented on issue #1228: Cookies are blocked in iframe even after disabling ITP
mkayander commented on issue #1228: URL: https://github.com/apache/cordova-ios/issues/1228#issuecomment-1398437392 As it turned out, those iframe cookies are only being saved if there's already a cookie present for this specific domain. I've used a `cordova-plugin-wkwebview-inject-cookie` plugin to add a dummy cookie for the required domain on the app startup, and it started working. So it seems like a working solution for the test environment, but not a good option for the prod, since it's not great to force users to enable tracking in settings. It looks like the only option for the production env is to make a separate build for each domain and enforce/proxy all iframes to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] erisu commented on pull request #99: chore: drop q where possible
erisu commented on PR #99: URL: https://github.com/apache/cordova-common/pull/99#issuecomment-1398155316 Spawn is used in these locations: * **`cordova-windows`** which is a deprecated platform and archived repo * **`cordova-fetch`** * **[installPackage](https://github.com/apache/cordova-fetch/blob/master/index.js#L87)** * Method is called [here](https://github.com/apache/cordova-fetch/blob/master/index.js#L69) * **[uninstall](https://github.com/apache/cordova-fetch/blob/master/index.js#L165)** * Method is called lib's [platform remove](https://github.com/apache/cordova-lib/blob/master/src/cordova/platform/remove.js#L89) and [plugman remove](https://github.com/apache/cordova-lib/blob/master/src/plugman/uninstall.js#L129). * And also in one test spec file for this repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] erisu commented on pull request #99: chore: drop q where possible
erisu commented on PR #99: URL: https://github.com/apache/cordova-common/pull/99#issuecomment-1398015577 Also, this repo is currently setup for taking in next major release PRs. (`5.0.0`) Any ideas or suggestions on what to do with this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] erisu commented on pull request #99: chore: drop q where possible
erisu commented on PR #99: URL: https://github.com/apache/cordova-common/pull/99#issuecomment-1398014654 @raphinesse I rebased this PR since it has not been updated in the last 3 years. As of now, I can not find `Q` being used in any of the higher packages. It only remains in development repos. E.g. coho, paramedic, etc. This is the only place left in this repo where `Q` is still being used. https://github.com/erisu/cordova-common/blob/v4-drop-q/src/superspawn.js#L23 I am guessing I left it because of the usage **[`d.notify()`](https://github.com/erisu/cordova-common/blob/v4-drop-q/src/superspawn.js#L115)**. I don't recall any options to get around this and I dont remember what happens higher up the chain... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] codecov-commenter commented on pull request #99: chore: drop q where possible
codecov-commenter commented on PR #99: URL: https://github.com/apache/cordova-common/pull/99#issuecomment-1398009590 # [Codecov](https://codecov.io/gh/apache/cordova-common/pull/99?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#99](https://codecov.io/gh/apache/cordova-common/pull/99?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (714df63) into [master](https://codecov.io/gh/apache/cordova-common/commit/cc78c8190a7adcfac701d68c51fdae3fa17e665c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (cc78c81) will **decrease** coverage by `0.03%`. > The diff coverage is `100.00%`. ```diff @@Coverage Diff @@ ## master #99 +/- ## == - Coverage 88.38% 88.36% -0.03% == Files 20 20 Lines1145 1143 -2 == - Hits 1012 1010 -2 Misses133 133 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-common/pull/99?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/ActionStack.js](https://codecov.io/gh/apache/cordova-common/pull/99?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL0FjdGlvblN0YWNrLmpz) | `93.10% <100.00%> (-0.23%)` | :arrow_down: | | [src/PluginManager.js](https://codecov.io/gh/apache/cordova-common/pull/99?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL1BsdWdpbk1hbmFnZXIuanM=) | `88.37% <100.00%> (-0.27%)` | :arrow_down: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-file] a51095 closed pull request #537: A CFType object to release. This value must not be NULL.
a51095 closed pull request #537: A CFType object to release. This value must not be NULL. URL: https://github.com/apache/cordova-plugin-file/pull/537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-file] erisu merged pull request #554: spec(android): fix spec based on testing environment
erisu merged PR #554: URL: https://github.com/apache/cordova-plugin-file/pull/554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-coho] breautek merged pull request #298: ci: Remove Node 10.x-14.x. Added 18.x
breautek merged PR #298: URL: https://github.com/apache/cordova-coho/pull/298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-cli] breautek commented on issue #602: Asset Links / universal-links
breautek commented on issue #602: URL: https://github.com/apache/cordova-cli/issues/602#issuecomment-1397076890 Moving this to cordova discussions as it doesn't relate to any bug or isuse within Cordova. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-coho] codecov-commenter commented on pull request #298: ci: Remove Node 10.x-12.x. Added 18.x
codecov-commenter commented on PR #298: URL: https://github.com/apache/cordova-coho/pull/298#issuecomment-1397034715 # [Codecov](https://codecov.io/gh/apache/cordova-coho/pull/298?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#298](https://codecov.io/gh/apache/cordova-coho/pull/298?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (62b76d7) into [master](https://codecov.io/gh/apache/cordova-coho/commit/80fea9d135a2cdb7b5a6af11827cd84e37d8adcf?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (80fea9d) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #298 +/- ## === Coverage 56.91% 56.91% === Files 88 Lines 492 492 === Hits 280 280 Misses212 212 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-coho] breautek opened a new pull request, #298: ci: Remove Node 10.x-12.x. Added 18.x
breautek opened a new pull request, #298: URL: https://github.com/apache/cordova-coho/pull/298 ### Platforms affected ### Motivation and Context ### Description ### Testing ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-coho] dependabot[bot] opened a new pull request, #297: chore(deps): bump dot-prop and cordova-android
dependabot[bot] opened a new pull request, #297: URL: https://github.com/apache/cordova-coho/pull/297 Removes [dot-prop](https://github.com/sindresorhus/dot-prop). It's no longer used after updating ancestor dependency [cordova-android](https://github.com/apache/cordova-android). These dependencies need to be updated together. Removes `dot-prop` Updates `cordova-android` from 8.1.0 to 11.0.0 Changelog Sourced from https://github.com/apache/cordova-android/blob/master/RELEASENOTES.md;>cordova-android's changelog. 11.0.0 (Jul 04, 2022) Breaking: https://github-redirect.dependabot.com/apache/cordova-android/pull/1441;>GH-1441 feat!: Android 12 splash screen https://github-redirect.dependabot.com/apache/cordova-android/pull/1427;>GH-1427 feat!: API 32 support https://github-redirect.dependabot.com/apache/cordova-android/pull/1410;>GH-1410 feat!: API 31 support https://github-redirect.dependabot.com/apache/cordova-android/pull/1444;>GH-1444 fix!: set use ANDROID_HOME as default https://github-redirect.dependabot.com/apache/cordova-android/pull/1411;>GH-1411 chore!: Drop Node 12 support Features: https://github-redirect.dependabot.com/apache/cordova-android/pull/1448;>GH-1448 feat: Update androidx.appcompat version https://github-redirect.dependabot.com/apache/cordova-android/pull/1446;>GH-1446 feat: Update gradle plugin version https://github-redirect.dependabot.com/apache/cordova-android/pull/1447;>GH-1447 feat: Update google services pluging https://github-redirect.dependabot.com/apache/cordova-android/pull/1431;>GH-1431 feat: support custom compileSdk setting https://github-redirect.dependabot.com/apache/cordova-android/pull/1311;>GH-1311 feat: added support for BoM imports Fixes: https://github-redirect.dependabot.com/apache/cordova-android/pull/1455;>GH-1455 fix(prepare): destFile path separator https://github-redirect.dependabot.com/apache/cordova-android/pull/1453;>GH-1453 fix: support installing platfrom from local git checkout https://github-redirect.dependabot.com/apache/cordova-android/pull/1449;>GH-1449 fix: accept file cookies only if AndroidInsecureFileModeEnabled https://github-redirect.dependabot.com/apache/cordova-android/pull/1443;>GH-1443 fix: force hostname to lowercase https://github-redirect.dependabot.com/apache/cordova-android/pull/1434;>GH-1434 fix: restore checkReqs in prepare.js https://github-redirect.dependabot.com/apache/cordova-android/pull/1154;>GH-1154 fix: move MainActivity.java to folder that tracks the app package name (widget id) Chores, Dependencies CI: https://github-redirect.dependabot.com/apache/cordova-android/pull/1451;>GH-1451 chore: display warning on deprecated splash tag usage https://github-redirect.dependabot.com/apache/cordova-android/pull/1430;>GH-1430 chore: remove unneeded deprecated annotation https://github-redirect.dependabot.com/apache/cordova-android/pull/1421;>GH-1421 chore(npm): bump @cordova/eslint-config@^4.0.0 https://github-redirect.dependabot.com/apache/cordova-android/pull/1420;>GH-1420 chore(npm): bump dependencies https://github-redirect.dependabot.com/apache/cordova-android/pull/1452;>GH-1452 dep: bump jasmine@4.2.1 w/ package-lock rebuild https://github-redirect.dependabot.com/apache/cordova-android/pull/1439;>GH-1439 ci: update github action workflow https://github-redirect.dependabot.com/apache/cordova-android/pull/1424;>GH-1424 ci: Added Node 18 to test matrix 10.1.2 (Apr 11, 2022) Fixes: https://github-redirect.dependabot.com/apache/cordova-android/pull/1372;>GH-1372 fix(AndroidManifest): explicitly define the activity attribute android:exported https://github-redirect.dependabot.com/apache/cordova-android/pull/1406;>GH-1406 fix: detect JAVA_HOME with Java 11 https://github-redirect.dependabot.com/apache/cordova-android/pull/1401;>GH-1401 fix(https://github-redirect.dependabot.com/apache/cordova-android/issues/1391;>GH-1391): Reword minimum build tools version to make it more clear what is actually required. https://github-redirect.dependabot.com/apache/cordova-android/pull/1384;>GH-1384 fix: escape strings.xml app name Chores: https://github-redirect.dependabot.com/apache/cordova-android/pull/1413;>GH-1413 chore: update package-lock to satisfy npm audit https://github-redirect.dependabot.com/apache/cordova-android/pull/1348;>GH-1348 chore: npmrc ... (truncated) Commits https://github.com/apache/cordova-android/commit/d8287854354806f16f0b1bf3b93997780c4626d0;>d828785 release(android-v11.0.0): updated version and RELEASENOTES.md (2) https://github.com/apache/cordova-android/commit/e5b7e8ab266c8f9de83923430be77c62499810a2;>e5b7e8a fix(prepare): destFile path separator (https://github-redirect.dependabot.com/apache/cordova-android/issues/1455;>#1455)
[GitHub] [cordova-coho] breautek merged pull request #295: chore(deps): bump json5 from 1.0.1 to 1.0.2
breautek merged PR #295: URL: https://github.com/apache/cordova-coho/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] erisu merged pull request #196: dep: bump @cordova/eslint-config@^5.0.0
erisu merged PR #196: URL: https://github.com/apache/cordova-common/pull/196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-paramedic] erisu merged pull request #253: fix(android): change order of project setup & plugin install
erisu merged PR #253: URL: https://github.com/apache/cordova-paramedic/pull/253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-paramedic] erisu commented on pull request #253: fix(android): change order of project setup & plugin install
erisu commented on PR #253: URL: https://github.com/apache/cordova-paramedic/pull/253#issuecomment-1396552070 File Plugin Test Results: * Before PR: https://github.com/apache/cordova-plugin-file/actions/runs/3867903568 * After PR: https://github.com/apache/cordova-plugin-file/actions/runs/3956130019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-paramedic] erisu commented on pull request #253: fix(android): change order of project setup & plugin install
erisu commented on PR #253: URL: https://github.com/apache/cordova-paramedic/pull/253#issuecomment-1396545012 Camera Plugin Test Results: * Before PR: https://github.com/apache/cordova-plugin-camera/actions/runs/3945602425 * After PR: https://github.com/apache/cordova-plugin-camera/actions/runs/3956142010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-file] erisu commented on pull request #554: feat: use improved paramedic test w/ Android fix
erisu commented on PR #554: URL: https://github.com/apache/cordova-plugin-file/pull/554#issuecomment-1396543779 Camera Plugin Test Results: * Before: https://github.com/apache/cordova-plugin-camera/actions/runs/3945602425 * After: https://github.com/apache/cordova-plugin-camera/actions/runs/3956142010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-file] erisu opened a new pull request, #554: feat: use improved paramedic test w/ Android fix
erisu opened a new pull request, #554: URL: https://github.com/apache/cordova-plugin-file/pull/554 ### Platforms affected n/a ### Motivation and Context Use an improved paramedic which include Android plugin test workaround fix ### Description * Temporarily use `github:erisu/cordova-paramedic\#fix/plugin-install-order` to demo the fix. * Apply additional Android fix. **TODO:** * Revert the temporary change paramedic PR has been merged: * https://github.com/apache/cordova-paramedic/pull/253 ### Testing GitHub Action ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-paramedic] erisu opened a new pull request, #253: fix(android): change order of project setup & plugin install
erisu opened a new pull request, #253:
URL: https://github.com/apache/cordova-paramedic/pull/253
### Motivation and Context
Various Android tests are failing because of the config munging order.
This PR changes the order of the project setup and the plugin install as a
temporary workaround for Android plugin testing.
This change does not resolve the underlining issue.
### Description
Example issue
**Current Order of Paramedic for Reference:**
* Install Plugins
* Install Plugins
* Install Test For Existing Plugins
* Install CI Testing Framework Related Plugins
* Setup Project Config For Test Framework
* Install Platform
Some plugins and the test plugins will inject elements into the
`AndroidManifest` with `config-file`. For example, let us say the `provider`
node is injected into the path of `/manifest/application`.
Next, the CI testing plugin attempts to update the `/manifest/application`
node by appending attributes with `edit-config`.
Because the CI is trying to update the same node that had already been
modified with `config-file`, it fails to merge with conflicts, even if the
changes do not affect each other.
Example Solution
**New Order of Paramedic for Reference:**
* Install Platform
* Install Plugins
* Install CI Testing Framework Related Plugins
* Install Plugins
* Install Test For Existing Plugins
* Setup Project Config For Test Framework
If `edit-config` is applied first and then `config-file` is applied last,
will not fail because config-file only uses the node path as a reference to
where it needs to inject.
Final Note
Even though we change the order for the paramedic to resolve the issue, it
only tests as if the project was being built up from scratch.
If we looked at the issue from a CI perspective, all the plugins and
platforms are usually defined in `package.json`, and running `cordova prepare`
could trigger the same issue as the order for installation might not be
guaranteed.
More investigation into a proper solution should be performed within the
`cordova-common` repo.
### Testing
* GitHub Action CI
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to
one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the
text above (and used the correct [keyword to close issues using
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] objmedsyssaro commented on issue #990: Keyboard not open in Android device when selecting input fields
objmedsyssaro commented on issue #990: URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/990#issuecomment-1396516468 working now with cordova-plugin-inappbrowser-location-editable plugin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] objmedsyssaro closed issue #990: Keyboard not open in Android device when selecting input fields
objmedsyssaro closed issue #990: Keyboard not open in Android device when selecting input fields URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-media-capture] Valdenirmezadri commented on issue #135: Read the video file on android
Valdenirmezadri commented on issue #135: URL: https://github.com/apache/cordova-plugin-media-capture/issues/135#issuecomment-1396234922 I have same issue on Android 10. 11 and above work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-cli] rajeshkumr commented on issue #539: '--searchpath' not working properly on Cordova 10.0
rajeshkumr commented on issue #539: URL: https://github.com/apache/cordova-cli/issues/539#issuecomment-1387733968 It seems like Cordova version 10.0.0 still has an issue related to adding a plugin with --searchpath. You can change the version of your Cordova CLI to 9.0.0 and it should work fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-file] Valdenirmezadri commented on issue #538: readAsDataURL promise resolve with empty data at end of data:audio/mpeg;base64, in Android target API 30
Valdenirmezadri commented on issue #538: URL: https://github.com/apache/cordova-plugin-file/issues/538#issuecomment-1387694267 same issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-ios] mkayander commented on issue #1228: Cookies are blocked in iframe even after disabling ITP
mkayander commented on issue #1228: URL: https://github.com/apache/cordova-ios/issues/1228#issuecomment-1387563601 Yeah, i've logged the `cookieAcceptPolicy` value and it's already `0` before the assignment, which is `NSHTTPCookieAcceptPolicyAlways`. NSCrossWebsiteTrackingUsageDescription is set and enabled in settings yes. Yet, i see in dev tools that iframe's response contains multiple `Set-Cookie`, `SameSite` is set to none. But when i check saved cookies for iframe's domain, there's none, which results in errors. I'm also using a `cordova-plugin-wkwebview-file-xhr` plugin that affects XHR requests but it doesn't seem to be relevant to the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #1542: ci(workflow): update codecov/codecov-action@v3
erisu merged PR #1542: URL: https://github.com/apache/cordova-android/pull/1542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-camera] breautek commented on pull request #781: (android) catch RecoverableSecurityException
breautek commented on PR #781: URL: https://github.com/apache/cordova-plugin-camera/pull/781#issuecomment-1387185921 The android test failures are due to a known incompatibility issue between cordova-android and cordova-paramedic testing tools. It's not the result of this PR, so they can probably be ignored for now. Some point next week I am planning on updating one of my apps that uses the camera plugin, so I'll have an opportunity to test this PR at the same time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] codecov-commenter commented on pull request #196: dep: bump @cordova/eslint-config@^5.0.0
codecov-commenter commented on PR #196: URL: https://github.com/apache/cordova-common/pull/196#issuecomment-1386864975 # [Codecov](https://codecov.io/gh/apache/cordova-common/pull/196?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#196](https://codecov.io/gh/apache/cordova-common/pull/196?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4fd8b5c) into [master](https://codecov.io/gh/apache/cordova-common/commit/0436b453b56a59a004a54c33dbc78c7aa8679de2?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0436b45) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #196 +/- ## === Coverage 88.38% 88.38% === Files 20 20 Lines1145 1145 === Hits 1012 1012 Misses133 133 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] erisu opened a new pull request, #196: dep: bump @cordova/eslint-config@^4.0.0
erisu opened a new pull request, #196: URL: https://github.com/apache/cordova-common/pull/196 ### Platforms affected n/a ### Motivation and Context Use latest @cordova/eslint-config ### Description Bump `@cordova/eslint-config@^4.0.0` ### Testing `npm t` ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-ios] Mady-Camara commented on issue #760: XCode cannot build : Cordova.h and Info.plist missing files
Mady-Camara commented on issue #760: URL: https://github.com/apache/cordova-ios/issues/760#issuecomment-1386599500 @dpogue it works perfectly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-ios] abhinavms commented on issue #1228: Cookies are blocked in iframe even after disabling ITP
abhinavms commented on issue #1228: URL: https://github.com/apache/cordova-ios/issues/1228#issuecomment-1386592650 In my codebase, it was added under "pluginInitialize". But I think it should have worked under initWithFrame also. Maybe you can debug and check the "cookieAcceptPolicy" value in your case. If it is already NSHTTPCookieAcceptPolicyAlways, then you might be facing a different issue. Also just to confirm you have already added "NSCrossWebsiteTrackingUsageDescription" and enabled tracking in the app settings? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-camera] dongourdet opened a new pull request, #781: (android) catch RecoverableSecurityException
dongourdet opened a new pull request, #781: URL: https://github.com/apache/cordova-plugin-camera/pull/781 ### Platforms affected Android ### Motivation and Context https://github.com/apache/cordova-plugin-camera/issues/679 https://github.com/apache/cordova-plugin-camera/issues/660 https://github.com/apache/cordova-plugin-camera/issues/656 Closes #679 Closes #660 Closes #679 ### Description Catch the RecoverableSecurityException and Requests permission to delete the media from the media store. see https://developer.android.com/training/data-storage/shared/media#update-other-apps-files ### Testing Using a Ulefone Armor 8, Android 10, api 29 ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-camera] breautek commented on pull request #781: (android) catch RecoverableSecurityException
breautek commented on PR #781: URL: https://github.com/apache/cordova-plugin-camera/pull/781#issuecomment-1386454362 Relaunching tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-camera] breautek closed pull request #781: (android) catch RecoverableSecurityException
breautek closed pull request #781: (android) catch RecoverableSecurityException URL: https://github.com/apache/cordova-plugin-camera/pull/781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-camera] breautek commented on issue #823: Taking screenshot while camera is active crashes app on android devices
breautek commented on issue #823: URL: https://github.com/apache/cordova-plugin-camera/issues/823#issuecomment-1386453246 Potentially related to https://github.com/apache/cordova-plugin-camera/issues/679 with an open PR https://github.com/apache/cordova-plugin-camera/pull/781 If you could try testing that PR to see if it will solve your issue ``` cordova plugin remove cordova-plugin-camera cordova plugin add https://github.com/dongourdet/cordova-plugin-camera.git#android-recoverable-security-exception ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-camera] Noraagnkk opened a new issue, #823: Taking screenshot while camera is active crashes app across android devices
Noraagnkk opened a new issue, #823: URL: https://github.com/apache/cordova-plugin-camera/issues/823 ## Problem Application restarts and crashes if user takes a screenshot when camera is active, snaps picture and presses "OK" ### Command or Code https://user-images.githubusercontent.com/122949685/213066701-79b1c993-49f0-4ad1-9253-234c614b9b9b.png;> https://user-images.githubusercontent.com/122949685/213070001-d2cf6649-579b-418a-a57e-da27ad0738ea.png;> ### Version information OS: Android 11 node -v : 14.21.1 cordova -v : 10.0.0 (cordova-lib@10.1.0) "cordova-plugin-camera": "^6.0.0" ### Logs https://user-images.githubusercontent.com/122949685/213069481-c288ad43-3248-4d78-af8c-465ca147f4ea.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-file] jfoclpf commented on issue #426: Storage updates in Android 11
jfoclpf commented on issue #426: URL: https://github.com/apache/cordova-plugin-file/issues/426#issuecomment-1386159011 Thank you @breautek for the clarification. Indeed for now I set `AndroidInsecureFileModeEnabled` on and it works just fine and I uploaded the AAB file to Google Play Console (with SDK 30-33) and it didn't complain (no errors nor warnings). But I guess it just a question of time. I will later remove `AndroidInsecureFileModeEnabled` (off) and I will test it considering `http://localhost` is the equivalent of `file://android_asset/www` and using your piece of code. Thanks again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-file] breautek commented on issue #426: Storage updates in Android 11
breautek commented on issue #426:
URL:
https://github.com/apache/cordova-plugin-file/issues/426#issuecomment-1386050453
@jfoclpf You're using a jquery API that presumably uses an XHR request to
fetch data from a `file://` url. This API is not related to the file plugin at
all.
The webview doesn't have direct access to `file://` unless if
`AndroidInsecureFileModeEnabled` preference is enabled. Enabling this will make
Cordova uses the same filesystem based strategy for the webview, which is the
same behaviour in cordova-android@9 and older. If
`AndroidInsecureFileModeEnabled` is off (the default value), then the webview
is handled through a `WebViewAssetLoader`, which is a way of treating your web
app as if it was being loaded from a secure `https` site, enabling features
that requires a secure context. But this also means that the webview and
standard browser features don't have direct access to the file system.
While the browser itself doesn't have direct access to the FS, native
plugins still does, so if you used the actual cordova plugin API,
`cordova.file.applicationDirectory + 'www/json/anomalies.json` will be readable.
> mentions replacing file:// by http://localhost. Does this work? If yes,
shouldn't cordova.file.applicationDirectory be updated accordingly?
`http://localhost` points to the asset directory, which is effectively the
equivalent of `file://android_asset/www`. The `http://` version of the path
will work in the webview and other browser APIs. But your real issue is that
you're mixing APIs together. No, `cordova.file.applicationDirectory` shouldn't
be updated because that's part of the File plugin API, which still uses the
`file://` protocol, as that is what used on the native side. The
`cordova.file.applicationDirectory + 'www/json/anomalies.json'` path will
resolve into a proper path that the file plugin can read.
Here's an untested example (may have syntax errors or a function name might
be wrong, going off memory...)
```javascript
resolveLocalFilesystemURL(cordova.file.applicationDirectory +
'www/json/anomalies.json', (fileEntry) => {
fileEntry.file((file) => {
let reader = new FileReader();
reader.onloadend = () => {
console.log('JSON String', reader.result);
};
reader.readAsText(file);
});
}, (error) => {
console.error('resolve error', error);
});
```
If you're using the WebViewAssetLoader, the latest version of this plugin as
a `fileEntry.toURL()` API that also produces a `http(s)://` friendly URLs for
standard browser APIs to consume.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-file] jfoclpf commented on issue #426: Storage updates in Android 11
jfoclpf commented on issue #426: URL: https://github.com/apache/cordova-plugin-file/issues/426#issuecomment-1386041755 @breautek I was reading now your post upwards, too many characters to go through :) and reading also your [blog post](https://cordova.apache.org/announcements/2021/07/20/cordova-android-10.0.0.html) Ok, `file://` is supposed to be insecure, but my previous question remains: is not possible to adapt the keys inside `cordova.file` to `https://localhost`? What am I missing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-file] jfoclpf commented on issue #426: Storage updates in Android 11
jfoclpf commented on issue #426:
URL:
https://github.com/apache/cordova-plugin-file/issues/426#issuecomment-1386031952
This is becoming a bit messy :)
From updating from SDK v30 upwards the APP breaks exactly by merely
_reading_ the file system (cordova `v11` and cordova-android `v10.1.2`)
jquery.min.js:2 Not allowed to load local resource:
file:///android_asset/www/json/anomalies.json
```js
$.getJSON(cordova.file.applicationDirectory + 'www/json/anomalies.json',
function (data) {
console.log(data)
})
```
1 - @breautek just confirm me please, if I remember correctly the issue
regarding the transition from SDK 29 upwards was merely related with _writing_
content to the device file system, right?
2 - @alex-steinberg mentions replacing `file://` by `http://localhost`. Does
this work? If yes, shouldn't `cordova.file.applicationDirectory` be updated
accordingly?
My package.json:
```json
{
"name": "in-my-district",
"displayName": "In my District!",
"version": "1.2.25",
"description": "Report to your municipality certain irregularities in your
neighborhood or district",
"homepage": "https://nomeubairro.app/;,
"android-version-code": 10225,
"scripts": {
"test": "standard && node test/convertHbsToHtml.js && html-validate
test/www/index.html && printf '\\n\\nTest OK\\n\\n'",
"version": "cordova-set-version --version ${npm_package_version} && git
add config.xml && node scripts/setAndroidVersionCode.js -v
${npm_package_version} && git add package.json",
"push-version": "git push && git push origin v${npm_package_version}",
"build-release-apk": "npm test && scripts/buildReleaseAPK.sh",
"build-release-aab": "npm test && scripts/buildReleaseAAB.sh",
"run-release-on-device": "scripts/runReleaseOnDevice.sh",
"run-debug-on-device": "adb get-state 1>/dev/null 2>&1 && echo 'DEVICE
ATTACHED' || { echo 'No device attached'; exit 1; } && cordova run android
--device --debug",
"regenerate-png-files": "./res/icon/generateIcons.sh &&
./res/screen/generateScreens.sh && cp res/icon/android/512.png www/img/logo.png
&& cp res/icon/android/512.png
../fastlane/metadata/android/en-US/images/icon.png && git add res/*
www/img/logo.png ../fastlane/metadata/android/en-US/images/icon.png && git
commit -m 'PNGs regenerated'"
},
"repository": {
"type": "git",
"url": "git://github.com/jfoclpf/in-my-district.git"
},
"author": "João Pimentel Ferreira",
"license": "GPL-3.0",
"dependencies": {
"@fortawesome/fontawesome-free": "6.2.1",
"async": "^3.2.4",
"bootstrap": "^5.2.3",
"cordova": "^11.1.0",
"cordova-browser": "^6.0.0",
"cordova-import-npm": "^1.0.35",
"cordova-pdf-generator": "^2.1.1",
"cordova-plugin-cache-clear": "^1.3.8",
"cordova-plugin-device": "^2.1.0",
"cordova-plugin-geolocation": "^4.1.0",
"cordova-plugin-inappbrowser": "^5.0.0",
"cordova-plugin-is-debug": "^1.0.0",
"cordova-plugin-screen-orientation": "^3.0.2",
"cordova-plugin-simple-image-resizer": "0.2.0",
"cordova-plugin-splashscreen": "^6.0.2",
"cordova-plugin-statusbar": "^3.0.0",
"cordova-plugin-whitelist": "^1.3.4",
"cordova-set-version": "^13.0.1",
"crypto-js": "^4.1.1",
"es6-promise-plugin": "^4.2.2",
"exif-js": "^2.3.0",
"express-handlebars": "^6.0.6",
"fs": "0.0.1-security",
"jAlert": "^4.9.1",
"jquery": "^3.6.3",
"leaflet": "^1.9.3",
"leaflet-image": "^0.4.0",
"leaflet.markercluster": "^1.5.3",
"path": "^0.12.7",
"whitelist": "^1.0.2"
},
"cordova": {
"plugins": {
"cordova-plugin-geolocation": {
"GPS_REQUIRED": "true"
},
"cordova-plugin-email-composer": {
"ANDROID_SUPPORT_V4_VERSION": "27.+"
},
"cordova-plugin-statusbar": {},
"cordova-plugin-screen-orientation": {},
"cordova-plugin-device": {},
"cordova-plugin-whitelist": {},
"cordova-pdf-generator": {},
"cordova-plugin-splashscreen": {},
"cordova-plugin-inappbrowser": {},
"cordova-plugin-is-debug": {},
"cordova-plugin-androidx-adapter": {},
"cordova-plugin-file": {
"ANDROIDX_WEBKIT_VERSION": "1.4.0"
},
"cordova-plugin-camera": {
"ANDROID_SUPPORT_V4_VERSION": "27.+",
"ANDROIDX_CORE_VERSION": "1.6.+"
},
"cordova-plugin-network-information": {},
"cordova-plugin-app-version": {},
"@globules-io/cordova-plugin-ios-xhr": {},
"cordova-plugin-simple-image-resizer": {
"ANDROID_EXIFINTERFACES_VERSION": "27.+"
}
},
"platforms": [
"ios",
"android"
]
},
[GitHub] [cordova-ios] mkayander commented on issue #1228: Cookies are blocked in iframe even after disabling ITP
mkayander commented on issue #1228: URL: https://github.com/apache/cordova-ios/issues/1228#issuecomment-1385754256 @abhinavms Thanks for the info! I've tried adding that line, but with no success yet. Is there a specific place in the file that this line should be at? I've currently added it inside the "initWithFrame". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-camera] jfoclpf commented on issue #707: Not working for Android 11
jfoclpf commented on issue #707: URL: https://github.com/apache/cordova-plugin-camera/issues/707#issuecomment-1385011518 @Houdhey why not make a PR to this repo and help others? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-coho] NiklasMerz merged pull request #265: Improve gpg fingerprint documentation
NiklasMerz merged PR #265: URL: https://github.com/apache/cordova-coho/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-coho] NiklasMerz merged pull request #266: Further gpg reading reference in gpg doc
NiklasMerz merged PR #266: URL: https://github.com/apache/cordova-coho/pull/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-coho] NiklasMerz merged pull request #296: Add eslint
NiklasMerz merged PR #296: URL: https://github.com/apache/cordova-coho/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-docs] erisu merged pull request #1284: blog(release): cli@11.1.0, create@4.1.0, fetch@3.1.0, lib@11.1.0
erisu merged PR #1284: URL: https://github.com/apache/cordova-docs/pull/1284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-docs] erisu opened a new pull request, #1284: blog(release): cli@11.1.0, create@4.1.0, fetch@3.1.0, lib@11.1.0
erisu opened a new pull request, #1284: URL: https://github.com/apache/cordova-docs/pull/1284 Release blog post for the latest cli, create, fetch, and lib -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-media-capture] breautek closed issue #266: Types of parameters 'data' and 'value' are incompatible
breautek closed issue #266: Types of parameters 'data' and 'value' are incompatible URL: https://github.com/apache/cordova-plugin-media-capture/issues/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-media-capture] breautek commented on issue #266: Types of parameters 'data' and 'value' are incompatible
breautek commented on issue #266:
URL:
https://github.com/apache/cordova-plugin-media-capture/issues/266#issuecomment-1382898018
According to the error the type is a union type of `MediaFile[] |
CaptureError`, not `MediaFile[]`
Therefore you must declare your type as a union type to match and do the
appropriate checks to isolate the union type, e.g:
```
if (data instanceof Array) {
// Typescript can assume data is of type MediaFile[] in this block
}
else {
// Typescript can assume the type is CaptureError
}
```
Note that while your plugin appears to share the same name as this plugin,
it doesn't appear to be the same as this plugin as these typings do not match
this plugin's
[typings](https://github.com/apache/cordova-plugin-media-capture/blob/65099a34a987dd2a86dc8bc5b2b764387a76b305/types/index.d.ts#L40).
It is likely that ionic, or the maintainers of
`@awesome-cordova-plugins/media-capture/ngx` is what is producing this
alternate API. Therefore if you have further issues or questions, it may be
best to ask them directly.
Closing as this does not appear to be related to Cordova.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-media-capture] devmaxime opened a new issue, #266: Types of parameters 'data' and 'value' are incompatible
devmaxime opened a new issue, #266:
URL: https://github.com/apache/cordova-plugin-media-capture/issues/266
Hello,
On a Ionic V6 app, I cannot use the plugin.
The app is the blank app, with MediaCapture installed and added to providers.
Here is the home.page.ts
```
import { Component } from '@angular/core';
import { MediaCapture, MediaFile, CaptureError, CaptureImageOptions } from
'@awesome-cordova-plugins/media-capture/ngx';
@Component({
selector: 'app-home',
templateUrl: 'home.page.html',
styleUrls: ['home.page.scss'],
})
export class HomePage {
constructor(private mediaCapture: MediaCapture) {}
openCamera(){
let options: CaptureImageOptions = { limit: 3 }
this.mediaCapture.captureImage(options)
.then(
(data: MediaFile[]) => console.log(data),
(err: CaptureError) => console.error(err)
);
}
}
```
Here is the error.
```
[ng] Error: src/app/home/home.page.ts:15:50 - error TS2345: Argument of type
'(data: MediaFile[]) => void' is not assignable to parameter of type '(value:
MediaFile[] | CaptureError) => void |
PromiseLike'.
[ng] Types of parameters 'data' and 'value' are incompatible.
[ng] Type 'MediaFile[] | CaptureError' is not assignable to type
'MediaFile[]'.
[ng] Type 'CaptureError' is missing the following properties from type
'MediaFile[]': length, pop, push, concat, and 26 more.
[ng]
[ng] 15 this.mediaCapture.captureImage(options).then((data: MediaFile[])
=> {
[ng]
[ng]
[ng]
[ng]
[ng] × Failed to compile.
```
I have tried many other ways, cannot make it works. Is it related to ionic
v6 ? How to make it works please ?
Many thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] GitToTheHub opened a new issue, #195: Mark plugin-Tags and engine-Tags as deprecated
GitToTheHub opened a new issue, #195: URL: https://github.com/apache/cordova-common/issues/195 # Bug Report On a conversation on slack it turned out, that plugin-Tags and engine-Tags are deprecated to use in config.xml. It should be clear for the user, that these tags are deprecated and they should be only maintained by the package.json-File. ## Problem There is no hint, that these tags are deprecated. The documentation don't say anything, nor the cli. Some old users could still use the plugin- and engine-Tags in the config.xml and could be wondered what is the right way. ### What is expected to happen? There should be somewhere a hint, that these tags are deprecated. ### What does actually happen? There is nowhere a hint, that these tags are deprecated. ## Checklist - [ ] I searched for existing GitHub issues - [ ] I updated all Cordova tooling to most recent version - [ ] I included all the necessary information above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] tanhatariq commented on issue #154: Status bar visible after focus into input / StatusBar.hide() not working
tanhatariq commented on issue #154: URL: https://github.com/apache/cordova-plugin-statusbar/issues/154#issuecomment-1382665332 I am also facing the same issue with **Status Bar**, the Status bar keeps overlapping the **UI**, until we use any **input**, once any input in App is being focussed out, the status bar starts behaving normally, i have tested this right from _Android 8_ until _Android 13_, real devices and simulators as well, but everywhere the problem remains the same. any help will be deeply appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-coho] NiklasMerz opened a new pull request, #296: Add eslint
NiklasMerz opened a new pull request, #296: URL: https://github.com/apache/cordova-coho/pull/296 ### Platforms affected coho ### Motivation and Context Just add the missing repo eslint ### Description ### Testing Used it for voting ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-browser] dependabot[bot] commented on pull request #108: Bump shelljs from 0.5.3 to 0.8.5
dependabot[bot] commented on PR #108: URL: https://github.com/apache/cordova-browser/pull/108#issuecomment-1381555106 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-browser] jcesarmobile closed pull request #108: Bump shelljs from 0.5.3 to 0.8.5
jcesarmobile closed pull request #108: Bump shelljs from 0.5.3 to 0.8.5 URL: https://github.com/apache/cordova-browser/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-browser] jcesarmobile closed issue #105: Bump shelljs ≥ 0.8.5
jcesarmobile closed issue #105: Bump shelljs ≥ 0.8.5 URL: https://github.com/apache/cordova-browser/issues/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-browser] jcesarmobile merged pull request #115: fix: update shelljs to 0.8.5
jcesarmobile merged PR #115: URL: https://github.com/apache/cordova-browser/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] jindrichkuba opened a new issue, #111: Latest release 4 years ago
jindrichkuba opened a new issue, #111: URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/111 [3.0.2](https://www.npmjs.com/package/cordova-plugin-screen-orientation/v/3.0.2) Hi, can I help you somehow? What is blocking new release? Latest release was 4 years ago, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] erisu merged pull request #37: chore: relax node engine requirement for external users
erisu merged PR #37: URL: https://github.com/apache/cordova-eslint/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] codecov-commenter commented on pull request #37: chore: relax node engine requirement for external users
codecov-commenter commented on PR #37: URL: https://github.com/apache/cordova-eslint/pull/37#issuecomment-1381254867 # [Codecov](https://codecov.io/gh/apache/cordova-eslint/pull/37?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#37](https://codecov.io/gh/apache/cordova-eslint/pull/37?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b10fa4d) into [master](https://codecov.io/gh/apache/cordova-eslint/commit/1e0f4ac8b53e57987fbd5ca1fec1f357db00df1b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1e0f4ac) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ##master #37 +/- ## = Coverage 100.00% 100.00% = Files9 9 Lines9 9 = Hits 9 9 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] erisu opened a new pull request, #37: chore: relax node engine requirement for external users
erisu opened a new pull request, #37: URL: https://github.com/apache/cordova-eslint/pull/37 Match the node engine requirement as ESLint for external users that might want to use our package outside of Cordova. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-ios] chr15m commented on issue #760: XCode cannot build : Cordova.h and Info.plist missing files
chr15m commented on issue #760: URL: https://github.com/apache/cordova-ios/issues/760#issuecomment-1381248625 @dpogue thank you that seems to have fixed the issue so far. Will post here if it happens again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-ios] dpogue commented on issue #760: XCode cannot build : Cordova.h and Info.plist missing files
dpogue commented on issue #760: URL: https://github.com/apache/cordova-ios/issues/760#issuecomment-1381246599 I believe this can happen if you open the project's `.xcodeproj` file rather than the project's `.xcworkspace` file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-ios] fwgood commented on issue #760: XCode cannot build : Cordova.h and Info.plist missing files
fwgood commented on issue #760: URL: https://github.com/apache/cordova-ios/issues/760#issuecomment-1381245952 已收到您的邮件，会尽快回复 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-ios] chr15m commented on issue #760: XCode cannot build : Cordova.h and Info.plist missing files
chr15m commented on issue #760: URL: https://github.com/apache/cordova-ios/issues/760#issuecomment-1381245811 I intermittently get this error in the form of missing Info.plist in the CordovaLib scheme. Selecting the app scheme in XCode does not seem to fix the error. Sometimes the file is generated when running prepare and build, and sometimes it isn't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] dependabot[bot] closed pull request #190: chore(deps): bump json5 from 1.0.1 to 1.0.2
dependabot[bot] closed pull request #190: chore(deps): bump json5 from 1.0.1 to 1.0.2 URL: https://github.com/apache/cordova-common/pull/190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] dependabot[bot] commented on pull request #190: chore(deps): bump json5 from 1.0.1 to 1.0.2
dependabot[bot] commented on PR #190: URL: https://github.com/apache/cordova-common/pull/190#issuecomment-1381234855 Looks like json5 is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] erisu merged pull request #192: dep!: bump all available packages
erisu merged PR #192: URL: https://github.com/apache/cordova-common/pull/192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-browser] codecov-commenter commented on pull request #115: fix: update shelljs to 0.8.5
codecov-commenter commented on PR #115: URL: https://github.com/apache/cordova-browser/pull/115#issuecomment-1381118514 # [Codecov](https://codecov.io/gh/apache/cordova-browser/pull/115?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#115](https://codecov.io/gh/apache/cordova-browser/pull/115?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4805d13) into [master](https://codecov.io/gh/apache/cordova-browser/commit/2218451ad9ed57711ec0ea65aca4e200235a0719?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (2218451) will **increase** coverage by `0.20%`. > The diff coverage is `100.00%`. ```diff @@Coverage Diff @@ ## master #115 +/- ## == + Coverage 93.54% 93.75% +0.20% == Files 22 Lines 31 32 +1 == + Hits 29 30 +1 Misses 22 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-browser/pull/115?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [bin/lib/create.js](https://codecov.io/gh/apache/cordova-browser/pull/115?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YmluL2xpYi9jcmVhdGUuanM=) | `93.33% <100.00%> (+0.22%)` | :arrow_up: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-browser] jcesarmobile opened a new pull request, #115: fix: update shelljs to 0.8.5
jcesarmobile opened a new pull request, #115: URL: https://github.com/apache/cordova-browser/pull/115 Update the shelljs dependency to 0.8.5 as previous versions are vulnerable There is a behavior change in shelljs that requires the `project_path` to exist before doing the first recursive copy or if not it will copy the content of the `cordova` directory instead of creating a `cordova` directory with all the content as 0.5.3 did. That's why there is one line addition. closes https://github.com/apache/cordova-browser/issues/105 closes https://github.com/apache/cordova-browser/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] objmedsyssaro opened a new issue, #990: Keyboard not open in Android device when selecting input fields
objmedsyssaro opened a new issue, #990: URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/990 ### Issue Type - [✓ ] Bug Report - [ ] Feature Request - [ ] Support Question ## Description I used Inappbrowser to show url. iOS Keyboard open successfully but Android with target(_blank) and (_self) keyboard not opening. ## Information Please check any url in Android device and try to type. ### Command or Code ### Environment, Platform, Device ### Version information Inappbrowser@latest ## Checklist - [✓ ] I searched for already existing GitHub issues about this - [ ✓] I updated all Cordova tooling to their most recent version - [ ✓] I included all the necessary information above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] erisu merged pull request #193: dep: replace underscore w/ lodash module pkgs
erisu merged PR #193: URL: https://github.com/apache/cordova-common/pull/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] erisu merged pull request #194: refactor: renamed variable
erisu merged PR #194: URL: https://github.com/apache/cordova-common/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] erisu opened a new pull request, #194: refactor: renamed variable
erisu opened a new pull request, #194: URL: https://github.com/apache/cordova-common/pull/194 ### Platforms affected n/a ### Motivation and Context Clean up variable name ### Description Renamed variable ### Testing n/a ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] erisu merged pull request #186: feat!: bump package requirement node>=16
erisu merged PR #186: URL: https://github.com/apache/cordova-common/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] erisu merged pull request #185: chore: bump version 5.0.0-dev
erisu merged PR #185: URL: https://github.com/apache/cordova-common/pull/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] growthengineering opened a new pull request, #989: Set custom font size
growthengineering opened a new pull request, #989: URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/989 ### Platforms affected ### Motivation and Context ### Description ### Testing ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] codecov-commenter commented on pull request #193: refactor: replace underscore w/ lodash module pkgs
codecov-commenter commented on PR #193: URL: https://github.com/apache/cordova-common/pull/193#issuecomment-1380214976 # [Codecov](https://codecov.io/gh/apache/cordova-common/pull/193?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#193](https://codecov.io/gh/apache/cordova-common/pull/193?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (cfefcd3) into [master](https://codecov.io/gh/apache/cordova-common/commit/b782a724f9fee6c483514ed9c23e4f20c8f9b8e6?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b782a72) will **increase** coverage by `0.03%`. > The diff coverage is `90.00%`. ```diff @@Coverage Diff @@ ## master #193 +/- ## == + Coverage 88.43% 88.46% +0.03% == Files 20 20 Lines1141 1144 +3 == + Hits 1009 1012 +3 Misses132 132 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-common/pull/193?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/superspawn.js](https://codecov.io/gh/apache/cordova-common/pull/193?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3N1cGVyc3Bhd24uanM=) | `85.24% <50.00%> (ø)` | | | [src/util/plist-helpers.js](https://codecov.io/gh/apache/cordova-common/pull/193?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3V0aWwvcGxpc3QtaGVscGVycy5qcw==) | `76.92% <100.00%> (+1.24%)` | :arrow_up: | | [src/util/xml-helpers.js](https://codecov.io/gh/apache/cordova-common/pull/193?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3V0aWwveG1sLWhlbHBlcnMuanM=) | `99.01% <100.00%> (+<0.01%)` | :arrow_up: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] erisu opened a new pull request, #193: refactor: replace underscore w/ lodash module pkgs
erisu opened a new pull request, #193: URL: https://github.com/apache/cordova-common/pull/193 ### Motivation and Context Drop the entire `underscore` package. ### Description Only a few methods from the package was being used. To reduce the size footprint, I replaced with various lodash modules. - `_.extend` -> `lodash.assign` - `_.isDate` -> `lodash.isdate` - `_.isObject` -> `lodash.isobject` - `_.zip` -> `lodash.zip` ### Testing - `npm t` ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] codecov-commenter commented on pull request #192: dep!: bump all available packages
codecov-commenter commented on PR #192: URL: https://github.com/apache/cordova-common/pull/192#issuecomment-1379944086 # [Codecov](https://codecov.io/gh/apache/cordova-common/pull/192?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#192](https://codecov.io/gh/apache/cordova-common/pull/192?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (13910c7) into [master](https://codecov.io/gh/apache/cordova-common/commit/b782a724f9fee6c483514ed9c23e4f20c8f9b8e6?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b782a72) will **decrease** coverage by `0.07%`. > The diff coverage is `50.00%`. ```diff @@Coverage Diff @@ ## master #192 +/- ## == - Coverage 88.43% 88.35% -0.08% == Files 20 20 Lines1141 1142 +1 == Hits 1009 1009 - Misses132 133 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-common/pull/192?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/PluginInfo/PluginInfoProvider.js](https://codecov.io/gh/apache/cordova-common/pull/192?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL1BsdWdpbkluZm8vUGx1Z2luSW5mb1Byb3ZpZGVyLmpz) | `79.31% <0.00%> (-2.84%)` | :arrow_down: | | [src/PlatformJson.js](https://codecov.io/gh/apache/cordova-common/pull/192?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL1BsYXRmb3JtSnNvbi5qcw==) | `78.66% <100.00%> (ø)` | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-common] erisu opened a new pull request, #192: dep!: bump all available packages
erisu opened a new pull request, #192:
URL: https://github.com/apache/cordova-common/pull/192
### Motivation and Context
* Use latetst dependencies
* Resolve npm audit warnings
### Description
**Bumped following dependencies:**
- bplist-parser@^0.3.2
- cross-spawn@^7.0.3
- endent@^2.1.0
- fast-glob@^3.2.12
- fs-extra@^11.1.0
- glob@^8.0.3
- plist@^3.0.6
- underscore@^1.13.6
- @cordova/eslint-config@^4.0.0
- @nodelib/fs.macchiato@^1.0.4
- jasmine@^4.5.0
- jasmine-spec-reporter@^7.0.0
- rewire@^6.0.0
**Updated following code:**
* `endent` method is now on default `require('endent').default`
* Updated `map` to return empty array on error. Resolves lint warning.
### Testing
`npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to
one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the
text above (and used the correct [keyword to close issues using
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] dependabot[bot] closed pull request #36: chore(deps): bump minimatch from 3.0.4 to 3.1.2
dependabot[bot] closed pull request #36: chore(deps): bump minimatch from 3.0.4 to 3.1.2 URL: https://github.com/apache/cordova-eslint/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] dependabot[bot] commented on pull request #36: chore(deps): bump minimatch from 3.0.4 to 3.1.2
dependabot[bot] commented on PR #36: URL: https://github.com/apache/cordova-eslint/pull/36#issuecomment-1379902638 Looks like minimatch is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] dependabot[bot] closed pull request #31: chore(deps): bump json5 from 1.0.1 to 1.0.2
dependabot[bot] closed pull request #31: chore(deps): bump json5 from 1.0.1 to 1.0.2 URL: https://github.com/apache/cordova-eslint/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] dependabot[bot] commented on pull request #31: chore(deps): bump json5 from 1.0.1 to 1.0.2
dependabot[bot] commented on PR #31: URL: https://github.com/apache/cordova-eslint/pull/31#issuecomment-1379902480 Looks like json5 is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] erisu commented on pull request #36: chore(deps): bump minimatch from 3.0.4 to 3.1.2
erisu commented on PR #36: URL: https://github.com/apache/cordova-eslint/pull/36#issuecomment-1379902347 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] erisu commented on pull request #31: chore(deps): bump json5 from 1.0.1 to 1.0.2
erisu commented on PR #31: URL: https://github.com/apache/cordova-eslint/pull/31#issuecomment-1379902243 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] erisu merged pull request #35: dep!: bump all available packages w/ package-lock rebuild
erisu merged PR #35: URL: https://github.com/apache/cordova-eslint/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] erisu merged pull request #34: chore!: bump node engine requirement >=16.0.0
erisu merged PR #34: URL: https://github.com/apache/cordova-eslint/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] dependabot[bot] opened a new pull request, #36: chore(deps): bump minimatch from 3.0.4 to 3.1.2
dependabot[bot] opened a new pull request, #36: URL: https://github.com/apache/cordova-eslint/pull/36 Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. Commits https://github.com/isaacs/minimatch/commit/699c459443a6bd98f5b28197978f76e7f71467ac;>699c459 3.1.2 https://github.com/isaacs/minimatch/commit/2f2b5ff1bb1b6a01f4404f7e475f0a2cba578ab7;>2f2b5ff fix: trim pattern https://github.com/isaacs/minimatch/commit/25d7c0d09c47063c9b0d2ace17ef8e951d90eccc;>25d7c0d 3.1.1 https://github.com/isaacs/minimatch/commit/55dda291dfb595bd11b4edb19b45dd98eda76de0;>55dda29 fix: treat nocase:true as always having magic https://github.com/isaacs/minimatch/commit/5e1fb8dd2bb78c0ae22101b9229fac4c76ef039e;>5e1fb8d 3.1.0 https://github.com/isaacs/minimatch/commit/f8145c54f34075069f4a23cb214d871da4cd4006;>f8145c5 Add 'allowWindowsEscape' option https://github.com/isaacs/minimatch/commit/570e8b1aef6c9e823a824aa0b9be10db43857cd7;>570e8b1 add publishConfig for v3 publishes https://github.com/isaacs/minimatch/commit/5b7cd3372be253759fb4d865eb3f38f189a5fcdf;>5b7cd33 3.0.6 https://github.com/isaacs/minimatch/commit/20b4b562830680867feb75f9c635aca08e5c86ff;>20b4b56 [fix] revert all breaking syntax changes https://github.com/isaacs/minimatch/commit/2ff038852ec03e85e60e0eb333005c680ac8a543;>2ff0388 document, expose, and test 'partial:true' option Additional commits viewable in https://github.com/isaacs/minimatch/compare/v3.0.4...v3.1.2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/cordova-eslint/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] erisu merged pull request #33: ci(gh-actions): update workflow and dependencies
erisu merged PR #33: URL: https://github.com/apache/cordova-eslint/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] erisu merged pull request #32: chore: bump version 5.0.0-dev
erisu merged PR #32: URL: https://github.com/apache/cordova-eslint/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] codecov-commenter commented on pull request #35: dep!: bump all available packages
codecov-commenter commented on PR #35: URL: https://github.com/apache/cordova-eslint/pull/35#issuecomment-1379883188 # [Codecov](https://codecov.io/gh/apache/cordova-eslint/pull/35?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#35](https://codecov.io/gh/apache/cordova-eslint/pull/35?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f418cd3) into [master](https://codecov.io/gh/apache/cordova-eslint/commit/f5b0d4160dcb46ae5efe2e9748f8088ba21a901b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f5b0d41) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ##master #35 +/- ## = Coverage 100.00% 100.00% = Files9 9 Lines9 9 = Hits 9 9 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] erisu opened a new pull request, #35: dep!: bump all available packages
erisu opened a new pull request, #35: URL: https://github.com/apache/cordova-eslint/pull/35 ### Motivation and Context Bump all available node package dependencies. ### Description - eslint@^8.31.0 - eslint-config-standard@^17.0.0 - eslint-plugin-import@^2.27.2 - eslint-plugin-promise@^6.1.1 - jasmine@^4.5.0 Additionally, we replaced `eslint-plugin-node` with `eslint-plugin-n@^15.6.1`. It appears that the maintainer of `eslint-plugin-node` is not active. As apart of bumping ESLint to 8.x, the `CLIEngine` class was replaced with `ESLint`. https://eslint.org/docs/latest/user-guide/migrating-to-8.0.0#remove-cliengine ### Testing n/a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] codecov-commenter commented on pull request #34: chore!: bump node engine requirement >=16.13.0
codecov-commenter commented on PR #34: URL: https://github.com/apache/cordova-eslint/pull/34#issuecomment-1379867193 # [Codecov](https://codecov.io/gh/apache/cordova-eslint/pull/34?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#34](https://codecov.io/gh/apache/cordova-eslint/pull/34?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (7ba2b0a) into [master](https://codecov.io/gh/apache/cordova-eslint/commit/f5b0d4160dcb46ae5efe2e9748f8088ba21a901b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (f5b0d41) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ##master #34 +/- ## = Coverage 100.00% 100.00% = Files9 9 Lines9 9 = Hits 9 9 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[GitHub] [cordova-eslint] erisu opened a new pull request, #34: chore!: bump node engine requirement >=16.13.0
erisu opened a new pull request, #34: URL: https://github.com/apache/cordova-eslint/pull/34 ### Motivation and Context Update node engine requirement ### Description * Define node engine requirement as `>=16.13.0` ### Testing n/a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
