[jira] [Commented] (CB-13774) cordova-plugin-media broken recording and playback functionality

2018-05-15 Thread Kenichi Naito (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475583#comment-16475583
 ] 

Kenichi Naito commented on CB-13774:


What device and android os version did you use?

I tried to test with Nexus 5 and Android 6.0.1. In my case, the Encoding AAC 
and Format AAC_ADTS works.

Further the above PR ([https://github.com/apache/cordova-plugin-media/pull/164] 
) fails because the WEB_MP3_STREAM 
([http://c22033-l.i.core.cdn.streamfarm.net/22033mdr/live/3087mdr_figaro/ch_classic_128.mp3)]
 no longer exists.

> cordova-plugin-media broken recording and playback functionality 
> -
>
> Key: CB-13774
> URL: https://issues.apache.org/jira/browse/CB-13774
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-media
> Environment: Android
>Reporter: Mark Mitchell
>Priority: Blocker
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The problem seems to be that somehow the encoder and decoder are set to 
> different encoding types and are not compatible. Additionally its assuming an 
> encoder is available on the platform and since the interface to the this 
> object does not allow a way to specifying encoding I feel like the default 
> may have been more appropriate. 
> Currently the code is as follows 
> {code:java}
> this.recorder.setOutputFormat(MediaRecorder.OutputFormat.AAC_ADTS); // 
> RAW_AMR);
> this.recorder.setAudioEncoder(MediaRecorder.AudioEncoder.AAC); //AMR_NB);
> {code}
> But trying to play back the recorded audio fails with a decoder error



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-12582) Plugin's Cocoapods don't persist if another plugin is added after it

2018-02-05 Thread Kenichi Naito (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353200#comment-16353200
 ] 

Kenichi Naito edited comment on CB-12582 at 2/6/18 1:40 AM:


{code:java}
`pod install` overrides pbxproj file. Then we should purge cache file.
---
 bin/templates/scripts/cordova/Api.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/templates/scripts/cordova/Api.js 
b/bin/templates/scripts/cordova/Api.js
index dd50d11f..04da4a1b 100644
--- a/bin/templates/scripts/cordova/Api.js
+++ b/bin/templates/scripts/cordova/Api.js
@@ -285,6 +285,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) 
{
 if (podfileFile.isDirty()) {
 podfileFile.write();
 events.emit('verbose', 'Running `pod install` (to install 
plugins)');
+    projectFile.purgeProjectFileCache(self.locations.root);
 
 return podfileFile.install(check_reqs.check_cocoapods);
 } else {
--
2.14.2
{code}
 


was (Author: knaito):
{code:java}
---
 bin/templates/scripts/cordova/Api.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/templates/scripts/cordova/Api.js 
b/bin/templates/scripts/cordova/Api.js
index dd50d11f..04da4a1b 100644
--- a/bin/templates/scripts/cordova/Api.js
+++ b/bin/templates/scripts/cordova/Api.js
@@ -285,6 +285,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) 
{
 if (podfileFile.isDirty()) {
 podfileFile.write();
 events.emit('verbose', 'Running `pod install` (to install 
plugins)');
+    projectFile.purgeProjectFileCache(self.locations.root);
 
 return podfileFile.install(check_reqs.check_cocoapods);
 } else {
--
2.14.2
{code}
 

> Plugin's Cocoapods don't persist if another plugin is added after it
> 
>
> Key: CB-12582
> URL: https://issues.apache.org/jira/browse/CB-12582
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios@4.3.1, 6.5.0
>Reporter: Kyle Kirbatski
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@4.5.1
>
> Attachments: 0001-exec-purgeProjectFileCache-when-pod-install.patch
>
>
> I was trying to use the urbanairship-cordova plugin but was unable to because 
> the frameworks added by Cocoapods (referenced from the plugin's xml) were not 
> being found for linking. After some investigation it appears that if a plugin 
> is added after a plugin that uses cocoapods then the changes made by 
> cocoapods are removed by cordova.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-12582) Plugin's Cocoapods don't persist if another plugin is added after it

2018-02-05 Thread Kenichi Naito (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353200#comment-16353200
 ] 

Kenichi Naito edited comment on CB-12582 at 2/6/18 1:39 AM:


{code:java}
---
 bin/templates/scripts/cordova/Api.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/templates/scripts/cordova/Api.js 
b/bin/templates/scripts/cordova/Api.js
index dd50d11f..04da4a1b 100644
--- a/bin/templates/scripts/cordova/Api.js
+++ b/bin/templates/scripts/cordova/Api.js
@@ -285,6 +285,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) 
{
 if (podfileFile.isDirty()) {
 podfileFile.write();
 events.emit('verbose', 'Running `pod install` (to install 
plugins)');
+    projectFile.purgeProjectFileCache(self.locations.root);
 
 return podfileFile.install(check_reqs.check_cocoapods);
 } else {
--
2.14.2
{code}
 


was (Author: knaito):
```
---
 bin/templates/scripts/cordova/Api.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/templates/scripts/cordova/Api.js 
b/bin/templates/scripts/cordova/Api.js
index dd50d11f..04da4a1b 100644
--- a/bin/templates/scripts/cordova/Api.js
+++ b/bin/templates/scripts/cordova/Api.js
@@ -285,6 +285,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) 
{
 if (podfileFile.isDirty()) {
 podfileFile.write();
 events.emit('verbose', 'Running `pod install` (to install 
plugins)');
+projectFile.purgeProjectFileCache(self.locations.root);
 
 return podfileFile.install(check_reqs.check_cocoapods);
 } else {
-- 
2.14.2
```

> Plugin's Cocoapods don't persist if another plugin is added after it
> 
>
> Key: CB-12582
> URL: https://issues.apache.org/jira/browse/CB-12582
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios@4.3.1, 6.5.0
>Reporter: Kyle Kirbatski
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@4.5.1
>
> Attachments: 0001-exec-purgeProjectFileCache-when-pod-install.patch
>
>
> I was trying to use the urbanairship-cordova plugin but was unable to because 
> the frameworks added by Cocoapods (referenced from the plugin's xml) were not 
> being found for linking. After some investigation it appears that if a plugin 
> is added after a plugin that uses cocoapods then the changes made by 
> cocoapods are removed by cordova.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-12582) Plugin's Cocoapods don't persist if another plugin is added after it

2018-02-05 Thread Kenichi Naito (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353200#comment-16353200
 ] 

Kenichi Naito edited comment on CB-12582 at 2/6/18 1:30 AM:


```
---
 bin/templates/scripts/cordova/Api.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/templates/scripts/cordova/Api.js 
b/bin/templates/scripts/cordova/Api.js
index dd50d11f..04da4a1b 100644
--- a/bin/templates/scripts/cordova/Api.js
+++ b/bin/templates/scripts/cordova/Api.js
@@ -285,6 +285,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) 
{
 if (podfileFile.isDirty()) {
 podfileFile.write();
 events.emit('verbose', 'Running `pod install` (to install 
plugins)');
+projectFile.purgeProjectFileCache(self.locations.root);
 
 return podfileFile.install(check_reqs.check_cocoapods);
 } else {
-- 
2.14.2
```


was (Author: knaito):
```
---
 bin/templates/scripts/cordova/Api.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/templates/scripts/cordova/Api.js 
b/bin/templates/scripts/cordova/Api.js
index dd50d11f..04da4a1b 100644
--- a/bin/templates/scripts/cordova/Api.js
+++ b/bin/templates/scripts/cordova/Api.js
@@ -285,6 +285,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) 
{
 if (podfileFile.isDirty()) {
 podfileFile.write();
 events.emit('verbose', 'Running `pod install` (to install 
plugins)');
+    projectFile.purgeProjectFileCache(self.locations.root);
 
 return podfileFile.install(check_reqs.check_cocoapods);
 } else {
-- 
2.14.2
```

> Plugin's Cocoapods don't persist if another plugin is added after it
> 
>
> Key: CB-12582
> URL: https://issues.apache.org/jira/browse/CB-12582
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios@4.3.1, 6.5.0
>Reporter: Kyle Kirbatski
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@4.5.1
>
> Attachments: 0001-exec-purgeProjectFileCache-when-pod-install.patch
>
>
> I was trying to use the urbanairship-cordova plugin but was unable to because 
> the frameworks added by Cocoapods (referenced from the plugin's xml) were not 
> being found for linking. After some investigation it appears that if a plugin 
> is added after a plugin that uses cocoapods then the changes made by 
> cocoapods are removed by cordova.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12582) Plugin's Cocoapods don't persist if another plugin is added after it

2018-02-05 Thread Kenichi Naito (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353200#comment-16353200
 ] 

Kenichi Naito commented on CB-12582:


```
---
 bin/templates/scripts/cordova/Api.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/templates/scripts/cordova/Api.js 
b/bin/templates/scripts/cordova/Api.js
index dd50d11f..04da4a1b 100644
--- a/bin/templates/scripts/cordova/Api.js
+++ b/bin/templates/scripts/cordova/Api.js
@@ -285,6 +285,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) 
{
 if (podfileFile.isDirty()) {
 podfileFile.write();
 events.emit('verbose', 'Running `pod install` (to install 
plugins)');
+    projectFile.purgeProjectFileCache(self.locations.root);
 
 return podfileFile.install(check_reqs.check_cocoapods);
 } else {
-- 
2.14.2
```

> Plugin's Cocoapods don't persist if another plugin is added after it
> 
>
> Key: CB-12582
> URL: https://issues.apache.org/jira/browse/CB-12582
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios@4.3.1, 6.5.0
>Reporter: Kyle Kirbatski
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@4.5.1
>
> Attachments: 0001-exec-purgeProjectFileCache-when-pod-install.patch
>
>
> I was trying to use the urbanairship-cordova plugin but was unable to because 
> the frameworks added by Cocoapods (referenced from the plugin's xml) were not 
> being found for linking. After some investigation it appears that if a plugin 
> is added after a plugin that uses cocoapods then the changes made by 
> cocoapods are removed by cordova.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-12582) Plugin's Cocoapods don't persist if another plugin is added after it

2018-02-05 Thread Kenichi Naito (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kenichi Naito updated CB-12582:
---
Attachment: 0001-exec-purgeProjectFileCache-when-pod-install.patch

> Plugin's Cocoapods don't persist if another plugin is added after it
> 
>
> Key: CB-12582
> URL: https://issues.apache.org/jira/browse/CB-12582
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios@4.3.1, 6.5.0
>Reporter: Kyle Kirbatski
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@4.5.1
>
> Attachments: 0001-exec-purgeProjectFileCache-when-pod-install.patch
>
>
> I was trying to use the urbanairship-cordova plugin but was unable to because 
> the frameworks added by Cocoapods (referenced from the plugin's xml) were not 
> being found for linking. After some investigation it appears that if a plugin 
> is added after a plugin that uses cocoapods then the changes made by 
> cocoapods are removed by cordova.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-12582) Plugin's Cocoapods don't persist if another plugin is added after it

2018-01-29 Thread Kenichi Naito (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344540#comment-16344540
 ] 

Kenichi Naito commented on CB-12582:


I think my PR is for this issue.

[https://github.com/apache/cordova-ios/pull/354#issuecomment-361147525]

 

> Plugin's Cocoapods don't persist if another plugin is added after it
> 
>
> Key: CB-12582
> URL: https://issues.apache.org/jira/browse/CB-12582
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova-ios@4.3.1, 6.5.0
>Reporter: Kyle Kirbatski
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@4.5.1
>
>
> I was trying to use the urbanairship-cordova plugin but was unable to because 
> the frameworks added by Cocoapods (referenced from the plugin's xml) were not 
> being found for linking. After some investigation it appears that if a plugin 
> is added after a plugin that uses cocoapods then the changes made by 
> cocoapods are removed by cordova.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.

2017-10-31 Thread Kenichi Naito (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233657#comment-16233657
 ] 

Kenichi Naito edited comment on CB-13496 at 11/1/17 4:52 AM:
-

Thanks, Audrey.

For example if you add the plugin where plugin.xml has
```

  

  $(AppIdentifierPrefix)$PACKAGE_NAME
  $(AppIdentifierPrefix)com.example.mylib

  
```
the Entitlements-Debug.plist becomes
```
  
keychain-access-groups

  $(AppIdentifierPrefix)io.cordova.hellocordova
  $(AppIdentifierPrefix)com.example.mylib

  
```
However after cordova prepare command, the Entitlements-Debug.plist  becomes
```
  
keychain-access-groups

  $(AppIdentifierPrefix)io.cordova.hellocordova

  
```
because nodeEqual function treats the above two string as `(.*?)`. Therefore
one of two is removed.


was (Author: knaito):
Thanks, Audrey.

For example if you add the plugin where plugin.xml has
```

  

  $(AppIdentifierPrefix)$PACKAGE_NAME
  $(AppIdentifierPrefix)com.example.mylib

  
```
the Entitlements-Debug.plist becomes
```
  
keychain-access-groups

  $(AppIdentifierPrefix)io.cordova.hellocordova
  $(AppIdentifierPrefix)com.example.mylib

  
```
However after cordova prepare command, the Entitlements-Debug.plist  becomes
```
  
keychain-access-groups

  $(AppIdentifierPrefix)io.cordova.hellocordova

  
```
because nodeEqual function treat the above two string as `(.*?)`. Therefore
one of two is removed.

> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Kenichi Naito
>   Original Estimate: 504h
>  Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.

2017-10-31 Thread Kenichi Naito (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233657#comment-16233657
 ] 

Kenichi Naito edited comment on CB-13496 at 11/1/17 4:52 AM:
-

Thanks, Audrey.

For example if you add the plugin where plugin.xml has
```

  

  $(AppIdentifierPrefix)$PACKAGE_NAME
  $(AppIdentifierPrefix)com.example.mylib

  
```
the Entitlements-Debug.plist becomes
```
  
keychain-access-groups

  $(AppIdentifierPrefix)io.cordova.hellocordova
  $(AppIdentifierPrefix)com.example.mylib

  
```
However after cordova prepare command, the Entitlements-Debug.plist  becomes
```
  
keychain-access-groups

  $(AppIdentifierPrefix)io.cordova.hellocordova

  
```
because nodeEqual function treat the above two string as `(.*?)`. Therefore
one of two is removed.


was (Author: knaito):
Thanks, Audrey.

For example if you add the plugin where plugin.xml has
```

  

  $(AppIdentifierPrefix)$PACKAGE_NAME
  $(AppIdentifierPrefix)com.example.mylib

  
```
the Entitlements-Debug.plist becomes
```
  
keychain-access-groups

  $(AppIdentifierPrefix)io.cordova.hellocordova
  $(AppIdentifierPrefix)com.example.mylib

  
```
However after cordova prepare command, this becomes
```
  
keychain-access-groups

  $(AppIdentifierPrefix)io.cordova.hellocordova

  
```
because nodeEqual function treat the above two string as `(.*?)`. Therefore
one of two is removed.

> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Kenichi Naito
>   Original Estimate: 504h
>  Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Comment Edited] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.

2017-10-31 Thread Kenichi Naito (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233657#comment-16233657
 ] 

Kenichi Naito edited comment on CB-13496 at 11/1/17 4:51 AM:
-

Thanks, Audrey.

For example if you add the plugin where plugin.xml has
```

  

  $(AppIdentifierPrefix)$PACKAGE_NAME
  $(AppIdentifierPrefix)com.example.mylib

  
```
the Entitlements-Debug.plist becomes
```
  
keychain-access-groups

  $(AppIdentifierPrefix)io.cordova.hellocordova
  $(AppIdentifierPrefix)com.example.mylib

  
```
However after cordova prepare command, this becomes
```
  
keychain-access-groups

  $(AppIdentifierPrefix)io.cordova.hellocordova

  
```
because nodeEqual function treat the above two string as `(.*?)`. Therefore
one of two is removed.


was (Author: knaito):
Thanks, Audrey.

For example if you add the plugin with plugin.xml as
```

  

  $(AppIdentifierPrefix)$PACKAGE_NAME
  $(AppIdentifierPrefix)com.example.mylib

  
```
the Entitlements-Debug.plist becomes
```
  
keychain-access-groups

  $(AppIdentifierPrefix)io.cordova.hellocordova
  $(AppIdentifierPrefix)com.example.mylib

  
```
However after cordova prepare command, this becomes
```
  
keychain-access-groups

  $(AppIdentifierPrefix)io.cordova.hellocordova

  
```
because nodeEqual function treat the above two string as `(.*?)`. Therefore
one of two is removed.

> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Kenichi Naito
>   Original Estimate: 504h
>  Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.

2017-10-31 Thread Kenichi Naito (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233657#comment-16233657
 ] 

Kenichi Naito commented on CB-13496:


Thanks, Audrey.

For example if you add the plugin with plugin.xml as
```

  

  $(AppIdentifierPrefix)$PACKAGE_NAME
  $(AppIdentifierPrefix)com.example.mylib

  
```
the Entitlements-Debug.plist becomes
```
  
keychain-access-groups

  $(AppIdentifierPrefix)io.cordova.hellocordova
  $(AppIdentifierPrefix)com.example.mylib

  
```
However after cordova prepare command, this becomes
```
  
keychain-access-groups

  $(AppIdentifierPrefix)io.cordova.hellocordova

  
```
because nodeEqual function treat the above two string as `(.*?)`. Therefore
one of two is removed.

> the plugin config-file tag for iOS plist array behaves unnaturally.
> ---
>
> Key: CB-13496
> URL: https://issues.apache.org/jira/browse/CB-13496
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-common
>Affects Versions: 2.1.0
> Environment: Mac OSX
>Reporter: Kenichi Naito
>   Original Estimate: 504h
>  Remaining Estimate: 504h
>
> In the src/util/plist-helpers.js, in the nodeEqual function,
> ```
> node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
> ```
> seems the strange behavior.
> For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".
> In the previous version of this code is
> ```
> node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
> ```
> in this case, the escaped node2 "$(ABC)Hello" is unchaned.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-13496) the plugin config-file tag for iOS plist array behaves unnaturally.

2017-10-26 Thread Kenichi Naito (JIRA)
Kenichi Naito created CB-13496:
--

 Summary: the plugin config-file tag for iOS plist array behaves 
unnaturally.
 Key: CB-13496
 URL: https://issues.apache.org/jira/browse/CB-13496
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-common
Affects Versions: 2.1.0
 Environment: Mac OSX
Reporter: Kenichi Naito
Priority: Trivial


In the src/util/plist-helpers.js, in the nodeEqual function,
```
node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
```
seems the strange behavior.
For example, the escaped node2 "$(ABC)Hello" becomes "(.*?)".

In the previous version of this code is
```
node2 = escapeRE(node2).replace(new RegExp('\\$[a-zA-Z0-9-_]+','gm'),'(.*?)');
```
in this case, the escaped node2 "$(ABC)Hello" is unchaned.





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org