[jira] [Closed] (CB-9205) Whitelist "launch-external" setting does nothing

2015-12-16 Thread Steve Hull (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-9205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Hull closed CB-9205.
--
   Resolution: Invalid
Fix Version/s: 5.0.1

I'll test out the related functionality mentioned by Jesse later.

It's less of an issue since Apple was adamant (after a few versions of our app 
already shipped) that there are _zero_ links to the web in our app (this was 
while we were frantically trying to ship a fix to 7.0.2).

Anyway thanks Jesse!

> Whitelist "launch-external" setting does nothing
> 
>
> Key: CB-9205
> URL: https://issues.apache.org/jira/browse/CB-9205
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Whitelist
>Affects Versions: 3.8.0
> Environment: OSX 10.10
> Cordova 3.8.0
> iOS 8.3
>Reporter: Steve Hull
> Fix For: 5.0.1
>
>
> according to [cordova 
> docs|http://cordova.apache.org/docs/en/4.0.0/guide_appdev_whitelist_index.md.html#external-application-whitelist],
>  you should be able to specify in the config file which urls will open in an 
> external browser by setting:
> {{http://example.com/*; launch-external="yes" />}}
> However this does nothing.
> I've looked into the definition of {{shouldStartLoadWithRequest}}, and it 
> does indeed have a line near the bottom that would load the url in the 
> external system browser ({{[[UIApplication sharedApplication] 
> openURL:url]}}), however it appears that it would be impossible for this line 
> to be executed as long as the protocol is {{http}} or {{https}}.
> I'm not sure what the "correct" way is to address this, however it seems that 
> old versions of the docs should be updated to reflect that 
> {{launch-external}} does not do anything and maybe we could start paying 
> attention to that config attribute going forward.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-9205) Whitelist launch-external setting does nothing

2015-06-17 Thread Steve Hull (JIRA)
Steve Hull created CB-9205:
--

 Summary: Whitelist launch-external setting does nothing
 Key: CB-9205
 URL: https://issues.apache.org/jira/browse/CB-9205
 Project: Apache Cordova
  Issue Type: Bug
Affects Versions: 3.8.0
 Environment: OSX 10.10
Cordova 3.8.0
iOS 8.3
Reporter: Steve Hull


according to [cordova 
docs|http://cordova.apache.org/docs/en/4.0.0/guide_appdev_whitelist_index.md.html#external-application-whitelist],
 you should be able to specify in the config file which urls will open in an 
external browser by setting:

{{access origin=http://example.com/*; launch-external=yes /}}

However this does nothing.

I've looked into the definition of {{shouldStartLoadWithRequest}}, and it does 
indeed have a line near the bottom that would load the url in the external 
system browser ({{[[UIApplication sharedApplication] openURL:url]}}), however 
it appears that it would be impossible for this line to be executed as long as 
the protocol is {{http}} or {{https}}.

I'm not sure what the correct way is to address this, however it seems that 
old versions of the docs should be updated to reflect that {{launch-external}} 
does not do anything and maybe we could start paying attention to that config 
attribute going forward.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org