[jira] [Commented] (CB-13932) APK Not Copied to Visual Studio bin Directory
[
https://issues.apache.org/jira/browse/CB-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382175#comment-16382175
]
Terence Bandoian commented on CB-13932:
---
I believe that's correct.
Are you suggesting this should be fixed in Visual Studio?
Conversely, would it make sense for cordova-android to copy the APK to the
previously supported directory to maintain compatibility? If Visual Studio is
detected?
For a broader solution, it seems like there could be a standard location for
all Cordova builds. Those build artifacts could then be copied to other
locations to support one IDE/environment or another. And all build
destinations could potentially be configurable.
> APK Not Copied to Visual Studio bin Directory
> -
>
> Key: CB-13932
> URL: https://issues.apache.org/jira/browse/CB-13932
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: cordova@8.0
> cordova-android@7.1.0
> Visual Studio 2017
> Windows 10
>Reporter: Terence Bandoian
>Assignee: Joe Bowser
>Priority: Minor
>
> With Visual Studio 2017 configured to use the globally installed Cordova CLI
> (8.0) instead of the version packaged with Visual Studio, debug APKs
> generated with cordova-android@7.1.0 are not copied to the project bin
> directory.
> Debug APKs are written to:
> {code:java}
> platforms/android/app/build/outputs/apk/debug/app-debug.apk
> {code}
> Visual Studio apparently expects APKs to be written to:
> {code:java}
> bin/Android/Debug/android-debug.apk{code}
> This prevents initiatiation of a debug session on a device from within Visual
> Studio.
> A simple after_build script such as the following:
> {code:java}
> module.exports = function (ctx) {
> if (ctx.opts.platforms.indexOf('android') < 0) {
> return;
> }
> var fs = ctx.requireCordovaModule('fs'),
> path = ctx.requireCordovaModule('path');
> var src = path.join(
> ctx.opts.projectRoot,
> 'platforms/android/app/build/outputs/apk/debug/app-debug.apk');
> var dst = path.join(
> ctx.opts.projectRoot,
> 'bin/Android/Debug/android-debug.apk');
> fs.copyFileSync(src, dst);
> return 0;
> };
> {code}
> is an effective work-around but the development experience would be improved
> if it wasn't necessary to expend the extra effort to determine the cause and
> implement a solution.
> The most recent version of cordova-android that I know of where this is not
> necessary is 6.3.0. I haven't tested 6.4.0 or 7.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13932) APK Not Copied to Visual Studio bin Directory
[
https://issues.apache.org/jira/browse/CB-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382061#comment-16382061
]
Terence Bandoian commented on CB-13932:
---
For what it's worth, Visual Studio 2017 is packaged with cordova@6.3.1 and
cordova-android@6.2.3.
> APK Not Copied to Visual Studio bin Directory
> -
>
> Key: CB-13932
> URL: https://issues.apache.org/jira/browse/CB-13932
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: cordova@8.0
> cordova-android@7.1.0
> Visual Studio 2017
> Windows 10
>Reporter: Terence Bandoian
>Assignee: Joe Bowser
>Priority: Minor
>
> With Visual Studio 2017 configured to use the globally installed Cordova CLI
> (8.0) instead of the version packaged with Visual Studio, debug APKs
> generated with cordova-android@7.1.0 are not copied to the project bin
> directory.
> Debug APKs are written to:
> {code:java}
> platforms/android/app/build/outputs/apk/debug/app-debug.apk
> {code}
> Visual Studio apparently expects APKs to be written to:
> {code:java}
> bin/Android/Debug/android-debug.apk{code}
> This prevents initiatiation of a debug session on a device from within Visual
> Studio.
> A simple after_build script such as the following:
> {code:java}
> module.exports = function (ctx) {
> if (ctx.opts.platforms.indexOf('android') < 0) {
> return;
> }
> var fs = ctx.requireCordovaModule('fs'),
> path = ctx.requireCordovaModule('path');
> var src = path.join(
> ctx.opts.projectRoot,
> 'platforms/android/app/build/outputs/apk/debug/app-debug.apk');
> var dst = path.join(
> ctx.opts.projectRoot,
> 'bin/Android/Debug/android-debug.apk');
> fs.copyFileSync(src, dst);
> return 0;
> };
> {code}
> is an effective work-around but the development experience would be improved
> if it wasn't necessary to expend the extra effort to determine the cause and
> implement a solution.
> The most recent version of cordova-android that I know of where this is not
> necessary is 6.3.0. I haven't tested 6.4.0 or 7.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13932) APK Not Copied to Visual Studio bin Directory
[
https://issues.apache.org/jira/browse/CB-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382019#comment-16382019
]
Terence Bandoian commented on CB-13932:
---
In Visual Studio 2017, if the option to use a globally installed Cordova CLI is
selected, the build is executed externally. Upon completion, Visual Studio
uses the generated APK to begin a debug session. This worked with
cordova@7.1.0 and cordova-android@6.3.0. Does that make sense?
> APK Not Copied to Visual Studio bin Directory
> -
>
> Key: CB-13932
> URL: https://issues.apache.org/jira/browse/CB-13932
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: cordova@8.0
> cordova-android@7.1.0
> Visual Studio 2017
> Windows 10
>Reporter: Terence Bandoian
>Assignee: Joe Bowser
>Priority: Minor
>
> With Visual Studio 2017 configured to use the globally installed Cordova CLI
> (8.0) instead of the version packaged with Visual Studio, debug APKs
> generated with cordova-android@7.1.0 are not copied to the project bin
> directory.
> Debug APKs are written to:
> {code:java}
> platforms/android/app/build/outputs/apk/debug/app-debug.apk
> {code}
> Visual Studio apparently expects APKs to be written to:
> {code:java}
> bin/Android/Debug/android-debug.apk{code}
> This prevents initiatiation of a debug session on a device from within Visual
> Studio.
> A simple after_build script such as the following:
> {code:java}
> module.exports = function (ctx) {
> if (ctx.opts.platforms.indexOf('android') < 0) {
> return;
> }
> var fs = ctx.requireCordovaModule('fs'),
> path = ctx.requireCordovaModule('path');
> var src = path.join(
> ctx.opts.projectRoot,
> 'platforms/android/app/build/outputs/apk/debug/app-debug.apk');
> var dst = path.join(
> ctx.opts.projectRoot,
> 'bin/Android/Debug/android-debug.apk');
> fs.copyFileSync(src, dst);
> return 0;
> };
> {code}
> is an effective work-around but the development experience would be improved
> if it wasn't necessary to expend the extra effort to determine the cause and
> implement a solution.
> The most recent version of cordova-android that I know of where this is not
> necessary is 6.3.0. I haven't tested 6.4.0 or 7.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13932) APK Not Copied to Visual Studio bin Directory
[
https://issues.apache.org/jira/browse/CB-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terence Bandoian updated CB-13932:
--
Description:
With Visual Studio 2017 configured to use the globally installed Cordova CLI
(8.0) instead of the version packaged with Visual Studio, debug APKs generated
with cordova-android@7.1.0 are not copied to the project bin directory.
Debug APKs are written to:
{code:java}
platforms/android/app/build/outputs/apk/debug/app-debug.apk
{code}
Visual Studio apparently expects APKs to be written to:
{code:java}
bin/Android/Debug/android-debug.apk{code}
This prevents initiatiation of a debug session on a device from within Visual
Studio.
A simple after_build script such as the following:
{code:java}
module.exports = function (ctx) {
if (ctx.opts.platforms.indexOf('android') < 0) {
return;
}
var fs = ctx.requireCordovaModule('fs'),
path = ctx.requireCordovaModule('path');
var src = path.join(
ctx.opts.projectRoot,
'platforms/android/app/build/outputs/apk/debug/app-debug.apk');
var dst = path.join(
ctx.opts.projectRoot,
'bin/Android/Debug/android-debug.apk');
fs.copyFileSync(src, dst);
return 0;
};
{code}
is an effective work-around but the development experience would be improved if
it wasn't necessary to expend the extra effort to determine the cause and
implement a solution.
The most recent version of cordova-android that I know of where this is not
necessary is 6.3.0. I haven't tested 6.4.0 or 7.0.0.
was:
With Visual Studio 2017 configured to use the globally installed Cordova CLI
(8.0) instead of the version packaged with Visual Studio, debug APKs generated
with cordova-android@7.1.0 are not copied to the project bin directory.
Debug APKs are written to:
{code:java}
platforms/android/app/build/outputs/apk/debug/app-debug.apk
{code}
Visual Studio apparently expects APKs to be written to:
{code:java}
bin/Android/Debug/android-debug.apk{code}
This prevents initiatiation of a debug session on a device from within Visual
Studio.
A simple after_build script such as the following:
{code:java}
module.exports = function (ctx) {
if (ctx.opts.platforms.indexOf('android') < 0) {
return;
}
var fs = ctx.requireCordovaModule('fs'),
path = ctx.requireCordovaModule('path');
var src = path.join(
ctx.opts.projectRoot,
'platforms/android/app/build/outputs/apk/debug/app-debug.apk');
var dst = path.join(
ctx.opts.projectRoot,
'bin/Android/Debug/android-debug.apk');
fs.copyFileSync(src, dst);
return 0;
};
{code}
is an effective work-around but the development experience would be improved if
it wasn't necessary to expend the extra effort to determine the cause and
implement a solution.
The most recent version of cordova-android that I know of where this is not
necessary is 6.3.0. I haven't tested 6.4.0 or 7.0.0.
> APK Not Copied to Visual Studio bin Directory
> -
>
> Key: CB-13932
> URL: https://issues.apache.org/jira/browse/CB-13932
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: cordova@8.0
> cordova-android@7.1.0
> Visual Studio 2017
> Windows 10
>Reporter: Terence Bandoian
>Assignee: Joe Bowser
>Priority: Minor
>
> With Visual Studio 2017 configured to use the globally installed Cordova CLI
> (8.0) instead of the version packaged with Visual Studio, debug APKs
> generated with cordova-android@7.1.0 are not copied to the project bin
> directory.
> Debug APKs are written to:
> {code:java}
> platforms/android/app/build/outputs/apk/debug/app-debug.apk
> {code}
> Visual Studio apparently expects APKs to be written to:
> {code:java}
> bin/Android/Debug/android-debug.apk{code}
> This prevents initiatiation of a debug session on a device from within Visual
> Studio.
> A simple after_build script such as the following:
> {code:java}
> module.exports = function (ctx) {
> if (ctx.opts.platforms.indexOf('android') < 0) {
> return;
> }
> var fs = ctx.requireCordovaModule('fs'),
> path = ctx.requireCordovaModule('path');
> var src = path.join(
> ctx.opts.projectRoot,
> 'platforms/android/app/build/outputs/apk/debug/app-debug.apk');
> var dst = path.join(
> ctx.opts.projectRoot,
> 'bin/Android/Debug/android-debug.apk');
> fs.copyFileSync(src, dst);
> return 0;
> };
> {code}
> is an effective work-around but the development experience would be improved
> if it wasn't necessary to expend the extra effort to determine the cause and
> implement a solution.
> The most recent version of cordova-android that I know of where this is
[jira] [Created] (CB-13932) APK Not Copied to Visual Studio bin Directory
Terence Bandoian created CB-13932:
-
Summary: APK Not Copied to Visual Studio bin Directory
Key: CB-13932
URL: https://issues.apache.org/jira/browse/CB-13932
Project: Apache Cordova
Issue Type: Improvement
Components: cordova-android
Affects Versions: cordova-android-7.0.0
Environment: cordova@8.0
cordova-android@7.1.0
Visual Studio 2017
Windows 10
Reporter: Terence Bandoian
Assignee: Joe Bowser
With Visual Studio 2017 configured to use the globally installed Cordova CLI
(8.0) instead of the version packaged with Visual Studio, debug APKs generated
with cordova-android@7.1.0 are not copied to the project bin directory.
Debug APKs are written to:
{code:java}
platforms/android/app/build/outputs/apk/debug/app-debug.apk
{code}
Visual Studio apparently expects APKs to be written to:
{code:java}
bin/Android/Debug/android-debug.apk{code}
This prevents initiatiation of a debug session on a device from within Visual
Studio.
A simple after_build script such as the following:
{code:java}
module.exports = function (ctx) {
if (ctx.opts.platforms.indexOf('android') < 0) {
return;
}
var fs = ctx.requireCordovaModule('fs'),
path = ctx.requireCordovaModule('path');
var src = path.join(
ctx.opts.projectRoot,
'platforms/android/app/build/outputs/apk/debug/app-debug.apk');
var dst = path.join(
ctx.opts.projectRoot,
'bin/Android/Debug/android-debug.apk');
fs.copyFileSync(src, dst);
return 0;
};
{code}
is an effective work-around but the development experience would be improved if
it wasn't necessary to expend the extra effort to determine the cause and
implement a solution.
The most recent version of cordova-android that I know of where this is not
necessary is 6.3.0. I haven't tested 6.4.0 or 7.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13917) Windows 10 Min Version Must Be Configured Twice in Config.xml
[
https://issues.apache.org/jira/browse/CB-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terence Bandoian updated CB-13917:
--
Description:
In config.xml, the minimum Windows 10 version preference must be set with both:
{{ uap-target-min-version}}
{{ Windows.Universal-MinVersion}}
Setting {{uap-target-min-version}} results in the value being copied to
CordovaApp.Windows10.jsproj.
Setting {{Windows.Universal-MinVersion}} results in the value being copied to
package.windows10.appxmanifest.
If {{uap-target-min-version}} is not set, the minimum version of the app in the
Microsoft Store is incorrect.
Development of Windows 10 apps would be simplified by only having to set the
minimum version in one place.
was:
In config.xml, the minimum Windows 10 version preference must be set with both:
{{ uap-target-min-version}}
{{ Windows.Universal-MinVersion}}{{}}
Setting {{uap-target-min-version}} results in the value being copied to
CordovaApp.Windows10.jsproj.
Setting {{Windows.Universal-MinVersion}} results in the value being copied to
package.windows10.appxmanifest.
If {{uap-target-min-version}} is not set, the minimum version of the app in the
Microsoft Store is incorrect.
Development of Windows 10 apps would be simplified by only having to set the
minimum version in one place.
> Windows 10 Min Version Must Be Configured Twice in Config.xml
> -
>
> Key: CB-13917
> URL: https://issues.apache.org/jira/browse/CB-13917
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10
> Cordova 7.1.0
>Reporter: Terence Bandoian
>Assignee: Jesse MacFadyen
>Priority: Major
> Labels: usability, windows
>
> In config.xml, the minimum Windows 10 version preference must be set with
> both:
> {{ uap-target-min-version}}
> {{ Windows.Universal-MinVersion}}
> Setting {{uap-target-min-version}} results in the value being copied to
> CordovaApp.Windows10.jsproj.
> Setting {{Windows.Universal-MinVersion}} results in the value being copied to
> package.windows10.appxmanifest.
> If {{uap-target-min-version}} is not set, the minimum version of the app in
> the Microsoft Store is incorrect.
> Development of Windows 10 apps would be simplified by only having to set the
> minimum version in one place.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13917) Windows 10 Min Version Must Be Configured Twice in Config.xml
Terence Bandoian created CB-13917:
-
Summary: Windows 10 Min Version Must Be Configured Twice in
Config.xml
Key: CB-13917
URL: https://issues.apache.org/jira/browse/CB-13917
Project: Apache Cordova
Issue Type: Improvement
Components: cordova-windows
Affects Versions: cordova@7.0.0
Environment: Windows 10
Cordova 7.1.0
Reporter: Terence Bandoian
Assignee: Jesse MacFadyen
In config.xml, the minimum Windows 10 version preference must be set with both:
{{ uap-target-min-version}}
{{ Windows.Universal-MinVersion}}{{}}
Setting {{uap-target-min-version}} results in the value being copied to
CordovaApp.Windows10.jsproj.
Setting {{Windows.Universal-MinVersion}} results in the value being copied to
package.windows10.appxmanifest.
If {{uap-target-min-version}} is not set, the minimum version of the app in the
Microsoft Store is incorrect.
Development of Windows 10 apps would be simplified by only having to set the
minimum version in one place.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13802) Avoid unnecessary ApplicationView access on Windows 8.1
[
https://issues.apache.org/jira/browse/CB-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333636#comment-16333636
]
Terence Bandoian commented on CB-13802:
---
By the way, [~Sujan12], I asked a related question on Slack when I noticed
differences between cordova.js and the code in cordova-js-src but didn't get a
reply.
> Avoid unnecessary ApplicationView access on Windows 8.1
> ---
>
> Key: CB-13802
> URL: https://issues.apache.org/jira/browse/CB-13802
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: Chris Brody
>Assignee: Jesse MacFadyen
>Priority: Minor
>
> From changes in CB-12238, CB-12784, and CB-13641 I noticed a few spots where
> {{Windows.UI.ViewManagement.ApplicationView.getForCurrentView()}} is called
> for no good reason on Windows 8.1, along with a couple "else crash on 8.1"
> comments nearby.
> The following changes (NOT TESTED) would resolve this issue:
> {code:sh}
> diff --git a/cordova-js-src/splashscreen.js b/cordova-js-src/splashscreen.js
> index 97fd86c..77bca75 100644
> --- a/cordova-js-src/splashscreen.js
> +++ b/cordova-js-src/splashscreen.js
> @@ -198,7 +198,7 @@ function enableUserInteraction() {
>
> // Enter fullscreen mode
> function enterFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
> var view =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useCoreWindow);
> view.suppressSystemOverlays = true;
> @@ -207,7 +207,7 @@ function enterFullScreen() {
>
> // Exit fullscreen mode
> function exitFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
> var view =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useVisible);
> view.suppressSystemOverlays = false;
> @@ -216,8 +216,10 @@ function exitFullScreen() {
>
> // Make title bg color match splashscreen bg color
> function colorizeTitleBar() {
> -var appView =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
> titleInitialBgColor = appView.titleBar.backgroundColor;
>
> appView.titleBar.backgroundColor = titleBgColor;
> @@ -227,8 +229,10 @@ function colorizeTitleBar() {
>
> // Revert title bg color
> function revertTitleBarColor() {
> -var appView =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
> appView.titleBar.backgroundColor = titleInitialBgColor;
> appView.titleBar.buttonBackgroundColor = titleInitialBgColor;
> }
> {code}
> Unfortunately I do not know how to test splashscreen changes myself, guidance
> would be appreciated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13802) Avoid unnecessary ApplicationView access on Windows 8.1
[
https://issues.apache.org/jira/browse/CB-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333632#comment-16333632
]
Terence Bandoian commented on CB-13802:
---
Right, [~Sujan12], additional comments might be better here on the issue
[~brodybits] raised.
> Avoid unnecessary ApplicationView access on Windows 8.1
> ---
>
> Key: CB-13802
> URL: https://issues.apache.org/jira/browse/CB-13802
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: Chris Brody
>Assignee: Jesse MacFadyen
>Priority: Minor
>
> From changes in CB-12238, CB-12784, and CB-13641 I noticed a few spots where
> {{Windows.UI.ViewManagement.ApplicationView.getForCurrentView()}} is called
> for no good reason on Windows 8.1, along with a couple "else crash on 8.1"
> comments nearby.
> The following changes (NOT TESTED) would resolve this issue:
> {code:sh}
> diff --git a/cordova-js-src/splashscreen.js b/cordova-js-src/splashscreen.js
> index 97fd86c..77bca75 100644
> --- a/cordova-js-src/splashscreen.js
> +++ b/cordova-js-src/splashscreen.js
> @@ -198,7 +198,7 @@ function enableUserInteraction() {
>
> // Enter fullscreen mode
> function enterFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
> var view =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useCoreWindow);
> view.suppressSystemOverlays = true;
> @@ -207,7 +207,7 @@ function enterFullScreen() {
>
> // Exit fullscreen mode
> function exitFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
> var view =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useVisible);
> view.suppressSystemOverlays = false;
> @@ -216,8 +216,10 @@ function exitFullScreen() {
>
> // Make title bg color match splashscreen bg color
> function colorizeTitleBar() {
> -var appView =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
> titleInitialBgColor = appView.titleBar.backgroundColor;
>
> appView.titleBar.backgroundColor = titleBgColor;
> @@ -227,8 +229,10 @@ function colorizeTitleBar() {
>
> // Revert title bg color
> function revertTitleBarColor() {
> -var appView =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
> appView.titleBar.backgroundColor = titleInitialBgColor;
> appView.titleBar.buttonBackgroundColor = titleInitialBgColor;
> }
> {code}
> Unfortunately I do not know how to test splashscreen changes myself, guidance
> would be appreciated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13802) Avoid unnecessary ApplicationView access on Windows 8.1
[
https://issues.apache.org/jira/browse/CB-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332978#comment-16332978
]
Terence Bandoian commented on CB-13802:
---
Thanks [~brodybits] for reviewing. Nice catch.
> Avoid unnecessary ApplicationView access on Windows 8.1
> ---
>
> Key: CB-13802
> URL: https://issues.apache.org/jira/browse/CB-13802
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: Chris Brody
>Assignee: Jesse MacFadyen
>Priority: Minor
>
> From changes in CB-12238, CB-12784, and CB-13641 I noticed a few spots where
> {{Windows.UI.ViewManagement.ApplicationView.getForCurrentView()}} is called
> for no good reason on Windows 8.1, along with a couple "else crash on 8.1"
> comments nearby.
> The following changes (NOT TESTED) would resolve this issue:
> {code:sh}
> diff --git a/cordova-js-src/splashscreen.js b/cordova-js-src/splashscreen.js
> index 97fd86c..77bca75 100644
> --- a/cordova-js-src/splashscreen.js
> +++ b/cordova-js-src/splashscreen.js
> @@ -198,7 +198,7 @@ function enableUserInteraction() {
>
> // Enter fullscreen mode
> function enterFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
> var view =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useCoreWindow);
> view.suppressSystemOverlays = true;
> @@ -207,7 +207,7 @@ function enterFullScreen() {
>
> // Exit fullscreen mode
> function exitFullScreen() {
> -if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else crash
> on 8.1
> +if (isWin10UWP && Windows.UI.ViewManagement.ApplicationViewBoundsMode) {
> var view =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
>
> view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useVisible);
> view.suppressSystemOverlays = false;
> @@ -216,8 +216,10 @@ function exitFullScreen() {
>
> // Make title bg color match splashscreen bg color
> function colorizeTitleBar() {
> -var appView =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
> titleInitialBgColor = appView.titleBar.backgroundColor;
>
> appView.titleBar.backgroundColor = titleBgColor;
> @@ -227,8 +229,10 @@ function colorizeTitleBar() {
>
> // Revert title bg color
> function revertTitleBarColor() {
> -var appView =
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (isWin10UWP && !isBgColorTransparent) {
> +var appView =
> +Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> +
> appView.titleBar.backgroundColor = titleInitialBgColor;
> appView.titleBar.buttonBackgroundColor = titleInitialBgColor;
> }
> {code}
> Unfortunately I do not know how to test splashscreen changes myself, guidance
> would be appreciated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.
[ https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282023#comment-16282023 ] Terence Bandoian commented on CB-13641: --- Pull request opened. Please let me know if you see any problems. > Splash screen on Windows does not allow for transparent background color. > - > > Key: CB-13641 > URL: https://issues.apache.org/jira/browse/CB-13641 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-windows >Affects Versions: cordova@7.0.0 > Environment: Windows 10. >Reporter: Terence Bandoian >Priority: Trivial > Labels: newbie > Fix For: Master > > > The splash screen background color defaults to #464646. In splashscreen.js, > the background color is expected to be a hex value and values longer than > seven characters are spliced to remove the alpha channel. The configured > value could be checked for the value 'transparent' and, in that case, not > spliced. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13641) Splash screen on Windows does not allow for transparent background color.
[ https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terence Bandoian updated CB-13641: -- Description: The splash screen background color defaults to #464646. In splashscreen.js, the background color is expected to be a hex value and values longer than seven characters are spliced to remove the alpha channel. The configured value could be checked for the value 'transparent' and, in that case, not spliced. (was: The splash screen background color defaults to #464646. In cordova.js, the background color is expected to be a hex value and values longer than seven characters are spliced to remove the alpha channel. The configured value could be checked for the value 'transparent' and, in that case, not spliced.) > Splash screen on Windows does not allow for transparent background color. > - > > Key: CB-13641 > URL: https://issues.apache.org/jira/browse/CB-13641 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-windows >Affects Versions: cordova@7.0.0 > Environment: Windows 10. >Reporter: Terence Bandoian >Priority: Trivial > Labels: newbie > Fix For: Master > > > The splash screen background color defaults to #464646. In splashscreen.js, > the background color is expected to be a hex value and values longer than > seven characters are spliced to remove the alpha channel. The configured > value could be checked for the value 'transparent' and, in that case, not > spliced. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13641) Splash screen on Windows does not allow for transparent background color.
[ https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terence Bandoian updated CB-13641: -- Component/s: (was: cordova-js) cordova-windows > Splash screen on Windows does not allow for transparent background color. > - > > Key: CB-13641 > URL: https://issues.apache.org/jira/browse/CB-13641 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-windows >Affects Versions: cordova@7.0.0 > Environment: Windows 10. >Reporter: Terence Bandoian >Priority: Trivial > Labels: newbie > Fix For: Master > > > The splash screen background color defaults to #464646. In cordova.js, the > background color is expected to be a hex value and values longer than seven > characters are spliced to remove the alpha channel. The configured value > could be checked for the value 'transparent' and, in that case, not spliced. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13641) Splash screen on Windows does not allow for transparent background color.
[ https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280564#comment-16280564 ] Terence Bandoian edited comment on CB-13641 at 12/6/17 5:46 PM: Here's the link: https://github.com/apache/cordova-windows/blob/master/cordova-js-src/splashscreen.js#L73 I may have submitted the issue for the wrong project. On Windows, the plugin isn't used and the splash screen is handled as a proxy. Also, the splash screen on Windows covers the entire application window, including the title bar, with the background color. In some cases, allowing the current Windows accent color to be displayed may be more preferable than a fixed color. This would still allow for a splash image to be displayed in the center of the window. was (Author: tbandoian): Here's the link: https://github.com/apache/cordova-windows/blob/master/cordova-js-src/splashscreen.js#L73 I may have submitted the issue for the wrong project. On Windows, the plugin isn't used and the splash screen is handled as a proxy. > Splash screen on Windows does not allow for transparent background color. > - > > Key: CB-13641 > URL: https://issues.apache.org/jira/browse/CB-13641 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-js >Affects Versions: cordova@7.0.0 > Environment: Windows 10. >Reporter: Terence Bandoian >Priority: Trivial > Labels: newbie > Fix For: Master > > > The splash screen background color defaults to #464646. In cordova.js, the > background color is expected to be a hex value and values longer than seven > characters are spliced to remove the alpha channel. The configured value > could be checked for the value 'transparent' and, in that case, not spliced. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13641) Splash screen on Windows does not allow for transparent background color.
[ https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280564#comment-16280564 ] Terence Bandoian commented on CB-13641: --- Here's the link: https://github.com/apache/cordova-windows/blob/master/cordova-js-src/splashscreen.js#L73 I may have submitted the issue for the wrong project. On Windows, the plugin isn't used and the splash screen is handled as a proxy. > Splash screen on Windows does not allow for transparent background color. > - > > Key: CB-13641 > URL: https://issues.apache.org/jira/browse/CB-13641 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-js >Affects Versions: cordova@7.0.0 > Environment: Windows 10. >Reporter: Terence Bandoian >Priority: Trivial > Labels: newbie > Fix For: Master > > > The splash screen background color defaults to #464646. In cordova.js, the > background color is expected to be a hex value and values longer than seven > characters are spliced to remove the alpha channel. The configured value > could be checked for the value 'transparent' and, in that case, not spliced. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13641) Splash screen on Windows does not allow for transparent background color.
Terence Bandoian created CB-13641: - Summary: Splash screen on Windows does not allow for transparent background color. Key: CB-13641 URL: https://issues.apache.org/jira/browse/CB-13641 Project: Apache Cordova Issue Type: Improvement Components: cordova-js Affects Versions: cordova@7.0.0 Environment: Windows 10. Reporter: Terence Bandoian Priority: Trivial Fix For: Master The splash screen background color defaults to #464646. In cordova.js, the background color is expected to be a hex value and values longer than seven characters are spliced to remove the alpha channel. The configured value could be checked for the value 'transparent' and, in that case, not spliced. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
