Re: [PR] fix(android): remove broad media permissions [cordova-plugin-media-capture]
breautek commented on PR #295: URL: https://github.com/apache/cordova-plugin-media-capture/pull/295#issuecomment-2163543596 btw the android test are failing cause it's attempting to test against cordova-android@13 which requires JDK 17, but this repo still is configured to use JDK 11. So don't worry about that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] fix(android): remove broad media permissions [cordova-plugin-media-capture]
breautek commented on PR #295: URL: https://github.com/apache/cordova-plugin-media-capture/pull/295#issuecomment-2163541277 > For Android 10, I would suggest this plugin be resilient to handle apps that have opted-out of scoped storage by using the android:requestLegacyExternalStorage="true" configuration. The `requestLegacyExternalStorage` is just a request. It is always rejected if the target SDK is 30 or later (current google play requires API 33 as a target). If you're targeting API 29, the request is only honoured if your app exists in google play before hand. Newer apps created after API 29 can be rejected (forcing developers to use scoped storage). In otherwords, scoped storage is always enforced today on API 29+ devices. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] IOS report "Failed to resolve host network app id" error, Android is working properly [cordova-ios]
breautek commented on issue #1440: URL: https://github.com/apache/cordova-ios/issues/1440#issuecomment-2163020661 I'm not really sure, but I definitely don't reproduce this though I don't use the VueJS framework as well. So I think this is more of a VueJS integration issue. It is possible that it assumes are more traditional web environment where you have a server, with a domain, etc... These things doesn't necessary exist in a webview environment. Couple of things you can try: ### Enabling url schemes iOS webview has a concept of schemes, by default has this disabled. This means that you're web app is loaded over the `file://` protocol, which the means the document has a `null` origin, and the webview considers the document insecure and will disable a lot of different features. If you add a `platform` block in your config with the `scheme` and `hostname` preferences, it will enable the url scheme, which means you're document will be proxied through something that looks like a server and the document will have a proper origin and will be considered secure, for the purposes of enabling features locked normally locked behind https. ```xml http://www.w3.org/ns/widgets; xmlns:cdv="http://cordova.apache.org/ns/1.0;> HelloWorld Sample Apache Cordova App https://cordova.apache.org;> Apache Cordova Team http://*/*; /> https://*/*; /> ``` Couple of things to note: 1. We use the platform block because android also accept these preferences for their equivalent system, but iOS and android has different requirements where Android only accepts `http` or `https` as the scheme and iOS requires you to use a non-reserved scheme where `http` and `https` are [reserved](https://github.com/WebKit/WebKit/blob/ba2a851809a33013068ec8511883055cabd239be/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm#L222-L244). This is why we choose something more custom, like `app` for our ios scheme. 2. Android defaults to `https://localhost` as the scheme instead of the `file://` protocol strategy, which may explain why VueJS works under the android webview out of the box. ### Possibility of finding more insights If the above fails... then we probably need to get more insights. I think on iOS, xcode will still log JS console messages, but if it is a message from JS, the web inspector may have more insightful information. If you don't know how to use the Safari remote inspector, I have a [blog post](https://breautek.com/articles/debugging-cordova-apps.html) that describes how, just scroll down to the iOS section. The key thing though is safari web inspector doesn't capture events that occurred before the inspector was attached, so in order to see log messages, network errors, or any debug information that occurred on launch, you'll need to refresh the webview with the inspector attached. This can be done by pressing `cmd` + `r` on the inspector window. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] IOS report "Failed to resolve host network app id" error, Android is working properly [cordova-ios]
mewebranding commented on issue #1440: URL: https://github.com/apache/cordova-ios/issues/1440#issuecomment-2161909335 this error is shown in XCode console. ` http://www.w3.org/ns/widgets; xmlns:cdv="http://cordova.apache.org/ns/1.0;> HelloWorld Sample Apache Cordova App https://cordova.apache.org;> Apache Cordova Team http://*/*; /> https://*/*; /> ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] IOS report "Failed to resolve host network app id" error, Android is working properly [cordova-ios]
breautek commented on issue #1440: URL: https://github.com/apache/cordova-ios/issues/1440#issuecomment-2161902965 > console reports "Failed to resolve host network app id" (btw, Safari in the XCode emulator can access API hosts) This doesn't really sound like an error that cordova throws really. Is this error being shown in XCode console or the web console? Also can you share your `config.xml` file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[I] IOS report "Failed to resolve host network app id" error, Android is working properly [cordova-ios]
mewebranding opened a new issue, #1440: URL: https://github.com/apache/cordova-ios/issues/1440 # Bug Report ## Problem The Android platform app is working normally, and then we added the iOS platform. When running in the emulator, a white screen appears and the console reports "Failed to resolve host network app ID" ### What is expected to happen? IOS should work normally like Android ### What does actually happen? When running in the iOS emulator, a white screen is displayed and the console reports "Failed to resolve host network app id" (btw, Safari in the XCode emulator can access API hosts) ## Information Could it be due to compatibility between our XCode and Mac OS versions or some settings errors？ ### Command or Code cordova platform add ios@7.1.0 && cordova build ios ### Environment, Platform, Device build on macOS Xcode simulator ### Version information Framework vue3.4.27 Cordova: Cordova CLI : 12.0.0 (cordova-lib@12.0.1) Cordova Platforms : ios 7.1.0 Cordova Plugins : None System MacOS sonoma14.5 Xcode15.4 NodeJS : v21.7.1 ## Checklist - [x] I searched for existing GitHub issues - [x] I updated all Cordova tooling to most recent version - [x] I included all the necessary information above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] IOS report "Failed to resolve host network app id" error, Android is working properly [cordova-ios]
breautek commented on issue #1439: URL: https://github.com/apache/cordova-ios/issues/1439#issuecomment-2161853877 Please fill out the issue form. The error message without context isn't that useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] IOS report "Failed to resolve host network app id" error, Android is working properly [cordova-ios]
breautek closed issue #1439: IOS report "Failed to resolve host network app id" error, Android is working properly URL: https://github.com/apache/cordova-ios/issues/1439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] SuppressesLongPressGesture / Suppresses3DTouchGesture preferences not working since iOS 15.1 [cordova-ios]
tol-uno commented on issue #1216: URL: https://github.com/apache/cordova-ios/issues/1216#issuecomment-2160947330 This is still an unresolved issue on iOS 17.4.1 Here is a [link](https://github.com/apache/cordova-ios/blob/master/CordovaLib/Classes/Private/Plugins/CDVGestureHandler/CDVGestureHandler.m) to the current `SuppressesLongPressGesture / Suppresses3DTouchGesture` code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Do not overwrite standard File API [cordova-plugin-file]
qiutian00 commented on issue #316: URL: https://github.com/apache/cordova-plugin-file/issues/316#issuecomment-2160310177 Changing the standard API's is a really bad idea, It effects other upload file components that use window.File -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Embedded Cordova in Apple's VisionOS App (VisionOS Platform) [cordova]
breautek commented on issue #448: URL: https://github.com/apache/cordova/issues/448#issuecomment-2158361202 I don't know all the challenges involved but Asset Kit is definitely one of them. It was [deprecated](https://developer.apple.com/documentation/AssetsLibrary?language=objc) in iOS 9 which is why there is a lack of support in VisionOS. It was replaced by [PhotoKit](https://developer.apple.com/documentation/photokit?language=objc), which does have a VisionOS implementation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] [Android] Remove broad photo/video permissions and use a system picker - Google Play Policy deadline 2024-08 [cordova-plugin-media-capture]
bmarsaud commented on issue #288: URL: https://github.com/apache/cordova-plugin-media-capture/issues/288#issuecomment-2157940026 I'v pushed the https://github.com/apache/cordova-plugin-media-capture/pull/295 PR that attempts to remove these broad permissions. I don't think we need them at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [D] Inquiry Regarding Support Status of InAppBrowser Plugin in Cordova [cordova]
GitHub user jcesarmobile added a comment to the discussion: Inquiry Regarding Support Status of InAppBrowser Plugin in Cordova What Ionic is deprecating are several Cordova enterprise (paid) plugins. That doesn’t affect Apache Cordova plugins, nor the wrappers for them. The old Ionic wrappers (`@ionic-native`) were renamed to `@awesome-cordova-plugins` years ago as they were donated to the community. They are still being maintained by the community. The enterprise plugins deprecation only affects a small number of Ionic paying customers and they have been advised by Ionic Customer Support team about paths for migration. Doesn’t affect any non paying Ionic users or non Ionic users. GitHub link: https://github.com/apache/cordova/discussions/479#discussioncomment-9721532 This is an automatically sent email for issues@cordova.apache.org. To unsubscribe, please send an email to: issues-unsubscr...@cordova.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Build failed with Invalid for given resource value. error [cordova-android]
eduardojmrosa commented on issue #1714: URL: https://github.com/apache/cordova-android/issues/1714#issuecomment-2156064305 Greetings, i have to update this thread. This isnt the version of the mapsplugins that works well in the New Android version. Ill edit soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Build failed with Invalid for given resource value. error [cordova-android]
GitToTheHub commented on issue #1714: URL: https://github.com/apache/cordova-android/issues/1714#issuecomment-2155921138 @eduardojmrosa Thanks for sharing the fork for the fixed google maps plugin. When you click on the link, it points to https://github.com/apache/cordova-android/issues/fork and not https://github.com/TSFArg/cordova-plugin-googlemaps/tree/master. Maybe you can edit this :) Do you have already good experiences with this fork? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Cordova is rejecting Java and gradle on windows [cordova-android]
lewismunene020 commented on issue #1554: URL: https://github.com/apache/cordova-android/issues/1554#issuecomment-2155784864 i also did an upgrade of the gradle version and it worked pretty well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Cordova is rejecting Java and gradle on windows [cordova-android]
RajnishAnand commented on issue #1554: URL: https://github.com/apache/cordova-android/issues/1554#issuecomment-2155496714 depending on the version installed its required to add `$ANDROID_HOME/cmdline-tools//bin` to path for me it was `$ANDROID_HOME/cmdline-tools/latest/bin` . and just to be clear `ANDROID_HOME=C:\Users\\AppData\Local\Android\Sdk\` which requires to be set as environmental variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [D] Inquiry Regarding Support Status of InAppBrowser Plugin in Cordova [cordova]
GitHub user breautek added a comment to the discussion: Inquiry Regarding Support Status of InAppBrowser Plugin in Cordova Migrating this to Cordova Discussions. GitHub link: https://github.com/apache/cordova/discussions/479#discussioncomment-9689532 This is an automatically sent email for issues@cordova.apache.org. To unsubscribe, please send an email to: issues-unsubscr...@cordova.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[I] Inquiry Regarding Support Status of InAppBrowser Plugin in Cordova [cordova]
dt237131 opened a new issue, #478: URL: https://github.com/apache/cordova/issues/478 Hey Cordova community, I hope you're doing well. I wanted to ask about the status of the InAppBrowser plugin. With Ionic declaring end of life for it, I'm curious if the Cordova community plans to continue supporting it or if there are alternative solutions recommended. Any insights you could provide would be really helpful! Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Inquiry Regarding Support Status of InAppBrowser Plugin in Cordova [cordova]
breautek closed issue #478: Inquiry Regarding Support Status of InAppBrowser Plugin in Cordova URL: https://github.com/apache/cordova/issues/478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Inquiry Regarding Support Status of InAppBrowser Plugin in Cordova [cordova-plugin-inappbrowser]
breautek commented on issue #1055: URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/1055#issuecomment-2152364803 Migrating this to Cordova Discussions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] (fix) typo in CDVSound.m [cordova-plugin-media]
breautek merged PR #398: URL: https://github.com/apache/cordova-plugin-media/pull/398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[PR] (fix) typo in CDVSound.m [cordova-plugin-media]
pinguluk opened a new pull request, #398: URL: https://github.com/apache/cordova-plugin-media/pull/398 ### Platforms affected ### Motivation and Context ### Description ### Testing ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Live streams (over http, like web radio) don't play on iOS [cordova-plugin-media]
pinguluk commented on issue #324: URL: https://github.com/apache/cordova-plugin-media/issues/324#issuecomment-2151909709 > This seems to still be happening with Cordova 11.1.0 and ios 6.2.0. > > I've also tried with the html audio tag but got same problem. Whenever I insert any live audio in my index.html the app freezes when starting. > > I tried with iframes and got 1 js player working but not others. > > Any hints to make an icecast stream play in ios? https://github.com/apache/cordova-plugin-media/issues/256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[I] Inquiry Regarding Support Status of InAppBrowser Plugin in Cordova [cordova-plugin-inappbrowser]
dt237131 opened a new issue, #1055: URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/1055 Hey Cordova community, I hope you're doing well. I wanted to ask about the status of the InAppBrowser plugin. With Ionic declaring end of life for it, I'm curious if the Cordova community plans to continue supporting it or if there are alternative solutions recommended. Any insights you could provide would be really helpful! Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Unable to access camera for record video online from inappbrowser [cordova-plugin-inappbrowser]
Vladeouz commented on issue #706:
URL:
https://github.com/apache/cordova-plugin-inappbrowser/issues/706#issuecomment-2151324109
> > Any solution around ?
>
> Already fixed with the commit mentioned up:
[d735e13](https://github.com/apache/cordova-plugin-inappbrowser/commit/d735e136cdf409472833558184764ea47d658c85)
i have been update to the latest version (v.6.0.0) and when i open the
webcam test web it still shows an error that the browser isn't allow the
permissions.
this is my code
`openWeb() {
const target = '_blank'
const options =
'allowInlineMediaPlayback=yes,location=yes,zoom=no,hideurlbar=yes,toolbarcolor=#1D99AA,hidenavigationbuttons=yes,lefttoright=yes,closebuttoncolor=#ff,fullscreen=no,clearsessioncache=yes,clearcache=yes'
var InAppBrowserRef = cordova.InAppBrowser.open(
// 'https://webcamtests.com/',
target,
options
)
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[I] Allow reading from/writing to iOS shared app group directory [cordova-plugin-file]
mohammadrafigh opened a new issue, #626: URL: https://github.com/apache/cordova-plugin-file/issues/626 # Feature Request ## Motivation Behind Feature There are many cases that there is a need to access files and directories of the main app target from another target (extension). For example if you want to read a file in a Notification Service Extension, currently there is no way to handle that. ## Feature Description You can easily add this as an option or another method to write into or read from the shared app group directory like this (in Swift) ``` FileManager.default.containerURL(forSecurityApplicationGroupIdentifier: "group.my.app.onesignal") ``` It wil return the URL that the plugin can facilitate it like any other URL it's handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[PR] fix(android): remove broad media permissions [cordova-plugin-media-capture]
bmarsaud opened a new pull request, #295: URL: https://github.com/apache/cordova-plugin-media-capture/pull/295 ### Platforms affected Android ### Motivation and Context As discussed on #288, broad media permissions (`READ_MEDIA_IMAGES`, `READ_MEDIA_VIDEO`, `READ_MEDIA_AUDIO`) policy will be enforced on August 31, 2024, threatening the Google Play approval of apps using this plugin. > For a more privacy preserving experience for users, we’re introducing the [Photo and Video Permissions policy](https://support.google.com/googleplay/android-developer/answer/13986130) to reduce the number of apps permitted to request broad photo/video permissions ([READ_MEDIA_IMAGES](https://developer.android.com/reference/android/Manifest.permission#READ_MEDIA_IMAGES) and [READ_MEDIA_VIDEO](https://developer.android.com/reference/android/Manifest.permission#READ_MEDIA_VIDEO)). Apps may only access photos and videos for purposes directly related to app functionality. Apps that have a one-time or infrequent need to access these files are requested to use a system picker, such as the Android [photo picker](https://developer.android.com/training/data-storage/shared/photopicker). > Apps that request access to the READ_MEDIA_VIDEO or READ_MEDIA_IMAGES permission must successfully demonstrate a core use case that requires persistent or frequent need of photo/video access located in shared storage. The purpose of this PR is to not use broad media permissions. ### Description My understanding is that, we don't need these permissions in the first place. I would be interested to know why the changes of #262 were considered necessary at the time, am I missing something? Here are the requirements that I've gathered: |Android Version|Requirement|Source| |---|---|---| |<= 9|`READ_EXTERNAL_STORAGE` and `WRITE_EXTERNAL_STORAGE` are needed to "access any media file"|https://developer.android.com/training/data-storage/shared/media?hl=en#extra-permissions| |10|Same as Android 11+ (see below) BUT if the app has opted-out of scoped storage we still need the `EXTERNAL_STORAGE` permissions|https://developer.android.com/training/data-storage/use-cases?hl=en#running_on_android_10 https://developer.android.com/training/data-storage/use-cases?hl=en#opt-out-in-production-app| |11+|There is no permission needed to perform a `MediaCapture` intent, save the media file to the `MediaStore.Images` collection and read it later because you "own" the file|https://developer.android.com/training/data-storage/shared/media?hl=en#storage-permission| For Android 10, I would suggest this plugin be resilient to handle apps that have opted-out of scoped storage by using the `android:requestLegacyExternalStorage="true"` configuration. With these information in mind, here is what I've changed: - `READ_EXTERNAL_STORAGE` and `WRITE_EXTERNAL_STORAGE` declared in the manifest and asked at runtime only for Android up to 10 - Removal of `READ_MEDIA_IMAGES`, `READ_MEDIA_VIDEO`, `READ_MEDIA_AUDIO` from the manifest and runtime request. ### Testing I have tested an image capture on Android 14, 13, 12L, 11, 10 and 9: the photo app opens, the file is well saved and can be read. I there a documentation on how to run the unit-tests ? ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Incoming Call FullScreen Intent On A Cordova Activity [cordova-android]
KyleKernanRepo commented on issue #1689: URL: https://github.com/apache/cordova-android/issues/1689#issuecomment-2146132361 @parveshneedhoo Yes the solution I found was you need to set your flags within the onCreate() as well as onNewIntent(). getWindow().addFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON| WindowManager.LayoutParams.FLAG_DISMISS_KEYGUARD| WindowManager.LayoutParams.FLAG_SHOW_WHEN_LOCKED| WindowManager.LayoutParams.FLAG_TURN_SCREEN_ON); -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Cordova 11.0.0 + Android 11.0.0 - cordova prepare android --debug command fails [cordova-android]
danicholls commented on issue #1461: URL: https://github.com/apache/cordova-android/issues/1461#issuecomment-2145497187 Worked here. Documentation should be updated. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] No known instance method for selector 'userAgent' in CDVFileTransfer.m [cordova-plugin-file-transfer]
danicholls commented on issue #258: URL: https://github.com/apache/cordova-plugin-file-transfer/issues/258#issuecomment-2144347409 NPM seems to have the current version (2.0.0) now. (From 09/2023.) I don't know if there's any reason to keep using the sitewaerts version (which was a lifesaver!) or anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Cordova is rejecting Java and gradle on windows [cordova-android]
lewismunene020 commented on issue #1554: URL: https://github.com/apache/cordova-android/issues/1554#issuecomment-2143738932 i am also facing the same issue on my end what might be the problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] feat(ios): add bundled resources for privacy manifest [cordova-plugin-file]
jkronborg commented on PR #621: URL: https://github.com/apache/cordova-plugin-file/pull/621#issuecomment-2143523388 @erisu OK, thanks for the clarification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Geolocation working on android 13,14 even 8 but not on android 12 function does not call no error in console [cordova-plugin-geolocation]
ckang777 commented on issue #273: URL: https://github.com/apache/cordova-plugin-geolocation/issues/273#issuecomment-2143453465 @breautek Thank you for you detailed response. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] feat(ios): add bundled resources for privacy manifest [cordova-plugin-file]
erisu commented on PR #621: URL: https://github.com/apache/cordova-plugin-file/pull/621#issuecomment-2143369057 @jkronborg The comment you linked should not be valid anymore. At that time we were thinking plugin developers would include the same privacy manifest tag structure in plugin.xml and Cordova would merge them together but that is not actually necessary. Xcode automatically detects and collects the privacy manifest files from the app, resource bundle, and frameworks/libraries and generates the report. The way this PR implemented the privacy manifest for plugins is preferred for other plugins. If a plugin is not updated, then app developers would need to determine the privacy information and include it in the app's config.xml. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] feat(ios): add bundled resources for privacy manifest [cordova-plugin-file]
jkronborg commented on PR #621: URL: https://github.com/apache/cordova-plugin-file/pull/621#issuecomment-2143340965 @erisu Thanks For people that might see this and think it'll fix Apple's privacy manifest error messages: I realized that [`cordova-ios` is not yet ready to support these plugin-provided privacy manifests](https://github.com/apache/cordova-ios/pull/1406#issuecomment-1982217021), so for now you have to merge the plugin's manifest with your app's manifest yourself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] build(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 [cordova-plugin-device]
dependabot[bot] closed pull request #188: build(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 URL: https://github.com/apache/cordova-plugin-device/pull/188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] build(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 [cordova-plugin-device]
dependabot[bot] commented on PR #188: URL: https://github.com/apache/cordova-plugin-device/pull/188#issuecomment-2143262314 Looks like word-wrap is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] build(deps): bump json5 from 1.0.1 to 1.0.2 [cordova-plugin-device]
erisu commented on PR #186: URL: https://github.com/apache/cordova-plugin-device/pull/186#issuecomment-2143262253 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] build(deps): bump json5 from 1.0.1 to 1.0.2 [cordova-plugin-device]
dependabot[bot] commented on PR #186: URL: https://github.com/apache/cordova-plugin-device/pull/186#issuecomment-2143262340 Looks like json5 is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] build(deps): bump json5 from 1.0.1 to 1.0.2 [cordova-plugin-device]
dependabot[bot] closed pull request #186: build(deps): bump json5 from 1.0.1 to 1.0.2 URL: https://github.com/apache/cordova-plugin-device/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] build(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 [cordova-plugin-device]
erisu commented on PR #188: URL: https://github.com/apache/cordova-plugin-device/pull/188#issuecomment-2143262226 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] ci(android): set default java version to 17 [cordova-paramedic]
erisu merged PR #268: URL: https://github.com/apache/cordova-paramedic/pull/268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] chore: rebuilt package-lock.json w/ version 3 [cordova-plugin-device]
erisu merged PR #203: URL: https://github.com/apache/cordova-plugin-device/pull/203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] ci: update gh-action's workflow [cordova-plugin-device]
erisu merged PR #198: URL: https://github.com/apache/cordova-plugin-device/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Could not find an installed version of Gradle [cordova-android]
breautek commented on issue #1347: URL: https://github.com/apache/cordova-android/issues/1347#issuecomment-2142725004 > Why do we need to install gradle manually when cordova is also installing a given version. Can't cordova install and use one single gradle version? The system gradle is used to install something known as a "gradle wrapper", which is a gradle at the version specified for the project. Allowing different projects to use different gradle versions. Gradle recommends checking in the wrapper into the repository and redistribute so that users need to have a full gradle install themselves but Apache has a lot of legal policies and security concerns on redistributing binaries since they can be hard to assert that they come from a legit source. This is the primary the reason why we rely on a system gradle to install the wrapper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Could not find an installed version of Gradle [cordova-android]
kripper commented on issue #1347: URL: https://github.com/apache/cordova-android/issues/1347#issuecomment-2142704077 Why do we need to install gradle manually when cordova is also installing a given version. Can't cordova install and use one single gradle version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] feat(ios): add bundled resources for privacy manifest [cordova-plugin-file]
erisu commented on PR #621: URL: https://github.com/apache/cordova-plugin-file/pull/621#issuecomment-2142580536 @jkronborg I pushed a release vote today. Cordova's voting process requires a 2+1 positive binding vote to be considered successful. Additionally, the process must remain open for a minimum of 48 hours. Depending on people's availability and the results, it is possible that we will see an official release shortly. You can monitor the vote via our dev mailing list: https://lists.apache.org/thread/fkdrny5yzjrqcmcc0ls4l25kngo311n9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] ci: update gh-action's workflow [cordova-plugin-device]
erisu commented on code in PR #198: URL: https://github.com/apache/cordova-plugin-device/pull/198#discussion_r1622496654 ## .github/workflows/android.yml: ## @@ -67,27 +67,33 @@ jobs: - android: 11 android-api: 30 - - android: 12 -android-api: 31 - - android: 12L android-api: 32 + - android: 13 +android-api: 33 + Review Comment: Went ahead and added API 34 since paramedic has been updated since. Also updated the JDK to 17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[PR] chore: rebuilt package-lock.json w/ version 3 [cordova-plugin-device]
erisu opened a new pull request, #203: URL: https://github.com/apache/cordova-plugin-device/pull/203 ### Platforms affected n/a ### Motivation, Context & Description - Rebuilt package-lock.json with v3. - Resolves audit for dev ### Testing n/a ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] fix(android)!: set platform requirement >= 7.0.0 [cordova-plugin-device]
erisu merged PR #200: URL: https://github.com/apache/cordova-plugin-device/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[PR] Add support for 'alwaysOutOfDate' PBX Shell Script property [cordova-node-xcode]
marco-saia-datadog opened a new pull request, #143: URL: https://github.com/apache/cordova-node-xcode/pull/143 This PR adds support for the `alwaysOutOfDate` property in PBX Shell Scripts. Setting `alwaysOutOfDate` to `true` disables dependency analysis for the given build phase, clearing warnings such as: ```sh Script has ambiguous dependencies causing it to run on every build ``` Since by default the property is not added to the PBX project file by Xcode, I have decided to write it down in the PBX file only if explicitly specified in the `pbxShellScriptBuildPhaseObj` options, hence the null check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] chore: rebuilt package-lock.json w/ version 3 [cordova-plugin-file]
erisu merged PR #625: URL: https://github.com/apache/cordova-plugin-file/pull/625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[PR] ci(android): set default java version to 17 [cordova-paramedic]
erisu opened a new pull request, #268: URL: https://github.com/apache/cordova-paramedic/pull/268 ### Platforms affected n/a ### Motivation and Context Use JDK 17 which is minimum requirement for latest `cordova-android` release ### Description bump default java version to 1 ### Testing tested with file plugin ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] ci: sync workflow with paramedic [cordova-plugin-file]
erisu merged PR #624: URL: https://github.com/apache/cordova-plugin-file/pull/624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] ci: sync workflow with paramedic [cordova-plugin-file]
breautek commented on PR #624: URL: https://github.com/apache/cordova-plugin-file/pull/624#issuecomment-2139496867 Ah actually it seem slike the test (at least android) is failing because the CI is sitll configured to use JDK 11. Now that 13 is merged/released it will need JDK 17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] plugin onload seems to start plugin before app ready [cordova-android]
breautek commented on issue #1715: URL: https://github.com/apache/cordova-android/issues/1715#issuecomment-2139464094 I do not believe it's related to #1605 which simply makes `CoreAndroid` (a plugin itself) be loaded via "onload", which is the equivalent of it doing `` if it actually had it's own `plugin.xml`. [CoreAndroid](https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CoreAndroid.java) isn't responsible for managing plugins or "starting" any plugins. It's purpose is to provide some core JS apis to handle hardware back button presses, among couple of other niche things. In otherwords, #1605 wouldn't have changed plugin loading behaviour of other plugins which uses `onload`. With that being said, I'm not so certain this is a bug with cordova-android either. The `onload` parameter is to initialise the plugins on platform startup which the PluginManager does so [here](https://github.com/apache/cordova-android/blame/master/framework/src/org/apache/cordova/PluginManager.java#L98), invoked by [CordovaWebViewImpl.init](https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaWebViewImpl.java#L119). This initialization chain starts [here](https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaActivity.java#L234). The init makes and configures the webview and initialises all plugins that has the `onload` parameter set to `true`. The loading of the webview app happens later, [here](https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaActivity.java#L240). Noting that these parts of the codebase hasn't changed for 10+ years, if you use the `blame` tool to see when the last changes on those lines occurred. So for about a decade, `onload` plugins always were initialised before the webview was fully loaded. Attempting to call JS on plugin initialise while the plugin is initialised `onload` will likely result in a race condition, depending on how the plugin invokes a JS call. I acknowledge that the documentation does not detail any of this whatsoever. The android plugin docs has 2 sentences noting the existence of the `onload` parameter, that's about it. Which is why I took the time to dig through the code base to get an understanding on how plugins gets initialised. If anything this highlights an issue with our documentation, but behaviour wise I do not think this is a bug with cordova-android. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[PR] chore: rebuilt package-lock.json w/ version 3 [cordova-plugin-file]
erisu opened a new pull request, #625: URL: https://github.com/apache/cordova-plugin-file/pull/625 ### Platforms affected n/a ### Motivation, Context & Description - Rebuilt package-lock.json with v3. - Resolves audit for dev ### Testing n/a ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[PR] ci: sync workflow with paramedic [cordova-plugin-file]
erisu opened a new pull request, #624: URL: https://github.com/apache/cordova-plugin-file/pull/624 ### Platforms affected n/a ### Motivation and Context Update CI Workflow ### Description Updated: - Dependencies - Android test matrix - iOS test matrix - Use linux & enable KVM - Use node 20 ### Testing n/a ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[I] plugin onload [cordova-android]
globules-io opened a new issue, #1715: URL: https://github.com/apache/cordova-android/issues/1715 # Bug Report ## Problem ### What is expected to happen? ### What does actually happen? ## Information ### Command or Code ### Environment, Platform, Device ### Version information ## Checklist - [ ] I searched for existing GitHub issues - [ ] I updated all Cordova tooling to most recent version - [ ] I included all the necessary information above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] feat(ios): add bundled resources for privacy manifest [cordova-plugin-file]
jkronborg commented on PR #621: URL: https://github.com/apache/cordova-plugin-file/pull/621#issuecomment-2136948541 @erisu Thanks for this! Do you plan on releasing this change anytime soon? For regulatory reasons it's easier for us to use release versions than development versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Crash with cordovaSettingForKey selector [cordova-ios]
dpogue closed issue #727: Crash with cordovaSettingForKey selector URL: https://github.com/apache/cordova-ios/issues/727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Crash with cordovaSettingForKey selector [cordova-ios]
dpogue commented on issue #727: URL: https://github.com/apache/cordova-ios/issues/727#issuecomment-2136462045 The cause of this appears to be when the app is linked to the Cordova static library without the `-ObjC` linker flag. However, that flag should always be set as part of the build configuration due to build.xcconfig: https://github.com/apache/cordova-ios/blob/2240ebcca08060130eb9c6ffc5b9b35ddb85b248/templates/cordova/build.xcconfig#L26 This shouldn't happen in a generated Cordova app template unless you've manually adjusted flags within Xcode, or changes the `LDFLAGS` in other xcconfig overrides. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Build failed with Invalid for given resource value. error [cordova-android]
eduardojmrosa commented on issue #1714: URL: https://github.com/apache/cordova-android/issues/1714#issuecomment-2136096923 Update: This fork [https://github.com/TSFArg/cordova-plugin-googlemaps/tree/master](fork) have a version that work pretty well with the android 13 version. It only work setting the "" in the config.xml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Build failed with Invalid for given resource value. error [cordova-android]
eduardojmrosa commented on issue #1714: URL: https://github.com/apache/cordova-android/issues/1714#issuecomment-2136058031 Ok, i just tested here, find some errors with permissions and with the transpiling the plugin googlempas to fit in android13 standards, so now the googlemaps plugin will need to be upgraded to fit in the android13 version. Thanks for your help! If you find any repo or method to adapt the current googlemaps plugin to work in this android13 version share with me please :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Build failed with Invalid for given resource value. error [cordova-android]
eduardojmrosa commented on issue #1714: URL: https://github.com/apache/cordova-android/issues/1714#issuecomment-2136036669 So even fixing this problem i may found problems with the 13 version ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Build failed with Invalid for given resource value. error [cordova-android]
breautek commented on issue #1714: URL: https://github.com/apache/cordova-android/issues/1714#issuecomment-2135731585 K so my original statement is wrong, it is a bug with cordova-android introduced by https://github.com/apache/cordova-android/pull/1700 It looks like the intent is to set the default background color to white (#FF) but it seems like it ends up defaulting to `0` instead which is an incorrect color value. ``` Task :app:mergeDebugResources FAILED C:\Users\eduar.gradle\caches\transforms-4\01bf680c3083cc7cc00592872a745a49\transformed\jetified-play-services-base-18.0.1\res\values\values.xml:4:0: Invalid for given resource value. ``` Definitely threw me off leading to believe the issue is elsewhere. If you explicitly set the `AndroidWindowSplashScreenBackground` preference, it should work around the Invalid color issue. Do note that the google maps plugin has several other issues and will not build without further changes. But the `Invalid for given resource value` issue is a bug in cordova-android@13. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Build failed with Invalid for given resource value. error [cordova-android]
breautek commented on issue #1714: URL: https://github.com/apache/cordova-android/issues/1714#issuecomment-2135664715 > Any idea how i can show it to you ? I just create an empty cordova project with cordova 12 and add the android 13, installed this plugin: https://github.com/mapsplugin/cordova-plugin-googlemaps and it gives me the above error. Could you give me your enviroment spec ? maybe my gradle or any config file like config.xml must change to make it work. > Any idea how i can show it to you ? I just create an empty cordova project with cordova 12 and add the android 13, installed this plugin: https://github.com/mapsplugin/cordova-plugin-googlemaps and it gives me the above error. Could you give me your enviroment spec ? maybe my gradle or any config file like config.xml must change to make it work. I cannot explain why downgrading my version numbers didn't reproduce the issue but using the original authored plugin on a base hello world project does reproduce the issue. Likewise updating the version numbers doesn't correct it either. This is out of scope of cordova-android but I'll spend a few minutes digging to see if I can find an explanation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Build failed with Invalid for given resource value. error [cordova-android]
eduardojmrosa commented on issue #1714: URL: https://github.com/apache/cordova-android/issues/1714#issuecomment-2135623296 Any idea how i can show it to you ? I just create an empty cordova project with cordova 12 and add the android 13, installed this plugin: https://github.com/mapsplugin/cordova-plugin-googlemaps and it gives me the above error. Could you give me your enviroment spec ? maybe my gradle or any config file like config.xml must change to make it work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Build failed with Invalid for given resource value. error [cordova-android]
breautek commented on issue #1714: URL: https://github.com/apache/cordova-android/issues/1714#issuecomment-2135333065 For what it's worth I just updated one of my apps to use cordova-android@13 and didn't encounter build issues with google maps plugin. I also reverted those versions back down to what is in the original repo and didn't reproduce the issue either. If you could package up and share your sample reproduction issue that reproduces your issue I can try taking a deeper look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Unable to set the custom icons [cordova-electron]
mbreslein-thd commented on issue #251: URL: https://github.com/apache/cordova-electron/issues/251#issuecomment-2134630714 This issue still persists 15 Months later. Any help with this would be appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] 6.1.0 Splash screen doesn't repect delay default [cordova-ios]
dpogue commented on issue #927: URL: https://github.com/apache/cordova-ios/issues/927#issuecomment-2134559534 I'll try to review the docs as part of https://github.com/apache/cordova-docs/pull/1348 and make sure they're accurate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Spash screen disappears before this.splashScreen.hide() [cordova-ios]
dpogue commented on issue #1220: URL: https://github.com/apache/cordova-ios/issues/1220#issuecomment-2134556729 I've tested this in Cordova-iOS 7.1.0 and I cannot reproduce the issue as described. Please test and confirm if you are still seeing this issue, otherwise we will close this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] fix: Set CodeSigning Entitlements in Xcode Project at Target level [cordova-ios]
codecov-commenter commented on PR #1438: URL: https://github.com/apache/cordova-ios/pull/1438#issuecomment-2134527975 ## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1438?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 78.35%. Comparing base [(`2240ebc`)](https://app.codecov.io/gh/apache/cordova-ios/commit/2240ebcca08060130eb9c6ffc5b9b35ddb85b248?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`1cb893a`)](https://app.codecov.io/gh/apache/cordova-ios/commit/1cb893a9c7bdccf3d6d7076b00fd9deefd950f2e?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master#1438 +/- ## === Coverage 78.35% 78.35% === Files 16 16 Lines1825 1825 === Hits 1430 1430 Misses395 395 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-ios/pull/1438?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[PR] fix: Set CodeSigning Entitlements in Xcode Project at Target level [cordova-ios]
dpogue opened a new pull request, #1438: URL: https://github.com/apache/cordova-ios/pull/1438 ### Platforms affected iOS ### Motivation and Context Closes GH-1135. ### Description Moved `CODE_SIGN_ENTITLEMENTS` from the xcconfig (which affects the entire project and all its targets) to the target settings of the application target within the Xcode project. ### Testing Confirmed manually that the Xcode project settings for the target have the expected values. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] fix: alerts could freeze the application [cordova-ios]
codecov-commenter commented on PR #1437: URL: https://github.com/apache/cordova-ios/pull/1437#issuecomment-2134479239 ## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1437?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 78.35%. Comparing base [(`2240ebc`)](https://app.codecov.io/gh/apache/cordova-ios/commit/2240ebcca08060130eb9c6ffc5b9b35ddb85b248?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`7a9b859`)](https://app.codecov.io/gh/apache/cordova-ios/commit/7a9b8591a7e810225f885494324fa1f173ffa666?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master#1437 +/- ## === Coverage 78.35% 78.35% === Files 16 16 Lines1825 1825 === Hits 1430 1430 Misses395 395 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-ios/pull/1437?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[PR] fix: alerts could freeze the application [cordova-ios]
dpogue opened a new pull request, #1437: URL: https://github.com/apache/cordova-ios/pull/1437 ### Platforms affected iOS ### Motivation and Context Closes GH-1120. Closes GH-1121. Closes GH-1429. ### Description In cases where the system was presenting something on the screen (such as a permission prompt, or an undo dialog) or in cases where the `CDVViewController` was not the root view controller (such as in a tabbed navigator), trying to show any dialogs triggered from the WebView would attempt to create an alert on the root view controller and get the view hierarchy into a bad state. Now, we only try to display alerts on the `CDVViewController` that owns the WebView. This means that alerts can potentially end up behind other system dialogs, but the view controller no longer freezes. (As an aside, having access to the `CDVViewController` here will be helpful for some future things too...) ### Testing Tested manually by triggering an alert while a permission prompt was being displayed and confirmed that the app continued working as expected. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Build failed with Invalid for given resource value. error [cordova-android]
breautek commented on issue #1714: URL: https://github.com/apache/cordova-android/issues/1714#issuecomment-2134157216 I assume you mean https://github.com/mapsplugin/cordova-plugin-googlemaps/tree/master My workplace utilises this plugin as well, unfortunately the original author no longer maintains it. If you're using the original version, the gmaps the plugin installs by default is quite dated. The plugin also doesn't have `values.xml` so perhaps it's coming from google maps sdk. My workplace maintains a fork but it also has proprietary code attached so it's not exactly usable as is. I did run a dev build of cordova-android@13 against my apps awhile back (approx. a year ago...) without issue. Maybe because my apps are using a more recent version of gmaps sdk. You could try applying https://github.com/totalpave/cordova-plugin-googlemaps/commit/f74b8e49fe832e0e2fec46e82904d2b504753574 to your own fork to see if it solves your issue. The original plugin has the ability to set the version via `config.xml` but it uses the same variable for multiple dependencies, and there is no `18.2.0` version for `com.google.android.gms:play-services-location`. The linked changeset above separates out the variables and sets the default value to the latest versions at the time of the changeset... the current android gmaps version today is still 18.2.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Build failed with Invalid for given resource value. error [cordova-android]
eduardojmrosa commented on issue #1714: URL: https://github.com/apache/cordova-android/issues/1714#issuecomment-2134149570 steps i took to find out -copy my angular project to a new folder -create new app with cordova -add android 13 - install plugin by plugin and run in the android device - notice the error with googlemaps - remove it and it build sucessfully At this point, anything i can do to fix this ? i mean change the plugin(don´t think is possible) or anything can be changed in the cordova-android release to fix ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Build failed with Invalid for given resource value. error [cordova-android]
eduardojmrosa commented on issue #1714: URL: https://github.com/apache/cordova-android/issues/1714#issuecomment-2134148662 I just find out that is the cordova plugin googlemaps givin this error. My app is purely based on this plugin. This error came out in this update. I have a project with android 12 that work pretty well with the same versions. Anything i can do to solve this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Build failed with Invalid for given resource value. error [cordova-android]
breautek commented on issue #1714: URL: https://github.com/apache/cordova-android/issues/1714#issuecomment-2134105989 `values.xml` is not a file that Cordova prepares. So it's likely caused by a plugin that your project has installed. Might be easy to scan the `plugins/` folder to see if anyone of your plugins references `values.xml`, and if they do; that plugin is most likely the culprit. If you find no references, then it could be coming from a native library being imported by that plugin. In which case I think the best way to determine which plugin is causing the problem is to setup a new project and add each plugin one at a time. Once the project breaks, then you probably found the bad plugin. When using a hello world app project to test your plugins, Start the build with no plugins installed to rule out that a basic hello world doesn't actually reproduce your issue in your environent. Then proceed to install one plugin at a time and rebuilding after each plugin install. Let us know what you find. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[I] Build failed with Invalid for given resource value. error [cordova-android]
eduardojmrosa opened a new issue, #1714: URL: https://github.com/apache/cordova-android/issues/1714 Hi, my project as cordova 12 with android 12 and i just update the android platform to 13, i change my jdk version to 17 and my gradle to 8.7 but when i run the cordova run android it keep send me this error > Task :app:mergeDebugResources FAILED C:\Users\eduar\.gradle\caches\transforms-4\01bf680c3083cc7cc00592872a745a49\transformed\jetified-play-services-base-18.0.1\res\values\values.xml:4:0: Invalid for given resource value. Already removed the platform, added it back. Clear the gradle cache and force npm cache clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] fix: Properly set the WebView config when it is provided [cordova-ios]
codecov-commenter commented on PR #1436: URL: https://github.com/apache/cordova-ios/pull/1436#issuecomment-2134082287 ## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1436?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 78.35%. Comparing base [(`2240ebc`)](https://app.codecov.io/gh/apache/cordova-ios/commit/2240ebcca08060130eb9c6ffc5b9b35ddb85b248?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`93a95e6`)](https://app.codecov.io/gh/apache/cordova-ios/commit/93a95e661ff83b37704f9098f614258e473565aa?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master#1436 +/- ## === Coverage 78.35% 78.35% === Files 16 16 Lines1825 1825 === Hits 1430 1430 Misses395 395 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-ios/pull/1436?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] fix: Properly set the WebView config when it is provided [cordova-ios]
dpogue commented on PR #1436: URL: https://github.com/apache/cordova-ios/pull/1436#issuecomment-2134077396 /fyi @msmtamburro -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[PR] fix: Properly set the WebView config when it is provided [cordova-ios]
dpogue opened a new pull request, #1436: URL: https://github.com/apache/cordova-ios/pull/1436 ### Platforms affected iOS ### Motivation and Context Fixes GH-1423 (based on the comment on https://github.com/apache/cordova-ios/commit/4c8136345ae9622646ee7e4eb60ba2b37ad44fbe#r142043240) ### Description Check that the engine class instance responds to the `initWithFrame:configuration:` selector rather than the engine class itself (because it's not a static class method). ### Testing All unit tests pass, but I don't think we have test coverage for this particular feature. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] fix: Fix version checking helper scripts [cordova-ios]
codecov-commenter commented on PR #1435: URL: https://github.com/apache/cordova-ios/pull/1435#issuecomment-2134074368 ## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1435?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 78.35%. Comparing base [(`2240ebc`)](https://app.codecov.io/gh/apache/cordova-ios/commit/2240ebcca08060130eb9c6ffc5b9b35ddb85b248?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`25185a3`)](https://app.codecov.io/gh/apache/cordova-ios/commit/25185a3b088b16ad8a3bda7acfcd8f6f0eb15240?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master#1435 +/- ## === Coverage 78.35% 78.35% === Files 16 16 Lines1825 1825 === Hits 1430 1430 Misses395 395 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-ios/pull/1435?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[PR] fix: Fix version checking helper scripts [cordova-ios]
dpogue opened a new pull request, #1435: URL: https://github.com/apache/cordova-ios/pull/1435 Closes GH-1415. ### Platforms affected iOS ### Motivation and Context Fixes GH-1415 & GH-1432 ### Description The bin scripts in the template needed to be updated to refer to the cordova-ios internals as a node module instead of as loose files in the same directory. ### Testing All unit tests pass. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] cordova-plugin-file 8.0.0 doesn'work with android 11.0.0 [cordova-plugin-file]
breautek commented on issue #584: URL: https://github.com/apache/cordova-plugin-file/issues/584#issuecomment-2132207098 If you have attempted to install v8, make sure you use `cordova plugin remove cordova-plugin-file` to uninstall the plugin (or whatever the ionic equivalent command is that triggers the cordova command). Cordova plugin has a downloaded and installed (for each platform) state. This part I don't really like about Cordova but if you're attempting to install a different version of a plugin that is already downloaded (e.g. it exists inside `/plugins/`) then it will ignore the download, even if it's not the same version and will install the version that is already stored in `/plugins/`, even if it's not the same version being requested. I feel like this might be what you're experiencing, it's definitely not intuitive behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] cordova-plugin-file 8.0.0 doesn'work with android 11.0.0 [cordova-plugin-file]
alitalaee commented on issue #584: URL: https://github.com/apache/cordova-plugin-file/issues/584#issuecomment-2132193211 > AndroidPersistentFileLocation I had the same issue also when try to install it... ` ionic cordova plugin add cordova-plugin-file@7.0.0 --force Installing "cordova-plugin-file" for android Plugin doesn't support this project's cordova-android version. cordova-android: 11.0.0, failed version requirement: >=12.0.0 Skipping 'cordova-plugin-file' for android Adding cordova-plugin-file to package.json ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] remove potential error when setting exit code [cordova-cli]
breautek commented on PR #640: URL: https://github.com/apache/cordova-cli/pull/640#issuecomment-2131363732 All test passes. If there are no objections in the next couple of days or so I'll do a merge so that this change is included on our next release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] remove potential error when setting exit code [cordova-cli]
codecov-commenter commented on PR #640: URL: https://github.com/apache/cordova-cli/pull/640#issuecomment-2131362931 ## [Codecov](https://app.codecov.io/gh/apache/cordova-cli/pull/640?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 70.68%. Comparing base [(`c06b573`)](https://app.codecov.io/gh/apache/cordova-cli/commit/c06b573f523d17964762d8315d183aadaf961c84?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`fbf16da`)](https://app.codecov.io/gh/apache/cordova-cli/commit/fbf16da9ac12bd0e3e4304674ed2bff60273f4ae?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #640 +/- ## === Coverage 70.68% 70.68% === Files 44 Lines 307 307 === Hits 217 217 Misses 90 90 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-cli/pull/640?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Geolocation working on android 13,14 even 8 but not on android 12 function does not call no error in console [cordova-plugin-geolocation]
breautek commented on issue #273: URL: https://github.com/apache/cordova-plugin-geolocation/issues/273#issuecomment-2130535161 > @breautek I running into the same issue and was wondering if the Android 12 bug affects all cordova builds with cordova Android 12.0.1 platforms? My users are experiencing the same problem with Samsung S22 Android 14 UI version 6.1. I believe so, https://issues.chromium.org/issues/40205003 isn't fully addressed yet it seems. Cordova doesn't actually have an implementation of geolocation for android. It relies on the system webview implementation. So it affects all cordova platforms. It sounds like there is a fix available but you would be relying on users to update their devices, and sometimes carriers don't deliver AOSP updates, which unfortunately means users will be stuck on a bugged version. > The underlying bug in Android ([b/208263743](https://issues.chromium.org/issues/208263743)) is supposed to be fixed in the QPR1 update for Android 12, which most devices would have received around the end of 2021, but it's unfortunately not guaranteed that all Android 12 devices will have gotten that update in practice. All Android 13 and later devices will have the fix, though. > > So, if you're seeing problems specifically with some Android 12 devices and not other versions then probably those devices just haven't gotten the update. If you're seeing issues on other versions as well then this may need further investigation. The ticket is still open, I think they are looking to find a solution in the system webview since it got migrated. If they patch a workaround in the webview then that update should make it to all users receiving updates from Google Play Store. Another potential workaround is using a plugin that implements native geolocation APIs. Don't really know of any that I can vouch for but I'd imagine most native implementations would generally make use of Google's Fuse location APIs, which will tie your app to Google Play services, e.g. your app will only work on Google-enabled devices. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [I] Geolocation working on android 13,14 even 8 but not on android 12 function does not call no error in console [cordova-plugin-geolocation]
ckang777 commented on issue #273: URL: https://github.com/apache/cordova-plugin-geolocation/issues/273#issuecomment-2130528268 @breautek I running into the same issue and was wondering if the Android 12 bug affects all cordova builds with cordova Android 12.0.1 platforms? My users are experiencing the same problem with Samsung S22 Android 14 UI version 6.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [D] How to write a build script to change framework from "Do not Embed" to "Embed and sign" [cordova]
GitHub user majeed-platogo closed a discussion: How to write a build script to change framework from "Do not Embed" to "Embed and sign" Hi all, I'm trying to use a custom plugin in the plugins `plugin.xml`, I have the following line ```xml ``` when the build is completed the app is stuck on the splashscreen. But, if i navigate `projectName -> General -> Frameworks, Library and embedded Content` and switch from `Do not Embed` to `Embed and sign` the app works. https://github.com/apache/cordova/assets/126869614/87bc0ed2-ccfe-4bcc-90c7-6d28bf732f99;> So, my question is how can I automate this step during my build process so i don't have to manually do it every time GitHub link: https://github.com/apache/cordova/discussions/477 This is an automatically sent email for issues@cordova.apache.org. To unsubscribe, please send an email to: issues-unsubscr...@cordova.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [D] How to write a build script to change framework from "Do not Embed" to "Embed and sign" [cordova]
GitHub user majeed-platogo added a comment to the discussion: How to write a build script to change framework from "Do not Embed" to "Embed and sign" This was the solution, Thank you so much GitHub link: https://github.com/apache/cordova/discussions/477#discussioncomment-9547502 This is an automatically sent email for issues@cordova.apache.org. To unsubscribe, please send an email to: issues-unsubscr...@cordova.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [D] How to write a build script to change framework from "Do not Embed" to "Embed and sign" [cordova]
GitHub user breautek added a comment to the discussion: How to write a build script to change framework from "Do not Embed" to "Embed and sign" I think you want to use the [framework](https://cordova.apache.org/docs/en/12.x/plugin_ref/spec.html#framework) tag instead. I have an example usage which does exactly what you want in an older plugin that I used to maintain: https://github.com/totalpaveinc/cordova-plugin-libsqlite/blob/main/plugin.xml#L22 It does require [improvements](https://github.com/apache/cordova-ios/pull/1266) added in cordova-ios 7. If I recall correctly, older versions it was impossible to embed AND link at the same time, because linking was always the inverse of embedding. The PR merged for 7.0.0 release effectively adds the `link` directive allowing you to both embed and link. Therefore for this to work properly you'll also need to be using `cordova-ios@^7`. GitHub link: https://github.com/apache/cordova/discussions/477#discussioncomment-9546388 This is an automatically sent email for issues@cordova.apache.org. To unsubscribe, please send an email to: issues-unsubscr...@cordova.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] blog: cordova-android@13.0.0 release announcement [cordova-docs]
erisu merged PR #1351: URL: https://github.com/apache/cordova-docs/pull/1351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] blog: cordova-android@13.0.0 release announcement [cordova-docs]
breautek commented on code in PR #1351:
URL: https://github.com/apache/cordova-docs/pull/1351#discussion_r1612453724
##
www/_posts/2024-05-23-cordova-android-13.0.0.md:
##
@@ -0,0 +1,158 @@
+---
+layout: post
+author:
+name: Bryan Ellis
+title: "Cordova Android 13.0.0 Released!"
+categories: announcements
+tags: news releases
+---
+
+We are happy to announce that we have just released `Cordova Android 13.0.0`!
This is one of Cordova's supported platforms for building Android applications.
+
+* [cordova-android@13.0.0](https://www.npmjs.com/package/cordova-android)
+
+**To upgrade:**
+
+```bash
+cordova platform remove android
+cordova platform add android@13.0.0
+```
+
+**To install:**
+
+```bash
+cordova platform add android@13.0.0
+```
+
+## Release Highlights
+
+### BREAKING CHANGES
+
+* **Increased Target SDK**
+
+This release has increased the target SDK to 34 (Android 14).
+
+* **Increased Android Studio Requirement**
+
+Android Studio Jellyfish is required if building and running from Android
Studio.
+
+* **Required Build Tools**
+
+To use `cordova-android@13`, SDK Platform `34` and SDK Build Tools
`34.0.0` must be installed. Older build tools version can be uninstalled if
older versions of cordova-android is no longer used in your projects.
+
+To install SDK Platform 34:
+
+1. Open Android Studio's **SDK Manager**:
+2. Click on `SDK Platforms` tab
+3. Check `Android 14.0 ("UpsideDownCake")` which has the `API Level` of
`34`
+4. Click `Apply`
+
+
+
+To install SDK Build Tools 34.0.0:
+
+5. Open Android Studio's **SDK Manager**:
+6. Click on `SDK Tools` tab
+7. Check `Show Package Details`
+8. Expand `Android SDK Build-Tools`
+9. Check `34.0.0`
+10. Click `Apply`
+
+
+
+* **Project Dependencies**
+
+The following project dependencies were bumpped:
+
+* Kotlin: `1.9.24`
+* Gradle: `8.7`
+* Android Gradle Plugin (AGP): `8.3.0`
+
+If you or a plugin has made changes to any of the following configuration
preferences, the build results might not match the expected outcomes with this
release:
+
+* `android-minSdkVersion`
+* `android-maxSdkVersion`
+* `android-targetSdkVersion`
+* `android-compileSdkVersion`
+* `android-buildToolsVersion`
+* `GradleVersion`
+* `AndroidGradlePluginVersion`
+* `GradlePluginKotlinVersion`
Review Comment:
Perhaps we can give a table:
|Preference|Default Value|
|---|---|
|`android-minSdkVersion`|24|
|`android-maxSdkVersion`|_Not set_|
|`android-targetSdkVersion`|34|
|`android-compileSdkVersion`|_android-targetSdkVersion configured value_|
|`android-buildToolsVersion`|"34.0.0"|
|`GradleVersion`|"8.7"|
|`AndroidGradlePluginVersion`|"8.3.0"|
|`GradlePluginKotlinVersion`|"1.9.24"|
Markdown:
```markdown
|Preference|Default Value|
|---|---|
|`android-minSdkVersion`|24|
|`android-maxSdkVersion`|_Not set_|
|`android-targetSdkVersion`|34|
|`android-compileSdkVersion`|_android-targetSdkVersion configured value_|
|`android-buildToolsVersion`|"34.0.0"|
|`GradleVersion`|"8.7"|
|`AndroidGradlePluginVersion`|"8.3.0"|
|`GradlePluginKotlinVersion`|"1.9.24"|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] blog: cordova-android@13.0.0 release announcement [cordova-docs]
dpogue commented on code in PR #1351:
URL: https://github.com/apache/cordova-docs/pull/1351#discussion_r1612401133
##
www/_posts/2024-05-23-cordova-android-13.0.0.md:
##
@@ -0,0 +1,158 @@
+---
+layout: post
+author:
+name: Bryan Ellis
+title: "Cordova Android 13.0.0 Released!"
+categories: announcements
+tags: news releases
+---
+
+We are happy to announce that we have just released `Cordova Android 13.0.0`!
This is one of Cordova's supported platforms for building Android applications.
+
+* [cordova-android@13.0.0](https://www.npmjs.com/package/cordova-android)
+
+**To upgrade:**
+
+```bash
+cordova platform remove android
+cordova platform add android@13.0.0
+```
+
+**To install:**
+
+```bash
+cordova platform add android@13.0.0
+```
+
+## Release Highlights
+
+### BREAKING CHANGES
+
+* **Increased Target SDK**
+
+This release has increased the target SDK to 34 (Android 14).
+
+* **Increased Android Studio Requirement**
+
+Android Studio Jellyfish is required if building and running from Android
Studio.
+
+* **Required Build Tools**
+
+To use `cordova-android@13`, SDK Platform `34` and SDK Build Tools
`34.0.0` must be installed. Older build tools version can be uninstalled if
older versions of cordova-android is no longer used in your projects.
+
+To install SDK Platform 34:
+
+1. Open Android Studio's **SDK Manager**:
+2. Click on `SDK Platforms` tab
+3. Check `Android 14.0 ("UpsideDownCake")` which has the `API Level` of
`34`
+4. Click `Apply`
+
+
+
+To install SDK Build Tools 34.0.0:
+
+5. Open Android Studio's **SDK Manager**:
+6. Click on `SDK Tools` tab
+7. Check `Show Package Details`
+8. Expand `Android SDK Build-Tools`
+9. Check `34.0.0`
+10. Click `Apply`
+
+
+
+* **Project Dependencies**
+
+The following project dependencies were bumpped:
+
+* Kotlin: `1.9.24`
+* Gradle: `8.7`
+* Android Gradle Plugin (AGP): `8.3.0`
+
+If you or a plugin has made changes to any of the following configuration
preferences, the build results might not match the expected outcomes with this
release:
+
+* `android-minSdkVersion`
+* `android-maxSdkVersion`
+* `android-targetSdkVersion`
+* `android-compileSdkVersion`
+* `android-buildToolsVersion`
+* `GradleVersion`
+* `AndroidGradlePluginVersion`
+* `GradlePluginKotlinVersion`
Review Comment:
Is it worth mentioning what the default values are, or linking to where they
are all defined?
We're basically telling people "If you edited any of these, please review
the new settings" but not giving any pointer to where to find those new
settings.
##
www/_posts/2024-05-23-cordova-android-13.0.0.md:
##
@@ -0,0 +1,158 @@
+---
+layout: post
+author:
+name: Bryan Ellis
+title: "Cordova Android 13.0.0 Released!"
+categories: announcements
+tags: news releases
+---
+
+We are happy to announce that we have just released `Cordova Android 13.0.0`!
This is one of Cordova's supported platforms for building Android applications.
+
+* [cordova-android@13.0.0](https://www.npmjs.com/package/cordova-android)
+
+**To upgrade:**
+
+```bash
+cordova platform remove android
+cordova platform add android@13.0.0
+```
+
+**To install:**
+
+```bash
+cordova platform add android@13.0.0
+```
+
+## Release Highlights
+
+### BREAKING CHANGES
+
+* **Increased Target SDK**
+
+This release has increased the target SDK to 34 (Android 14).
+
+* **Increased Android Studio Requirement**
+
+Android Studio Jellyfish is required if building and running from Android
Studio.
+
+* **Required Build Tools**
+
+To use `cordova-android@13`, SDK Platform `34` and SDK Build Tools
`34.0.0` must be installed. Older build tools version can be uninstalled if
older versions of cordova-android is no longer used in your projects.
+
+To install SDK Platform 34:
+
+1. Open Android Studio's **SDK Manager**:
+2. Click on `SDK Platforms` tab
+3. Check `Android 14.0 ("UpsideDownCake")` which has the `API Level` of
`34`
+4. Click `Apply`
+
+
+
+To install SDK Build Tools 34.0.0:
+
+5. Open Android Studio's **SDK Manager**:
Review Comment:
Feels a bit weird to me that the numbering keeps going from the previous
list. Maybe this should start at 1 again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
Re: [PR] blog: cordova-android@13.0.0 release announcement [cordova-docs]
erisu commented on code in PR #1351:
URL: https://github.com/apache/cordova-docs/pull/1351#discussion_r1611716048
##
www/_posts/2024-05-23-cordova-android-13.0.0.md:
##
@@ -0,0 +1,158 @@
+---
+layout: post
+author:
+name: Bryan Ellis
+title: "Cordova Android 13.0.0 Released!"
+categories: announcements
+tags: news releases
+---
+
+We are happy to announce that we have just released `Cordova Android 13.0.0`!
This is one of Cordova's supported platforms for building Android applications.
+
+* [cordova-android@13.0.0](https://www.npmjs.com/package/cordova-android)
+
+**To upgrade:**
+
+```bash
+cordova platform remove android
+cordova platform add android@13.0.0
+```
+
+**To install:**
+
+```bash
+cordova platform add android@13.0.0
+```
+
+## Release Highlights
+
+### BREAKING CHANGES
+
+* **Increased Target SDK**
+
+This release has increased the target SDK to 34 (Android 14).
+
+* **Increased Android Studio Requirement**
+
+Android Studio Jellyfish is required if building and running from Android
Studio.
+
+* **Required Build Tools**
+
+To use `cordova-android@13`, SDK Platform `34` and SDK Build Tools
`34.0.0` must be installed. Older build tools version can be uninstalled if
older versions of cordova-android is no longer used in your projects.
+
+To install SDK Platform 34:
+
+1. Open Android Studio's **SDK Manager**:
+2. Click on `SDK Platforms` tab
+3. Check `Android 14.0 ("UpsideDownCake")` which has the `API Level` of
`34`
+4. Click `Apply`
+
+
+
+To install SDK Build Tools 34.0.0:
+
+5. Open Android Studio's **SDK Manager**:
+6. Click on `SDK Tools` tab
+7. Check `Show Package Details`
+8. Expand `Android SDK Build-Tools`
+9. Check `34.0.0`
+10. Click `Apply`
+
+
+
+* **Project Dependencies**
+
+The following project dependencies were bumpped:
+
+* Kotlin: `1.9.24`
+* Gradle: `8.7`
+* Android Gradle Plugin (AGP): `8.3.0`
+
+If you or a plugin has made changes to any of the following configuration
preferences, the build results might not match the expected outcomes with this
release:
+
+* `android-minSdkVersion`
+* `android-maxSdkVersion`
+* `android-targetSdkVersion`
+* `android-compileSdkVersion`
+* `android-buildToolsVersion`
+* `GradleVersion`
+* `AndroidGradlePluginVersion`
+* `GradlePluginKotlinVersion`
+
+Please take note of the versions that have been updated in this release.
If you have manually modified any of these values, it is recommended to review
and update the preference values accordingly.
+
+* **Increased Java Requirement**
+
+The Java Development Kit (JDK) requirement has been increased to version
17 due to the new versions of dependencies and tooling previously described.
+
+* **Removed `kotlin-android-extensions`**
+
+`kotlin-android-extensions` will no longer be checked out when kotlin is
less than or equal to version `1.8.0`.
Review Comment:
Yes, `greater` was correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
