[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-09-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532441#comment-15532441
 ] 

ASF GitHub Bot commented on CB-11522:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/197


> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-09-29 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532440#comment-15532440
 ] 

ASF subversion and git services commented on CB-11522:
--

Commit 8b836a78304d397f62ff882e188eacbba3e398b4 in cordova-windows's branch 
refs/heads/master from [~daserge]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=8b836a7 ]

CB-11522 [windows] Make cordova-js handle 'unknown' type


> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-09-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532419#comment-15532419
 ] 

ASF GitHub Bot commented on CB-11522:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-js/pull/137


> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-09-29 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532418#comment-15532418
 ] 

ASF subversion and git services commented on CB-11522:
--

Commit 640f151f0badfbf7d3ede6b7a2befb7a96054dd7 in cordova-js's branch 
refs/heads/master from [~daserge]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=640f151 ]

CB-11522 [windows] Make cordova-js handle 'unknown' type


> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-09-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532210#comment-15532210
 ] 

ASF GitHub Bot commented on CB-11522:
-

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-js/pull/137
  
LGTM


> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-09-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490887#comment-15490887
 ] 

ASF GitHub Bot commented on CB-11522:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-windows/pull/197
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-windows/pull/197?src=pr) is 
74.25% (diff: 100%)
> Merging 
[#197](https://codecov.io/gh/apache/cordova-windows/pull/197?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #197   diff @@
==
  Files14 14  
  Lines  1942   1942  
  Methods 362362  
  Messages  0  0  
  Branches391391  
==
  Hits   1442   1442  
  Misses  500500  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[0855feb...bd5dbc9](https://codecov.io/gh/apache/cordova-windows/compare/0855feb13aa5de334d5a7cdedea646f31bf8ddfe...bd5dbc9fe476dd4d941a0bcd68a449ac5ba9a323?src=pr)


> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-09-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490876#comment-15490876
 ] 

ASF GitHub Bot commented on CB-11522:
-

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-windows/pull/197

CB-11522 [windows] Make cordova-js clone handle 'unknown' type

See details in 
[CB-11522](https://issues.apache.org/jira/browse/CB-11522?focusedCommentId=15469653=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15469653)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-windows CB-11522-type-unknown

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #197


commit bd5dbc9fe476dd4d941a0bcd68a449ac5ba9a323
Author: daserge 
Date:   2016-09-14T16:31:28Z

CB-11522 [windows] Make cordova-js handle 'unknown' type




> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-09-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490874#comment-15490874
 ] 

ASF GitHub Bot commented on CB-11522:
-

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-js/pull/137

CB-11522 [windows] Make cordova-js handle 'unknown' type

See details in 
[CB-11522](https://issues.apache.org/jira/browse/CB-11522?focusedCommentId=15469653=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15469653)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-js CB-11522-type-unknown

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-js/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #137


commit 9aada3bf8122e8527507e902134af8736b9b1b1d
Author: daserge 
Date:   2016-09-14T16:28:15Z

CB-11522 [windows] Make cordova-js handle 'unknown' type




> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-09-13 Thread Sergey Shakhnazarov (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487419#comment-15487419
 ] 

Sergey Shakhnazarov commented on CB-11522:
--

Thanks, I got it (I was testing on Windows 10 desktop where it was not 
reproducing).
Looks like we are missing a check for JScript' typeof {{"unknown"}} 
[here|https://github.com/apache/cordova-js/pull/134/files#diff-aaf31aeb3814626dd30795c7aec9f813R111].
This will fix cloning although things will break if we access 
{{args.raw.uri.absoluteCanonicalUri}} for example.

> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-09-13 Thread Michael Dudek (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487315#comment-15487315
 ] 

Michael Dudek commented on CB-11522:


I'm using latest cordova-windows 4.4.2. The device is Nokia Lumia 1520 with 
latest Windows Phone 8.1.

> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-09-13 Thread Sergey Shakhnazarov (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487294#comment-15487294
 ] 

Sergey Shakhnazarov commented on CB-11522:
--

[~michael.dudek], could you please add details on {{cordova-windows}} version 
which has this issue?
It would also be great to have minimal reproduction sample project(s).
I've tested it with cordova-windows master version and with this [sample 
solution|https://issues.apache.org/jira/browse/CB-11470?focusedCommentId=15344367=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15344367]
 and there is no such exception, {{uri}} is defined.

> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-09-06 Thread Michael Dudek (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469653#comment-15469653
 ] 

Michael Dudek commented on CB-11522:


Unfortunately this fix is not working for Windows.Foundation.Uri type (when app 
is activated by url). "No such interface supported" exception is thrown when 
cloning property "absoluteCanonicalUri".

> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-07-11 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370861#comment-15370861
 ] 

ASF subversion and git services commented on CB-11522:
--

Commit 786b46881940db8ea736f4e3d8b30daa844d52a9 in cordova-windows's branch 
refs/heads/4.4.x from [~daserge]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=786b468 ]

CB-11522 Save raw 'detail' object to activation context

Adds activationContext.raw property to avoid losing the types (for 
ActivationKind.file case for example)

This closes #183


> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-07-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370792#comment-15370792
 ] 

ASF GitHub Bot commented on CB-11522:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/618


> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-07-11 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370791#comment-15370791
 ] 

ASF subversion and git services commented on CB-11522:
--

Commit c2c59e88085b42c5adbc7a189516a67dedd3ab78 in cordova-docs's branch 
refs/heads/master from [~daserge]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=c2c59e8 ]

CB-11522 Do not clone the detail object on activation context

Documents Windows activated event and its quirks

 This closes #618


> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-07-11 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370781#comment-15370781
 ] 

ASF subversion and git services commented on CB-11522:
--

Commit b751825b5d9fed88f9ee2cb060d64ef7f365c57f in cordova-windows's branch 
refs/heads/master from [~daserge]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=b751825 ]

CB-11522 Save raw 'detail' object to activation context

Adds activationContext.raw property to avoid losing the types (for 
ActivationKind.file case for example)

This closes #183


> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-07-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370782#comment-15370782
 ] 

ASF GitHub Bot commented on CB-11522:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/183


> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-07-11 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370732#comment-15370732
 ] 

ASF subversion and git services commented on CB-11522:
--

Commit d403ce434788ffe1937711d6ebcbcc837fcbcb14 in cordova-js's branch 
refs/heads/master from [~daserge]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=d403ce4 ]

CB-11522 Make utils.clone handle properties gracefully

Fix clone method so that it does not crash trying to clone unavailable property

This closes #134


> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-07-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370734#comment-15370734
 ] 

ASF GitHub Bot commented on CB-11522:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-js/pull/134


> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-07-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364623#comment-15364623
 ] 

ASF GitHub Bot commented on CB-11522:
-

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-docs/pull/618

CB-11522 Do not clone the detail object on activation context

Documents Windows activated event and its quirks

[Jira issue](https://issues.apache.org/jira/browse/CB-11522)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-docs CB-11522

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/618.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #618


commit ff2e16bac9f87cacb7700e8162877f057127f444
Author: daserge 
Date:   2016-07-06T16:57:22Z

CB-11522 Do not clone the detail object on activation context

Documents Windows activated event and its quirks




> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-07-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364545#comment-15364545
 ] 

ASF GitHub Bot commented on CB-11522:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-windows/pull/183
  
## [Current coverage][cc-pull] is **72.17%**
> Merging [#183][cc-pull] into [master][cc-base-branch] will not change 
coverage

```diff
@@ master   #183   diff @@
==
  Files14 14  
  Lines  1905   1905  
  Methods 351351  
  Messages  0  0  
  Branches385385  
==
  Hits   1375   1375  
  Misses  530530  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 
[b0502ae...09b96fd][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-windows/compare/b0502ae450c61e8bcb99969a174d062ef751f081...09b96fd88f2c6690b2e34cc1645425caeac2f480
[cc-pull]: https://codecov.io/gh/apache/cordova-windows/pull/183?src=pr


> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-07-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364514#comment-15364514
 ] 

ASF GitHub Bot commented on CB-11522:
-

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-windows/pull/183

CB-11522 Do not clone the detail object on activation context

Adds activationContext.raw property to avoid losing the types (for 
ActivationKind.file case for example)

[Jira issue](https://issues.apache.org/jira/browse/CB-11522)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-windows CB-11522

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #183


commit 09b96fd88f2c6690b2e34cc1645425caeac2f480
Author: daserge 
Date:   2016-07-06T15:56:52Z

CB-11522 Do not clone the detail object on activation context

Adds activationContext.raw property to avoid losing the types (for 
ActivationKind.file case for example)




> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-07-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364464#comment-15364464
 ] 

ASF GitHub Bot commented on CB-11522:
-

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-js/pull/134

CB-11522 Do not clone the detail object on activation context

Fix clone method so that it does not crash trying to clone unavailable 
property

[Jira issue](https://issues.apache.org/jira/browse/CB-11522)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-js CB-11522

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-js/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #134


commit 886843febcc34d7248dfd968fde2e00a34c9be29
Author: daserge 
Date:   2016-07-06T15:26:52Z

CB-11522 Do not clone the detail object on activation context

Fix clone method so that it does not crash trying to clone unavailable 
property




> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Assignee: Sergey Shakhnazarov
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-07-01 Thread Sergey Shakhnazarov (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359189#comment-15359189
 ] 

Sergey Shakhnazarov commented on CB-11522:
--

The second issue is caused by the fact of cloning so we could solve it this way:
Store both raw {{args.detail}} and a cloned one as a fallback - developer then 
could try the raw one first and fallback to the clone in case something is 
missing.
Platform could additionally extend the raw {{args.detail}} automatically 
complementing missing properties from its clone.
I'm going to test Cortana activation case now.

> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-07-01 Thread Sergey Shakhnazarov (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359160#comment-15359160
 ] 

Sergey Shakhnazarov commented on CB-11522:
--

[~cnsdato], I'm pasting some details from related thread:
{quote}
I have 2 issues when kind is 
Windows.ApplicationModel.Activation.ActivationKind.file for file association:
1. The clone fails because neighboringFilesQuery.folder property is not 
accessible
2. When trying to read the StorageFile via 
Windows.Storage.FileIO.readTextAsync() I get a type mismatch.
{quote}

The first one is fixed if we modify the utils.clone method:
{code}
if((!(i in retVal) || retVal[i] != obj[i]) && typeof obj[i] != 
'undefined') {
retVal[i] = utils.clone(obj[i]);
}
{code}

> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11522) Do not clone the detail object on activation context

2016-07-01 Thread Sergey Shakhnazarov (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358896#comment-15358896
 ] 

Sergey Shakhnazarov commented on CB-11522:
--

Error occurring is
{noformat}
Exception is about to be caught by JavaScript library code at line 2237, column 
13 in ms-appx-web://com.example.destinationapp/www/cordova.js
0x80004001 - JavaScript runtime error: Not implemented
WinRT information: Cannot call the requested method (Folder) on a Neighboring 
Files Query.
{noformat}

> Do not clone the detail object on activation context
> 
>
> Key: CB-11522
> URL: https://issues.apache.org/jira/browse/CB-11522
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Reporter: Daniel Toplak
>Priority: Blocker
>  Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context 
> will fail. Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in 
> https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org