[jira] [Commented] (CB-11998) cordova platform add error with cordova-common@1.5.0

2016-10-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567005#comment-15567005
 ] 

ASF GitHub Bot commented on CB-11998:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-lib/pull/500
  
@RyanThomas73 thanks! Unfortunately I've already spent too much time on 
this one line fix, so I'm probably not going to re-visit it for now.



> cordova platform add error with cordova-common@1.5.0
> 
>
> Key: CB-11998
> URL: https://issues.apache.org/jira/browse/CB-11998
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon
> Environment: cordova-common@1.5.0
>Reporter: Shazron Abdullah
>
> This occurs when adding the cordova-ios platform, that has 
> cordova-common@1.5.0
> {code}
> Shazron-rMBP:u shaz$ cordova platform add ~/Apache/cordova-ios --verbose
> Warning: using prerelease version 6.4.0-nightly.2016.10.11.4759c467 
> (cordova-lib@6.4.0-nightly.2016.10.11.4ca3b4ca)
> No scripts found for hook "before_platform_add".
> Warning: using prerelease platform ios@4.3.0-dev.
> Use 'cordova platform add ios@latest' to add the latest published version 
> instead.
> Adding ios project...
> PlatformApi successfully found for platform ios
> Creating Cordova project for the iOS platform:
>   Path: platforms/ios
>   Package: com.u.name
>   Name: u
> Copying iOS template project to /Users/shaz/Desktop/u/platforms/ios
> iOS project created with cordova-ios@4.3.0-dev
> Checking for any plugins added to the project that have not been installed in 
> ios platform
> No differences found between plugins added to project and installed in ios 
> platform. Continuing...
> Generating platform-specific config.xml from defaults for iOS at 
> /Users/shaz/Desktop/u/platforms/ios/u/config.xml
> Merging project's config.xml into platform-specific iOS config.xml
> Merging and updating files from [www, platforms/ios/platform_www] to 
> platforms/ios/www
> Error: ENOENT: no such file or directory, stat 
> '/Users/shaz/Desktop/u/Users/shaz/Desktop/u/www'
> at Error (native)
> at Object.fs.statSync (fs.js:987:18)
> at mapDirectory 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:331:52)
> at 
> /Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:295:20
> at Array.map (native)
> at Object.mergeAndUpdateDir 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:290:12)
> at updateWww 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/lib/prepare.js:153:17)
> at Api.module.exports.prepare 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/lib/prepare.js:48:19)
> at Api.prepare (/Users/shaz/Desktop/u/platforms/ios/cordova/Api.js:188:45)
> at 
> /Users/shaz/.nvm/v6.4.0/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/prepare.js:105:32
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11998) cordova platform add error with cordova-common@1.5.0

2016-10-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566996#comment-15566996
 ] 

ASF GitHub Bot commented on CB-11998:
-

Github user RyanThomas73 commented on the issue:

https://github.com/apache/cordova-lib/pull/500
  
One suggestion - you could simplify the source directory mapping to:
```
// Scan the files in each of the source directories.
var sourceMaps = sourceDirs.map(function (sourceDir) {
var absoluteSourceDir = path.join(rootDir, sourceDir);
if (!fs.existsSync(absoluteSourceDir)) {
throw new Error("Source directory does not exist: " + 
absoluteSourceDir);
}
return mapDirectory(rootDir, sourceDir, include, exclude);
});
```


> cordova platform add error with cordova-common@1.5.0
> 
>
> Key: CB-11998
> URL: https://issues.apache.org/jira/browse/CB-11998
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon
> Environment: cordova-common@1.5.0
>Reporter: Shazron Abdullah
>
> This occurs when adding the cordova-ios platform, that has 
> cordova-common@1.5.0
> {code}
> Shazron-rMBP:u shaz$ cordova platform add ~/Apache/cordova-ios --verbose
> Warning: using prerelease version 6.4.0-nightly.2016.10.11.4759c467 
> (cordova-lib@6.4.0-nightly.2016.10.11.4ca3b4ca)
> No scripts found for hook "before_platform_add".
> Warning: using prerelease platform ios@4.3.0-dev.
> Use 'cordova platform add ios@latest' to add the latest published version 
> instead.
> Adding ios project...
> PlatformApi successfully found for platform ios
> Creating Cordova project for the iOS platform:
>   Path: platforms/ios
>   Package: com.u.name
>   Name: u
> Copying iOS template project to /Users/shaz/Desktop/u/platforms/ios
> iOS project created with cordova-ios@4.3.0-dev
> Checking for any plugins added to the project that have not been installed in 
> ios platform
> No differences found between plugins added to project and installed in ios 
> platform. Continuing...
> Generating platform-specific config.xml from defaults for iOS at 
> /Users/shaz/Desktop/u/platforms/ios/u/config.xml
> Merging project's config.xml into platform-specific iOS config.xml
> Merging and updating files from [www, platforms/ios/platform_www] to 
> platforms/ios/www
> Error: ENOENT: no such file or directory, stat 
> '/Users/shaz/Desktop/u/Users/shaz/Desktop/u/www'
> at Error (native)
> at Object.fs.statSync (fs.js:987:18)
> at mapDirectory 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:331:52)
> at 
> /Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:295:20
> at Array.map (native)
> at Object.mergeAndUpdateDir 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:290:12)
> at updateWww 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/lib/prepare.js:153:17)
> at Api.module.exports.prepare 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/lib/prepare.js:48:19)
> at Api.prepare (/Users/shaz/Desktop/u/platforms/ios/cordova/Api.js:188:45)
> at 
> /Users/shaz/.nvm/v6.4.0/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/prepare.js:105:32
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11998) cordova platform add error with cordova-common@1.5.0

2016-10-11 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566959#comment-15566959
 ] 

ASF subversion and git services commented on CB-11998:
--

Commit 2170099d3aaff99a239a9beba5f517d8b79d1196 in cordova-ios's branch 
refs/heads/master from [~shazron]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=2170099 ]

Added CB-11998 fix into bundled cordova-common


> cordova platform add error with cordova-common@1.5.0
> 
>
> Key: CB-11998
> URL: https://issues.apache.org/jira/browse/CB-11998
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon
> Environment: cordova-common@1.5.0
>Reporter: Shazron Abdullah
>
> This occurs when adding the cordova-ios platform, that has 
> cordova-common@1.5.0
> {code}
> Shazron-rMBP:u shaz$ cordova platform add ~/Apache/cordova-ios --verbose
> Warning: using prerelease version 6.4.0-nightly.2016.10.11.4759c467 
> (cordova-lib@6.4.0-nightly.2016.10.11.4ca3b4ca)
> No scripts found for hook "before_platform_add".
> Warning: using prerelease platform ios@4.3.0-dev.
> Use 'cordova platform add ios@latest' to add the latest published version 
> instead.
> Adding ios project...
> PlatformApi successfully found for platform ios
> Creating Cordova project for the iOS platform:
>   Path: platforms/ios
>   Package: com.u.name
>   Name: u
> Copying iOS template project to /Users/shaz/Desktop/u/platforms/ios
> iOS project created with cordova-ios@4.3.0-dev
> Checking for any plugins added to the project that have not been installed in 
> ios platform
> No differences found between plugins added to project and installed in ios 
> platform. Continuing...
> Generating platform-specific config.xml from defaults for iOS at 
> /Users/shaz/Desktop/u/platforms/ios/u/config.xml
> Merging project's config.xml into platform-specific iOS config.xml
> Merging and updating files from [www, platforms/ios/platform_www] to 
> platforms/ios/www
> Error: ENOENT: no such file or directory, stat 
> '/Users/shaz/Desktop/u/Users/shaz/Desktop/u/www'
> at Error (native)
> at Object.fs.statSync (fs.js:987:18)
> at mapDirectory 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:331:52)
> at 
> /Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:295:20
> at Array.map (native)
> at Object.mergeAndUpdateDir 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:290:12)
> at updateWww 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/lib/prepare.js:153:17)
> at Api.module.exports.prepare 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/lib/prepare.js:48:19)
> at Api.prepare (/Users/shaz/Desktop/u/platforms/ios/cordova/Api.js:188:45)
> at 
> /Users/shaz/.nvm/v6.4.0/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/prepare.js:105:32
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11998) cordova platform add error with cordova-common@1.5.0

2016-10-11 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566950#comment-15566950
 ] 

ASF subversion and git services commented on CB-11998:
--

Commit c44db3d7a00779d5c7eb5ae6150847156858a4f7 in cordova-lib's branch 
refs/heads/master from [~shazron]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=c44db3d ]

CB-11998 - cordova platform add error with cordova-common@1.5.0

 This closes #500


> cordova platform add error with cordova-common@1.5.0
> 
>
> Key: CB-11998
> URL: https://issues.apache.org/jira/browse/CB-11998
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon
> Environment: cordova-common@1.5.0
>Reporter: Shazron Abdullah
>
> This occurs when adding the cordova-ios platform, that has 
> cordova-common@1.5.0
> {code}
> Shazron-rMBP:u shaz$ cordova platform add ~/Apache/cordova-ios --verbose
> Warning: using prerelease version 6.4.0-nightly.2016.10.11.4759c467 
> (cordova-lib@6.4.0-nightly.2016.10.11.4ca3b4ca)
> No scripts found for hook "before_platform_add".
> Warning: using prerelease platform ios@4.3.0-dev.
> Use 'cordova platform add ios@latest' to add the latest published version 
> instead.
> Adding ios project...
> PlatformApi successfully found for platform ios
> Creating Cordova project for the iOS platform:
>   Path: platforms/ios
>   Package: com.u.name
>   Name: u
> Copying iOS template project to /Users/shaz/Desktop/u/platforms/ios
> iOS project created with cordova-ios@4.3.0-dev
> Checking for any plugins added to the project that have not been installed in 
> ios platform
> No differences found between plugins added to project and installed in ios 
> platform. Continuing...
> Generating platform-specific config.xml from defaults for iOS at 
> /Users/shaz/Desktop/u/platforms/ios/u/config.xml
> Merging project's config.xml into platform-specific iOS config.xml
> Merging and updating files from [www, platforms/ios/platform_www] to 
> platforms/ios/www
> Error: ENOENT: no such file or directory, stat 
> '/Users/shaz/Desktop/u/Users/shaz/Desktop/u/www'
> at Error (native)
> at Object.fs.statSync (fs.js:987:18)
> at mapDirectory 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:331:52)
> at 
> /Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:295:20
> at Array.map (native)
> at Object.mergeAndUpdateDir 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:290:12)
> at updateWww 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/lib/prepare.js:153:17)
> at Api.module.exports.prepare 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/lib/prepare.js:48:19)
> at Api.prepare (/Users/shaz/Desktop/u/platforms/ios/cordova/Api.js:188:45)
> at 
> /Users/shaz/.nvm/v6.4.0/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/prepare.js:105:32
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11998) cordova platform add error with cordova-common@1.5.0

2016-10-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566952#comment-15566952
 ] 

ASF GitHub Bot commented on CB-11998:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/500


> cordova platform add error with cordova-common@1.5.0
> 
>
> Key: CB-11998
> URL: https://issues.apache.org/jira/browse/CB-11998
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon
> Environment: cordova-common@1.5.0
>Reporter: Shazron Abdullah
>
> This occurs when adding the cordova-ios platform, that has 
> cordova-common@1.5.0
> {code}
> Shazron-rMBP:u shaz$ cordova platform add ~/Apache/cordova-ios --verbose
> Warning: using prerelease version 6.4.0-nightly.2016.10.11.4759c467 
> (cordova-lib@6.4.0-nightly.2016.10.11.4ca3b4ca)
> No scripts found for hook "before_platform_add".
> Warning: using prerelease platform ios@4.3.0-dev.
> Use 'cordova platform add ios@latest' to add the latest published version 
> instead.
> Adding ios project...
> PlatformApi successfully found for platform ios
> Creating Cordova project for the iOS platform:
>   Path: platforms/ios
>   Package: com.u.name
>   Name: u
> Copying iOS template project to /Users/shaz/Desktop/u/platforms/ios
> iOS project created with cordova-ios@4.3.0-dev
> Checking for any plugins added to the project that have not been installed in 
> ios platform
> No differences found between plugins added to project and installed in ios 
> platform. Continuing...
> Generating platform-specific config.xml from defaults for iOS at 
> /Users/shaz/Desktop/u/platforms/ios/u/config.xml
> Merging project's config.xml into platform-specific iOS config.xml
> Merging and updating files from [www, platforms/ios/platform_www] to 
> platforms/ios/www
> Error: ENOENT: no such file or directory, stat 
> '/Users/shaz/Desktop/u/Users/shaz/Desktop/u/www'
> at Error (native)
> at Object.fs.statSync (fs.js:987:18)
> at mapDirectory 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:331:52)
> at 
> /Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:295:20
> at Array.map (native)
> at Object.mergeAndUpdateDir 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:290:12)
> at updateWww 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/lib/prepare.js:153:17)
> at Api.module.exports.prepare 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/lib/prepare.js:48:19)
> at Api.prepare (/Users/shaz/Desktop/u/platforms/ios/cordova/Api.js:188:45)
> at 
> /Users/shaz/.nvm/v6.4.0/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/prepare.js:105:32
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11998) cordova platform add error with cordova-common@1.5.0

2016-10-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566937#comment-15566937
 ] 

ASF GitHub Bot commented on CB-11998:
-

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-lib/pull/500

CB-11998 - cordova platform add error with cordova-common@1.5.0

### Platforms affected

All platforms.

### What does this PR do?

Fixes "ENOENT: no such file or directory" error when adding a platform that 
has cordova-common@1.5.0

### What testing has been done on this change?

Added failing test in cordova-common library, then fixed it. 
Added a platform with cordova-common@1.5.0 that has this fix.

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-lib CB-11998

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/500.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #500


commit b00086fe053838580d517ed316768f5c794903dd
Author: Shazron Abdullah 
Date:   2016-10-11T22:52:40Z

CB-11998 - cordova platform add error with cordova-common@1.5.0




> cordova platform add error with cordova-common@1.5.0
> 
>
> Key: CB-11998
> URL: https://issues.apache.org/jira/browse/CB-11998
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon
> Environment: cordova-common@1.5.0
>Reporter: Shazron Abdullah
>
> This occurs when adding the cordova-ios platform, that has 
> cordova-common@1.5.0
> {code}
> Shazron-rMBP:u shaz$ cordova platform add ~/Apache/cordova-ios --verbose
> Warning: using prerelease version 6.4.0-nightly.2016.10.11.4759c467 
> (cordova-lib@6.4.0-nightly.2016.10.11.4ca3b4ca)
> No scripts found for hook "before_platform_add".
> Warning: using prerelease platform ios@4.3.0-dev.
> Use 'cordova platform add ios@latest' to add the latest published version 
> instead.
> Adding ios project...
> PlatformApi successfully found for platform ios
> Creating Cordova project for the iOS platform:
>   Path: platforms/ios
>   Package: com.u.name
>   Name: u
> Copying iOS template project to /Users/shaz/Desktop/u/platforms/ios
> iOS project created with cordova-ios@4.3.0-dev
> Checking for any plugins added to the project that have not been installed in 
> ios platform
> No differences found between plugins added to project and installed in ios 
> platform. Continuing...
> Generating platform-specific config.xml from defaults for iOS at 
> /Users/shaz/Desktop/u/platforms/ios/u/config.xml
> Merging project's config.xml into platform-specific iOS config.xml
> Merging and updating files from [www, platforms/ios/platform_www] to 
> platforms/ios/www
> Error: ENOENT: no such file or directory, stat 
> '/Users/shaz/Desktop/u/Users/shaz/Desktop/u/www'
> at Error (native)
> at Object.fs.statSync (fs.js:987:18)
> at mapDirectory 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:331:52)
> at 
> /Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:295:20
> at Array.map (native)
> at Object.mergeAndUpdateDir 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/node_modules/cordova-common/src/FileUpdater.js:290:12)
> at updateWww 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/lib/prepare.js:153:17)
> at Api.module.exports.prepare 
> (/Users/shaz/Desktop/u/platforms/ios/cordova/lib/prepare.js:48:19)
> at Api.prepare (/Users/shaz/Desktop/u/platforms/ios/cordova/Api.js:188:45)
> at 
> /Users/shaz/.nvm/v6.4.0/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/prepare.js:105:32
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org