[jira] [Commented] (CB-12071) Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628358#comment-15628358
 ] 

ASF GitHub Bot commented on CB-12071:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/208


> Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
> ---
>
> Key: CB-12071
> URL: https://issues.apache.org/jira/browse/CB-12071
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugins, Windows
>Affects Versions: 4.4.3
> Environment: Windows Phone 8.1, Windows 8.1, Windows 10 UWP
>Reporter: Luc Humair
>Priority: Critical
>
> I have a plugin which needs an InProcessServerExtension in the project's 
> package.windows.appxmanifest like:
> {code:xml}
> 
> 
> 
> Foo.dll
>  ThreadingModel="both" />
> 
> 
> 
> {code}
> The corresponding DLL is configured in the plugin.xml file using:
> {code:xml}
>  src="src/windows/win81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  src="src/windows/wpa81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  versions="=10"/>
> {code}
> This configuration worked until release 4.4.2. Foo.dll was included in the 
> projects with property "Package Action"="Content" which includes the DLL in 
> the package manifest.
> Release 4.4.3 introduced a patch related to issue CB-11825 that changes  the 
> DLL's "Package Action" to "None". Now the file is no longer included in the 
> package manifest and the build fails for all the platforms with the following 
> error message:
> package.windows.appxmanifest : error APPX0703: Manifest references file 
> 'Foo.dll' which is not part of the payload.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12071) Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628355#comment-15628355
 ] 

ASF subversion and git services commented on CB-12071:
--

Commit d6322b774a6b4db624813f58c3cd8e15a5924a83 in cordova-windows's branch 
refs/heads/master from [~daserge]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=d6322b7 ]

CB-12071 Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows

Adds a test for missing InProcessServer extension case to prevent further 
breakages


> Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
> ---
>
> Key: CB-12071
> URL: https://issues.apache.org/jira/browse/CB-12071
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugins, Windows
>Affects Versions: 4.4.3
> Environment: Windows Phone 8.1, Windows 8.1, Windows 10 UWP
>Reporter: Luc Humair
>Priority: Critical
>
> I have a plugin which needs an InProcessServerExtension in the project's 
> package.windows.appxmanifest like:
> {code:xml}
> 
> 
> 
> Foo.dll
>  ThreadingModel="both" />
> 
> 
> 
> {code}
> The corresponding DLL is configured in the plugin.xml file using:
> {code:xml}
>  src="src/windows/win81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  src="src/windows/wpa81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  versions="=10"/>
> {code}
> This configuration worked until release 4.4.2. Foo.dll was included in the 
> projects with property "Package Action"="Content" which includes the DLL in 
> the package manifest.
> Release 4.4.3 introduced a patch related to issue CB-11825 that changes  the 
> DLL's "Package Action" to "None". Now the file is no longer included in the 
> package manifest and the build fails for all the platforms with the following 
> error message:
> package.windows.appxmanifest : error APPX0703: Manifest references file 
> 'Foo.dll' which is not part of the payload.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12071) Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628195#comment-15628195
 ] 

ASF GitHub Bot commented on CB-12071:
-

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-windows/pull/208
  
LGTM


> Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
> ---
>
> Key: CB-12071
> URL: https://issues.apache.org/jira/browse/CB-12071
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugins, Windows
>Affects Versions: 4.4.3
> Environment: Windows Phone 8.1, Windows 8.1, Windows 10 UWP
>Reporter: Luc Humair
>Priority: Critical
>
> I have a plugin which needs an InProcessServerExtension in the project's 
> package.windows.appxmanifest like:
> {code:xml}
> 
> 
> 
> Foo.dll
>  ThreadingModel="both" />
> 
> 
> 
> {code}
> The corresponding DLL is configured in the plugin.xml file using:
> {code:xml}
>  src="src/windows/win81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  src="src/windows/wpa81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  versions="=10"/>
> {code}
> This configuration worked until release 4.4.2. Foo.dll was included in the 
> projects with property "Package Action"="Content" which includes the DLL in 
> the package manifest.
> Release 4.4.3 introduced a patch related to issue CB-11825 that changes  the 
> DLL's "Package Action" to "None". Now the file is no longer included in the 
> package manifest and the build fails for all the platforms with the following 
> error message:
> package.windows.appxmanifest : error APPX0703: Manifest references file 
> 'Foo.dll' which is not part of the payload.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12071) Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624789#comment-15624789
 ] 

ASF GitHub Bot commented on CB-12071:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-windows/pull/208
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-windows/pull/208?src=pr) is 
74.64% (diff: 100%)
> Merging 
[#208](https://codecov.io/gh/apache/cordova-windows/pull/208?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #208   diff @@
==
  Files15 15  
  Lines  2067   2067  
  Methods 390390  
  Messages  0  0  
  Branches403403  
==
  Hits   1543   1543  
  Misses  524524  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[7ed3c99...369f69a](https://codecov.io/gh/apache/cordova-windows/compare/7ed3c997af55d818354f5b5c38453b7d76ec4aa7...369f69a0618658209f29027abb1c114761ce5b83?src=pr)


> Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
> ---
>
> Key: CB-12071
> URL: https://issues.apache.org/jira/browse/CB-12071
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugins, Windows
>Affects Versions: 4.4.3
> Environment: Windows Phone 8.1, Windows 8.1, Windows 10 UWP
>Reporter: Luc Humair
>Priority: Critical
>
> I have a plugin which needs an InProcessServerExtension in the project's 
> package.windows.appxmanifest like:
> {code:xml}
> 
> 
> 
> Foo.dll
>  ThreadingModel="both" />
> 
> 
> 
> {code}
> The corresponding DLL is configured in the plugin.xml file using:
> {code:xml}
>  src="src/windows/win81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  src="src/windows/wpa81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  versions="=10"/>
> {code}
> This configuration worked until release 4.4.2. Foo.dll was included in the 
> projects with property "Package Action"="Content" which includes the DLL in 
> the package manifest.
> Release 4.4.3 introduced a patch related to issue CB-11825 that changes  the 
> DLL's "Package Action" to "None". Now the file is no longer included in the 
> package manifest and the build fails for all the platforms with the following 
> error message:
> package.windows.appxmanifest : error APPX0703: Manifest references file 
> 'Foo.dll' which is not part of the payload.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12071) Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624749#comment-15624749
 ] 

ASF GitHub Bot commented on CB-12071:
-

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-windows/pull/208

CB-12071 Fix for CB-11825 breaks usage of InProcessServer in Cordova …

…Windows


### Platforms affected
Windows

### What does this PR do?
Adds a test for missing InProcessServer extension case to prevent further 
breakages

### What testing has been done on this change?
Run npm test, checked that None package action breaks the test.

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-windows CB-12071

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/208.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #208


commit 369f69a0618658209f29027abb1c114761ce5b83
Author: daserge 
Date:   2016-11-01T08:27:49Z

CB-12071 Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows

Adds a test for missing InProcessServer extension case to prevent further 
breakages




> Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
> ---
>
> Key: CB-12071
> URL: https://issues.apache.org/jira/browse/CB-12071
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugins, Windows
>Affects Versions: 4.4.3
> Environment: Windows Phone 8.1, Windows 8.1, Windows 10 UWP
>Reporter: Luc Humair
>Priority: Critical
>
> I have a plugin which needs an InProcessServerExtension in the project's 
> package.windows.appxmanifest like:
> {code:xml}
> 
> 
> 
> Foo.dll
>  ThreadingModel="both" />
> 
> 
> 
> {code}
> The corresponding DLL is configured in the plugin.xml file using:
> {code:xml}
>  src="src/windows/win81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  src="src/windows/wpa81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  versions="=10"/>
> {code}
> This configuration worked until release 4.4.2. Foo.dll was included in the 
> projects with property "Package Action"="Content" which includes the DLL in 
> the package manifest.
> Release 4.4.3 introduced a patch related to issue CB-11825 that changes  the 
> DLL's "Package Action" to "None". Now the file is no longer included in the 
> package manifest and the build fails for all the platforms with the following 
> error message:
> package.windows.appxmanifest : error APPX0703: Manifest references file 
> 'Foo.dll' which is not part of the payload.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12071) Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows

[Sergey Shakhnazarov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622216#comment-15622216
 ] 

Sergey Shakhnazarov commented on CB-12071:
--

[~lhm], I've reverted that commit, thanks again for pointing out this issue!
I'm also going to add an automated test for InProcessServer case as it is 
missing now.

> Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
> ---
>
> Key: CB-12071
> URL: https://issues.apache.org/jira/browse/CB-12071
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugins, Windows
>Affects Versions: 4.4.3
> Environment: Windows Phone 8.1, Windows 8.1, Windows 10 UWP
>Reporter: Luc Humair
>Priority: Critical
>
> I have a plugin which needs an InProcessServerExtension in the project's 
> package.windows.appxmanifest like:
> {code:xml}
> 
> 
> 
> Foo.dll
>  ThreadingModel="both" />
> 
> 
> 
> {code}
> The corresponding DLL is configured in the plugin.xml file using:
> {code:xml}
>  src="src/windows/win81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  src="src/windows/wpa81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  versions="=10"/>
> {code}
> This configuration worked until release 4.4.2. Foo.dll was included in the 
> projects with property "Package Action"="Content" which includes the DLL in 
> the package manifest.
> Release 4.4.3 introduced a patch related to issue CB-11825 that changes  the 
> DLL's "Package Action" to "None". Now the file is no longer included in the 
> package manifest and the build fails for all the platforms with the following 
> error message:
> package.windows.appxmanifest : error APPX0703: Manifest references file 
> 'Foo.dll' which is not part of the payload.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12071) Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622204#comment-15622204
 ] 

ASF subversion and git services commented on CB-12071:
--

Commit 7ed3c997af55d818354f5b5c38453b7d76ec4aa7 in cordova-windows's branch 
refs/heads/master from [~daserge]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=7ed3c99 ]

CB-12071 Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows

The real issue in CB-11825 was in a wrong plugin configuration - 
resource-file.target (Content.Link) should use backslashes (reverted from 
commit 1417b932c836c0fe21cca902e5098fa12e98fe82)


> Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
> ---
>
> Key: CB-12071
> URL: https://issues.apache.org/jira/browse/CB-12071
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugins, Windows
>Affects Versions: 4.4.3
> Environment: Windows Phone 8.1, Windows 8.1, Windows 10 UWP
>Reporter: Luc Humair
>Priority: Critical
>
> I have a plugin which needs an InProcessServerExtension in the project's 
> package.windows.appxmanifest like:
> {code:xml}
> 
> 
> 
> Foo.dll
>  ThreadingModel="both" />
> 
> 
> 
> {code}
> The corresponding DLL is configured in the plugin.xml file using:
> {code:xml}
>  src="src/windows/win81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  src="src/windows/wpa81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  versions="=10"/>
> {code}
> This configuration worked until release 4.4.2. Foo.dll was included in the 
> projects with property "Package Action"="Content" which includes the DLL in 
> the package manifest.
> Release 4.4.3 introduced a patch related to issue CB-11825 that changes  the 
> DLL's "Package Action" to "None". Now the file is no longer included in the 
> package manifest and the build fails for all the platforms with the following 
> error message:
> package.windows.appxmanifest : error APPX0703: Manifest references file 
> 'Foo.dll' which is not part of the payload.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12071) Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622207#comment-15622207
 ] 

ASF GitHub Bot commented on CB-12071:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/206


> Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
> ---
>
> Key: CB-12071
> URL: https://issues.apache.org/jira/browse/CB-12071
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugins, Windows
>Affects Versions: 4.4.3
> Environment: Windows Phone 8.1, Windows 8.1, Windows 10 UWP
>Reporter: Luc Humair
>Priority: Critical
>
> I have a plugin which needs an InProcessServerExtension in the project's 
> package.windows.appxmanifest like:
> {code:xml}
> 
> 
> 
> Foo.dll
>  ThreadingModel="both" />
> 
> 
> 
> {code}
> The corresponding DLL is configured in the plugin.xml file using:
> {code:xml}
>  src="src/windows/win81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  src="src/windows/wpa81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  versions="=10"/>
> {code}
> This configuration worked until release 4.4.2. Foo.dll was included in the 
> projects with property "Package Action"="Content" which includes the DLL in 
> the package manifest.
> Release 4.4.3 introduced a patch related to issue CB-11825 that changes  the 
> DLL's "Package Action" to "None". Now the file is no longer included in the 
> package manifest and the build fails for all the platforms with the following 
> error message:
> package.windows.appxmanifest : error APPX0703: Manifest references file 
> 'Foo.dll' which is not part of the payload.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12071) Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows

[Luc Humair (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621625#comment-15621625
 ] 

Luc Humair commented on CB-12071:
-

Thank you for clarifying this issue [~daserge]!
Do you revert the corresponding fix, or should I do something?
It would be a great help if we could use master again.

> Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
> ---
>
> Key: CB-12071
> URL: https://issues.apache.org/jira/browse/CB-12071
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugins, Windows
>Affects Versions: 4.4.3
> Environment: Windows Phone 8.1, Windows 8.1, Windows 10 UWP
>Reporter: Luc Humair
>Priority: Critical
>
> I have a plugin which needs an InProcessServerExtension in the project's 
> package.windows.appxmanifest like:
> {code:xml}
> 
> 
> 
> Foo.dll
>  ThreadingModel="both" />
> 
> 
> 
> {code}
> The corresponding DLL is configured in the plugin.xml file using:
> {code:xml}
>  src="src/windows/win81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  src="src/windows/wpa81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  versions="=10"/>
> {code}
> This configuration worked until release 4.4.2. Foo.dll was included in the 
> projects with property "Package Action"="Content" which includes the DLL in 
> the package manifest.
> Release 4.4.3 introduced a patch related to issue CB-11825 that changes  the 
> DLL's "Package Action" to "None". Now the file is no longer included in the 
> package manifest and the build fails for all the platforms with the following 
> error message:
> package.windows.appxmanifest : error APPX0703: Manifest references file 
> 'Foo.dll' which is not part of the payload.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12071) Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows

[Sergey Shakhnazarov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615519#comment-15615519
 ] 

Sergey Shakhnazarov commented on CB-12071:
--

Thank you [~lhm]!
You are right, the fix for CB-11825 was invalid - the real issue reason were 
the incorrect slashes:
{code}

->

{code}

> Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
> ---
>
> Key: CB-12071
> URL: https://issues.apache.org/jira/browse/CB-12071
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugins, Windows
>Affects Versions: 4.4.3
> Environment: Windows Phone 8.1, Windows 8.1, Windows 10 UWP
>Reporter: Luc Humair
>Priority: Critical
>
> I have a plugin which needs an InProcessServerExtension in the project's 
> package.windows.appxmanifest like:
> {code:xml}
> 
> 
> 
> Foo.dll
>  ThreadingModel="both" />
> 
> 
> 
> {code}
> The corresponding DLL is configured in the plugin.xml file using:
> {code:xml}
>  src="src/windows/win81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  src="src/windows/wpa81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  versions="=10"/>
> {code}
> This configuration worked until release 4.4.2. Foo.dll was included in the 
> projects with property "Package Action"="Content" which includes the DLL in 
> the package manifest.
> Release 4.4.3 introduced a patch related to issue CB-11825 that changes  the 
> DLL's "Package Action" to "None". Now the file is no longer included in the 
> package manifest and the build fails for all the platforms with the following 
> error message:
> package.windows.appxmanifest : error APPX0703: Manifest references file 
> 'Foo.dll' which is not part of the payload.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12071) Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows

[Luc Humair (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614816#comment-15614816
 ] 

Luc Humair commented on CB-12071:
-

Our scenario requires us to use 
[MediaCapture.AddEffectAsync|https://msdn.microsoft.com/en-us/library/windows/apps/br211961.aspx]
 which needs an activatable runtime class. This 
[ActivatableClass|https://msdn.microsoft.com/en-us/library/windows/apps/dn934736.aspx]
 is declared using an InProcessServer.
The deployment with version 4.4.2 and manually setting PackageAction=None does 
not work either (the build fails with the same error).

Currently, we tell our customers to use version 4.4.2 as a workaround. With 
version 4.4.3 I can also only see the workaround of manually switching the 
PackageAction.

Btw: I played around with the sample provided with issue CB-11825. Suprisingly 
the deployment succeeds if I move the DLL to the project's root folder (while 
still having the PackageAction=Content property). Specifically I changed part 
of the file CordovaApp.projitems from:
{code:xml}


plugins/com.plugin.test.myPlugin/SayHelloLib.dll
Always


{code}

to

{code:xml}


SayHelloLib.dll
Always


{code}

This matches the configuration we also use in our project. As the deployment 
succeeds this way, I am wondering whether the patch for CB-11825 actually fixed 
a problem or rather a symptom of some other problem.

> Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
> ---
>
> Key: CB-12071
> URL: https://issues.apache.org/jira/browse/CB-12071
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugins, Windows
>Affects Versions: 4.4.3
> Environment: Windows Phone 8.1, Windows 8.1, Windows 10 UWP
>Reporter: Luc Humair
>Priority: Critical
>
> I have a plugin which needs an InProcessServerExtension in the project's 
> package.windows.appxmanifest like:
> {code:xml}
> 
> 
> 
> Foo.dll
>  ThreadingModel="both" />
> 
> 
> 
> {code}
> The corresponding DLL is configured in the plugin.xml file using:
> {code:xml}
>  src="src/windows/win81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  src="src/windows/wpa81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  versions="=10"/>
> {code}
> This configuration worked until release 4.4.2. Foo.dll was included in the 
> projects with property "Package Action"="Content" which includes the DLL in 
> the package manifest.
> Release 4.4.3 introduced a patch related to issue CB-11825 that changes  the 
> DLL's "Package Action" to "None". Now the file is no longer included in the 
> package manifest and the build fails for all the platforms with the following 
> error message:
> package.windows.appxmanifest : error APPX0703: Manifest references file 
> 'Foo.dll' which is not part of the payload.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12071) Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows

[Sergey Shakhnazarov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612020#comment-15612020
 ] 

Sergey Shakhnazarov commented on CB-12071:
--

[~lhm], thanks for reporting the issue!
Could you please describe your scenario - what is InProcessServer used for?
I can't find any resources/articles on this topic.
Also - was the deploy working for you for 8.1 Phone/10 Mobile previously with 
PackageAction=None?

As a workaround for now I can see opening a dll Properties in Visual Studio and 
switching back to Content Package Action.

> Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
> ---
>
> Key: CB-12071
> URL: https://issues.apache.org/jira/browse/CB-12071
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugins, Windows
>Affects Versions: 4.4.3
> Environment: Windows Phone 8.1, Windows 8.1, Windows 10 UWP
>Reporter: Luc Humair
>Priority: Critical
>
> I have a plugin which needs an InProcessServerExtension in the project's 
> package.windows.appxmanifest like:
> {code:xml}
> 
> 
> 
> Foo.dll
>  ThreadingModel="both" />
> 
> 
> 
> {code}
> The corresponding DLL is configured in the plugin.xml file using:
> {code:xml}
>  src="src/windows/win81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  src="src/windows/wpa81/$(Platform)/Foo.dll" target="Foo.dll" versions="8.1"/>
>  versions="=10"/>
> {code}
> This configuration worked until release 4.4.2. Foo.dll was included in the 
> projects with property "Package Action"="Content" which includes the DLL in 
> the package manifest.
> Release 4.4.3 introduced a patch related to issue CB-11825 that changes  the 
> DLL's "Package Action" to "None". Now the file is no longer included in the 
> package manifest and the build fails for all the platforms with the following 
> error message:
> package.windows.appxmanifest : error APPX0703: Manifest references file 
> 'Foo.dll' which is not part of the payload.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org