[jira] [Commented] (CB-12813) Cordova Paramedic is not supporting full target name with OS version
[ https://issues.apache.org/jira/browse/CB-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633454#comment-16633454 ] ASF GitHub Bot commented on CB-12813: - janpio commented on issue #21: CB-12813 ios Fix target chooser to use full target name URL: https://github.com/apache/cordova-paramedic/pull/21#issuecomment-425738635 Fixed a merge conflict. Change itself looks good and solves the problem of the JIRA issue, but I am not sure if this could have negative effects on how we currently use paramedic. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova Paramedic is not supporting full target name with OS version > > > Key: CB-12813 > URL: https://issues.apache.org/jira/browse/CB-12813 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-paramedic >Affects Versions: Master >Reporter: Tomasz Subik >Priority: Major > > Cordova paramedic is not supporting full target name with OS version. When > providing --target "'iPhone-6, 9.3'" it is simply running first iPhone-6 > emulator not the exact one I want. > Logs: > cordova-paramedic: Choosing Target for iOS > running: > cordova run --list --emulator --no-telemetry --no-update-notifier | grep > 'iPhone-6, 9.3' | tail -n1 > running: > instruments -s devices | grep ^iPhone > cordova-paramedic: Setting required permissions. > cordova-paramedic: running command cordova run ios --no-telemetry > --no-update-notifier --target iPhone-6 --emulator -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12813) Cordova Paramedic is not supporting full target name with OS version
[ https://issues.apache.org/jira/browse/CB-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255434#comment-16255434 ] ASF GitHub Bot commented on CB-12813: - janpio commented on a change in pull request #21: CB-12813 ios Fix target chooser to use full target name URL: https://github.com/apache/cordova-paramedic/pull/21#discussion_r151432524 ## File path: lib/ParamedicTargetChooser.js ## @@ -128,12 +128,10 @@ ParamedicTargetChooser.prototype.chooseTargetForWindows = function (emulator, ta ParamedicTargetChooser.prototype.chooseTargetForIOS = function (emulator, target) { logger.info('cordova-paramedic: Choosing Target for iOS'); -var simulatorModelId = util.getSimulatorModelId(this.cli, target); -var split= simulatorModelId.split(', '); -var device = split[0].trim(); -var simId= util.getSimulatorId(simulatorModelId); +var deviceOSVersion = util.getSimulatorModelId(this.cli, target); Review comment: variable name is strange. because this is the device, os and version in a string? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova Paramedic is not supporting full target name with OS version > > > Key: CB-12813 > URL: https://issues.apache.org/jira/browse/CB-12813 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-paramedic >Affects Versions: Master >Reporter: Tomasz Subik > > Cordova paramedic is not supporting full target name with OS version. When > providing --target "'iPhone-6, 9.3'" it is simply running first iPhone-6 > emulator not the exact one I want. > Logs: > cordova-paramedic: Choosing Target for iOS > running: > cordova run --list --emulator --no-telemetry --no-update-notifier | grep > 'iPhone-6, 9.3' | tail -n1 > running: > instruments -s devices | grep ^iPhone > cordova-paramedic: Setting required permissions. > cordova-paramedic: running command cordova run ios --no-telemetry > --no-update-notifier --target iPhone-6 --emulator -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12813) Cordova Paramedic is not supporting full target name with OS version
[ https://issues.apache.org/jira/browse/CB-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255432#comment-16255432 ] ASF GitHub Bot commented on CB-12813: - janpio commented on a change in pull request #21: CB-12813 ios Fix target chooser to use full target name URL: https://github.com/apache/cordova-paramedic/pull/21#discussion_r151432524 ## File path: lib/ParamedicTargetChooser.js ## @@ -128,12 +128,10 @@ ParamedicTargetChooser.prototype.chooseTargetForWindows = function (emulator, ta ParamedicTargetChooser.prototype.chooseTargetForIOS = function (emulator, target) { logger.info('cordova-paramedic: Choosing Target for iOS'); -var simulatorModelId = util.getSimulatorModelId(this.cli, target); -var split= simulatorModelId.split(', '); -var device = split[0].trim(); -var simId= util.getSimulatorId(simulatorModelId); +var deviceOSVersion = util.getSimulatorModelId(this.cli, target); Review comment: variable name is strange. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cordova Paramedic is not supporting full target name with OS version > > > Key: CB-12813 > URL: https://issues.apache.org/jira/browse/CB-12813 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-paramedic >Affects Versions: Master >Reporter: Tomasz Subik > > Cordova paramedic is not supporting full target name with OS version. When > providing --target "'iPhone-6, 9.3'" it is simply running first iPhone-6 > emulator not the exact one I want. > Logs: > cordova-paramedic: Choosing Target for iOS > running: > cordova run --list --emulator --no-telemetry --no-update-notifier | grep > 'iPhone-6, 9.3' | tail -n1 > running: > instruments -s devices | grep ^iPhone > cordova-paramedic: Setting required permissions. > cordova-paramedic: running command cordova run ios --no-telemetry > --no-update-notifier --target iPhone-6 --emulator -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12813) Cordova Paramedic is not supporting full target name with OS version
[ https://issues.apache.org/jira/browse/CB-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009672#comment-16009672 ] Tomasz Subik commented on CB-12813: --- Link to PR: https://github.com/apache/cordova-paramedic/pull/21 > Cordova Paramedic is not supporting full target name with OS version > > > Key: CB-12813 > URL: https://issues.apache.org/jira/browse/CB-12813 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-paramedic >Affects Versions: Master >Reporter: Tomasz Subik > > Cordova paramedic is not supporting full target name with OS version. When > providing --target "'iPhone-6, 9.3'" it is simply running first iPhone-6 > emulator not the exact one I want. > Logs: > cordova-paramedic: Choosing Target for iOS > running: > cordova run --list --emulator --no-telemetry --no-update-notifier | grep > 'iPhone-6, 9.3' | tail -n1 > running: > instruments -s devices | grep ^iPhone > cordova-paramedic: Setting required permissions. > cordova-paramedic: running command cordova run ios --no-telemetry > --no-update-notifier --target iPhone-6 --emulator -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12813) Cordova Paramedic is not supporting full target name with OS version
[ https://issues.apache.org/jira/browse/CB-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009666#comment-16009666 ] Tomasz Subik commented on CB-12813: --- I'm working on fix for this one. > Cordova Paramedic is not supporting full target name with OS version > > > Key: CB-12813 > URL: https://issues.apache.org/jira/browse/CB-12813 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-paramedic >Affects Versions: Master >Reporter: Tomasz Subik > > Cordova paramedic is not supporting full target name with OS version. When > providing --target "'iPhone-6, 9.3'" it is simply running first iPhone-6 > emulator not the exact one I want. > Logs: > cordova-paramedic: Choosing Target for iOS > running: > cordova run --list --emulator --no-telemetry --no-update-notifier | grep > 'iPhone-6, 9.3' | tail -n1 > running: > instruments -s devices | grep ^iPhone > cordova-paramedic: Setting required permissions. > cordova-paramedic: running command cordova run ios --no-telemetry > --no-update-notifier --target iPhone-6 --emulator -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org