[jira] [Commented] (CB-13394) iPhone X StatusBar rendering in landscape

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212460#comment-16212460
 ] 

ASF GitHub Bot commented on CB-13394:
-

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/89
  
@dpa99c thanks for testing, I've merged it


> iPhone X StatusBar rendering in landscape
> -
>
> Key: CB-13394
> URL: https://issues.apache.org/jira/browse/CB-13394
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Affects Versions: cordova-ios 4.5.0
> Environment: iPhone X, iOS11 landscape mode
>Reporter: Dan Field
>Assignee: jcesarmobile
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When rotating the iPhone X into landscape mode, a thick bar with no status 
> indicators is rendered that covers content in the web view.  Default 
> applications on the phone hide the status bar when in landscape; this seems 
> to be the preferable solution, as the landscape statusbar shows no 
> information to the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13394) iPhone X StatusBar rendering in landscape

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212458#comment-16212458
 ] 

ASF GitHub Bot commented on CB-13394:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-statusbar/pull/88


> iPhone X StatusBar rendering in landscape
> -
>
> Key: CB-13394
> URL: https://issues.apache.org/jira/browse/CB-13394
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Affects Versions: cordova-ios 4.5.0
> Environment: iPhone X, iOS11 landscape mode
>Reporter: Dan Field
>Assignee: jcesarmobile
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When rotating the iPhone X into landscape mode, a thick bar with no status 
> indicators is rendered that covers content in the web view.  Default 
> applications on the phone hide the status bar when in landscape; this seems 
> to be the preferable solution, as the landscape statusbar shows no 
> information to the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13394) iPhone X StatusBar rendering in landscape

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212456#comment-16212456
 ] 

ASF subversion and git services commented on CB-13394:
--

Commit cdc9295b30b013425f4906670e16b50461aeca8d in cordova-plugin-statusbar's 
branch refs/heads/master from [~jcesarmobile]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=cdc9295
 ]

CB-13394 (iOS): fix iPhone X StatusBar rendering in landscape

 This closes #89 and closes #88


> iPhone X StatusBar rendering in landscape
> -
>
> Key: CB-13394
> URL: https://issues.apache.org/jira/browse/CB-13394
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Affects Versions: cordova-ios 4.5.0
> Environment: iPhone X, iOS11 landscape mode
>Reporter: Dan Field
>Assignee: jcesarmobile
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When rotating the iPhone X into landscape mode, a thick bar with no status 
> indicators is rendered that covers content in the web view.  Default 
> applications on the phone hide the status bar when in landscape; this seems 
> to be the preferable solution, as the landscape statusbar shows no 
> information to the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13394) iPhone X StatusBar rendering in landscape

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212457#comment-16212457
 ] 

ASF GitHub Bot commented on CB-13394:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-statusbar/pull/89


> iPhone X StatusBar rendering in landscape
> -
>
> Key: CB-13394
> URL: https://issues.apache.org/jira/browse/CB-13394
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Affects Versions: cordova-ios 4.5.0
> Environment: iPhone X, iOS11 landscape mode
>Reporter: Dan Field
>Assignee: jcesarmobile
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When rotating the iPhone X into landscape mode, a thick bar with no status 
> indicators is rendered that covers content in the web view.  Default 
> applications on the phone hide the status bar when in landscape; this seems 
> to be the preferable solution, as the landscape statusbar shows no 
> information to the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13394) iPhone X StatusBar rendering in landscape

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212362#comment-16212362
 ] 

ASF GitHub Bot commented on CB-13394:
-

GitHub user jcesarmobile reopened a pull request:

https://github.com/apache/cordova-plugin-statusbar/pull/89

CB-13394: (iOS) fix iPhone X StatusBar rendering in landscape



### Platforms affected
iOS

### What does this PR do?
iPhone X don't show the status bar in landscape, this PR handles that and 
also resizes the webview accordingly 
The downside is it brings CB-10158 back, we need to find another way of 
fishing it, but at least it has a workaround.

### What testing has been done on this change?
Tested on iPhone 8 and iPhone X simulators

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jcesarmobile/cordova-plugin-statusbar CB-13394

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-statusbar/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #89


commit 26a5a8e1adaffdba6aa506115a71e9d45d74a6eb
Author: Julio César 
Date:   2017-10-12T22:42:50Z

CB-13394 (iOS): fix iPhone X StatusBar rendering in landscape




> iPhone X StatusBar rendering in landscape
> -
>
> Key: CB-13394
> URL: https://issues.apache.org/jira/browse/CB-13394
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Affects Versions: cordova-ios 4.5.0
> Environment: iPhone X, iOS11 landscape mode
>Reporter: Dan Field
>Assignee: jcesarmobile
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When rotating the iPhone X into landscape mode, a thick bar with no status 
> indicators is rendered that covers content in the web view.  Default 
> applications on the phone hide the status bar when in landscape; this seems 
> to be the preferable solution, as the landscape statusbar shows no 
> information to the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13394) iPhone X StatusBar rendering in landscape

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212361#comment-16212361
 ] 

ASF GitHub Bot commented on CB-13394:
-

Github user jcesarmobile closed the pull request at:

https://github.com/apache/cordova-plugin-statusbar/pull/89


> iPhone X StatusBar rendering in landscape
> -
>
> Key: CB-13394
> URL: https://issues.apache.org/jira/browse/CB-13394
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Affects Versions: cordova-ios 4.5.0
> Environment: iPhone X, iOS11 landscape mode
>Reporter: Dan Field
>Assignee: jcesarmobile
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When rotating the iPhone X into landscape mode, a thick bar with no status 
> indicators is rendered that covers content in the web view.  Default 
> applications on the phone hide the status bar when in landscape; this seems 
> to be the preferable solution, as the landscape statusbar shows no 
> information to the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13394) iPhone X StatusBar rendering in landscape

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210621#comment-16210621
 ] 

ASF GitHub Bot commented on CB-13394:
-

Github user dpa99c commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/89
  
@jcesarmobile I've tested your PR changes both with iPhone X Simulator and 
non-iPhone X and it looks good.

Although it may bring back CB-10158, that's rather an edge case and, as you 
say, can be worked around.

We should get this PR merged and released ASAP. 


> iPhone X StatusBar rendering in landscape
> -
>
> Key: CB-13394
> URL: https://issues.apache.org/jira/browse/CB-13394
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Affects Versions: cordova-ios 4.5.0
> Environment: iPhone X, iOS11 landscape mode
>Reporter: Dan Field
>Assignee: jcesarmobile
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When rotating the iPhone X into landscape mode, a thick bar with no status 
> indicators is rendered that covers content in the web view.  Default 
> applications on the phone hide the status bar when in landscape; this seems 
> to be the preferable solution, as the landscape statusbar shows no 
> information to the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13394) iPhone X StatusBar rendering in landscape

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202803#comment-16202803
 ] 

ASF GitHub Bot commented on CB-13394:
-

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/88
  
Thanks for the PR and sorry for not spotting it before.

Instead of creating a new variable `_hideCalledFromExternal`you could have 
used  `_statusBarVisible` as it has the same value.

I don't think hiding the statusbar on iPhone X when in landscape is the 
right approach here as it looks like a bug to me, it should respect the value 
on `prefersStatusBarHidden`, iPhone X is the only one ignoring that value, so I 
think that might change in a future version. My approach uses current status 
bar size for the bar, as right now iPhone X doesn't have the status bar in 
landscape, has height 0 and the fake view it's not shown neither, but if that 
changes in the future and iPhone X starts respecting `prefersStatusBarHidden` 
value my approach will continue working, while yours will always hide the 
status bar.

Also your approach doesn't work fine when running in iPhones different from 
iPhone X and you call show when the in-call/hot-spot status bar is present and 
after that you rotate, the background view will remain with 40pt when rotated 
to landscape instead of resizing to 20pt (current size as  in-call/hot-spot 
status bar is 20pt in landscape).

So, for now I'll keep my approach, but I'm still waiting for review from 
other users. So, please, can you give it a try?


> iPhone X StatusBar rendering in landscape
> -
>
> Key: CB-13394
> URL: https://issues.apache.org/jira/browse/CB-13394
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Affects Versions: cordova-ios 4.5.0
> Environment: iPhone X, iOS11 landscape mode
>Reporter: Dan Field
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When rotating the iPhone X into landscape mode, a thick bar with no status 
> indicators is rendered that covers content in the web view.  Default 
> applications on the phone hide the status bar when in landscape; this seems 
> to be the preferable solution, as the landscape statusbar shows no 
> information to the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13394) iPhone X StatusBar rendering in landscape

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202776#comment-16202776
 ] 

ASF GitHub Bot commented on CB-13394:
-

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/89
  
@dnfield sorry, didn't see your PR, I don't know why it wasn't linked to 
the JIRA issue when you sent it.
Will look into it and decide which one to keep


> iPhone X StatusBar rendering in landscape
> -
>
> Key: CB-13394
> URL: https://issues.apache.org/jira/browse/CB-13394
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Affects Versions: cordova-ios 4.5.0
> Environment: iPhone X, iOS11 landscape mode
>Reporter: Dan Field
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When rotating the iPhone X into landscape mode, a thick bar with no status 
> indicators is rendered that covers content in the web view.  Default 
> applications on the phone hide the status bar when in landscape; this seems 
> to be the preferable solution, as the landscape statusbar shows no 
> information to the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13394) iPhone X StatusBar rendering in landscape

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202761#comment-16202761
 ] 

ASF GitHub Bot commented on CB-13394:
-

Github user dnfield commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/89
  
How does this compare to the pull I submitted?


> iPhone X StatusBar rendering in landscape
> -
>
> Key: CB-13394
> URL: https://issues.apache.org/jira/browse/CB-13394
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Affects Versions: cordova-ios 4.5.0
> Environment: iPhone X, iOS11 landscape mode
>Reporter: Dan Field
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When rotating the iPhone X into landscape mode, a thick bar with no status 
> indicators is rendered that covers content in the web view.  Default 
> applications on the phone hide the status bar when in landscape; this seems 
> to be the preferable solution, as the landscape statusbar shows no 
> information to the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13394) iPhone X StatusBar rendering in landscape

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202750#comment-16202750
 ] 

ASF GitHub Bot commented on CB-13394:
-

GitHub user jcesarmobile opened a pull request:

https://github.com/apache/cordova-plugin-statusbar/pull/89

CB-13394: (iOS) fix iPhone X StatusBar rendering in landscape



### Platforms affected
iOS

### What does this PR do?
iPhone X don't show the status bar in landscape, this PR handles that and 
also resizes the webview accordingly 
The downside is it brings CB-10158 back, we need to find another way of 
fishing it, but at least it has a workaround.

### What testing has been done on this change?
Tested on iPhone 8 and iPhone X simulators

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jcesarmobile/cordova-plugin-statusbar CB-13394

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-statusbar/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #89


commit 26a5a8e1adaffdba6aa506115a71e9d45d74a6eb
Author: Julio César 
Date:   2017-10-12T22:42:50Z

CB-13394 (iOS): fix iPhone X StatusBar rendering in landscape




> iPhone X StatusBar rendering in landscape
> -
>
> Key: CB-13394
> URL: https://issues.apache.org/jira/browse/CB-13394
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Affects Versions: cordova-ios 4.5.0
> Environment: iPhone X, iOS11 landscape mode
>Reporter: Dan Field
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When rotating the iPhone X into landscape mode, a thick bar with no status 
> indicators is rendered that covers content in the web view.  Default 
> applications on the phone hide the status bar when in landscape; this seems 
> to be the preferable solution, as the landscape statusbar shows no 
> information to the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org