[jira] [Commented] (CB-13460) Apply Android style to the splash screen.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640692#comment-16640692
 ] 

ASF GitHub Bot commented on CB-13460:
-

sanctus671 edited a comment on issue #137: CB-13460: Apply Android style to the 
splash screen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/137#issuecomment-427565053
 
 
   Thanks @pdyraga for this update! I've been testing it and found the fade out 
doesn't work correctly. The splashscreen fades out but it fades to a white 
background rather than the app. If I switch back to the original plugin, it 
fades to the app correctly. It's likely something related to this change, do 
you know what it could be?
   
   **edit: found a way around it:**
   
   
   @color/transaprentColor
   @color/transaprentColor  
 
   @color/primaryColorDark   
 
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Apply Android style to the splash screen.
> -
>
> Key: CB-13460
> URL: https://issues.apache.org/jira/browse/CB-13460
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Reporter: Piotr Dyraga
>Priority: Major
>
> This improvement aims at making the splash screen dialog use the 
> `SplashScreenStyle`, if defined. If not, it plugin should fall back to the 
> default style (backward compatibility).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13460) Apply Android style to the splash screen.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640682#comment-16640682
 ] 

ASF GitHub Bot commented on CB-13460:
-

sanctus671 commented on issue #137: CB-13460: Apply Android style to the splash 
screen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/137#issuecomment-427565053
 
 
   Thanks @pdyraga for this update! I've been testing it and found the fade out 
doesn't work correctly. The splashscreen fades out but it fades to a white 
background rather than the app. If I switch back to the original plugin, it 
fades to the app correctly. It's likely something related to this change, do 
you know what it could be?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Apply Android style to the splash screen.
> -
>
> Key: CB-13460
> URL: https://issues.apache.org/jira/browse/CB-13460
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Reporter: Piotr Dyraga
>Priority: Major
>
> This improvement aims at making the splash screen dialog use the 
> `SplashScreenStyle`, if defined. If not, it plugin should fall back to the 
> default style (backward compatibility).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13460) Apply Android style to the splash screen.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635059#comment-16635059
 ] 

ASF GitHub Bot commented on CB-13460:
-

pdyraga commented on issue #137: CB-13460: Apply Android style to the splash 
screen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/137#issuecomment-426158222
 
 
   @janpio Done, sorry for the delay. All tests are passing now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Apply Android style to the splash screen.
> -
>
> Key: CB-13460
> URL: https://issues.apache.org/jira/browse/CB-13460
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Reporter: Piotr Dyraga
>Priority: Major
>
> This improvement aims at making the splash screen dialog use the 
> `SplashScreenStyle`, if defined. If not, it plugin should fall back to the 
> default style (backward compatibility).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13460) Apply Android style to the splash screen.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635060#comment-16635060
 ] 

ASF GitHub Bot commented on CB-13460:
-

pdyraga edited a comment on issue #137: CB-13460: Apply Android style to the 
splash screen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/137#issuecomment-426158222
 
 
   @janpio Done, sorry for the delay. All tests are passing now. :tada:


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Apply Android style to the splash screen.
> -
>
> Key: CB-13460
> URL: https://issues.apache.org/jira/browse/CB-13460
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Reporter: Piotr Dyraga
>Priority: Major
>
> This improvement aims at making the splash screen dialog use the 
> `SplashScreenStyle`, if defined. If not, it plugin should fall back to the 
> default style (backward compatibility).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13460) Apply Android style to the splash screen.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634027#comment-16634027
 ] 

ASF GitHub Bot commented on CB-13460:
-

janpio commented on issue #137: CB-13460: Apply Android style to the splash 
screen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/137#issuecomment-425911395
 
 
   Hey, I just fixed the problem that caused Android tests to fail. Rebasing on 
master should get rid of those and possibly remove all test failures for this 
PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Apply Android style to the splash screen.
> -
>
> Key: CB-13460
> URL: https://issues.apache.org/jira/browse/CB-13460
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Reporter: Piotr Dyraga
>Priority: Major
>
> This improvement aims at making the splash screen dialog use the 
> `SplashScreenStyle`, if defined. If not, it plugin should fall back to the 
> default style (backward compatibility).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13460) Apply Android style to the splash screen.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616832#comment-16616832
 ] 

ASF GitHub Bot commented on CB-13460:
-

janpio commented on issue #137: CB-13460: Apply Android style to the splash 
screen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/137#issuecomment-421806230
 
 
   Hey @pdyraga, could you please rebase your PR on master? Shouldn't be much 
effort, and may possibly fix the test issues. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Apply Android style to the splash screen.
> -
>
> Key: CB-13460
> URL: https://issues.apache.org/jira/browse/CB-13460
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Reporter: Piotr Dyraga
>Priority: Major
>
> This improvement aims at making the splash screen dialog use the 
> `SplashScreenStyle`, if defined. If not, it plugin should fall back to the 
> default style (backward compatibility).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13460) Apply Android style to the splash screen.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209520#comment-16209520
 ] 

ASF GitHub Bot commented on CB-13460:
-

Github user pdyraga commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/137
  
Some tests failed but it looks like some test environment issue rather than 
a problem with the code here.


> Apply Android style to the splash screen.
> -
>
> Key: CB-13460
> URL: https://issues.apache.org/jira/browse/CB-13460
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Reporter: Piotr Dyraga
>
> This improvement aims at making the splash screen dialog use the 
> `SplashScreenStyle`, if defined. If not, it plugin should fall back to the 
> default style (backward compatibility).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13460) Apply Android style to the splash screen.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208926#comment-16208926
 ] 

ASF GitHub Bot commented on CB-13460:
-

GitHub user pdyraga opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/137

CB-13460: Apply Android style to the splash screen

This change makes the splash screen dialog use the `SplashScreenStyle`, if 
defined.
If not, it falls back to the default style.

Using Android style is a way more robust than adding configurable 
status/navigation color properties.

Examples:
In the `config.xml`:
```

```

In the `my-android-theme.xml`:
```



true
true


```


![image](https://user-images.githubusercontent.com/4712360/31705508-f67debcc-b3e5-11e7-980c-78cf34c0ca76.png)
```



@android:color/holo_green_light
@android:color/holo_green_light


```


![image](https://user-images.githubusercontent.com/4712360/31705544-1b3f50fe-b3e6-11e7-9440-2cf7cd003fdb.png)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdyraga/cordova-plugin-splashscreen master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #137


commit 143b63eda15f11a3de1a198dc63f84e09ed2e4e8
Author: Piotr Dyraga 
Date:   2017-10-18T06:40:33Z

Apply an Android Style to the splash screen

Cordova 6.4.0 adds `edit-config` support to `config.xml`. This lets to 
easily define custom Android styles.
This change makes the splash screen dialog use the `SplashScreenStyle`, if 
defined.
If not, it falls back to the default style.




> Apply Android style to the splash screen.
> -
>
> Key: CB-13460
> URL: https://issues.apache.org/jira/browse/CB-13460
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Reporter: Piotr Dyraga
>
> This improvement aims at making the splash screen dialog use the 
> `SplashScreenStyle`, if defined. If not, it plugin should fall back to the 
> default style (backward compatibility).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org