[jira] [Commented] (CB-13800) Drop pre-KitKat specific code
[ https://issues.apache.org/jira/browse/CB-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404425#comment-16404425 ] Shashwat Tripathi commented on CB-13800: Does this mean that value of android-minSdkVersion should be 19 instead of 16 from cordova-android 7.1.0? I am getting an error since I updated to cordova-android to 7.1.0. On changing minSdk to 19 it works. Manifest merger failed : uses-sdk:minSdkVersion 16 cannot be smaller than version 19 declared in library [:CordovaLib] /Users/shashwat/projects/bnforecast-ui/dist-phonegap-android/platforms/android/CordovaLib/build/intermediates/manifests/full/debug/AndroidManifest.xml as the library might be using APIs not available in 16 Suggestion: use a compatible library with a minSdk of at most 16, or increase this project's minSdk version to at least 19, or use tools:overrideLibrary="org.apache.cordova" to force usage (may lead to runtime failures) > Drop pre-KitKat specific code > - > > Key: CB-13800 > URL: https://issues.apache.org/jira/browse/CB-13800 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Affects Versions: 7.0.0 >Reporter: Bas Bosman >Assignee: Bas Bosman >Priority: Minor > > With the release of cordova-android 7.0.0 the minimum API-Level was set to 19. > > There are a couple of places in the codebase where we have specific logic for > older API-levels, which are now no longer needed and therefore can be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13800) Drop pre-KitKat specific code
[ https://issues.apache.org/jira/browse/CB-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332771#comment-16332771 ] ASF subversion and git services commented on CB-13800: -- Commit cc08e9d84a3f7cf76a623006c6a7e48814d74cec in cordova-android's branch refs/heads/master from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=cc08e9d ] Merge pull request #429 from BBosman/cb13800 CB-13800: Drop pre-KitKat specific code > Drop pre-KitKat specific code > - > > Key: CB-13800 > URL: https://issues.apache.org/jira/browse/CB-13800 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Affects Versions: 7.0.0 >Reporter: Bas Bosman >Assignee: Bas Bosman >Priority: Minor > > With the release of cordova-android 7.0.0 the minimum API-Level was set to 19. > > There are a couple of places in the codebase where we have specific logic for > older API-levels, which are now no longer needed and therefore can be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13800) Drop pre-KitKat specific code
[ https://issues.apache.org/jira/browse/CB-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332768#comment-16332768 ] ASF GitHub Bot commented on CB-13800: - infil00p commented on issue #429: CB-13800: Drop pre-KitKat specific code URL: https://github.com/apache/cordova-android/pull/429#issuecomment-359060673 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Drop pre-KitKat specific code > - > > Key: CB-13800 > URL: https://issues.apache.org/jira/browse/CB-13800 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Affects Versions: 7.0.0 >Reporter: Bas Bosman >Assignee: Bas Bosman >Priority: Minor > > With the release of cordova-android 7.0.0 the minimum API-Level was set to 19. > > There are a couple of places in the codebase where we have specific logic for > older API-levels, which are now no longer needed and therefore can be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13800) Drop pre-KitKat specific code
[
https://issues.apache.org/jira/browse/CB-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332769#comment-16332769
]
ASF GitHub Bot commented on CB-13800:
-
infil00p closed pull request #429: CB-13800: Drop pre-KitKat specific code
URL: https://github.com/apache/cordova-android/pull/429
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/framework/src/org/apache/cordova/CordovaActivity.java
b/framework/src/org/apache/cordova/CordovaActivity.java
index e2ed1cb82..dbbb48f69 100755
--- a/framework/src/org/apache/cordova/CordovaActivity.java
+++ b/framework/src/org/apache/cordova/CordovaActivity.java
@@ -123,7 +123,7 @@ public void onCreate(Bundle savedInstanceState) {
if (preferences.getBoolean("Fullscreen", false)) {
// NOTE: use the FullscreenNotImmersive configuration key to set
the activity in a REAL full screen
// (as was the case in previous cordova versions)
-if ((Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) &&
!preferences.getBoolean("FullscreenNotImmersive", false)) {
+if (!preferences.getBoolean("FullscreenNotImmersive", false)) {
immersiveMode = true;
} else {
getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
diff --git a/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
b/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
index 3ea5e5765..a27fc6af4 100755
--- a/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
+++ b/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java
@@ -149,21 +149,6 @@ public void onExceededDatabaseQuota(String url, String
databaseIdentifier, long
quotaUpdater.updateQuota(MAX_QUOTA);
}
-// console.log in api level 7:
http://developer.android.com/guide/developing/debug-tasks.html
-// Expect this to not compile in a future Android release!
-@SuppressWarnings("deprecation")
-@Override
-public void onConsoleMessage(String message, int lineNumber, String
sourceID)
-{
-//This is only for Android 2.1
-if(android.os.Build.VERSION.SDK_INT ==
android.os.Build.VERSION_CODES.ECLAIR_MR1)
-{
-LOG.d(LOG_TAG, "%s: Line %d : %s", sourceID, lineNumber, message);
-super.onConsoleMessage(message, lineNumber, sourceID);
-}
-}
-
-@TargetApi(8)
@Override
public boolean onConsoleMessage(ConsoleMessage consoleMessage)
{
diff --git a/framework/src/org/apache/cordova/engine/SystemWebViewClient.java
b/framework/src/org/apache/cordova/engine/SystemWebViewClient.java
index d17650240..0b6a577ea 100755
--- a/framework/src/org/apache/cordova/engine/SystemWebViewClient.java
+++ b/framework/src/org/apache/cordova/engine/SystemWebViewClient.java
@@ -112,7 +112,7 @@ public void onReceivedHttpAuthRequest(WebView view,
HttpAuthHandler handler, Str
* @param request
*/
@Override
-@TargetApi(21)
+@TargetApi(Build.VERSION_CODES.LOLLIPOP)
public void onReceivedClientCertRequest (WebView view, ClientCertRequest
request)
{
@@ -219,7 +219,6 @@ public void onReceivedError(WebView view, int errorCode,
String description, Str
* @param handler An SslErrorHandler object that will handle the
user's response.
* @param error The SSL error object.
*/
-@TargetApi(8)
@Override
public void onReceivedSslError(WebView view, SslErrorHandler handler,
SslError error) {
@@ -316,7 +315,6 @@ public void clearAuthenticationTokens() {
this.authenticationTokens.clear();
}
-@TargetApi(Build.VERSION_CODES.HONEYCOMB)
@Override
public WebResourceResponse shouldInterceptRequest(WebView view, String
url) {
try {
@@ -349,7 +347,7 @@ public WebResourceResponse shouldInterceptRequest(WebView
view, String url) {
}
private static boolean needsKitKatContentUrlFix(Uri uri) {
-return android.os.Build.VERSION.SDK_INT >=
android.os.Build.VERSION_CODES.KITKAT && "content".equals(uri.getScheme());
+return "content".equals(uri.getScheme());
}
private static boolean needsSpecialsInAssetUrlFix(Uri uri) {
@@ -364,11 +362,6 @@ private static boolean needsSpecialsInAssetUrlFix(Uri uri)
{
return false;
}
-switch(android.os.Build.VERSION.SDK_INT){
-case android.os.Build.VERSION_CODES.ICE_CREAM_SANDWICH:
-case android.os.Build.VERSION_CODES.ICE_CREAM_SANDWICH_MR1:
-return true;
-}
return false;
}
}
diff --git a/framework/src/org/apache/cordova/engine/SystemWebViewEngine.java
[jira] [Commented] (CB-13800) Drop pre-KitKat specific code
[ https://issues.apache.org/jira/browse/CB-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332770#comment-16332770 ] ASF subversion and git services commented on CB-13800: -- Commit 075d38117ae19ee8832f3f16eb9340a1786674b6 in cordova-android's branch refs/heads/master from [~BBosman] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=075d381 ] CB-13800: (android) Drop pre-KitKat specific code > Drop pre-KitKat specific code > - > > Key: CB-13800 > URL: https://issues.apache.org/jira/browse/CB-13800 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Affects Versions: 7.0.0 >Reporter: Bas Bosman >Assignee: Bas Bosman >Priority: Minor > > With the release of cordova-android 7.0.0 the minimum API-Level was set to 19. > > There are a couple of places in the codebase where we have specific logic for > older API-levels, which are now no longer needed and therefore can be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13800) Drop pre-KitKat specific code
[ https://issues.apache.org/jira/browse/CB-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332234#comment-16332234 ] ASF GitHub Bot commented on CB-13800: - codecov-io commented on issue #429: CB-13800: Drop pre-KitKat specific code URL: https://github.com/apache/cordova-android/pull/429#issuecomment-358963013 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/429?src=pr=h1) Report > Merging [#429](https://codecov.io/gh/apache/cordova-android/pull/429?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/6cc4896690e73503a2281d7b63640f6d4ed5ffaa?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-android/pull/429?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #429 +/- ## === Coverage 43.95% 43.95% === Files 17 17 Lines1711 1711 Branches 318 318 === Hits 752 752 Misses959 959 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/429?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/429?src=pr=footer). Last update [6cc4896...075d381](https://codecov.io/gh/apache/cordova-android/pull/429?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Drop pre-KitKat specific code > - > > Key: CB-13800 > URL: https://issues.apache.org/jira/browse/CB-13800 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Affects Versions: 7.0.0 >Reporter: Bas Bosman >Assignee: Bas Bosman >Priority: Minor > > With the release of cordova-android 7.0.0 the minimum API-Level was set to 19. > > There are a couple of places in the codebase where we have specific logic for > older API-levels, which are now no longer needed and therefore can be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13800) Drop pre-KitKat specific code
[ https://issues.apache.org/jira/browse/CB-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332220#comment-16332220 ] ASF GitHub Bot commented on CB-13800: - BBosman opened a new pull request #429: CB-13800: Drop pre-KitKat specific code URL: https://github.com/apache/cordova-android/pull/429 ### Platforms affected Android ### What does this PR do? With the release of cordova-android 7.0.0 the minimum API-Level was set to 19. There are a couple of places in the codebase where we have specific logic for older API-levels which are now no longer needed and can therefore be removed. This PR removes them. It results in (negligible) faster execution and smaller binary sizes, but most importantly less code to maintain. ### What testing has been done on this change? Ran: * npm test * gradlew test * gradlew connectedAndroidTest ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Drop pre-KitKat specific code > - > > Key: CB-13800 > URL: https://issues.apache.org/jira/browse/CB-13800 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Affects Versions: 7.0.0 >Reporter: Bas Bosman >Assignee: Bas Bosman >Priority: Minor > > With the release of cordova-android 7.0.0 the minimum API-Level was set to 19. > > There are a couple of places in the codebase where we have specific logic for > older API-levels, which are now no longer needed and therefore can be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
