[jira] [Commented] (CB-13877) MSBuildTools selection is a mess
[ https://issues.apache.org/jira/browse/CB-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365711#comment-16365711 ] ASF GitHub Bot commented on CB-13877: - janpio closed pull request #259: CB-13877 Clean up MSBuildTools.js URL: https://github.com/apache/cordova-windows/pull/259 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > MSBuildTools selection is a mess > > > Key: CB-13877 > URL: https://issues.apache.org/jira/browse/CB-13877 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > Now with VS2017 out, the code for the detection of the correct MSBuildTools > installation is a total mess and works just by accident. > Things to do: > - -Give more output that can help understand what is going on- Done via PR 255 > - Give more ways to understand selection > - -Integrate new restrictions like no Win8.1 support with VS2017-only > installations- Acceptable limitation for a dead platform I think > - Simplify selection code that is currently spread over 2 files: > `MSBuildTools.js` and `build.js` -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13877) MSBuildTools selection is a mess
[ https://issues.apache.org/jira/browse/CB-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365712#comment-16365712 ] ASF subversion and git services commented on CB-13877: -- Commit aed7484098b15827e4947762402345e2df3f7299 in cordova-windows's branch refs/heads/master from Jan Piotrowski [ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=aed7484 ] CB-13877 Clean up MSBuildTools.js (#259) * comments in MSBuildTools.js * move method * temporary logging * clearer comment * move method * move filterSupportedTargets from build.js to MSBuildTools.js * restructure getLatestMSBuild to get the list of available MSBuilds itself restructure usage of MSBuildTools in build.js to that new reality (get builtTargets earlier, get msBuild instead of list, use both to filter buildTargets earlier) * now also remove filterSupportedTargets from build.js * move method * fix eslint * Visual Studio 15.5 is a thing the script should know about * better logging for checkMSBuildVersion future method preparation * fix eslint * disable some unit tests * move filterSupportedTargets into getLatestMatchingMSBuild * move method * switch Error to CordovaError * fix comments * re-enable tests (but 3) * fix eslint * TODO comment for future functionality * document ugly hack for VS17 MSBuild selection * undo VS17 stuff > MSBuildTools selection is a mess > > > Key: CB-13877 > URL: https://issues.apache.org/jira/browse/CB-13877 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > Now with VS2017 out, the code for the detection of the correct MSBuildTools > installation is a total mess and works just by accident. > Things to do: > - -Give more output that can help understand what is going on- Done via PR 255 > - Give more ways to understand selection > - -Integrate new restrictions like no Win8.1 support with VS2017-only > installations- Acceptable limitation for a dead platform I think > - Simplify selection code that is currently spread over 2 files: > `MSBuildTools.js` and `build.js` -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13877) MSBuildTools selection is a mess
[ https://issues.apache.org/jira/browse/CB-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365689#comment-16365689 ] ASF GitHub Bot commented on CB-13877: - janpio opened a new pull request #260: [WIP] CB-13877 Visual Studio 2017 support URL: https://github.com/apache/cordova-windows/pull/260 ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > MSBuildTools selection is a mess > > > Key: CB-13877 > URL: https://issues.apache.org/jira/browse/CB-13877 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > Now with VS2017 out, the code for the detection of the correct MSBuildTools > installation is a total mess and works just by accident. > Things to do: > - -Give more output that can help understand what is going on- Done via PR 255 > - Give more ways to influence the selection > - -Integrate new restrictions like no Win8.1 support with VS2017-only > installations- Acceptable limitation for a dead platform I think > - Simplify selection code that is currently spread over 2 files: > `MSBuildTools.js` and `build.js` -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13877) MSBuildTools selection is a mess
[ https://issues.apache.org/jira/browse/CB-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365676#comment-16365676 ] ASF GitHub Bot commented on CB-13877: - janpio opened a new pull request #259: [WIP] CB-13877 Clean up MSBuildTools.js URL: https://github.com/apache/cordova-windows/pull/259 ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > MSBuildTools selection is a mess > > > Key: CB-13877 > URL: https://issues.apache.org/jira/browse/CB-13877 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > Now with VS2017 out, the code for the detection of the correct MSBuildTools > installation is a total mess and works just by accident. > Things to do: > - -Give more output that can help understand what is going on- Done via PR 255 > - Give more ways to influence the selection > - -Integrate new restrictions like no Win8.1 support with VS2017-only > installations- Acceptable limitation for a dead platform I think > - Simplify selection code that is currently spread over 2 files: > `MSBuildTools.js` and `build.js` -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13877) MSBuildTools selection is a mess
[ https://issues.apache.org/jira/browse/CB-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365633#comment-16365633 ] ASF GitHub Bot commented on CB-13877: - janpio closed pull request #257: CB-13877 more env information about msbuild and visual studio on appveyor URL: https://github.com/apache/cordova-windows/pull/257 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > MSBuildTools selection is a mess > > > Key: CB-13877 > URL: https://issues.apache.org/jira/browse/CB-13877 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > Now with VS2017 out, the code for the detection of the correct MSBuildTools > installation is a total mess and works just by accident. > Things to do: > - -Give more output that can help understand what is going on- Done via PR 255 > - Give more ways to influence the selection > - -Integrate new restrictions like no Win8.1 support with VS2017-only > installations- Acceptable limitation for a dead platform I think -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13877) MSBuildTools selection is a mess
[ https://issues.apache.org/jira/browse/CB-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365632#comment-16365632 ] ASF GitHub Bot commented on CB-13877: - janpio opened a new pull request #257: CB-13877 more env information about msbuild and visual studio on appveyor URL: https://github.com/apache/cordova-windows/pull/257 ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > MSBuildTools selection is a mess > > > Key: CB-13877 > URL: https://issues.apache.org/jira/browse/CB-13877 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > Now with VS2017 out, the code for the detection of the correct MSBuildTools > installation is a total mess and works just by accident. > Things to do: > - -Give more output that can help understand what is going on- Done via PR 255 > - Give more ways to influence the selection > - -Integrate new restrictions like no Win8.1 support with VS2017-only > installations- Acceptable limitation for a dead platform I think -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13877) MSBuildTools selection is a mess
[ https://issues.apache.org/jira/browse/CB-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364289#comment-16364289 ] ASF GitHub Bot commented on CB-13877: - janpio closed pull request #255: CB-13877 First MSBuildTools.js work: Debug output, move misplaced method, comments URL: https://github.com/apache/cordova-windows/pull/255 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > MSBuildTools selection is a mess > > > Key: CB-13877 > URL: https://issues.apache.org/jira/browse/CB-13877 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > Now with VS2017 out, the code for the detection of the correct MSBuildTools > installation is a total mess and works just by accident. > Things to do: > - Give more output that can help understand what is going on > - Give more ways to influence the selection > - Integrate new restrictions like no WIn8.1 support with VS2017-only > installations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13877) MSBuildTools selection is a mess
[ https://issues.apache.org/jira/browse/CB-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364290#comment-16364290 ] ASF subversion and git services commented on CB-13877: -- Commit 2817f7c084e8d6330f4cb316735a53136a108fed in cordova-windows's branch refs/heads/master from Jan Piotrowski [ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=2817f7c ] CB-13877 First MSBuildTools.js work: Debug output, move misplaced method, comments (#255) * notes on method usage * move getLatestMSBuild over to MSBuildTools * output path to used MSBuildTools in during build > MSBuildTools selection is a mess > > > Key: CB-13877 > URL: https://issues.apache.org/jira/browse/CB-13877 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > Now with VS2017 out, the code for the detection of the correct MSBuildTools > installation is a total mess and works just by accident. > Things to do: > - Give more output that can help understand what is going on > - Give more ways to influence the selection > - Integrate new restrictions like no WIn8.1 support with VS2017-only > installations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13877) MSBuildTools selection is a mess
[ https://issues.apache.org/jira/browse/CB-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364206#comment-16364206 ] ASF GitHub Bot commented on CB-13877: - janpio opened a new pull request #255: CB-13877 First MSBuildTools.js work: Debug output, move misplaced method, comments URL: https://github.com/apache/cordova-windows/pull/255 This PR takes first steps to improbe the MSBuildTools selection: - Output the path of the use MSBuildTools during build - move misplaced method from build.js - Add some comments to make clearer where methods are used This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > MSBuildTools selection is a mess > > > Key: CB-13877 > URL: https://issues.apache.org/jira/browse/CB-13877 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Major > > Now with VS2017 out, the code for the detection of the correct MSBuildTools > installation is a total mess and works just by accident. > Things to do: > - Give more output that can help understand what is going on > - Give more ways to influence the selection > - Integrate new restrictions like no WIn8.1 support with VS2017-only > installations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
