[jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
[
https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637208#comment-16637208
]
ASF GitHub Bot commented on CB-14024:
-
janpio edited a comment on issue #265: CB-14024 Take into account statusbar
height when toolbar is enabled
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/265#issuecomment-425913163
Hey, I just fixed the problem that caused Android tests to fail in `master`.
~~Could you rebase this PR please? This should get rid of the Android failures
and possibly fix all test failures for this PR.~~
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Doesn't have into account statusbar height when toolbar is enabled
> --
>
> Key: CB-14024
> URL: https://issues.apache.org/jira/browse/CB-14024
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Humberto Alfonso Díaz
>Priority: Major
> Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage
> to not show properly on the header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
[
https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637128#comment-16637128
]
ASF GitHub Bot commented on CB-14024:
-
janpio closed pull request #265: CB-14024 Take into account statusbar height
when toolbar is enabled
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/265
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/ios/CDVInAppBrowser.m b/src/ios/CDVInAppBrowser.m
index a581472dd..e79b08922 100644
--- a/src/ios/CDVInAppBrowser.m
+++ b/src/ios/CDVInAppBrowser.m
@@ -885,8 +885,8 @@ - (float) getStatusBarOffset {
}
- (void) rePositionViews {
-if ([_browserOptions.toolbarposition
isEqualToString:kInAppBrowserToolbarBarPositionTop]) {
-[self.webView setFrame:CGRectMake(self.webView.frame.origin.x,
TOOLBAR_HEIGHT, self.webView.frame.size.width, self.webView.frame.size.height)];
+if ((_browserOptions.toolbar) && ([_browserOptions.toolbarposition
isEqualToString:kInAppBrowserToolbarBarPositionTop])) {
+[self.webView setFrame:CGRectMake(self.webView.frame.origin.x,
TOOLBAR_HEIGHT + [self getStatusBarOffset], self.webView.frame.size.width,
self.webView.frame.size.height)];
[self.toolbar setFrame:CGRectMake(self.toolbar.frame.origin.x, [self
getStatusBarOffset], self.toolbar.frame.size.width,
self.toolbar.frame.size.height)];
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Doesn't have into account statusbar height when toolbar is enabled
> --
>
> Key: CB-14024
> URL: https://issues.apache.org/jira/browse/CB-14024
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Humberto Alfonso Díaz
>Priority: Major
> Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage
> to not show properly on the header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
[
https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637127#comment-16637127
]
ASF GitHub Bot commented on CB-14024:
-
janpio commented on issue #265: CB-14024 Take into account statusbar height
when toolbar is enabled
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/265#issuecomment-426697967
Closing to retrigger CI.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Doesn't have into account statusbar height when toolbar is enabled
> --
>
> Key: CB-14024
> URL: https://issues.apache.org/jira/browse/CB-14024
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Humberto Alfonso Díaz
>Priority: Major
> Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage
> to not show properly on the header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
[
https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637130#comment-16637130
]
ASF GitHub Bot commented on CB-14024:
-
humbertuning opened a new pull request #265: CB-14024 Take into account
statusbar height when toolbar is enabled
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/265
### Platforms affected
ios
### What does this PR do?
Solves the problem with the webs that are not shown properly when toolbar is
enabled on top:
`this.browser.create(element.url,
'_blank',"toolbar=yes,toolbarposition=top");`
### What testing has been done on this change?
It was tested on ios devices using the above configuration
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Doesn't have into account statusbar height when toolbar is enabled
> --
>
> Key: CB-14024
> URL: https://issues.apache.org/jira/browse/CB-14024
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Humberto Alfonso Díaz
>Priority: Major
> Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage
> to not show properly on the header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
[
https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634050#comment-16634050
]
ASF GitHub Bot commented on CB-14024:
-
janpio commented on issue #265: CB-14024 Take into account statusbar height
when toolbar is enabled
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/265#issuecomment-425913163
Hey, I just fixed the problem that caused Android tests to fail in `master`.
Could you rebase this PR please? This should get rid of the Android failures
and possibly fix all test failures for this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Doesn't have into account statusbar height when toolbar is enabled
> --
>
> Key: CB-14024
> URL: https://issues.apache.org/jira/browse/CB-14024
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Humberto Alfonso Díaz
>Priority: Major
> Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage
> to not show properly on the header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
[
https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607118#comment-16607118
]
ASF GitHub Bot commented on CB-14024:
-
de-dan commented on issue #265: CB-14024 Take into account statusbar height
when toolbar is enabled
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/265#issuecomment-419437919
I tested this PR with @hvaughan3's changes. Works beautifully. The Travis CI
build fails on Android platform?? This can be ignored in my opinion as there
are no changes for android.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Doesn't have into account statusbar height when toolbar is enabled
> --
>
> Key: CB-14024
> URL: https://issues.apache.org/jira/browse/CB-14024
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Humberto Alfonso Díaz
>Priority: Major
> Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage
> to not show properly on the header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
[
https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568622#comment-16568622
]
ASF GitHub Bot commented on CB-14024:
-
hvaughan3 edited a comment on issue #265: CB-14024 Take into account statusbar
height when toolbar is enabled
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/265#issuecomment-410300531
Forked and pulled in this PR. It does indeed push the content below the
status bar but it also cuts off the content at the bottom by the same amount.
You should also subtract the webview height by the status bar height to prevent
it. Something like:
[self.webView setFrame:CGRectMake(self.webView.frame.origin.x,
TOOLBAR_HEIGHT + [self getStatusBarOffset], self.webView.frame.size.width,
self.webView.frame.size.height - [self getStatusBarOffset])];
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Doesn't have into account statusbar height when toolbar is enabled
> --
>
> Key: CB-14024
> URL: https://issues.apache.org/jira/browse/CB-14024
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Humberto Alfonso Díaz
>Priority: Major
> Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage
> to not show properly on the header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
[
https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568413#comment-16568413
]
ASF GitHub Bot commented on CB-14024:
-
hvaughan3 commented on issue #265: CB-14024 Take into account statusbar height
when toolbar is enabled
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/265#issuecomment-410300531
When can this be merged?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Doesn't have into account statusbar height when toolbar is enabled
> --
>
> Key: CB-14024
> URL: https://issues.apache.org/jira/browse/CB-14024
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Humberto Alfonso Díaz
>Priority: Major
> Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage
> to not show properly on the header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
[
https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503712#comment-16503712
]
ASF GitHub Bot commented on CB-14024:
-
svanzoest commented on issue #265: CB-14024 Take into account statusbar height
when toolbar is enabled
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/265#issuecomment-395167350
The travis failure is a timeout, which seems like it wouldn't be related to
this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Doesn't have into account statusbar height when toolbar is enabled
> --
>
> Key: CB-14024
> URL: https://issues.apache.org/jira/browse/CB-14024
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Humberto Alfonso Díaz
>Priority: Major
> Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage
> to not show properly on the header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
[
https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440548#comment-16440548
]
ASF GitHub Bot commented on CB-14024:
-
sin-tanaka commented on issue #265: CB-14024 Take into account statusbar height
when toolbar is enabled
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/265#issuecomment-381884450
This PR worked on my device(ver. iOS 11.3)
Im glad to be merged this PR as soon as possible, because we are using this
plugin :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Doesn't have into account statusbar height when toolbar is enabled
> --
>
> Key: CB-14024
> URL: https://issues.apache.org/jira/browse/CB-14024
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Humberto Alfonso Díaz
>Priority: Major
> Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage
> to not show properly on the header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
[
https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430561#comment-16430561
]
ASF GitHub Bot commented on CB-14024:
-
humbertuning opened a new pull request #265: CB-14024 Take into account
statusbar height when toolbar is enabled
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/265
### Platforms affected
ios
### What does this PR do?
Solves the problem with the webs that are not shown properly when toolbar is
enabled on top:
`this.browser.create(element.url,
'_blank',"toolbar=yes,toolbarposition=top");`
### What testing has been done on this change?
It was tested on ios devices using the above configuration
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Doesn't have into account statusbar height when toolbar is enabled
> --
>
> Key: CB-14024
> URL: https://issues.apache.org/jira/browse/CB-14024
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Humberto Alfonso Díaz
>Priority: Major
> Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage
> to not show properly on the header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
