[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604818#comment-16604818
 ] 

ASF GitHub Bot commented on CB-14211:
-

oliversalzburg commented on issue #627: CB-14211: Run test suite in PowerShell 
and cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-418851258
 
 
   Alright, I rebased, just so we can have one more look at the output, but it 
seems like we can close this as it's mostly testing for issues in underlying 
components and those should be checked for correctness instead.
   
   Or, even better, just get rid of `superspawn` and use something that already 
works right. I'd love to do that, but `superspawn` provides console output 
through the non-standard progress callback of the Q promise `superspawn` 
returns. That behavior is relied upon in at least 2 platform APIs that I found.
   
   But I'd rather refactor all that than start writing new tests for 
`superspawn`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604387#comment-16604387
 ] 

ASF GitHub Bot commented on CB-14211:
-

janpio commented on issue #627: CB-14211: Run test suite in PowerShell and 
cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-418726131
 
 
   I fully agree, I spent the last few weeks making a ruby library 
crossplatform and had a lot of fun with the escaping and quoting of command 
line params as well. We should probably create an issue to collect some more 
information what exactly is going wrong etc.
   
   (Btw: I couldn't replicate the JIRA issue 
https://github.com/apache/cordova-lib/pull/622 is trying to solve on Windows)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604386#comment-16604386
 ] 

ASF GitHub Bot commented on CB-14211:
-

raphinesse edited a comment on issue #627: CB-14211: Run test suite in 
PowerShell and cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-418725174
 
 
   @janpio @oliversalzburg This all started with #622 which challenges the 
correctness of the escaping done in lib for some shells. Thus, we should start 
with unit tests for `superspawn` in `cordova-common` that test (or show the 
absence of) escaping. For example by calling `superspawn` to write some special 
characters to a file and check the result.
   
   After we have a better understanding of the problems at hand and we still 
feel it's necessary, we could select a few tests to form a smoke test suite for 
lib on PowerShell that we run on CI in addition to our regular tests. What do 
you think?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604385#comment-16604385
 ] 

ASF GitHub Bot commented on CB-14211:
-

raphinesse commented on issue #627: CB-14211: Run test suite in PowerShell and 
cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-418725174
 
 
   @janpio @oliversalzburg This all started with #622 which challenges the 
correctness of the escaping done in lib for some shells. Thus, we should start 
with unit tests for `superspawn` in `cordova-common` that test (or show the 
absence of) escaping. For example by calling `superspawn` to write some special 
characters to a file and check the result.
   
   After we have a better understanding of the problems at hand, we could 
select a few tests to form a smoke test suite for PowerShell that we run on CI 
in addition to our regular tests. What do you think?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604312#comment-16604312
 ] 

ASF GitHub Bot commented on CB-14211:
-

janpio commented on issue #627: CB-14211: Run test suite in PowerShell and 
cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-418701594
 
 
   So rebasing on `master` should fix the failing test @raphinesse? If so, 
could you please take care of that @oliversalzburg? Thanks.
   
   I agree with the test run time - we will have to find another solution here 
somehow :/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604309#comment-16604309
 ] 

ASF GitHub Bot commented on CB-14211:
-

raphinesse commented on issue #627: CB-14211: Run test suite in PowerShell and 
cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-418700952
 
 
   @janpio the deprecation warning would have been resolved since. For the 
rest: I still don't want to double test times on AppVeyor


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604247#comment-16604247
 ] 

ASF GitHub Bot commented on CB-14211:
-

janpio commented on issue #627: CB-14211: Run test suite in PowerShell and 
cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-418681397
 
 
   So, how should we continue here? 
   Was an issue created for the "Buffer deprecation warning" stuff?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547620#comment-16547620
 ] 

ASF GitHub Bot commented on CB-14211:
-

oliversalzburg commented on issue #627: CB-14211: Run test suite in PowerShell 
and cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405874702
 
 
   @raphinesse Yeah, well observed. I was looking at that output earlier and 
could not quite figure out what exactly the failure was.
   
   > PowerShell fails with NativeCommandError when a process writes to StdErr. 
Caused by this line: 
https://github.com/stevenvachon/nopter/blob/master/appveyor.yml#L37
   
   From: 
https://help.appveyor.com/discussions/problems/10014-false-build-fail-status
   
   Now that's a bit annoying. The `appveyor.yml` that he links to runs the 
tests in succession in both shells btw. Maybe that would be an option too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547605#comment-16547605
 ] 

ASF GitHub Bot commented on CB-14211:
-

janpio commented on issue #627: CB-14211: Run test suite in PowerShell and 
cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405870443
 
 
   So we have CI specific bugs as well? Yay!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547590#comment-16547590
 ] 

ASF GitHub Bot commented on CB-14211:
-

raphinesse edited a comment on issue #627: CB-14211: Run test suite in 
PowerShell and cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405865819
 
 
   @oliversalzburg 
   
   > So right after we decide that it's probably not worth running all NodeJS 
versions on both shells, we see failures with one specific version in one 
specific shell.
   
   It sure looks that way. I *think* that I saw the Buffer deprecation warning 
while working on some other Cordova stuff before this PR. But I couldn't say if 
it was the same code that failed. :man_shrugging: 
   
   **Edit**: Yeah, it also occurs with cmd: 
https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-lib/build/1.0.1366/job/b2ver32qyy1cqqm5#L80
   
   Maybe it prints to stderr and AppVeyor/Powershell sees that as an error and 
fails the build.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547588#comment-16547588
 ] 

ASF GitHub Bot commented on CB-14211:
-

raphinesse edited a comment on issue #627: CB-14211: Run test suite in 
PowerShell and cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405865819
 
 
   > So right after we decide that it's probably not worth running all NodeJS 
versions on both shells, we see failures with one specific version in one 
specific shell.
   
   It sure looks that way. I *think* that I saw the Buffer deprecation warning 
while working on some other Cordova stuff before this PR. But I couldn't say if 
it was the same code that failed. :man_shrugging: 
   
   **Edit**: Yeah, it also occurs with cmd: 
https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-lib/build/1.0.1366/job/b2ver32qyy1cqqm5#L80
   
   Maybe it prints to stderr and AppVeyor/Powershell sees that as an error and 
fails the build.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547584#comment-16547584
 ] 

ASF GitHub Bot commented on CB-14211:
-

raphinesse commented on issue #627: CB-14211: Run test suite in PowerShell and 
cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405865819
 
 
   > So right after we decide that it's probably not worth running all NodeJS 
versions on both shells, we see failures with one specific version in one 
specific shell.
   
   It sure looks that way. I *think* that I saw the Buffer deprecation warning 
while working on some other Cordova stuff before this PR. But I couldn't say if 
it was the same code that failed. :man_shrugging: 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547580#comment-16547580
 ] 

ASF GitHub Bot commented on CB-14211:
-

oliversalzburg commented on issue #627: CB-14211: Run test suite in PowerShell 
and cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405864248
 
 
   @brodybits Nice find.
   
   So right after we decide that it's probably not worth running all NodeJS 
versions on both shells, we see failures with one specific version in one 
specific shell.
   
   That somewhat contradicts the decision to scale down the test matrix, 
doesn't it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547180#comment-16547180
 ] 

ASF GitHub Bot commented on CB-14211:
-

brodybits commented on issue #627: CB-14211: Run test suite in PowerShell and 
cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405752360
 
 
   Interesting failure on Node 10 on PowerShell 
[[1]](https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-lib/build/1.0.1366/job/55c71ss4ex5g0are#L80)
 / 
[[2]](https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-lib/build/1.0.1366/job/55c71ss4ex5g0are#L199)
   
   Should probably be fixed. See also: 
[[3]](https://nodesource.com/blog/understanding-the-buffer-deprecation-in-node-js-10/),
 [[4]](https://medium.com/@jasnell/node-js-buffer-api-changes-3c21f1048f97)
   
   [1] 

   [2] 

   [3] 

   [4] 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546804#comment-16546804
 ] 

ASF GitHub Bot commented on CB-14211:
-

raphinesse commented on issue #627: CB-14211: Run test suite in PowerShell and 
cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405627916
 
 
   Yes, for a smaller impact, running only one version with both shells would 
be a start


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546801#comment-16546801
 ] 

ASF GitHub Bot commented on CB-14211:
-

oliversalzburg commented on issue #627: CB-14211: Run test suite in PowerShell 
and cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405627316
 
 
   I understand that sentiment completely. The idea just came up after trying 
to analyze issues relating to shell interaction, which this component does. 
Because this is prone to error, it should be included in an automatic testing 
approach IMHO.
   
   A test suite that takes 2h to complete is annoying. Having to run a test 
suite on your own workstation 20 times because you're trying to track down an 
issue introduced by shell interaction is even more so.
   
   It's probably overkill to run all 3 NodeJS versions on both shells though, 
now that I think about it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546785#comment-16546785
 ] 

ASF GitHub Bot commented on CB-14211:
-

raphinesse commented on issue #627: CB-14211: Run test suite in PowerShell and 
cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405623257
 
 
   While I think that it's a good idea to test in different shells, this 
doubles the amount of jobs, right? Currently, AppVeyor tests take *very* long 
already. Since the jobs are only executing sequentially and some of our tests 
are awfully slow, it takes about **one hour** for them to finish. So with these 
changes I'm expecting a runtime of about **two hours**. :disappointed: 
   
   IMO, we should only increase the number of jobs if it has no drastic impact 
on the overall build time.
   
   I'm currently working on cleaning up the biggest runtime-offenders, so that 
we hopefully can reduce our test duration drastically as a next step. However, 
I suspect these changes are still a few weeks from being ready to land. Right 
now the tests take about 480s on my machine with the two biggest offenders 
amounting to 305s. Say I can reduce the overall run time by 50% that would 
still leave us with a 10 minute run time per job on the CI. Which would still 
be 30 minutes without this change or 60 minutes with it. Which I would still be 
inclined to avoid.
   
   I guess what I'm trying to say is: I would very much prefer to find some way 
to test this with less impact on the CI run time. Like excessive unit tests for 
`superspawn` for example.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546753#comment-16546753
 ] 

ASF GitHub Bot commented on CB-14211:
-

janpio commented on a change in pull request #627: CB-14211: Run test suite in 
PowerShell and cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#discussion_r203058097
 
 

 ##
 File path: appveyor.yml
 ##
 @@ -7,6 +7,10 @@ environment:
   - nodejs_version: "8"
   - nodejs_version: "10"
 
+platform:
+  - cmd
 
 Review comment:
   Does doesn't really matter, my confusion came from assuming this was a 
"magic string" you could set to trigger some platform - but it seems this is 
just selecting which part of the script is being executed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546742#comment-16546742
 ] 

ASF GitHub Bot commented on CB-14211:
-

oliversalzburg commented on a change in pull request #627: CB-14211: Run test 
suite in PowerShell and cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#discussion_r203056496
 
 

 ##
 File path: appveyor.yml
 ##
 @@ -7,6 +7,10 @@ environment:
   - nodejs_version: "8"
   - nodejs_version: "10"
 
+platform:
+  - cmd
 
 Review comment:
   But, what about using `CommandPrompt` and `PowerShell`? Or do you prefer to 
have a verb in there?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546740#comment-16546740
 ] 

ASF GitHub Bot commented on CB-14211:
-

oliversalzburg commented on a change in pull request #627: CB-14211: Run test 
suite in PowerShell and cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#discussion_r203056067
 
 

 ##
 File path: appveyor.yml
 ##
 @@ -7,6 +7,10 @@ environment:
   - nodejs_version: "8"
   - nodejs_version: "10"
 
+platform:
+  - cmd
 
 Review comment:
   I think that can be whatever you want. If you prefer a prefix, I can add it, 
but I thought it's clear enough :D


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546732#comment-16546732
 ] 

ASF GitHub Bot commented on CB-14211:
-

janpio commented on a change in pull request #627: CB-14211: Run test suite in 
PowerShell and cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#discussion_r203053979
 
 

 ##
 File path: appveyor.yml
 ##
 @@ -7,6 +7,10 @@ environment:
   - nodejs_version: "8"
   - nodejs_version: "10"
 
+platform:
+  - cmd
 
 Review comment:
   Is this a name you chose or something that AppVeyor has named?
   If it's your choice: Maybe make it `use_cmd` to make this clearer.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546704#comment-16546704
 ] 

ASF GitHub Bot commented on CB-14211:
-

oliversalzburg opened a new pull request #627: CB-14211: Run test suite in 
PowerShell and cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627
 
 
   
   
   ### Platforms affected
   None
   
   ### What does this PR do?
   Runs the test suite in both PowerShell and Command Prompt. Previously only 
one was checked.
   
   ### What testing has been done on this change?
   I like to believe it tests itself :D
   
   ### Checklist
   - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [C] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [X] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> -
>
> Key: CB-14211
> URL: https://issues.apache.org/jira/browse/CB-14211
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-lib
>Reporter: Oliver Salzburg
>Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be 
> safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org