[jira] [Commented] (CB-14238) Statusbar transparency does not persist when hiding and showing the statusbar

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564912#comment-16564912
 ] 

ASF GitHub Bot commented on CB-14238:
-

janpio commented on issue #99: CB-14238: Make transparency of statusbar 
persistent when hiding and showing statusbar
URL: 
https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409483994
 
 
   I restarted the failed Travis jobs manually.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Statusbar transparency does not persist when hiding and showing the statusbar
> -
>
> Key: CB-14238
> URL: https://issues.apache.org/jira/browse/CB-14238
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
> Environment: Android
>Reporter: Adam Szmyd
>Priority: Minor
>  Labels: android, easyfix, transparency
>
> When you call methods in this order: {{overlaysWebView(true)}} , {{hide()}} , 
> {{show()}} the status bar gets shown without transparency and pushes webview 
> to bottom. And because at start statusbar gets transparent (overlaysWebView) 
> from this point the show/hide should toggle the statusbar visibility and it 
> should always show transparent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14238) Statusbar transparency does not persist when hiding and showing the statusbar

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564723#comment-16564723
 ] 

ASF GitHub Bot commented on CB-14238:
-

aszmyd commented on issue #99: CB-14238: Make transparency of statusbar 
persistent when hiding and showing statusbar
URL: 
https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409447930
 
 
   I do not know why travis build failed for safari browser.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Statusbar transparency does not persist when hiding and showing the statusbar
> -
>
> Key: CB-14238
> URL: https://issues.apache.org/jira/browse/CB-14238
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
> Environment: Android
>Reporter: Adam Szmyd
>Priority: Minor
>  Labels: android, easyfix, transparency
>
> When you call methods in this order: {{overlaysWebView(true)}} , {{hide()}} , 
> {{show()}} the status bar gets shown without transparency and pushes webview 
> to bottom. And because at start statusbar gets transparent (overlaysWebView) 
> from this point the show/hide should toggle the statusbar visibility and it 
> should always show transparent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14238) Statusbar transparency does not persist when hiding and showing the statusbar

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564710#comment-16564710
 ] 

ASF GitHub Bot commented on CB-14238:
-

brodybits commented on issue #99: CB-14238: Make transparency of statusbar 
persistent when hiding and showing statusbar
URL: 
https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409443946
 
 
   A couple minor points FYI:
   - First line should generally be within 50 characters. If you need more then 
you should add a blank line then keep remaining lines within 70 characters. 
This is very well documented, for example: 
. AFAICT we generally take care of 
this formatting issue if needed.
   - Unless there is good reason to keep multiple original commits we will very 
likely do a "squash merge", which means that the master branch would actually 
diverge from your proposed `android-persistent-transparency` branch.
   
   Thanks for the contribution, I am sure it will help others in the future.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Statusbar transparency does not persist when hiding and showing the statusbar
> -
>
> Key: CB-14238
> URL: https://issues.apache.org/jira/browse/CB-14238
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
> Environment: Android
>Reporter: Adam Szmyd
>Priority: Minor
>  Labels: android, easyfix, transparency
>
> When you call methods in this order: {{overlaysWebView(true)}} , {{hide()}} , 
> {{show()}} the status bar gets shown without transparency and pushes webview 
> to bottom. And because at start statusbar gets transparent (overlaysWebView) 
> from this point the show/hide should toggle the statusbar visibility and it 
> should always show transparent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14238) Statusbar transparency does not persist when hiding and showing the statusbar

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564704#comment-16564704
 ] 

ASF GitHub Bot commented on CB-14238:
-

aszmyd commented on issue #99: CB-14238: Make transparency of statusbar 
persistent when hiding and showing statusbar
URL: 
https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409442707
 
 
   @brodybits thanks. I've pushed clean one commit with name changed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Statusbar transparency does not persist when hiding and showing the statusbar
> -
>
> Key: CB-14238
> URL: https://issues.apache.org/jira/browse/CB-14238
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
> Environment: Android
>Reporter: Adam Szmyd
>Priority: Minor
>  Labels: android, easyfix, transparency
>
> When you call methods in this order: {{overlaysWebView(true)}} , {{hide()}} , 
> {{show()}} the status bar gets shown without transparency and pushes webview 
> to bottom. And because at start statusbar gets transparent (overlaysWebView) 
> from this point the show/hide should toggle the statusbar visibility and it 
> should always show transparent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14238) Statusbar transparency does not persist when hiding and showing the statusbar

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564700#comment-16564700
 ] 

ASF GitHub Bot commented on CB-14238:
-

brodybits commented on issue #99: CB-14238: Make transparency of statusbar 
persistent when hiding and showing statusbar
URL: 
https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409441677
 
 
   @aszmyd it should be fine to update by force push (we do this kind of thing 
all the time). Alternative solution which I think is not necessary is to simply 
open a new PR. Even fancier is to open a new PR with text like "resolves #99" 
or "closes #99" in the description 
().
   
   As an aside you may want to maintain your own special fork version until we 
get a chance to deal with this one. Maybe something like 
"cordova-plugin-statusbar-transparent" or "cordova-plugin-persistent-statusbar"?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Statusbar transparency does not persist when hiding and showing the statusbar
> -
>
> Key: CB-14238
> URL: https://issues.apache.org/jira/browse/CB-14238
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
> Environment: Android
>Reporter: Adam Szmyd
>Priority: Minor
>  Labels: android, easyfix, transparency
>
> When you call methods in this order: {{overlaysWebView(true)}} , {{hide()}} , 
> {{show()}} the status bar gets shown without transparency and pushes webview 
> to bottom. And because at start statusbar gets transparent (overlaysWebView) 
> from this point the show/hide should toggle the statusbar visibility and it 
> should always show transparent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14238) Statusbar transparency does not persist when hiding and showing the statusbar

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564690#comment-16564690
 ] 

ASF GitHub Bot commented on CB-14238:
-

aszmyd commented on issue #99: CB-14238: Make transparency of statusbar 
persistent when hiding and showing statusbar
URL: 
https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409440198
 
 
   @janpio I've created JIRA issue: 
https://issues.apache.org/jira/browse/CB-14238 and renamed PR name and 
description. Not sure if i should also rename commit name and force git push? 
It could confuse others that already pulled this branch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Statusbar transparency does not persist when hiding and showing the statusbar
> -
>
> Key: CB-14238
> URL: https://issues.apache.org/jira/browse/CB-14238
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
> Environment: Android
>Reporter: Adam Szmyd
>Priority: Minor
>  Labels: android, easyfix, transparency
>
> When you call methods in this order: {{overlaysWebView(true)}} , {{hide()}} , 
> {{show()}} the status bar gets shown without transparency and pushes webview 
> to bottom. And because at start statusbar gets transparent (overlaysWebView) 
> from this point the show/hide should toggle the statusbar visibility and it 
> should always show transparent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org