[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981125#comment-13981125 ] ASF GitHub Bot commented on CB-3209: Github user zalun closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/8 geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Steve Gill Fix For: 3.2.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817549#comment-13817549 ] Herm Wong commented on CB-3209: --- created a subtask to update the geolocation docs at https://issues.apache.org/jira/browse/CB-5326 geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816443#comment-13816443 ] James Long commented on CB-3209: Thanks! There are going to be several pieces of documentation to add like that with these various APIs. I like putting it there, but how can we track the doc changes that we need to give you guys? geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13816450#comment-13816450 ] Steve Gill commented on CB-3209: Lets add subtasks to CB-3204 for all of the APIs + related docs to keep track. We need to add code to plugman probably to handle permissions from plugin.xml and add them to config.xml + app manifest. Some android plugins require permission and they have code to handle this. We would just need to add one more step where we take the permission data and map it to app manifest. I haven't had time to explore this yet. Hoping one of you guys will have a chance. geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815218#comment-13815218 ] James Long commented on CB-3209: Ok, I think we can close this. Piotr fixed the last bug in the plugin and the final code is here: https://github.com/jlongster/cordova-plugin-geolocation I've run all the tests and they pass: http://jlongster.com/s/geolocation-tests.png The only problem is that the user can't rely on a correct manifest.webapp being generated. They need to make a manifest.webapp in the proejct's www folder and add the geolocation permission to it. How should we communicate documentation like this to you guys? geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815250#comment-13815250 ] Herm Wong commented on CB-3209: --- I'll merge in the latest changes to the apache repo. As for documentation of the permissions required in the manifest.webapp, I think the best place would be under Accessing the Feature section in the geolocation docs. http://cordova.apache.org/docs/en/edge/cordova_geolocation_geolocation.md.html#Geolocation geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812854#comment-13812854 ] Piotr Zalewa commented on CB-3209: -- We at least need to have some sort of a documentation given to the devs. Something along these lines When no permission added to the manifest.webapp geolocation prompt fails with an error. plus instructions how to do this. Unfortunately the ``cordova prepare`` command overwrites the manifest file so we need to work on CLI. Maybe some section in application's www/config.xml ? geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812910#comment-13812910 ] James Long commented on CB-3209: Yep, we need to go ahead and generate the permissions automatically. I don't know how hard it will be, but it might be easy. We need to check out how cordova specifies permissions and see if it's easy to map that. I'll look into it. geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813049#comment-13813049 ] Herm Wong commented on CB-3209: --- In the interim, I think we should probably document the permissions required in README and also in the Cordova docs for geolocation. geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813107#comment-13813107 ] James Long commented on CB-3209: I just did a proper implementation for geolocation on firefoxos: https://github.com/jlongster/cordova-plugin-geolocation You can see the code here: https://github.com/jlongster/cordova-plugin-geolocation/blob/master/src/firefoxos/GeolocationProxy.js The plugin.xml was missing several entries and it was completely broken before. It was never even using the plugin, so it was just using the native API. Unfortunately, I haven't been able to get it to actually work on the device yet because the native geolocation call never gives me back a position. The code should work, though. I haven't fixed the manifest.webapp permissions yet, I was just manually adding the permission. geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811737#comment-13811737 ] Herm Wong commented on CB-3209: --- I've merged in Piotr's changes into the dev branch of the geolocation plugin. geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810238#comment-13810238 ] Piotr Zalewa commented on CB-3209: -- Geolocation is working now https://github.com/apache/cordova-plugin-geolocation/pull/8 geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.2.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[
https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810663#comment-13810663
]
James Long commented on CB-3209:
Ok, looks like you have to add this to the manifest.webapp:
permissions: {
geolocation: {
description: Used to position the map to your current position
}
}
which sucks. We have to figure out how to generate the right manifest now,
instead of doing it later like we've talked about.
geolocation
---
Key: CB-3209
URL: https://issues.apache.org/jira/browse/CB-3209
Project: Apache Cordova
Issue Type: Sub-task
Components: FirefoxOS
Affects Versions: 2.6.0
Reporter: Herm Wong
Assignee: Herm Wong
Fix For: 3.2.0
geolocation spec: http://www.w3.org/TR/geolocation-API/
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (CB-3209) geolocation
[ https://issues.apache.org/jira/browse/CB-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13784327#comment-13784327 ] James Long commented on CB-3209: Does this actually work? https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-geolocation.git;a=blob;f=src/firefoxos/GeolocationProxy.js;h=0f05f0271a51707bf68050dbd9ff39a664565ccc;hb=8840c938ea7909e7e74dd3a8e7ef61a96629b7d9 All the code does is call `win(position)`, and skips the error handler. `position` isn't even defined. geolocation --- Key: CB-3209 URL: https://issues.apache.org/jira/browse/CB-3209 Project: Apache Cordova Issue Type: Sub-task Components: FirefoxOS Affects Versions: 2.6.0 Reporter: Herm Wong Assignee: Herm Wong Fix For: 3.1.0 geolocation spec: http://www.w3.org/TR/geolocation-API/ -- This message was sent by Atlassian JIRA (v6.1#6144)
