[jira] [Commented] (CB-4051) Splashscreen rotation problem
[ https://issues.apache.org/jira/browse/CB-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941279#comment-13941279 ] ASF GitHub Bot commented on CB-4051: Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/13#issuecomment-38126812 With regards to this issue and CB-4051 and @seanbollin 's patch there, I think the proper fix is the logical operator change. I will re-open CB-4051. Splashscreen rotation problem - Key: CB-4051 URL: https://issues.apache.org/jira/browse/CB-4051 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 2.7.0 Reporter: Estelle Assignee: Shazron Abdullah On Cordova 2.7 I have made an application iPhone with Cordova, my application is only on landscape mode. I have added splashscreens on the app and seen a bug. When I launch app, I see correctly the good splashscreen but after view seconds the splashscreen rotate on 90° I think it's a bug because all params in XML, Xcode and plist are in landscape mode. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4051) Splashscreen rotation problem
[ https://issues.apache.org/jira/browse/CB-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941281#comment-13941281 ] ASF subversion and git services commented on CB-4051: - Commit e3e39967660c5715da2838f434bba288776ae358 in cordova-plugin-splashscreen's branch refs/heads/dev from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=e3e3996 ] CB-4051 - Re-fix - Splashscreen rotation problem (closes #13) Splashscreen rotation problem - Key: CB-4051 URL: https://issues.apache.org/jira/browse/CB-4051 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 2.7.0 Reporter: Estelle Assignee: Shazron Abdullah On Cordova 2.7 I have made an application iPhone with Cordova, my application is only on landscape mode. I have added splashscreens on the app and seen a bug. When I launch app, I see correctly the good splashscreen but after view seconds the splashscreen rotate on 90° I think it's a bug because all params in XML, Xcode and plist are in landscape mode. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4051) Splashscreen rotation problem
[ https://issues.apache.org/jira/browse/CB-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13939811#comment-13939811 ] ASF GitHub Bot commented on CB-4051: Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/13#issuecomment-37989527 Hmm, your first commit reverts https://issues.apache.org/jira/browse/CB-4051 Would my last comment in the issue (where I replace the || operator with an operator) fix the issue as well? Splashscreen rotation problem - Key: CB-4051 URL: https://issues.apache.org/jira/browse/CB-4051 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 2.7.0 Reporter: Estelle Assignee: Shazron Abdullah On Cordova 2.7 I have made an application iPhone with Cordova, my application is only on landscape mode. I have added splashscreens on the app and seen a bug. When I launch app, I see correctly the good splashscreen but after view seconds the splashscreen rotate on 90° I think it's a bug because all params in XML, Xcode and plist are in landscape mode. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4051) Splashscreen rotation problem
[ https://issues.apache.org/jira/browse/CB-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898282#comment-13898282 ] Max Stemplinger commented on CB-4051: - I think this pull request adds a new bug. I have an iPhone only app with orientation lock for only portrait. My launch images have all the name Default~iphone.png, Default-568h@2x~iphone.png, Default@2x~iphone.png as it is suggested by apple and the cordova doc (iPhone Apps can only be started in Portrait, so no need for -landscape or -portrait). When the orientation is locked, this pull requests adds the line {code} } else if (CDV_IsIPad() || isOrientationLocked) { {code} which then appends the filename with -Portrait in my case. Now the plugin can't find the image, because the names are different. The -Portrait and -Landscape should only be appended when the device is an iPad. So i think this has to be reopened, or am i doing something wrong? Splashscreen rotation problem - Key: CB-4051 URL: https://issues.apache.org/jira/browse/CB-4051 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 2.7.0 Reporter: Estelle Assignee: Shazron Abdullah On Cordova 2.7 I have made an application iPhone with Cordova, my application is only on landscape mode. I have added splashscreens on the app and seen a bug. When I launch app, I see correctly the good splashscreen but after view seconds the splashscreen rotate on 90° I think it's a bug because all params in XML, Xcode and plist are in landscape mode. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-4051) Splashscreen rotation problem
[ https://issues.apache.org/jira/browse/CB-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898591#comment-13898591 ] Shazron Abdullah commented on CB-4051: -- You're right - the logical operator there should be an not || This code probably needs to be re-factored to be unit-testable to handle all cases. Splashscreen rotation problem - Key: CB-4051 URL: https://issues.apache.org/jira/browse/CB-4051 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 2.7.0 Reporter: Estelle Assignee: Shazron Abdullah On Cordova 2.7 I have made an application iPhone with Cordova, my application is only on landscape mode. I have added splashscreens on the app and seen a bug. When I launch app, I see correctly the good splashscreen but after view seconds the splashscreen rotate on 90° I think it's a bug because all params in XML, Xcode and plist are in landscape mode. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-4051) Splashscreen rotation problem
[ https://issues.apache.org/jira/browse/CB-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833571#comment-13833571 ] Sean Bollin commented on CB-4051: - Here's a pull request I believe fixes the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/10 Splashscreen rotation problem - Key: CB-4051 URL: https://issues.apache.org/jira/browse/CB-4051 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 2.7.0 Reporter: Estelle Assignee: Shazron Abdullah On Cordova 2.7 I have made an application iPhone with Cordova, my application is only on landscape mode. I have added splashscreens on the app and seen a bug. When I launch app, I see correctly the good splashscreen but after view seconds the splashscreen rotate on 90° I think it's a bug because all params in XML, Xcode and plist are in landscape mode. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4051) Splashscreen rotation problem
[ https://issues.apache.org/jira/browse/CB-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833468#comment-13833468 ] Sean Bollin commented on CB-4051: - The quick hack fix for this is to 1) Open up CDVSplashScreen.m 2) Comment out the beginning of the else if clause on line 135 3) Comment out the end of the else if clause on line 148 4) Make sure you have all the following images: Default-568h@2x~iphone.png (640x1136 pixels) Default-Landscape@2x~ipad.png (2048x1496 pixels) Default-Landscape~ipad.png (1024x748 pixels) Default-Portrait@2x~ipad.png (1536x2008 pixels) Default-Portrait~ipad.png (768x1004 pixels) Default@2x~iphone.png (640x960 pixels) Default~iphone.png (320x480 pixels) Splashscreen rotation problem - Key: CB-4051 URL: https://issues.apache.org/jira/browse/CB-4051 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 2.7.0 Reporter: Estelle Assignee: Shazron Abdullah On Cordova 2.7 I have made an application iPhone with Cordova, my application is only on landscape mode. I have added splashscreens on the app and seen a bug. When I launch app, I see correctly the good splashscreen but after view seconds the splashscreen rotate on 90° I think it's a bug because all params in XML, Xcode and plist are in landscape mode. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4051) Splashscreen rotation problem
[ https://issues.apache.org/jira/browse/CB-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13787978#comment-13787978 ] Mikael Koniakowski commented on CB-4051: Same issue. Portrait/Landscape App with bugs for Splash screen On Cordova 2.9 - Iphone App - Supports both Portrait and Landscape - Splash screens are in Portrait only (as normally supported by iPhone) - When launching App with Phone in landscape Splash screen shows correctly in portrait mode for about 0,5s. - After 0,5s the Splash image is rotated to landscape and distorted by rescale. Since Landscape Splash images are NOT supported on iPhone, the Splash screen should never be rotated. (Also, in this way, someone creating a Landscape app, could make the portrait splash image look landscape and everything would look correct for the user.) Splashscreen rotation problem - Key: CB-4051 URL: https://issues.apache.org/jira/browse/CB-4051 Project: Apache Cordova Issue Type: Bug Components: iOS Affects Versions: 2.7.0 Reporter: Estelle Assignee: Shazron Abdullah On Cordova 2.7 I have made an application iPhone with Cordova, my application is only on landscape mode. I have added splashscreens on the app and seen a bug. When I launch app, I see correctly the good splashscreen but after view seconds the splashscreen rotate on 90° I think it's a bug because all params in XML, Xcode and plist are in landscape mode. -- This message was sent by Atlassian JIRA (v6.1#6144)