[jira] [Commented] (CB-5438) Can't build/test cordova-js on Windows

2014-02-11 Thread qi (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898718#comment-13898718
 ] 

qi commented on CB-5438:


Now everything works, wow!

> Can't build/test cordova-js on Windows
> --
>
> Key: CB-5438
> URL: https://issues.apache.org/jira/browse/CB-5438
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaJS
>Affects Versions: Master
> Environment: Windows 8 x64
> Node v0.10.13
>Reporter: qi
>Assignee: Andrew Grieve
>Priority: Critical
> Fix For: 3.5.0
>
>
> Simply run 'grunt build', got,
> Running "jshint:src" (jshint) task
> Linting lib/test/androidexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../android/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../android/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../android/exec.js
> [L1:C4] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W015: Expected 'android' to have an indentation at 1 instead at 4.
> ../android/exec.js
> [L1:C19] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W117: 'android' is not defined.
> ../android/exec.js
> [L1:C12] W117: 'exec' is not defined.
> ../android/exec.js
> Linting lib/test/iosexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../ios/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../ios/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../ios/exec.js
> [L1:C4] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W015: Expected 'ios' to have an indentation at 1 instead at 4.
> ../ios/exec.js
> [L1:C15] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W117: 'ios' is not defined.
> ../ios/exec.js
> [L1:C8] W117: 'exec' is not defined.
> ../ios/exec.js
> Warning: Task "jshint:src" failed. Use --force to continue.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (CB-5438) Can't build/test cordova-js on Windows

2014-02-11 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898691#comment-13898691
 ] 

ASF subversion and git services commented on CB-5438:
-

Commit ddf13aa89aee6ab96e11736417b9a7b53a2c02be in branch refs/heads/master 
from [~agrieve]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=ddf13aa ]

CB-5438 Use jsdom-nogyp to avoid dependency on python & visual studio


> Can't build/test cordova-js on Windows
> --
>
> Key: CB-5438
> URL: https://issues.apache.org/jira/browse/CB-5438
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaJS
>Affects Versions: Master
> Environment: Windows 8 x64
> Node v0.10.13
>Reporter: qi
>Assignee: Andrew Grieve
>Priority: Critical
> Fix For: 3.5.0
>
>
> Simply run 'grunt build', got,
> Running "jshint:src" (jshint) task
> Linting lib/test/androidexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../android/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../android/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../android/exec.js
> [L1:C4] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W015: Expected 'android' to have an indentation at 1 instead at 4.
> ../android/exec.js
> [L1:C19] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W117: 'android' is not defined.
> ../android/exec.js
> [L1:C12] W117: 'exec' is not defined.
> ../android/exec.js
> Linting lib/test/iosexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../ios/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../ios/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../ios/exec.js
> [L1:C4] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W015: Expected 'ios' to have an indentation at 1 instead at 4.
> ../ios/exec.js
> [L1:C15] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W117: 'ios' is not defined.
> ../ios/exec.js
> [L1:C8] W117: 'exec' is not defined.
> ../ios/exec.js
> Warning: Task "jshint:src" failed. Use --force to continue.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (CB-5438) Can't build/test cordova-js on Windows

2014-02-11 Thread qi (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898614#comment-13898614
 ] 

qi commented on CB-5438:


[~agrieve], I replaced jsdom to jsdom-nogyp in my fork, you could try it and no 
VS required

> Can't build/test cordova-js on Windows
> --
>
> Key: CB-5438
> URL: https://issues.apache.org/jira/browse/CB-5438
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaJS
>Affects Versions: Master
> Environment: Windows 8 x64
> Node v0.10.13
>Reporter: qi
>Assignee: Andrew Grieve
>Priority: Critical
>
> Simply run 'grunt build', got,
> Running "jshint:src" (jshint) task
> Linting lib/test/androidexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../android/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../android/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../android/exec.js
> [L1:C4] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W015: Expected 'android' to have an indentation at 1 instead at 4.
> ../android/exec.js
> [L1:C19] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W117: 'android' is not defined.
> ../android/exec.js
> [L1:C12] W117: 'exec' is not defined.
> ../android/exec.js
> Linting lib/test/iosexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../ios/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../ios/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../ios/exec.js
> [L1:C4] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W015: Expected 'ios' to have an indentation at 1 instead at 4.
> ../ios/exec.js
> [L1:C15] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W117: 'ios' is not defined.
> ../ios/exec.js
> [L1:C8] W117: 'exec' is not defined.
> ../ios/exec.js
> Warning: Task "jshint:src" failed. Use --force to continue.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (CB-5438) Can't build/test cordova-js on Windows

2014-02-11 Thread Andrew Grieve (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898020#comment-13898020
 ] 

Andrew Grieve commented on CB-5438:
---

I took a stab at this. Never actually got to the testing phase since I don't 
want to spend the time installing visual studio at the moment (which is 
apparently needed for jsdom to work !?)

> Can't build/test cordova-js on Windows
> --
>
> Key: CB-5438
> URL: https://issues.apache.org/jira/browse/CB-5438
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaJS
>Affects Versions: Master
> Environment: Windows 8 x64
> Node v0.10.13
>Reporter: qi
>Assignee: Andrew Grieve
>Priority: Critical
>
> Simply run 'grunt build', got,
> Running "jshint:src" (jshint) task
> Linting lib/test/androidexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../android/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../android/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../android/exec.js
> [L1:C4] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W015: Expected 'android' to have an indentation at 1 instead at 4.
> ../android/exec.js
> [L1:C19] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W117: 'android' is not defined.
> ../android/exec.js
> [L1:C12] W117: 'exec' is not defined.
> ../android/exec.js
> Linting lib/test/iosexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../ios/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../ios/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../ios/exec.js
> [L1:C4] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W015: Expected 'ios' to have an indentation at 1 instead at 4.
> ../ios/exec.js
> [L1:C15] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W117: 'ios' is not defined.
> ../ios/exec.js
> [L1:C8] W117: 'exec' is not defined.
> ../ios/exec.js
> Warning: Task "jshint:src" failed. Use --force to continue.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (CB-5438) Can't build/test cordova-js on Windows

2014-02-11 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898012#comment-13898012
 ] 

ASF subversion and git services commented on CB-5438:
-

Commit 19f9c02ac7d09b371b78d7ff7489f91de021a7e6 in branch refs/heads/master 
from [~agrieve]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=19f9c02 ]

CB-5438 Remove test symlinks & fix some build errors on windows.


> Can't build/test cordova-js on Windows
> --
>
> Key: CB-5438
> URL: https://issues.apache.org/jira/browse/CB-5438
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaJS
>Affects Versions: Master
> Environment: Windows 8 x64
> Node v0.10.13
>Reporter: qi
>Assignee: Andrew Grieve
>Priority: Critical
>
> Simply run 'grunt build', got,
> Running "jshint:src" (jshint) task
> Linting lib/test/androidexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../android/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../android/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../android/exec.js
> [L1:C4] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W015: Expected 'android' to have an indentation at 1 instead at 4.
> ../android/exec.js
> [L1:C19] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W117: 'android' is not defined.
> ../android/exec.js
> [L1:C12] W117: 'exec' is not defined.
> ../android/exec.js
> Linting lib/test/iosexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../ios/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../ios/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../ios/exec.js
> [L1:C4] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W015: Expected 'ios' to have an indentation at 1 instead at 4.
> ../ios/exec.js
> [L1:C15] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W117: 'ios' is not defined.
> ../ios/exec.js
> [L1:C8] W117: 'exec' is not defined.
> ../ios/exec.js
> Warning: Task "jshint:src" failed. Use --force to continue.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (CB-5438) Can't build/test cordova-js on Windows

2014-02-11 Thread qi (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897692#comment-13897692
 ] 

qi commented on CB-5438:


Hi [~BBosman] thanks, build's now properly working but test still failed. Those 
two js files are intended to test 

> Can't build/test cordova-js on Windows
> --
>
> Key: CB-5438
> URL: https://issues.apache.org/jira/browse/CB-5438
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaJS
>Affects Versions: Master
> Environment: Windows 8 x64
> Node v0.10.13
>Reporter: qi
>Priority: Critical
>
> Simply run 'grunt build', got,
> Running "jshint:src" (jshint) task
> Linting lib/test/androidexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../android/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../android/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../android/exec.js
> [L1:C4] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W015: Expected 'android' to have an indentation at 1 instead at 4.
> ../android/exec.js
> [L1:C19] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W117: 'android' is not defined.
> ../android/exec.js
> [L1:C12] W117: 'exec' is not defined.
> ../android/exec.js
> Linting lib/test/iosexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../ios/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../ios/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../ios/exec.js
> [L1:C4] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W015: Expected 'ios' to have an indentation at 1 instead at 4.
> ../ios/exec.js
> [L1:C15] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W117: 'ios' is not defined.
> ../ios/exec.js
> [L1:C8] W117: 'exec' is not defined.
> ../ios/exec.js
> Warning: Task "jshint:src" failed. Use --force to continue.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (CB-5438) Can't build/test cordova-js on Windows

2014-02-05 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892978#comment-13892978
 ] 

ASF subversion and git services commented on CB-5438:
-

Commit a85f693ca5d15cd5c5204f81c1542100fac13300 in branch refs/heads/browserify 
from [~BBosman]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=a85f693 ]

CB-5438 Exclude local symlinks from jshint

Both /src/test/androidexec.js and /src/test/iosexec.js are symlinks to
/src/android/exec.js and /src/ios/exec.js

Symlinks don't work on the Windows platform and are represented there as
a text file with the contents being a text description of where it
should be pointing at.

The problem is that the jshint task of the build tries to parse those
'text' files as js files, which fails for obvious reasons.

My solution is to explicitly exclude those 2 symlink files from the
jshint task. The files they point at are included in the src/**/*.js
jshint src setting, so they will get checked anyway.

Now we can succesfully run grunt build on Windows.


> Can't build/test cordova-js on Windows
> --
>
> Key: CB-5438
> URL: https://issues.apache.org/jira/browse/CB-5438
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaJS
>Affects Versions: Master
> Environment: Windows 8 x64
> Node v0.10.13
>Reporter: qi
>Priority: Critical
>
> Simply run 'grunt build', got,
> Running "jshint:src" (jshint) task
> Linting lib/test/androidexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../android/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../android/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../android/exec.js
> [L1:C4] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W015: Expected 'android' to have an indentation at 1 instead at 4.
> ../android/exec.js
> [L1:C19] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W117: 'android' is not defined.
> ../android/exec.js
> [L1:C12] W117: 'exec' is not defined.
> ../android/exec.js
> Linting lib/test/iosexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../ios/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../ios/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../ios/exec.js
> [L1:C4] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W015: Expected 'ios' to have an indentation at 1 instead at 4.
> ../ios/exec.js
> [L1:C15] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W117: 'ios' is not defined.
> ../ios/exec.js
> [L1:C8] W117: 'exec' is not defined.
> ../ios/exec.js
> Warning: Task "jshint:src" failed. Use --force to continue.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (CB-5438) Can't build/test cordova-js on Windows

2014-02-05 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892980#comment-13892980
 ] 

ASF subversion and git services commented on CB-5438:
-

Commit 12a6fdbb62c9e37f26fd5f32dbe840b6e3aa8ccd in branch refs/heads/browserify 
from [~purplecabbage]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=12a6fdb ]

Merge branch 'CB-5438' of https://github.com/BBosman/cordova-js


> Can't build/test cordova-js on Windows
> --
>
> Key: CB-5438
> URL: https://issues.apache.org/jira/browse/CB-5438
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaJS
>Affects Versions: Master
> Environment: Windows 8 x64
> Node v0.10.13
>Reporter: qi
>Priority: Critical
>
> Simply run 'grunt build', got,
> Running "jshint:src" (jshint) task
> Linting lib/test/androidexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../android/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../android/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../android/exec.js
> [L1:C4] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W015: Expected 'android' to have an indentation at 1 instead at 4.
> ../android/exec.js
> [L1:C19] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W117: 'android' is not defined.
> ../android/exec.js
> [L1:C12] W117: 'exec' is not defined.
> ../android/exec.js
> Linting lib/test/iosexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../ios/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../ios/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../ios/exec.js
> [L1:C4] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W015: Expected 'ios' to have an indentation at 1 instead at 4.
> ../ios/exec.js
> [L1:C15] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W117: 'ios' is not defined.
> ../ios/exec.js
> [L1:C8] W117: 'exec' is not defined.
> ../ios/exec.js
> Warning: Task "jshint:src" failed. Use --force to continue.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (CB-5438) Can't build/test cordova-js on Windows

2014-02-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891363#comment-13891363
 ] 

ASF subversion and git services commented on CB-5438:
-

Commit 12a6fdbb62c9e37f26fd5f32dbe840b6e3aa8ccd in branch refs/heads/master 
from [~purplecabbage]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=12a6fdb ]

Merge branch 'CB-5438' of https://github.com/BBosman/cordova-js


> Can't build/test cordova-js on Windows
> --
>
> Key: CB-5438
> URL: https://issues.apache.org/jira/browse/CB-5438
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaJS
>Affects Versions: Master
> Environment: Windows 8 x64
> Node v0.10.13
>Reporter: qi
>Priority: Critical
>
> Simply run 'grunt build', got,
> Running "jshint:src" (jshint) task
> Linting lib/test/androidexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../android/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../android/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../android/exec.js
> [L1:C4] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W015: Expected 'android' to have an indentation at 1 instead at 4.
> ../android/exec.js
> [L1:C19] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W117: 'android' is not defined.
> ../android/exec.js
> [L1:C12] W117: 'exec' is not defined.
> ../android/exec.js
> Linting lib/test/iosexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../ios/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../ios/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../ios/exec.js
> [L1:C4] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W015: Expected 'ios' to have an indentation at 1 instead at 4.
> ../ios/exec.js
> [L1:C15] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W117: 'ios' is not defined.
> ../ios/exec.js
> [L1:C8] W117: 'exec' is not defined.
> ../ios/exec.js
> Warning: Task "jshint:src" failed. Use --force to continue.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (CB-5438) Can't build/test cordova-js on Windows

2014-02-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891362#comment-13891362
 ] 

ASF subversion and git services commented on CB-5438:
-

Commit a85f693ca5d15cd5c5204f81c1542100fac13300 in branch refs/heads/master 
from [~BBosman]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=a85f693 ]

CB-5438 Exclude local symlinks from jshint

Both /src/test/androidexec.js and /src/test/iosexec.js are symlinks to
/src/android/exec.js and /src/ios/exec.js

Symlinks don't work on the Windows platform and are represented there as
a text file with the contents being a text description of where it
should be pointing at.

The problem is that the jshint task of the build tries to parse those
'text' files as js files, which fails for obvious reasons.

My solution is to explicitly exclude those 2 symlink files from the
jshint task. The files they point at are included in the src/**/*.js
jshint src setting, so they will get checked anyway.

Now we can succesfully run grunt build on Windows.


> Can't build/test cordova-js on Windows
> --
>
> Key: CB-5438
> URL: https://issues.apache.org/jira/browse/CB-5438
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaJS
>Affects Versions: Master
> Environment: Windows 8 x64
> Node v0.10.13
>Reporter: qi
>Priority: Critical
>
> Simply run 'grunt build', got,
> Running "jshint:src" (jshint) task
> Linting lib/test/androidexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../android/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../android/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../android/exec.js
> [L1:C4] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W015: Expected 'android' to have an indentation at 1 instead at 4.
> ../android/exec.js
> [L1:C19] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W117: 'android' is not defined.
> ../android/exec.js
> [L1:C12] W117: 'exec' is not defined.
> ../android/exec.js
> Linting lib/test/iosexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../ios/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../ios/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../ios/exec.js
> [L1:C4] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W015: Expected 'ios' to have an indentation at 1 instead at 4.
> ../ios/exec.js
> [L1:C15] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W117: 'ios' is not defined.
> ../ios/exec.js
> [L1:C8] W117: 'exec' is not defined.
> ../ios/exec.js
> Warning: Task "jshint:src" failed. Use --force to continue.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (CB-5438) Can't build/test cordova-js on Windows

2014-01-26 Thread Bas Bosman (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882313#comment-13882313
 ] 

Bas Bosman commented on CB-5438:


Both /src/test/androidexec.js and /src/test/iosexec.js are symlinks to
/src/android/exec.js and /src/ios/exec.js

Symlinks don't work on the Windows platform and are represented there as
a text file with the contents being a text description of where it
should be pointing at.

The problem is that the jshint task of the build tries to parse those
'text' files as js files, which fails for obvious reasons.

My solution is to explicitly exclude those 2 symlink files from the
jshint task. The files they point at are included in the src/**/*.js
jshint src setting, so they will get checked anyway.

Now we can successfully run grunt build on Windows.

Pull request for this at: https://github.com/apache/cordova-js/pull/64


> Can't build/test cordova-js on Windows
> --
>
> Key: CB-5438
> URL: https://issues.apache.org/jira/browse/CB-5438
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaJS
>Affects Versions: Master
> Environment: Windows 8 x64
> Node v0.10.13
>Reporter: qi
>Priority: Critical
>
> Simply run 'grunt build', got,
> Running "jshint:src" (jshint) task
> Linting lib/test/androidexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../android/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../android/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../android/exec.js
> [L1:C4] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W015: Expected 'android' to have an indentation at 1 instead at 4.
> ../android/exec.js
> [L1:C19] W033: Missing semicolon.
> ../android/exec.js
> [L1:C4] W117: 'android' is not defined.
> ../android/exec.js
> [L1:C12] W117: 'exec' is not defined.
> ../android/exec.js
> Linting lib/test/iosexec.js ...ERROR
> [L1:C1] E030: Expected an identifier and instead saw '.'.
> ../ios/exec.js
> [L1:C2] E033: Expected an operator and instead saw '.'.
> ../ios/exec.js
> [L1:C3] E033: Expected an operator and instead saw '/'.
> ../ios/exec.js
> [L1:C4] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W015: Expected 'ios' to have an indentation at 1 instead at 4.
> ../ios/exec.js
> [L1:C15] W033: Missing semicolon.
> ../ios/exec.js
> [L1:C4] W117: 'ios' is not defined.
> ../ios/exec.js
> [L1:C8] W117: 'exec' is not defined.
> ../ios/exec.js
> Warning: Task "jshint:src" failed. Use --force to continue.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)