[jira] [Commented] (CB-5634) Orientation Preference is ignored in Android, should be parsed by CLI
[ https://issues.apache.org/jira/browse/CB-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13992724#comment-13992724 ] Iron Bone commented on CB-5634: --- The problem was reported 1,5 year before. Orientation is one of the few main properties in cordova. I do not understand why it is not possible to solve this problem. If it is not possible then cordova should remove this property from the description - such a situation is just a shame for such project. I teach cordova and my students ask me why it does not work. I have no answer - so the students suggest to use something else. Orientation Preference is ignored in Android, should be parsed by CLI - Key: CB-5634 URL: https://issues.apache.org/jira/browse/CB-5634 Project: Apache Cordova Issue Type: Bug Components: Amazon FireOS, Android, CLI, Docs, iOS Reporter: Joe Bowser Assignee: Andrew Grieve The docs say that an Orientation preference is supposed to work across all platforms. However, Android's activities can only be locked to an orientation by modifying the AndroidManifest.xml. To get past this, we either change the docs, or we support this in the CLI. I feel that adding an XML parser to the scripts is complete overkill, since we don't have any tests for our platform scripts, and I personally think they're a giant pile of technical debt. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5634) Orientation Preference is ignored in Android, should be parsed by CLI
[ https://issues.apache.org/jira/browse/CB-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950517#comment-13950517 ] David Lee commented on CB-5634: --- I'm still able to reproduce this on Android for 3.4.0-0.1.3. Maybe it's a bug in the docs, but I have {{preference name=Orientation value=portrait /}} in my config.xml and it's still reorienting to landscape. Orientation Preference is ignored in Android, should be parsed by CLI - Key: CB-5634 URL: https://issues.apache.org/jira/browse/CB-5634 Project: Apache Cordova Issue Type: Bug Components: Amazon FireOS, Android, CLI, Docs, iOS Reporter: Joe Bowser Assignee: Andrew Grieve The docs say that an Orientation preference is supposed to work across all platforms. However, Android's activities can only be locked to an orientation by modifying the AndroidManifest.xml. To get past this, we either change the docs, or we support this in the CLI. I feel that adding an XML parser to the scripts is complete overkill, since we don't have any tests for our platform scripts, and I personally think they're a giant pile of technical debt. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5634) Orientation Preference is ignored in Android, should be parsed by CLI
[ https://issues.apache.org/jira/browse/CB-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950524#comment-13950524 ] David Lee commented on CB-5634: --- I'm also getting a {{[ReferenceError: a is not defined]}} error when I run {{cordova run android}} with {{preference name=Orientation value=portrait /}}. This error doesn't stop the command from succeeding, though. If I remove {{preference name=Orientation value=portrait /}}, then the error message goes away. Orientation Preference is ignored in Android, should be parsed by CLI - Key: CB-5634 URL: https://issues.apache.org/jira/browse/CB-5634 Project: Apache Cordova Issue Type: Bug Components: Amazon FireOS, Android, CLI, Docs, iOS Reporter: Joe Bowser Assignee: Andrew Grieve The docs say that an Orientation preference is supposed to work across all platforms. However, Android's activities can only be locked to an orientation by modifying the AndroidManifest.xml. To get past this, we either change the docs, or we support this in the CLI. I feel that adding an XML parser to the scripts is complete overkill, since we don't have any tests for our platform scripts, and I personally think they're a giant pile of technical debt. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5634) Orientation Preference is ignored in Android, should be parsed by CLI
[ https://issues.apache.org/jira/browse/CB-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950578#comment-13950578 ] Robin Zeggelaar commented on CB-5634: - I can confirm this issue. I tried to find the source of the problem, which brought me to configParser.js, line 88. {code}if (preferences[i].attrib.name.toLowerCase() === name) { ret = a.attrib.value; }{code} Here, the variable a is not defined, generating the error. I'd say changing this line to {code}ret = preferences[i].attrib.value{code} would fix it. Then again, i'm no cordova expert. But that's what it looks like to me. Orientation Preference is ignored in Android, should be parsed by CLI - Key: CB-5634 URL: https://issues.apache.org/jira/browse/CB-5634 Project: Apache Cordova Issue Type: Bug Components: Amazon FireOS, Android, CLI, Docs, iOS Reporter: Joe Bowser Assignee: Andrew Grieve The docs say that an Orientation preference is supposed to work across all platforms. However, Android's activities can only be locked to an orientation by modifying the AndroidManifest.xml. To get past this, we either change the docs, or we support this in the CLI. I feel that adding an XML parser to the scripts is complete overkill, since we don't have any tests for our platform scripts, and I personally think they're a giant pile of technical debt. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5634) Orientation Preference is ignored in Android, should be parsed by CLI
[ https://issues.apache.org/jira/browse/CB-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899950#comment-13899950 ] ASF subversion and git services commented on CB-5634: - Commit 8a4e6a6b1725bb057937ae8ccc6ab0c5af3613de in branch refs/heads/master from [~dpogue] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=8a4e6a6 ] CB-5634 Set Android orientation from config.xml Orientation Preference is ignored in Android, should be parsed by CLI - Key: CB-5634 URL: https://issues.apache.org/jira/browse/CB-5634 Project: Apache Cordova Issue Type: Bug Components: Amazon FireOS, Android, CLI, Docs, iOS Reporter: Joe Bowser The docs say that an Orientation preference is supposed to work across all platforms. However, Android's activities can only be locked to an orientation by modifying the AndroidManifest.xml. To get past this, we either change the docs, or we support this in the CLI. I feel that adding an XML parser to the scripts is complete overkill, since we don't have any tests for our platform scripts, and I personally think they're a giant pile of technical debt. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5634) Orientation Preference is ignored in Android, should be parsed by CLI
[ https://issues.apache.org/jira/browse/CB-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899951#comment-13899951 ] ASF subversion and git services commented on CB-5634: - Commit 0b1417772466d66b0ef942805d9bb39c462b0943 in branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=0b14177 ] CB-5634 Minor refactoring + tests for Android's orientation preference. Orientation Preference is ignored in Android, should be parsed by CLI - Key: CB-5634 URL: https://issues.apache.org/jira/browse/CB-5634 Project: Apache Cordova Issue Type: Bug Components: Amazon FireOS, Android, CLI, Docs, iOS Reporter: Joe Bowser The docs say that an Orientation preference is supposed to work across all platforms. However, Android's activities can only be locked to an orientation by modifying the AndroidManifest.xml. To get past this, we either change the docs, or we support this in the CLI. I feel that adding an XML parser to the scripts is complete overkill, since we don't have any tests for our platform scripts, and I personally think they're a giant pile of technical debt. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5634) Orientation Preference is ignored in Android, should be parsed by CLI
[ https://issues.apache.org/jira/browse/CB-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887504#comment-13887504 ] Darryl Pogue commented on CB-5634: -- I have a patch to cordova-cli for Android that correctly handles parses the orientation: https://github.com/apache/cordova-cli/pull/112 Orientation Preference is ignored in Android, should be parsed by CLI - Key: CB-5634 URL: https://issues.apache.org/jira/browse/CB-5634 Project: Apache Cordova Issue Type: Bug Components: Amazon FireOS, Android, CLI, Docs, iOS Reporter: Joe Bowser The docs say that an Orientation preference is supposed to work across all platforms. However, Android's activities can only be locked to an orientation by modifying the AndroidManifest.xml. To get past this, we either change the docs, or we support this in the CLI. I feel that adding an XML parser to the scripts is complete overkill, since we don't have any tests for our platform scripts, and I personally think they're a giant pile of technical debt. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5634) Orientation Preference is ignored in Android, should be parsed by CLI
[ https://issues.apache.org/jira/browse/CB-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846877#comment-13846877 ] Shazron Abdullah commented on CB-5634: -- This is true, orientation pref is ignored on iOS - you will have to modify the app's Info.plist. The CLI does not handle this currently Orientation Preference is ignored in Android, should be parsed by CLI - Key: CB-5634 URL: https://issues.apache.org/jira/browse/CB-5634 Project: Apache Cordova Issue Type: Bug Components: CLI, Docs Reporter: Joe Bowser The docs say that an Orientation preference is supposed to work across all platforms. However, Android's activities can only be locked to an orientation by modifying the AndroidManifest.xml. To get past this, we either change the docs, or we support this in the CLI. I feel that adding an XML parser to the scripts is complete overkill, since we don't have any tests for our platform scripts, and I personally think they're a giant pile of technical debt. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (CB-5634) Orientation Preference is ignored in Android, should be parsed by CLI
[ https://issues.apache.org/jira/browse/CB-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845729#comment-13845729 ] Joe Bowser commented on CB-5634: Apparently, it's been reported that iOS also ignores this preference that is supported by all platforms. Orientation Preference is ignored in Android, should be parsed by CLI - Key: CB-5634 URL: https://issues.apache.org/jira/browse/CB-5634 Project: Apache Cordova Issue Type: Bug Components: CLI, Docs Reporter: Joe Bowser The docs say that an Orientation preference is supposed to work across all platforms. However, Android's activities can only be locked to an orientation by modifying the AndroidManifest.xml. To get past this, we either change the docs, or we support this in the CLI. I feel that adding an XML parser to the scripts is complete overkill, since we don't have any tests for our platform scripts, and I personally think they're a giant pile of technical debt. -- This message was sent by Atlassian JIRA (v6.1.4#6159)