[jira] [Commented] (CB-5774) Windows 8: DirectoryReader returns isFile = true for directories
[ https://issues.apache.org/jira/browse/CB-5774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872564#comment-13872564 ] Matti Eerola commented on CB-5774: -- results\[i\].isDirectory is false. I think I have found the reason for this error. Folder query in FileProxy.js readEntries-function created FileEntry object instead of DirectoryEntry object. This fixed the error in my use case: https://github.com/spMatti/cordova-plugin-file/commit/9b290353eca2bd64e5deabbb75487052281100ea Windows 8: DirectoryReader returns isFile = true for directories Key: CB-5774 URL: https://issues.apache.org/jira/browse/CB-5774 Project: Apache Cordova Issue Type: Bug Components: Plugin File, Windows 8 Affects Versions: 3.3.0 Environment: Windows 8.0 Reporter: Matti Eerola Assignee: Jesse MacFadyen Priority: Minor All entries returned by DirectoryReader.readEntries have isFile set to true. The expected result is that directories have isFile:false and isDirectory:true. Here is a code sample that will show the error: {code:javascript} window.requestFileSystem(LocalFileSystem.PERSISTENT, 5 * 1024 * 1024 * 1024, function (fs) { //Ensure that there is one directory in the root fs.root.getDirectory('foo', { create: true }, function (newDir) { //Use reader to get the directory var reader = fs.root.createReader(); reader.readEntries(function (results) { for (var i = 0; i results.length; i++) { if (results[i].name != foo) continue; // foo should be directory if (results[i].isFile) throw 'foo' is a directory and isFile is true; } }); }); }); {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5774) Windows 8: DirectoryReader returns isFile = true for directories
[ https://issues.apache.org/jira/browse/CB-5774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872576#comment-13872576 ] Jesse MacFadyen commented on CB-5774: - Do you want to send a pull request, or should I just do it? Windows 8: DirectoryReader returns isFile = true for directories Key: CB-5774 URL: https://issues.apache.org/jira/browse/CB-5774 Project: Apache Cordova Issue Type: Bug Components: Plugin File, Windows 8 Affects Versions: 3.3.0 Environment: Windows 8.0 Reporter: Matti Eerola Assignee: Jesse MacFadyen Priority: Minor All entries returned by DirectoryReader.readEntries have isFile set to true. The expected result is that directories have isFile:false and isDirectory:true. Here is a code sample that will show the error: {code:javascript} window.requestFileSystem(LocalFileSystem.PERSISTENT, 5 * 1024 * 1024 * 1024, function (fs) { //Ensure that there is one directory in the root fs.root.getDirectory('foo', { create: true }, function (newDir) { //Use reader to get the directory var reader = fs.root.createReader(); reader.readEntries(function (results) { for (var i = 0; i results.length; i++) { if (results[i].name != foo) continue; // foo should be directory if (results[i].isFile) throw 'foo' is a directory and isFile is true; } }); }); }); {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5774) Windows 8: DirectoryReader returns isFile = true for directories
[ https://issues.apache.org/jira/browse/CB-5774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872585#comment-13872585 ] Matti Eerola commented on CB-5774: -- It's so small that you can just make the change. Windows 8: DirectoryReader returns isFile = true for directories Key: CB-5774 URL: https://issues.apache.org/jira/browse/CB-5774 Project: Apache Cordova Issue Type: Bug Components: Plugin File, Windows 8 Affects Versions: 3.3.0 Environment: Windows 8.0 Reporter: Matti Eerola Assignee: Jesse MacFadyen Priority: Minor All entries returned by DirectoryReader.readEntries have isFile set to true. The expected result is that directories have isFile:false and isDirectory:true. Here is a code sample that will show the error: {code:javascript} window.requestFileSystem(LocalFileSystem.PERSISTENT, 5 * 1024 * 1024 * 1024, function (fs) { //Ensure that there is one directory in the root fs.root.getDirectory('foo', { create: true }, function (newDir) { //Use reader to get the directory var reader = fs.root.createReader(); reader.readEntries(function (results) { for (var i = 0; i results.length; i++) { if (results[i].name != foo) continue; // foo should be directory if (results[i].isFile) throw 'foo' is a directory and isFile is true; } }); }); }); {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5774) Windows 8: DirectoryReader returns isFile = true for directories
[ https://issues.apache.org/jira/browse/CB-5774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871469#comment-13871469 ] Jesse MacFadyen commented on CB-5774: - Can you verify if results[i].isDirectory is also true? Windows 8: DirectoryReader returns isFile = true for directories Key: CB-5774 URL: https://issues.apache.org/jira/browse/CB-5774 Project: Apache Cordova Issue Type: Bug Components: Plugin File, Windows 8 Affects Versions: 3.3.0 Environment: Windows 8.0 Reporter: Matti Eerola Assignee: Jesse MacFadyen Priority: Minor All entries returned by DirectoryReader.readEntries have isFile set to true. The expected result is that directories have isFile:false and isDirectory:true. Here is a code sample that will show the error: {code:javascript} window.requestFileSystem(LocalFileSystem.PERSISTENT, 5 * 1024 * 1024 * 1024, function (fs) { //Ensure that there is one directory in the root fs.root.getDirectory('foo', { create: true }, function (newDir) { //Use reader to get the directory var reader = fs.root.createReader(); reader.readEntries(function (results) { for (var i = 0; i results.length; i++) { if (results[i].name != foo) continue; // foo should be directory if (results[i].isFile) throw 'foo' is a directory and isFile is true; } }); }); }); {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)