[jira] [Commented] (CB-5816) FirefoxOS - add build script
[ https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14012257#comment-14012257 ] ASF GitHub Bot commented on CB-5816: Github user Steckelfisch commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/7#issuecomment-44518248 Oh. bugger. missed that. I'm bussy coming two weeks, but will fix it. FirefoxOS - add build script Key: CB-5816 URL: https://issues.apache.org/jira/browse/CB-5816 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Axel Nennker run: cordova build firefoxos output: Generating config.xml from defaults for platform firefoxos Preparing firefoxos project Compiling app on platform firefoxos via command /project/platforms/firefoxos/cordova/build events.js:72 throw er; // Unhandled 'error' event ^ Error: spawn ENOENT at errnoException (child_process.js:980:11) at Process.ChildProcess._handle.onexit (child_process.js:771:34) project$ expected output: nothing - platforms/firefoxos/cordova/build does not exist so the cordova build firefoxos command fails. Please add a build script (although it does nothing) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[ https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010948#comment-14010948 ] ASF GitHub Bot commented on CB-5816: Github user fdummert commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/7#issuecomment-44382201 Thank you for adding the basic build functionality for Firefox OS. Unfortunately the adm-zip module used to generate the package.zip is buggy and often creates corrupt zip files (see https://github.com/cthackers/adm-zip/issues/71). Could you please consider using a different zip implementation, e.g. jszip? FirefoxOS - add build script Key: CB-5816 URL: https://issues.apache.org/jira/browse/CB-5816 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Axel Nennker run: cordova build firefoxos output: Generating config.xml from defaults for platform firefoxos Preparing firefoxos project Compiling app on platform firefoxos via command /project/platforms/firefoxos/cordova/build events.js:72 throw er; // Unhandled 'error' event ^ Error: spawn ENOENT at errnoException (child_process.js:980:11) at Process.ChildProcess._handle.onexit (child_process.js:771:34) project$ expected output: nothing - platforms/firefoxos/cordova/build does not exist so the cordova build firefoxos command fails. Please add a build script (although it does nothing) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[ https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997073#comment-13997073 ] ASF subversion and git services commented on CB-5816: - Commit d8c99f9d67e9d26949c5ca2bef1c47bfaba02fff in cordova-firefoxos's branch refs/heads/3.5.x from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-firefoxos.git;h=d8c99f9 ] Merge branch 'CB-5816' of https://github.com/Steckelfisch/cordova-firefoxos into 3.5.x Conflicts: package.json FirefoxOS - add build script Key: CB-5816 URL: https://issues.apache.org/jira/browse/CB-5816 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Axel Nennker run: cordova build firefoxos output: Generating config.xml from defaults for platform firefoxos Preparing firefoxos project Compiling app on platform firefoxos via command /project/platforms/firefoxos/cordova/build events.js:72 throw er; // Unhandled 'error' event ^ Error: spawn ENOENT at errnoException (child_process.js:980:11) at Process.ChildProcess._handle.onexit (child_process.js:771:34) project$ expected output: nothing - platforms/firefoxos/cordova/build does not exist so the cordova build firefoxos command fails. Please add a build script (although it does nothing) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[ https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997074#comment-13997074 ] ASF subversion and git services commented on CB-5816: - Commit 52a52556f4b07d7bf5f4dc5db657eb6e942c57c5 in cordova-firefoxos's branch refs/heads/master from [~Steckelfisch] [ https://git-wip-us.apache.org/repos/asf?p=cordova-firefoxos.git;h=52a5255 ] CB-5816 Review-response: fix unix-centric paths to path.join(), minor typographic changes FirefoxOS - add build script Key: CB-5816 URL: https://issues.apache.org/jira/browse/CB-5816 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Axel Nennker run: cordova build firefoxos output: Generating config.xml from defaults for platform firefoxos Preparing firefoxos project Compiling app on platform firefoxos via command /project/platforms/firefoxos/cordova/build events.js:72 throw er; // Unhandled 'error' event ^ Error: spawn ENOENT at errnoException (child_process.js:980:11) at Process.ChildProcess._handle.onexit (child_process.js:771:34) project$ expected output: nothing - platforms/firefoxos/cordova/build does not exist so the cordova build firefoxos command fails. Please add a build script (although it does nothing) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[ https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997077#comment-13997077 ] ASF GitHub Bot commented on CB-5816: Github user asfgit closed the pull request at: https://github.com/apache/cordova-firefoxos/pull/7 FirefoxOS - add build script Key: CB-5816 URL: https://issues.apache.org/jira/browse/CB-5816 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Axel Nennker run: cordova build firefoxos output: Generating config.xml from defaults for platform firefoxos Preparing firefoxos project Compiling app on platform firefoxos via command /project/platforms/firefoxos/cordova/build events.js:72 throw er; // Unhandled 'error' event ^ Error: spawn ENOENT at errnoException (child_process.js:980:11) at Process.ChildProcess._handle.onexit (child_process.js:771:34) project$ expected output: nothing - platforms/firefoxos/cordova/build does not exist so the cordova build firefoxos command fails. Please add a build script (although it does nothing) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[ https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997076#comment-13997076 ] ASF subversion and git services commented on CB-5816: - Commit 9a15a5a562cc60c090534457d312cc2a4513ce09 in cordova-firefoxos's branch refs/heads/master from [~stevegill] [ https://git-wip-us.apache.org/repos/asf?p=cordova-firefoxos.git;h=9a15a5a ] Merge branch 'CB-5816' of https://github.com/Steckelfisch/cordova-firefoxos Conflicts: package.json FirefoxOS - add build script Key: CB-5816 URL: https://issues.apache.org/jira/browse/CB-5816 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Axel Nennker run: cordova build firefoxos output: Generating config.xml from defaults for platform firefoxos Preparing firefoxos project Compiling app on platform firefoxos via command /project/platforms/firefoxos/cordova/build events.js:72 throw er; // Unhandled 'error' event ^ Error: spawn ENOENT at errnoException (child_process.js:980:11) at Process.ChildProcess._handle.onexit (child_process.js:771:34) project$ expected output: nothing - platforms/firefoxos/cordova/build does not exist so the cordova build firefoxos command fails. Please add a build script (although it does nothing) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[ https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997075#comment-13997075 ] ASF subversion and git services commented on CB-5816: - Commit 7800b1b2718ff5a27afd63e3a7a2f366fb673145 in cordova-firefoxos's branch refs/heads/master from [~Steckelfisch] [ https://git-wip-us.apache.org/repos/asf?p=cordova-firefoxos.git;h=7800b1b ] CB-5816 fix errors in untested code FirefoxOS - add build script Key: CB-5816 URL: https://issues.apache.org/jira/browse/CB-5816 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Axel Nennker run: cordova build firefoxos output: Generating config.xml from defaults for platform firefoxos Preparing firefoxos project Compiling app on platform firefoxos via command /project/platforms/firefoxos/cordova/build events.js:72 throw er; // Unhandled 'error' event ^ Error: spawn ENOENT at errnoException (child_process.js:980:11) at Process.ChildProcess._handle.onexit (child_process.js:771:34) project$ expected output: nothing - platforms/firefoxos/cordova/build does not exist so the cordova build firefoxos command fails. Please add a build script (although it does nothing) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13985277#comment-13985277
]
ASF GitHub Bot commented on CB-5816:
Github user Steckelfisch commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12133238
--- Diff: bin/templates/project/cordova/clean ---
@@ -0,0 +1,38 @@
+#!/usr/bin/env node
+
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+
+var path = require('path'),
+clean = require('./lib/clean'),
+reqs = require('./lib/check_reqs'),
+args = process.argv;
+
+// Support basic help commands
+if(args.length 2
+ || args[2] == '--help' || args[2] == '/?' || args[2] == '-h' ||
--- End diff --
stole it from android
FirefoxOS - add build script
Key: CB-5816
URL: https://issues.apache.org/jira/browse/CB-5816
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
run: cordova build firefoxos
output:
Generating config.xml from defaults for platform firefoxos
Preparing firefoxos project
Compiling app on platform firefoxos via command
/project/platforms/firefoxos/cordova/build
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:980:11)
at Process.ChildProcess._handle.onexit (child_process.js:771:34)
project$
expected output:
nothing
-
platforms/firefoxos/cordova/build does not exist so the cordova build
firefoxos command fails.
Please add a build script (although it does nothing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983048#comment-13983048
]
ASF GitHub Bot commented on CB-5816:
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12049234
--- Diff: bin/lib/create.js ---
@@ -26,6 +26,7 @@ var fs = require('fs'),
ROOT= path.join(__dirname, '..', '..'),
check_reqs = require('./check_reqs');
+
--- End diff --
no. why add a second blank line?
FirefoxOS - add build script
Key: CB-5816
URL: https://issues.apache.org/jira/browse/CB-5816
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
run: cordova build firefoxos
output:
Generating config.xml from defaults for platform firefoxos
Preparing firefoxos project
Compiling app on platform firefoxos via command
/project/platforms/firefoxos/cordova/build
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:980:11)
at Process.ChildProcess._handle.onexit (child_process.js:771:34)
project$
expected output:
nothing
-
platforms/firefoxos/cordova/build does not exist so the cordova build
firefoxos command fails.
Please add a build script (although it does nothing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13982368#comment-13982368
]
ASF GitHub Bot commented on CB-5816:
Github user Steckelfisch commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12029718
--- Diff: bin/lib/create.js ---
@@ -26,6 +26,7 @@ var fs = require('fs'),
ROOT= path.join(__dirname, '..', '..'),
check_reqs = require('./check_reqs');
+
--- End diff --
why check_reqs i assume.
Steven Gill has put that file there and I approached the inclusion
and test as a pattern from other platforms.
FirefoxOS - add build script
Key: CB-5816
URL: https://issues.apache.org/jira/browse/CB-5816
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
run: cordova build firefoxos
output:
Generating config.xml from defaults for platform firefoxos
Preparing firefoxos project
Compiling app on platform firefoxos via command
/project/platforms/firefoxos/cordova/build
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:980:11)
at Process.ChildProcess._handle.onexit (child_process.js:771:34)
project$
expected output:
nothing
-
platforms/firefoxos/cordova/build does not exist so the cordova build
firefoxos command fails.
Please add a build script (although it does nothing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13982376#comment-13982376
]
ASF GitHub Bot commented on CB-5816:
Github user Steckelfisch commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12029772
--- Diff: bin/lib/create.js ---
@@ -53,14 +54,24 @@ exports.createProject =
function(project_path,package_name,project_name){
//copy template folder
shjs.cp('-r', path.join(ROOT, 'bin', 'templates', 'project', 'www'),
project_path);
+
+//copy check_reqs file ,creat bin/lib if it does not exist yet
--- End diff --
It seems i was somewhat sloppy with documentation here. corrected
FirefoxOS - add build script
Key: CB-5816
URL: https://issues.apache.org/jira/browse/CB-5816
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
run: cordova build firefoxos
output:
Generating config.xml from defaults for platform firefoxos
Preparing firefoxos project
Compiling app on platform firefoxos via command
/project/platforms/firefoxos/cordova/build
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:980:11)
at Process.ChildProcess._handle.onexit (child_process.js:771:34)
project$
expected output:
nothing
-
platforms/firefoxos/cordova/build does not exist so the cordova build
firefoxos command fails.
Please add a build script (although it does nothing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13982377#comment-13982377
]
ASF GitHub Bot commented on CB-5816:
Github user Steckelfisch commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12029795
--- Diff: bin/lib/create.js ---
@@ -53,14 +54,24 @@ exports.createProject =
function(project_path,package_name,project_name){
//copy template folder
shjs.cp('-r', path.join(ROOT, 'bin', 'templates', 'project', 'www'),
project_path);
+
+//copy check_reqs file ,creat bin/lib if it does not exist yet
+if(!fs.existsSync(path.join(project_path,'cordova', 'lib'))) {
--- End diff --
check
FirefoxOS - add build script
Key: CB-5816
URL: https://issues.apache.org/jira/browse/CB-5816
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
run: cordova build firefoxos
output:
Generating config.xml from defaults for platform firefoxos
Preparing firefoxos project
Compiling app on platform firefoxos via command
/project/platforms/firefoxos/cordova/build
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:980:11)
at Process.ChildProcess._handle.onexit (child_process.js:771:34)
project$
expected output:
nothing
-
platforms/firefoxos/cordova/build does not exist so the cordova build
firefoxos command fails.
Please add a build script (although it does nothing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13982454#comment-13982454
]
ASF GitHub Bot commented on CB-5816:
Github user Steckelfisch commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12031141
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -0,0 +1,167 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+var path = require('path'),
+fs = require('fs'),
+clean = require('./clean'),
+shjs = require('shelljs'),
+zip = require('adm-zip'),
+check_reqs = require('./check_reqs'),
+buildDirInMerge ='build--release';
+
+function hasMergesCustomReleaseArtifactsDir() {
+return fs.existsSync('merges/firefoxos/'+buildDirInMerge);
+}
+
+
+function hasCustomReleaseArtifactsDir() {
+return fs.existsSync('platforms/firefoxos/www/'+buildDirInMerge);
+}
+
+/**
+ * hasAllMergesRequiredCustomReleaseArtifacts()
+ * checks that merges/firefoxos/build--release is avialable and properly
filled.
+ *
+ */
+function hasAllMergesRequiredCustomReleaseArtifacts() {
+
if(!fs.existsSync('merges/firefoxos/'+buildDirInMerge+'/manifest.webapp')) {
+console.error('\nPlease provide
project/merges/firefoxos/'+buildDirInMerge+'/package.manifest');
+}
+
+if(!fs.existsSync('merges/firefoxos/'+buildDirInMerge+'/index.html')) {
+console.error('\nPlease provide
project/merges/firefoxos/'+buildDirInMerge+'/index.html');
+}
+
+return (
fs.existsSync('merges/firefoxos/'+buildDirInMerge+'/package.manifest')
+
fs.existsSync('merges/firefoxos/'+buildDirInMerge+'/index.html') );
+}
+
+/**
+ * hasAllRequiredCustomReleaseArtifacts()
+ * checks that 'cordova prepare' has copied merges/firefoxos to
platforms/firefoxos/www
+ *
+ */
+function hasAllRequiredCustomReleaseArtifacts() {
+
if(!fs.existsSync('platforms/firefoxos/www/'+buildDirInMerge+'/manifest.webapp'))
{
+console.error('\nPlease provide
project/merges/firefoxos/'+buildDirInMerge+'/package.manifest');
--- End diff --
plus some other stuff :-(
review is nice :-)
FirefoxOS - add build script
Key: CB-5816
URL: https://issues.apache.org/jira/browse/CB-5816
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
run: cordova build firefoxos
output:
Generating config.xml from defaults for platform firefoxos
Preparing firefoxos project
Compiling app on platform firefoxos via command
/project/platforms/firefoxos/cordova/build
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:980:11)
at Process.ChildProcess._handle.onexit (child_process.js:771:34)
project$
expected output:
nothing
-
platforms/firefoxos/cordova/build does not exist so the cordova build
firefoxos command fails.
Please add a build script (although it does nothing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[ https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981087#comment-13981087 ] ASF GitHub Bot commented on CB-5816: Github user zalun commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/7#issuecomment-41403013 Is it polished? FirefoxOS - add build script Key: CB-5816 URL: https://issues.apache.org/jira/browse/CB-5816 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Axel Nennker run: cordova build firefoxos output: Generating config.xml from defaults for platform firefoxos Preparing firefoxos project Compiling app on platform firefoxos via command /project/platforms/firefoxos/cordova/build events.js:72 throw er; // Unhandled 'error' event ^ Error: spawn ENOENT at errnoException (child_process.js:980:11) at Process.ChildProcess._handle.onexit (child_process.js:771:34) project$ expected output: nothing - platforms/firefoxos/cordova/build does not exist so the cordova build firefoxos command fails. Please add a build script (although it does nothing) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981132#comment-13981132
]
ASF GitHub Bot commented on CB-5816:
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001306
--- Diff: bin/lib/create.js ---
@@ -53,14 +54,24 @@ exports.createProject =
function(project_path,package_name,project_name){
//copy template folder
shjs.cp('-r', path.join(ROOT, 'bin', 'templates', 'project', 'www'),
project_path);
+
+//copy check_reqs file ,creat bin/lib if it does not exist yet
+if(!fs.existsSync(path.join(project_path,'cordova', 'lib'))) {
--- End diff --
not sure about this file, but often it's `if (`
FirefoxOS - add build script
Key: CB-5816
URL: https://issues.apache.org/jira/browse/CB-5816
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
run: cordova build firefoxos
output:
Generating config.xml from defaults for platform firefoxos
Preparing firefoxos project
Compiling app on platform firefoxos via command
/project/platforms/firefoxos/cordova/build
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:980:11)
at Process.ChildProcess._handle.onexit (child_process.js:771:34)
project$
expected output:
nothing
-
platforms/firefoxos/cordova/build does not exist so the cordova build
firefoxos command fails.
Please add a build script (although it does nothing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981128#comment-13981128
]
ASF GitHub Bot commented on CB-5816:
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001272
--- Diff: bin/lib/create.js ---
@@ -26,6 +26,7 @@ var fs = require('fs'),
ROOT= path.join(__dirname, '..', '..'),
check_reqs = require('./check_reqs');
+
--- End diff --
Why?
FirefoxOS - add build script
Key: CB-5816
URL: https://issues.apache.org/jira/browse/CB-5816
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
run: cordova build firefoxos
output:
Generating config.xml from defaults for platform firefoxos
Preparing firefoxos project
Compiling app on platform firefoxos via command
/project/platforms/firefoxos/cordova/build
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:980:11)
at Process.ChildProcess._handle.onexit (child_process.js:771:34)
project$
expected output:
nothing
-
platforms/firefoxos/cordova/build does not exist so the cordova build
firefoxos command fails.
Please add a build script (although it does nothing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981131#comment-13981131
]
ASF GitHub Bot commented on CB-5816:
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001296
--- Diff: bin/lib/create.js ---
@@ -53,14 +54,24 @@ exports.createProject =
function(project_path,package_name,project_name){
//copy template folder
shjs.cp('-r', path.join(ROOT, 'bin', 'templates', 'project', 'www'),
project_path);
+
+//copy check_reqs file ,creat bin/lib if it does not exist yet
--- End diff --
`,creat`? did you mean `file, create`?
FirefoxOS - add build script
Key: CB-5816
URL: https://issues.apache.org/jira/browse/CB-5816
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
run: cordova build firefoxos
output:
Generating config.xml from defaults for platform firefoxos
Preparing firefoxos project
Compiling app on platform firefoxos via command
/project/platforms/firefoxos/cordova/build
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:980:11)
at Process.ChildProcess._handle.onexit (child_process.js:771:34)
project$
expected output:
nothing
-
platforms/firefoxos/cordova/build does not exist so the cordova build
firefoxos command fails.
Please add a build script (although it does nothing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981139#comment-13981139
]
ASF GitHub Bot commented on CB-5816:
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001459
--- Diff: bin/templates/project/cordova/clean ---
@@ -0,0 +1,38 @@
+#!/usr/bin/env node
+
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+
+var path = require('path'),
+clean = require('./lib/clean'),
+reqs = require('./lib/check_reqs'),
+args = process.argv;
+
+// Support basic help commands
+if(args.length 2
+ || args[2] == '--help' || args[2] == '/?' || args[2] == '-h' ||
--- End diff --
you don't support -? or /h ... which is a bit odd...
FirefoxOS - add build script
Key: CB-5816
URL: https://issues.apache.org/jira/browse/CB-5816
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
run: cordova build firefoxos
output:
Generating config.xml from defaults for platform firefoxos
Preparing firefoxos project
Compiling app on platform firefoxos via command
/project/platforms/firefoxos/cordova/build
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:980:11)
at Process.ChildProcess._handle.onexit (child_process.js:771:34)
project$
expected output:
nothing
-
platforms/firefoxos/cordova/build does not exist so the cordova build
firefoxos command fails.
Please add a build script (although it does nothing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981138#comment-13981138
]
ASF GitHub Bot commented on CB-5816:
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001446
--- Diff: bin/templates/project/cordova/clean ---
@@ -0,0 +1,38 @@
+#!/usr/bin/env node
+
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+
+var path = require('path'),
+clean = require('./lib/clean'),
+reqs = require('./lib/check_reqs'),
+args = process.argv;
+
+// Support basic help commands
--- End diff --
most people end up using someone's argument parser...
FirefoxOS - add build script
Key: CB-5816
URL: https://issues.apache.org/jira/browse/CB-5816
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
run: cordova build firefoxos
output:
Generating config.xml from defaults for platform firefoxos
Preparing firefoxos project
Compiling app on platform firefoxos via command
/project/platforms/firefoxos/cordova/build
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:980:11)
at Process.ChildProcess._handle.onexit (child_process.js:771:34)
project$
expected output:
nothing
-
platforms/firefoxos/cordova/build does not exist so the cordova build
firefoxos command fails.
Please add a build script (although it does nothing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981144#comment-13981144
]
ASF GitHub Bot commented on CB-5816:
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001511
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -0,0 +1,167 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+var path = require('path'),
+fs = require('fs'),
+clean = require('./clean'),
+shjs = require('shelljs'),
+zip = require('adm-zip'),
+check_reqs = require('./check_reqs'),
+buildDirInMerge ='build--release';
+
+function hasMergesCustomReleaseArtifactsDir() {
+return fs.existsSync('merges/firefoxos/'+buildDirInMerge);
+}
+
+
+function hasCustomReleaseArtifactsDir() {
+return fs.existsSync('platforms/firefoxos/www/'+buildDirInMerge);
+}
+
+/**
+ * hasAllMergesRequiredCustomReleaseArtifacts()
+ * checks that merges/firefoxos/build--release is avialable and properly
filled.
+ *
+ */
+function hasAllMergesRequiredCustomReleaseArtifacts() {
+
if(!fs.existsSync('merges/firefoxos/'+buildDirInMerge+'/manifest.webapp')) {
+console.error('\nPlease provide
project/merges/firefoxos/'+buildDirInMerge+'/package.manifest');
+}
+
+if(!fs.existsSync('merges/firefoxos/'+buildDirInMerge+'/index.html')) {
+console.error('\nPlease provide
project/merges/firefoxos/'+buildDirInMerge+'/index.html');
+}
+
+return (
fs.existsSync('merges/firefoxos/'+buildDirInMerge+'/package.manifest')
+
fs.existsSync('merges/firefoxos/'+buildDirInMerge+'/index.html') );
+}
+
+/**
+ * hasAllRequiredCustomReleaseArtifacts()
+ * checks that 'cordova prepare' has copied merges/firefoxos to
platforms/firefoxos/www
+ *
+ */
+function hasAllRequiredCustomReleaseArtifacts() {
+
if(!fs.existsSync('platforms/firefoxos/www/'+buildDirInMerge+'/manifest.webapp'))
{
+console.error('\nPlease provide
project/merges/firefoxos/'+buildDirInMerge+'/package.manifest');
--- End diff --
these should be path.join() too... so that on Windows you show `\` instead
of `/`
FirefoxOS - add build script
Key: CB-5816
URL: https://issues.apache.org/jira/browse/CB-5816
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
run: cordova build firefoxos
output:
Generating config.xml from defaults for platform firefoxos
Preparing firefoxos project
Compiling app on platform firefoxos via command
/project/platforms/firefoxos/cordova/build
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:980:11)
at Process.ChildProcess._handle.onexit (child_process.js:771:34)
project$
expected output:
nothing
-
platforms/firefoxos/cordova/build does not exist so the cordova build
firefoxos command fails.
Please add a build script (although it does nothing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981140#comment-13981140
]
ASF GitHub Bot commented on CB-5816:
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001463
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -0,0 +1,167 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+var path = require('path'),
+fs = require('fs'),
+clean = require('./clean'),
+shjs = require('shelljs'),
+zip = require('adm-zip'),
+check_reqs = require('./check_reqs'),
+buildDirInMerge ='build--release';
+
+function hasMergesCustomReleaseArtifactsDir() {
+return fs.existsSync('merges/firefoxos/'+buildDirInMerge);
+}
+
+
--- End diff --
why the second blank line?
FirefoxOS - add build script
Key: CB-5816
URL: https://issues.apache.org/jira/browse/CB-5816
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
run: cordova build firefoxos
output:
Generating config.xml from defaults for platform firefoxos
Preparing firefoxos project
Compiling app on platform firefoxos via command
/project/platforms/firefoxos/cordova/build
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:980:11)
at Process.ChildProcess._handle.onexit (child_process.js:771:34)
project$
expected output:
nothing
-
platforms/firefoxos/cordova/build does not exist so the cordova build
firefoxos command fails.
Please add a build script (although it does nothing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981142#comment-13981142
]
ASF GitHub Bot commented on CB-5816:
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001480
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -0,0 +1,167 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+var path = require('path'),
+fs = require('fs'),
+clean = require('./clean'),
+shjs = require('shelljs'),
+zip = require('adm-zip'),
+check_reqs = require('./check_reqs'),
+buildDirInMerge ='build--release';
+
+function hasMergesCustomReleaseArtifactsDir() {
+return fs.existsSync('merges/firefoxos/'+buildDirInMerge);
--- End diff --
this should normally be done using path.join() i think
FirefoxOS - add build script
Key: CB-5816
URL: https://issues.apache.org/jira/browse/CB-5816
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
run: cordova build firefoxos
output:
Generating config.xml from defaults for platform firefoxos
Preparing firefoxos project
Compiling app on platform firefoxos via command
/project/platforms/firefoxos/cordova/build
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:980:11)
at Process.ChildProcess._handle.onexit (child_process.js:771:34)
project$
expected output:
nothing
-
platforms/firefoxos/cordova/build does not exist so the cordova build
firefoxos command fails.
Please add a build script (although it does nothing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[ https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934995#comment-13934995 ] ASF GitHub Bot commented on CB-5816: Github user jsoref commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/7#issuecomment-37646613 Normally there is --release Please don't invent things without checking for precedent. I still don't understand why this pull request as is would be correct. FirefoxOS - add build script Key: CB-5816 URL: https://issues.apache.org/jira/browse/CB-5816 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Axel Nennker run: cordova build firefoxos output: Generating config.xml from defaults for platform firefoxos Preparing firefoxos project Compiling app on platform firefoxos via command /project/platforms/firefoxos/cordova/build events.js:72 throw er; // Unhandled 'error' event ^ Error: spawn ENOENT at errnoException (child_process.js:980:11) at Process.ChildProcess._handle.onexit (child_process.js:771:34) project$ expected output: nothing - platforms/firefoxos/cordova/build does not exist so the cordova build firefoxos command fails. Please add a build script (although it does nothing) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[ https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13935507#comment-13935507 ] ASF GitHub Bot commented on CB-5816: Github user Steckelfisch commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/7#issuecomment-37686312 that should be --release indeed. I have created an implementation for that, using the CommanLineTooling contract and documentation from Firefoxos (https://developer.mozilla.org/en-US/Marketplace/Publishing/Packaged_apps). Still polishing up, and when I'm ready to create a new pull request, I will ask Zalun to review my design and code. FirefoxOS - add build script Key: CB-5816 URL: https://issues.apache.org/jira/browse/CB-5816 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Axel Nennker run: cordova build firefoxos output: Generating config.xml from defaults for platform firefoxos Preparing firefoxos project Compiling app on platform firefoxos via command /project/platforms/firefoxos/cordova/build events.js:72 throw er; // Unhandled 'error' event ^ Error: spawn ENOENT at errnoException (child_process.js:980:11) at Process.ChildProcess._handle.onexit (child_process.js:771:34) project$ expected output: nothing - platforms/firefoxos/cordova/build does not exist so the cordova build firefoxos command fails. Please add a build script (although it does nothing) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[ https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13932970#comment-13932970 ] ASF GitHub Bot commented on CB-5816: Github user Steckelfisch commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/7#issuecomment-37507856 so build --debug (as the default) is what this pullrequest provides build --create builds a zip. should the --create option be filed under a new issue? or add it in this one? FirefoxOS - add build script Key: CB-5816 URL: https://issues.apache.org/jira/browse/CB-5816 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Axel Nennker run: cordova build firefoxos output: Generating config.xml from defaults for platform firefoxos Preparing firefoxos project Compiling app on platform firefoxos via command /project/platforms/firefoxos/cordova/build events.js:72 throw er; // Unhandled 'error' event ^ Error: spawn ENOENT at errnoException (child_process.js:980:11) at Process.ChildProcess._handle.onexit (child_process.js:771:34) project$ expected output: nothing - platforms/firefoxos/cordova/build does not exist so the cordova build firefoxos command fails. Please add a build script (although it does nothing) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[ https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13932032#comment-13932032 ] ASF GitHub Bot commented on CB-5816: Github user zalun commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/7#issuecomment-37436753 We will add an ability to create a zip of the app FirefoxOS - add build script Key: CB-5816 URL: https://issues.apache.org/jira/browse/CB-5816 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Axel Nennker run: cordova build firefoxos output: Generating config.xml from defaults for platform firefoxos Preparing firefoxos project Compiling app on platform firefoxos via command /project/platforms/firefoxos/cordova/build events.js:72 throw er; // Unhandled 'error' event ^ Error: spawn ENOENT at errnoException (child_process.js:980:11) at Process.ChildProcess._handle.onexit (child_process.js:771:34) project$ expected output: nothing - platforms/firefoxos/cordova/build does not exist so the cordova build firefoxos command fails. Please add a build script (although it does nothing) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930764#comment-13930764
]
ASF GitHub Bot commented on CB-5816:
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r10489420
--- Diff: bin/templates/project/cordova/build ---
@@ -0,0 +1,28 @@
+#!/usr/bin/env node
+
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+
+console.log(Build is not implemented);
+if (process.getuid) {
+ console.log('Current uid: ' + process.getuid());
+}
+process.exit(0);
--- End diff --
This should actually be exit(1) iirc
FirefoxOS - add build script
Key: CB-5816
URL: https://issues.apache.org/jira/browse/CB-5816
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
run: cordova build firefoxos
output:
Generating config.xml from defaults for platform firefoxos
Preparing firefoxos project
Compiling app on platform firefoxos via command
/project/platforms/firefoxos/cordova/build
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:980:11)
at Process.ChildProcess._handle.onexit (child_process.js:771:34)
project$
expected output:
nothing
-
platforms/firefoxos/cordova/build does not exist so the cordova build
firefoxos command fails.
Please add a build script (although it does nothing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[
https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930894#comment-13930894
]
ASF GitHub Bot commented on CB-5816:
Github user Steckelfisch commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r10494052
--- Diff: bin/templates/project/cordova/build ---
@@ -0,0 +1,28 @@
+#!/usr/bin/env node
+
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+
+console.log(Build is not implemented);
+if (process.getuid) {
+ console.log('Current uid: ' + process.getuid());
+}
+process.exit(0);
--- End diff --
ah. ok. will create aditional fix.
To satisfy my curiosity, where is this kind of info documented? Or is it
just common knowledge?
FirefoxOS - add build script
Key: CB-5816
URL: https://issues.apache.org/jira/browse/CB-5816
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
run: cordova build firefoxos
output:
Generating config.xml from defaults for platform firefoxos
Preparing firefoxos project
Compiling app on platform firefoxos via command
/project/platforms/firefoxos/cordova/build
events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:980:11)
at Process.ChildProcess._handle.onexit (child_process.js:771:34)
project$
expected output:
nothing
-
platforms/firefoxos/cordova/build does not exist so the cordova build
firefoxos command fails.
Please add a build script (although it does nothing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-5816) FirefoxOS - add build script
[ https://issues.apache.org/jira/browse/CB-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923862#comment-13923862 ] Gert-Jan Braas commented on CB-5816: related to PB-5715 Pull request: https://github.com/apache/cordova-firefoxos/pull/7 FirefoxOS - add build script Key: CB-5816 URL: https://issues.apache.org/jira/browse/CB-5816 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Axel Nennker run: cordova build firefoxos output: Generating config.xml from defaults for platform firefoxos Preparing firefoxos project Compiling app on platform firefoxos via command /project/platforms/firefoxos/cordova/build events.js:72 throw er; // Unhandled 'error' event ^ Error: spawn ENOENT at errnoException (child_process.js:980:11) at Process.ChildProcess._handle.onexit (child_process.js:771:34) project$ expected output: nothing - platforms/firefoxos/cordova/build does not exist so the cordova build firefoxos command fails. Please add a build script (although it does nothing) -- This message was sent by Atlassian JIRA (v6.2#6252)
