[jira] [Commented] (CB-6012) Important query parameters shouldn't be dropped on cdvfile:// urls
[ https://issues.apache.org/jira/browse/CB-6012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898330#comment-13898330 ] ASF subversion and git services commented on CB-6012: - Commit 71ae55766425140ac17525985bb90a5d8eb90364 in branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=71ae557 ] CB-6012: Really fix previous^^ test > Important query parameters shouldn't be dropped on cdvfile:// urls > -- > > Key: CB-6012 > URL: https://issues.apache.org/jira/browse/CB-6012 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin File >Affects Versions: 3.4.0 >Reporter: Ian Clelland >Assignee: Ian Clelland > > Mobile spec file test 10 checks that resolving a local url with query > parameters returns a file entry object without those parameters. > On iOS, at least, those parameters may be useful for asset-library urls. They > shouldn't be dropped automatically on cdvfile:// urls, I think. The correct > behaviour would be to drop them on old-style file:/// urls, but not on any > urls which are explicitly managed by the File plugin. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-6012) Important query parameters shouldn't be dropped on cdvfile:// urls
[ https://issues.apache.org/jira/browse/CB-6012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898319#comment-13898319 ] ASF subversion and git services commented on CB-6012: - Commit 9429825cf3134a961efe52a02cc7572f06d348da in branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=9429825 ] CB-6012: Fix incorrect test in previous commit > Important query parameters shouldn't be dropped on cdvfile:// urls > -- > > Key: CB-6012 > URL: https://issues.apache.org/jira/browse/CB-6012 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin File >Affects Versions: 3.4.0 >Reporter: Ian Clelland >Assignee: Ian Clelland > > Mobile spec file test 10 checks that resolving a local url with query > parameters returns a file entry object without those parameters. > On iOS, at least, those parameters may be useful for asset-library urls. They > shouldn't be dropped automatically on cdvfile:// urls, I think. The correct > behaviour would be to drop them on old-style file:/// urls, but not on any > urls which are explicitly managed by the File plugin. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-6012) Important query parameters shouldn't be dropped on cdvfile:// urls
[ https://issues.apache.org/jira/browse/CB-6012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898162#comment-13898162 ] ASF subversion and git services commented on CB-6012: - Commit 5294f27a3b67224d172bf9fdbe3ac5bb3af61929 in branch refs/heads/dev from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=5294f27 ] CB-6012: Preserve query parameters in cdvfile:// urls; strip query params from local filesystem urls when searching for files > Important query parameters shouldn't be dropped on cdvfile:// urls > -- > > Key: CB-6012 > URL: https://issues.apache.org/jira/browse/CB-6012 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin File >Affects Versions: 3.4.0 >Reporter: Ian Clelland >Assignee: Ian Clelland > > Mobile spec file test 10 checks that resolving a local url with query > parameters returns a file entry object without those parameters. > On iOS, at least, those parameters may be useful for asset-library urls. They > shouldn't be dropped automatically on cdvfile:// urls, I think. The correct > behaviour would be to drop them on old-style file:/// urls, but not on any > urls which are explicitly managed by the File plugin. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-6012) Important query parameters shouldn't be dropped on cdvfile:// urls
[ https://issues.apache.org/jira/browse/CB-6012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898141#comment-13898141 ] ASF subversion and git services commented on CB-6012: - Commit 63a0b95731040e421dc1d70965a9c88cd0dc9290 in branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=63a0b95 ] CB-6012: file.spec.10: Test fullPath rather than name for query parameter preservation > Important query parameters shouldn't be dropped on cdvfile:// urls > -- > > Key: CB-6012 > URL: https://issues.apache.org/jira/browse/CB-6012 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin File >Affects Versions: 3.4.0 >Reporter: Ian Clelland >Assignee: Ian Clelland > > Mobile spec file test 10 checks that resolving a local url with query > parameters returns a file entry object without those parameters. > On iOS, at least, those parameters may be useful for asset-library urls. They > shouldn't be dropped automatically on cdvfile:// urls, I think. The correct > behaviour would be to drop them on old-style file:/// urls, but not on any > urls which are explicitly managed by the File plugin. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-6012) Important query parameters shouldn't be dropped on cdvfile:// urls
[ https://issues.apache.org/jira/browse/CB-6012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898010#comment-13898010 ] ASF subversion and git services commented on CB-6012: - Commit 88ab61bf9f7cc6ac21a8ef8c49917cc289032d26 in branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=88ab61b ] CB-6012: Don't necessarily drop query parameters from File plugin URLs > Important query parameters shouldn't be dropped on cdvfile:// urls > -- > > Key: CB-6012 > URL: https://issues.apache.org/jira/browse/CB-6012 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin File >Affects Versions: 3.4.0 >Reporter: Ian Clelland >Assignee: Ian Clelland > > Mobile spec file test 10 checks that resolving a local url with query > parameters returns a file entry object without those parameters. > On iOS, at least, those parameters may be useful for asset-library urls. They > shouldn't be dropped automatically on cdvfile:// urls, I think. The correct > behaviour would be to drop them on old-style file:/// urls, but not on any > urls which are explicitly managed by the File plugin. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-6012) Important query parameters shouldn't be dropped on cdvfile:// urls
[ https://issues.apache.org/jira/browse/CB-6012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898007#comment-13898007 ] Ian Clelland commented on CB-6012: -- Also, the localfilesystem file systems should strip the query parameters when constructing file paths, and may not preserve them when returning new URLs. (Especially when traversing directories to find new files, there should be no expectation that query parameters are preserved.) > Important query parameters shouldn't be dropped on cdvfile:// urls > -- > > Key: CB-6012 > URL: https://issues.apache.org/jira/browse/CB-6012 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin File >Affects Versions: 3.4.0 >Reporter: Ian Clelland >Assignee: Ian Clelland > > Mobile spec file test 10 checks that resolving a local url with query > parameters returns a file entry object without those parameters. > On iOS, at least, those parameters may be useful for asset-library urls. They > shouldn't be dropped automatically on cdvfile:// urls, I think. The correct > behaviour would be to drop them on old-style file:/// urls, but not on any > urls which are explicitly managed by the File plugin. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-6012) Important query parameters shouldn't be dropped on cdvfile:// urls
[ https://issues.apache.org/jira/browse/CB-6012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897995#comment-13897995 ] Ian Clelland commented on CB-6012: -- Linking to the original issue which added these tests > Important query parameters shouldn't be dropped on cdvfile:// urls > -- > > Key: CB-6012 > URL: https://issues.apache.org/jira/browse/CB-6012 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin File >Affects Versions: 3.4.0 >Reporter: Ian Clelland >Assignee: Ian Clelland > > Mobile spec file test 10 checks that resolving a local url with query > parameters returns a file entry object without those parameters. > On iOS, at least, those parameters may be useful for asset-library urls. They > shouldn't be dropped automatically on cdvfile:// urls, I think. The correct > behaviour would be to drop them on old-style file:/// urls, but not on any > urls which are explicitly managed by the File plugin. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
