[jira] [Commented] (CB-6109) Refactor - ActionStack params should be consistent
[ https://issues.apache.org/jira/browse/CB-6109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913793#comment-13913793 ] ASF subversion and git services commented on CB-6109: - Commit b6a4ad9aee33b78e55dad2fcdd27c7fb5c334167 in cordova-plugman's branch refs/heads/master from [~purplecabbage] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=b6a4ad9 ] CB-6109 all platforms now implement all tags and do verbose log if the method is called but not supported. Added tests > Refactor - ActionStack params should be consistent > -- > > Key: CB-6109 > URL: https://issues.apache.org/jira/browse/CB-6109 > Project: Apache Cordova > Issue Type: Bug > Components: Plugman >Affects Versions: 3.4.0 >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen > > The code repeats the same things over several tags from the platform specific > plugin definition. > Need to verify param use within all project specific action handlers. > An example mapping would be: > https://github.com/apache/cordova-plugman/blob/4ae290a20b72632d91dcc5d5b2180e9f07823e6e/src/install.js#L351 > to: > https://github.com/apache/cordova-plugman/blob/4ae290a20b72632d91dcc5d5b2180e9f07823e6e/src/platforms/android.js#L38 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-6109) Refactor - ActionStack params should be consistent
[ https://issues.apache.org/jira/browse/CB-6109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913483#comment-13913483 ] ASF subversion and git services commented on CB-6109: - Commit 63436d9269cbacf4dafb1bc3b7a19906d5dd831d in cordova-plugman's branch refs/heads/master from [~purplecabbage] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=63436d9 ] CB-6109 Refactored to make ActionStack action calls consistent across platforms, updated tests - all green > Refactor - ActionStack params should be consistent > -- > > Key: CB-6109 > URL: https://issues.apache.org/jira/browse/CB-6109 > Project: Apache Cordova > Issue Type: Bug > Components: Plugman >Affects Versions: 3.4.0 >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen > > The code repeats the same things over several tags from the platform specific > plugin definition. > Need to verify param use within all project specific action handlers. > An example mapping would be: > https://github.com/apache/cordova-plugman/blob/4ae290a20b72632d91dcc5d5b2180e9f07823e6e/src/install.js#L351 > to: > https://github.com/apache/cordova-plugman/blob/4ae290a20b72632d91dcc5d5b2180e9f07823e6e/src/platforms/android.js#L38 -- This message was sent by Atlassian JIRA (v6.1.5#6160)