[jira] [Commented] (CB-6323) platform superspawn exists version check is unfortunate
[
https://issues.apache.org/jira/browse/CB-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944524#comment-13944524
]
ASF subversion and git services commented on CB-6323:
-
Commit c0923f6cfba938010c47915711e3102f781df154 in cordova-cli's branch
refs/heads/master from [~agrieve]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=c0923f6 ]
CB-6323 Fix superspawn's resolve function on windows (was very broken)
platform superspawn exists version check is unfortunate
---
Key: CB-6323
URL: https://issues.apache.org/jira/browse/CB-6323
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Windows 8
Affects Versions: 3.4.0
Reporter: Josh Soref
Assignee: Andrew Grieve
The code before CB-5181 / {{b675ee35d5b92f5b997a834d4e6575e1edc14ef3}} didn't
really look before it leapt, which meant that a platform with only a
{{cordova/version.bat}} and no {{cordova/version}} would magically work.
While I'm not sure of any Windows only platforms, it doesn't seem
unreasonable.
A quick check confirms that in fact *windows8* doesn't have this file.
{{https://git-wip-us.apache.org/repos/asf/cordova-windows.git}} @
{{ca106cfd91efa74b3556d70b6a936e77d85ec169}}
{quote}
cordova-windows $ find windows8 -name 'versi*'
windows8/template/cordova/version.bat
{quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6323) platform superspawn exists version check is unfortunate
[
https://issues.apache.org/jira/browse/CB-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944529#comment-13944529
]
Josh Soref commented on CB-6323:
+var winExtensions = ['.exe', '.cmd', '.bat', '.js', '.vbs'];
+function isValidExe(c) {
+return winExtensions.indexOf(path.extname(cmd)) !== -1
fs.existsSync(cmd);
+}
This doesn't look right, where's c used?
platform superspawn exists version check is unfortunate
---
Key: CB-6323
URL: https://issues.apache.org/jira/browse/CB-6323
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Windows 8
Affects Versions: 3.4.0
Reporter: Josh Soref
Assignee: Andrew Grieve
The code before CB-5181 / {{b675ee35d5b92f5b997a834d4e6575e1edc14ef3}} didn't
really look before it leapt, which meant that a platform with only a
{{cordova/version.bat}} and no {{cordova/version}} would magically work.
While I'm not sure of any Windows only platforms, it doesn't seem
unreasonable.
A quick check confirms that in fact *windows8* doesn't have this file.
{{https://git-wip-us.apache.org/repos/asf/cordova-windows.git}} @
{{ca106cfd91efa74b3556d70b6a936e77d85ec169}}
{quote}
cordova-windows $ find windows8 -name 'versi*'
windows8/template/cordova/version.bat
{quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6323) platform superspawn exists version check is unfortunate
[
https://issues.apache.org/jira/browse/CB-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944548#comment-13944548
]
Andrew Grieve commented on CB-6323:
---
Dang it! Thanks Josh. Looks like c === cmd always, but using c in the function
is clearly what I had intended.
platform superspawn exists version check is unfortunate
---
Key: CB-6323
URL: https://issues.apache.org/jira/browse/CB-6323
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Windows 8
Affects Versions: 3.4.0
Reporter: Josh Soref
Assignee: Andrew Grieve
The code before CB-5181 / {{b675ee35d5b92f5b997a834d4e6575e1edc14ef3}} didn't
really look before it leapt, which meant that a platform with only a
{{cordova/version.bat}} and no {{cordova/version}} would magically work.
While I'm not sure of any Windows only platforms, it doesn't seem
unreasonable.
A quick check confirms that in fact *windows8* doesn't have this file.
{{https://git-wip-us.apache.org/repos/asf/cordova-windows.git}} @
{{ca106cfd91efa74b3556d70b6a936e77d85ec169}}
{quote}
cordova-windows $ find windows8 -name 'versi*'
windows8/template/cordova/version.bat
{quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6323) platform superspawn exists version check is unfortunate
[
https://issues.apache.org/jira/browse/CB-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944547#comment-13944547
]
ASF subversion and git services commented on CB-6323:
-
Commit 787cd6f9988a6eee02f8d3bc169bdb9513196036 in cordova-cli's branch
refs/heads/master from [~agrieve]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=787cd6f ]
CB-6323 Fix harmless typo in superspawn (cmd - c)
platform superspawn exists version check is unfortunate
---
Key: CB-6323
URL: https://issues.apache.org/jira/browse/CB-6323
Project: Apache Cordova
Issue Type: Bug
Components: CLI, Windows 8
Affects Versions: 3.4.0
Reporter: Josh Soref
Assignee: Andrew Grieve
The code before CB-5181 / {{b675ee35d5b92f5b997a834d4e6575e1edc14ef3}} didn't
really look before it leapt, which meant that a platform with only a
{{cordova/version.bat}} and no {{cordova/version}} would magically work.
While I'm not sure of any Windows only platforms, it doesn't seem
unreasonable.
A quick check confirms that in fact *windows8* doesn't have this file.
{{https://git-wip-us.apache.org/repos/asf/cordova-windows.git}} @
{{ca106cfd91efa74b3556d70b6a936e77d85ec169}}
{quote}
cordova-windows $ find windows8 -name 'versi*'
windows8/template/cordova/version.bat
{quote}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
