[jira] [Commented] (CB-7356) mobilespec's localXHR test #6 fails on WP8
[
https://issues.apache.org/jira/browse/CB-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14164756#comment-14164756
]
ASF subversion and git services commented on CB-7356:
-
Commit 46c804ff052e4fac84a6d1722e747251edad0911 in cordova-mobile-spec's branch
refs/heads/master from [~purplecabbage]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=46c804f ]
Merge branch 'CB-7356' of https://github.com/MSOpenTech/cordova-mobile-spec
mobilespec's localXHR test #6 fails on WP8
--
Key: CB-7356
URL: https://issues.apache.org/jira/browse/CB-7356
Project: Apache Cordova
Issue Type: Bug
Components: mobile-spec
Reporter: Vladimir Kotikov
Labels: mobilespec, wp8
Commit https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;h=6ded156
make spec 6 on the 'local XHR tests' from mobile spec (XMLHttpRequest.spec.6
should be able to load the current page with hash-part added) failing.
Seems that problem is in test itself. {{window.location}} has been changed
inside of test (probably, it's a bad practice), and this cleans XHR callbacks
cache, so callbacks for any pending XHR's are never called.
Do we really want to change {{window.location}} before calling XHR?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7356) mobilespec's localXHR test #6 fails on WP8
[
https://issues.apache.org/jira/browse/CB-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14164755#comment-14164755
]
ASF subversion and git services commented on CB-7356:
-
Commit 52c7b1a551444bc2f7b7290a20b7bfa9a1f4ec77 in cordova-mobile-spec's branch
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=52c7b1a ]
CB-7356 Fix spec.6 failing on WP8
mobilespec's localXHR test #6 fails on WP8
--
Key: CB-7356
URL: https://issues.apache.org/jira/browse/CB-7356
Project: Apache Cordova
Issue Type: Bug
Components: mobile-spec
Reporter: Vladimir Kotikov
Labels: mobilespec, wp8
Commit https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;h=6ded156
make spec 6 on the 'local XHR tests' from mobile spec (XMLHttpRequest.spec.6
should be able to load the current page with hash-part added) failing.
Seems that problem is in test itself. {{window.location}} has been changed
inside of test (probably, it's a bad practice), and this cleans XHR callbacks
cache, so callbacks for any pending XHR's are never called.
Do we really want to change {{window.location}} before calling XHR?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7356) mobilespec's localXHR test #6 fails on WP8
[
https://issues.apache.org/jira/browse/CB-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14164757#comment-14164757
]
ASF GitHub Bot commented on CB-7356:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/104
mobilespec's localXHR test #6 fails on WP8
--
Key: CB-7356
URL: https://issues.apache.org/jira/browse/CB-7356
Project: Apache Cordova
Issue Type: Bug
Components: mobile-spec
Reporter: Vladimir Kotikov
Labels: mobilespec, wp8
Commit https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;h=6ded156
make spec 6 on the 'local XHR tests' from mobile spec (XMLHttpRequest.spec.6
should be able to load the current page with hash-part added) failing.
Seems that problem is in test itself. {{window.location}} has been changed
inside of test (probably, it's a bad practice), and this cleans XHR callbacks
cache, so callbacks for any pending XHR's are never called.
Do we really want to change {{window.location}} before calling XHR?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7356) mobilespec's localXHR test #6 fails on WP8
[
https://issues.apache.org/jira/browse/CB-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105246#comment-14105246
]
ASF GitHub Bot commented on CB-7356:
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/104
CB-7356 Fix spec.6 failing on WP8
Fix for https://issues.apache.org/jira/browse/CB-7356
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-mobile-spec CB-7356
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-mobile-spec/pull/104.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #104
commit 52c7b1a551444bc2f7b7290a20b7bfa9a1f4ec77
Author: Vladimir Kotikov v-vlk...@microsoft.com
Date: 2014-08-21T09:13:50Z
CB-7356 Fix spec.6 failing on WP8
mobilespec's localXHR test #6 fails on WP8
--
Key: CB-7356
URL: https://issues.apache.org/jira/browse/CB-7356
Project: Apache Cordova
Issue Type: Bug
Components: mobile-spec
Reporter: Vladimir Kotikov
Labels: mobilespec, wp8
Commit https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;h=6ded156
make spec 6 on the 'local XHR tests' from mobile spec (XMLHttpRequest.spec.6
should be able to load the current page with hash-part added) failing.
Seems that problem is in test itself. {{window.location}} has been changed
inside of test (probably, it's a bad practice), and this cleans XHR callbacks
cache, so callbacks for any pending XHR's are never called.
Do we really want to change {{window.location}} before calling XHR?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-7356) mobilespec's localXHR test #6 fails on WP8
[
https://issues.apache.org/jira/browse/CB-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105492#comment-14105492
]
Martin Gonzalez commented on CB-7356:
-
Yes I did that yesterday, I was about to deliver the same fix.
window.location it's a read-only object, I agree try to modify its value, it's
a bad practice.
Thanks Vlad.
mobilespec's localXHR test #6 fails on WP8
--
Key: CB-7356
URL: https://issues.apache.org/jira/browse/CB-7356
Project: Apache Cordova
Issue Type: Bug
Components: mobile-spec
Reporter: Vladimir Kotikov
Labels: mobilespec, wp8
Commit https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;h=6ded156
make spec 6 on the 'local XHR tests' from mobile spec (XMLHttpRequest.spec.6
should be able to load the current page with hash-part added) failing.
Seems that problem is in test itself. {{window.location}} has been changed
inside of test (probably, it's a bad practice), and this cleans XHR callbacks
cache, so callbacks for any pending XHR's are never called.
Do we really want to change {{window.location}} before calling XHR?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
