[jira] [Commented] (CB-8498) Camera plugin on windows does not return native URL for photolibrary source
[
https://issues.apache.org/jira/browse/CB-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007411#comment-15007411
]
Raghav commented on CB-8498:
[~vldmrrr]: Can we close this issue?
> Camera plugin on windows does not return native URL for photolibrary source
> ---
>
> Key: CB-8498
> URL: https://issues.apache.org/jira/browse/CB-8498
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
>Affects Versions: 3.5.0
> Environment: Windows 8.1, platform windows
>Reporter: vldm
>
> getPicture called with options
> {
> sourceType: git ss,
> destinationType: Camera.DestinationType.NATIVE_URI
> }
> returns blob: URI. Expected to return native file URI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8498) Camera plugin on windows does not return native URL for photolibrary source
[
https://issues.apache.org/jira/browse/CB-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007616#comment-15007616
]
vldm commented on CB-8498:
--
yeah, it appears all changes were merged
> Camera plugin on windows does not return native URL for photolibrary source
> ---
>
> Key: CB-8498
> URL: https://issues.apache.org/jira/browse/CB-8498
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
>Affects Versions: 3.5.0
> Environment: Windows 8.1, platform windows
>Reporter: vldm
>
> getPicture called with options
> {
> sourceType: git ss,
> destinationType: Camera.DestinationType.NATIVE_URI
> }
> returns blob: URI. Expected to return native file URI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8498) Camera plugin on windows does not return native URL for photolibrary source
[
https://issues.apache.org/jira/browse/CB-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590631#comment-14590631
]
Vladimir Avdonin commented on CB-8498:
--
New pull request: https://github.com/apache/cordova-plugin-camera/pull/102
Camera plugin on windows does not return native URL for photolibrary source
---
Key: CB-8498
URL: https://issues.apache.org/jira/browse/CB-8498
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Camera
Affects Versions: 3.5.0
Environment: Windows 8.1, platform windows
Reporter: Vladimir Avdonin
getPicture called with options
{
sourceType: git ss,
destinationType: Camera.DestinationType.NATIVE_URI
}
returns blob: URI. Expected to return native file URI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8498) Camera plugin on windows does not return native URL for photolibrary source
[
https://issues.apache.org/jira/browse/CB-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591002#comment-14591002
]
ASF subversion and git services commented on CB-8498:
-
Commit 2e147ba9caad07004cf2384debaed7ba365c597c in cordova-plugin-camera's
branch refs/heads/master from [~purplecabbage]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;h=2e147ba
]
Merge branch 'CB-8498-take2' of https://github.com/vldmrrr/cordova-plugin-camera
Camera plugin on windows does not return native URL for photolibrary source
---
Key: CB-8498
URL: https://issues.apache.org/jira/browse/CB-8498
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Camera
Affects Versions: 3.5.0
Environment: Windows 8.1, platform windows
Reporter: Vladimir Avdonin
getPicture called with options
{
sourceType: git ss,
destinationType: Camera.DestinationType.NATIVE_URI
}
returns blob: URI. Expected to return native file URI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8498) Camera plugin on windows does not return native URL for photolibrary source
[
https://issues.apache.org/jira/browse/CB-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552692#comment-14552692
]
Mathieu Lafontaine commented on CB-8498:
I think the same fix applied here
(https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;a=commitdiff;h=33ffb17;hp=a830b3e08b610388c51aba38db41424e72db3d8b)
should also be applied here
(https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;a=blob;f=src/windows/CameraProxy.js;h=dd7afd796efd1dcf65f5a8afc52f1351557b37c2;hb=706a3aa73ed20e748fad3d95006ede002c08ed4a#l247)
Camera plugin on windows does not return native URL for photolibrary source
---
Key: CB-8498
URL: https://issues.apache.org/jira/browse/CB-8498
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Camera
Affects Versions: 3.5.0
Environment: Windows 8.1, platform windows
Reporter: Vladimir Avdonin
getPicture called with options
{
sourceType: git ss,
destinationType: Camera.DestinationType.NATIVE_URI
}
returns blob: URI. Expected to return native file URI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8498) Camera plugin on windows does not return native URL for photolibrary source
[
https://issues.apache.org/jira/browse/CB-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14549566#comment-14549566
]
ASF GitHub Bot commented on CB-8498:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/64
Camera plugin on windows does not return native URL for photolibrary source
---
Key: CB-8498
URL: https://issues.apache.org/jira/browse/CB-8498
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Camera
Affects Versions: 3.5.0
Environment: Windows 8.1, platform windows
Reporter: Vladimir Avdonin
getPicture called with options
{
sourceType: git ss,
destinationType: Camera.DestinationType.NATIVE_URI
}
returns blob: URI. Expected to return native file URI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8498) Camera plugin on windows does not return native URL for photolibrary source
[
https://issues.apache.org/jira/browse/CB-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14549565#comment-14549565
]
ASF subversion and git services commented on CB-8498:
-
Commit 33ffb17c9780db93e44bc9daaa284d4809940a95 in cordova-plugin-camera's
branch refs/heads/master from [~purplecabbage]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;h=33ffb17
]
Patch for CB-8498, this closes #64
Camera plugin on windows does not return native URL for photolibrary source
---
Key: CB-8498
URL: https://issues.apache.org/jira/browse/CB-8498
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Camera
Affects Versions: 3.5.0
Environment: Windows 8.1, platform windows
Reporter: Vladimir Avdonin
getPicture called with options
{
sourceType: git ss,
destinationType: Camera.DestinationType.NATIVE_URI
}
returns blob: URI. Expected to return native file URI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8498) Camera plugin on windows does not return native URL for photolibrary source
[
https://issues.apache.org/jira/browse/CB-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14348748#comment-14348748
]
ASF GitHub Bot commented on CB-8498:
Github user vldmrrr commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/64#discussion_r25863818
--- Diff: src/windows/CameraProxy.js ---
@@ -165,7 +165,16 @@ module.exports = {
var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting).then(function
(storageFile) {
-
successCallback(URL.createObjectURL(storageFile));
--- End diff --
OK, tested, works, amended commit as suggested
Camera plugin on windows does not return native URL for photolibrary source
---
Key: CB-8498
URL: https://issues.apache.org/jira/browse/CB-8498
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Camera
Affects Versions: 3.5.0
Environment: Windows 8.1, platform windows
Reporter: Vladimir Avdonin
getPicture called with options
{
sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
destinationType: Camera.DestinationType.NATIVE_URI
}
returns blob: URI. Expected to return native file URI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8498) Camera plugin on windows does not return native URL for photolibrary source
[
https://issues.apache.org/jira/browse/CB-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14348696#comment-14348696
]
ASF GitHub Bot commented on CB-8498:
Github user Bubkastor commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/64#discussion_r25860399
--- Diff: src/windows/CameraProxy.js ---
@@ -165,7 +165,16 @@ module.exports = {
var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting).then(function
(storageFile) {
-
successCallback(URL.createObjectURL(storageFile));
--- End diff --
Maybe just
return successCallback(ms-appdata:///local/ + storagefile.name);
Camera plugin on windows does not return native URL for photolibrary source
---
Key: CB-8498
URL: https://issues.apache.org/jira/browse/CB-8498
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Camera
Affects Versions: 3.5.0
Environment: Windows 8.1, platform windows
Reporter: Vladimir Avdonin
getPicture called with options
{
sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
destinationType: Camera.DestinationType.NATIVE_URI
}
returns blob: URI. Expected to return native file URI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8498) Camera plugin on windows does not return native URL for photolibrary source
[
https://issues.apache.org/jira/browse/CB-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14348701#comment-14348701
]
ASF GitHub Bot commented on CB-8498:
Github user vldmrrr commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/64#discussion_r25861297
--- Diff: src/windows/CameraProxy.js ---
@@ -165,7 +165,16 @@ module.exports = {
var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting).then(function
(storageFile) {
-
successCallback(URL.createObjectURL(storageFile));
--- End diff --
Yeah, that should work as well. Just need to test.
Camera plugin on windows does not return native URL for photolibrary source
---
Key: CB-8498
URL: https://issues.apache.org/jira/browse/CB-8498
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Camera
Affects Versions: 3.5.0
Environment: Windows 8.1, platform windows
Reporter: Vladimir Avdonin
getPicture called with options
{
sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
destinationType: Camera.DestinationType.NATIVE_URI
}
returns blob: URI. Expected to return native file URI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8498) Camera plugin on windows does not return native URL for photolibrary source
[
https://issues.apache.org/jira/browse/CB-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346975#comment-14346975
]
ASF GitHub Bot commented on CB-8498:
Github user vldmrrr commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/64#discussion_r25779360
--- Diff: src/windows/CameraProxy.js ---
@@ -165,7 +165,16 @@ module.exports = {
var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting).then(function
(storageFile) {
-
successCallback(URL.createObjectURL(storageFile));
+var res;
+if (destinationType ==
Camera.DestinationType.NATIVE_URI) {
+res = storageFile.path
+.replace(/\\/g, '/')
+.replace(':','%3A');
--- End diff --
Colon is invalid character in URI. This replacement makes returned URI
compatible with native URI suitable for File plugin.
Camera plugin on windows does not return native URL for photolibrary source
---
Key: CB-8498
URL: https://issues.apache.org/jira/browse/CB-8498
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Camera
Affects Versions: 3.5.0
Environment: Windows 8.1, platform windows
Reporter: Vladimir Avdonin
getPicture called with options
{
sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
destinationType: Camera.DestinationType.NATIVE_URI
}
returns blob: URI. Expected to return native file URI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8498) Camera plugin on windows does not return native URL for photolibrary source
[
https://issues.apache.org/jira/browse/CB-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346967#comment-14346967
]
ASF GitHub Bot commented on CB-8498:
Github user Bubkastor commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/64#discussion_r25779060
--- Diff: src/windows/CameraProxy.js ---
@@ -165,7 +165,16 @@ module.exports = {
var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting).then(function
(storageFile) {
-
successCallback(URL.createObjectURL(storageFile));
+var res;
+if (destinationType ==
Camera.DestinationType.NATIVE_URI) {
+res = storageFile.path
+.replace(/\\/g, '/')
+.replace(':','%3A');
--- End diff --
there is no need to replace
Camera plugin on windows does not return native URL for photolibrary source
---
Key: CB-8498
URL: https://issues.apache.org/jira/browse/CB-8498
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Camera
Affects Versions: 3.5.0
Environment: Windows 8.1, platform windows
Reporter: Vladimir Avdonin
getPicture called with options
{
sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
destinationType: Camera.DestinationType.NATIVE_URI
}
returns blob: URI. Expected to return native file URI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8498) Camera plugin on windows does not return native URL for photolibrary source
[
https://issues.apache.org/jira/browse/CB-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344928#comment-14344928
]
ASF GitHub Bot commented on CB-8498:
Github user Bubkastor commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/64#issuecomment-76925942
Image not open this uri object.
Camera plugin on windows does not return native URL for photolibrary source
---
Key: CB-8498
URL: https://issues.apache.org/jira/browse/CB-8498
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Camera
Affects Versions: 3.5.0
Environment: Windows 8.1, platform windows
Reporter: Vladimir Avdonin
getPicture called with options
{
sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
destinationType: Camera.DestinationType.NATIVE_URI
}
returns blob: URI. Expected to return native file URI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8498) Camera plugin on windows does not return native URL for photolibrary source
[
https://issues.apache.org/jira/browse/CB-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14324598#comment-14324598
]
ASF GitHub Bot commented on CB-8498:
GitHub user vldmrrr opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/64
CB-8498: On windows import from library shall return native URI when
requested.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vldmrrr/cordova-plugin-camera CB-8498
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/64.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #64
commit d4db0fe78eb3b1dd014d567af9bcfd6e6e42723f
Author: unknown vldm...@gmail.com
Date: 2015-02-17T18:08:50Z
Windows: import from library shall return native URI when requested.
Camera plugin on windows does not return native URL for photolibrary source
---
Key: CB-8498
URL: https://issues.apache.org/jira/browse/CB-8498
Project: Apache Cordova
Issue Type: Bug
Components: Plugin Camera
Affects Versions: 3.5.0
Environment: Windows 8.1, platform windows
Reporter: Vladimir Avdonin
getPicture called with options
{
sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
destinationType: Camera.DestinationType.NATIVE_URI
}
returns blob: URI. Expected to return native file URI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
