[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-12-07 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730544#comment-15730544
 ] 

ASF subversion and git services commented on CB-8929:
-

Commit 248f96fcdd98e02a69e1d82b7a53bfdfed510a08 in 
cordova-plugin-battery-status's branch refs/heads/1.2.x from [~vladimir.kotikov]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=248f96f
 ]

CB-8929 Fix failing tests on iOS


> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-12-07 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730543#comment-15730543
 ] 

ASF subversion and git services commented on CB-8929:
-

Commit 85c6f507a3e4b8640ae81eac3be953e6d7cf19ab in 
cordova-plugin-battery-status's branch refs/heads/1.2.x from [~vladimir.kotikov]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=85c6f50
 ]

CB-8929 Use PowerManager to get battery state on Win 10

This closes #42


> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-11-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653303#comment-15653303
 ] 

ASF GitHub Bot commented on CB-8929:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-battery-status/pull/44


> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-11-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653299#comment-15653299
 ] 

ASF GitHub Bot commented on CB-8929:


Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-battery-status/pull/44
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-battery-status/pull/44/commits/248f96fcdd98e02a69e1d82b7a53bfdfed510a08)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/32//PLATFORM=android/artifact/)
 |
 



> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-11-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653274#comment-15653274
 ] 

ASF GitHub Bot commented on CB-8929:


GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-plugin-battery-status/pull/44

CB-8929 Fix failing tests on iOS



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull 
https://github.com/vladimir-kotikov/cordova-plugin-battery-status master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-battery-status/pull/44.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #44


commit 248f96fcdd98e02a69e1d82b7a53bfdfed510a08
Author: Vladimir Kotikov 
Date:   2016-11-10T07:14:42Z

CB-8929 Fix failing tests on iOS




> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-11-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648286#comment-15648286
 ] 

ASF GitHub Bot commented on CB-8929:


Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-battery-status/pull/42
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-battery-status/pull/42/commits/9f236357b0488e8aecad852539c8cff47768bc36)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/30//PLATFORM=android/artifact/)
 |
 



> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-11-08 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647660#comment-15647660
 ] 

ASF subversion and git services commented on CB-8929:
-

Commit 85c6f507a3e4b8640ae81eac3be953e6d7cf19ab in 
cordova-plugin-battery-status's branch refs/heads/master from 
[~vladimir.kotikov]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=85c6f50
 ]

CB-8929 Use PowerManager to get battery state on Win 10

This closes #42


> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-11-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647661#comment-15647661
 ] 

ASF GitHub Bot commented on CB-8929:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-battery-status/pull/42


> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-11-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647619#comment-15647619
 ] 

ASF GitHub Bot commented on CB-8929:


Github user daserge commented on the issue:

https://github.com/apache/cordova-plugin-battery-status/pull/42
  
@vladimir-kotikov LGTM, thanks!


> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-11-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647532#comment-15647532
 ] 

ASF GitHub Bot commented on CB-8929:


Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-plugin-battery-status/pull/42
  
@daserge, addressed your notes


> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-11-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646928#comment-15646928
 ] 

ASF GitHub Bot commented on CB-8929:


Github user daserge commented on the issue:

https://github.com/apache/cordova-plugin-battery-status/pull/42
  
Tested and it works good on all targets (Win 10 desktop, Win 10 Mobile, 
Windows Phone 8.1).
LGTM apart the comments.


> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-11-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646897#comment-15646897
 ] 

ASF GitHub Bot commented on CB-8929:


Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-battery-status/pull/42#discussion_r86942697
  
--- Diff: src/windows/BatteryProxy.js ---
@@ -19,7 +19,38 @@
  *
  */
 
-/* global WinJS, BatteryStatus */
+/* global Windows, WinJS, BatteryStatus */
+
+var PowerManager = Windows && Windows.System &&
+Windows.System.Power && Windows.System.Power.PowerManager;
+
+if (PowerManager) {
+var BatteryWin10 = {
+start: function (win, fail) {
+
+function reportStatus() {
+win({
+level: PowerManager.remainingChargePercent,
+isPlugged: PowerManager.powerSupplyStatus !== 
Windows.System.Power.PowerSupplyStatus.notPresent
+}, { keepCallback: true });
+}
+
+PowerManager.onremainingchargepercentchanged = reportStatus;
--- End diff --

Would not it be better to use add/remove event listener here instead to 
avoid overriding a listener which might be set in an app code?


> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-11-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644844#comment-15644844
 ] 

ASF GitHub Bot commented on CB-8929:


Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-battery-status/pull/42
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-battery-status/pull/42/commits/04339fb875e357ae48460c3390a12bb6566b7b06)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/29//PLATFORM=android/artifact/)
 |
 



> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-11-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643991#comment-15643991
 ] 

ASF GitHub Bot commented on CB-8929:


GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-plugin-battery-status/pull/42

CB-8929 Use PowerManager to get battery state on Win 10



### Platforms affected
Windows (specifically Windows 10)

### What does this PR do?
Adds support for Windows 10

### What testing has been done on this change?
Manual testing

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull 
https://github.com/vladimir-kotikov/cordova-plugin-battery-status CB-8929

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-battery-status/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #42


commit 04339fb875e357ae48460c3390a12bb6566b7b06
Author: Vladimir Kotikov 
Date:   2016-11-07T11:46:20Z

CB-8929 Use PowerManager to get battery state on Win 10




> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-11-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633567#comment-15633567
 ] 

ASF GitHub Bot commented on CB-8929:


Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-battery-status/pull/41
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-battery-status/pull/41/commits/a30847726dde98bab4dd5bf27f3a97d065caee54)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-battery-status-pr/28//PLATFORM=android/artifact/)
 |
 



> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-11-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633476#comment-15633476
 ] 

ASF GitHub Bot commented on CB-8929:


Github user alsorokin closed the pull request at:

https://github.com/apache/cordova-plugin-battery-status/pull/41


> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2016-11-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633253#comment-15633253
 ] 

ASF GitHub Bot commented on CB-8929:


GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-battery-status/pull/41

CB-8929 (Windows) Now working on Windows 10 mobile devices

### Platforms affected
Windows

### What does this PR do?
Fixes battery-status plugin now working on Windows 10 devices

### What testing has been done on this change?
Tested on Lumia 1520 and Windows 10 Desktop

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-battery-status 
CB-8929

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-battery-status/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #41


commit a30847726dde98bab4dd5bf27f3a97d065caee54
Author: Alexander Sorokin 
Date:   2016-11-03T15:54:37Z

CB-8929 (Windows) Now working on Windows 10 mobile devices




> battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
> Desktop device
> -
>
> Key: CB-8929
> URL: https://issues.apache.org/jira/browse/CB-8929
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Battery Status, Windows
>Reporter: Rob Paveza
>Priority: Minor
>
> On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
> available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8929) battery-status on Windows fails to work on Windows 10, thinks a Phone is a Desktop device

2015-05-01 Thread Rob Paveza (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523408#comment-14523408
 ] 

Rob Paveza commented on CB-8929:


I have a fix for this, but Windows 10 has a bug in the APIs that cause HTML 
apps to crash.  Once that fix is in flights, I'll push the PR.

 battery-status on Windows fails to work on Windows 10, thinks a Phone is a 
 Desktop device
 -

 Key: CB-8929
 URL: https://issues.apache.org/jira/browse/CB-8929
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Battery Status, Windows
Reporter: Rob Paveza
Priority: Minor

 On a Windows 10 phone, the Battery Status responds that Battery Status isn't 
 available on a Windows Desktop device.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org