[jira] [Commented] (CB-9109) Switch to using .ratignore in cordova repositories
[
https://issues.apache.org/jira/browse/CB-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590435#comment-14590435
]
ASF GitHub Bot commented on CB-9109:
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/86#discussion_r32667023
--- Diff: src/audit-license-headers.js ---
@@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [
'*.xcworkspacedata',
'*.xccheckout',
'*.xcscheme',
-];
+];
+
+var RAT_IGNORE_PATH = '.ratignore';
+var RATIGNORE_COMMENT_PREFIX = '#';
+
+var RAT_NAME = 'apache-rat-0.10';
+var RAT_URL =
'https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.10/apache-rat-0.10-bin.tar.gz';
+
+function startsWith(string, prefix) {
+return string.lastIndexOf(prefix, 0) === 0;
--- End diff --
It works because `lastIndexOf` searches backwards. That's definitely an
implementation detail, and I shouldn't rely on it.
Switch to using .ratignore in cordova repositories
--
Key: CB-9109
URL: https://issues.apache.org/jira/browse/CB-9109
Project: Apache Cordova
Issue Type: Improvement
Components: Coho
Reporter: Dmitry Blotsky
Assignee: Dmitry Blotsky
Labels: coho, rat
Original Estimate: 24h
Remaining Estimate: 24h
Move from using ratExcludes in repoutils.js within COHO to using a .ratignore
file in each respective repo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9109) Switch to using .ratignore in cordova repositories
[
https://issues.apache.org/jira/browse/CB-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590407#comment-14590407
]
ASF GitHub Bot commented on CB-9109:
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/86#discussion_r32665147
--- Diff: src/audit-license-headers.js ---
@@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [
'*.xcworkspacedata',
'*.xccheckout',
'*.xcscheme',
-];
+];
+
+var RAT_IGNORE_PATH = '.ratignore';
+var RATIGNORE_COMMENT_PREFIX = '#';
+
+var RAT_NAME = 'apache-rat-0.10';
+var RAT_URL =
'https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.10/apache-rat-0.10-bin.tar.gz';
+
+function startsWith(string, prefix) {
+return string.lastIndexOf(prefix, 0) === 0;
--- End diff --
using lastIndexOf will fail with this won't it?
startsWith(boomboom,boom); // false?
string.indexOf(prefix) === 0 is not only correct, but easier to understand
too
Switch to using .ratignore in cordova repositories
--
Key: CB-9109
URL: https://issues.apache.org/jira/browse/CB-9109
Project: Apache Cordova
Issue Type: Improvement
Components: Coho
Reporter: Dmitry Blotsky
Assignee: Dmitry Blotsky
Labels: coho, rat
Original Estimate: 24h
Remaining Estimate: 24h
Move from using ratExcludes in repoutils.js within COHO to using a .ratignore
file in each respective repo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9109) Switch to using .ratignore in cordova repositories
[ https://issues.apache.org/jira/browse/CB-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590492#comment-14590492 ] ASF GitHub Bot commented on CB-9109: Github user TimBarham commented on the pull request: https://github.com/apache/cordova-coho/pull/86#issuecomment-112934635 Looks good (well, apart from those blank lines you insist on adding at the beginning of blocks :smile:). Switch to using .ratignore in cordova repositories -- Key: CB-9109 URL: https://issues.apache.org/jira/browse/CB-9109 Project: Apache Cordova Issue Type: Improvement Components: Coho Reporter: Dmitry Blotsky Assignee: Dmitry Blotsky Labels: coho, rat Original Estimate: 24h Remaining Estimate: 24h Move from using ratExcludes in repoutils.js within COHO to using a .ratignore file in each respective repo. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9109) Switch to using .ratignore in cordova repositories
[
https://issues.apache.org/jira/browse/CB-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590398#comment-14590398
]
ASF GitHub Bot commented on CB-9109:
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/86#discussion_r32664301
--- Diff: src/audit-license-headers.js ---
@@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [
'*.xcworkspacedata',
'*.xccheckout',
'*.xcscheme',
-];
+];
+
+var RAT_IGNORE_PATH = '.ratignore';
+var RATIGNORE_COMMENT_PREFIX = '#';
+
+var RAT_NAME = 'apache-rat-0.10';
+var RAT_URL =
'https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.10/apache-rat-0.10-bin.tar.gz';
+
+function startsWith(string, prefix) {
+return string.lastIndexOf(prefix, 0) === 0;
+}
+
+function isComment(pattern) {
+return startsWith(pattern, RATIGNORE_COMMENT_PREFIX) ;
--- End diff --
Good call! Fixed.
Switch to using .ratignore in cordova repositories
--
Key: CB-9109
URL: https://issues.apache.org/jira/browse/CB-9109
Project: Apache Cordova
Issue Type: Improvement
Components: Coho
Reporter: Dmitry Blotsky
Assignee: Dmitry Blotsky
Labels: coho, rat
Original Estimate: 24h
Remaining Estimate: 24h
Move from using ratExcludes in repoutils.js within COHO to using a .ratignore
file in each respective repo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9109) Switch to using .ratignore in cordova repositories
[
https://issues.apache.org/jira/browse/CB-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590397#comment-14590397
]
ASF GitHub Bot commented on CB-9109:
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/86#discussion_r32664260
--- Diff: src/audit-license-headers.js ---
@@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [
'*.xcworkspacedata',
'*.xccheckout',
'*.xcscheme',
-];
+];
+
+var RAT_IGNORE_PATH = '.ratignore';
+var RATIGNORE_COMMENT_PREFIX = '#';
+
+var RAT_NAME = 'apache-rat-0.10';
+var RAT_URL =
'https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.10/apache-rat-0.10-bin.tar.gz';
+
+function startsWith(string, prefix) {
+return string.lastIndexOf(prefix, 0) === 0;
--- End diff --
Because `lastIndexOf` searches backwards, meaning that if it starts at `0`,
it will check for one occurrence and return right away. Arguably, regular
`indexOf` would be clearer though. Thoughts?
Switch to using .ratignore in cordova repositories
--
Key: CB-9109
URL: https://issues.apache.org/jira/browse/CB-9109
Project: Apache Cordova
Issue Type: Improvement
Components: Coho
Reporter: Dmitry Blotsky
Assignee: Dmitry Blotsky
Labels: coho, rat
Original Estimate: 24h
Remaining Estimate: 24h
Move from using ratExcludes in repoutils.js within COHO to using a .ratignore
file in each respective repo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9109) Switch to using .ratignore in cordova repositories
[ https://issues.apache.org/jira/browse/CB-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590870#comment-14590870 ] ASF subversion and git services commented on CB-9109: - Commit 1cb0b39eda6f76a49a798085f2433884dde024b2 in cordova-coho's branch refs/heads/master from [~dblotsky] [ https://git-wip-us.apache.org/repos/asf?p=cordova-coho.git;h=1cb0b39 ] CB-9109 Switched to using a repository's .ratignore file instead of the ratExcludes property inside of coho. Switch to using .ratignore in cordova repositories -- Key: CB-9109 URL: https://issues.apache.org/jira/browse/CB-9109 Project: Apache Cordova Issue Type: Improvement Components: Coho Reporter: Dmitry Blotsky Assignee: Dmitry Blotsky Labels: coho, rat Original Estimate: 24h Remaining Estimate: 24h Move from using ratExcludes in repoutils.js within COHO to using a .ratignore file in each respective repo. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9109) Switch to using .ratignore in cordova repositories
[ https://issues.apache.org/jira/browse/CB-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590872#comment-14590872 ] ASF GitHub Bot commented on CB-9109: Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/86 Switch to using .ratignore in cordova repositories -- Key: CB-9109 URL: https://issues.apache.org/jira/browse/CB-9109 Project: Apache Cordova Issue Type: Improvement Components: Coho Reporter: Dmitry Blotsky Assignee: Dmitry Blotsky Labels: coho, rat Original Estimate: 24h Remaining Estimate: 24h Move from using ratExcludes in repoutils.js within COHO to using a .ratignore file in each respective repo. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9109) Switch to using .ratignore in cordova repositories
[ https://issues.apache.org/jira/browse/CB-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590543#comment-14590543 ] ASF GitHub Bot commented on CB-9109: Github user stevengill commented on the pull request: https://github.com/apache/cordova-coho/pull/86#issuecomment-112943481 LGTM Switch to using .ratignore in cordova repositories -- Key: CB-9109 URL: https://issues.apache.org/jira/browse/CB-9109 Project: Apache Cordova Issue Type: Improvement Components: Coho Reporter: Dmitry Blotsky Assignee: Dmitry Blotsky Labels: coho, rat Original Estimate: 24h Remaining Estimate: 24h Move from using ratExcludes in repoutils.js within COHO to using a .ratignore file in each respective repo. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9109) Switch to using .ratignore in cordova repositories
[
https://issues.apache.org/jira/browse/CB-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590118#comment-14590118
]
ASF GitHub Bot commented on CB-9109:
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/86#discussion_r32650376
--- Diff: src/audit-license-headers.js ---
@@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [
'*.xcworkspacedata',
'*.xccheckout',
'*.xcscheme',
-];
+];
+
+var RAT_IGNORE_PATH = '.ratignore';
+var RATIGNORE_COMMENT_PREFIX = '#';
+
+var RAT_NAME = 'apache-rat-0.10';
+var RAT_URL =
'https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.10/apache-rat-0.10-bin.tar.gz';
+
+function startsWith(string, prefix) {
+return string.lastIndexOf(prefix, 0) === 0;
+}
+
+function isComment(pattern) {
+return startsWith(pattern, RATIGNORE_COMMENT_PREFIX) ;
--- End diff --
Perhaps trim leading white-space from pattern (not particularly likely in
an ignore file, but to be strictly correct)?
Switch to using .ratignore in cordova repositories
--
Key: CB-9109
URL: https://issues.apache.org/jira/browse/CB-9109
Project: Apache Cordova
Issue Type: Improvement
Components: Coho
Reporter: Dmitry Blotsky
Assignee: Dmitry Blotsky
Labels: coho, rat
Original Estimate: 24h
Remaining Estimate: 24h
Move from using ratExcludes in repoutils.js within COHO to using a .ratignore
file in each respective repo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9109) Switch to using .ratignore in cordova repositories
[
https://issues.apache.org/jira/browse/CB-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590114#comment-14590114
]
ASF GitHub Bot commented on CB-9109:
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/86#discussion_r32650218
--- Diff: src/audit-license-headers.js ---
@@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [
'*.xcworkspacedata',
'*.xccheckout',
'*.xcscheme',
-];
+];
+
+var RAT_IGNORE_PATH = '.ratignore';
+var RATIGNORE_COMMENT_PREFIX = '#';
+
+var RAT_NAME = 'apache-rat-0.10';
+var RAT_URL =
'https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.10/apache-rat-0.10-bin.tar.gz';
+
+function startsWith(string, prefix) {
+return string.lastIndexOf(prefix, 0) === 0;
--- End diff --
Why `lastIndexOf`?
Switch to using .ratignore in cordova repositories
--
Key: CB-9109
URL: https://issues.apache.org/jira/browse/CB-9109
Project: Apache Cordova
Issue Type: Improvement
Components: Coho
Reporter: Dmitry Blotsky
Assignee: Dmitry Blotsky
Labels: coho, rat
Original Estimate: 24h
Remaining Estimate: 24h
Move from using ratExcludes in repoutils.js within COHO to using a .ratignore
file in each respective repo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9109) Switch to using .ratignore in cordova repositories
[ https://issues.apache.org/jira/browse/CB-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14589175#comment-14589175 ] ASF GitHub Bot commented on CB-9109: GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-coho/pull/86 CB-9109 Switching to using .ratignores Switched to using a repository's `.ratignore` file instead of the `ratExcludes` property inside of coho. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-coho CB-9109 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/86.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #86 commit 50f99e52d40b94cd2e62bd911aab07ab2ea43d2e Author: Dmitry Blotsky dmitry.blot...@gmail.com Date: 2015-06-17T01:29:54Z CB-9109 Switched to using a repository's .ratignore file instead of the ratExcludes property inside of coho. Switch to using .ratignore in cordova repositories -- Key: CB-9109 URL: https://issues.apache.org/jira/browse/CB-9109 Project: Apache Cordova Issue Type: Improvement Components: Coho Reporter: Dmitry Blotsky Assignee: Dmitry Blotsky Labels: coho, rat Original Estimate: 24h Remaining Estimate: 24h Move from using ratExcludes in repoutils.js within COHO to using a .ratignore file in each respective repo. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
