[jira] [Commented] (CB-9163) Make engines error look less nasty
[
https://issues.apache.org/jira/browse/CB-9163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590628#comment-14590628
]
Steve Gill commented on CB-9163:
I think the bigger issue here is that this stops automated plugin install.
Cordova-lib should leave a nice warning message and skip instead of error and
exit when the supported platform version isn't available.
Make engines error look less nasty
--
Key: CB-9163
URL: https://issues.apache.org/jira/browse/CB-9163
Project: Apache Cordova
Issue Type: Bug
Components: CordovaLib, Plugin Whitelist
Environment: iOS
Reporter: Shazron Abdullah
Labels: cordova-ios-4.0.x
When installing the cordova-plugin-whitelist plugin (from master), and it
doesn't fulfill the engine requirement, you get a scary error which is
harmless.
{code}
$ cordova plugin add
https://github.com/apache/cordova-plugin-whitelist.git#master
Fetching plugin https://github.com/apache/cordova-plugin-whitelist.git; via
git clone
Repository https://github.com/apache/cordova-plugin-whitelist.git; checked
out to git ref master.
Installing cordova-plugin-whitelist for android
Installing cordova-plugin-whitelist for ios
Failed to install 'cordova-plugin-whitelist':CordovaError: Plugin doesn't
support this project's cordova-ios version. cordova-ios: 3.8.0, failed
version requirement: =4.0.0-dev
at checkEngines
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/src/plugman/install.js:119:29)
at
/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/src/plugman/install.js:296:16
at _fulfilled
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
at self.promiseDispatch.done
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
at Promise.promise.promiseDispatch
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
at
/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:557:44
at flush
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
at process._tickCallback (node.js:419:13)
Plugin doesn't support this project's cordova-ios version. cordova-ios:
3.8.0, failed version requirement: =4.0.0-dev
{code}
Change it to not have the stack-trace, and have a friendlier output. If you
have the Android platform added, it succeeds in installing it also, but not
sure if its because the platform tag appears first in plugin.xml (check).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9163) Make engines error look less nasty
[
https://issues.apache.org/jira/browse/CB-9163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590686#comment-14590686
]
ASF subversion and git services commented on CB-9163:
-
Commit d7f8ebdec56a8b92997ba0458eb31139ab608e10 in cordova-lib's branch
refs/heads/master from [~stevegill]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=d7f8ebd ]
CB-9163 when engine check isn't satisfied, skip it
Make engines error look less nasty
--
Key: CB-9163
URL: https://issues.apache.org/jira/browse/CB-9163
Project: Apache Cordova
Issue Type: Bug
Components: CordovaLib, Plugin Whitelist
Environment: iOS
Reporter: Shazron Abdullah
Labels: cordova-ios-4.0.x
When installing the cordova-plugin-whitelist plugin (from master), and it
doesn't fulfill the engine requirement, you get a scary error which is
harmless.
{code}
$ cordova plugin add
https://github.com/apache/cordova-plugin-whitelist.git#master
Fetching plugin https://github.com/apache/cordova-plugin-whitelist.git; via
git clone
Repository https://github.com/apache/cordova-plugin-whitelist.git; checked
out to git ref master.
Installing cordova-plugin-whitelist for android
Installing cordova-plugin-whitelist for ios
Failed to install 'cordova-plugin-whitelist':CordovaError: Plugin doesn't
support this project's cordova-ios version. cordova-ios: 3.8.0, failed
version requirement: =4.0.0-dev
at checkEngines
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/src/plugman/install.js:119:29)
at
/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/src/plugman/install.js:296:16
at _fulfilled
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
at self.promiseDispatch.done
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
at Promise.promise.promiseDispatch
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
at
/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:557:44
at flush
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
at process._tickCallback (node.js:419:13)
Plugin doesn't support this project's cordova-ios version. cordova-ios:
3.8.0, failed version requirement: =4.0.0-dev
{code}
Change it to not have the stack-trace, and have a friendlier output. If you
have the Android platform added, it succeeds in installing it also, but not
sure if its because the platform tag appears first in plugin.xml (check).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9163) Make engines error look less nasty
[
https://issues.apache.org/jira/browse/CB-9163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590708#comment-14590708
]
ASF subversion and git services commented on CB-9163:
-
Commit b6727ba9e465a733ce07ac222b17b46ab975f714 in cordova-lib's branch
refs/heads/master from [~stevegill]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=b6727ba ]
CB-9163 fixed failing tests
Make engines error look less nasty
--
Key: CB-9163
URL: https://issues.apache.org/jira/browse/CB-9163
Project: Apache Cordova
Issue Type: Bug
Components: CordovaLib, Plugin Whitelist
Environment: iOS
Reporter: Shazron Abdullah
Labels: cordova-ios-4.0.x
When installing the cordova-plugin-whitelist plugin (from master), and it
doesn't fulfill the engine requirement, you get a scary error which is
harmless.
{code}
$ cordova plugin add
https://github.com/apache/cordova-plugin-whitelist.git#master
Fetching plugin https://github.com/apache/cordova-plugin-whitelist.git; via
git clone
Repository https://github.com/apache/cordova-plugin-whitelist.git; checked
out to git ref master.
Installing cordova-plugin-whitelist for android
Installing cordova-plugin-whitelist for ios
Failed to install 'cordova-plugin-whitelist':CordovaError: Plugin doesn't
support this project's cordova-ios version. cordova-ios: 3.8.0, failed
version requirement: =4.0.0-dev
at checkEngines
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/src/plugman/install.js:119:29)
at
/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/src/plugman/install.js:296:16
at _fulfilled
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
at self.promiseDispatch.done
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
at Promise.promise.promiseDispatch
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
at
/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:557:44
at flush
(/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
at process._tickCallback (node.js:419:13)
Plugin doesn't support this project's cordova-ios version. cordova-ios:
3.8.0, failed version requirement: =4.0.0-dev
{code}
Change it to not have the stack-trace, and have a friendlier output. If you
have the Android platform added, it succeeds in installing it also, but not
sure if its because the platform tag appears first in plugin.xml (check).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
