Pavel Shevchuk created CB-12080: ----------------------------------- Summary: Only add WRITE_EXTERNAL_STORAGE when listing sdcard in AndroidExtraFilesystems Key: CB-12080 URL: https://issues.apache.org/jira/browse/CB-12080 Project: Apache Cordova Issue Type: Improvement Components: Plugin File Affects Versions: 4.3.0 Environment: Android Reporter: Pavel Shevchuk Priority: Minor
WRITE_EXTERNAL_STORAGE permission is listed as dangerous according to latest Android SDK documentation: https://developer.android.com/reference/android/Manifest.permission.html#WRITE_EXTERNAL_STORAGE cordova-plugin-file only needs it for sdcard ExtraFilesystem, according to Cordova docs: https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-file/#configuring-the-plugin-optional Yet plugin.xml adds the permission to AndroidManifest unconditionally, even when i specify only harmless ExtraFilesystems in application's config.xml: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=blob;f=plugin.xml;h=aba8feedd7493059922d252a4dec25a02b6bf532;hb=HEAD#l134 I'd prefer the plugin to only add dangerous permissions when explicitly including sdcard ExtraFilesystem. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org