[jira] [Comment Edited] (CXF-7738) Binding with two version of soap is not working

2018-05-16 Thread pankajjoshi (JIRA)

[ 
https://issues.apache.org/jira/browse/CXF-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477624#comment-16477624
 ] 

pankajjoshi edited comment on CXF-7738 at 5/16/18 6:04 PM:
---

[~coheigea] Yes The WSDL generated by CXF via wsdl publish and the version of 
cxf we using is 3.1.12. I feel (but not sure) this application is deployed on 
java 8. Do you think this feature has not been supported in Java 8? 

As i said we have both version of soap in one single wsdl and when someone 
pulls the wsdl address, the absolute path for second is not coming. Only 
relative path is coming.

If i restrict my wsdl to only soap1.1 then works ok. Which means keeping one 
soap version at time works for us not both at single instance. I hope i am able 
to provide all the information required. Thanks


was (Author: pankajmkjoshi):
[~coheigea] Yes The WSDL generated by CXF via wsdl publish and the version of 
cxf we using is 3.1.12. I feel (but not sure) this application is deployed on 
java 8. Do you think this feature has not been supported in Java 8?

 

As i said we both version of soap in one single wsdl and when some one pulls 
the wsdl address the absolute path for second is not coming. Only relative path 
is coming.

If i restrict my wsdl to only soap1.1 then all works ok. I hope i am able to 
provide all the information required. Thanks

> Binding with two version of soap is not working 
> 
>
> Key: CXF-7738
> URL: https://issues.apache.org/jira/browse/CXF-7738
> Project: CXF
>  Issue Type: Bug
>Reporter: pankajjoshi
>Priority: Blocker
>
> I have two biding in one of my wsdl, one for soap11 and one for soap12. When 
> i am using this wsdl and placing in soapUI,i dont see the absolute path for 
> soap 11. It only have relative path. But soap12 works fine with its absolute 
> path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FEDIZ-217) SAML authentication fails in plugin

2018-05-16 Thread Colm O hEigeartaigh (JIRA)

[ 
https://issues.apache.org/jira/browse/FEDIZ-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477718#comment-16477718
 ] 

Colm O hEigeartaigh commented on FEDIZ-217:
---

Incidentally, an additional fix was required to the Tomcat authenticator to get 
it to work with SAML SSO (it was hard-coded to select the WS-Federation 
parameter 'wctx' instead of 'RelayState'). I've added a bunch of tests for the 
plugin now and it seems to be working OK. Please grab the latest source and 
test it to see if it works against Okta!

> SAML authentication fails in plugin
> ---
>
> Key: FEDIZ-217
> URL: https://issues.apache.org/jira/browse/FEDIZ-217
> Project: CXF-Fediz
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 1.4.3
>Reporter: Arnaud MERGEY
>Assignee: Colm O hEigeartaigh
>Priority: Major
> Fix For: 1.4.4
>
>
> On a tomcat hosting a SP application trying to authenticate against a SAML 
> IDP (OKTA)
>  authentication fails with this log:
> May 11, 2018 11:22:14 AM 
> org.apache.cxf.fediz.core.processor.SAMLProcessorImpl processRelayState 
>  SEVERE: Missing Request State 
>  May 11, 2018 11:22:14 AM org.apache.cxf.fediz.core.handler.SigninHandler 
> handleRequest 
>  SEVERE: Federation processing failed: The request was invalid or malformed
> I checked in the code and it fails because request state in 
> org.apache.cxf.fediz.core.processor.FedizRequest is null, but it seems with 
> SAML protocol 
> org.apache.cxf.fediz.core.processor.FedizRequest.setRequestState(RequestState)
>  is never called, so I am wondering how it can be different from null and I 
> suspect a bug
> I manage to patch fediz to have it working, I could propose a Pull request 
> for this if required
> Additionally to OKTA I also tried with samling for a simple test setup, same 
> error
>  
> {code:java}
>  
>      
>      
> http://localhost:8080/myApp/ 
>      
>     
>      
>      type="JKS" /> 
>      
>      
>      
>      
>      
>     http://www.w3.org/2001/XMLSchema-instance"; 
> xsi:type="samlProtocolType" version="2.0"> 
> true
> true
> https://capriza.github.io/samling/samling.html 
>     groups 
>      
>      
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CXF-7738) Binding with two version of soap is not working

2018-05-16 Thread pankajjoshi (JIRA)

[ 
https://issues.apache.org/jira/browse/CXF-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477624#comment-16477624
 ] 

pankajjoshi commented on CXF-7738:
--

[~coheigea] Yes The WSDL generated by CXF via wsdl publish and the version of 
cxf we using is 3.1.12. I feel (but not sure) this application is deployed on 
java 8. Do you think this feature has not been supported in Java 8?

 

As i said we both version of soap in one single wsdl and when some one pulls 
the wsdl address the absolute path for second is not coming. Only relative path 
is coming.

If i restrict my wsdl to only soap1.1 then all works ok. I hope i am able to 
provide all the information required. Thanks

> Binding with two version of soap is not working 
> 
>
> Key: CXF-7738
> URL: https://issues.apache.org/jira/browse/CXF-7738
> Project: CXF
>  Issue Type: Bug
>Reporter: pankajjoshi
>Priority: Blocker
>
> I have two biding in one of my wsdl, one for soap11 and one for soap12. When 
> i am using this wsdl and placing in soapUI,i dont see the absolute path for 
> soap 11. It only have relative path. But soap12 works fine with its absolute 
> path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (CXF-7738) Binding with two version of soap is not working

2018-05-16 Thread pankajjoshi (JIRA)

[ 
https://issues.apache.org/jira/browse/CXF-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469698#comment-16469698
 ] 

pankajjoshi edited comment on CXF-7738 at 5/16/18 3:51 PM:
---


 
 http://localhost:8081/blahblah/services/service/2009-12-20/taxservice"/>
 
 
 
 
 


was (Author: pankajmkjoshi):

 
 http://localhost:8081/sabrix/services/taxservice/2009-12-20/taxservice"/>
 
 
 
 


> Binding with two version of soap is not working 
> 
>
> Key: CXF-7738
> URL: https://issues.apache.org/jira/browse/CXF-7738
> Project: CXF
>  Issue Type: Bug
>Reporter: pankajjoshi
>Priority: Blocker
>
> I have two biding in one of my wsdl, one for soap11 and one for soap12. When 
> i am using this wsdl and placing in soapUI,i dont see the absolute path for 
> soap 11. It only have relative path. But soap12 works fine with its absolute 
> path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (FEDIZ-217) SAML authentication fails in plugin

2018-05-16 Thread Colm O hEigeartaigh (JIRA)

 [ 
https://issues.apache.org/jira/browse/FEDIZ-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh resolved FEDIZ-217.
---
Resolution: Fixed

> SAML authentication fails in plugin
> ---
>
> Key: FEDIZ-217
> URL: https://issues.apache.org/jira/browse/FEDIZ-217
> Project: CXF-Fediz
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 1.4.3
>Reporter: Arnaud MERGEY
>Assignee: Colm O hEigeartaigh
>Priority: Major
> Fix For: 1.4.4
>
>
> On a tomcat hosting a SP application trying to authenticate against a SAML 
> IDP (OKTA)
>  authentication fails with this log:
> May 11, 2018 11:22:14 AM 
> org.apache.cxf.fediz.core.processor.SAMLProcessorImpl processRelayState 
>  SEVERE: Missing Request State 
>  May 11, 2018 11:22:14 AM org.apache.cxf.fediz.core.handler.SigninHandler 
> handleRequest 
>  SEVERE: Federation processing failed: The request was invalid or malformed
> I checked in the code and it fails because request state in 
> org.apache.cxf.fediz.core.processor.FedizRequest is null, but it seems with 
> SAML protocol 
> org.apache.cxf.fediz.core.processor.FedizRequest.setRequestState(RequestState)
>  is never called, so I am wondering how it can be different from null and I 
> suspect a bug
> I manage to patch fediz to have it working, I could propose a Pull request 
> for this if required
> Additionally to OKTA I also tried with samling for a simple test setup, same 
> error
>  
> {code:java}
>  
>      
>      
> http://localhost:8080/myApp/ 
>      
>     
>      
>      type="JKS" /> 
>      
>      
>      
>      
>      
>     http://www.w3.org/2001/XMLSchema-instance"; 
> xsi:type="samlProtocolType" version="2.0"> 
> true
> true
> https://capriza.github.io/samling/samling.html 
>     groups 
>      
>      
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FEDIZ-217) SAML authentication fails in plugin

2018-05-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/FEDIZ-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477395#comment-16477395
 ] 

ASF GitHub Bot commented on FEDIZ-217:
--

coheigea closed pull request #27: [FEDIZ-217] Fix SAML authentication in Plugin
URL: https://github.com/apache/cxf-fediz/pull/27
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/plugins/core/src/main/java/org/apache/cxf/fediz/core/FederationConstants.java 
b/plugins/core/src/main/java/org/apache/cxf/fediz/core/FederationConstants.java
index 6839ff50..88bd2730 100644
--- 
a/plugins/core/src/main/java/org/apache/cxf/fediz/core/FederationConstants.java
+++ 
b/plugins/core/src/main/java/org/apache/cxf/fediz/core/FederationConstants.java
@@ -150,6 +150,12 @@
  * element.
  */
 public static final String PARAM_RESULT_PTR = "wresultptr";
+
+/**
+ * This OPTIONAL session attribute prefix append to request RelayState 
value specifies 
+ * initial RequestState created before redirecting to IDP
+ */
+public static final String SESSION_SAVED_REQUEST_STATE_PREFIX = 
"SAVED_REQUEST_STATE_";
 
 public static final Map AUTH_TYPE_MAP;
 static {
diff --git 
a/plugins/core/src/main/java/org/apache/cxf/fediz/core/handler/SigninHandler.java
 
b/plugins/core/src/main/java/org/apache/cxf/fediz/core/handler/SigninHandler.java
index 31aefcd0..125e9fc9 100644
--- 
a/plugins/core/src/main/java/org/apache/cxf/fediz/core/handler/SigninHandler.java
+++ 
b/plugins/core/src/main/java/org/apache/cxf/fediz/core/handler/SigninHandler.java
@@ -23,8 +23,10 @@
 
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
+import javax.servlet.http.HttpSession;
 
 import org.apache.cxf.fediz.core.FederationConstants;
+import org.apache.cxf.fediz.core.RequestState;
 import org.apache.cxf.fediz.core.SAMLSSOConstants;
 import org.apache.cxf.fediz.core.config.FederationProtocol;
 import org.apache.cxf.fediz.core.config.FedizContext;
@@ -101,13 +103,22 @@ public FedizResponse processSigninRequest(String 
responseToken, HttpServletReque
 FedizRequest federationRequest = new FedizRequest();
 
 String wa = req.getParameter(FederationConstants.PARAM_ACTION);
+
+String relayState = req.getParameter("RelayState");
 
 federationRequest.setAction(wa);
 federationRequest.setResponseToken(responseToken);
-federationRequest.setState(req.getParameter("RelayState"));
+federationRequest.setState(relayState);
 federationRequest.setRequest(req);
 
federationRequest.setCerts((X509Certificate[])req.getAttribute("javax.servlet.request.X509Certificate"));
 
+if (relayState != null) {
+HttpSession session = req.getSession();
+federationRequest.setRequestState((RequestState) 
+ 
session.getAttribute(FederationConstants.SESSION_SAVED_REQUEST_STATE_PREFIX + 
relayState));
+
session.removeAttribute(FederationConstants.SESSION_SAVED_REQUEST_STATE_PREFIX 
+ relayState);
+}
+
 FedizProcessor processor = 
FedizProcessorFactory.newFedizProcessor(fedizContext.getProtocol());
 return processor.processRequest(federationRequest, fedizContext);
 }
diff --git 
a/plugins/core/src/main/java/org/apache/cxf/fediz/core/processor/SAMLProcessorImpl.java
 
b/plugins/core/src/main/java/org/apache/cxf/fediz/core/processor/SAMLProcessorImpl.java
index fc227e16..6f8d167a 100644
--- 
a/plugins/core/src/main/java/org/apache/cxf/fediz/core/processor/SAMLProcessorImpl.java
+++ 
b/plugins/core/src/main/java/org/apache/cxf/fediz/core/processor/SAMLProcessorImpl.java
@@ -134,6 +134,7 @@ protected FedizResponse processSignInRequest(
 tokenStream = CompressionUtils.inflate(deflatedToken);
 }
 } catch (DataFormatException ex) {
+LOG.warn("Invalid data format", ex);
 throw new ProcessingException(TYPE.INVALID_REQUEST);
 }
 
@@ -144,7 +145,7 @@ protected FedizResponse processSignInRequest(
 el = doc.getDocumentElement();
 
 } catch (Exception e) {
-LOG.warn("Failed to parse token: " + e.getMessage());
+LOG.warn("Failed to parse token", e);
 throw new ProcessingException(TYPE.INVALID_REQUEST);
 }
 
diff --git 
a/plugins/tomcat8/src/main/java/org/apache/cxf/fediz/tomcat8/FederationAuthenticator.java
 
b/plugins/tomcat8/src/main/java/org/apache/cxf/fediz/tomcat8/FederationAuthenticator.java
index 1acd5514..ff92c695 100644
--- 
a/plugins/tomcat8/src/main/java/org/apache/cxf/fediz/tomcat8/FederationAuthenticator.java
+++ 
b/plugins/tomcat8/src/main

[jira] [Assigned] (FEDIZ-217) SAML authentication fails in plugin

2018-05-16 Thread Colm O hEigeartaigh (JIRA)

 [ 
https://issues.apache.org/jira/browse/FEDIZ-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh reassigned FEDIZ-217:
-

Assignee: Colm O hEigeartaigh

> SAML authentication fails in plugin
> ---
>
> Key: FEDIZ-217
> URL: https://issues.apache.org/jira/browse/FEDIZ-217
> Project: CXF-Fediz
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 1.4.3
>Reporter: Arnaud MERGEY
>Assignee: Colm O hEigeartaigh
>Priority: Major
> Fix For: 1.4.4
>
>
> On a tomcat hosting a SP application trying to authenticate against a SAML 
> IDP (OKTA)
>  authentication fails with this log:
> May 11, 2018 11:22:14 AM 
> org.apache.cxf.fediz.core.processor.SAMLProcessorImpl processRelayState 
>  SEVERE: Missing Request State 
>  May 11, 2018 11:22:14 AM org.apache.cxf.fediz.core.handler.SigninHandler 
> handleRequest 
>  SEVERE: Federation processing failed: The request was invalid or malformed
> I checked in the code and it fails because request state in 
> org.apache.cxf.fediz.core.processor.FedizRequest is null, but it seems with 
> SAML protocol 
> org.apache.cxf.fediz.core.processor.FedizRequest.setRequestState(RequestState)
>  is never called, so I am wondering how it can be different from null and I 
> suspect a bug
> I manage to patch fediz to have it working, I could propose a Pull request 
> for this if required
> Additionally to OKTA I also tried with samling for a simple test setup, same 
> error
>  
> {code:java}
>  
>      
>      
> http://localhost:8080/myApp/ 
>      
>     
>      
>      type="JKS" /> 
>      
>      
>      
>      
>      
>     http://www.w3.org/2001/XMLSchema-instance"; 
> xsi:type="samlProtocolType" version="2.0"> 
> true
> true
> https://capriza.github.io/samling/samling.html 
>     groups 
>      
>      
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (FEDIZ-217) SAML authentication fails in plugin

2018-05-16 Thread Colm O hEigeartaigh (JIRA)

 [ 
https://issues.apache.org/jira/browse/FEDIZ-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh updated FEDIZ-217:
--
Fix Version/s: 1.4.4

> SAML authentication fails in plugin
> ---
>
> Key: FEDIZ-217
> URL: https://issues.apache.org/jira/browse/FEDIZ-217
> Project: CXF-Fediz
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 1.4.3
>Reporter: Arnaud MERGEY
>Assignee: Colm O hEigeartaigh
>Priority: Major
> Fix For: 1.4.4
>
>
> On a tomcat hosting a SP application trying to authenticate against a SAML 
> IDP (OKTA)
>  authentication fails with this log:
> May 11, 2018 11:22:14 AM 
> org.apache.cxf.fediz.core.processor.SAMLProcessorImpl processRelayState 
>  SEVERE: Missing Request State 
>  May 11, 2018 11:22:14 AM org.apache.cxf.fediz.core.handler.SigninHandler 
> handleRequest 
>  SEVERE: Federation processing failed: The request was invalid or malformed
> I checked in the code and it fails because request state in 
> org.apache.cxf.fediz.core.processor.FedizRequest is null, but it seems with 
> SAML protocol 
> org.apache.cxf.fediz.core.processor.FedizRequest.setRequestState(RequestState)
>  is never called, so I am wondering how it can be different from null and I 
> suspect a bug
> I manage to patch fediz to have it working, I could propose a Pull request 
> for this if required
> Additionally to OKTA I also tried with samling for a simple test setup, same 
> error
>  
> {code:java}
>  
>      
>      
> http://localhost:8080/myApp/ 
>      
>     
>      
>      type="JKS" /> 
>      
>      
>      
>      
>      
>     http://www.w3.org/2001/XMLSchema-instance"; 
> xsi:type="samlProtocolType" version="2.0"> 
> true
> true
> https://capriza.github.io/samling/samling.html 
>     groups 
>      
>      
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CXF-7736) DispatchImpl doesn't work for an empty Source

2018-05-16 Thread Colm O hEigeartaigh (JIRA)

 [ 
https://issues.apache.org/jira/browse/CXF-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh resolved CXF-7736.
--
Resolution: Fixed

> DispatchImpl doesn't work for an empty Source
> -
>
> Key: CXF-7736
> URL: https://issues.apache.org/jira/browse/CXF-7736
> Project: CXF
>  Issue Type: Bug
>  Components: JAX-WS Runtime
>Affects Versions: 3.1.15, 3.2.4
>Reporter: Jim Ma
>Assignee: Jim Ma
>Priority: Major
> Fix For: 3.1.16, 3.2.5
>
>
> After CXF-7653,  Dispatchimpl can't return a null value result from an empty 
> source like : 
>  @WebServiceProvider(serviceName = "HelloProviderService", 
>  portName = "HelloProviderPort", 
>  targetNamespace = "http://apache.org/hello_world_xml_http/bare";)
>  @BindingType(value = javax.xml.ws.soap.SOAPBinding.SOAP11HTTP_BINDING)
>  @ServiceMode(value = javax.xml.ws.Service.Mode.PAYLOAD)
>  public class GreeterProvider implements Provider {
> public Source invoke(Source req) {
>return new StreamSource();
> }
>  }
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CXF-7738) Binding with two version of soap is not working

2018-05-16 Thread Colm O hEigeartaigh (JIRA)

[ 
https://issues.apache.org/jira/browse/CXF-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477203#comment-16477203
 ] 

Colm O hEigeartaigh commented on CXF-7738:
--

We need more information to diagnose what the problem is. You've mentioned a 
WSDL and SOAP-UI, how does CXF fit into this? Is it a WSDL generated by CXF via 
wsdl publish (?wsdl at the end of the endpoint address)? If so what version of 
CXF?

> Binding with two version of soap is not working 
> 
>
> Key: CXF-7738
> URL: https://issues.apache.org/jira/browse/CXF-7738
> Project: CXF
>  Issue Type: Bug
>Reporter: pankajjoshi
>Priority: Blocker
>
> I have two biding in one of my wsdl, one for soap11 and one for soap12. When 
> i am using this wsdl and placing in soapUI,i dont see the absolute path for 
> soap 11. It only have relative path. But soap12 works fine with its absolute 
> path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CXF-7740) add NPE guard for SAAJStreamWriter

2018-05-16 Thread Freeman Fang (JIRA)

 [ 
https://issues.apache.org/jira/browse/CXF-7740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Freeman Fang resolved CXF-7740.
---
   Resolution: Fixed
Fix Version/s: 3.2.5
   3.1.16

> add NPE guard for SAAJStreamWriter
> --
>
> Key: CXF-7740
> URL: https://issues.apache.org/jira/browse/CXF-7740
> Project: CXF
>  Issue Type: Bug
>Reporter: Freeman Fang
>Assignee: Freeman Fang
>Priority: Major
> Fix For: 3.1.16, 3.2.5
>
>
> to avoid NPE like
> {code}
> java.lang.NullPointerException
>     at 
> com.sun.org.apache.xerces.internal.dom.ParentNode.internalRemoveChild(ParentNode.java:542)[:1.8.0_161]
>     at 
> com.sun.org.apache.xerces.internal.dom.ParentNode.removeChild(ParentNode.java:484)[:1.8.0_161]
>     at 
> org.apache.cxf.binding.soap.saaj.SAAJStreamWriter.createAndAddElement(SAAJStreamWriter.java:137)[78:org.apache.cxf.cxf-rt-bindings-soap:3.1.5]
>     at 
> org.apache.cxf.staxutils.W3CDOMStreamWriter.writeStartElement(W3CDOMStreamWriter.java:143)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.staxutils.OverlayW3CDOMStreamWriter.writeStartElement(OverlayW3CDOMStreamWriter.java:210)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.staxutils.StaxUtils.writeStartElement(StaxUtils.java:811)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.staxutils.StaxUtils.copy(StaxUtils.java:738)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.staxutils.StaxUtils.copy(StaxUtils.java:702)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.staxutils.StaxUtils.copy(StaxUtils.java:626)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.databinding.source.XMLStreamDataWriter.write(XMLStreamDataWriter.java:111)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.databinding.source.XMLStreamDataWriter.write(XMLStreamDataWriter.java:65)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.camel.component.cxf.HybridSourceDataBinding$1.write(HybridSourceDataBinding.java:80)[240:org.apache.camel.camel-cxf:2.17.0]
>     at 
> org.apache.camel.component.cxf.HybridSourceDataBinding$1.write(HybridSourceDataBinding.java:74)[240:org.apache.camel.camel-cxf:2.17.0]
>     at 
> org.apache.cxf.interceptor.AbstractOutDatabindingInterceptor.writeParts(AbstractOutDatabindingInterceptor.java:137)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.wsdl.interceptors.BareOutInterceptor.handleMessage(BareOutInterceptor.java:68)[75:org.apache.cxf.cxf-rt-wsdl:3.1.5]
>     at 
> org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.endpoint.ClientImpl.doInvoke(ClientImpl.java:514)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.endpoint.ClientImpl.invoke(ClientImpl.java:416)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.camel.component.cxf.CxfProducer.process(CxfProducer.java:120)[240:org.apache.camel.camel-cxf:2.17.0]
>     at 
> org.apache.camel.processor.SendProcessor.process(SendProcessor.java:145)[231:org.apache.camel.camel-core:2.17.0]
>     at 
> org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:77)[231:org.apache.camel.camel-core:2.17.0]
>     at 
> org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:468)[231:org.apache.camel.camel-core:2.17.0]
>     at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:196)[231:org.apache.camel.camel-core:2.17.0]
>     at 
> org.apache.camel.processor.Pipeline.process(Pipeline.java:121)[231:org.apache.camel.camel-core:2.17.0]
>     at 
> org.apache.camel.processor.Pipeline.process(Pipeline.java:83)[231:org.apache.camel.camel-core:2.17.0]
>     at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:196)[231:org.apache.camel.camel-core:2.17.0]
>     at 
> org.apache.camel.component.timer.TimerConsumer.sendTimerExchange(TimerConsumer.java:192)[231:org.apache.camel.camel-core:2.17.0]
>     at 
> org.apache.camel.component.timer.TimerConsumer$1.run(TimerConsumer.java:76)[231:org.apache.camel.camel-core:2.17.0]
>     at java.util.TimerThread.mainLoop(Timer.java:555)[:1.8.0_161]
>     at java.util.TimerThread.run(Timer.java:505)[:1.8.0_161]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (CXF-7740) add NPE guard for SAAJStreamWriter

2018-05-16 Thread Freeman Fang (JIRA)

 [ 
https://issues.apache.org/jira/browse/CXF-7740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Freeman Fang reassigned CXF-7740:
-

Assignee: Freeman Fang

> add NPE guard for SAAJStreamWriter
> --
>
> Key: CXF-7740
> URL: https://issues.apache.org/jira/browse/CXF-7740
> Project: CXF
>  Issue Type: Bug
>Reporter: Freeman Fang
>Assignee: Freeman Fang
>Priority: Major
>
> to avoid NPE like
> {code}
> java.lang.NullPointerException
>     at 
> com.sun.org.apache.xerces.internal.dom.ParentNode.internalRemoveChild(ParentNode.java:542)[:1.8.0_161]
>     at 
> com.sun.org.apache.xerces.internal.dom.ParentNode.removeChild(ParentNode.java:484)[:1.8.0_161]
>     at 
> org.apache.cxf.binding.soap.saaj.SAAJStreamWriter.createAndAddElement(SAAJStreamWriter.java:137)[78:org.apache.cxf.cxf-rt-bindings-soap:3.1.5]
>     at 
> org.apache.cxf.staxutils.W3CDOMStreamWriter.writeStartElement(W3CDOMStreamWriter.java:143)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.staxutils.OverlayW3CDOMStreamWriter.writeStartElement(OverlayW3CDOMStreamWriter.java:210)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.staxutils.StaxUtils.writeStartElement(StaxUtils.java:811)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.staxutils.StaxUtils.copy(StaxUtils.java:738)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.staxutils.StaxUtils.copy(StaxUtils.java:702)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.staxutils.StaxUtils.copy(StaxUtils.java:626)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.databinding.source.XMLStreamDataWriter.write(XMLStreamDataWriter.java:111)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.databinding.source.XMLStreamDataWriter.write(XMLStreamDataWriter.java:65)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.camel.component.cxf.HybridSourceDataBinding$1.write(HybridSourceDataBinding.java:80)[240:org.apache.camel.camel-cxf:2.17.0]
>     at 
> org.apache.camel.component.cxf.HybridSourceDataBinding$1.write(HybridSourceDataBinding.java:74)[240:org.apache.camel.camel-cxf:2.17.0]
>     at 
> org.apache.cxf.interceptor.AbstractOutDatabindingInterceptor.writeParts(AbstractOutDatabindingInterceptor.java:137)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.wsdl.interceptors.BareOutInterceptor.handleMessage(BareOutInterceptor.java:68)[75:org.apache.cxf.cxf-rt-wsdl:3.1.5]
>     at 
> org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.endpoint.ClientImpl.doInvoke(ClientImpl.java:514)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.cxf.endpoint.ClientImpl.invoke(ClientImpl.java:416)[72:org.apache.cxf.cxf-core:3.1.5]
>     at 
> org.apache.camel.component.cxf.CxfProducer.process(CxfProducer.java:120)[240:org.apache.camel.camel-cxf:2.17.0]
>     at 
> org.apache.camel.processor.SendProcessor.process(SendProcessor.java:145)[231:org.apache.camel.camel-core:2.17.0]
>     at 
> org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:77)[231:org.apache.camel.camel-core:2.17.0]
>     at 
> org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:468)[231:org.apache.camel.camel-core:2.17.0]
>     at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:196)[231:org.apache.camel.camel-core:2.17.0]
>     at 
> org.apache.camel.processor.Pipeline.process(Pipeline.java:121)[231:org.apache.camel.camel-core:2.17.0]
>     at 
> org.apache.camel.processor.Pipeline.process(Pipeline.java:83)[231:org.apache.camel.camel-core:2.17.0]
>     at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:196)[231:org.apache.camel.camel-core:2.17.0]
>     at 
> org.apache.camel.component.timer.TimerConsumer.sendTimerExchange(TimerConsumer.java:192)[231:org.apache.camel.camel-core:2.17.0]
>     at 
> org.apache.camel.component.timer.TimerConsumer$1.run(TimerConsumer.java:76)[231:org.apache.camel.camel-core:2.17.0]
>     at java.util.TimerThread.mainLoop(Timer.java:555)[:1.8.0_161]
>     at java.util.TimerThread.run(Timer.java:505)[:1.8.0_161]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CXF-7740) add NPE guard for SAAJStreamWriter

2018-05-16 Thread Freeman Fang (JIRA)
Freeman Fang created CXF-7740:
-

 Summary: add NPE guard for SAAJStreamWriter
 Key: CXF-7740
 URL: https://issues.apache.org/jira/browse/CXF-7740
 Project: CXF
  Issue Type: Bug
Reporter: Freeman Fang


to avoid NPE like

{code}

java.lang.NullPointerException
    at 
com.sun.org.apache.xerces.internal.dom.ParentNode.internalRemoveChild(ParentNode.java:542)[:1.8.0_161]
    at 
com.sun.org.apache.xerces.internal.dom.ParentNode.removeChild(ParentNode.java:484)[:1.8.0_161]
    at 
org.apache.cxf.binding.soap.saaj.SAAJStreamWriter.createAndAddElement(SAAJStreamWriter.java:137)[78:org.apache.cxf.cxf-rt-bindings-soap:3.1.5]
    at 
org.apache.cxf.staxutils.W3CDOMStreamWriter.writeStartElement(W3CDOMStreamWriter.java:143)[72:org.apache.cxf.cxf-core:3.1.5]
    at 
org.apache.cxf.staxutils.OverlayW3CDOMStreamWriter.writeStartElement(OverlayW3CDOMStreamWriter.java:210)[72:org.apache.cxf.cxf-core:3.1.5]
    at 
org.apache.cxf.staxutils.StaxUtils.writeStartElement(StaxUtils.java:811)[72:org.apache.cxf.cxf-core:3.1.5]
    at 
org.apache.cxf.staxutils.StaxUtils.copy(StaxUtils.java:738)[72:org.apache.cxf.cxf-core:3.1.5]
    at 
org.apache.cxf.staxutils.StaxUtils.copy(StaxUtils.java:702)[72:org.apache.cxf.cxf-core:3.1.5]
    at 
org.apache.cxf.staxutils.StaxUtils.copy(StaxUtils.java:626)[72:org.apache.cxf.cxf-core:3.1.5]
    at 
org.apache.cxf.databinding.source.XMLStreamDataWriter.write(XMLStreamDataWriter.java:111)[72:org.apache.cxf.cxf-core:3.1.5]
    at 
org.apache.cxf.databinding.source.XMLStreamDataWriter.write(XMLStreamDataWriter.java:65)[72:org.apache.cxf.cxf-core:3.1.5]
    at 
org.apache.camel.component.cxf.HybridSourceDataBinding$1.write(HybridSourceDataBinding.java:80)[240:org.apache.camel.camel-cxf:2.17.0]
    at 
org.apache.camel.component.cxf.HybridSourceDataBinding$1.write(HybridSourceDataBinding.java:74)[240:org.apache.camel.camel-cxf:2.17.0]
    at 
org.apache.cxf.interceptor.AbstractOutDatabindingInterceptor.writeParts(AbstractOutDatabindingInterceptor.java:137)[72:org.apache.cxf.cxf-core:3.1.5]
    at 
org.apache.cxf.wsdl.interceptors.BareOutInterceptor.handleMessage(BareOutInterceptor.java:68)[75:org.apache.cxf.cxf-rt-wsdl:3.1.5]
    at 
org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)[72:org.apache.cxf.cxf-core:3.1.5]
    at 
org.apache.cxf.endpoint.ClientImpl.doInvoke(ClientImpl.java:514)[72:org.apache.cxf.cxf-core:3.1.5]
    at 
org.apache.cxf.endpoint.ClientImpl.invoke(ClientImpl.java:416)[72:org.apache.cxf.cxf-core:3.1.5]
    at 
org.apache.camel.component.cxf.CxfProducer.process(CxfProducer.java:120)[240:org.apache.camel.camel-cxf:2.17.0]
    at 
org.apache.camel.processor.SendProcessor.process(SendProcessor.java:145)[231:org.apache.camel.camel-core:2.17.0]
    at 
org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:77)[231:org.apache.camel.camel-core:2.17.0]
    at 
org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:468)[231:org.apache.camel.camel-core:2.17.0]
    at 
org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:196)[231:org.apache.camel.camel-core:2.17.0]
    at 
org.apache.camel.processor.Pipeline.process(Pipeline.java:121)[231:org.apache.camel.camel-core:2.17.0]
    at 
org.apache.camel.processor.Pipeline.process(Pipeline.java:83)[231:org.apache.camel.camel-core:2.17.0]
    at 
org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:196)[231:org.apache.camel.camel-core:2.17.0]
    at 
org.apache.camel.component.timer.TimerConsumer.sendTimerExchange(TimerConsumer.java:192)[231:org.apache.camel.camel-core:2.17.0]
    at 
org.apache.camel.component.timer.TimerConsumer$1.run(TimerConsumer.java:76)[231:org.apache.camel.camel-core:2.17.0]
    at java.util.TimerThread.mainLoop(Timer.java:555)[:1.8.0_161]
    at java.util.TimerThread.run(Timer.java:505)[:1.8.0_161]



{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)