[jira] [Commented] (CXF-7891) OpenApiAutoConfiguration doesn't work with classes-scan-packages

2018-11-06 Thread Andriy Redko (JIRA)


[ 
https://issues.apache.org/jira/browse/CXF-7891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676858#comment-16676858
 ] 

Andriy Redko commented on CXF-7891:
---

Hi [~deki],

Thanks a lot for finding that. Yes, I think 
@ConditionalOnClass(OpenApiFeature.class) it the safe change, the 
post-processor would be able to properly assign the customizer instance to the 
beans. Thanks!

Best Regards,
    Andriy Redko

> OpenApiAutoConfiguration doesn't work with classes-scan-packages
> 
>
> Key: CXF-7891
> URL: https://issues.apache.org/jira/browse/CXF-7891
> Project: CXF
>  Issue Type: Bug
>Affects Versions: 3.2.7
>Reporter: Dennis Kieselhorst
>Assignee: Dennis Kieselhorst
>Priority: Major
> Fix For: 3.3.0, 3.2.8
>
>
> I just noticed that the OpenApiAutoConfiguration introduced in CXF-7853 
> doesn't work if {{classes-scan-packages: org.apache.cxf.jaxrs.openapi}} is 
> used. In this case OpenApiFeature is added as a Provider by 
> AbstractSpringComponentScanServer and OpenApiAutoConfiguration doesn't hook 
> in.
> Sample:
> {code}
> git clone https://github.com/deki/swagger-samples/ --branch 
> java-cxf-spring-boot-minimal
> cd java/java-cxf-spring-boot-minimal
> mvn spring-boot:run
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CXF-7891) OpenApiAutoConfiguration doesn't work with classes-scan-packages

2018-11-06 Thread Dennis Kieselhorst (JIRA)


[ 
https://issues.apache.org/jira/browse/CXF-7891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676684#comment-16676684
 ] 

Dennis Kieselhorst commented on CXF-7891:
-

[~reta] 
I'll suggest to change {{@ConditionalOnBean(OpenApiFeature.class)}} to 
{{@ConditionalOnClass(OpenApiFeature.class)}}. Any objections?

> OpenApiAutoConfiguration doesn't work with classes-scan-packages
> 
>
> Key: CXF-7891
> URL: https://issues.apache.org/jira/browse/CXF-7891
> Project: CXF
>  Issue Type: Bug
>Affects Versions: 3.2.7
>Reporter: Dennis Kieselhorst
>Assignee: Dennis Kieselhorst
>Priority: Major
> Fix For: 3.3.0, 3.2.8
>
>
> I just noticed that the OpenApiAutoConfiguration introduced in CXF-7853 
> doesn't work if {{classes-scan-packages: org.apache.cxf.jaxrs.openapi}} is 
> used. In this case OpenApiFeature is added as a Provider by 
> AbstractSpringComponentScanServer and OpenApiAutoConfiguration doesn't hook 
> in.
> Sample:
> {code}
> git clone https://github.com/deki/swagger-samples/ --branch 
> java-cxf-spring-boot-minimal
> cd java/java-cxf-spring-boot-minimal
> mvn spring-boot:run
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)