[jira] [Commented] (DRILL-7200) Update Calcite to 1.19.0 / 1.20.0
[
https://issues.apache.org/jira/browse/DRILL-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877066#comment-16877066
]
ASF GitHub Bot commented on DRILL-7200:
---
vvysotskyi commented on pull request #1818: DRILL-7200: Update Calcite to
1.19.0 / 1.20.0
URL: https://github.com/apache/drill/pull/1818#discussion_r299544005
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/JoinPrel.java
##
@@ -158,6 +164,58 @@ protected void buildJoinConditions(List
conditions,
}
}
+ private static boolean collapseExpandedIsNotDistinctFromExpr(RexCall call) {
Review comment:
Nit: could you please create Calcite Jira to address it in the next version
of Calcite?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Calcite to 1.19.0 / 1.20.0
> -
>
> Key: DRILL-7200
> URL: https://issues.apache.org/jira/browse/DRILL-7200
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Bohdan Kazydub
>Assignee: Bohdan Kazydub
>Priority: Major
> Fix For: 1.17.0
>
>
> Calcite has released the 1.19.0 version. Upgrade Calcite dependency in Drill
> to the newest version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-7200) Update Calcite to 1.19.0 / 1.20.0
[
https://issues.apache.org/jira/browse/DRILL-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877061#comment-16877061
]
ASF GitHub Bot commented on DRILL-7200:
---
vvysotskyi commented on pull request #1818: DRILL-7200: Update Calcite to
1.19.0 / 1.20.0
URL: https://github.com/apache/drill/pull/1818#discussion_r299529279
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/FilterBuilder.java
##
@@ -262,6 +262,13 @@ public LogicalExpression
visitFunctionHolderExpression(FunctionHolderExpression
}
}
+ // shows whether function is simplified IS FALSE
+ private boolean isIsFalse(FunctionHolderExpression holderExpression, String
funcName) {
Review comment:
Could you please rename this method to something like `isNot`, since
actually, it checks whether specified functions is `NOT`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Calcite to 1.19.0 / 1.20.0
> -
>
> Key: DRILL-7200
> URL: https://issues.apache.org/jira/browse/DRILL-7200
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Bohdan Kazydub
>Assignee: Bohdan Kazydub
>Priority: Major
> Fix For: 1.17.0
>
>
> Calcite has released the 1.19.0 version. Upgrade Calcite dependency in Drill
> to the newest version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-7200) Update Calcite to 1.19.0 / 1.20.0
[
https://issues.apache.org/jira/browse/DRILL-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877062#comment-16877062
]
ASF GitHub Bot commented on DRILL-7200:
---
vvysotskyi commented on pull request #1818: DRILL-7200: Update Calcite to
1.19.0 / 1.20.0
URL: https://github.com/apache/drill/pull/1818#discussion_r299539195
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillAggregateRel.java
##
@@ -47,17 +47,29 @@
* Aggregation implemented in Drill.
*/
public class DrillAggregateRel extends DrillAggregateRelBase implements
DrillRel {
+
/** Creates a DrillAggregateRel. */
+ @Deprecated // Will be removed before Calcite 2.0
Review comment:
The same here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Calcite to 1.19.0 / 1.20.0
> -
>
> Key: DRILL-7200
> URL: https://issues.apache.org/jira/browse/DRILL-7200
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Bohdan Kazydub
>Assignee: Bohdan Kazydub
>Priority: Major
> Fix For: 1.17.0
>
>
> Calcite has released the 1.19.0 version. Upgrade Calcite dependency in Drill
> to the newest version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-7200) Update Calcite to 1.19.0 / 1.20.0
[
https://issues.apache.org/jira/browse/DRILL-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877065#comment-16877065
]
ASF GitHub Bot commented on DRILL-7200:
---
vvysotskyi commented on pull request #1818: DRILL-7200: Update Calcite to
1.19.0 / 1.20.0
URL: https://github.com/apache/drill/pull/1818#discussion_r299542741
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillSemiJoinRel.java
##
@@ -99,8 +102,9 @@ public LogicalOperator implement(DrillImplementor
implementor) {
return new LogicalSemiJoin(leftOp, rightOp, conditions, joinType);
}
- @Override
- public boolean isSemiJoin() {
-return true;
+ @Override public RelOptCost computeSelfCost(RelOptPlanner planner,
Review comment:
Please use "Drill" code style - move `@Override` in a separate line.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Calcite to 1.19.0 / 1.20.0
> -
>
> Key: DRILL-7200
> URL: https://issues.apache.org/jira/browse/DRILL-7200
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Bohdan Kazydub
>Assignee: Bohdan Kazydub
>Priority: Major
> Fix For: 1.17.0
>
>
> Calcite has released the 1.19.0 version. Upgrade Calcite dependency in Drill
> to the newest version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-7200) Update Calcite to 1.19.0 / 1.20.0
[
https://issues.apache.org/jira/browse/DRILL-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877063#comment-16877063
]
ASF GitHub Bot commented on DRILL-7200:
---
vvysotskyi commented on pull request #1818: DRILL-7200: Update Calcite to
1.19.0 / 1.20.0
URL: https://github.com/apache/drill/pull/1818#discussion_r299532499
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillAggregateRelBase.java
##
@@ -34,12 +34,17 @@
import java.util.List;
-
/**
* Base class for logical and physical Aggregations implemented in Drill
*/
public abstract class DrillAggregateRelBase extends Aggregate implements
DrillRelNode {
+ public DrillAggregateRelBase(RelOptCluster cluster, RelTraitSet traits,
RelNode child,
+ ImmutableBitSet groupSet, List
groupSets, List aggCalls) {
+super(cluster, traits, child, groupSet, groupSets, aggCalls);
+ }
+
+ @Deprecated // Will be removed before Calcite 2.0
Review comment:
Since you have marked this constructor deprecated, it would be good to
remove its usages if it wasn't done.
Also, please update the comment, we can remove this constructor
independently on the Calcite version we use.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Calcite to 1.19.0 / 1.20.0
> -
>
> Key: DRILL-7200
> URL: https://issues.apache.org/jira/browse/DRILL-7200
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Bohdan Kazydub
>Assignee: Bohdan Kazydub
>Priority: Major
> Fix For: 1.17.0
>
>
> Calcite has released the 1.19.0 version. Upgrade Calcite dependency in Drill
> to the newest version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-7200) Update Calcite to 1.19.0 / 1.20.0
[
https://issues.apache.org/jira/browse/DRILL-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877064#comment-16877064
]
ASF GitHub Bot commented on DRILL-7200:
---
vvysotskyi commented on pull request #1818: DRILL-7200: Update Calcite to
1.19.0 / 1.20.0
URL: https://github.com/apache/drill/pull/1818#discussion_r299542230
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillSemiJoinRel.java
##
@@ -99,8 +102,9 @@ public LogicalOperator implement(DrillImplementor
implementor) {
return new LogicalSemiJoin(leftOp, rightOp, conditions, joinType);
}
- @Override
- public boolean isSemiJoin() {
-return true;
+ @Override public RelOptCost computeSelfCost(RelOptPlanner planner,
+ RelMetadataQuery mq) {
+// REVIEW jvs 9-Apr-2006: Just for now...
Review comment:
Please update this comment to describe the reason why this method was
overridden.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Calcite to 1.19.0 / 1.20.0
> -
>
> Key: DRILL-7200
> URL: https://issues.apache.org/jira/browse/DRILL-7200
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Bohdan Kazydub
>Assignee: Bohdan Kazydub
>Priority: Major
> Fix For: 1.17.0
>
>
> Calcite has released the 1.19.0 version. Upgrade Calcite dependency in Drill
> to the newest version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-4070) Files written with versions of Drill before v1.3 record metadata that is indistinguishable from bad metadata from other Parquet creators
[ https://issues.apache.org/jira/browse/DRILL-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877011#comment-16877011 ] ASF GitHub Bot commented on DRILL-4070: --- arina-ielchiieva commented on pull request #278: DRILL-4070: Add note about parquet file migration in 1.3 URL: https://github.com/apache/drill/pull/278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Files written with versions of Drill before v1.3 record metadata that is > indistinguishable from bad metadata from other Parquet creators > > > Key: DRILL-4070 > URL: https://issues.apache.org/jira/browse/DRILL-4070 > Project: Apache Drill > Issue Type: Bug > Components: Metadata >Affects Versions: 1.3.0 >Reporter: Rahul Challapalli >Assignee: Parth Chandra >Priority: Blocker > Fix For: 1.3.0 > > Attachments: cache.txt, fewtypes_varcharpartition.tar.tgz > > > Drill uses the parquet-mr library to write Parquet files. The metadata > signature that Drill produced in 1.2 and earlier versions of Drill is > indistinguishable from older footers written by other tools (such as Pig and > Hive). There was a known bug when those tools wrote metadata that caused the > statistics to be incorrect. To correct this, the parquet-mr library adopted a > behavior of ignoring statistics from the old form of the Parquet footer. > With 1.3, Drill upgraded to the latest version of parquet-mr and has now > started ignoring these statistics as well. This ensures correct result but > produces performance regressions (compared to Drill v1 and v2) when querying > against partitioned Parquet files generated in Drill 1.1 and 1.2. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-7306) Disable "fast schema" batch for new scan framework
[ https://issues.apache.org/jira/browse/DRILL-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876856#comment-16876856 ] ASF GitHub Bot commented on DRILL-7306: --- arina-ielchiieva commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework URL: https://github.com/apache/drill/pull/1813#issuecomment-507619026 Looks like datasets are stored here: https://github.com/mapr/drill-test-framework/tree/master/framework/resources/Datasources/Tpch0.01/parquet This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Disable "fast schema" batch for new scan framework > -- > > Key: DRILL-7306 > URL: https://issues.apache.org/jira/browse/DRILL-7306 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Paul Rogers >Assignee: Paul Rogers >Priority: Major > Fix For: 1.17.0 > > > The EVF framework is set up to return a "fast schema" empty batch with only > schema as its first batch because, when the code was written, it seemed > that's how we wanted operators to work. However, DRILL-7305 notes that many > operators cannot handle empty batches. > Since the empty-batch bugs show that Drill does not, in fact, provide a "fast > schema" batch, this ticket asks to disable the feature in the new scan > framework. The feature is disabled with a config option; it can be re-enabled > if ever it is needed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-7306) Disable "fast schema" batch for new scan framework
[ https://issues.apache.org/jira/browse/DRILL-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876853#comment-16876853 ] ASF GitHub Bot commented on DRILL-7306: --- arina-ielchiieva commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework URL: https://github.com/apache/drill/pull/1813#issuecomment-507619026 Looks like datasets are stored here; https://github.com/mapr/drill-test-framework/tree/master/framework/resources/Datasources/Tpch0.01/parquet This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Disable "fast schema" batch for new scan framework > -- > > Key: DRILL-7306 > URL: https://issues.apache.org/jira/browse/DRILL-7306 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Paul Rogers >Assignee: Paul Rogers >Priority: Major > Fix For: 1.17.0 > > > The EVF framework is set up to return a "fast schema" empty batch with only > schema as its first batch because, when the code was written, it seemed > that's how we wanted operators to work. However, DRILL-7305 notes that many > operators cannot handle empty batches. > Since the empty-batch bugs show that Drill does not, in fact, provide a "fast > schema" batch, this ticket asks to disable the feature in the new scan > framework. The feature is disabled with a config option; it can be re-enabled > if ever it is needed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-7306) Disable "fast schema" batch for new scan framework
[ https://issues.apache.org/jira/browse/DRILL-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva updated DRILL-7306: Labels: (was: ready-to-commit) > Disable "fast schema" batch for new scan framework > -- > > Key: DRILL-7306 > URL: https://issues.apache.org/jira/browse/DRILL-7306 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Paul Rogers >Assignee: Paul Rogers >Priority: Major > Fix For: 1.17.0 > > > The EVF framework is set up to return a "fast schema" empty batch with only > schema as its first batch because, when the code was written, it seemed > that's how we wanted operators to work. However, DRILL-7305 notes that many > operators cannot handle empty batches. > Since the empty-batch bugs show that Drill does not, in fact, provide a "fast > schema" batch, this ticket asks to disable the feature in the new scan > framework. The feature is disabled with a config option; it can be re-enabled > if ever it is needed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DRILL-6951) Merge row set based mock data source
[ https://issues.apache.org/jira/browse/DRILL-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva updated DRILL-6951: Labels: (was: ready-to-commit) > Merge row set based mock data source > > > Key: DRILL-6951 > URL: https://issues.apache.org/jira/browse/DRILL-6951 > Project: Apache Drill > Issue Type: Improvement >Affects Versions: 1.15.0 >Reporter: Paul Rogers >Assignee: Paul Rogers >Priority: Major > Fix For: 1.17.0 > > > The mock reader framework is an obscure bit of code used in tests that > generates fake data for use in things like testing sort, filters and so on. > Because the mock reader is simple, it is a good demonstration case for the > new scanner framework based on the result set loader. This task merges the > existing work in migrating the mock data source into master via a PR. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-7200) Update Calcite to 1.19.0 / 1.20.0
[
https://issues.apache.org/jira/browse/DRILL-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876831#comment-16876831
]
ASF GitHub Bot commented on DRILL-7200:
---
arina-ielchiieva commented on pull request #1818: DRILL-7200: Update Calcite to
1.19.0 / 1.20.0
URL: https://github.com/apache/drill/pull/1818#discussion_r299400674
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
##
@@ -268,7 +268,7 @@ public SqlNode visit(SqlCall sqlCall) {
// Disable Function
for(String strOperator : disabledOperators) {
- if(sqlCall.getOperator().isName(strOperator)) {
+ if(sqlCall.getOperator().isName(strOperator, true)) { // true is passed
to have previous behavior
Review comment:
```suggestion
if(sqlCall.getOperator().isName(strOperator, true)) { // true is
passed to preserve previous behavior
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Calcite to 1.19.0 / 1.20.0
> -
>
> Key: DRILL-7200
> URL: https://issues.apache.org/jira/browse/DRILL-7200
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Bohdan Kazydub
>Assignee: Bohdan Kazydub
>Priority: Major
> Fix For: 1.17.0
>
>
> Calcite has released the 1.19.0 version. Upgrade Calcite dependency in Drill
> to the newest version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-7200) Update Calcite to 1.19.0 / 1.20.0
[
https://issues.apache.org/jira/browse/DRILL-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876833#comment-16876833
]
ASF GitHub Bot commented on DRILL-7200:
---
arina-ielchiieva commented on pull request #1818: DRILL-7200: Update Calcite to
1.19.0 / 1.20.0
URL: https://github.com/apache/drill/pull/1818#discussion_r299400307
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
##
@@ -403,8 +411,20 @@ public RelRoot toRel(final SqlNode validatedNode) {
new SqlToRelConverter(new Expander(), validator, catalog, cluster,
DrillConvertletTable.INSTANCE,
sqlToRelConverterConfig);
-//To avoid unexpected column errors set a value of top to false
-final RelRoot rel = sqlToRelConverter.convertQuery(validatedNode, false,
false);
+RelRoot rel = sqlToRelConverter.convertQuery(validatedNode, false,
!isInnerQuery || isExpandedView);
+
+// If extra expressions used in ORDER BY were added to the project list,
+// add another project to remove them.
+if ((!isInnerQuery || isExpandedView) &&
rel.rel.getRowType().getFieldCount() - rel.fields.size() > 0) {
+ List exprs = new ArrayList<>();
Review comment:
Can we use stream?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Calcite to 1.19.0 / 1.20.0
> -
>
> Key: DRILL-7200
> URL: https://issues.apache.org/jira/browse/DRILL-7200
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Bohdan Kazydub
>Assignee: Bohdan Kazydub
>Priority: Major
> Fix For: 1.17.0
>
>
> Calcite has released the 1.19.0 version. Upgrade Calcite dependency in Drill
> to the newest version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DRILL-7200) Update Calcite to 1.19.0 / 1.20.0
[ https://issues.apache.org/jira/browse/DRILL-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876829#comment-16876829 ] ASF GitHub Bot commented on DRILL-7200: --- arina-ielchiieva commented on pull request #1818: DRILL-7200: Update Calcite to 1.19.0 / 1.20.0 URL: https://github.com/apache/drill/pull/1818#discussion_r299400445 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java ## @@ -66,7 +66,7 @@ public PhysicalPlan getPlan(SqlNode sqlNode) throws ValidationException, RelConv // Disallow temporary tables usage in view definition config.getConverter().disallowTemporaryTables(); // Store the viewSql as view def SqlNode is modified as part of the resolving the new table definition below. - final String viewSql = createView.getQuery().toString(); + final String viewSql = createView.getQuery().toSqlString(null, true).getSql(); Review comment: Please add unit test for this case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update Calcite to 1.19.0 / 1.20.0 > - > > Key: DRILL-7200 > URL: https://issues.apache.org/jira/browse/DRILL-7200 > Project: Apache Drill > Issue Type: Task >Affects Versions: 1.16.0 >Reporter: Bohdan Kazydub >Assignee: Bohdan Kazydub >Priority: Major > Fix For: 1.17.0 > > > Calcite has released the 1.19.0 version. Upgrade Calcite dependency in Drill > to the newest version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-7200) Update Calcite to 1.19.0 / 1.20.0
[ https://issues.apache.org/jira/browse/DRILL-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876830#comment-16876830 ] ASF GitHub Bot commented on DRILL-7200: --- arina-ielchiieva commented on pull request #1818: DRILL-7200: Update Calcite to 1.19.0 / 1.20.0 URL: https://github.com/apache/drill/pull/1818#discussion_r299398641 ## File path: docs/dev/Calcite.md ## @@ -10,6 +10,7 @@ List of Jiras with Drill-specific commits: |[CALCITE-2018](https://issues.apache.org/jira/browse/CALCITE-2018)|Queries failed with AssertionError: rel has lower cost than best cost of subset|Pull request with the fix was created ([PR-552](https://github.com/apache/calcite/pull/552)), but [CALCITE-2166](https://issues.apache.org/jira/browse/CALCITE-2166) which blocks it was found and is not resolved yet.| |[CALCITE-2087](https://issues.apache.org/jira/browse/CALCITE-2087)|Add new method to ViewExpander interface to allow passing SchemaPlus.|Pull request into Apache Calcite was created, but it was declined. See conversation in Jira.| |[CALCITE-1178](https://issues.apache.org/jira/browse/CALCITE-1178)|Allow SqlBetweenOperator to compare DATE and TIMESTAMP|SQL spec does not allow to compare datetime types if they have different ``s. Therefore Calcite community won’t accept these changes. Similar issues were reported in [CALCITE-2829](https://issues.apache.org/jira/browse/CALCITE-2829) and in [CALCITE-2745](https://issues.apache.org/jira/browse/CALCITE-2745).| +|[CALCITE-3121](https://issues.apache.org/jira/browse/CALCITE-3121)|VolcanoPlanner hangs due to removing ORDER BY from sub-query|Pull request was open to revert changes ([PR-1264](https://github.com/apache/calcite/pull/1264)) which remove ORDER BY clause; it wasn't merged, because aforementioned changes only unveiled the issue and no proper solution was proposed yet.| Review comment: ```suggestion |[CALCITE-3121](https://issues.apache.org/jira/browse/CALCITE-3121)|VolcanoPlanner hangs due to removing ORDER BY from sub-query|Pull request was open to revert changes ([PR-1264](https://github.com/apache/calcite/pull/1264)) which remove ORDER BY clause; it wasn't merged, because aforementioned changes only unveiled the issue and no proper solution is available yet.| ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update Calcite to 1.19.0 / 1.20.0 > - > > Key: DRILL-7200 > URL: https://issues.apache.org/jira/browse/DRILL-7200 > Project: Apache Drill > Issue Type: Task >Affects Versions: 1.16.0 >Reporter: Bohdan Kazydub >Assignee: Bohdan Kazydub >Priority: Major > Fix For: 1.17.0 > > > Calcite has released the 1.19.0 version. Upgrade Calcite dependency in Drill > to the newest version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DRILL-7200) Update Calcite to 1.19.0 / 1.20.0
[
https://issues.apache.org/jira/browse/DRILL-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876832#comment-16876832
]
ASF GitHub Bot commented on DRILL-7200:
---
arina-ielchiieva commented on pull request #1818: DRILL-7200: Update Calcite to
1.19.0 / 1.20.0
URL: https://github.com/apache/drill/pull/1818#discussion_r299400489
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
##
@@ -268,7 +268,7 @@ public SqlNode visit(SqlCall sqlCall) {
// Disable Function
for(String strOperator : disabledOperators) {
- if(sqlCall.getOperator().isName(strOperator)) {
+ if(sqlCall.getOperator().isName(strOperator, true)) { // true is passed
to have previous behavior
Review comment:
```suggestion
if (sqlCall.getOperator().isName(strOperator, true)) { // true is
passed to have previous behavior
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Calcite to 1.19.0 / 1.20.0
> -
>
> Key: DRILL-7200
> URL: https://issues.apache.org/jira/browse/DRILL-7200
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.16.0
>Reporter: Bohdan Kazydub
>Assignee: Bohdan Kazydub
>Priority: Major
> Fix For: 1.17.0
>
>
> Calcite has released the 1.19.0 version. Upgrade Calcite dependency in Drill
> to the newest version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
