[jira] [Commented] (DRILL-1896) Unit tests failing due to string based comparison at JsonStringHashMap & JsonStringArrayList #equals methods
[
https://issues.apache.org/jira/browse/DRILL-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443484#comment-17443484
]
Vitalii Diravka commented on DRILL-1896:
[~jnadeau] is right DRILL-1824 is mixed with this Jira. DRILL-1824 is resolved:
{code:java}
apache drill> select * from dfs.home.`/vector/complex/writer/schemaChange`;
+--+---+
| a | b |
+--+---+
| foo | null |
| bar | null |
| foo2 | {} |
| bar2 | {"x":1,"y":2} |
+--+---+
4 rows selected (0.195 seconds) {code}
But this one is not resolved and causes _TestJsonReader#schemaChangeValidate_
to fail
> Unit tests failing due to string based comparison at JsonStringHashMap &
> JsonStringArrayList #equals methods
>
>
> Key: DRILL-1896
> URL: https://issues.apache.org/jira/browse/DRILL-1896
> Project: Apache Drill
> Issue Type: Bug
>Reporter: Hanifi Gunes
>Assignee: Vitalii Diravka
>Priority: Major
> Fix For: 0.8.0
>
> Attachments: DRILL-1896-v3.patch, DRILL-1896.patch, RILL-1896-v2.patch
>
>
> Unit test framework relies on JsonString*#equals methods to compare actual
> and expected results. We should properly implement these to prevent unit
> tests from failing.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Reopened] (DRILL-1896) Unit tests failing due to string based comparison at JsonStringHashMap & JsonStringArrayList #equals methods
[ https://issues.apache.org/jira/browse/DRILL-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vitalii Diravka reopened DRILL-1896: Assignee: Vitalii Diravka (was: Jason Altekruse) > Unit tests failing due to string based comparison at JsonStringHashMap & > JsonStringArrayList #equals methods > > > Key: DRILL-1896 > URL: https://issues.apache.org/jira/browse/DRILL-1896 > Project: Apache Drill > Issue Type: Bug >Reporter: Hanifi Gunes >Assignee: Vitalii Diravka >Priority: Major > Fix For: 0.8.0 > > Attachments: DRILL-1896-v3.patch, DRILL-1896.patch, RILL-1896-v2.patch > > > Unit test framework relies on JsonString*#equals methods to compare actual > and expected results. We should properly implement these to prevent unit > tests from failing. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (DRILL-1824) Certain JSON data test patterns cause false negatives in new test framework
[
https://issues.apache.org/jira/browse/DRILL-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vitalii Diravka resolved DRILL-1824.
Fix Version/s: 1.19.0
(was: Future)
Resolution: Done
> Certain JSON data test patterns cause false negatives in new test framework
> ---
>
> Key: DRILL-1824
> URL: https://issues.apache.org/jira/browse/DRILL-1824
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
>Affects Versions: 0.7.0
>Reporter: Jacques Nadeau
>Assignee: Vitalii Diravka
>Priority: Minor
> Fix For: 1.19.0
>
>
> Testing the json reader.
> {code}
> testBuilder() //
> .sqlQuery("select b from files") //
> .unOrdered() //
> .jsonBaselineFile("expected.json") //
> .build()
> .run();
> {code}
> Files composed of two files:
> File 1
> {code}
> {"a": "foo","b": null}
> {"a": "bar","b": null}
> {code}
> File 2
> {code}
> {"a": "foo2","b": null}
> {"a": "bar2","b": {"x":1, "y":2}}
> {code}
> Expected Output:
> {code}
> b
> null
> null
> {}
> {"x":1,"y":2}
> {code}
> Receives failure of
> {code}
> java.lang.Exception: Did not find expected record in result set: `b` : null,
> at
> org.apache.drill.DrillTestWrapper.compareResults(DrillTestWrapper.java:528)
> at
> org.apache.drill.DrillTestWrapper.compareUnorderedResults(DrillTestWrapper.java:290)
> at org.apache.drill.DrillTestWrapper.run(DrillTestWrapper.java:118)
> at
> org.apache.drill.exec.vector.complex.writer.TestJsonReader.schemaChange(TestJsonReader.java:60)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at java.lang.reflect.Method.invoke(Method.java:601)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (DRILL-1824) Certain JSON data test patterns cause false negatives in new test framework
[
https://issues.apache.org/jira/browse/DRILL-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443483#comment-17443483
]
Vitalii Diravka commented on DRILL-1824:
[~jnadeau] is right DRILL-1896 is mixed with this Jira. This one is resolved:
{code:java}
apache drill> select * from dfs.home.`/vector/complex/writer/schemaChange`;
+--+---+
| a | b |
+--+---+
| foo | null |
| bar | null |
| foo2 | {} |
| bar2 | {"x":1,"y":2} |
+--+---+
4 rows selected (0.195 seconds) {code}
But DRILL-1896 is not resolved and causes _TestJsonReader#schemaChangeValidate_
to fail.
> Certain JSON data test patterns cause false negatives in new test framework
> ---
>
> Key: DRILL-1824
> URL: https://issues.apache.org/jira/browse/DRILL-1824
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
>Affects Versions: 0.7.0
>Reporter: Jacques Nadeau
>Priority: Minor
> Fix For: Future
>
>
> Testing the json reader.
> {code}
> testBuilder() //
> .sqlQuery("select b from files") //
> .unOrdered() //
> .jsonBaselineFile("expected.json") //
> .build()
> .run();
> {code}
> Files composed of two files:
> File 1
> {code}
> {"a": "foo","b": null}
> {"a": "bar","b": null}
> {code}
> File 2
> {code}
> {"a": "foo2","b": null}
> {"a": "bar2","b": {"x":1, "y":2}}
> {code}
> Expected Output:
> {code}
> b
> null
> null
> {}
> {"x":1,"y":2}
> {code}
> Receives failure of
> {code}
> java.lang.Exception: Did not find expected record in result set: `b` : null,
> at
> org.apache.drill.DrillTestWrapper.compareResults(DrillTestWrapper.java:528)
> at
> org.apache.drill.DrillTestWrapper.compareUnorderedResults(DrillTestWrapper.java:290)
> at org.apache.drill.DrillTestWrapper.run(DrillTestWrapper.java:118)
> at
> org.apache.drill.exec.vector.complex.writer.TestJsonReader.schemaChange(TestJsonReader.java:60)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at java.lang.reflect.Method.invoke(Method.java:601)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (DRILL-1824) Certain JSON data test patterns cause false negatives in new test framework
[
https://issues.apache.org/jira/browse/DRILL-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vitalii Diravka reassigned DRILL-1824:
--
Assignee: Vitalii Diravka
> Certain JSON data test patterns cause false negatives in new test framework
> ---
>
> Key: DRILL-1824
> URL: https://issues.apache.org/jira/browse/DRILL-1824
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
>Affects Versions: 0.7.0
>Reporter: Jacques Nadeau
>Assignee: Vitalii Diravka
>Priority: Minor
> Fix For: Future
>
>
> Testing the json reader.
> {code}
> testBuilder() //
> .sqlQuery("select b from files") //
> .unOrdered() //
> .jsonBaselineFile("expected.json") //
> .build()
> .run();
> {code}
> Files composed of two files:
> File 1
> {code}
> {"a": "foo","b": null}
> {"a": "bar","b": null}
> {code}
> File 2
> {code}
> {"a": "foo2","b": null}
> {"a": "bar2","b": {"x":1, "y":2}}
> {code}
> Expected Output:
> {code}
> b
> null
> null
> {}
> {"x":1,"y":2}
> {code}
> Receives failure of
> {code}
> java.lang.Exception: Did not find expected record in result set: `b` : null,
> at
> org.apache.drill.DrillTestWrapper.compareResults(DrillTestWrapper.java:528)
> at
> org.apache.drill.DrillTestWrapper.compareUnorderedResults(DrillTestWrapper.java:290)
> at org.apache.drill.DrillTestWrapper.run(DrillTestWrapper.java:118)
> at
> org.apache.drill.exec.vector.complex.writer.TestJsonReader.schemaChange(TestJsonReader.java:60)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at java.lang.reflect.Method.invoke(Method.java:601)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at java.lang.reflect.Method.invoke(Method.java:601)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (DRILL-8043) Excel Reader Regression Fix
[ https://issues.apache.org/jira/browse/DRILL-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443320#comment-17443320 ] ASF GitHub Bot commented on DRILL-8043: --- luocooong commented on pull request #2372: URL: https://github.com/apache/drill/pull/2372#issuecomment-968273561 @cgivre It would be better to use the title (DRILL-XXX) for commits log. I forgot.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Excel Reader Regression Fix > --- > > Key: DRILL-8043 > URL: https://issues.apache.org/jira/browse/DRILL-8043 > Project: Apache Drill > Issue Type: Bug > Components: Storage - Other >Affects Versions: 1.19.0 >Reporter: Charles Givre >Assignee: Charles Givre >Priority: Blocker > Fix For: 1.20.0 > > > DRILL-8033 caused a regression with reading excel files. See > ([https://github.com/pjfanning/excel-streaming-reader/issues/76)] This PR > reverts back to the previous version of POI. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (DRILL-8043) Excel Reader Regression Fix
[ https://issues.apache.org/jira/browse/DRILL-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443314#comment-17443314 ] ASF GitHub Bot commented on DRILL-8043: --- luocooong merged pull request #2372: URL: https://github.com/apache/drill/pull/2372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Excel Reader Regression Fix > --- > > Key: DRILL-8043 > URL: https://issues.apache.org/jira/browse/DRILL-8043 > Project: Apache Drill > Issue Type: Bug > Components: Storage - Other >Affects Versions: 1.19.0 >Reporter: Charles Givre >Assignee: Charles Givre >Priority: Blocker > Fix For: 1.20.0 > > > DRILL-8033 caused a regression with reading excel files. See > ([https://github.com/pjfanning/excel-streaming-reader/issues/76)] This PR > reverts back to the previous version of POI. -- This message was sent by Atlassian Jira (v8.20.1#820001)
