[jira] [Commented] (DRILL-8015) Add MongoDB Metastore implementation
[ https://issues.apache.org/jira/browse/DRILL-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456195#comment-17456195 ] ASF GitHub Bot commented on DRILL-8015: --- dzamo commented on pull request #2384: URL: https://github.com/apache/drill/pull/2384#issuecomment-989585110 > @dzamo We can make progress now, I will try my best to solve the comments by this weekend, is that ok for you to delay two days before freezing the master branch? @Leon-WTF Great! We voted in the mailing list to delay the freeze until next week Friday due to multiple PRs that are near completion. We're grateful for your efforts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add MongoDB Metastore implementation > > > Key: DRILL-8015 > URL: https://issues.apache.org/jira/browse/DRILL-8015 > Project: Apache Drill > Issue Type: Improvement > Components: Metadata >Reporter: wtf >Assignee: wtf >Priority: Minor > > Add a NoSQL Metastore implementation -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (DRILL-8056) Add OAuth2 Support for HTTP Rest Plugin
[ https://issues.apache.org/jira/browse/DRILL-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456159#comment-17456159 ] ASF GitHub Bot commented on DRILL-8056: --- lgtm-com[bot] commented on pull request #2401: URL: https://github.com/apache/drill/pull/2401#issuecomment-989548997 This pull request **introduces 1 alert** when merging d82e039c6af4d6996d83ce6619c599c90ced8637 into 7ddfb08523ea9fcf0f2f4e6d1307cc9ca9c4c851 - [view on LGTM.com](https://lgtm.com/projects/g/apache/drill/rev/pr-cb95004be65512fade1b932dfe219a2874824cba) **new alerts:** * 1 for Dereferenced variable may be null -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add OAuth2 Support for HTTP Rest Plugin > --- > > Key: DRILL-8056 > URL: https://issues.apache.org/jira/browse/DRILL-8056 > Project: Apache Drill > Issue Type: Improvement > Components: Storage - Other >Affects Versions: 1.19.0 >Reporter: Charles Givre >Assignee: Charles Givre >Priority: Major > Fix For: 1.20.0 > > > Many enterprise platforms use OAuth2 for authentication and authorization. > This pull request allows Drill to authenticate with external APIs that use > OAuth2 and query these data sources. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (DRILL-8056) Add OAuth2 Support for HTTP Rest Plugin
[ https://issues.apache.org/jira/browse/DRILL-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456142#comment-17456142 ] ASF GitHub Bot commented on DRILL-8056: --- cgivre opened a new pull request #2401: URL: https://github.com/apache/drill/pull/2401 # [DRILL-8056](https://issues.apache.org/jira/browse/DRILL-8056): Add OAuth2 Support for HTTP Rest Plugin ## Description This PR adds the ability to query APIs which use OAuth2.0. The PR handles obtaining all the tokens and refreshing them in API calls. ## Documentation (Please describe user-visible changes similar to what should appear in the Drill documentation.) ## Testing Manually tested and added unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add OAuth2 Support for HTTP Rest Plugin > --- > > Key: DRILL-8056 > URL: https://issues.apache.org/jira/browse/DRILL-8056 > Project: Apache Drill > Issue Type: Improvement > Components: Storage - Other >Affects Versions: 1.19.0 >Reporter: Charles Givre >Assignee: Charles Givre >Priority: Major > Fix For: 1.20.0 > > > Many enterprise platforms use OAuth2 for authentication and authorization. > This pull request allows Drill to authenticate with external APIs that use > OAuth2 and query these data sources. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (DRILL-8015) Add MongoDB Metastore implementation
[ https://issues.apache.org/jira/browse/DRILL-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456115#comment-17456115 ] ASF GitHub Bot commented on DRILL-8015: --- cgivre commented on pull request #2384: URL: https://github.com/apache/drill/pull/2384#issuecomment-989463385 I'm not that familiar with the Drill metastore, but I do think this is a valuable contribution. I don't want to hold this up, so it looks good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add MongoDB Metastore implementation > > > Key: DRILL-8015 > URL: https://issues.apache.org/jira/browse/DRILL-8015 > Project: Apache Drill > Issue Type: Improvement > Components: Metadata >Reporter: wtf >Assignee: wtf >Priority: Minor > > Add a NoSQL Metastore implementation -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (DRILL-8070) format-excel assumes that rowIterator returns every row
[
https://issues.apache.org/jira/browse/DRILL-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456111#comment-17456111
]
ASF GitHub Bot commented on DRILL-8070:
---
cgivre merged pull request #2399:
URL: https://github.com/apache/drill/pull/2399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> format-excel assumes that rowIterator returns every row
> ---
>
> Key: DRILL-8070
> URL: https://issues.apache.org/jira/browse/DRILL-8070
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Data Types
>Reporter: PJ Fanning
>Priority: Major
>
> In ExcelBatchReader, this code makes the wrong assumption:
> {code:java}
> for (int i = 1; i < rowNumber; i++) {
> currentRow = rowIterator.next();
> } {code}
>
> There are 2 for loops like this.
> Empty Rows will not necessarily be returned by the iterator. Basically, rows
> without populated cells could easily be skipped. Think of the Sheet as being
> represented as a sparse matrix - because it is stored like this.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (DRILL-8015) Add MongoDB Metastore implementation
[ https://issues.apache.org/jira/browse/DRILL-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456098#comment-17456098 ] ASF GitHub Bot commented on DRILL-8015: --- Leon-WTF edited a comment on pull request #2384: URL: https://github.com/apache/drill/pull/2384#issuecomment-98920 > @Leon-WTF @luocooong, w.r.t to the release of 1.20 and having read this PR's comments I just want to check if we're deadlocked here with author waiting for reviewers and reviewers waiting for author? @dzamo We can make progress now, I will try my best to solve the comments by this weekend, is that ok for you to delay two days before freezing the master branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add MongoDB Metastore implementation > > > Key: DRILL-8015 > URL: https://issues.apache.org/jira/browse/DRILL-8015 > Project: Apache Drill > Issue Type: Improvement > Components: Metadata >Reporter: wtf >Assignee: wtf >Priority: Minor > > Add a NoSQL Metastore implementation -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (DRILL-8015) Add MongoDB Metastore implementation
[ https://issues.apache.org/jira/browse/DRILL-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456097#comment-17456097 ] ASF GitHub Bot commented on DRILL-8015: --- Leon-WTF commented on pull request #2384: URL: https://github.com/apache/drill/pull/2384#issuecomment-98920 > @Leon-WTF @luocooong, w.r.t to the release of 1.20 and having read this PR's comments I just want to check if we're deadlocked here with author waiting for reviewers and reviewers waiting for author? @dzamo We can progress now, I will try my best to solve the comments by this weekend, is that ok for you to delay two days before freezing the master branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add MongoDB Metastore implementation > > > Key: DRILL-8015 > URL: https://issues.apache.org/jira/browse/DRILL-8015 > Project: Apache Drill > Issue Type: Improvement > Components: Metadata >Reporter: wtf >Assignee: wtf >Priority: Minor > > Add a NoSQL Metastore implementation -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (DRILL-8071) format-excel should use POI DataFormatter
[ https://issues.apache.org/jira/browse/DRILL-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456063#comment-17456063 ] ASF GitHub Bot commented on DRILL-8071: --- pjfanning opened a new pull request #2400: URL: https://github.com/apache/drill/pull/2400 # [DRILL-8071](https://issues.apache.org/jira/browse/DRILL-8071): use excel cell.getLocalDateTimeCellValue ## Description Use built-in POI/excel-streaming-reader method to get date time - this is safer than writing custom code to convert excel numbers to date times. In particular, this method takes into account if the workbook stores date times with 1900 or 1904 as the base date. ## Documentation No changes ## Testing Unit tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > format-excel should use POI DataFormatter > - > > Key: DRILL-8071 > URL: https://issues.apache.org/jira/browse/DRILL-8071 > Project: Apache Drill > Issue Type: Improvement > Components: Execution - Data Types >Affects Versions: 1.19.0 >Reporter: PJ Fanning >Priority: Major > > The existing ExcelBatchReader uses the raw data values from the cells. This > raw data ignores formatting set on the cells. As an example, numbers and > dates are stored as doubles. With the POI DataFormatter, you can get the cell > style applied so that the data will appear as it does when you view the data > in Excel itself. > [https://poi.apache.org/apidocs/dev/org/apache/poi/ss/usermodel/DataFormatter.html#formatCellValue-org.apache.poi.ss.usermodel.Cell-] > > A big number like 123456789.987654 could be stored as double that is more > like 123456789.987653999 when represented in decimal format (because this > might be the closest match that double can represent). The cell format could > say that cell has 6 decimal places after the decimal point so the formatter > would round the number back to the value that it displayed in Excel as. > Even if you choose not to use the DataFormatter, you have unprotected calls > to `cell.getNumericCellValue()` and that could easily throw an exception (if > the data is not stored a number). Even `cell.getStringCellValue()` can throw > an exception - for similar reasons. > > There is also custom code for handling the conversion of the raw numbers > representing dates/timestamps but this also seems like a bad idea. The Cell > class has getLocalDateTimeCellValue and this has the right logic for > converting 1904 and 1900 based dates - yes, Excel uses 2 different formats. > Code that processes excel files is a real pain to get right because the > Microsoft storage format is really bad. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (DRILL-8070) format-excel assumes that rowIterator returns every row
[
https://issues.apache.org/jira/browse/DRILL-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456007#comment-17456007
]
ASF GitHub Bot commented on DRILL-8070:
---
pjfanning commented on pull request #2399:
URL: https://github.com/apache/drill/pull/2399#issuecomment-989221637
@cgivre the test involves a new xlsx that has a copy of the 'data' sheet
from test_data.xlsx but with 3 empty rows before the header row. Without my
code change, the existing format-excel code skips too far because its skip
logic is wrong (not handling rows that are simply missing from the iterator)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> format-excel assumes that rowIterator returns every row
> ---
>
> Key: DRILL-8070
> URL: https://issues.apache.org/jira/browse/DRILL-8070
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Data Types
>Reporter: PJ Fanning
>Priority: Major
>
> In ExcelBatchReader, this code makes the wrong assumption:
> {code:java}
> for (int i = 1; i < rowNumber; i++) {
> currentRow = rowIterator.next();
> } {code}
>
> There are 2 for loops like this.
> Empty Rows will not necessarily be returned by the iterator. Basically, rows
> without populated cells could easily be skipped. Think of the Sheet as being
> represented as a sparse matrix - because it is stored like this.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (DRILL-8070) format-excel assumes that rowIterator returns every row
[
https://issues.apache.org/jira/browse/DRILL-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17455995#comment-17455995
]
ASF GitHub Bot commented on DRILL-8070:
---
pjfanning opened a new pull request #2399:
URL: https://github.com/apache/drill/pull/2399
# [DRILL-8070](https://issues.apache.org/jira/browse/DRILL-8070):
format-excel assumes that rowIterator returns every row
## Description
Replaces the code for skipping rows with a version that checks the rownum as
it iterates
## Documentation
No changes needed
## Testing
Unit tests. Advice about how to add a test that changes the
ExcelBatchReader.ExcelReaderConfig would be appreciated. There do not appear to
be any existing tests that set the ExcelReaderConfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> format-excel assumes that rowIterator returns every row
> ---
>
> Key: DRILL-8070
> URL: https://issues.apache.org/jira/browse/DRILL-8070
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Data Types
>Reporter: PJ Fanning
>Priority: Major
>
> In ExcelBatchReader, this code makes the wrong assumption:
> {code:java}
> for (int i = 1; i < rowNumber; i++) {
> currentRow = rowIterator.next();
> } {code}
>
> There are 2 for loops like this.
> Empty Rows will not necessarily be returned by the iterator. Basically, rows
> without populated cells could easily be skipped. Think of the Sheet as being
> represented as a sparse matrix - because it is stored like this.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (DRILL-8069) remove use of excel sheet getLastRowNum
[ https://issues.apache.org/jira/browse/DRILL-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17455979#comment-17455979 ] ASF GitHub Bot commented on DRILL-8069: --- cgivre merged pull request #2396: URL: https://github.com/apache/drill/pull/2396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > remove use of excel sheet getLastRowNum > --- > > Key: DRILL-8069 > URL: https://issues.apache.org/jira/browse/DRILL-8069 > Project: Apache Drill > Issue Type: Improvement > Components: Execution - Data Types >Reporter: PJ Fanning >Priority: Major > > excel-streaming-reader can only get last row num from sheets that have > dimension data and not all sheets have this set - it is safer to iterate > through the row data and not try to shortcut the reading of the sheet based > on getLastRowNum -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (DRILL-8058) NPE: Cannot invoke "org.apache.calcite.rel.core.TableScan.getTable()" because "scan" is null
[
https://issues.apache.org/jira/browse/DRILL-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17455942#comment-17455942
]
Vova Vysotskyi commented on DRILL-8058:
---
Nope, different one, error on the next line:
org.apache.drill.exec.store.iceberg.plan.IcebergPluginImplementor.canImplement(IcebergPluginImplementor.java:102)
vs
org.apache.drill.exec.store.iceberg.plan.IcebergPluginImplementor.canImplement(IcebergPluginImplementor.java:101)
But will be fixed in the scope of DRILL-8060
> NPE: Cannot invoke "org.apache.calcite.rel.core.TableScan.getTable()" because
> "scan" is null
>
>
> Key: DRILL-8058
> URL: https://issues.apache.org/jira/browse/DRILL-8058
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - Iceberg
>Affects Versions: 1.19.0
>Reporter: Vitalii Diravka
>Assignee: Vova Vysotskyi
>Priority: Major
> Labels: iceberg, storage
> Fix For: Future
>
>
> Checked in Drill embedded the query form
> _TestE2EUnnestAndLateral#testMultipleBatchesLateral_WithLimitInParent_ test
> case:
> {code:java}
> SELECT customer.c_name, avg(orders.o_totalprice) AS avgPrice FROM
> dfs.`/{custom_path}/drill/exec/java-exec/target/org.apache.drill.exec.physical.impl.lateraljoin.TestE2EUnnestAndLateral/root/lateraljoin/multipleFiles`
>
> customer, LATERAL (SELECT t.ord.o_totalprice as o_totalprice FROM
> UNNEST(customer.c_orders) t(ord)
> WHERE t.ord.o_totalprice > 10 LIMIT 2) orders GROUP BY customer.c_name;
> {code}
> But it gives the following error:
> {code:java}
> Caused by: java.lang.NullPointerException: Cannot invoke
> "org.apache.calcite.rel.core.TableScan.getTable()" because "scan" is null
> at
> org.apache.drill.exec.planner.common.DrillRelOptUtil.getDrillTable(DrillRelOptUtil.java:691)
> at
> org.apache.drill.exec.store.iceberg.plan.IcebergPluginImplementor.canImplement(IcebergPluginImplementor.java:101)
> at
> org.apache.drill.exec.store.plan.rule.PluginConverterRule.matches(PluginConverterRule.java:64)
> at
> org.apache.calcite.plan.volcano.VolcanoRuleCall.matchRecurse(VolcanoRuleCall.java:263)
> at
> org.apache.calcite.plan.volcano.VolcanoRuleCall.match(VolcanoRuleCall.java:247)
> at
> org.apache.calcite.plan.volcano.VolcanoPlanner.fireRules(VolcanoPlanner.java:1566)
> at
> org.apache.calcite.plan.volcano.VolcanoPlanner.registerImpl(VolcanoPlanner.java:1840)
> at
> org.apache.calcite.plan.volcano.VolcanoPlanner.register(VolcanoPlanner.java:848)
> at
> org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:864)
> at
> org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:92)
> at
> org.apache.calcite.rel.AbstractRelNode.onRegister(AbstractRelNode.java:329)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (DRILL-8058) NPE: Cannot invoke "org.apache.calcite.rel.core.TableScan.getTable()" because "scan" is null
[
https://issues.apache.org/jira/browse/DRILL-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17455933#comment-17455933
]
Vitalii Diravka commented on DRILL-8058:
Looks the same as DRILL-8060
> NPE: Cannot invoke "org.apache.calcite.rel.core.TableScan.getTable()" because
> "scan" is null
>
>
> Key: DRILL-8058
> URL: https://issues.apache.org/jira/browse/DRILL-8058
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - Iceberg
>Affects Versions: 1.19.0
>Reporter: Vitalii Diravka
>Assignee: Vova Vysotskyi
>Priority: Major
> Labels: iceberg, storage
> Fix For: Future
>
>
> Checked in Drill embedded the query form
> _TestE2EUnnestAndLateral#testMultipleBatchesLateral_WithLimitInParent_ test
> case:
> {code:java}
> SELECT customer.c_name, avg(orders.o_totalprice) AS avgPrice FROM
> dfs.`/{custom_path}/drill/exec/java-exec/target/org.apache.drill.exec.physical.impl.lateraljoin.TestE2EUnnestAndLateral/root/lateraljoin/multipleFiles`
>
> customer, LATERAL (SELECT t.ord.o_totalprice as o_totalprice FROM
> UNNEST(customer.c_orders) t(ord)
> WHERE t.ord.o_totalprice > 10 LIMIT 2) orders GROUP BY customer.c_name;
> {code}
> But it gives the following error:
> {code:java}
> Caused by: java.lang.NullPointerException: Cannot invoke
> "org.apache.calcite.rel.core.TableScan.getTable()" because "scan" is null
> at
> org.apache.drill.exec.planner.common.DrillRelOptUtil.getDrillTable(DrillRelOptUtil.java:691)
> at
> org.apache.drill.exec.store.iceberg.plan.IcebergPluginImplementor.canImplement(IcebergPluginImplementor.java:101)
> at
> org.apache.drill.exec.store.plan.rule.PluginConverterRule.matches(PluginConverterRule.java:64)
> at
> org.apache.calcite.plan.volcano.VolcanoRuleCall.matchRecurse(VolcanoRuleCall.java:263)
> at
> org.apache.calcite.plan.volcano.VolcanoRuleCall.match(VolcanoRuleCall.java:247)
> at
> org.apache.calcite.plan.volcano.VolcanoPlanner.fireRules(VolcanoPlanner.java:1566)
> at
> org.apache.calcite.plan.volcano.VolcanoPlanner.registerImpl(VolcanoPlanner.java:1840)
> at
> org.apache.calcite.plan.volcano.VolcanoPlanner.register(VolcanoPlanner.java:848)
> at
> org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:864)
> at
> org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:92)
> at
> org.apache.calcite.rel.AbstractRelNode.onRegister(AbstractRelNode.java:329)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (DRILL-8067) Web UI loads slowly for Drill users in China mainland
[ https://issues.apache.org/jira/browse/DRILL-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17455361#comment-17455361 ] ASF GitHub Bot commented on DRILL-8067: --- cgivre merged pull request #2395: URL: https://github.com/apache/drill/pull/2395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Web UI loads slowly for Drill users in China mainland > - > > Key: DRILL-8067 > URL: https://issues.apache.org/jira/browse/DRILL-8067 > Project: Apache Drill > Issue Type: Improvement >Reporter: Jingchuan Hu >Priority: Major > > Drill Web UI sends a request to googles' URL. Since China mainland cannot > visit google directly, Web UI refreshes slowly because each request have to > wait the request timeout. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (DRILL-8069) remove use of excel sheet getLastRowNum
[
https://issues.apache.org/jira/browse/DRILL-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17455359#comment-17455359
]
ASF GitHub Bot commented on DRILL-8069:
---
cgivre commented on a change in pull request #2396:
URL: https://github.com/apache/drill/pull/2396#discussion_r764507669
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##
@@ -154,7 +154,7 @@ public String getFieldName() {
private int totalColumnCount;
private boolean firstLine;
private FileSplit split;
- private int recordCount;
+ private int recordCount = 0;
Review comment:
I don't think this is actually necessary since an undefined `int` will
be `0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> remove use of excel sheet getLastRowNum
> ---
>
> Key: DRILL-8069
> URL: https://issues.apache.org/jira/browse/DRILL-8069
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Data Types
>Reporter: PJ Fanning
>Priority: Major
>
> excel-streaming-reader can only get last row num from sheets that have
> dimension data and not all sheets have this set - it is safer to iterate
> through the row data and not try to shortcut the reading of the sheet based
> on getLastRowNum
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (DRILL-8015) Add MongoDB Metastore implementation
[
https://issues.apache.org/jira/browse/DRILL-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17455332#comment-17455332
]
ASF GitHub Bot commented on DRILL-8015:
---
luocooong commented on a change in pull request #2384:
URL: https://github.com/apache/drill/pull/2384#discussion_r764881739
##
File path:
metastore/mongo-metastore/src/main/java/org/apache/drill/metastore/mongo/MongoMetastore.java
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.metastore.mongo;
+
+import com.mongodb.ConnectionString;
+import com.mongodb.MongoClientSettings;
+import com.mongodb.MongoCredential;
+import com.mongodb.ServerAddress;
+import com.mongodb.client.MongoClient;
+import com.mongodb.client.MongoClients;
+import org.apache.drill.common.config.DrillConfig;
+import org.apache.drill.metastore.Metastore;
+import org.apache.drill.metastore.components.tables.Tables;
+import org.apache.drill.metastore.components.views.Views;
+import org.apache.drill.metastore.mongo.components.tables.MongoTables;
+import org.apache.drill.metastore.mongo.config.MongoConfigConstants;
+import org.apache.drill.shaded.guava.com.google.common.collect.Lists;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+
+/**
+ * Mongo Drill Metastore implementation.
+ */
+public class MongoMetastore implements Metastore {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MongoMetastore.class);
+
+ private final ConnectionString clientURI;
+ private final MongoClient client;
+
+ public MongoMetastore(DrillConfig config) {
+this.clientURI =
+ new ConnectionString(config.getString(MongoConfigConstants.CONNECTION));
+this.client = getClient();
+ }
+
+ @Override
+ public Tables tables() {
+return new MongoTables(client);
+ }
+
+ @Override
+ public Views views() {
+throw new UnsupportedOperationException("Views metadata support is not
implemented");
+ }
+
+ public MongoClient getClient() {
Review comment:
`private` the keyword if this function is not called publicly.
##
File path:
metastore/mongo-metastore/src/main/java/org/apache/drill/metastore/mongo/MongoMetastore.java
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.metastore.mongo;
+
+import com.mongodb.ConnectionString;
+import com.mongodb.MongoClientSettings;
+import com.mongodb.MongoCredential;
+import com.mongodb.ServerAddress;
+import com.mongodb.client.MongoClient;
+import com.mongodb.client.MongoClients;
+import org.apache.drill.common.config.DrillConfig;
+import org.apache.drill.metastore.Metastore;
+import org.apache.drill.metastore.components.tables.Tables;
+import org.apache.drill.metastore.components.views.Views;
+import org.apache.drill.metastore.mongo.components.tables.MongoTables;
+import org.apache.drill.metastore.mongo.config.MongoConfigConstants;
+import org.apache.drill.shaded.guava.com.google.common.collect.Lists;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+
+/**
+ * Mongo Drill Metastore implementation.
+ */
+public class MongoMetastore implements Metastore {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MongoMetastore.class);
+
+ private final ConnectionString clientURI;
+ private final MongoClient client;
+
+ p
[jira] [Commented] (DRILL-8015) Add MongoDB Metastore implementation
[ https://issues.apache.org/jira/browse/DRILL-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17455326#comment-17455326 ] ASF GitHub Bot commented on DRILL-8015: --- dzamo commented on pull request #2384: URL: https://github.com/apache/drill/pull/2384#issuecomment-988922680 @Leon-WTF @luocooong, w.r.t to the release of 1.20 and having read this PR's comments I just want to check if we're deadlocked here with author waiting for reviewers and reviewers waiting for author? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add MongoDB Metastore implementation > > > Key: DRILL-8015 > URL: https://issues.apache.org/jira/browse/DRILL-8015 > Project: Apache Drill > Issue Type: Improvement > Components: Metadata >Reporter: wtf >Assignee: wtf >Priority: Minor > > Add a NoSQL Metastore implementation -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (DRILL-8067) Web UI loads slowly for Drill users in China mainland
[
https://issues.apache.org/jira/browse/DRILL-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17455066#comment-17455066
]
ASF GitHub Bot commented on DRILL-8067:
---
vdiravka commented on a change in pull request #2395:
URL: https://github.com/apache/drill/pull/2395#discussion_r764667955
##
File path: exec/java-exec/src/main/resources/rest/static/css/drillStyle.css
##
@@ -7,3 +7,27 @@ body {
.close {
outline: none;
}
+
+/* Material + Icons */
+@font-face {
+ font-family: 'Material Icons';
+ font-style: normal;
+ font-weight: 400;
+ src: url('materialicons_v118.woff2') format('woff2');
+}
+
+.material-icons {
+ font-family: 'Material Icons';
+ font-weight: normal;
+ font-style: normal;
+ font-size: 24px;
+ line-height: 1;
+ letter-spacing: normal;
+ text-transform: none;
+ display: inline-block;
+ white-space: nowrap;
+ word-wrap: normal;
+ direction: ltr;
+ -webkit-font-feature-settings: 'liga';
+ -webkit-font-smoothing: antialiased;
+}
Review comment:
```suggestion
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Web UI loads slowly for Drill users in China mainland
> -
>
> Key: DRILL-8067
> URL: https://issues.apache.org/jira/browse/DRILL-8067
> Project: Apache Drill
> Issue Type: Improvement
>Reporter: Jingchuan Hu
>Priority: Major
>
> Drill Web UI sends a request to googles' URL. Since China mainland cannot
> visit google directly, Web UI refreshes slowly because each request have to
> wait the request timeout.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (DRILL-7983) Add a REST API to support the get running or completed profiles
[
https://issues.apache.org/jira/browse/DRILL-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17455045#comment-17455045
]
ASF GitHub Bot commented on DRILL-7983:
---
CuteKittyhoho commented on pull request #2353:
URL: https://github.com/apache/drill/pull/2353#issuecomment-988608321
@paul-rogers @cgivre Thanks again for your good advice! I have finished task
of real test now. It first issued two queries then checked the results from
```/profiles.json```, ```/profiles/running``` and ```/profiles/completed```
respectively. Adding a status parameter in GET request such as
```/profiles/json?status=[all|running|completed]``` is also done, so could you
please review these things now? However, implementing a test with threads to
check running queries is a bit of challenging, so it still need some time for
me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a REST API to support the get running or completed profiles
> ---
>
> Key: DRILL-7983
> URL: https://issues.apache.org/jira/browse/DRILL-7983
> Project: Apache Drill
> Issue Type: New Feature
>Reporter: Cong Luo
>Priority: Major
> Fix For: 1.20.0
>
>
> Drill have a REST API to get the profiles of running and completed queries.
> this goal of ticket is extended from the `/profiles.json` to support get the
> running or completed profiles (not all of them). the client does not need to
> filter with the state.
> old URI
> {code:java}
> /profiles.json{code}
> new URI
> {code:java}
> /profiles.json
> /profiles/running
> /profiles/completed{code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
