[jira] [Updated] (DRILL-8215) Remove SecurityContext from PluginConfigWrapper
[ https://issues.apache.org/jira/browse/DRILL-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8215: Affects Version/s: (was: 1.20.0) > Remove SecurityContext from PluginConfigWrapper > --- > > Key: DRILL-8215 > URL: https://issues.apache.org/jira/browse/DRILL-8215 > Project: Apache Drill > Issue Type: Bug > Components: Web Server >Reporter: Charles Givre >Priority: Major > > Drill-8155 introduced a bug in the PluginConfigWrapper by including the > SecurityContext in it. This seemed to cause SerDe issues. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DRILL-8216) Use EVF-based JSON reader for Values operator
[ https://issues.apache.org/jira/browse/DRILL-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton closed DRILL-8216. --- > Use EVF-based JSON reader for Values operator > - > > Key: DRILL-8216 > URL: https://issues.apache.org/jira/browse/DRILL-8216 > Project: Apache Drill > Issue Type: Sub-task >Affects Versions: 1.20.1 >Reporter: Vova Vysotskyi >Assignee: Vova Vysotskyi >Priority: Major > Fix For: 2.0.0 > > > The newer Calcite version simplifies and removes casts for literals. It > causes wrong results for drillTypeOf and sqlTypeOf functions, since the > Values operator uses an old JSON reader which reads integers with bigInt type. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8216) Use EVF-based JSON reader for Values operator
[ https://issues.apache.org/jira/browse/DRILL-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8216: Affects Version/s: 1.20.1 > Use EVF-based JSON reader for Values operator > - > > Key: DRILL-8216 > URL: https://issues.apache.org/jira/browse/DRILL-8216 > Project: Apache Drill > Issue Type: Sub-task >Affects Versions: 1.20.1 >Reporter: Vova Vysotskyi >Assignee: Vova Vysotskyi >Priority: Major > Fix For: 2.0.0 > > > The newer Calcite version simplifies and removes casts for literals. It > causes wrong results for drillTypeOf and sqlTypeOf functions, since the > Values operator uses an old JSON reader which reads integers with bigInt type. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8216) Use EVF-based JSON reader for Values operator
[ https://issues.apache.org/jira/browse/DRILL-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8216: Fix Version/s: 2.0.0 > Use EVF-based JSON reader for Values operator > - > > Key: DRILL-8216 > URL: https://issues.apache.org/jira/browse/DRILL-8216 > Project: Apache Drill > Issue Type: Sub-task >Reporter: Vova Vysotskyi >Assignee: Vova Vysotskyi >Priority: Major > Fix For: 2.0.0 > > > The newer Calcite version simplifies and removes casts for literals. It > causes wrong results for drillTypeOf and sqlTypeOf functions, since the > Values operator uses an old JSON reader which reads integers with bigInt type. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (DRILL-8217) Credential Resources Page Throws an Error With Empty Lists.
[ https://issues.apache.org/jira/browse/DRILL-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542790#comment-17542790 ] James Turton commented on DRILL-8217: - [~cgivre] can we close this one? > Credential Resources Page Throws an Error With Empty Lists. > --- > > Key: DRILL-8217 > URL: https://issues.apache.org/jira/browse/DRILL-8217 > Project: Apache Drill > Issue Type: Bug > Components: Web Server >Affects Versions: 1.20.0 >Reporter: Charles Givre >Assignee: Charles Givre >Priority: Major > Fix For: 2.0.0 > > > If a user does not have any plugins enabled with USER_TRANSLATION on, the > Credentials page will throw an exception. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DRILL-8220) Add User Translation Support for OAuth Enabled Plugins
[ https://issues.apache.org/jira/browse/DRILL-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton closed DRILL-8220. --- Resolution: Fixed > Add User Translation Support for OAuth Enabled Plugins > -- > > Key: DRILL-8220 > URL: https://issues.apache.org/jira/browse/DRILL-8220 > Project: Apache Drill > Issue Type: Improvement > Components: Storage - Other >Affects Versions: 1.20.0 >Reporter: Charles Givre >Assignee: Charles Givre >Priority: Major > Fix For: 2.0.0 > > > This PR adds support for individual users to provide their own credentials > for plugins that use OAuth 2.0 as a means of authorization and > authentication. Currently, only the HTTP storage plugin supports OAuth, > however, this PR moves some of the core features out of the HTTP plugin so > that other plugins can access this. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DRILL-8222) Wrong function's implementation of concat_delim
[ https://issues.apache.org/jira/browse/DRILL-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton closed DRILL-8222. --- Resolution: Fixed > Wrong function's implementation of concat_delim > --- > > Key: DRILL-8222 > URL: https://issues.apache.org/jira/browse/DRILL-8222 > Project: Apache Drill > Issue Type: Bug > Components: Functions - Drill >Affects Versions: 1.20.1 >Reporter: Xurenhe >Priority: Major > Fix For: 1.20.2 > > Attachments: image-2022-05-11-19-07-28-586.png > > > Current function implementation of `concat_delim` is wrong. > {code:java} > select concat_delim(',', 'a', null, 'b') as c {code} > We may want the result of 'a,b', which ignore null value during executing. > > But, actual result is 'a,,b'. > I found the similar function(concat_ws) in MySQL and Postgres, and the > behavior is what I wish. > > > > {code:java} > @Test > public void testConcatDelimVarArgsWithNullValue() throws Exception { > testBuilder() > .sqlQuery("select concat_delim(',', 'a', null, 'b') as c") > .unOrdered() > .baselineColumns("c") > .baselineValues("a,b") > .go(); > } > {code} > !image-2022-05-11-19-07-28-586.png|width=576,height=218! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8222) Wrong function's implementation of concat_delim
[ https://issues.apache.org/jira/browse/DRILL-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8222: Affects Version/s: 1.20.1 > Wrong function's implementation of concat_delim > --- > > Key: DRILL-8222 > URL: https://issues.apache.org/jira/browse/DRILL-8222 > Project: Apache Drill > Issue Type: Bug > Components: Functions - Drill >Affects Versions: 1.20.1 >Reporter: Xurenhe >Priority: Major > Attachments: image-2022-05-11-19-07-28-586.png > > > Current function implementation of `concat_delim` is wrong. > {code:java} > select concat_delim(',', 'a', null, 'b') as c {code} > We may want the result of 'a,b', which ignore null value during executing. > > But, actual result is 'a,,b'. > I found the similar function(concat_ws) in MySQL and Postgres, and the > behavior is what I wish. > > > > {code:java} > @Test > public void testConcatDelimVarArgsWithNullValue() throws Exception { > testBuilder() > .sqlQuery("select concat_delim(',', 'a', null, 'b') as c") > .unOrdered() > .baselineColumns("c") > .baselineValues("a,b") > .go(); > } > {code} > !image-2022-05-11-19-07-28-586.png|width=576,height=218! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8222) Wrong function's implementation of concat_delim
[ https://issues.apache.org/jira/browse/DRILL-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8222: Fix Version/s: 1.20.2 > Wrong function's implementation of concat_delim > --- > > Key: DRILL-8222 > URL: https://issues.apache.org/jira/browse/DRILL-8222 > Project: Apache Drill > Issue Type: Bug > Components: Functions - Drill >Affects Versions: 1.20.1 >Reporter: Xurenhe >Priority: Major > Fix For: 1.20.2 > > Attachments: image-2022-05-11-19-07-28-586.png > > > Current function implementation of `concat_delim` is wrong. > {code:java} > select concat_delim(',', 'a', null, 'b') as c {code} > We may want the result of 'a,b', which ignore null value during executing. > > But, actual result is 'a,,b'. > I found the similar function(concat_ws) in MySQL and Postgres, and the > behavior is what I wish. > > > > {code:java} > @Test > public void testConcatDelimVarArgsWithNullValue() throws Exception { > testBuilder() > .sqlQuery("select concat_delim(',', 'a', null, 'b') as c") > .unOrdered() > .baselineColumns("c") > .baselineValues("a,b") > .go(); > } > {code} > !image-2022-05-11-19-07-28-586.png|width=576,height=218! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DRILL-8223) Refactor auth modes dropping DRILL_PROCESS and allowing credential providers everywhere
[ https://issues.apache.org/jira/browse/DRILL-8223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton closed DRILL-8223. --- > Refactor auth modes dropping DRILL_PROCESS and allowing credential providers > everywhere > --- > > Key: DRILL-8223 > URL: https://issues.apache.org/jira/browse/DRILL-8223 > Project: Apache Drill > Issue Type: Improvement > Components: Security >Affects Versions: 2.0.0 >Reporter: James Turton >Assignee: James Turton >Priority: Major > Fix For: 2.0.0 > > > Remove the abstract CredentialedStoragePluginConfig (formerly > AbstractSecuredStoragePluginConfig) class and promote the credential provider > members to the parent StoragePluginConfig. Since having a credential provider > provider is optional, there is no harm in giving the capability to every > plugin's config. > Drop the DRILL_PROCESS auth mode since this case is adequately covered by > using SHARED_USER with no credentials specified. > Bug fix. In storage-jdbc and when there are no JDBC credentials for the query > user, only forgo an attempt to connect if the auth mode is USER_TRANSLATION. > If it is SHARED_USER, proceed with an attempt to connect (examples of this > case are unsecured DBs and BigQuery which requires OAuth tokens in the JDBC > URL instead of a JDBC username and password). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8224) Fix TestHttpPlugin#testSlowResponse
[ https://issues.apache.org/jira/browse/DRILL-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8224: Affects Version/s: 1.20.1 > Fix TestHttpPlugin#testSlowResponse > --- > > Key: DRILL-8224 > URL: https://issues.apache.org/jira/browse/DRILL-8224 > Project: Apache Drill > Issue Type: Sub-task >Affects Versions: 1.20.1 >Reporter: Vitalii Diravka >Assignee: Vitalii Diravka >Priority: Major > > In > [DRILL-7973|https://github.com/apache/drill/commit/304230a289505526e1ff1bb1aae932517b7b6965#diff-c6b42ccd4a5372e7c299b3b8052455c0fe618403a957e0b1b908edf46eee4809R880] > timeout for http request in mock http plugin was changed. > But looks like we need to use other method, not {{_throttleBody:_}} > * Throttles the request reader and response writer to sleep for the given > period after each > * series of [bytesPerPeriod] bytes are transferred. Use this to simulate > network behavior. > That means we can sleep longer than 6 seconds, but 10s configured in plugin. > Possibly {{_new MockResponse().setBodyDelay(20, > TimeUnit.DAYS).setHeadersDelay(20, TimeUnit.DAYS);_}} should work: > https://github.com/square/okhttp/issues/6976#issuecomment-1006028317 > Also current MockWebServer 4.9.2 version can be updated to 4.9.3: > https://mvnrepository.com/artifact/com.squareup.okhttp3/mockwebserver/4.9.3 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (DRILL-8223) Refactor auth modes dropping DRILL_PROCESS and allowing credential providers everywhere
[ https://issues.apache.org/jira/browse/DRILL-8223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton resolved DRILL-8223. - Resolution: Fixed > Refactor auth modes dropping DRILL_PROCESS and allowing credential providers > everywhere > --- > > Key: DRILL-8223 > URL: https://issues.apache.org/jira/browse/DRILL-8223 > Project: Apache Drill > Issue Type: Improvement > Components: Security >Affects Versions: 2.0.0 >Reporter: James Turton >Assignee: James Turton >Priority: Major > Fix For: 2.0.0 > > > Remove the abstract CredentialedStoragePluginConfig (formerly > AbstractSecuredStoragePluginConfig) class and promote the credential provider > members to the parent StoragePluginConfig. Since having a credential provider > provider is optional, there is no harm in giving the capability to every > plugin's config. > Drop the DRILL_PROCESS auth mode since this case is adequately covered by > using SHARED_USER with no credentials specified. > Bug fix. In storage-jdbc and when there are no JDBC credentials for the query > user, only forgo an attempt to connect if the auth mode is USER_TRANSLATION. > If it is SHARED_USER, proceed with an attempt to connect (examples of this > case are unsecured DBs and BigQuery which requires OAuth tokens in the JDBC > URL instead of a JDBC username and password). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DRILL-8224) Fix TestHttpPlugin#testSlowResponse
[ https://issues.apache.org/jira/browse/DRILL-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton closed DRILL-8224. --- > Fix TestHttpPlugin#testSlowResponse > --- > > Key: DRILL-8224 > URL: https://issues.apache.org/jira/browse/DRILL-8224 > Project: Apache Drill > Issue Type: Sub-task >Affects Versions: 1.20.1 >Reporter: Vitalii Diravka >Assignee: Vitalii Diravka >Priority: Major > Fix For: 1.20.2 > > > In > [DRILL-7973|https://github.com/apache/drill/commit/304230a289505526e1ff1bb1aae932517b7b6965#diff-c6b42ccd4a5372e7c299b3b8052455c0fe618403a957e0b1b908edf46eee4809R880] > timeout for http request in mock http plugin was changed. > But looks like we need to use other method, not {{_throttleBody:_}} > * Throttles the request reader and response writer to sleep for the given > period after each > * series of [bytesPerPeriod] bytes are transferred. Use this to simulate > network behavior. > That means we can sleep longer than 6 seconds, but 10s configured in plugin. > Possibly {{_new MockResponse().setBodyDelay(20, > TimeUnit.DAYS).setHeadersDelay(20, TimeUnit.DAYS);_}} should work: > https://github.com/square/okhttp/issues/6976#issuecomment-1006028317 > Also current MockWebServer 4.9.2 version can be updated to 4.9.3: > https://mvnrepository.com/artifact/com.squareup.okhttp3/mockwebserver/4.9.3 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8224) Fix TestHttpPlugin#testSlowResponse
[ https://issues.apache.org/jira/browse/DRILL-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8224: Fix Version/s: 1.20.2 > Fix TestHttpPlugin#testSlowResponse > --- > > Key: DRILL-8224 > URL: https://issues.apache.org/jira/browse/DRILL-8224 > Project: Apache Drill > Issue Type: Sub-task >Affects Versions: 1.20.1 >Reporter: Vitalii Diravka >Assignee: Vitalii Diravka >Priority: Major > Fix For: 1.20.2 > > > In > [DRILL-7973|https://github.com/apache/drill/commit/304230a289505526e1ff1bb1aae932517b7b6965#diff-c6b42ccd4a5372e7c299b3b8052455c0fe618403a957e0b1b908edf46eee4809R880] > timeout for http request in mock http plugin was changed. > But looks like we need to use other method, not {{_throttleBody:_}} > * Throttles the request reader and response writer to sleep for the given > period after each > * series of [bytesPerPeriod] bytes are transferred. Use this to simulate > network behavior. > That means we can sleep longer than 6 seconds, but 10s configured in plugin. > Possibly {{_new MockResponse().setBodyDelay(20, > TimeUnit.DAYS).setHeadersDelay(20, TimeUnit.DAYS);_}} should work: > https://github.com/square/okhttp/issues/6976#issuecomment-1006028317 > Also current MockWebServer 4.9.2 version can be updated to 4.9.3: > https://mvnrepository.com/artifact/com.squareup.okhttp3/mockwebserver/4.9.3 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8225) Update LogParser and Yauaa dependencies
[ https://issues.apache.org/jira/browse/DRILL-8225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8225: Fix Version/s: 2.0.0 > Update LogParser and Yauaa dependencies > --- > > Key: DRILL-8225 > URL: https://issues.apache.org/jira/browse/DRILL-8225 > Project: Apache Drill > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: Niels Basjes >Assignee: Niels Basjes >Priority: Minor > Fix For: 2.0.0 > > > This also includes making the new support for Client Hints available (and > related tests). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DRILL-8225) Update LogParser and Yauaa dependencies
[ https://issues.apache.org/jira/browse/DRILL-8225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton closed DRILL-8225. --- > Update LogParser and Yauaa dependencies > --- > > Key: DRILL-8225 > URL: https://issues.apache.org/jira/browse/DRILL-8225 > Project: Apache Drill > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: Niels Basjes >Assignee: Niels Basjes >Priority: Minor > Fix For: 2.0.0 > > > This also includes making the new support for Client Hints available (and > related tests). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8225) Update LogParser and Yauaa dependencies
[ https://issues.apache.org/jira/browse/DRILL-8225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8225: Affects Version/s: 2.0.0 > Update LogParser and Yauaa dependencies > --- > > Key: DRILL-8225 > URL: https://issues.apache.org/jira/browse/DRILL-8225 > Project: Apache Drill > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: Niels Basjes >Assignee: Niels Basjes >Priority: Minor > > This also includes making the new support for Client Hints available (and > related tests). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8228) Drill2288GetColumnsMetadataWhenNoRowsTest regression
[ https://issues.apache.org/jira/browse/DRILL-8228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8228: Fix Version/s: 1.20.2 > Drill2288GetColumnsMetadataWhenNoRowsTest regression > > > Key: DRILL-8228 > URL: https://issues.apache.org/jira/browse/DRILL-8228 > Project: Apache Drill > Issue Type: Sub-task >Affects Versions: 1.20.1 >Reporter: Vitalii Diravka >Assignee: Vitalii Diravka >Priority: Major > Labels: backport-to-stable > Fix For: 1.20.2 > > > Drill2288GetColumnsMetadataWhenNoRowsTest starts to fail after DRILL-8225 > {code:java} > Error: Failures: > Error:Drill2288GetColumnsMetadataWhenNoRowsTest Multiple Failures (2 > failures) > java.lang.NullPointerException: Cannot invoke > "java.io.File.getAbsolutePath()" because the return value of > "org.apache.drill.test.BaseDirTestWatcher.getTmpDir()" is null > java.lang.NullPointerException: Cannot invoke > "java.sql.Connection.close()" because > "org.apache.drill.jdbc.test.Drill2288GetColumnsMetadataWhenNoRowsTest.connection" > is null > {code} > https://github.com/apache/drill/runs/6499401042?check_suite_focus=true -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DRILL-8228) Drill2288GetColumnsMetadataWhenNoRowsTest regression
[ https://issues.apache.org/jira/browse/DRILL-8228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton closed DRILL-8228. --- > Drill2288GetColumnsMetadataWhenNoRowsTest regression > > > Key: DRILL-8228 > URL: https://issues.apache.org/jira/browse/DRILL-8228 > Project: Apache Drill > Issue Type: Sub-task >Affects Versions: 1.20.1 >Reporter: Vitalii Diravka >Assignee: Vitalii Diravka >Priority: Major > Labels: backport-to-stable > Fix For: 1.20.2 > > > Drill2288GetColumnsMetadataWhenNoRowsTest starts to fail after DRILL-8225 > {code:java} > Error: Failures: > Error:Drill2288GetColumnsMetadataWhenNoRowsTest Multiple Failures (2 > failures) > java.lang.NullPointerException: Cannot invoke > "java.io.File.getAbsolutePath()" because the return value of > "org.apache.drill.test.BaseDirTestWatcher.getTmpDir()" is null > java.lang.NullPointerException: Cannot invoke > "java.sql.Connection.close()" because > "org.apache.drill.jdbc.test.Drill2288GetColumnsMetadataWhenNoRowsTest.connection" > is null > {code} > https://github.com/apache/drill/runs/6499401042?check_suite_focus=true -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DRILL-8227) JConnect and jTDS JDBC drivers do not implement Connection::getSchema
[ https://issues.apache.org/jira/browse/DRILL-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton closed DRILL-8227. --- > JConnect and jTDS JDBC drivers do not implement Connection::getSchema > - > > Key: DRILL-8227 > URL: https://issues.apache.org/jira/browse/DRILL-8227 > Project: Apache Drill > Issue Type: Bug > Components: 1.19 >Affects Versions: 1.19.0 > Environment: Apache drill - 1.19.0 , jdk1.8.0_121 , jre1.8.0_121 , > Windows 10 Enterprise >Reporter: Nishanthi >Assignee: James Turton >Priority: Major > Fix For: 1.20.2 > > Attachments: Sybase_Exception.png, jTDS_Error.png, sqlline_log.png > > > Hi , > In Apache drill - 1.19.0 not able to execute a Sybase ASE related query > getting exception as org.apache.drill.common.exceptions.UserRemoteException: > SYSTEM ERROR: AbstractMethodError: > com.sybase.jdbc4.jdbc.SybConnection.getSchema()Ljava/lang/String > jar - jconn4, > "driver": "com.sybase.jdbc4.jdbc.SybDriver" , > "url": "jdbc:sybase:Tds:?:/" > Query : > select * from .. > Able to execute the query for same configuration with same jar and driver in > apache drill 1.17.0 but not in apache drill 1.19.0. > Kindly, look into it as it is coming as a blocker while trying to query with > sybase ase -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8228) Drill2288GetColumnsMetadataWhenNoRowsTest regression
[ https://issues.apache.org/jira/browse/DRILL-8228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8228: Affects Version/s: 1.20.1 > Drill2288GetColumnsMetadataWhenNoRowsTest regression > > > Key: DRILL-8228 > URL: https://issues.apache.org/jira/browse/DRILL-8228 > Project: Apache Drill > Issue Type: Sub-task >Affects Versions: 1.20.1 >Reporter: Vitalii Diravka >Assignee: Vitalii Diravka >Priority: Major > Labels: backport-to-stable > > Drill2288GetColumnsMetadataWhenNoRowsTest starts to fail after DRILL-8225 > {code:java} > Error: Failures: > Error:Drill2288GetColumnsMetadataWhenNoRowsTest Multiple Failures (2 > failures) > java.lang.NullPointerException: Cannot invoke > "java.io.File.getAbsolutePath()" because the return value of > "org.apache.drill.test.BaseDirTestWatcher.getTmpDir()" is null > java.lang.NullPointerException: Cannot invoke > "java.sql.Connection.close()" because > "org.apache.drill.jdbc.test.Drill2288GetColumnsMetadataWhenNoRowsTest.connection" > is null > {code} > https://github.com/apache/drill/runs/6499401042?check_suite_focus=true -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DRILL-8229) Add Parameter to Skip Malformed Records to HTTP UDF
[ https://issues.apache.org/jira/browse/DRILL-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton closed DRILL-8229. --- > Add Parameter to Skip Malformed Records to HTTP UDF > > > Key: DRILL-8229 > URL: https://issues.apache.org/jira/browse/DRILL-8229 > Project: Apache Drill > Issue Type: Improvement > Components: Functions - Drill >Affects Versions: 2.0.0 >Reporter: Charles Givre >Assignee: Charles Givre >Priority: Minor > Fix For: 2.0.0 > > > The http_get and http_request UDFs were not using the JSON parameter to skip > malformed records. This PR fixes that. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8229) Add Parameter to Skip Malformed Records to HTTP UDF
[ https://issues.apache.org/jira/browse/DRILL-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8229: Fix Version/s: 2.0.0 (was: 1.20.2) > Add Parameter to Skip Malformed Records to HTTP UDF > > > Key: DRILL-8229 > URL: https://issues.apache.org/jira/browse/DRILL-8229 > Project: Apache Drill > Issue Type: Improvement > Components: Functions - Drill >Affects Versions: 2.0.0 >Reporter: Charles Givre >Assignee: Charles Givre >Priority: Minor > Fix For: 2.0.0 > > > The http_get and http_request UDFs were not using the JSON parameter to skip > malformed records. This PR fixes that. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8229) Add Parameter to Skip Malformed Records to HTTP UDF
[ https://issues.apache.org/jira/browse/DRILL-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8229: Affects Version/s: 2.0.0 (was: 1.20.1) > Add Parameter to Skip Malformed Records to HTTP UDF > > > Key: DRILL-8229 > URL: https://issues.apache.org/jira/browse/DRILL-8229 > Project: Apache Drill > Issue Type: Improvement > Components: Functions - Drill >Affects Versions: 2.0.0 >Reporter: Charles Givre >Assignee: Charles Givre >Priority: Minor > Fix For: 1.20.2 > > > The http_get and http_request UDFs were not using the JSON parameter to skip > malformed records. This PR fixes that. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DRILL-8230) upgrade to poi 5.2.2
[ https://issues.apache.org/jira/browse/DRILL-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton closed DRILL-8230. --- Resolution: Fixed > upgrade to poi 5.2.2 > > > Key: DRILL-8230 > URL: https://issues.apache.org/jira/browse/DRILL-8230 > Project: Apache Drill > Issue Type: Improvement >Affects Versions: 1.20.1 >Reporter: PJ Fanning >Priority: Major > Fix For: 1.20.2 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8231) Wrong result in the COUNT function position.
[ https://issues.apache.org/jira/browse/DRILL-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8231: Fix Version/s: 1.20.2 > Wrong result in the COUNT function position. > > > Key: DRILL-8231 > URL: https://issues.apache.org/jira/browse/DRILL-8231 > Project: Apache Drill > Issue Type: Bug >Affects Versions: 1.18.0 >Reporter: manabu nagamine >Priority: Major > Fix For: 1.20.2 > > Attachments: drill.zip > > > Hi Team. > We using Drill 1.18. > There is a phenomenon that the count values of COL4452 are different in the > execution results of the following queries. > The only difference is that the positions of COL4452 and COL6408 have been > changed. > {code:java} > 1. > select COUNT(DISTINCT val2) COL4452, SUM(CAST(val11 as BIGINT)+CAST(val12 as > BIGINT)) COL6408 from dfs.root.`/drill/data/*/log_15872_R_79_*.parquet` WHERE > 1 = 1 and ( ( dir0 between '01' and '10' ) ) and ( LOG_DATE >= '2022-04-01 > 00:00:00.00' and LOG_DATE <= '2022-04-30 23:59:59.00'); > 2. > select SUM(CAST(val11 as BIGINT)+CAST(val12 as BIGINT)) COL6408, > COUNT(DISTINCT val2) COL4452 from > dfs.root.`/drill/data/*/log_15872_R_79_*.parquet` WHERE 1 = 1 and ( ( dir0 > between '01' and '10' ) ) and ( LOG_DATE >= '2022-04-01 00:00:00.00' and > LOG_DATE <= '2022-04-30 23:59:59.00');{code} > As for the actual data, the count with COL4452 at the beginning of 1. is > correct. > I am having trouble understanding the cause of this phenomenon. > Can anybody help me?Thanks in advance. > Attached the parquet log file. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8230) upgrade to poi 5.2.2
[ https://issues.apache.org/jira/browse/DRILL-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8230: Affects Version/s: 1.20.1 > upgrade to poi 5.2.2 > > > Key: DRILL-8230 > URL: https://issues.apache.org/jira/browse/DRILL-8230 > Project: Apache Drill > Issue Type: Improvement >Affects Versions: 1.20.1 >Reporter: PJ Fanning >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8230) upgrade to poi 5.2.2
[ https://issues.apache.org/jira/browse/DRILL-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8230: Fix Version/s: 1.20.2 > upgrade to poi 5.2.2 > > > Key: DRILL-8230 > URL: https://issues.apache.org/jira/browse/DRILL-8230 > Project: Apache Drill > Issue Type: Improvement >Affects Versions: 1.20.1 >Reporter: PJ Fanning >Priority: Major > Fix For: 1.20.2 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DRILL-8233) Change JDK 17 Docker base image from Oracle Linux to Debian.
[ https://issues.apache.org/jira/browse/DRILL-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton closed DRILL-8233. --- Resolution: Fixed > Change JDK 17 Docker base image from Oracle Linux to Debian. > > > Key: DRILL-8233 > URL: https://issues.apache.org/jira/browse/DRILL-8233 > Project: Apache Drill > Issue Type: Bug > Components: Tools, Build Test >Affects Versions: 1.20.1 >Reporter: James Turton >Assignee: James Turton >Priority: Minor > Fix For: 1.20.2 > > > The change is made in order to remain consistent with the OS in the base > images for JDK 8 and 11 since users may have derived from the Drill > Dockerfile or written other scripts that assume a Debian-like OS inside the > Docker image. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8232) Add support for user credentials to VaultCredentialsProvider
[ https://issues.apache.org/jira/browse/DRILL-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8232: Affects Version/s: 2.0.0 > Add support for user credentials to VaultCredentialsProvider > > > Key: DRILL-8232 > URL: https://issues.apache.org/jira/browse/DRILL-8232 > Project: Apache Drill > Issue Type: Improvement > Components: Security >Affects Versions: 2.0.0 >Reporter: James Turton >Assignee: James Turton >Priority: Minor > Fix For: 2.0.0 > > > The VaultCredentialsProvider can join the PlainCredentialsProvider in > supporting user credentials, credentials that stored for each each Drill > query user, by constructing a Vault secret path dynamically based on the name > of the query user. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DRILL-8232) Add support for user credentials to VaultCredentialsProvider
[ https://issues.apache.org/jira/browse/DRILL-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton closed DRILL-8232. --- Resolution: Fixed > Add support for user credentials to VaultCredentialsProvider > > > Key: DRILL-8232 > URL: https://issues.apache.org/jira/browse/DRILL-8232 > Project: Apache Drill > Issue Type: Improvement > Components: Security >Affects Versions: 2.0.0 >Reporter: James Turton >Assignee: James Turton >Priority: Minor > Fix For: 2.0.0 > > > The VaultCredentialsProvider can join the PlainCredentialsProvider in > supporting user credentials, credentials that stored for each each Drill > query user, by constructing a Vault secret path dynamically based on the name > of the query user. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8234) Register rules only from plugins used in the query
[ https://issues.apache.org/jira/browse/DRILL-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8234: Affects Version/s: 1.20.1 > Register rules only from plugins used in the query > -- > > Key: DRILL-8234 > URL: https://issues.apache.org/jira/browse/DRILL-8234 > Project: Apache Drill > Issue Type: Improvement >Affects Versions: 1.20.1 >Reporter: Vova Vysotskyi >Assignee: Vova Vysotskyi >Priority: Major > > Currently, rules from all enabled plugins are collected for query planning. > It could cause issues when one of the plugins became invalid. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DRILL-8234) Register rules only from plugins used in the query
[ https://issues.apache.org/jira/browse/DRILL-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton closed DRILL-8234. --- > Register rules only from plugins used in the query > -- > > Key: DRILL-8234 > URL: https://issues.apache.org/jira/browse/DRILL-8234 > Project: Apache Drill > Issue Type: Improvement >Affects Versions: 1.20.1 >Reporter: Vova Vysotskyi >Assignee: Vova Vysotskyi >Priority: Major > Fix For: 1.20.2 > > > Currently, rules from all enabled plugins are collected for query planning. > It could cause issues when one of the plugins became invalid. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8234) Register rules only from plugins used in the query
[ https://issues.apache.org/jira/browse/DRILL-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8234: Fix Version/s: 1.20.2 > Register rules only from plugins used in the query > -- > > Key: DRILL-8234 > URL: https://issues.apache.org/jira/browse/DRILL-8234 > Project: Apache Drill > Issue Type: Improvement >Affects Versions: 1.20.1 >Reporter: Vova Vysotskyi >Assignee: Vova Vysotskyi >Priority: Major > Fix For: 1.20.2 > > > Currently, rules from all enabled plugins are collected for query planning. > It could cause issues when one of the plugins became invalid. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8236) Move HttpHelperFunctions to use JSON2 reader
[ https://issues.apache.org/jira/browse/DRILL-8236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8236: Affects Version/s: 2.0.0 > Move HttpHelperFunctions to use JSON2 reader > > > Key: DRILL-8236 > URL: https://issues.apache.org/jira/browse/DRILL-8236 > Project: Apache Drill > Issue Type: Improvement > Components: Client - HTTP >Affects Versions: 2.0.0 >Reporter: Vitalii Diravka >Assignee: Vitalii Diravka >Priority: Major > > HttpHelperFunctions still uses old JSON reader. Need to swtich it to the new > EVF based reader -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8236) Move HttpHelperFunctions to use JSON2 reader
[ https://issues.apache.org/jira/browse/DRILL-8236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton updated DRILL-8236: Fix Version/s: 2.0.0 > Move HttpHelperFunctions to use JSON2 reader > > > Key: DRILL-8236 > URL: https://issues.apache.org/jira/browse/DRILL-8236 > Project: Apache Drill > Issue Type: Improvement > Components: Client - HTTP >Affects Versions: 2.0.0 >Reporter: Vitalii Diravka >Assignee: Vitalii Diravka >Priority: Major > Fix For: 2.0.0 > > > HttpHelperFunctions still uses old JSON reader. Need to swtich it to the new > EVF based reader -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DRILL-8237) Limit is not pushed down to scan for MSSQL
[ https://issues.apache.org/jira/browse/DRILL-8237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton closed DRILL-8237. --- Fix Version/s: 1.20.2 Resolution: Fixed > Limit is not pushed down to scan for MSSQL > -- > > Key: DRILL-8237 > URL: https://issues.apache.org/jira/browse/DRILL-8237 > Project: Apache Drill > Issue Type: Bug >Reporter: Vova Vysotskyi >Assignee: Vova Vysotskyi >Priority: Major > Fix For: 1.20.2 > > > [~dzamo] has noticed that the following test case will fail > {code:java} > @Test > public void testLimitPushDownWithOffset() throws Exception { > String query = "select person_id, first_name from mssql.dbo.person limit > 100 offset 10"; > queryBuilder() > .sql(query) > .planMatcher() > .include("Jdbc\\(.*SELECT TOP \\(110\\)") > .include("Limit\\(") > .match(); > } > {code} > because the limit wasn't pushed down. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (DRILL-8237) Limit is not pushed down to scan for MSSQL
[ https://issues.apache.org/jira/browse/DRILL-8237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542722#comment-17542722 ] ASF GitHub Bot commented on DRILL-8237: --- cgivre merged PR #2564: URL: https://github.com/apache/drill/pull/2564 > Limit is not pushed down to scan for MSSQL > -- > > Key: DRILL-8237 > URL: https://issues.apache.org/jira/browse/DRILL-8237 > Project: Apache Drill > Issue Type: Bug >Reporter: Vova Vysotskyi >Assignee: Vova Vysotskyi >Priority: Major > > [~dzamo] has noticed that the following test case will fail > {code:java} > @Test > public void testLimitPushDownWithOffset() throws Exception { > String query = "select person_id, first_name from mssql.dbo.person limit > 100 offset 10"; > queryBuilder() > .sql(query) > .planMatcher() > .include("Jdbc\\(.*SELECT TOP \\(110\\)") > .include("Limit\\(") > .match(); > } > {code} > because the limit wasn't pushed down. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (DRILL-8232) Add support for user credentials to VaultCredentialsProvider
[ https://issues.apache.org/jira/browse/DRILL-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542723#comment-17542723 ] ASF GitHub Bot commented on DRILL-8232: --- cgivre merged PR #2558: URL: https://github.com/apache/drill/pull/2558 > Add support for user credentials to VaultCredentialsProvider > > > Key: DRILL-8232 > URL: https://issues.apache.org/jira/browse/DRILL-8232 > Project: Apache Drill > Issue Type: Improvement > Components: Security >Reporter: James Turton >Assignee: James Turton >Priority: Minor > Fix For: 2.0.0 > > > The VaultCredentialsProvider can join the PlainCredentialsProvider in > supporting user credentials, credentials that stored for each each Drill > query user, by constructing a Vault secret path dynamically based on the name > of the query user. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (DRILL-8232) Add support for user credentials to VaultCredentialsProvider
[ https://issues.apache.org/jira/browse/DRILL-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542640#comment-17542640 ] ASF GitHub Bot commented on DRILL-8232: --- jnturton commented on code in PR #2558: URL: https://github.com/apache/drill/pull/2558#discussion_r882972296 ## docs/dev/PluginCredentialsProvider.md: ## @@ -118,7 +121,7 @@ Once it is set, we can configure storage plugin to use this way of obtaining cre } ``` -`secretPath` property specifies the Vault key value from which to read +`secretPath` property specifies the Vault key value from which to read. If the plugin's `authMode` is set to `user_translation` then the `secretPath` may include a variable named `$user` which will be replaced with the Drill query username at query execution time. Review Comment: @cgivre it's still optional and you could deliberately omit it as a trick to make user_translation translate to a single shared set of creds. To me me it seemed okay to allow that... > Add support for user credentials to VaultCredentialsProvider > > > Key: DRILL-8232 > URL: https://issues.apache.org/jira/browse/DRILL-8232 > Project: Apache Drill > Issue Type: Improvement > Components: Security >Reporter: James Turton >Assignee: James Turton >Priority: Minor > Fix For: 2.0.0 > > > The VaultCredentialsProvider can join the PlainCredentialsProvider in > supporting user credentials, credentials that stored for each each Drill > query user, by constructing a Vault secret path dynamically based on the name > of the query user. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (DRILL-8237) Limit is not pushed down to scan for MSSQL
[ https://issues.apache.org/jira/browse/DRILL-8237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542637#comment-17542637 ] ASF GitHub Bot commented on DRILL-8237: --- vvysotskyi commented on PR #2564: URL: https://github.com/apache/drill/pull/2564#issuecomment-1138897332 Yes, right after the first fix push down worked fine, but some changes broke it, and adding MSSQL tests helped to discover it. > Limit is not pushed down to scan for MSSQL > -- > > Key: DRILL-8237 > URL: https://issues.apache.org/jira/browse/DRILL-8237 > Project: Apache Drill > Issue Type: Bug >Reporter: Vova Vysotskyi >Assignee: Vova Vysotskyi >Priority: Major > > [~dzamo] has noticed that the following test case will fail > {code:java} > @Test > public void testLimitPushDownWithOffset() throws Exception { > String query = "select person_id, first_name from mssql.dbo.person limit > 100 offset 10"; > queryBuilder() > .sql(query) > .planMatcher() > .include("Jdbc\\(.*SELECT TOP \\(110\\)") > .include("Limit\\(") > .match(); > } > {code} > because the limit wasn't pushed down. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (DRILL-8232) Add support for user credentials to VaultCredentialsProvider
[ https://issues.apache.org/jira/browse/DRILL-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542635#comment-17542635 ] ASF GitHub Bot commented on DRILL-8232: --- cgivre commented on code in PR #2558: URL: https://github.com/apache/drill/pull/2558#discussion_r882962178 ## docs/dev/PluginCredentialsProvider.md: ## @@ -118,7 +121,7 @@ Once it is set, we can configure storage plugin to use this way of obtaining cre } ``` -`secretPath` property specifies the Vault key value from which to read +`secretPath` property specifies the Vault key value from which to read. If the plugin's `authMode` is set to `user_translation` then the `secretPath` may include a variable named `$user` which will be replaced with the Drill query username at query execution time. Review Comment: NIT/Question: If `user_translation` mode is enabled, isn't it a requirement that the `secretPath` contain `$user`? > Add support for user credentials to VaultCredentialsProvider > > > Key: DRILL-8232 > URL: https://issues.apache.org/jira/browse/DRILL-8232 > Project: Apache Drill > Issue Type: Improvement > Components: Security >Reporter: James Turton >Assignee: James Turton >Priority: Minor > Fix For: 2.0.0 > > > The VaultCredentialsProvider can join the PlainCredentialsProvider in > supporting user credentials, credentials that stored for each each Drill > query user, by constructing a Vault secret path dynamically based on the name > of the query user. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (DRILL-8237) Limit is not pushed down to scan for MSSQL
[ https://issues.apache.org/jira/browse/DRILL-8237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542631#comment-17542631 ] ASF GitHub Bot commented on DRILL-8237: --- vvysotskyi opened a new pull request, #2564: URL: https://github.com/apache/drill/pull/2564 # [DRILL-8237](https://issues.apache.org/jira/browse/DRILL-8237): Limit is not pushed down to scan for MSSQL ## Description Adjusted the cost of `DrillJdbcSort` to handle the case when the original limit was split ## Documentation NA ## Testing All unit tests passed, enabled disabled test which is fixed with these changes. > Limit is not pushed down to scan for MSSQL > -- > > Key: DRILL-8237 > URL: https://issues.apache.org/jira/browse/DRILL-8237 > Project: Apache Drill > Issue Type: Bug >Reporter: Vova Vysotskyi >Assignee: Vova Vysotskyi >Priority: Major > > [~dzamo] has noticed that the following test case will fail > {code:java} > @Test > public void testLimitPushDownWithOffset() throws Exception { > String query = "select person_id, first_name from mssql.dbo.person limit > 100 offset 10"; > queryBuilder() > .sql(query) > .planMatcher() > .include("Jdbc\\(.*SELECT TOP \\(110\\)") > .include("Limit\\(") > .match(); > } > {code} > because the limit wasn't pushed down. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (DRILL-8237) Limit is not pushed down to scan for MSSQL
[ https://issues.apache.org/jira/browse/DRILL-8237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vova Vysotskyi updated DRILL-8237: -- Summary: Limit is not pushed down to scan for MSSQL (was: Limit is not pushed for MSSQL) > Limit is not pushed down to scan for MSSQL > -- > > Key: DRILL-8237 > URL: https://issues.apache.org/jira/browse/DRILL-8237 > Project: Apache Drill > Issue Type: Bug >Reporter: Vova Vysotskyi >Assignee: Vova Vysotskyi >Priority: Major > > [~dzamo] has noticed that the following test case will fail > {code:java} > @Test > public void testLimitPushDownWithOffset() throws Exception { > String query = "select person_id, first_name from mssql.dbo.person limit > 100 offset 10"; > queryBuilder() > .sql(query) > .planMatcher() > .include("Jdbc\\(.*SELECT TOP \\(110\\)") > .include("Limit\\(") > .match(); > } > {code} > because the limit wasn't pushed down. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (DRILL-8237) Limit is not pushed for MSSQL
Vova Vysotskyi created DRILL-8237: - Summary: Limit is not pushed for MSSQL Key: DRILL-8237 URL: https://issues.apache.org/jira/browse/DRILL-8237 Project: Apache Drill Issue Type: Bug Reporter: Vova Vysotskyi Assignee: Vova Vysotskyi [~dzamo] has noticed that the following test case will fail {code:java} @Test public void testLimitPushDownWithOffset() throws Exception { String query = "select person_id, first_name from mssql.dbo.person limit 100 offset 10"; queryBuilder() .sql(query) .planMatcher() .include("Jdbc\\(.*SELECT TOP \\(110\\)") .include("Limit\\(") .match(); } {code} because the limit wasn't pushed down. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (DRILL-8232) Add support for user credentials to VaultCredentialsProvider
[ https://issues.apache.org/jira/browse/DRILL-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542535#comment-17542535 ] ASF GitHub Bot commented on DRILL-8232: --- jnturton commented on PR #2558: URL: https://github.com/apache/drill/pull/2558#issuecomment-1138691328 CI has passed but I was missing an Apache license header in a test resource. > Add support for user credentials to VaultCredentialsProvider > > > Key: DRILL-8232 > URL: https://issues.apache.org/jira/browse/DRILL-8232 > Project: Apache Drill > Issue Type: Improvement > Components: Security >Reporter: James Turton >Assignee: James Turton >Priority: Minor > Fix For: 2.0.0 > > > The VaultCredentialsProvider can join the PlainCredentialsProvider in > supporting user credentials, credentials that stored for each each Drill > query user, by constructing a Vault secret path dynamically based on the name > of the query user. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (DRILL-8236) Move HttpHelperFunctions to use JSON2 reader
Vitalii Diravka created DRILL-8236: -- Summary: Move HttpHelperFunctions to use JSON2 reader Key: DRILL-8236 URL: https://issues.apache.org/jira/browse/DRILL-8236 Project: Apache Drill Issue Type: Improvement Components: Client - HTTP Reporter: Vitalii Diravka Assignee: Vitalii Diravka HttpHelperFunctions still uses old JSON reader. Need to swtich it to the new EVF based reader -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (DRILL-8015) Add MongoDB Metastore implementation
[ https://issues.apache.org/jira/browse/DRILL-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton closed DRILL-8015. --- Fix Version/s: 1.20.0 Resolution: Fixed > Add MongoDB Metastore implementation > > > Key: DRILL-8015 > URL: https://issues.apache.org/jira/browse/DRILL-8015 > Project: Apache Drill > Issue Type: Improvement > Components: Metadata >Reporter: wtf >Assignee: wtf >Priority: Minor > Fix For: 1.20.0 > > > Add a NoSQL Metastore implementation -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (DRILL-8169) Add UDFs to HTTP Plugin to Facilitate Joins
[ https://issues.apache.org/jira/browse/DRILL-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vitalii Diravka resolved DRILL-8169. Resolution: Fixed > Add UDFs to HTTP Plugin to Facilitate Joins > --- > > Key: DRILL-8169 > URL: https://issues.apache.org/jira/browse/DRILL-8169 > Project: Apache Drill > Issue Type: Improvement > Components: Storage - Other >Affects Versions: 1.20.0 >Reporter: Charles Givre >Assignee: Charles Givre >Priority: Major > Fix For: 2.0.0 > > > There are some situations where a user might want to join data with an API > result and the pushdowns prevent that from happening. The main situation > where this happens is when > an API has parameters which are part of the URL AND these parameters are > dynamically populated via a join. > In this case, there are two functions `http_get_url` and `http_get` which you > can use to faciliate these joins. > * `http_get('', )`: This function accepts a > storage plugin as input and an optional list of parameters to include in a > URL. > * `http_get_url(, )`: This function works in the same way except > that it does not pull any configuration information from existing storage > plugins. > ### Example Queries > Let's say that you have a storage plugin called `github` with an endpoint > called `repos` which points to the url: https://github.com/orgs/\{org}/repos. > It is easy enough to > write a query like this: > ```sql > SELECT * > FROM github.repos > WHERE org='apache' > ``` > However, if you had a file with organizations and wanted to join this with > the API, the query would fail. Using the functions listed above you could get > this data as follows: > ```sql > SELECT http_get('github.repos', `org`) > FROM dfs.`some_data.csvh` > ``` > or > ```sql > SELECT http_get('https://github.com/orgs/\{org}/repos', `org`) > FROM dfs.`some_data.csvh` > ``` > ** WARNING: This functionality will execute an HTTP Request FOR EVERY ROW IN > YOUR DATA. Use with caution. ** > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (DRILL-8229) Add Parameter to Skip Malformed Records to HTTP UDF
[ https://issues.apache.org/jira/browse/DRILL-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vitalii Diravka resolved DRILL-8229. Resolution: Fixed > Add Parameter to Skip Malformed Records to HTTP UDF > > > Key: DRILL-8229 > URL: https://issues.apache.org/jira/browse/DRILL-8229 > Project: Apache Drill > Issue Type: Improvement > Components: Functions - Drill >Affects Versions: 1.20.1 >Reporter: Charles Givre >Assignee: Charles Givre >Priority: Minor > Fix For: 1.20.2 > > > The http_get and http_request UDFs were not using the JSON parameter to skip > malformed records. This PR fixes that. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (DRILL-8190) Mongo query: "Schema change not currently supported for schemas with complex types"
[ https://issues.apache.org/jira/browse/DRILL-8190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542492#comment-17542492 ] James Turton commented on DRILL-8190: - Hi [~clarkddc] have you been able to workaround this in the interim applying the following config? {code:java} "pluginOptimizations": { "supportsProjectPushdown": false } {code} > Mongo query: "Schema change not currently supported for schemas with complex > types" > --- > > Key: DRILL-8190 > URL: https://issues.apache.org/jira/browse/DRILL-8190 > Project: Apache Drill > Issue Type: Bug > Components: Server >Affects Versions: Future, 1.20.0 > Environment: RHEL 7: Linux 3.10.0-1160.59.1.el7.x86_64 #1 SMP Wed > Feb 16 12:17:35 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Daniel Clark >Priority: Major > Fix For: Future > > Attachments: customGrounds.gz, log_4.txt, profile_4.json > > > I'm attempting to run this mongo query that ran successfully in Drill 1.19 > with the 1.21.0-SNAPSHOT build. > > SELECT `Elements_Efforts`.`EffortTypeName` AS `EffortTypeName`, > `Elements`.`ElementSubTypeName` AS `ElementSubTypeName`, > `Elements`.`ElementTypeName` AS `ElementTypeName`, > `Elements`.`PlanID` AS `PlanID` > FROM `mongo.grounds`.`Elements` `Elements` > INNER JOIN `mongo.grounds`.`Elements_Efforts` `Elements_Efforts` ON > (`Elements`.`_id` = `Elements_Efforts`.`_id`) > WHERE (`Elements`.`PlanID` = '1623263140') > GROUP BY `Elements_Efforts`.`EffortTypeName`, > `Elements`.`ElementSubTypeName`, > `Elements`.`ElementTypeName`, > `Elements`.`PlanID` > > I'm getting this error message: UserRemoteException : SYSTEM ERROR: > RuntimeException: Schema change not currently supported for schemas with > complex types. I've attached the log, profile, and a mongodb dump containing > the relevant datasets. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (DRILL-8232) Add support for user credentials to VaultCredentialsProvider
[ https://issues.apache.org/jira/browse/DRILL-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17542468#comment-17542468 ] ASF GitHub Bot commented on DRILL-8232: --- jnturton commented on PR #2558: URL: https://github.com/apache/drill/pull/2558#issuecomment-1138533245 Please note that this PR includes a breaking change in that the Vault credentials provider switches from using a static Vault token to using a static app role to obtain tokens dynamically. > Add support for user credentials to VaultCredentialsProvider > > > Key: DRILL-8232 > URL: https://issues.apache.org/jira/browse/DRILL-8232 > Project: Apache Drill > Issue Type: Improvement > Components: Security >Reporter: James Turton >Assignee: James Turton >Priority: Minor > Fix For: 2.0.0 > > > The VaultCredentialsProvider can join the PlainCredentialsProvider in > supporting user credentials, credentials that stored for each each Drill > query user, by constructing a Vault secret path dynamically based on the name > of the query user. -- This message was sent by Atlassian Jira (v8.20.7#820007)