[jira] [Commented] (DRILL-8436) Upgrade Hadoop 3.2.4 -> 3.3.6

2023-08-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-8436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758816#comment-17758816
 ] 

ASF GitHub Bot commented on DRILL-8436:
---

jnturton commented on code in PR #2821:
URL: https://github.com/apache/drill/pull/2821#discussion_r1305095341


##
exec/jdbc-all/pom.xml:
##
@@ -679,86 +688,85 @@
 
   *:*
   
-**/logback.xml

Review Comment:
   Another list that's been sorted alphabetically in this PR.





> Upgrade Hadoop 3.2.4 -> 3.3.6
> -
>
> Key: DRILL-8436
> URL: https://issues.apache.org/jira/browse/DRILL-8436
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: library
>Affects Versions: 1.21.1
>Reporter: James Turton
>Assignee: James Turton
>Priority: Minor
> Fix For: 1.22.0
>
>
> Hadoop is upgraded to 3.3.6. Jetty is upgraded to 9.4.51.v20230217.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DRILL-8436) Upgrade Hadoop 3.2.4 -> 3.3.6

2023-08-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-8436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758815#comment-17758815
 ] 

ASF GitHub Bot commented on DRILL-8436:
---

jnturton commented on code in PR #2821:
URL: https://github.com/apache/drill/pull/2821#discussion_r1305093910


##
exec/jdbc-all/pom.xml:
##
@@ -388,51 +396,52 @@
   *:*
 
 
-  io.protostuff:*

Review Comment:
   @cgivre All the diff noise here comes about because I decided to sort this 
list alphabetically in the hopes that contributors will keep it sorted from 
here on, making checking what's in it that much easier. I can revert the 
sorting if preferred though.





> Upgrade Hadoop 3.2.4 -> 3.3.6
> -
>
> Key: DRILL-8436
> URL: https://issues.apache.org/jira/browse/DRILL-8436
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: library
>Affects Versions: 1.21.1
>Reporter: James Turton
>Assignee: James Turton
>Priority: Minor
> Fix For: 1.22.0
>
>
> Hadoop is upgraded to 3.3.6. Jetty is upgraded to 9.4.51.v20230217.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DRILL-8436) Upgrade Hadoop 3.2.4 -> 3.3.6

2023-08-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-8436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758812#comment-17758812
 ] 

ASF GitHub Bot commented on DRILL-8436:
---

jnturton commented on code in PR #2821:
URL: https://github.com/apache/drill/pull/2821#discussion_r1305092866


##
contrib/storage-phoenix/pom.xml:
##
@@ -29,9 +29,9 @@
   Drill : Contrib : Storage : Phoenix
 
   
-5.1.2
+5.1.3
  Upgrade Hadoop 3.2.4 -> 3.3.6
> -
>
> Key: DRILL-8436
> URL: https://issues.apache.org/jira/browse/DRILL-8436
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: library
>Affects Versions: 1.21.1
>Reporter: James Turton
>Assignee: James Turton
>Priority: Minor
> Fix For: 1.22.0
>
>
> Hadoop is upgraded to 3.3.6. Jetty is upgraded to 9.4.51.v20230217.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DRILL-8453) Add XSD Support to XML Reader (Part 1)

2023-08-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758621#comment-17758621
 ] 

ASF GitHub Bot commented on DRILL-8453:
---

mbeckerle commented on PR #2824:
URL: https://github.com/apache/drill/pull/2824#issuecomment-1691830388

   I'm ok with merging this. It's still a bit of a work-in-progress (hence the 
Part 1) 
   
   Some TODOs in here are mine. I do intend to get to them, but no reason to 
hold up this change set for that. 
   
   I highly recommend that you squash these 15 commits together into one 
coherent commit rather than commit all 15 as is. 
   




> Add XSD Support to XML Reader (Part 1)
> --
>
> Key: DRILL-8453
> URL: https://issues.apache.org/jira/browse/DRILL-8453
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Format - XML
>Affects Versions: 1.21.1
>Reporter: Charles Givre
>Assignee: Charles Givre
>Priority: Major
> Fix For: 1.21.2
>
>
> This PR is a part of a series to add better support for reading XML data to 
> Drill.  One of the main challenges is that XML data does not have a way of 
> inferring data types, nor does it have a way of detecting arrays.  
> The only way to do this really well is to have a schema.  Some XML files link 
> a schema definition file to the data.  This PR adds the capability for Drill 
> to map XSD schema files into Drill schemas.  
> The current plan is as follows: Part 1 of this PR simply adds the reader but 
> adds no new user detectable functionality.  Part 2 will include the actual 
> integration with the XML reader.  Part 3 will include the ability to read 
> arrays.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DRILL-8420) Remove Guava shading and patching

2023-08-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758577#comment-17758577
 ] 

ASF GitHub Bot commented on DRILL-8420:
---

jnturton commented on PR #2786:
URL: https://github.com/apache/drill/pull/2786#issuecomment-1691627763

   > @jnturton Is this PR still relevant?
   
   Yes, I'm going to resurrect it after all the other clean up and upgrade PRs 
are in.




> Remove Guava shading and patching
> -
>
> Key: DRILL-8420
> URL: https://issues.apache.org/jira/browse/DRILL-8420
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Tools, Build  Test
>Affects Versions: 1.21.0
>Reporter: James Turton
>Assignee: James Turton
>Priority: Major
> Fix For: 1.22.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DRILL-8454) Disable unsupported MapR profile and plugin

2023-08-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-8454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758572#comment-17758572
 ] 

ASF GitHub Bot commented on DRILL-8454:
---

jnturton opened a new pull request, #2825:
URL: https://github.com/apache/drill/pull/2825

   # [DRILL-8454](https://issues.apache.org/jira/browse/DRILL-8454): Disable 
unsupported MapR profile and plugin
   
   ## Description
   
   The MapR build profile and format plugin, which fell out of support in the 
open source Drill codebase years ago, are disabled. Drill users needing support 
for these components should contact HPE.
   
   ## Documentation
   See the HPE Ezmeral docs.
   
   ## Testing
   Build and unit tests of remaining modules pass.
   




> Disable unsupported MapR profile and plugin
> ---
>
> Key: DRILL-8454
> URL: https://issues.apache.org/jira/browse/DRILL-8454
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Tools, Build  Test
>Affects Versions: 1.21.1
>Reporter: James Turton
>Assignee: James Turton
>Priority: Minor
> Fix For: 1.22.0
>
>
> The MapR build profile and format plugin, which fell out of support in the 
> open source Drill codebase years ago, are disabled. Drill users needing 
> support for these components should contact HPE.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (DRILL-8454) Disable unsupported MapR profile and plugin

2023-08-24 Thread James Turton (Jira)
James Turton created DRILL-8454:
---

 Summary: Disable unsupported MapR profile and plugin
 Key: DRILL-8454
 URL: https://issues.apache.org/jira/browse/DRILL-8454
 Project: Apache Drill
  Issue Type: Improvement
  Components: Tools, Build  Test
Affects Versions: 1.21.1
Reporter: James Turton
Assignee: James Turton
 Fix For: 1.22.0


The MapR build profile and format plugin, which fell out of support in the open 
source Drill codebase years ago, are disabled. Drill users needing support for 
these components should contact HPE.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DRILL-8453) Add XSD Support to XML Reader (Part 1)

2023-08-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758547#comment-17758547
 ] 

ASF GitHub Bot commented on DRILL-8453:
---

cgivre commented on code in PR #2824:
URL: https://github.com/apache/drill/pull/2824#discussion_r1304230698


##
contrib/format-xml/src/test/resources/logback-test.xml:
##
@@ -0,0 +1,69 @@
+
+
+
+  
+
+  
+true
+1
+true
+${LILITH_HOSTNAME:-localhost}
+  

Review Comment:
   This is a file which should have not been included in the PR. ;-). 





> Add XSD Support to XML Reader (Part 1)
> --
>
> Key: DRILL-8453
> URL: https://issues.apache.org/jira/browse/DRILL-8453
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Format - XML
>Affects Versions: 1.21.1
>Reporter: Charles Givre
>Assignee: Charles Givre
>Priority: Major
> Fix For: 1.21.2
>
>
> This PR is a part of a series to add better support for reading XML data to 
> Drill.  One of the main challenges is that XML data does not have a way of 
> inferring data types, nor does it have a way of detecting arrays.  
> The only way to do this really well is to have a schema.  Some XML files link 
> a schema definition file to the data.  This PR adds the capability for Drill 
> to map XSD schema files into Drill schemas.  
> The current plan is as follows: Part 1 of this PR simply adds the reader but 
> adds no new user detectable functionality.  Part 2 will include the actual 
> integration with the XML reader.  Part 3 will include the ability to read 
> arrays.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DRILL-8420) Remove Guava shading and patching

2023-08-24 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758546#comment-17758546
 ] 

ASF GitHub Bot commented on DRILL-8420:
---

cgivre commented on PR #2786:
URL: https://github.com/apache/drill/pull/2786#issuecomment-1691559682

   @jnturton Is this PR still relevant?




> Remove Guava shading and patching
> -
>
> Key: DRILL-8420
> URL: https://issues.apache.org/jira/browse/DRILL-8420
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Tools, Build  Test
>Affects Versions: 1.21.0
>Reporter: James Turton
>Assignee: James Turton
>Priority: Major
> Fix For: 1.22.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)