[jira] [Commented] (DRILL-5892) Distinguish between states for query statistics exposed via JMX
[
https://issues.apache.org/jira/browse/DRILL-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234136#comment-16234136
]
Josiah Yan commented on DRILL-5892:
---
[~kkhatua] could I take a shot at this, if no one has started work on it? It
looks quite doable.
> Distinguish between states for query statistics exposed via JMX
> ---
>
> Key: DRILL-5892
> URL: https://issues.apache.org/jira/browse/DRILL-5892
> Project: Apache Drill
> Issue Type: Improvement
>Affects Versions: 1.11.0
>Reporter: Kunal Khatua
>Priority: Major
> Fix For: Future
>
>
> Currently, the JMX metrics exposed
> {code:java}
> metrics:name=drill.queries.completed
> metrics:name=drill.queries.running
> metrics:name=drill.queries.enqueued
> {code}
> The completed queries, however, do not distinguish between the outcomes of
> the completed queries.
> The proposal is to also provide success, failed, cancelled and timeout (yet
> to implement) states.
> {code:xml}
> "metrics:name=drill.queries" : {
> "completed" : {
> "successful": INTEGER,
> "failed": INTEGER,
> "cancelled": INTEGER,
> "timeout": INTEGER
> },
> "running" : INTEGER,
> "enqueued" : {
> "small" : INTEGER,
> "large" : INTEGER
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DRILL-5892) Distinguish between states for query statistics exposed via JMX
[
https://issues.apache.org/jira/browse/DRILL-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234111#comment-16234111
]
Josiah Yan commented on DRILL-5892:
---
Digging into
{{/drill/exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java}},
not sure if {{timeout}} refers to failure due to timeout in a query queue, or
a timeout in a Drillbit RPC.
> Distinguish between states for query statistics exposed via JMX
> ---
>
> Key: DRILL-5892
> URL: https://issues.apache.org/jira/browse/DRILL-5892
> Project: Apache Drill
> Issue Type: Improvement
>Affects Versions: 1.11.0
>Reporter: Kunal Khatua
>Priority: Major
> Fix For: Future
>
>
> Currently, the JMX metrics exposed
> {code:java}
> metrics:name=drill.queries.completed
> metrics:name=drill.queries.running
> metrics:name=drill.queries.enqueued
> {code}
> The completed queries, however, do not distinguish between the outcomes of
> the completed queries.
> The proposal is to also provide success, failed, cancelled and timeout (yet
> to implement) states.
> {code:xml}
> "metrics:name=drill.queries" : {
> "completed" : {
> "successful": INTEGER,
> "failed": INTEGER,
> "cancelled": INTEGER,
> "timeout": INTEGER
> },
> "running" : INTEGER,
> "enqueued" : {
> "small" : INTEGER,
> "large" : INTEGER
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DRILL-5645) negation of expression causes null pointer exception
[
https://issues.apache.org/jira/browse/DRILL-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111038#comment-16111038
]
Josiah Yan commented on DRILL-5645:
---
Reproduced, getting stacktrace
{code}
[Error Id: bea50afd-515c-4afb-be0f-b07849945dee on psf806i3:31010]
org.apache.drill.common.exceptions.UserException: SYSTEM ERROR:
NullPointerException
[Error Id: bea50afd-515c-4afb-be0f-b07849945dee on psf806i3:31010]
at
org.apache.drill.common.exceptions.UserException$Builder.build(UserException.java:550)
~[drill-common-1.11.0.jar:1.11.0]
at
org.apache.drill.exec.work.foreman.Foreman$ForemanResult.close(Foreman.java:847)
[drill-java-exec-1.11.0.jar:1.11.0]
at
org.apache.drill.exec.work.foreman.Foreman.moveToState(Foreman.java:977)
[drill-java-exec-1.11.0.jar:1.11.0]
at org.apache.drill.exec.work.foreman.Foreman.run(Foreman.java:297)
[drill-java-exec-1.11.0.jar:1.11.0]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[na:1.8.0_131]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[na:1.8.0_131]
at java.lang.Thread.run(Thread.java:748) [na:1.8.0_131]
Caused by: org.apache.drill.exec.work.foreman.ForemanException: Unexpected
exception during fragment initialization: Internal error: Error while applying
rule ReduceExpressionsRule_Project, args [rel#12:L
ogicalProject.NONE.ANY([]).[](input=rel#11:Subset#0.NONE.ANY([]).[0],EXPR$0=-(*(2,
2)))]
... 4 common frames omitted
Caused by: java.lang.AssertionError: Internal error: Error while applying rule
ReduceExpressionsRule_Project, args
[rel#12:LogicalProject.NONE.ANY([]).[](input=rel#11:Subset#0.NONE.ANY([]).[0],EXPR$0=-(*(2,
2)))]
at org.apache.calcite.util.Util.newInternal(Util.java:792)
~[calcite-core-1.4.0-drill-r21.jar:1.4.0-drill-r21]
at
org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:251)
~[calcite-core-1.4.0-drill-r21.jar:1.4.0-drill-r21]
at
org.apache.calcite.plan.volcano.VolcanoPlanner.findBestExp(VolcanoPlanner.java:811)
~[calcite-core-1.4.0-drill-r21.jar:1.4.0-drill-r21]
at
org.apache.calcite.tools.Programs$RuleSetProgram.run(Programs.java:310)
~[calcite-core-1.4.0-drill-r21.jar:1.4.0-drill-r21]
at
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.transform(DefaultSqlHandler.java:401)
~[drill-java-exec-1.11.0.jar:1.11.0]
at
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.transform(DefaultSqlHandler.java:343)
~[drill-java-exec-1.11.0.jar:1.11.0]
at
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.convertToRawDrel(DefaultSqlHandler.java:242)
~[drill-java-exec-1.11.0.jar:1.11.0]
at
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.convertToDrel(DefaultSqlHandler.java:292)
~[drill-java-exec-1.11.0.jar:1.11.0]
at
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.getPlan(DefaultSqlHandler.java:169)
~[drill-java-exec-1.11.0.jar:1.11.0]
at
org.apache.drill.exec.planner.sql.DrillSqlWorker.getQueryPlan(DrillSqlWorker.java:131)
~[drill-java-exec-1.11.0.jar:1.11.0]
at
org.apache.drill.exec.planner.sql.DrillSqlWorker.getPlan(DrillSqlWorker.java:79)
~[drill-java-exec-1.11.0.jar:1.11.0]
at org.apache.drill.exec.work.foreman.Foreman.runSQL(Foreman.java:1050)
[drill-java-exec-1.11.0.jar:1.11.0]
at org.apache.drill.exec.work.foreman.Foreman.run(Foreman.java:280)
[drill-java-exec-1.11.0.jar:1.11.0]
... 3 common frames omitted
Caused by: java.lang.NullPointerException: null
at
org.apache.drill.exec.planner.logical.DrillOptiq$RexToDrill.visitCall(DrillOptiq.java:170)
~[drill-java-exec-1.11.0.jar:1.11.0]
at
org.apache.drill.exec.planner.logical.DrillOptiq$RexToDrill.visitCall(DrillOptiq.java:97)
~[drill-java-exec-1.11.0.jar:1.11.0]
at org.apache.calcite.rex.RexCall.accept(RexCall.java:107)
~[calcite-core-1.4.0-drill-r21.jar:1.4.0-drill-r21]
at
org.apache.drill.exec.planner.logical.DrillOptiq.toDrill(DrillOptiq.java:94)
~[drill-java-exec-1.11.0.jar:1.11.0]
at
org.apache.drill.exec.planner.logical.DrillOptiq.toDrill(DrillOptiq.java:81)
~[drill-java-exec-1.11.0.jar:1.11.0]
at
org.apache.drill.exec.planner.logical.DrillConstExecutor.reduce(DrillConstExecutor.java:124)
~[drill-java-exec-1.11.0.jar:1.11.0]
at
org.apache.calcite.rel.rules.ReduceExpressionsRule.reduceExpressions(ReduceExpressionsRule.java:502)
~[calcite-core-1.4.0-drill-r21.jar:1.4.0-drill-r21]
at
org.apache.calcite.rel.rules.ReduceExpressionsRule$1.onMatch(ReduceExpressionsRule.java:243)
~[calcite-core-1.4.0-drill-r21.jar:1.4.0-drill-r21]
at
org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:228)
~[calcite-core-1.4.0-drill-r21.jar:1.4.0-drill-r21]
... 14
