[jira] [Commented] (DRILL-5911) Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json library
[
https://issues.apache.org/jira/browse/DRILL-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225742#comment-16225742
]
ASF GitHub Bot commented on DRILL-5911:
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1012
> Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json
> library
> --
>
> Key: DRILL-5911
> URL: https://issues.apache.org/jira/browse/DRILL-5911
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.11.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Volodymyr Vysotskyi
> Labels: ready-to-commit
> Fix For: 1.12.0
>
>
> Currently, {{drill-gis}} module uses {{esri-geometry-api}} library version
> 1.2.1. This version of the library has the dependency on {{org.json}} library:
> {noformat}
> [INFO] org.apache.drill.contrib:drill-gis:jar:1.12.0-SNAPSHOT
> [INFO] \- com.esri.geometry:esri-geometry-api:jar:1.2.1:compile
> [INFO]\- org.json:json:jar:20090211:compile
> {noformat}
> In {{esri-geometry-api}} v.2.0.0 this dependency on {{org.json}} was removed:
> https://github.com/Esri/geometry-api-java/commit/9bedde397f2f61675bc687b95875893aa7cd7f2f.
>
> So we need also update the version of this library to avoid transitive
> dependency on {{org.json}} form {{drill-gis}} module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DRILL-5911) Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json library
[
https://issues.apache.org/jira/browse/DRILL-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223740#comment-16223740
]
ASF GitHub Bot commented on DRILL-5911:
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1012
OK. LGTM.
> Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json
> library
> --
>
> Key: DRILL-5911
> URL: https://issues.apache.org/jira/browse/DRILL-5911
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.11.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Volodymyr Vysotskyi
> Labels: ready-to-commit
> Fix For: 1.12.0
>
>
> Currently, {{drill-gis}} module uses {{esri-geometry-api}} library version
> 1.2.1. This version of the library has the dependency on {{org.json}} library:
> {noformat}
> [INFO] org.apache.drill.contrib:drill-gis:jar:1.12.0-SNAPSHOT
> [INFO] \- com.esri.geometry:esri-geometry-api:jar:1.2.1:compile
> [INFO]\- org.json:json:jar:20090211:compile
> {noformat}
> In {{esri-geometry-api}} v.2.0.0 this dependency on {{org.json}} was removed:
> https://github.com/Esri/geometry-api-java/commit/9bedde397f2f61675bc687b95875893aa7cd7f2f.
>
> So we need also update the version of this library to avoid transitive
> dependency on {{org.json}} form {{drill-gis}} module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DRILL-5911) Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json library
[
https://issues.apache.org/jira/browse/DRILL-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223724#comment-16223724
]
ASF GitHub Bot commented on DRILL-5911:
---
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/1012
@vrozov, sorry for the misunderstanding. Currently, it is also not
supported.
> Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json
> library
> --
>
> Key: DRILL-5911
> URL: https://issues.apache.org/jira/browse/DRILL-5911
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.11.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Volodymyr Vysotskyi
> Labels: ready-to-commit
> Fix For: 1.12.0
>
>
> Currently, {{drill-gis}} module uses {{esri-geometry-api}} library version
> 1.2.1. This version of the library has the dependency on {{org.json}} library:
> {noformat}
> [INFO] org.apache.drill.contrib:drill-gis:jar:1.12.0-SNAPSHOT
> [INFO] \- com.esri.geometry:esri-geometry-api:jar:1.2.1:compile
> [INFO]\- org.json:json:jar:20090211:compile
> {noformat}
> In {{esri-geometry-api}} v.2.0.0 this dependency on {{org.json}} was removed:
> https://github.com/Esri/geometry-api-java/commit/9bedde397f2f61675bc687b95875893aa7cd7f2f.
>
> So we need also update the version of this library to avoid transitive
> dependency on {{org.json}} form {{drill-gis}} module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DRILL-5911) Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json library
[
https://issues.apache.org/jira/browse/DRILL-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223589#comment-16223589
]
ASF GitHub Bot commented on DRILL-5911:
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1012
@vvysotskyi I refer to JSON format that ESRI supports by itself.
> Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json
> library
> --
>
> Key: DRILL-5911
> URL: https://issues.apache.org/jira/browse/DRILL-5911
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.11.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Volodymyr Vysotskyi
> Labels: ready-to-commit
> Fix For: 1.12.0
>
>
> Currently, {{drill-gis}} module uses {{esri-geometry-api}} library version
> 1.2.1. This version of the library has the dependency on {{org.json}} library:
> {noformat}
> [INFO] org.apache.drill.contrib:drill-gis:jar:1.12.0-SNAPSHOT
> [INFO] \- com.esri.geometry:esri-geometry-api:jar:1.2.1:compile
> [INFO]\- org.json:json:jar:20090211:compile
> {noformat}
> In {{esri-geometry-api}} v.2.0.0 this dependency on {{org.json}} was removed:
> https://github.com/Esri/geometry-api-java/commit/9bedde397f2f61675bc687b95875893aa7cd7f2f.
>
> So we need also update the version of this library to avoid transitive
> dependency on {{org.json}} form {{drill-gis}} module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DRILL-5911) Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json library
[
https://issues.apache.org/jira/browse/DRILL-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223370#comment-16223370
]
ASF GitHub Bot commented on DRILL-5911:
---
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/1012
@vrozov, If you meant [geojson](http://geojson.org) when saying about JSON
format support, then my answer - not, it is not supported yet.
> Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json
> library
> --
>
> Key: DRILL-5911
> URL: https://issues.apache.org/jira/browse/DRILL-5911
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.11.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Volodymyr Vysotskyi
> Labels: ready-to-commit
> Fix For: 1.12.0
>
>
> Currently, {{drill-gis}} module uses {{esri-geometry-api}} library version
> 1.2.1. This version of the library has the dependency on {{org.json}} library:
> {noformat}
> [INFO] org.apache.drill.contrib:drill-gis:jar:1.12.0-SNAPSHOT
> [INFO] \- com.esri.geometry:esri-geometry-api:jar:1.2.1:compile
> [INFO]\- org.json:json:jar:20090211:compile
> {noformat}
> In {{esri-geometry-api}} v.2.0.0 this dependency on {{org.json}} was removed:
> https://github.com/Esri/geometry-api-java/commit/9bedde397f2f61675bc687b95875893aa7cd7f2f.
>
> So we need also update the version of this library to avoid transitive
> dependency on {{org.json}} form {{drill-gis}} module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DRILL-5911) Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json library
[
https://issues.apache.org/jira/browse/DRILL-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222931#comment-16222931
]
ASF GitHub Bot commented on DRILL-5911:
---
Github user julianhyde commented on the issue:
https://github.com/apache/drill/pull/1012
If I recall correctly -- we went through this because Calcite uses ESRI --
the only change was to remove org.json. It's a pretty important change because
org.json is not compatible with Apache license. And I think org.json data
structures were used in the API (e.g. as arguments and method return values) so
obsoleting it would be an API change.
> Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json
> library
> --
>
> Key: DRILL-5911
> URL: https://issues.apache.org/jira/browse/DRILL-5911
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.11.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Volodymyr Vysotskyi
> Labels: ready-to-commit
> Fix For: 1.12.0
>
>
> Currently, {{drill-gis}} module uses {{esri-geometry-api}} library version
> 1.2.1. This version of the library has the dependency on {{org.json}} library:
> {noformat}
> [INFO] org.apache.drill.contrib:drill-gis:jar:1.12.0-SNAPSHOT
> [INFO] \- com.esri.geometry:esri-geometry-api:jar:1.2.1:compile
> [INFO]\- org.json:json:jar:20090211:compile
> {noformat}
> In {{esri-geometry-api}} v.2.0.0 this dependency on {{org.json}} was removed:
> https://github.com/Esri/geometry-api-java/commit/9bedde397f2f61675bc687b95875893aa7cd7f2f.
>
> So we need also update the version of this library to avoid transitive
> dependency on {{org.json}} form {{drill-gis}} module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DRILL-5911) Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json library
[
https://issues.apache.org/jira/browse/DRILL-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222693#comment-16222693
]
ASF GitHub Bot commented on DRILL-5911:
---
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/1012
@vrozov As I understand from the [release
notes](https://github.com/Esri/geometry-api-java/releases/tag/v2.0.0), the main
reason for the major version change was changing the interface due to the
removing org.json dependency. Gis storage plugin provides UDF functions, and
they are covered by the existing unit tests, so since all tests are passed this
change does not break drill-gis.
I think this change should be merged in the current release, but I don't
know when other PR will be merged. Also, another pull request isn't affected by
changing esri-geometry-api library, ie this change does not break changes made
there.
> Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json
> library
> --
>
> Key: DRILL-5911
> URL: https://issues.apache.org/jira/browse/DRILL-5911
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.11.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Volodymyr Vysotskyi
> Labels: ready-to-commit
> Fix For: 1.12.0
>
>
> Currently, {{drill-gis}} module uses {{esri-geometry-api}} library version
> 1.2.1. This version of the library has the dependency on {{org.json}} library:
> {noformat}
> [INFO] org.apache.drill.contrib:drill-gis:jar:1.12.0-SNAPSHOT
> [INFO] \- com.esri.geometry:esri-geometry-api:jar:1.2.1:compile
> [INFO]\- org.json:json:jar:20090211:compile
> {noformat}
> In {{esri-geometry-api}} v.2.0.0 this dependency on {{org.json}} was removed:
> https://github.com/Esri/geometry-api-java/commit/9bedde397f2f61675bc687b95875893aa7cd7f2f.
>
> So we need also update the version of this library to avoid transitive
> dependency on {{org.json}} form {{drill-gis}} module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DRILL-5911) Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json library
[
https://issues.apache.org/jira/browse/DRILL-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222598#comment-16222598
]
ASF GitHub Bot commented on DRILL-5911:
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1012
@vvysotskyi It is a major version change of the dependency, but except for
the pom file changes, there are no other changes. It will be good to understand
what triggered a major version change (do release notes cover that?) and how it
may affect gis plugin. Also, there is another PR on the review related to gis,
can this change be combined with the other changes?
> Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json
> library
> --
>
> Key: DRILL-5911
> URL: https://issues.apache.org/jira/browse/DRILL-5911
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.11.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Volodymyr Vysotskyi
> Labels: ready-to-commit
> Fix For: 1.12.0
>
>
> Currently, {{drill-gis}} module uses {{esri-geometry-api}} library version
> 1.2.1. This version of the library has the dependency on {{org.json}} library:
> {noformat}
> [INFO] org.apache.drill.contrib:drill-gis:jar:1.12.0-SNAPSHOT
> [INFO] \- com.esri.geometry:esri-geometry-api:jar:1.2.1:compile
> [INFO]\- org.json:json:jar:20090211:compile
> {noformat}
> In {{esri-geometry-api}} v.2.0.0 this dependency on {{org.json}} was removed:
> https://github.com/Esri/geometry-api-java/commit/9bedde397f2f61675bc687b95875893aa7cd7f2f.
>
> So we need also update the version of this library to avoid transitive
> dependency on {{org.json}} form {{drill-gis}} module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DRILL-5911) Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json library
[
https://issues.apache.org/jira/browse/DRILL-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222510#comment-16222510
]
ASF GitHub Bot commented on DRILL-5911:
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1012
+1, LGTM.
> Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json
> library
> --
>
> Key: DRILL-5911
> URL: https://issues.apache.org/jira/browse/DRILL-5911
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.11.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Volodymyr Vysotskyi
> Fix For: 1.12.0
>
>
> Currently, {{drill-gis}} module uses {{esri-geometry-api}} library version
> 1.2.1. This version of the library has the dependency on {{org.json}} library:
> {noformat}
> [INFO] org.apache.drill.contrib:drill-gis:jar:1.12.0-SNAPSHOT
> [INFO] \- com.esri.geometry:esri-geometry-api:jar:1.2.1:compile
> [INFO]\- org.json:json:jar:20090211:compile
> {noformat}
> In {{esri-geometry-api}} v.2.0.0 this dependency on {{org.json}} was removed:
> https://github.com/Esri/geometry-api-java/commit/9bedde397f2f61675bc687b95875893aa7cd7f2f.
>
> So we need also update the version of this library to avoid transitive
> dependency on {{org.json}} form {{drill-gis}} module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (DRILL-5911) Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json library
[
https://issues.apache.org/jira/browse/DRILL-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222311#comment-16222311
]
ASF GitHub Bot commented on DRILL-5911:
---
GitHub user vvysotskyi opened a pull request:
https://github.com/apache/drill/pull/1012
DRILL-5911: Upgrade esri-geometry-api version to 2.0.0 to avoid depen…
…dency on org.json library
Please see [DRILL-5911](https://issues.apache.org/jira/browse/DRILL-5911)
for details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vvysotskyi/drill DRILL-5911
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1012.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1012
commit 87e892515bfd731a088a3e03ffdc0bef184cf29c
Author: Volodymyr Vysotskyi
Date: 2017-10-27T14:45:17Z
DRILL-5911: Upgrade esri-geometry-api version to 2.0.0 to avoid dependency
on org.json library
> Upgrade esri-geometry-api version to 2.0.0 to avoid dependency on org.json
> library
> --
>
> Key: DRILL-5911
> URL: https://issues.apache.org/jira/browse/DRILL-5911
> Project: Apache Drill
> Issue Type: Task
>Affects Versions: 1.11.0
>Reporter: Volodymyr Vysotskyi
>Assignee: Volodymyr Vysotskyi
> Fix For: 1.12.0
>
>
> Currently, {{drill-gis}} module uses {{esri-geometry-api}} library version
> 1.2.1. This version of the library has the dependency on {{org.json}} library:
> {noformat}
> [INFO] org.apache.drill.contrib:drill-gis:jar:1.12.0-SNAPSHOT
> [INFO] \- com.esri.geometry:esri-geometry-api:jar:1.2.1:compile
> [INFO]\- org.json:json:jar:20090211:compile
> {noformat}
> In {{esri-geometry-api}} v.2.0.0 this dependency on {{org.json}} was removed:
> https://github.com/Esri/geometry-api-java/commit/9bedde397f2f61675bc687b95875893aa7cd7f2f.
>
> So we need also update the version of this library to avoid transitive
> dependency on {{org.json}} form {{drill-gis}} module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
